[clang] 66f1dcd - [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

Author: Ten Tzen Date: 2020-07-12T01:37:56-07:00 New Revision: 66f1dcd872dba189ee054fb016f4bff535fb5afc URL: https://github.com/llvm/llvm-project/commit/66f1dcd872dba189ee054fb016f4bff535fb5afc DIFF: https://github.com/llvm/llvm-project/commit/66f1dcd872dba189ee054fb016f4bff535fb5afc.diff

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

This revision was automatically updated to reflect the committed changes. Closed by commit rG66f1dcd872db: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally (authored by tentzen). Changed prior to commit: https://reviews.llvm.org/D77982?vs=257227=277279#toc Repository: rG

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

sameerds added a comment. >> https://github.com/ROCm-Developer-Tools/HIP/blob/master/docs/markdown/hip_kernel_language.md#warp-vote-and-ballot-functions > > I think if the language interface insists on fixing the wave size, then I > think the correct solution is to implement this in the header

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

davezarzycki added a comment. Hello. I have an auto-bisecting multi-stage bot that is failing on two after this change. Can we please revert this or commit a quick fix? FAIL: Clang :: CXX/class/class.compare/class.spaceship/p1.cpp (6232 of 64222) TEST 'Clang ::

[PATCH] D83564: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83564/new/ https://reviews.llvm.org/D83564

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

yaxunl added a comment. In D82087#2146170 , @sameerds wrote: > >> https://github.com/ROCm-Developer-Tools/HIP/blob/master/docs/markdown/hip_kernel_language.md#warp-vote-and-ballot-functions > > > > I think if the language interface insists on fixing the

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

dim created this revision. dim added reviewers: emaste, brooks, rsmith. Herald added subscribers: jfb, krytarowski, arichardson. Herald added a project: clang. Similar to what we have done downstream, some time ago: https://svnweb.freebsd.org/changeset/base/353936 This followed some discussions

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Fine with me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83645/new/ https://reviews.llvm.org/D83645

[PATCH] D83564: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack

This revision was automatically updated to reflect the committed changes. Closed by commit rG65dc97b79eb1: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 65dc97b - [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack

Author: mydeveloperday Date: 2020-07-12T18:44:26+01:00 New Revision: 65dc97b79eb1979c54e7e17c411ea5f58f8dcc9c URL: https://github.com/llvm/llvm-project/commit/65dc97b79eb1979c54e7e17c411ea5f58f8dcc9c DIFF:

[PATCH] D83647: Don't allow mangling substitutions to refer to unrelated entities from different s.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per the ABI rules, substitutable components are symbolic constructs, not the associated mangling character strings, so references to function parameters or

[clang] 02cfa75 - Bump the default target CPU for i386-freebsd to i686

Author: Dimitry Andric Date: 2020-07-12T23:45:22+02:00 New Revision: 02cfa7530d9e7cfd8ea940dab4173afb7938b831 URL: https://github.com/llvm/llvm-project/commit/02cfa7530d9e7cfd8ea940dab4173afb7938b831 DIFF:

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 added a comment. In D82728#2146067 , @dblaikie wrote: > Looks good - thanks for the patch and all the details! Might be worth turning > on by default in the LLVM build (after all the cleanup) Thanks a lot! I don't (think I) have commit access

[clang] 1111678 - [clang] Add -Wsuggest-override

Author: Logan Smith Date: 2020-07-12T16:05:24-07:00 New Revision: 67895d47558989f9f3a593a82527b016c7e7 URL: https://github.com/llvm/llvm-project/commit/67895d47558989f9f3a593a82527b016c7e7 DIFF: https://github.com/llvm/llvm-project/commit/67895d47558989f9f3a593a82527b016c7e7.diff

[PATCH] D82728: [clang] Add -Wsuggest-override

This revision was automatically updated to reflect the committed changes. Closed by commit rG67895d47: [clang] Add -Wsuggest-override (authored by logan-5, committed by dblaikie). Changed prior to commit: https://reviews.llvm.org/D82728?vs=276248=277308#toc Repository: rG LLVM Github

[PATCH] D83647: Don't allow mangling substitutions to refer to unrelated entities from different s.

rsmith added a comment. Hm, I think this is not quite right. For example, given: template struct X {}; template auto f(T a, decltype(a)) { struct A {}; struct B {}; return X(); } decltype(f(0, 0)) g() {} ... I think we won't use a substitution from the first parameter of `f`

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng created this revision. pzheng added reviewers: MaskRay, dblaikie, echristo. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. DriverOption seems to be accidentally removed from integrated_as definition in commit e5158b5

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

This revision was automatically updated to reflect the committed changes. Closed by commit rG02cfa7530d9e: Bump the default target CPU for i386-freebsd to i686 (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83645/new/

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

uweigand added a comment. In D80833#2123508 , @aganea wrote: > In D80833#2109172 , @uweigand wrote: > > > Hmm, with clang-cl it seems the driver is trying to use this: > > Target: s390x-pc-windows-msvc > > which

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

dblaikie added a comment. Is there missing test coverage for this in some way? (how does this patch change the observable behavior of clang? I guess --help would change?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/

[clang] b4dbb37 - [X86] Rename X86_CPU_TYPE_COMPAT_ALIAS/X86_CPU_TYPE_COMPAT/X86_CPU_SUBTYPE_COMPAT macros. NFC

Author: Craig Topper Date: 2020-07-12T17:00:24-07:00 New Revision: b4dbb37f32e554e4d6f118d9ddd87717721ea664 URL: https://github.com/llvm/llvm-project/commit/b4dbb37f32e554e4d6f118d9ddd87717721ea664 DIFF: https://github.com/llvm/llvm-project/commit/b4dbb37f32e554e4d6f118d9ddd87717721ea664.diff

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng added a comment. Actually, this patch won't change --help because it just reduced some duplication by extracting the common part (" the integrated assembler") of the help message into the "help" of "OptOutFFlag". Sorry for the confusion. The real fix here is to restore "integrated_as"

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng updated this revision to Diff 277316. pzheng added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/ https://reviews.llvm.org/D83648 Files: clang/include/clang/Driver/Options.td

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

aqjune added a comment. (renaming variables for readability) %a = select i1 %s, i1 undef, i1 %t %b = xor i1 %s, 1 %c = and i1 %a, %b This series of reasoning happened from a single SimplifyAndInst call: c = a & (s ^ 1) = (a & s) ^ (a & 1); ExpandBinOp =

[clang] c943329 - Revert "Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression"

Author: David Blaikie Date: 2020-07-12T20:29:19-07:00 New Revision: c94332919bd922032e979b3ae3ced5ca5bdf9650 URL: https://github.com/llvm/llvm-project/commit/c94332919bd922032e979b3ae3ced5ca5bdf9650 DIFF: https://github.com/llvm/llvm-project/commit/c94332919bd922032e979b3ae3ced5ca5bdf9650.diff

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

dblaikie added a comment. In D83648#2146472 , @pzheng wrote: > Actually, this patch won't change --help because it just reduced some > duplication by extracting the common part (" the integrated assembler") of > the help message into the "help" of

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie created this revision. dblaikie added reviewers: rnk, llunak, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. I was trying to pick this up a bit when reviewing D48426 (& perhaps D69778 ) -

[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

This revision was automatically updated to reflect the committed changes. Closed by commit rG49e5f603d400: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression (authored by dblaikie). Herald added a subscriber: sstefan1. Changed prior to commit:

[clang] 49e5f60 - Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

Author: David Blaikie Date: 2020-07-12T19:43:24-07:00 New Revision: 49e5f603d40083dce9c05796e3cde3a185c3beba URL: https://github.com/llvm/llvm-project/commit/49e5f603d40083dce9c05796e3cde3a185c3beba DIFF: https://github.com/llvm/llvm-project/commit/49e5f603d40083dce9c05796e3cde3a185c3beba.diff

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added a comment. In D83648#2146472 , @pzheng wrote: > Actually, this patch won't change --help because it just reduced some > duplication by extracting the common part (" the integrated assembler") of > the help message into the "help" of