[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny updated this revision to Diff 278658. jdenny added a comment. Rebased onto latest D83922 . Implemented rejection of `present` if not OpenMP >= 5.1. Cleaned up tests some. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83061/new/

[PATCH] D83999: [CMake][Fuchsia] Include additional tools in the toolchain

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. These are needed on Windows. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83999 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

vsavchenko added a comment. Additionally, I would prefer commit message to be imperative. It is sorta like a rule of a good commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83836/new/ https://reviews.llvm.org/D83836

[PATCH] D77125: [Analyzer] Model return values of container insert and delete operations

baloghadamsoftware updated this revision to Diff 278395. baloghadamsoftware added a comment. Protection agains `Unknown` return values added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77125/new/ https://reviews.llvm.org/D77125 Files:

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 278399. gargvaibhav64 added a comment. The tests weren't failing for me. So, we are possibly missing test coverage. I have made the change now. Also, I would like to add that the current test present in this diff does not fail in the existing system

[PATCH] D83934: [clangd] Always retrieve ProjectInfo from Base in OverlayCDB

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd is returning current working directory for overriden commands. This can cause inconsistencies

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus updated this revision to Diff 278412. walrus added a comment. Remove unused struct definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83855/new/ https://reviews.llvm.org/D83855 Files: clang/lib/AST/StmtPrinter.cpp

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus updated this revision to Diff 278411. walrus added a comment. Simplify code according to suggestions in code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83855/new/ https://reviews.llvm.org/D83855 Files:

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus marked an inline comment as done. walrus added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2011 + Expr *Init = D->getInit(); + if (D->getInitStyle() == VarDecl::CallInit && !isa(Init)) +OS << "("; kadircet wrote: > walrus

[PATCH] D83934: [clangd] Always retrieve ProjectInfo from Base in OverlayCDB

kadircet updated this revision to Diff 278421. kadircet added a comment. - Split comments between implementation and header, and reword. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83934/new/ https://reviews.llvm.org/D83934 Files:

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

ArcsinX added a comment. In D83508#2155322 , @sammccall wrote: > In D83508#2155174 , @ArcsinX wrote: > > > In D83508#2143625 , @sammccall > > wrote: > > > > > Your test

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus updated this revision to Diff 278420. walrus added a comment. Simplify if..else statement, add braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83855/new/ https://reviews.llvm.org/D83855 Files: clang/lib/AST/StmtPrinter.cpp

[clang] a130cf8 - [clang] Fix printing of lambdas with capture expressions

Author: Ilya Golovenko Date: 2020-07-16T12:50:25+02:00 New Revision: a130cf8ae8ab56ba1cfa7edc52b637c9d0c3fd38 URL: https://github.com/llvm/llvm-project/commit/a130cf8ae8ab56ba1cfa7edc52b637c9d0c3fd38 DIFF:

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa130cf8ae8ab: [clang] Fix printing of lambdas with capture expressions (authored by walrus, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77062: [analyzer] Improved zero assumption in CStringChecke::assumeZero

vsavchenko added a comment. It is a good practice in many projects to make commit messages into imperative (i.e. "Improve" instead of "Improving" or "Improved"). Again, not everyone follows it, but it is good to keep it consistent, right? @NoQ knock-knock! Comment at:

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus marked 2 inline comments as done. walrus added a comment. In D83855#2155303 , @kadircet wrote: > thanks, lgtm! Thank you much for the review! I do not have commit access. Could you please commit the changes on my behalf? Ilya Golovenko

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

sammccall added a comment. In D83508#2155335 , @ArcsinX wrote: > In D83508#2155322 , @sammccall wrote: > > > In D83508#2155174 , @ArcsinX wrote: > > > > > In D83508#2143625

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

baloghadamsoftware updated this revision to Diff 278396. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77150/new/ https://reviews.llvm.org/D77150 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 278398. njames93 added a comment. Updated release notes for version bump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files:

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:99 // load vd, (rs1), vm class VUnitStrideLoad fpallares wrote: > I believe that with the changes introduced in the encoding of

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

ArcsinX added a comment. In D83508#2143625 , @sammccall wrote: > Your test cases show two problems with this strategy: > > - we ignore comments and semicolons, but not preprocessor directives (or > disabled preprocessor regions). I think we can fix this

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

fhahn added a comment. I think this change introduced the following warnings, where `auto &` is used for types that are always copied. It would be great if you could take a look. lvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp:8011:24: warning: loop variable 'L' is always a copy because

[PATCH] D83934: [clangd] Always retrieve ProjectInfo from Base in OverlayCDB

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:136 tooling::CompileCommand getFallbackCommand(PathRef File) const override; + /// Note that

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/lib/AST/StmtPrinter.cpp:2014 + if (D->getInitStyle() == VarDecl::CallInit) { +if (!isa(D->getInit())) { + Pre =

[PATCH] D83934: [clangd] Always retrieve ProjectInfo from Base in OverlayCDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG46c921003c2c: [clangd] Always retrieve ProjectInfo from Base in OverlayCDB (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83934/new/

[clang-tools-extra] 46c9210 - [clangd] Always retrieve ProjectInfo from Base in OverlayCDB

Author: Kadir Cetinkaya Date: 2020-07-16T12:33:54+02:00 New Revision: 46c921003c2ce5f1cdc4de9ef613eb001980780c URL: https://github.com/llvm/llvm-project/commit/46c921003c2ce5f1cdc4de9ef613eb001980780c DIFF:

[clang-tools-extra] 2743322 - [clangd] Fix a few gcc warnings [NFC]

Author: Mikael Holmen Date: 2020-07-16T09:36:17+02:00 New Revision: 274332282cb4ce167de8e73fb9c59d2eecd67c25 URL: https://github.com/llvm/llvm-project/commit/274332282cb4ce167de8e73fb9c59d2eecd67c25 DIFF: https://github.com/llvm/llvm-project/commit/274332282cb4ce167de8e73fb9c59d2eecd67c25.diff

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware updated this revision to Diff 278394. baloghadamsoftware added a comment. Protection against `Unknown` added for pointer increments and decrements. No more crashes on `LLVM/Clang`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 added a comment. In D83717#2155066 , @njames93 wrote: > In D83717#2152762 , @gamesh411 wrote: > > > In D83717#2150977 , @njames93 > > wrote: > > > > >

[PATCH] D83901: [clang] Disable a few formatting options for test/

MyDeveloperDay added a comment. clang-format -n warnings before this change in clang/test/Analysis/*.cpp (clang-format -n *.cpp |& grep warning | wc -l) before = 6903 vs after=6595, if it helps I'd say this looks good. Most a very brief review of changes seem to be mainly whitespace/extra

[PATCH] D83914: [clangd] Plan features for FoldingRanges

sammccall added a comment. A few different types of feedback mixed up here :-) Some nitpicks about behavior: these are probably worth discussing. Places where the coverage is incomplete: obviously until we get closer to implementation, how complete this is is up to you. Looking at examples

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

kadircet added a comment. do you have commit access? if not I am happy to land this for you. After having some commits done on your behalf, you can apply for commit access as described in https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rG LLVM Github Monorepo

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

baloghadamsoftware added a comment. Now I made some measurements about the false positives this option adds. For `BitCoin` the increase was `-1`. I do not know how it happened, but it reduced the number of false positives by one. For `LLVM/Clang` the increase was `15` which is less than `4%`

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added a comment. In D83717#2152762 , @gamesh411 wrote: > In D83717#2150977 , @njames93 wrote: > > > Alternatively you could do something like this, though it would be a pain > >

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

vsavchenko added a comment. The same thing with the commit message here, it would be better as just "Change" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83877/new/ https://reviews.llvm.org/D83877

[clang] 90798e0 - Re-enable "[InstCombine] Simplify boolean Phis with const inputs using CFG"

Author: Max Kazantsev Date: 2020-07-16T16:09:08+07:00 New Revision: 90798e09e29012fe316565ea04a1f848c5e40e6e URL: https://github.com/llvm/llvm-project/commit/90798e09e29012fe316565ea04a1f848c5e40e6e DIFF: https://github.com/llvm/llvm-project/commit/90798e09e29012fe316565ea04a1f848c5e40e6e.diff

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

sammccall added a comment. In D83099#2154416 , @davidvancleve wrote: > Thanks for the quick response! Nope, no compile_commands.json files, and they > didn't previously contain .clangd files. Well, thanks for reporting this, this seems like a really

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

sammccall added a comment. In D83508#2155174 , @ArcsinX wrote: > In D83508#2143625 , @sammccall wrote: > > > Your test cases show two problems with this strategy: > > > > - we ignore comments and semicolons, but

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; c-rhodes wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > c-rhodes wrote: > > > > sdesmalen wrote: > > >

[PATCH] D83868: Use TestClangConfig in AST Matchers tests and run them in more configurations

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks for doing this change! I think it's a great step forward for the testing robustness. I'm scared by how many fixme's we have in this file, but at least they're now explicit, rather

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

vsavchenko updated this revision to Diff 278454. vsavchenko added a comment. Rename function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82381/new/ https://reviews.llvm.org/D82381 Files:

[PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP support

hubert.reinterpretcast added a comment. Should we indicate planned removal in the Release Notes for version 11 and actual removal in those for version 12? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83915/new/ https://reviews.llvm.org/D83915

[PATCH] D71124: [RISCV] support clang driver to select cpu

asb accepted this revision. asb added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124 ___ cfe-commits mailing list

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. I would add checks for mapping of `declare target to/link` vars and checked if they work in runtime. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9468-9469 CurSizes, CurMapTypes, PartialStruct); +

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

kadircet added a comment. In D83508#2155322 , @sammccall wrote: > Yeah that makes sense, I guess it just says nothing is selected in that case? > Selecting the `while` is probably marginally better for that exact case, but > selecting nothing seems fine

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, Szelethus, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. Whith the

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 278430. c-rhodes added a comment. Changes: - Documented internal type attributes. - Set `ASTNode = 0` on user-facing `ArmSveVectorBitsAttr` as the internal type attrs are used in the AST. Also removed the case for this from `TypePrinter`. -

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:93 + // Not all transformations will want or need to attach metadata and therefore + // sholud not be requierd to do so. AnyGenerator

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

sammccall added a comment. (Sorry, I know that this is a lot of goalpost-shifting: I think this is now being solved at the right layer and with the right behavior, and it's just a question of finding a clear+fast implementation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:227 continue; + // Ignore tokens in disabled preprocessor sections. + if (Buf.expandedTokens(SM.getMacroArgExpandedLocation(T->location())) I think this is

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

Szelethus added a comment. I suppose LLVM could be a HUGE project? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83942/new/ https://reviews.llvm.org/D83942 ___ cfe-commits mailing list

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

c-rhodes marked 5 inline comments as done. c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.h:138 + llvm::Type *ConvertTypeForMem(QualType T, bool ForBitField = false, +bool EnforceFixedLengthSVEAttribute = false);

[PATCH] D83940: Port HeaderSearch option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83892 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83940 Files:

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

simoncook added a comment. Since this patch replaces 0.8 support with 0.9, it should include an update to the version check in `clang/lib/Driver/ToolChains/Arch/RISCV.cpp` to match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80802/new/

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 278466. c-rhodes added a comment. Changes: - Rebased. - Added comments for args in calls to `ConvertTypeForMem` when `EnforceFixedLengthSVEAttribute` is set and documented `EnforceFixedLengthSVEAttribute`. -

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan added a comment. In D82663#2153834 , @rjmccall wrote: > I don't understand. The problem statement as I understood it is that using > unsigned intrinsics to do unsigned-with-padding operations is leading to poor > code-gen, so you want to start

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

ArcsinX updated this revision to Diff 278440. ArcsinX added a comment. Prevent tokens selection in disabled preprocessor sections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83508/new/ https://reviews.llvm.org/D83508 Files:

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

CJ-Johnson added a comment. Hello to everyone following along! My apologies for the lack of activity; I should have made a comment sooner. Back in December/January I was exploring working on TySan (met with Hal and Richard, in addition to rebasing the diffs). After digging into the problem

[clang] 3a624c3 - [Matrix] Add the matrix test from D83570. NFC.

Author: Sjoerd Meijer Date: 2020-07-16T15:19:45+01:00 New Revision: 3a624c327adde62d075a4477e9bb9e6a2c186731 URL: https://github.com/llvm/llvm-project/commit/3a624c327adde62d075a4477e9bb9e6a2c186731 DIFF: https://github.com/llvm/llvm-project/commit/3a624c327adde62d075a4477e9bb9e6a2c186731.diff

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

Szelethus added a comment. I don't speak snek, but I approve this message! Its also great that we have dedicated tiny/small projects to analyze locally. Comment at: clang/utils/analyzer/ProjectMap.py:31 +SMALL: 1min-10min +BIG: 10min-1h +HUGE: >1h

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes marked 6 inline comments as done. c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; aaron.ballman wrote: > aaron.ballman wrote: > > c-rhodes wrote: > > >

[PATCH] D77062: [analyzer] Improved zero assumption in CStringChecke::assumeZero

ASDenysPetrov updated this revision to Diff 278445. ASDenysPetrov marked an inline comment as done. ASDenysPetrov added a comment. Changed naming due to LLVM rules. I decided not to change names everywhere to leave the patch more readable. CHANGES SINCE LAST ACTION

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. In D67833#2155196 , @fhahn wrote: > I think this change introduced the following warnings, where `auto &` is used > for types that are always copied. It would be great if you could take a look. > >

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Type.h:1928 + /// Determines if this is vector-length sized typed (VLST), i.e. a + /// sizeless type with the 'arm_sve_vector_bits(N)' attribute applied. ... this is a

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 278507. c-rhodes added a comment. Use `const auto *` and remove cast CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83550/new/ https://reviews.llvm.org/D83550 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/Attr.td

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

stefanp added a comment. The title of the patch mentions both zero extend and sign extend. However, it seems that we only have instructions for the zero extend case. Is that right? I see both types of tests in: `test/CodeGen/builtins-ppc-p10vector.c` But I only see codegen tests for the zreo

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske added a comment. Lot of tests are failing because changed warning locations. These will be updated if the code change looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83961/new/ https://reviews.llvm.org/D83961

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

vsavchenko marked an inline comment as done. vsavchenko added a comment. In D83942#2155762 , @Szelethus wrote: > I don't speak snek, but I approve this message! Thanks  > I suppose LLVM could be a HUGE project? Yurp, LLVM, pytorch, (surprisingly!)

[libunwind] 0f03626 - [runtimes][NFC] Remove unused or unnecessary CMake variables

Author: Louis Dionne Date: 2020-07-16T10:47:08-04:00 New Revision: 0f03626fbf40ba1a74badf2d1476a550535c184f URL: https://github.com/llvm/llvm-project/commit/0f03626fbf40ba1a74badf2d1476a550535c184f DIFF: https://github.com/llvm/llvm-project/commit/0f03626fbf40ba1a74badf2d1476a550535c184f.diff

[PATCH] D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins

amyk requested changes to this revision. amyk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Headers/altivec.h:5472 + +#ifdef _ARCH_PWR10 +static __inline__ vector unsigned __int128 __ATTRS_o_ai Please use

[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

bsaleil accepted this revision. bsaleil added a comment. This revision is now accepted and ready to land. Thanks for the explanation. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82576/new/ https://reviews.llvm.org/D82576

[PATCH] D83868: Use TestClangConfig in AST Matchers tests and run them in more configurations

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f244c4b42b0: Use TestClangConfig in AST Matchers tests and run them in more configurations (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added a comment. Apologies we didn't identify this earlier but with the change of the mask register layout (`MLEN=1`) the overlap constraints involving the mask register were modified: //**RVV-0.8, Section 5.3. Vector Masking:**// > The destination vector register group for a masked

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Yes, these two are exactly the case! > - you'd be using an editor/plugin that sends compile commands over LSP (such > as YCM + ycm_extra_conf). What are you using? > - there should be relatively few *.idx files inside the extra directories > (the ones not near

[PATCH] D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins

Conanap created this revision. Conanap added reviewers: PowerPC, saghir, nemanjai, hfinkel. Conanap added projects: LLVM, clang, PowerPC. Herald added subscribers: steven.zhang, kbarton. This patch implements 128-bit Binary Vector Multiply builtins for PowerPC10. Repository: rG LLVM Github

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Fix of the

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7948-7949 + MapFlagsArrayTy , + const llvm::DenseSet = + llvm::DenseSet()) const { // We have to process the component

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added a comment. This new modifier must be enabed only for OpenMP 5.1, need to add the checks for OpenMP version. Also, this change should not affect the functionality of previous versions Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7043-7044 OMP_MAP_CLOSE

[clang] 69f3378 - [AIX]Generate debug info for static init related functions

Author: Xiangling Liao Date: 2020-07-16T10:43:10-04:00 New Revision: 69f3378ad65b41c979acc1bcb4968d2247e6adf7 URL: https://github.com/llvm/llvm-project/commit/69f3378ad65b41c979acc1bcb4968d2247e6adf7 DIFF:

[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

amyk marked an inline comment as done. amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:28 + return vec_mul(vulla, vullb); +} + bsaleil wrote: > Are the tests for `vec_mul` with `v4i32` missing ? I should probably reword the

[clang] 31248b4 - Last attempt for rG3a624c327add: one test fails with the NPM,

Author: Sjoerd Meijer Date: 2020-07-16T16:12:47+01:00 New Revision: 31248b4785c14e50c1694fc986c69afcea64bd81 URL: https://github.com/llvm/llvm-project/commit/31248b4785c14e50c1694fc986c69afcea64bd81 DIFF: https://github.com/llvm/llvm-project/commit/31248b4785c14e50c1694fc986c69afcea64bd81.diff

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. Fix is at https://reviews.llvm.org/D83959 @Meinersbur Michael, could you please help upstream the patch above? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

rsandifo-arm added a comment. Thanks for doing this. FWIW, the patch LGTM from a spec point of view. I just saw one minor spelling nit. Comment at: clang/include/clang/Basic/AttrDocs.td:4882 +to the SVE predicate type ``svbool_t``, this excludes tuple types such as

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

stefanp added a comment. Just a few nits for this patch. Comment at: clang/lib/Headers/altivec.h:17158 +static __inline__ vector signed __int128 __ATTRS_o_ai +vec_sl(vector signed __int128 __a, vector unsigned __int128 __b) { + return __builtin_altivec_vslq((vector unsigned

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes marked an inline comment as done. c-rhodes added a comment. In D83550#2155837 , @aaron.ballman wrote: > LGTM aside from a small nit. In D83550#2156063 , @rsandifo-arm wrote: > Thanks for doing this.

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:17 + +#define GET_CALLER_PC() __builtin_return_address(0) + Nit: Let's move this down with the other defines. Comment at:

[clang] a7a07a8 - Follow up of rG3a624c327add: pacify buildbot, add "REQUIRES: aarch64" to test

Author: Sjoerd Meijer Date: 2020-07-16T15:38:36+01:00 New Revision: a7a07a8d63b2008750347932e351d479a45bfc2c URL: https://github.com/llvm/llvm-project/commit/a7a07a8d63b2008750347932e351d479a45bfc2c DIFF: https://github.com/llvm/llvm-project/commit/a7a07a8d63b2008750347932e351d479a45bfc2c.diff

[PATCH] D83702: [AIX]Generate debug info for static init related functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG69f3378ad65b: [AIX]Generate debug info for static init related functions (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a small nit. Comment at: clang/lib/Sema/SemaType.cpp:7698 +llvm::APSInt ) { + Expr *AttrExpr = static_cast(Attr.getArgAsExpr(0)); + if

[clang] 0160ad8 - And now really disable that test.

Author: Sjoerd Meijer Date: 2020-07-16T16:14:47+01:00 New Revision: 0160ad802e899c2922bc9b29564080c22eb0908c URL: https://github.com/llvm/llvm-project/commit/0160ad802e899c2922bc9b29564080c22eb0908c DIFF: https://github.com/llvm/llvm-project/commit/0160ad802e899c2922bc9b29564080c22eb0908c.diff

[PATCH] D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() {

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

kamaub accepted this revision as: kamaub. kamaub added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83500/new/ https://reviews.llvm.org/D83500

[clang] 4f244c4 - Use TestClangConfig in AST Matchers tests and run them in more configurations

Author: Dmitri Gribenko Date: 2020-07-16T18:36:53+02:00 New Revision: 4f244c4b42b096a55f2e7f719e1101c6fd26c034 URL: https://github.com/llvm/llvm-project/commit/4f244c4b42b096a55f2e7f719e1101c6fd26c034 DIFF:

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

HsiangKai added a comment. In D80802#2155432 , @simoncook wrote: > Since this patch replaces 0.8 support with 0.9, it should include an update > to the version check in `clang/lib/Driver/ToolChains/Arch/RISCV.cpp` to match. The modification is put in

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:53 +int fuzzer_inited = 0; +bool fuzzer_init_is_running; + These are in the global namespace, and have C mangling, which is unnecessary. Please either put them in a

[PATCH] D83966: Enable the test for hasArraySize() in all language modes

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In C++11 and later Clang generates an implicit conversion from int to size_t in the AST. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83966 Files:

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

sammccall added a comment. In D83099#2155900 , @davidvancleve wrote: > Yes, these two are exactly the case! > > > - you'd be using an editor/plugin that sends compile commands over LSP > > (such as YCM + ycm_extra_conf). What are you using? > > - there

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

sammccall added a comment. https://bugs.llvm.org/show_bug.cgi?id=46754 to get the fixed merged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83099/new/ https://reviews.llvm.org/D83099 ___ cfe-commits

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 - Builder.SetInsertPoint(OuterFn->getEntryBlock().getFirstNonPHI()); - AllocaInst *TIDAddr = Builder.CreateAlloca(Int32, nullptr, "tid.addr"); - AllocaInst *ZeroAddr =

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; davidstone wrote: > aaron.ballman wrote: > > riccibruno wrote: > > > riccibruno wrote: > > > > davidstone wrote: > >

  1   2   >