[PATCH] D79744: clang: Use byref for aggregate kernel arguments

rjmccall added a comment. Arguably we should add this attribute to all indirect arguments. I can understand not wanting to update all the test cases, but you could probably avoid adding a new IndirectByRef kind of ABIArgInfo by treating kernels specially in ConstructAttributeList. Or, sorry,

[clang] 6aea36f - Follow-on fixes for get/isIntegerConstantExpression

Author: David Blaikie Date: 2020-07-21T21:51:59-07:00 New Revision: 6aea36fb98ed1e0c89cd6e3a24b76339a75aef68 URL: https://github.com/llvm/llvm-project/commit/6aea36fb98ed1e0c89cd6e3a24b76339a75aef68 DIFF: https://github.com/llvm/llvm-project/commit/6aea36fb98ed1e0c89cd6e3a24b76339a75aef68.diff

Buildbot numbers for the week of 07/12/2020 - 07/18/2020

Hello everyone, Below are some buildbot numbers for the last week of 07/12/2020 - 07/18/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 07/5/2020 - 07/11/2020

Hello everyone, Below are some buildbot numbers for the week of 07/5/2020 - 07/11/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

[clang] 36036aa - Reapply "Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression"

Author: David Blaikie Date: 2020-07-21T20:57:12-07:00 New Revision: 36036aa70ec1df7b51b5d30b2dd8090ad2b6e783 URL: https://github.com/llvm/llvm-project/commit/36036aa70ec1df7b51b5d30b2dd8090ad2b6e783 DIFF: https://github.com/llvm/llvm-project/commit/36036aa70ec1df7b51b5d30b2dd8090ad2b6e783.diff

[PATCH] D84291: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation

amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, nemanjai, rzurob. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. The implementation of the `xvtlsbb` builtins/intrinsics were not correct as the intrinsics previously used `i1`

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu added a comment. In D83592#2165818 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/20315/step_7.txt > > Please take a look, and if it takes a while to investigate please revert > while you look. Fixed

[clang] 3930c4e - [Coverage] fix failed test case.

Author: Zequan Wu Date: 2020-07-21T19:16:18-07:00 New Revision: 3930c4e7d1aa486ccb4245214c0b383f40574a52 URL: https://github.com/llvm/llvm-project/commit/3930c4e7d1aa486ccb4245214c0b383f40574a52 DIFF: https://github.com/llvm/llvm-project/commit/3930c4e7d1aa486ccb4245214c0b383f40574a52.diff

[PATCH] D83592: [Coverage] Add comment to skipped regions

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/20315/step_7.txt Please take a look, and if it takes a while to investigate please revert while you look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592

[PATCH] D79290: Update suffix check and cast non-suffix types

BATManVSGig added a comment. this good idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79290/new/ https://reviews.llvm.org/D79290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: compiler-rt/test/profile/coverage_comments.cpp:9 +int y = 0; /* comment */ // CHECK: [[# @LINE]]| 1| int y = 0; /* comment */ +int z = 0; // comment // CHECK:

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

NoQ added a comment. In D82598#2164363 , @Szelethus wrote: > > Hmm, interesting. I don't really understand why do we need to keep that > > block live, as we definitely won't use any of the value it provides (since > > it does not provide a value at

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu closed this revision. zequanwu added a comment. Landed here, https://reviews.llvm.org/rGabd45154bdb6b76c5b480455eacc8c75b08242aa I put the wrong diff ID.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592

[PATCH] D83592: [Coverage] Add comment to skipped regions

MaskRay added inline comments. Comment at: compiler-rt/test/profile/coverage_comments.cpp:9 +int y = 0; /* comment */ // CHECK: [[# @LINE]]| 1| int y = 0; /* comment */ +int z = 0; // comment // CHECK: [[# @LINE]]| 1| int z = 0; // comment +

[clang] abd4515 - [Coverage] Add comment to skipped regions

Author: Zequan Wu Date: 2020-07-21T17:34:18-07:00 New Revision: abd45154bdb6b76c5b480455eacc8c75b08242aa URL: https://github.com/llvm/llvm-project/commit/abd45154bdb6b76c5b480455eacc8c75b08242aa DIFF: https://github.com/llvm/llvm-project/commit/abd45154bdb6b76c5b480455eacc8c75b08242aa.diff

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

This revision was automatically updated to reflect the committed changes. Closed by commit rG18581fd2c441: [CFE] Add nomerge function attribute to inline assembly. (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84225/new/

[clang] 18581fd - [CFE] Add nomerge function attribute to inline assembly.

Author: Wang, Pengfei Date: 2020-07-22T08:22:58+08:00 New Revision: 18581fd2c441eac052a25e4cbe9bd74d6ff605ad URL: https://github.com/llvm/llvm-project/commit/18581fd2c441eac052a25e4cbe9bd74d6ff605ad DIFF: https://github.com/llvm/llvm-project/commit/18581fd2c441eac052a25e4cbe9bd74d6ff605ad.diff

[PATCH] D83592: [Coverage] Add comment to skipped regions

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 ___ cfe-commits mailing list

[PATCH] D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.

varungandhi-apple added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84087/new/ https://reviews.llvm.org/D84087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

logan-5 added a comment. In D84244#2165592 , @dblaikie wrote: > Looks OK (for future reference, this sort of stuff should've been cleaned up > before enabling the flag so as to avoid this kind of hurry/breakage/etc) Loud and clear. I honestly thought I

[PATCH] D84277: [PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments.

amyk created this revision. amyk added reviewers: power-llvm-team, nemanjai, PowerPC, rzurob. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. Previously, the vins*vlx instructions were incorrectly defined with i64 as the second argument. This patches

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks OK (for future reference, this sort of stuff should've been cleaned up before enabling the flag so as to avoid this kind of hurry/breakage/etc) Repository: rG LLVM Github

[clang] a361aa5 - [clang] Disable -Wsuggest-override for unittests/

Author: Logan Smith Date: 2020-07-21T16:38:35-07:00 New Revision: a361aa5249856e333a373df90947dabf34cd6aab URL: https://github.com/llvm/llvm-project/commit/a361aa5249856e333a373df90947dabf34cd6aab DIFF: https://github.com/llvm/llvm-project/commit/a361aa5249856e333a373df90947dabf34cd6aab.diff

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

logan-5 added a comment. Committing this now to fix the bots, as per discussion in https://reviews.llvm.org/D84126. I'll happily revert and approach it differently later if anyone requests that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu updated this revision to Diff 279661. zequanwu added a comment. remove unnecessary header. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

nridge added a comment. Is there some additional context for what this patch is aiming to do? The description sounds interesting but I don't really understand it. What is a "feature" in this context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb907ad539a90: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf. (authored by aprantl). Changed prior to commit: https://reviews.llvm.org/D84087?vs=278972=279659#toc Repository:

[clang] b907ad5 - [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.

Author: Adrian Prantl Date: 2020-07-21T16:23:36-07:00 New Revision: b907ad539a900279443dc8ef8816b6b5a76b1ea1 URL: https://github.com/llvm/llvm-project/commit/b907ad539a900279443dc8ef8816b6b5a76b1ea1 DIFF: https://github.com/llvm/llvm-project/commit/b907ad539a900279443dc8ef8816b6b5a76b1ea1.diff

[PATCH] D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs

kubamracek added a comment. Let's handle simulators separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84082/new/ https://reviews.llvm.org/D84082 ___ cfe-commits mailing list

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. In D71726#2165494 , @jyknight wrote: > In D71726#2165445 , @yaxunl wrote: > > > In D71726#2165424 , @jyknight > > wrote: > > > > > Why not have

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3842-3846 + if (EmitDwarf && + Args.hasFlag(options::OPT_fno_eliminate_unused_debug_types, + options::OPT_feliminate_unused_debug_types, false) && + DebugInfoKind >=

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2165517 , @cchen wrote: > In D84192#2165438 , @ABataev wrote: > > > In D84192#2165396 , @cchen wrote: > > > > > In D84192#2165249

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165438 , @ABataev wrote: > In D84192#2165396 , @cchen wrote: > > > In D84192#2165249 , @ABataev wrote: > > > > > In D84192#2165235

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

chill added a comment. I'm afraid the patch does not work yet. For example, when the following program void *f() { void g(); g(); return __builtin_return_address(0); } is compiled with ./bin/clang -target aarch64-eabi -march=armv8.3-a -mbranch-protection=pac-ret

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. In D71726#2165445 , @yaxunl wrote: > In D71726#2165424 , @jyknight wrote: > > > Why not have clang always emit atomicrmw for floats, and let > > AtomicExpandPass handle legalizing that

[PATCH] D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.

varungandhi-apple added a comment. (Could you land the patch if it looks good? I don't have commit access.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84087/new/ https://reviews.llvm.org/D84087 ___

[PATCH] D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.

varungandhi-apple marked an inline comment as done. varungandhi-apple added inline comments. Comment at: clang/lib/Basic/Module.cpp:176 bool Module::isSubModuleOf(const Module *Other) const { - const Module *This = this; - do { + for (const Module *This = this; This !=

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3825-3828 + if (EmitDwarf && + Args.hasFlag(options::OPT_fno_eliminate_unused_debug_types, + options::OPT_feliminate_unused_debug_types, false)) +DebugInfoKind =

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 279643. nickdesaulniers marked 4 inline comments as done. nickdesaulniers added a comment. - rebase, add -g1 test case, don't emit unless -g2 or higher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jfb added a comment. In D71726#2165445 , @yaxunl wrote: > In D71726#2165424 , @jyknight wrote: > > > Why not have clang always emit atomicrmw for floats, and let > > AtomicExpandPass handle legalizing that into

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. In D71726#2165424 , @jyknight wrote: > Why not have clang always emit atomicrmw for floats, and let AtomicExpandPass > handle legalizing that into integer atomics if necessary, rather than adding > a target hook in clang? Not

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

dblaikie added a comment. In D52296#2165370 , @Trass3r wrote: > In D52296#1285328 , @grimar wrote: > > > In D52296#1284130 , @probinson > > wrote: > > > > > Only DWARF

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2165396 , @cchen wrote: > In D84192#2165249 , @ABataev wrote: > > > In D84192#2165235 , @cchen wrote: > > > > > In D84192#2164885

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. Why not have clang always emit atomicrmw for floats, and let AtomicExpandPass handle legalizing that into integer atomics if necessary, rather than adding a target hook in clang? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/

[PATCH] D83772: [Windows] Fix limit on command line size

max-kudr added a comment. Thank you! @sepavloff reverted it in revision ac0edc55887b6961ad90fd51f349c9587b1a8a7a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/

[PATCH] D83772: [Windows] Fix limit on command line size

amccarth added a comment. In D83772#2164685 , @max-kudr wrote: > This commit is now failing LLDB Windows buildbot > builds > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17702.

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165249 , @ABataev wrote: > In D84192#2165235 , @cchen wrote: > > > In D84192#2164885 , @ABataev wrote: > > > > > Also, what about

[PATCH] D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins

Conanap updated this revision to Diff 279637. Conanap marked 2 inline comments as done. Conanap added a comment. Changed if def to use pwer10_vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83955/new/ https://reviews.llvm.org/D83955 Files:

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

Trass3r added a comment. Herald added a subscriber: dang. In D52296#1285328 , @grimar wrote: > In D52296#1284130 , @probinson wrote: > > > Only DWARF supports this, correct? > > > I am not aware of any kind of

[PATCH] D79744: clang: Use byref for kernel arguments

arsenm updated this revision to Diff 279635. arsenm retitled this revision from "clang: Add address space to indirect abi info and use it for kernels" to "clang: Use byref for kernel arguments". arsenm edited the summary of this revision. arsenm added a comment. Switch to byref. Doesn't handle

[clang] ce04d4e - Fix pow and ldexp in HIP header

Author: Yaxun (Sam) Liu Date: 2020-07-21T17:39:46-04:00 New Revision: ce04d4e39c936528fa0e0dc49fdf376eaee21f14 URL: https://github.com/llvm/llvm-project/commit/ce04d4e39c936528fa0e0dc49fdf376eaee21f14 DIFF:

[PATCH] D83519: [NewPM] Support optnone under new pass manager

MaskRay added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:77 + StandardInstrumentations(bool DebugLogging) + : PrintIR(), TimePasses(), OptNone(DebugLogging) {} (No need to change) PrintIR & TimePasses don't need to

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added inline comments. Comment at: clang/include/clang/Driver/Driver.h:332 + llvm::Triple getHIPOffloadTargetTriple() const; + This is used exclusively by the Driver.cpp and does not have to be a public API call. Comment at:

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165249 , @ABataev wrote: > In D84192#2165235 , @cchen wrote: > > > In D84192#2164885 , @ABataev wrote: > > > > > Also, what about

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2165235 , @cchen wrote: > In D84192#2164885 , @ABataev wrote: > > > Also, what about compatibility with declare mapper? Can you add tests for > > it? > > > There's a restriction

[PATCH] D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Module.cpp:176 bool Module::isSubModuleOf(const Module *Other) const { - const Module *This = this; - do { + for (const Module *This =

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 279631. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2164885 , @ABataev wrote: > Also, what about compatibility with declare mapper? Can you add tests for it? There's a restriction for map clause that non-contiguous is not allowed and I guess it also applies to declare

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:1 -// RUN: %check_clang_tidy -std=c++14,c++17 %s modernize-use-trailing-return-type %t -- -- -fdeclspec -fexceptions +// RUN: %check_clang_tidy

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX added a comment. In D83759#2165116 , @thakis wrote: > Looks like this breaks tests on macOS (and probably with non-gnu greps): > http://45.33.8.238/mac/17611/step_9.txt > > Please take a look, and revert while you investigate if it takes a while

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber updated this revision to Diff 279625. bernhardmgruber marked an inline comment as done. bernhardmgruber edited the summary of this revision. bernhardmgruber added a comment. Removed probably stale FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/

[clang-tools-extra] 23ff4e4 - Revert "[clangd] Fixes in lit tests"

Author: Aleksandr Platonov Date: 2020-07-21T23:32:47+03:00 New Revision: 23ff4e4f5d651b4a75aede51defc8e903dfd694d URL: https://github.com/llvm/llvm-project/commit/23ff4e4f5d651b4a75aede51defc8e903dfd694d DIFF:

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber added a comment. Great, I seems I forgot to submit the inline comments. Sorry about that! Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:293 +StringRef File = SM.getBufferData(Loc.first); +const char *TokenBegin =

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added a comment. Thanks. It probably won't be soon. At the very least, I need to find the answer to question 3 from the review summary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83061/new/ https://reviews.llvm.org/D83061 ___

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added a comment. In D83061#2165100 , @jdenny wrote: > In D83061#2165093 , @ABataev wrote: > > > In D83061#2165089 , @jdenny wrote: > > > > > In D83061#2165063

[PATCH] D83759: [clangd] Fixes in lit tests

thakis added a comment. Looks like this breaks tests on macOS (and probably with non-gnu greps): http://45.33.8.238/mac/17611/step_9.txt Please take a look, and revert while you investigate if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 73bc23f - Fix the data layout mangling specification for 'i686-pc-macho'

Author: Akira Hatanaka Date: 2020-07-21T12:58:17-07:00 New Revision: 73bc23ff86655b4e041ce14a991a8bd5cce985e0 URL: https://github.com/llvm/llvm-project/commit/73bc23ff86655b4e041ce14a991a8bd5cce985e0 DIFF:

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added a comment. In D83551#2164984 , @aaron.ballman wrote: > The attribute bits LGTM, thanks! Thanks for reviewing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83551/new/ https://reviews.llvm.org/D83551

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane marked 2 inline comments as done. erichkeane added a comment. I'd attempted to regenerate the cxx_dr_status.html using make_cxx_dr_status, but I get a 'no such In D84048#2165080 , @rsmith wrote: > In D84048#2164950

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added a comment. In D83061#2165093 , @ABataev wrote: > In D83061#2165089 , @jdenny wrote: > > > In D83061#2165063 , @ABataev wrote: > > > > > LG. > > > > > > Thanks

[clang] 13bfe4b - [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

Author: Alexey Bataev Date: 2020-07-21T15:48:32-04:00 New Revision: 13bfe4b226d2f158c46b9e351f4f0c224b899b96 URL: https://github.com/llvm/llvm-project/commit/13bfe4b226d2f158c46b9e351f4f0c224b899b96 DIFF: https://github.com/llvm/llvm-project/commit/13bfe4b226d2f158c46b9e351f4f0c224b899b96.diff

[PATCH] D84182: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13bfe4b226d2: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added a comment. In D83061#2165089 , @jdenny wrote: > In D83061#2165063 , @ABataev wrote: > > > LG. > > > Thanks for the review. > > As discussed in the review summary, please consider the following. A

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

riccibruno added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81003/new/ https://reviews.llvm.org/D81003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

NoQ added inline comments. Comment at: clang/test/Analysis/CGColorSpace.c:8-11 void f() { - CGColorSpaceRef X = CGColorSpaceCreateDeviceRGB(); // expected-warning{{leak}} + CGColorSpaceRef X = CGColorSpaceCreateDeviceRGB(); CGColorSpaceRetain(X); +} //

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added a comment. In D83061#2165063 , @ABataev wrote: > LG. Thanks for the review. As discussed in the review summary, please consider the following. A present map type modifier behavior that this patch does not attempt to implement is TR8

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

rsmith added a comment. In D84048#2164950 , @erichkeane wrote: > Additionally, I sent out a CWG message on the reflector about this: > https://godbolt.org/z/bEr61T > > My implementation has this as ambiguous, but the wording makes it well-formed > I

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 279610. saiislam added a comment. Added final to specialized classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files:

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG. Please, land it after the runtime part CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83061/new/ https://reviews.llvm.org/D83061

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie added a comment. @hans @llunak - sounds like you're both fine with this? Either of you mind to give it a formal approval, if that's the case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83652/new/ https://reviews.llvm.org/D83652

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3067-3068 + unsigned Type = getOpenMPSimpleClauseType(OMPC_map, PP.getSpelling(Tok)); + if (Type < OMPC_MAP_MODIFIER_unknown) +return OMPC_MAP_MODIFIER_unknown; + return static_cast(Type);

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane updated this revision to Diff 279609. erichkeane added a comment. Revert change to cxx_dr_status and update the test to have the right tag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84048/new/ https://reviews.llvm.org/D84048 Files:

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

riccibruno added a comment. > Ah, doh, I see a few now. Is that number the compiler version number? Yup CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84048/new/ https://reviews.llvm.org/D84048 ___ cfe-commits mailing list

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

riccibruno added a comment. In D84048#2165026 , @erichkeane wrote: > In D84048#2165023 , @riccibruno > wrote: > > > > Also make sure to update the the cxx_dr_status.html document. > > > > It is auto-generated. You

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane added a comment. In D84048#2165026 , @erichkeane wrote: > In D84048#2165023 , @riccibruno > wrote: > > > > Also make sure to update the the cxx_dr_status.html document. > > > > It is auto-generated. You

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane added a comment. In D84048#2165023 , @riccibruno wrote: > > Also make sure to update the the cxx_dr_status.html document. > > It is auto-generated. You need to tag the test case: `dr2303: 12`. > > Edit: And put it at the right place in the file

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

riccibruno added a comment. > Also make sure to update the the cxx_dr_status.html document. It is auto-generated. You need to tag the test case: `dr2303: 12`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84048/new/ https://reviews.llvm.org/D84048

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu updated this revision to Diff 279605. zequanwu added a comment. Change `@LINE` to `# @LINE`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/CodeGen/CodeGenAction.cpp

Re: [clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

Cool - thanks for the context! On Tue, Jul 21, 2020 at 5:44 AM Aaron Ballman wrote: > On Mon, Jul 20, 2020 at 5:44 PM David Blaikie wrote: > > > > Should the warning be disabled for LLVM overall, rather than only for > > this subproject? (& be good tohave some details in the commit at least >

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.h:25 -class CGOpenMPRuntimeNVPTX : public CGOpenMPRuntimeGPU { +class CGOpenMPRuntimeAMDGCN : public CGOpenMPRuntimeGPU { `final` Comment at:

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The attribute bits LGTM, thanks! Comment at: clang/lib/AST/ASTContext.cpp:1887 + +unsigned getSvePredWidth(const Type *T) { return getSveVectorWidth(T) / 8; }

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam created this revision. saiislam added reviewers: ABataev, jdoerfert, JonChesterfield, grokos. Herald added subscribers: cfe-commits, aaron.ballman, sstefan1, guansong, yaxunl, mgorny, jvesely, jholewinski. Herald added a project: clang. Provides AMDGCN and NVPTX specific specialization

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

zequanwu accepted this revision. zequanwu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84225/new/ https://reviews.llvm.org/D84225

[PATCH] D83592: [Coverage] Add comment to skipped regions

MaskRay added a comment. New tests should use `[[#@LINE]]` instead of `[[@LINE]]` https://llvm.org/docs/CommandGuide/FileCheck.html > To support legacy uses of @LINE as a special string variable, FileCheck also > accepts the following uses of @LINE with string substitution block syntax: >

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane updated this revision to Diff 279598. erichkeane added a comment. Also make sure to update the the cxx_dr_status.html document. Additionally, I sent out a CWG message on the reflector about this: https://godbolt.org/z/bEr61T My implementation has this as ambiguous, but the wording

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

aaron.ballman added a comment. LGTM, though I have a possible code simplification if you think it's an improvement. Comment at: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp:78 + + if (const auto *DeclRef = Result.Nodes.getNodeAs("expr")) { +

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

ABataev added a comment. In D83261#2162904 , @Meinersbur wrote: > In D83261#2162561 , @ABataev wrote: > > > 1. OMPChildren class uses standard TrailingObjects harness instead of > > manual calculation. > > > I was

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu updated this revision to Diff 279595. zequanwu marked 2 inline comments as done. zequanwu retitled this revision from "[Parser] Add comment to skipped regions" to "[Coverage] Add comment to skipped regions". zequanwu edited the summary of this revision. zequanwu added a comment. -

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Also, what about compatibility with declare mapper? Can you add tests for it? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7809-7813 +MapValuesArrayTy CurOffsets{llvm::ConstantInt::get(CGF.CGM.Int64Ty, 0)}; +MapValuesArrayTy

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

aaron.ballman removed a reviewer: aaron.ballman. aaron.ballman added a comment. While this looks reasonable to me, I don't feel comfortable signing off on it because Templates Are Complicated (switching myself to a subscriber instead). CHANGES SINCE LAST ACTION

  1   2   3   >