[clang-tools-extra] cd4e8d7 - [clangd] Fix an assertion failure in TargetFinder's heuristic resolution of dependent type.

Author: Haojian Wu Date: 2020-07-30T08:54:22+02:00 New Revision: cd4e8d7f6f5ef108919f9f53db35ac73d1edea3d URL: https://github.com/llvm/llvm-project/commit/cd4e8d7f6f5ef108919f9f53db35ac73d1edea3d DIFF: https://github.com/llvm/llvm-project/commit/cd4e8d7f6f5ef108919f9f53db35ac73d1edea3d.diff

[PATCH] D84837: [clangd] Fix an assertion failure in TargetFinder's heuristic resolution of dependent type.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4e8d7f6f5e: [clangd] Fix an assertion failure in TargetFinders heuristic resolution of… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

lebedev.ri added a comment. I really think this should be in clang proper. I have seen such patterns written in the wild, they should be caught by just the compiler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/

[PATCH] D84671: Port LangOpts simple string based options to new option parsing system

dang updated this revision to Diff 281820. dang added a comment. Remove accidental addition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84671/new/ https://reviews.llvm.org/D84671 Files: clang/include/clang/Driver/Options.td

[PATCH] D84837: [clangd] Fix an assertion failure in TargetFinder's heuristic resolution of dependent type.

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:171 // or more declarations that it likely references. -std::vector resolveDependentExprToDecls(const Expr *E) { - assert(E->isTypeDependent()); +std::vector resolveExprToDecls(const Expr *E) {

[clang] 73c12bd - [Concepts] Fix a deserialization crash.

Author: Haojian Wu Date: 2020-07-30T09:25:15+02:00 New Revision: 73c12bd8ff1a9cd8375a357ea06f171e127ec1b8 URL: https://github.com/llvm/llvm-project/commit/73c12bd8ff1a9cd8375a357ea06f171e127ec1b8 DIFF: https://github.com/llvm/llvm-project/commit/73c12bd8ff1a9cd8375a357ea06f171e127ec1b8.diff

[PATCH] D84455: [Concepts] Fix a deserialization crash.

This revision was automatically updated to reflect the committed changes. Closed by commit rG73c12bd8ff1a: [Concepts] Fix a deserialization crash. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D84455?vs=280225=281811#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

njames93 added a comment. For the record `X < Y < Z ` does have a mathematical meaning, Y is constrained between X and Z. However in the context of `C` the expression isnt parsed like that. If someone writes this they likely wanted `(X < Y) && (Y < Z)` For this specific check as you pointed out

[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. LGTM! Thanks for all the investigative work! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84902/new/ https://reviews.llvm.org/D84902

[PATCH] D84843: [Analyzer] Remove inclusion of uniqueing decl from diagnostic profile.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1745ba41b196: [Analyzer] Remove inclusion of uniqueing decl from diagnostic profile. (authored by balazske). Repository: rG LLVM Github Monorepo

[clang] 1745ba4 - [Analyzer] Remove inclusion of uniqueing decl from diagnostic profile.

Author: Balázs Kéri Date: 2020-07-30T09:52:28+02:00 New Revision: 1745ba41b196d80d8a6739dffcbb6f613d371f29 URL: https://github.com/llvm/llvm-project/commit/1745ba41b196d80d8a6739dffcbb6f613d371f29 DIFF: https://github.com/llvm/llvm-project/commit/1745ba41b196d80d8a6739dffcbb6f613d371f29.diff

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

vsavchenko added a comment. Other then the naming issue, I don't see any problems with this change! Comment at: clang/lib/Analysis/IssueHash.cpp:183 -std::string clang::GetIssueString(const SourceManager , - FullSourceLoc , -

[PATCH] D84455: [Concepts] Fix a deserialization crash.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. In D84455#2170461 , @hokein wrote: > btw, `getTypeConstraint` and `hasTypeConstraint` APIs are quite easy to be > misused (there is another similar

[PATCH] D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:285 ::testing::Matcher Sym(std::string Name, Range Decl) { - return Sym(Name, Decl, llvm::None); + return Sym(Name, Decl, Decl); } hokein wrote: > kadircet wrote: >

[PATCH] D84926: [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap

njames93 updated this revision to Diff 281862. njames93 added a comment. Fix build errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84926/new/ https://reviews.llvm.org/D84926 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D84894: [clangd] Implement Relations request for remote index

kbobyrev updated this revision to Diff 281863. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84894/new/ https://reviews.llvm.org/D84894 Files:

[PATCH] D84929: [analyzer] Fix out-of-tree only clang build by not relaying on private header

steakhal created this revision. steakhal added reviewers: NoQ, mgorny, xazax.hun, Szelethus, martong, balazske. Herald added subscribers: llvm-commits, cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald

[clang-tools-extra] a262f0f - [clangd] Implement Relations request for remote index

Author: Kirill Bobyrev Date: 2020-07-30T12:57:33+02:00 New Revision: a262f0fea46ce08008f3462c336c3d7107e98b27 URL: https://github.com/llvm/llvm-project/commit/a262f0fea46ce08008f3462c336c3d7107e98b27 DIFF:

[PATCH] D84894: [clangd] Implement Relations request for remote index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa262f0fea46c: [clangd] Implement Relations request for remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

atrosinenko created this revision. atrosinenko added reviewers: koviankevin, joerg, efriedma, compnerd, scanon. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. atrosinenko requested review of this revision. This patch - makes the three tests look more uniformly - adds

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

hokein added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:112 +if (!IndexRoot.empty()) { + llvm::DenseSet ExcludeIDs; + for (const auto : *Result.Symbols) I think we could reuse the `FileShardedIndex` to do the

[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

njames93 added a comment. This is very much a work in progress Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 ___ cfe-commits mailing list

[clang-tools-extra] 45a720a - [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap

Author: Nathan James Date: 2020-07-30T10:31:13+01:00 New Revision: 45a720a864320bbbeb596abe412786fa91858980 URL: https://github.com/llvm/llvm-project/commit/45a720a864320bbbeb596abe412786fa91858980 DIFF: https://github.com/llvm/llvm-project/commit/45a720a864320bbbeb596abe412786fa91858980.diff

[PATCH] D84868: [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG45a720a86432: [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84868/new/

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for catching this, LGTM! This might still end up traversing the whole file in non-existent cases, but I suppose that's an adventure for another day. I think we should also

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers added a comment. Thanks all for the prompt and actionable comments. I will address all comments directly and 1-1, but would like to bottom out on one point before driving this forward. @lebedev.ri commented this should be in the Clang front end rather than a tidy check. Can we reach

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

kadircet added a comment. oh and also, how did you notice the discrepancy? was it a random encounter while reading the code or did you notice a misbehaviour? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84912/new/ https://reviews.llvm.org/D84912

[PATCH] D84926: [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84926 Files:

[PATCH] D84894: [clangd] Implement Relations request for remote index

kbobyrev updated this revision to Diff 281869. kbobyrev marked an inline comment as done. kbobyrev added a comment. Address post-LGTM comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84894/new/ https://reviews.llvm.org/D84894 Files:

[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

njames93 accepted this revision. njames93 added a comment. LGTM, Thanks that bug was eating away at me for a good few days. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84902/new/ https://reviews.llvm.org/D84902

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Ping ... ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 281878. simoll added a comment. NFC - Style updates - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 281844. simoll added a comment. Updated clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

ArcsinX added a comment. In D84912#2184147 , @kadircet wrote: > oh and also, how did you notice the discrepancy? was it a random encounter > while reading the code or did you notice a misbehaviour? Case was like this void f1(int [[paramValue]]){ }

[PATCH] D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol.

hokein updated this revision to Diff 281852. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84919/new/ https://reviews.llvm.org/D84919 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol.

hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:430 Located.PreferredDeclaration = bool(Sym.Definition) ? DefLoc : DeclLoc; -Located.Definition = DefLoc; +if (Sym.Definition) + Located.Definition = DefLoc; kadircet

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev planned changes to this revision. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:112 +if (!IndexRoot.empty()) { + llvm::DenseSet ExcludeIDs; + for (const auto : *Result.Symbols) hokein wrote:

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

This revision was automatically updated to reflect the committed changes. Closed by commit rG05b173466142: [clangd] findNearbyIdentifier(): fix the word search in the token stream. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 05b1734 - [clangd] findNearbyIdentifier(): fix the word search in the token stream.

Author: Aleksandr Platonov Date: 2020-07-30T12:45:58+03:00 New Revision: 05b173466142596b3297ab02e423574cb74b3799 URL: https://github.com/llvm/llvm-project/commit/05b173466142596b3297ab02e423574cb74b3799 DIFF:

[PATCH] D84894: [clangd] Implement Relations request for remote index

kadircet added a comment. thanks mostly nits, only annoying bit is usage of optionals and multi-logging but letting them be for now :D. also looks like there are some irrelevant changes, e.g. auto's in lambdas or formatting in protos, feel free to land an NFC change(without review) for those

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281881. TaWeiTu added a comment. Herald added a reviewer: bollu. Fix several pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.org/D84886 Files:

[PATCH] D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. And also fix a bug where we may return a meaningless

[PATCH] D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:430 Located.PreferredDeclaration = bool(Sym.Definition) ? DefLoc : DeclLoc; -Located.Definition = DefLoc; +if (Sym.Definition) + Located.Definition = DefLoc; this is

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, gribozavr2, Eugene.Zelenko, hokein. Herald added subscribers: cfe-commits, arphaman, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Added an option to control whether to apply

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:198 +[LLVMPointerType], +[IntrReadMem, IntrArgMemOnly, IntrSpeculatable], +

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

ArcsinX added a comment. In D84912#2184144 , @kadircet wrote: > I think we should also cherry-pick this into release branch. I've filed > https://bugs.llvm.org/show_bug.cgi?id=46905 for cherry-picking please update > the bug > with the commit hash once

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal added inline comments. Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19 +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" +#include "llvm/Config/config.h" +#include "gtest/gtest.h" steakhal wrote: >

[PATCH] D84894: [clangd] Implement Relations request for remote index

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:391 + auto Deserialized = ProtobufMarshaller.fromProtobuf(*Serialized); +

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4876 +assert(E->containsErrors()); +return ESR_Failed; + } This should not result in failure when checking for a potential constant expression; if an expression

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

efriedma created this revision. efriedma added a reviewer: rjmccall. Herald added a project: clang. efriedma requested review of this revision. Without the "align" attribute, marking the argument dereferenceable is basically useless. See also D80166 . Fixes

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 added a comment. There is a possibly-compelling argument against using x18: RV32E only gives x0-x15, so would not be able to support the current implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

tlively added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:198 +[LLVMPointerType], +[IntrReadMem, IntrArgMemOnly, IntrSpeculatable], + "", [SDNPMemOperand]>; aheejin wrote: > Can memory accesses

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane marked 2 inline comments as done. erichkeane added a comment. Thanks! I'm done for the day, so I'll push in the morning when I'll have a few hours to respond to build bots. Thanks again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84048/new/

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith added a comment. In D84637#2175681 , @erichkeane wrote: > Based on richard's suggestions, that seems about right. However I believe > all the asserts should have a message to go along with them as we typicaly do. In this case, the asserts are

[clang] c03d3ac - [test] Fix thinlto-distributed-newpm.ll

Author: Arthur Eubanks Date: 2020-07-30T20:09:34-07:00 New Revision: c03d3aca7d00db61eece554b7c4a9d921c1aff05 URL: https://github.com/llvm/llvm-project/commit/c03d3aca7d00db61eece554b7c4a9d921c1aff05 DIFF:

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers updated this revision to Diff 281943. vabridgers added a comment. Address backticks in rst files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898 Files:

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers marked 2 inline comments as done. vabridgers added a comment. Thanks Eugene, I think the backtick issue has been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281954. TaWeiTu added a comment. Fix loop deletion and rotation tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.org/D84886 Files: clang/lib/CodeGen/BackendUtil.cpp

[clang] 3d06fc0 - [OpenMP][Docs] Mark `present` motion modifier as done

Author: Joel E. Denny Date: 2020-07-30T12:21:37-04:00 New Revision: 3d06fc0049c6bb94e6efd77388453206037f43ad URL: https://github.com/llvm/llvm-project/commit/3d06fc0049c6bb94e6efd77388453206037f43ad DIFF: https://github.com/llvm/llvm-project/commit/3d06fc0049c6bb94e6efd77388453206037f43ad.diff

[clang] 3d6f530 - [PGO] Include the mem ops into the function hash.

Author: Hiroshi Yamauchi Date: 2020-07-30T09:26:20-07:00 New Revision: 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d URL: https://github.com/llvm/llvm-project/commit/3d6f53018f845e893ad34f64ff2851a2e5c3ba1d DIFF:

[PATCH] D84908: [darwin][compiler-rt] build libclang_rt.sim.a Apple Silicon slice, if SDK supports it

arphaman updated this revision to Diff 281963. arphaman added a comment. don't check if the SDK isn't present. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84908/new/ https://reviews.llvm.org/D84908 Files: compiler-rt/cmake/builtin-config-ix.cmake Index:

[clang] 555cf42 - [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

Author: Yuanfang Chen Date: 2020-07-30T10:07:57-07:00 New Revision: 555cf42f380d86f35e761c3a2179c761356ab152 URL: https://github.com/llvm/llvm-project/commit/555cf42f380d86f35e761c3a2179c761356ab152 DIFF: https://github.com/llvm/llvm-project/commit/555cf42f380d86f35e761c3a2179c761356ab152.diff

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay added a comment. It is also a convention to explain what has changed compared with the initial land. As a hindsight, the option `-pgo-instr-old-cfg-hashing` should probably have been mentioned in the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added a comment. Yup, -pgo-instr-old-cfg-hashing=true to revert back to the old hashing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 ___ cfe-commits

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:201-205 /// Declare generalized virtual functions which need to be defined - /// by all specializations of OpenMPGPURuntime Targets. + /// by all specializations of OpenMPGPURuntime Targets

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:75 + + Finds complex conditions using `<`, `>`, `<=`, and `>=` that could be + interpreted ambiguously. Double back-ticks, not single ones. Comment at:

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84422/new/ https://reviews.llvm.org/D84422 ___ cfe-commits mailing list

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 281946. kbobyrev marked 12 inline comments as done. kbobyrev added a comment. Resolve most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.org/D84939 Files:

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev added a comment. This patch is not ready for review yet; planned changes: check if the version is between 1.25.0 and 1.26.0-4 and bail out in such cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/

[clang-tools-extra] 6a043ec - [clang-tidy] Fix ODR violation in unittests.

Author: Artem Dergachev Date: 2020-07-30T08:52:47-07:00 New Revision: 6a043ecc0cf4d257d06c4fe0c3d5e1d9a8c7ea94 URL: https://github.com/llvm/llvm-project/commit/6a043ecc0cf4d257d06c4fe0c3d5e1d9a8c7ea94 DIFF:

[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a043ecc0cf4: [clang-tidy] Fix ODR violation in unittests. (authored by dergachev.a). Herald added a subscriber: steakhal. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:109 SourceMgr(Diags, Files), Context(Context), ApplyFixes(ApplyFixes), -TotalFixes(0), AppliedFixes(0), WarningsAsErrors(0) { +ApplyAnyFix(ApplyAnyFix),

[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:109 SourceMgr(Diags, Files), Context(Context), ApplyFixes(ApplyFixes), -TotalFixes(0), AppliedFixes(0), WarningsAsErrors(0) { +

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG555cf42f380d: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations (authored by ychen). Repository: rG LLVM Github Monorepo

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay closed this revision. MaskRay added a comment. Relanded as 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d @yamauchi For a reland, you still need to include `Differential Revision: ` so that the differential can be closed

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:313 RelativePath, llvm::sys::path::Style::posix)); - if (RelativePath.empty()) { -return llvm::None; - } - if

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny marked an inline comment as done. jdenny added a comment. Thanks for the review. As discussed during the 7/29 call, I'll wait to push until we're sure about what the OpenMP committee intended here. I'm pursuing this and will report back when I have more information. CHANGES SINCE

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand added a comment. @jdoerfert what would the procedure be for reviewing these test changes / getting this landed with the noundef patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/ https://reviews.llvm.org/D82317

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 281897. kbobyrev added a comment. Client: print debug string for the stream_result, not the ReplyT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.org/D84939 Files:

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 updated this revision to Diff 281911. Jac1494 added a comment. Hi @aaron.ballman , Address your review comments. Thank you for accepting this. I don't have commit access please commit this. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebad64dfe133: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES

[clang] 19756ef - [OpenMP][IRBuilder] Support allocas in nested parallel regions

Author: Johannes Doerfert Date: 2020-07-30T10:19:39-05:00 New Revision: 19756ef53a498b7aa1fbac9e3a7cd3aa8e110fad URL: https://github.com/llvm/llvm-project/commit/19756ef53a498b7aa1fbac9e3a7cd3aa8e110fad DIFF:

[clang] ebad64d - [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

Author: Johannes Doerfert Date: 2020-07-30T10:19:40-05:00 New Revision: ebad64dfe133e64d1df6b82e6ef2fb031d635b08 URL: https://github.com/llvm/llvm-project/commit/ebad64dfe133e64d1df6b82e6ef2fb031d635b08 DIFF:

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers added a comment. I believe all review comments have been address, except for the discussion on implementing this in the CFE or as a tidy check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19756ef53a49: [OpenMP][IRBuilder] Support allocas in nested parallel regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281907. TaWeiTu added a comment. Fix LOOP_NEST_ANALYSIS macro, clang-tidy warnings. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.org/D84886 Files:

[clang-tools-extra] c4b7bfd - [clangd] NFC: Spell out types in index callback arguments

Author: Kirill Bobyrev Date: 2020-07-30T17:12:29+02:00 New Revision: c4b7bfdff65e5883bfe64248ac244b9fadf531ee URL: https://github.com/llvm/llvm-project/commit/c4b7bfdff65e5883bfe64248ac244b9fadf531ee DIFF:

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added a comment. In D84939#2184836 , @kadircet wrote: > i think you might want to have an helper for creating stringerrors and use it > in all places Haha, yeah I thought about that but then looked at other examples and saw that in some cases

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 281932. saiislam added a comment. Moved comments to header files. Used regexps for test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files:

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L updated this revision to Diff 281938. Xiangling_L added a comment. Removed the disablement in IncrementalProcessingTest.cpp cross-target test; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84534/new/ https://reviews.llvm.org/D84534 Files: clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a refactoring: errors

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from an almost NFC simplification. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5350 + + D->addAttr(::new (S.Context) + NSErrorDomainAttr(S.Context, AL, IdentLoc->Ident));

[PATCH] D84880: [AIX] Temporarily disable IncrementalProcessingTest partially

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e6176fd912a: [AIX] Temporarily disable IncrementalProcessingTest partially (authored by Xiangling_L). Repository: rG LLVM Github Monorepo

[clang] 4e6176f - [AIX] Temporarily disable IncrementalProcessingTest partially

Author: Xiangling Liao Date: 2020-07-30T10:41:52-04:00 New Revision: 4e6176fd912a68de0764fff43a129a73f5cab800 URL: https://github.com/llvm/llvm-project/commit/4e6176fd912a68de0764fff43a129a73f5cab800 DIFF:

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

yonghong-song updated this revision to Diff 281933. yonghong-song retitled this revision from "[clang][BPF] support type existence/size and enum value relocations" to "[clang][BPF] support type exist/size and enum exist/value relocations". yonghong-song edited the summary of this revision.

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG142d0d3ed8e0: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target… (authored by ABataev). Repository: rG LLVM Github

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281928. MForster marked 5 inline comments as done. MForster added a comment. Fix patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files:

[clang] b69357c - Revert "[OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region."

Author: Alexey Bataev Date: 2020-07-30T10:57:56-04:00 New Revision: b69357c2f4f2aa0c4999d6827a40fe748641fdb1 URL: https://github.com/llvm/llvm-project/commit/b69357c2f4f2aa0c4999d6827a40fe748641fdb1 DIFF: https://github.com/llvm/llvm-project/commit/b69357c2f4f2aa0c4999d6827a40fe748641fdb1.diff

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers updated this revision to Diff 281937. vabridgers marked 6 inline comments as done. vabridgers added a comment. Address most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898

[clang] 622e461 - [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

Author: Alexey Bataev Date: 2020-07-30T11:18:33-04:00 New Revision: 622e46156d9a91206c877a604d069bb3e2dbf294 URL: https://github.com/llvm/llvm-project/commit/622e46156d9a91206c877a604d069bb3e2dbf294 DIFF: https://github.com/llvm/llvm-project/commit/622e46156d9a91206c877a604d069bb3e2dbf294.diff

  1   2   >