[clang] 961da69 - Improve diagnostics for disallowed attributes used with multiversioning

Author: Erich Keane Date: 2020-08-04T07:40:27-07:00 New Revision: 961da69d7eafe44411d5ac9719209653d196f9e2 URL: https://github.com/llvm/llvm-project/commit/961da69d7eafe44411d5ac9719209653d196f9e2 DIFF: https://github.com/llvm/llvm-project/commit/961da69d7eafe44411d5ac9719209653d196f9e2.diff L

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4961 } +if (IS->getCond()->isValueDependent()) + return EvaluateDependentExpr(IS->getCond(), Info); The `if` stmt (the same to `while`,

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

amyk added inline comments. Comment at: clang/lib/Headers/altivec.h:17217 + +/* vs[l | r | ra] */ +static __inline__ vector unsigned __int128 __ATTRS_o_ai Add a space after this comment. Comment at: clang/lib/Headers/altivec.h:17227 +vec_sl(vec

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ce15f7eeb12: [SyntaxTree] Fix crash on pointer to member function (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85146/new/ https:

[clang] 8ce15f7 - [SyntaxTree] Fix crash on pointer to member function

Author: Eduardo Caldas Date: 2020-08-04T14:31:12Z New Revision: 8ce15f7eeb122c0bba4b676d797217359dd57c30 URL: https://github.com/llvm/llvm-project/commit/8ce15f7eeb122c0bba4b676d797217359dd57c30 DIFF: https://github.com/llvm/llvm-project/commit/8ce15f7eeb122c0bba4b676d797217359dd57c30.diff LOG

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein updated this revision to Diff 282917. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-function-re

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein updated this revision to Diff 282916. hokein added a comment. address review comments: - treat contains-errors expression as being potentially constant; - handle the value-dependent expressions for EvaluateInPlace; - remove the bailing out for constructor initializers that contains errors;

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

Xiangling_L added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1841 auto setDeclInfo = [&](bool IsIncompleteArrayType) { -TypeInfo TI = Context.getTypeInfo(D->getType()); -FieldAlign = Context.toCharUnitsFromBits(TI.Align); +auto TI = Context.

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware updated this revision to Diff 282914. baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added a comment. Minor fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76590/new/ https://reviews.llvm.org/D76590 Files: clang/lib/StaticAnalyzer/Checke

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D84622: [PowerPC] Implement Vector Extract Low/High Order Builtins in LLVM/Clang

amyk accepted this revision. amyk added a comment. I think overall it LGTM and the indentation can be addressed when committing. Comment at: clang/lib/Headers/altivec.h:17082 +/* vec_extractl */ +static __inline__ vector unsigned long long __ATTRS_o_ai vec_extractl( -

[PATCH] D85186: [SyntaxTree] Add support for `LiteralExpression`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG860cbbdd6b84: [SyntaxTree] Add support for `LiteralExpression` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware updated this revision to Diff 282909. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76590/new/ https://reviews.llvm.org/D76590 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp cl

[clang] 860cbbd - [SyntaxTree] Add support for `LiteralExpression`

Author: Eduardo Caldas Date: 2020-08-04T14:05:09Z New Revision: 860cbbdd6b84017e6d37e1752b0358a05da6b115 URL: https://github.com/llvm/llvm-project/commit/860cbbdd6b84017e6d37e1752b0358a05da6b115 DIFF: https://github.com/llvm/llvm-project/commit/860cbbdd6b84017e6d37e1752b0358a05da6b115.diff LOG

[clang] 1c0a0df - [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

Author: Haojian Wu Date: 2020-08-04T15:58:12+02:00 New Revision: 1c0a0dfa0236514fd1fbb1bccd8ad29f9d64e915 URL: https://github.com/llvm/llvm-project/commit/1c0a0dfa0236514fd1fbb1bccd8ad29f9d64e915 DIFF: https://github.com/llvm/llvm-project/commit/1c0a0dfa0236514fd1fbb1bccd8ad29f9d64e915.diff LO

[PATCH] D85124: [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c0a0dfa0236: [Concepts] Include the found concept decl when dumping the… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D85124: [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

hokein updated this revision to Diff 282906. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85124/new/ https://reviews.llvm.org/D85124 Files: clang/include/clang/AS

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:56 +SVal RetVal) const; + void handleErase(CheckerContext &C, const Expr *CE, SVal Cont, SVal It

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers added a subscriber: bevinh. vabridgers added a comment. ok, I think it's all sorted out now. Thanks @bevinh for the desk review. Let's start at the beginning again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://revi

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

tschuett added a comment. Sorry. I meant ABI. Can link GCC .o files with Clang .o files using the attributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85128/new/ https://reviews.llvm.org/D85128 ___

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers updated this revision to Diff 282902. vabridgers edited the summary of this revision. vabridgers added a comment. ok, I think it's all sorted out now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D851

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

rsandifo-arm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector). ---

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

njames93 updated this revision to Diff 282890. njames93 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81923/new/ https://reviews.llvm.org/D81923 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-e

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. Herald added a subscriber: steakhal. Ping! Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:199 // Utility methods - std::pair - static assumeZero(CheckerContext &C, -ProgramStateRef state, SVal V, QualType

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 282876. baloghadamsoftware added a comment. `else` branch merged with inner `if`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

ArcsinX created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ArcsinX requested review of this revision. This patch prevents `InitListChecker::UpdateStructuredListElement()` call with `expr == nullptr` which could cause a crash. Repository: rG LLVM Gith

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett added a comment. I was surprised too. Perhaps there is a way to write the test file such that any type mismatch is a warning and compile with -Werror (maybe a new file, the IR might get messy). I will spend some time looking into this. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added a comment. This approach looks way too hackish to me with multiple opposing attributes ("sign-return-address" vs. "ignore-sign-return-address") and some convoluted logic to resolve the contradiction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.l

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. In D80791#2164543 , @danielkiss wrote: >> If any function has the attribute "sign-return-address", then the output note >> section should have PAC bit set. The return address signing is completely >> local >> to the function, and fu

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

c-rhodes added a comment. In D85128#2192867 , @c-rhodes wrote: > In D85128#2191108 , @tschuett wrote: > >> - Is it compatible with GCC? > > Support for this attribute landed in GCC 10 and it's more complete than wha

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

ebevhan added a comment. I submitted a patch with the changes at D85191 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 ___ cf

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

ebevhan created this revision. ebevhan added reviewers: jasonliu, efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. ebevhan requested review of this revision. In D79719 , LayoutField was refactored to fetch the size of field types in

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

c-rhodes added a comment. In D85128#2191401 , @efriedma wrote: > Not going to write detailed review comments, but this looks like the right > approach in general. Thanks for taking a look! I'll split this up into separate patches soon. > One high-level

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added a comment. Would it be possible to publish these results on a public CodeChecker server? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 ___ cfe-c

[PATCH] D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing

vhscampos added a comment. Not really. Closing it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82949/new/ https://reviews.llvm.org/D82949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing

chill added a comment. Is this patch needed anymore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82949/new/ https://reviews.llvm.org/D82949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

Szelethus added a comment. We definitely need more tests. The idea overall however is amazing, thanks! Comment at: clang/test/Analysis/misc-ps-region-store.m:1160 struct list_pr8141 *items; - for (;; items = ({ do { } while (0); items->tail; })) // expected-warning{{Derefe

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers marked 2 inline comments as done. vabridgers added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14047 +static bool isComparisonOpSamePrecedence(BinaryOperatorKind Opc) { + switch (Opc) { njames93 wrote: > Quuxplusone wrote: > > Same prec

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers updated this revision to Diff 282854. vabridgers added a comment. fix misc test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85097/new/ https://reviews.llvm.org/D85097 Files: clang/docs/DiagnosticsReference.rst clang/inc

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers updated this revision to Diff 282852. vabridgers added a comment. isRelationalOp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85097/new/ https://reviews.llvm.org/D85097 Files: clang/docs/DiagnosticsReference.rst clang/include/clang

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

c-rhodes added a comment. In D85128#2191108 , @tschuett wrote: > Stupid questions. > > - Is it for convenience? You get arrays, global variables, structs, ... . > Vectorization becomes easier ... Yes, this allows the definition of types that can be used

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a comment. In D67422#2192407 , @NoQ wrote: > One bit that's not directly related but i decided to keep it from the > original patch was moving the plist-html diagnostic builder function into its > own file. That is a great call indeed.

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 282837. gamesh411 marked an inline comment as done. gamesh411 added a comment. rename file name in header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files: cla

[clang] 141cb8a - [analyzer] Model iterator random incrementation symmetrically

Author: Endre Fülöp Date: 2020-08-04T11:04:12+02:00 New Revision: 141cb8a1eecc0c843cdd4e788a28d2b6715e4dc5 URL: https://github.com/llvm/llvm-project/commit/141cb8a1eecc0c843cdd4e788a28d2b6715e4dc5 DIFF: https://github.com/llvm/llvm-project/commit/141cb8a1eecc0c843cdd4e788a28d2b6715e4dc5.diff L

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG141cb8a1eecc: [analyzer] Model iterator random incrementation symmetrically (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D85186: [SyntaxTree] Add support for `LiteralExpression`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. We use inheritance to model the grammar's disjunction rule: literal: integer-literal character-literal floating-point-literal string-liter

[PATCH] D85185: [SyntaxTree] Add test coverage for `->*` operator

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. This was the last binary operator that we supported but didn't have any test coverage. The recent fix in a crash in member pointers allowed us to a

[clang-tools-extra] 7c4782c - [clang-tidy] Fix regression in RenamerClangTidy

Author: Nathan James Date: 2020-08-04T09:27:01+01:00 New Revision: 7c4782ce91d66a8447a851362b99bb86a42b7c08 URL: https://github.com/llvm/llvm-project/commit/7c4782ce91d66a8447a851362b99bb86a42b7c08 DIFF: https://github.com/llvm/llvm-project/commit/7c4782ce91d66a8447a851362b99bb86a42b7c08.diff

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

ro added a reviewer: MaskRay. ro added a comment. Ping? It's been two weeks now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412 ___ cfe-commits mailing list cfe

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

gamesh411 added a comment. I would add one more test for the undefined case. Like a local array variable that is uninitialized. That could mirror some of the null-dereference cases. Comment at: clang/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:135 +DerefKindStr = "d

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

eduucaldas updated this revision to Diff 282814. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85146/new/ https://reviews.llvm.org/D85146 Files: clang/lib/T

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint())); TRY_TO(TraverseConceptReference(*TC)); hokein wr

<    1   2