[PATCH] D85453: [PowerPC] Implement __int128 vector divide operations

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Overall LGTM. Comment at: llvm/test/CodeGen/PowerPC/p10-vector-divide.ll:53 + +define <1 x i128> @test_vdivsq(<1 x i128> %x, <1 x i128> %y) nounwind readnone { +;

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1144 +(v1i128 (VSLQ v1i128:$VRA, v1i128:$VRB))>; + def : Pat<(v1i128 (PPCshl v1i128:$VRA, v1i128:$VRB)), +(v1i128 (VSLQ v1i128:$VRA, v1i128:$VRB))>; amyk

[PATCH] D85500: [clangd] Highlight structured bindings at local scope as LocalVariable

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

MaskRay added a comment. The file is auto-generated by: `path/to/clang-tblgen -gen-opt-docs -I clang/include/clang/Driver -I llvm/include/ clang/include/clang/Driver/ClangOptionDocs.td > clang/docs/ClangCommandLineReference.rst` The description is retrieved from `DocBrief`. It `DocBrief` does

[PATCH] D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings

rtrieu added a comment. In D85287#2199490 , @sberg wrote: > In D85287#2199463 , @rtrieu wrote: > >> Also, have you tried running warning over a codebase? > > As I wrote: "At least building LibreOffice with this

[clang-tools-extra] b284767 - Reinstate check that we don't crash.

Author: Richard Smith Date: 2020-08-06T19:07:50-07:00 New Revision: b2847671b83f6acb71a78d4e37bd57967c858f4e URL: https://github.com/llvm/llvm-project/commit/b2847671b83f6acb71a78d4e37bd57967c858f4e DIFF: https://github.com/llvm/llvm-project/commit/b2847671b83f6acb71a78d4e37bd57967c858f4e.diff

[clang-tools-extra] 2f1fffa - Disable clang-tidy test that started failing after clang commit ed5a18f.

Author: Richard Smith Date: 2020-08-06T19:06:06-07:00 New Revision: 2f1fffab73f83e6a729cb4d68a99f930e44bc7a8 URL: https://github.com/llvm/llvm-project/commit/2f1fffab73f83e6a729cb4d68a99f930e44bc7a8 DIFF: https://github.com/llvm/llvm-project/commit/2f1fffab73f83e6a729cb4d68a99f930e44bc7a8.diff

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4ba7a100a56: [clangd] Semantic highlighting for dependent template name in template argument (authored by nridge). Repository: rG LLVM Github

[clang-tools-extra] f4ba7a1 - [clangd] Semantic highlighting for dependent template name in template argument

Author: Nathan Ridge Date: 2020-08-06T21:23:49-04:00 New Revision: f4ba7a100a56b63f9b3eac709ecea9f514d90c00 URL: https://github.com/llvm/llvm-project/commit/f4ba7a100a56b63f9b3eac709ecea9f514d90c00 DIFF: https://github.com/llvm/llvm-project/commit/f4ba7a100a56b63f9b3eac709ecea9f514d90c00.diff

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:305 + break; +default:; +} nridge wrote: > hokein wrote: > > nit: move the trailing `;` to a new line. > I have done

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

nridge updated this revision to Diff 283784. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85272/new/ https://reviews.llvm.org/D85272 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

Re: [clang] ed5a18f - PR30738: Implement two-phase name lookup for fold-expressions.

Hi, it looks like this broke check-clang-tools, see e.g. http://45.33.8.238/linux/24975/step_8.txt Nico On Thu, Aug 6, 2020 at 7:57 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-08-06T16:56:39-07:00 > New Revision:

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers added a comment. Ping! Ok to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers added a comment. Thanks for the recent comments. I just pushed a few improvements over the last patch that didn't comprehend latest comments from @rsmith and @Quuxplusone. I'll read through those carefully and address those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers updated this revision to Diff 283780. vabridgers added a comment. use source from expression in fixit s/seperate/separate/ address some chained comparison ambiguities outside of original scope of changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

yonghong-song abandoned this revision. yonghong-song added a comment. inline asm can do the work, so abandon this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81479/new/ https://reviews.llvm.org/D81479

[clang] ed5a18f - PR30738: Implement two-phase name lookup for fold-expressions.

Author: Richard Smith Date: 2020-08-06T16:56:39-07:00 New Revision: ed5a18fc0399dce994aa354a33e6f981f9828647 URL: https://github.com/llvm/llvm-project/commit/ed5a18fc0399dce994aa354a33e6f981f9828647 DIFF: https://github.com/llvm/llvm-project/commit/ed5a18fc0399dce994aa354a33e6f981f9828647.diff

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rsmith added a comment. In D79279#2201136 , @rjmccall wrote: > In D79279#2200916 , @rsmith wrote: > >> In D79279#2197176 , @rjmccall wrote: >> >>> I thought part of the

[PATCH] D85485: Fix quiet mode in git-clang-format

Gvald added reviewers: jmerdich, rsmith, djasper, serge-sans-paille. Gvald added a comment. Quiet mode is very useful for scripting, when only the diff format output is required, or no output if not formatting is needed. In case of no modified files, git-clang-format will output to screen even

[PATCH] D85485: Fix quiet mode in git-clang-format

Gvald created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Gvald requested review of this revision. Eliminate output in quiet mode, when no modified files exists Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85485 Files:

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

rsmith added a comment. In D85191#2199574 , @ebevhan wrote: > In D85191#2197663 , @efriedma wrote: > >>> If the intent is for getTypeInfo to always return sizes that are multiples >>> of the char size, then the

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

tra added a comment. In D84364#2176091 , @yaxunl wrote: > I added a `Deferrable` bit to the diagnostics which can be specified in td > files. This can be added to individual diagnostic defs or added to a bunch of > diagnostic defs all together. > > This

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

yaxunl added a comment. I just saw bugzilla bug https://bugs.llvm.org/show_bug.cgi?id=46922 my patch https://reviews.llvm.org/D77954 is supposed to fix this issue. However since implicit host device functions often cause overloading resolution diagnostics on the device side which are not

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

zequanwu updated this revision to Diff 283744. zequanwu added a comment. Add new note and test case. I think for the class template case, the new note might not be useful, since they might simply caused by mismatch of template arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:210 + case ToolChain::CST_Libstdcxx: +llvm::report_fatal_error("linking libstdc++ unimplemented on AIX"); + } Should there be a test for the error message?

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

zequanwu added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:8710 } + QualType fromType = op->getType(); + auto *fromDecl = fromType.getTypePtr()->getPointeeCXXRecordDecl(); zequanwu wrote: > hans wrote: > > Can the reverse situation happen,

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro added a comment. Ping? It's been a week... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84029/new/ https://reviews.llvm.org/D84029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642 +int Num; +if (V == "future") + A->render(Args, CmdArgs); Another option would be `unstable`. Comment at:

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

zequanwu added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:8710 } + QualType fromType = op->getType(); + auto *fromDecl = fromType.getTypePtr()->getPointeeCXXRecordDecl(); hans wrote: > Can the reverse situation happen, where it's destType

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. In D79279#2200916 , @rsmith wrote: > In D79279#2197176 , @rjmccall wrote: > >> I thought part of the point of `__builtin_memcpy` was so that C library >> headers could do `#define

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay created this revision. MaskRay added reviewers: jyknight, pcc, phosek. Herald added subscribers: llvm-commits, cfe-commits, dang, steven.zhang, atanasyan, hiraditya, arichardson, sdardis. Herald added a reviewer: rengolin. Herald added projects: clang, LLVM. MaskRay requested review of

[PATCH] D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath

rsmith added a comment. Looks reasonable to me. I expect you'll find more places that need to learn how to handle dependent types in C, but this looks like a solid start. Comment at: clang/lib/AST/Expr.cpp:3757-3758 case NPC_ValueDependentIsNull: - if

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn created this revision. fhahn added reviewers: rjmccall, rsmith, hfinkel, jfb. Herald added subscribers: dang, dexonsmith. Herald added a project: clang. fhahn requested review of this revision. After the recent discussion on cfe-dev 'Can indirect class parameters be noalias?' [1], it seems

[PATCH] D85471: Make clang HIP headers compatible with C++98

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85471/new/ https://reviews.llvm.org/D85471

[clang] d6492d8 - Add -Wtautological-value-range-compare warning.

Author: Richard Smith Date: 2020-08-06T13:28:50-07:00 New Revision: d6492d874478b1d3b1ce3adb4c3044618bec29e9 URL: https://github.com/llvm/llvm-project/commit/d6492d874478b1d3b1ce3adb4c3044618bec29e9 DIFF: https://github.com/llvm/llvm-project/commit/d6492d874478b1d3b1ce3adb4c3044618bec29e9.diff

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6492d874478: Add -Wtautological-value-range-compare warning. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85256/new/

[PATCH] D85367: [clang, test, Darwin] Fix tests expecting Darwin target

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85367/new/ https://reviews.llvm.org/D85367

[clang] e1cad42 - [X86] Make getX86TargetCPU return std::string instead of const char *. Remove call to MakeArgString. NFCI

Author: Craig Topper Date: 2020-08-06T13:18:15-07:00 New Revision: e1cad4234cf3a3d0747c140e135e413ece22cf63 URL: https://github.com/llvm/llvm-project/commit/e1cad4234cf3a3d0747c140e135e413ece22cf63 DIFF: https://github.com/llvm/llvm-project/commit/e1cad4234cf3a3d0747c140e135e413ece22cf63.diff

[clang] 4df38a5 - [X86] Optimize out a few extra strlen calls in getX86TargetCPU. NFCI

Author: Craig Topper Date: 2020-08-06T13:18:15-07:00 New Revision: 4df38a5589f6fa23e161a76bdaa3180ad053791e URL: https://github.com/llvm/llvm-project/commit/4df38a5589f6fa23e161a76bdaa3180ad053791e DIFF: https://github.com/llvm/llvm-project/commit/4df38a5589f6fa23e161a76bdaa3180ad053791e.diff

[PATCH] D79279: Add overloaded versions of builtin mem* functions

tstellar added a comment. In D79279#2200916 , @rsmith wrote: > In D79279#2197176 , @rjmccall wrote: > >> I thought part of the point of `__builtin_memcpy` was so that C library >> headers could do `#define

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L updated this revision to Diff 283712. Xiangling_L marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84534/new/ https://reviews.llvm.org/D84534 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenModule.h

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L marked 3 inline comments as done. Xiangling_L added inline comments. Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:466 + + bool preprocessStructorList(const DataLayout , const Constant *List, + SmallVector );

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rsmith added a comment. In D79279#2197176 , @rjmccall wrote: > I thought part of the point of `__builtin_memcpy` was so that C library > headers could do `#define memcpy(x, y, z) __builtin_memcpy(x, y, z)`. If so, > the conformance issue touches

[PATCH] D85471: Make clang HIP headers compatible with C++98

scchan created this revision. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. scchan requested review of this revision. Automation to detect compiler features, such as CMake's target_compile_features, would attempt to detect compiler features by explicitly using

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

arsenm closed this revision. arsenm added a comment. 30eeb742f1d11d7a7036e3b8a3bffc1dfd252082 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79744/new/ https://reviews.llvm.org/D79744

[clang] 30eeb74 - clang: Use byref for aggregate kernel arguments

Author: Matt Arsenault Date: 2020-08-06T15:52:26-04:00 New Revision: 30eeb742f1d11d7a7036e3b8a3bffc1dfd252082 URL: https://github.com/llvm/llvm-project/commit/30eeb742f1d11d7a7036e3b8a3bffc1dfd252082 DIFF:

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

rsmith added a comment. The diagnostic we get for the case of three or more comparison operators here doesn't seem ideal. Perhaps we could do this check as part of the `SemaChecking` pass over the completed expression rather than doing it as we form the individual comparisons? That way we'll

[PATCH] D85247: [Darwin] [Driver] Clang should invoke dsymutil for multiarch builds

aprantl added inline comments. Comment at: clang/test/Driver/darwin-dsymutil.c:74 +// CHECK-DSYMUTIL-MULTIARCH: "/usr/bin/ld" "-demangle" "-object_path_lto" +// CHECK-DSYMUTIL-MULTIARCH: "/usr/bin/dsymutil" "-o" "a.out.dSYM" "a.out" Is a.out the `lipo`ed fat

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

rjmccall added a comment. Are you seriously adding an attribute to literally every argument and return value? Why is this the right representation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/ https://reviews.llvm.org/D82317

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

jrtc27 added a comment. If changes like this are required for all these tests this is going to be a complete pain for downstream forks like ours. At the very least, make whatever script you used to update these public, as I don't want to have to recreate it from scratch when merging this in. I

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79744/new/ https://reviews.llvm.org/D79744 ___ cfe-commits mailing list

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

jasonliu added inline comments. Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:466 + + bool preprocessStructorList(const DataLayout , const Constant *List, + SmallVector ); Xiangling_L wrote: > jasonliu wrote: > > Xiangling_L

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6139 +def note_compare_seperate_sides : Note< + "seperate the expression into two clauses to give it the intended mathematical meaning">; + Both in the string and

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:466 + + bool preprocessStructorList(const DataLayout , const Constant *List, + SmallVector );

[clang-tools-extra] 9f24148 - [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

Author: Aleksandr Platonov Date: 2020-08-06T21:45:21+03:00 New Revision: 9f24148b212698aca220ac923d215c2073e443ce URL: https://github.com/llvm/llvm-project/commit/9f24148b212698aca220ac923d215c2073e443ce DIFF:

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f24148b2126: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check. (authored by ArcsinX). Repository: rG LLVM Github

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

psmith added a comment. I agree it's not what I'd like. I'm not sure how to react to MaskRays comment. The top of the ClangCommandLineReference.rst says: --- NOTE: This file is automatically generated by running clang-tblgen

[PATCH] D85453: [PowerPC] Implement __int128 vector divide operations

Conanap created this revision. Conanap added reviewers: PowerPC, saghir, nemanjai, hfinkel. Conanap added projects: LLVM, clang, PowerPC. Herald added a subscriber: kbarton. Conanap requested review of this revision. Herald added a subscriber: wuzish. This patch implements __int128 vector divide

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84458/new/ https://reviews.llvm.org/D84458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a reviewer: theraven. rjmccall added a comment. One thing that's come up so far: you generally need to be looking through non-runtime protocols, not ignoring them. This matters when non-runtime protocols inherit from ordinary protocols. It may be useful to provide a generic

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:839-840 + // Skip host-only functions in the CUDA device compilation and device-only + // functions in the host compilation. + if (CGM.getLangOpts().CUDA && hliao wrote: > tra wrote: >

[PATCH] D85450: Support the standards-based dates for __has_c_attribute

aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. Herald added a subscriber: krytarowski. aaron.ballman requested review of this revision. WG14 N2481 was adopted with minor modifications at this week's WG14 meetings. The only modification to the paper was to correct

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

probinson added a comment. Whoa--that's the *help* text? Well, if that's the only documentation for options that there is, I guess it has to go there; but it seems pretty excessive for the (ideally concise) output of `clang --help`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:789 +// Remove "::" from the `SourceRange` +SR.setEnd(SR.getEnd().getLocWithOffset(-1)); + Newbie mistake. Corrected in latter commit Repository: rG LLVM Github

[PATCH] D85295: [SyntaxTree] Implement the List construct.

eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:247 + + TerminationKind getTerminationKind(); + gribozavr2 wrote: > I just realized that the rest of the syntax tree API does not use the `get~` > prefix. However, most of

[PATCH] D85427: [SyntaxTree][NFC] remove redundant namespace-specifiers

eduucaldas updated this revision to Diff 283659. eduucaldas added a comment. removed namespace specifiers `llvm::` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85427/new/ https://reviews.llvm.org/D85427 Files:

[PATCH] D85442: [HIP] Ignore invalid ar linker options

This revision was automatically updated to reflect the committed changes. Closed by commit rG96c2d5e99e32: [HIP] Ignore invalid ar linker options (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 96c2d5e - [HIP] Ignore invalid ar linker options

Author: Aaron En Ye Shi Date: 2020-08-06T17:39:41Z New Revision: 96c2d5e99e32340be1379959977f2d6247788db6 URL: https://github.com/llvm/llvm-project/commit/96c2d5e99e32340be1379959977f2d6247788db6 DIFF: https://github.com/llvm/llvm-project/commit/96c2d5e99e32340be1379959977f2d6247788db6.diff

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:839-840 + // Skip host-only functions in the CUDA device compilation and device-only + // functions in the host compilation. + if (CGM.getLangOpts().CUDA && tra wrote: > hliao wrote:

[PATCH] D84781: [SyntaxTree] Use PointerUnion instead of inheritance for alternative clauses in NNS

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:788-789 - -// Remove "::" from the `SourceRange` -SR.setEnd(SR.getEnd().getLocWithOffset(-1)); Newbie mistake causing the crash Comment at:

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

hliao updated this revision to Diff 283654. hliao added a comment. Revise the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85276/new/ https://reviews.llvm.org/D85276 Files: clang/lib/CodeGen/CodeGenPGO.cpp

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85276/new/ https://reviews.llvm.org/D85276

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

atrosinenko added a comment. I suspect there might be some terminology clash, so clarifying a bit just in case. It was probably better to refer to these functions as //LibCalls// - functions from the compiler support library (such as `libgcc`) such as `__adddf3`. While there are

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 added a comment. Could you add unit tests for methods in List and NNS? OK if they are in a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 added a comment. Please also add appropriate handling to `syntax::List::getDelimiterTokenKind`, `getTerminationKind`, and `canBeEmpty`. Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:240 return Children; -} +}; Repository: rG LLVM Github

[PATCH] D85295: [SyntaxTree] Implement the List construct.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:247 + + TerminationKind getTerminationKind(); + I just realized that the rest of the syntax tree API does not use the `get~` prefix. However, most of Clang does, as far as

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

hliao added a comment. In D85276#2200108 , @tra wrote: > In D85276#2199655 , @yaxunl wrote: > >> Do we need to disable pgo and coverage mapping for device compilation? Or it >> is already disabled? > > We already

[PATCH] D85337: [AMDGPU] gfx1031 target

rampitec added inline comments. Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1844 LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1030), + LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1031), LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_XNACK),

[clang] 8d072a4 - [OPENMP]Fix for Windows buildbots, NFC.

Author: Alexey Bataev Date: 2020-08-06T12:36:52-04:00 New Revision: 8d072a4405213623a1b13dbac2e451df81457343 URL: https://github.com/llvm/llvm-project/commit/8d072a4405213623a1b13dbac2e451df81457343 DIFF: https://github.com/llvm/llvm-project/commit/8d072a4405213623a1b13dbac2e451df81457343.diff

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 283643. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 283638. eduucaldas added a comment. Clean List specific code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

tra added a comment. In D85276#2199655 , @yaxunl wrote: > Do we need to disable pgo and coverage mapping for device compilation? Or it > is already disabled? We already disable profiling during device compilation for NVIDIA and AMD GPUs:

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:227-254 +namespace llvm { +template <> struct DenseMapInfo { + using FirstInfo = DenseMapInfo; + using SecondInfo = DenseMapInfo; + + static inline

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 283636. simoll added a comment. NFC. Cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 283632. simoll added a comment. Fixed debug info representation for bool vectors. Interpret 8*N with the N in vector_size(N) as the bool numbers of bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. We want NestedNameSpecifier syntax nodes to be generally supported, not only for `DeclRefExpr` and `DependentScopedDeclRefExpr`. To achieve this

[PATCH] D84781: Use PointerUnion instead of inheritance for alternative clauses in NNS

eduucaldas updated this revision to Diff 283627. eduucaldas added a comment. - [SyntaxTree] Fix crash on name specifier. This diff revision is based on https://reviews.llvm.org/D84348 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84781/new/

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev planned changes to this revision. kbobyrev added a comment. In D84811#2199891 , @hokein wrote: > In D84811#2199829 , @kbobyrev wrote: > >> In D84811#2199820 ,

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 283622. eduucaldas added a comment. - Update comments to reflect change in API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.org/D84348 Files:

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

hokein added a comment. In D84811#2199829 , @kbobyrev wrote: > In D84811#2199820 , @hokein wrote: > >> In D84811#2199510 , @kbobyrev wrote: >> >>> Even despite `FileFilter`

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

Anastasia added a comment. Can you extend test test/Preprocessor/macro_variadic.cl to cover C++ for OpenCL mode, otherwise LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new/ https://reviews.llvm.org/D85429

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

amyk accepted this revision. amyk added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:703 +vector signed __int128 test_vec_xl_sext_i8(void) { + // CHECK: load i8 + // CHECK: sext i8 It

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:643 assert(Loc.isValid() && "Invalid source location for NamedDecl"); - // FIXME: use the result to filter out symbols. - shouldIndexFile(SM.getFileID(Loc)); + if

[PATCH] D85285: [clangd] WIP experimentation with finding static grpc++ libraries

kbobyrev planned changes to this revision. kbobyrev added a comment. WIP, nothing important here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85285/new/ https://reviews.llvm.org/D85285 ___ cfe-commits

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

ArcsinX added a comment. In D85417#2199694 , @hokein wrote: > Looks like NotNullTerminatedResultCheck.cpp also has this pattern, we may > want to fix that as well. Yes, you are right. I will fix this in the next patch. Repository: rG LLVM Github

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev added a comment. In D84811#2199820 , @hokein wrote: > In D84811#2199510 , @kbobyrev wrote: > >> Even despite `FileFilter` not being fully implemented yet (an issue for a >> separate patch) I think this

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:643 assert(Loc.isValid() && "Invalid source location for NamedDecl"); - // FIXME: use the result to filter out symbols. - shouldIndexFile(SM.getFileID(Loc)); + if

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

hokein added a comment. In D84811#2199510 , @kbobyrev wrote: > Even despite `FileFilter` not being fully implemented yet (an issue for a > separate patch) I think this change should still be correct and is probably > OK to land, WDYT @hokein? Yes,

  1   2   >