[PATCH] D59615: [AArch64] When creating SISD intrinsic calls widen scalar args into a zero vectors, not undef

aemerson added a comment. Herald added a subscriber: danielkiss. Does anyone object to this? I'd like to get it off my review dashboard one way or the other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59615/new/ https://reviews.llvm.org/D59615

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Also thanks, let's land! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84520/new/ https://reviews.llvm.org/D84520

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge updated this revision to Diff 284576. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536 Files:

[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

nridge added a comment. In D85621#2205944 , @njames93 wrote: > In D85621#2205856 , @nridge wrote: > >> In D85621#2205803 , @hokein wrote: >> >>> Please run

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. I don't have further comments. Worth waiting for other opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85099/new/

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

nridge added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:4587 + return RParenLoc; +return getPattern()->getEndLoc(); + } Wouldn't `EllipsisLoc` be more accurate? Comment at: clang/test/AST/ast-dump-concepts.cpp:16

Buildbot numbers for the week of 08/02/2020 - 08/08/2020

Hello everyone, Below are some buildbot numbers for the last week of 08/02/2020 - 08/08/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 07/26/2020 - 08/01/2020

Hello everyone, Below are some buildbot numbers for the week of 07/26/2020 - 08/01/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green

Buildbot numbers for the week of 07/19/2020 - 07/25/2020

Hello everyone, Below are some buildbot numbers for the week of 07/19/2020 - 07/25/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green

[clang] 5fe1713 - [Sparc] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros on SPARCv9

Author: Brad Smith Date: 2020-08-11T00:04:24-04:00 New Revision: 5fe171321c018a811debc306a776dbdf27a306dd URL: https://github.com/llvm/llvm-project/commit/5fe171321c018a811debc306a776dbdf27a306dd DIFF: https://github.com/llvm/llvm-project/commit/5fe171321c018a811debc306a776dbdf27a306dd.diff

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan updated this revision to Diff 284573. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/lib/Driver/ToolChains/Fuchsia.cpp

[PATCH] D37809: [analyzer] PthreadLock: Refactor, use PostCall API. NFC.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, rnkovacs, szepet, baloghadamsoftware. This patch has already landed as

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ accepted this revision. NoQ added a comment. Let's land this! Damn, we've learned //a lot// from this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84600/new/ https://reviews.llvm.org/D84600

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

NoQ added a comment. In D84520#2206077 , @balazske wrote: > Do the null pointer and invalid pointer dereference belong to the same > checker, that is called //NullDereference//? Yup. And that's bad. Note that the only reason to have checker names is to

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

NoQ added a comment. Umm, why don't you extend `PthreadLockChecker` instead? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85431/new/ https://reviews.llvm.org/D85431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 4aaa977 - [Sema] Fix missing warning on initializer lists on field initializers with overloaded operators

Author: Zequan Wu Date: 2020-08-10T19:32:59-07:00 New Revision: 4aaa97700377a811dbcaf88a81ec068a5b517a4d URL: https://github.com/llvm/llvm-project/commit/4aaa97700377a811dbcaf88a81ec068a5b517a4d DIFF: https://github.com/llvm/llvm-project/commit/4aaa97700377a811dbcaf88a81ec068a5b517a4d.diff

[PATCH] D85574: [Sema] Fix missing warning on initializer lists on field initializers with overloaded operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aaa97700377: [Sema] Fix missing warning on initializer lists on field initializers with… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. After not warning on structs, this did find a real missing comma in the Chromium codebase, so thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545

[PATCH] D85696: [AST] add parenthesis locations for IfStmt and SwitchStmt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94c6ceab539e: [AST] add parenthesis locations for IfStmt and SwitchStmt (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES

[clang] 94c6cea - [AST] add parenthesis locations for IfStmt and SwitchStmt

Author: Zequan Wu Date: 2020-08-10T19:19:51-07:00 New Revision: 94c6ceab539efe26a1707124e803f444139c1b12 URL: https://github.com/llvm/llvm-project/commit/94c6ceab539efe26a1707124e803f444139c1b12 DIFF: https://github.com/llvm/llvm-project/commit/94c6ceab539efe26a1707124e803f444139c1b12.diff

[PATCH] D85696: [AST] add parenthesis locations for IfStmt and SwitchStmt

zequanwu updated this revision to Diff 284557. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85696/new/ https://reviews.llvm.org/D85696 Files:

[PATCH] D85574: [Sema] Fix missing warning on initializer lists on field initializers with overloaded operators

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85574/new/ https://reviews.llvm.org/D85574 ___

[PATCH] D85385: [X86][FPEnv] Teach X86 mask compare intrinsics to respect strict FP semantics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85385/new/ https://reviews.llvm.org/D85385

[PATCH] D85574: [Sema] Fix missing warning on initializer lists on field initializers with overloaded operators

zequanwu added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3584-3585 if (!isa(Base->IgnoreParenImpCasts())) return; rtrieu wrote: > Does the warning work if it was changed to be "Visit(Base);" before the > return here instead

[PATCH] D85574: [Sema] Fix missing warning on initializer lists on field initializers with overloaded operators

zequanwu updated this revision to Diff 284551. zequanwu marked an inline comment as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85574/new/ https://reviews.llvm.org/D85574 Files:

[PATCH] D85385: [X86][FPEnv] Teach X86 mask compare intrinsics to respect strict FP semantics.

pengfei added inline comments. Comment at: clang/test/CodeGen/avx512f-builtins-constrained-cmp.c:793 // CHECK-LABEL: test_mm512_mask_cmp_pd_mask_true_us - // CHECK: [[CMP:%.*]] = call <8 x i1> @llvm.x86.avx512.cmp.pd.512(<8 x double> %{{.*}}, <8 x double> %{{.*}}, i32 31,

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

jdoerfert added a comment. (I'm going to sneak in `!range !` as well) Comment at: llvm/utils/UpdateTestChecks/common.py:330 +IR_VALUE_REGEXP_STRING += nameless_value.ir_prefix + r'(' + nameless_value.ir_regexp + r')' +IR_VALUE_REGEXP_SUFFIX = r'([,\s\(\)]|\Z)'

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

jdoerfert updated this revision to Diff 284543. jdoerfert marked an inline comment as done. jdoerfert added a comment. added @MaskRays's tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85099/new/ https://reviews.llvm.org/D85099 Files:

[PATCH] D83088: Introduce CfgTraits abstraction

dblaikie added a comment. This seems like a strange hybrid between a static-polymorphism (with traits) and dynamic polymorphism (with base classes/virtual functions). Could this more readily be just one or the other? (sounds like you're leaning towards dynamic polymorphism) Repository: rG

[PATCH] D85696: [AST] add parenthesis locations for IfStmt and SwitchStmt

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Only relatively trivial comments; please feel free to commit once they're addressed. Comment at: clang/include/clang/Sema/Sema.h:4382-4393 + StmtResult

[clang] ed66df6 - test commit

Author: Albion Fung Date: 2020-08-10T21:18:36-04:00 New Revision: ed66df6705a9dffc36fecc3468cc3ab430849182 URL: https://github.com/llvm/llvm-project/commit/ed66df6705a9dffc36fecc3468cc3ab430849182 DIFF: https://github.com/llvm/llvm-project/commit/ed66df6705a9dffc36fecc3468cc3ab430849182.diff

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10164 const BuiltinType *BT = cast(T); -assert(BT->isInteger()); +if (!BT->isInteger()) { + // This can happen in a conditional expression with a throw statement Mordante

[PATCH] D85574: [Sema] Fix missing warning on initializer lists on field initializers with overloaded operators

rtrieu added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3584-3585 if (!isa(Base->IgnoreParenImpCasts())) return; Does the warning work if it was changed to be "Visit(Base);" before the return here instead of the change

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

MaskRay added a comment. Mostly looks good. Comment at: llvm/utils/UpdateTestChecks/common.py:309 + +nameless_values = [] +# Description of the different "unnamed" values we match in the IR, e.g., ```lang=python nameless_values = [ NamelessValue(r'TMP',

[PATCH] D85699: PR47099: Split out of .

rsmith created this revision. rsmith added reviewers: hans, BillyONeal. Herald added subscribers: cfe-commits, jfb, mgorny. Herald added a project: clang. rsmith requested review of this revision. This aims to be compatible with Visual C++'s , but not exactly match it. The contents of are a

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

jdoerfert updated this revision to Diff 284537. jdoerfert added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85099/new/

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. I found another case. See how everything after the //requires-clause// is indented for constructors with just the constructor's name (it works otherwise, maybe because it looks like a function). class [[nodiscard]] data_t { public: template

[PATCH] D85385: [X86][FPEnv] Teach X86 mask compare intrinsics to respect strict FP semantics.

craig.topper added inline comments. Comment at: clang/test/CodeGen/avx512f-builtins-constrained-cmp.c:793 // CHECK-LABEL: test_mm512_mask_cmp_pd_mask_true_us - // CHECK: [[CMP:%.*]] = call <8 x i1> @llvm.x86.avx512.cmp.pd.512(<8 x double> %{{.*}}, <8 x double> %{{.*}}, i32

[PATCH] D85695: [OpenMP] split execution of a long test into smaller parts.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85695/new/ https://reviews.llvm.org/D85695 ___

[PATCH] D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`

fghanim added a comment. In D85619#2208425 , @kiranchandramohan wrote: > Before I start, Why is this change all new code and no modification or > deletion of existing Clang functionality for omp single/copyprivate? Because the OMPBuilder currently is

[PATCH] D85385: [X86][FPEnv] Teach X86 mask compare intrinsics to respect strict FP semantics.

pengfei added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85385/new/ https://reviews.llvm.org/D85385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped

Eugene.Zelenko added a comment. Please mention new check in Release Notes. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-prefer-scoped-enums-over-unscoped.rst:22 + +After the fix is applied, the enum will become: + Please enclose enum

[PATCH] D85685: [WIP] Support dwarf fission for wasm object files

aardappel accepted this revision. aardappel added a comment. This revision is now accepted and ready to land. Nice, fairly unintrusive actually. If you desperately wanted to fix the need for changing `W` dynamically, you could instead make it allocate a second `WasmObjectWriter` to write the

[PATCH] D85696: [AST] add parenthesis locations for IfStmt and SwitchStmt

zequanwu updated this revision to Diff 284532. zequanwu added a comment. Forgot changes on ASTReaderStmt.cpp, added now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85696/new/ https://reviews.llvm.org/D85696 Files:

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped

janosbenjaminantal created this revision. janosbenjaminantal added reviewers: alexfh, njames93, xazax.hun, Eugene.Zelenko. Herald added subscribers: cfe-commits, aaron.ballman, rnkovacs, kbarton, mgorny, nemanjai. Herald added a project: clang. janosbenjaminantal requested review of this

[clang] 0fd3d37 - Improve diagnostic for an expression that's not constant because it uses

Author: Richard Smith Date: 2020-08-10T17:03:19-07:00 New Revision: 0fd3d379e26da3cb02b6d960198e2efbc5190650 URL: https://github.com/llvm/llvm-project/commit/0fd3d379e26da3cb02b6d960198e2efbc5190650 DIFF: https://github.com/llvm/llvm-project/commit/0fd3d379e26da3cb02b6d960198e2efbc5190650.diff

[PATCH] D85696: [AST] add parenthesis locations for IfStmt and SwitchStmt

zequanwu created this revision. zequanwu added a reviewer: rsmith. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: shafik. Herald added a project: clang. zequanwu requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85696

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

yaxunl added a comment. In D84068#2208394 , @arsenm wrote: >> > > Long term, I'd rather aim for merging rocm-device-libs into libclc and making > it an llvm project. They're largely forks of the same original sources from > about 5 years ago, and it's

[PATCH] D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`

kiranchandramohan added a comment. Before I start, Why is this change all new code and no modification or deletion of existing Clang functionality for omp single/copyprivate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85619/new/

[clang] fb04d7b - [CUDA][HIP] Do not externalize implicit constant static variable

Author: Yaxun (Sam) Liu Date: 2020-08-10T19:02:49-04:00 New Revision: fb04d7b4a69831f6b999b1776da738557b108e0d URL: https://github.com/llvm/llvm-project/commit/fb04d7b4a69831f6b999b1776da738557b108e0d DIFF:

[PATCH] D85686: [CUDA][HIP] Do not externalize implicit constant static variable

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGfb04d7b4a698: [CUDA][HIP] Do not externalize implicit constant static variable (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[PATCH] D85695: [OpenMP] split execution of a long test into smaller parts.

tra added a comment. The test is no longer sticking out: https://gist.github.com/Artem-B/d0b05c2e98a49158c02de23f7f4f0279 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85695/new/ https://reviews.llvm.org/D85695

[PATCH] D85685: [WIP] Support dwarf fission for wasm object files

dschuff updated this revision to Diff 284522. dschuff added a comment. Fix bad diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

arsenm added a comment. In D84068#2208132 , @tra wrote: > In D84068#2204713 , @arsenm wrote: > >>> If we ship them with clang, who/where/how builds them? >>> If they come from ROCm packages, how would those

[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

tra added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_18.cpp:5 + +///==/// +// RUN: %clang_cc1 -DUSE -DCK19 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple

[PATCH] D85695: [OpenMP] split execution of a long test into smaller parts.

tra created this revision. tra added reviewers: ABataev, jdoerfert. Herald added subscribers: sanjoy.google, bixia, guansong, yaxunl. Herald added a project: clang. tra requested review of this revision. Herald added a subscriber: sstefan1. This test is bottlenecked by heavy regex use (~0.6s per

[clang] 09517a9 - Add regression test from PR46487.

Author: Richard Smith Date: 2020-08-10T15:55:27-07:00 New Revision: 09517a90682f05f13dca7d976aeaa5437beeb8f3 URL: https://github.com/llvm/llvm-project/commit/09517a90682f05f13dca7d976aeaa5437beeb8f3 DIFF: https://github.com/llvm/llvm-project/commit/09517a90682f05f13dca7d976aeaa5437beeb8f3.diff

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Pushed fix. It should not warn for structs or long texts. ut 11. 8. 2020 o 0:34 Arthur Eubanks via Phabricator napísal(a): > > aeubanks added a comment. > > In D85545#2208266 , @arthur.j.odwyer > wrote: > > > To decrease the number of false-positives,

[clang] 4b59dc7 - [Diagnostics] Ignore structs and long text for -Wstring-concatenation

Author: Dávid Bolvanský Date: 2020-08-11T00:49:58+02:00 New Revision: 4b59dc77dc473bba849c1b08f3a1ab7be5733ad1 URL: https://github.com/llvm/llvm-project/commit/4b59dc77dc473bba849c1b08f3a1ab7be5733ad1 DIFF:

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

MaskRay abandoned this revision. MaskRay added a comment. Herald added subscribers: aaron.ballman, sstefan1. Landed with a change that only changes the explicit -fno-semantic-interposition behavior, so there was very little test change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

rsmith added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump %s | FileCheck %s + I don't think we really need a dedicated AST test for this. Such tests

[PATCH] D85686: [CUDA][HIP] Do not externalize implicit constant static variable

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11196 return !getLangOpts().GPURelocatableDeviceCode && - (D->hasAttr() || D->hasAttr()) && + (D->hasAttr() || + (D->hasAttr() &&

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. In D85545#2208266 , @arthur.j.odwyer wrote: > To decrease the number of false-positives, you could emit the warning only > if *exactly one* comma was missing. > > const char *likely_a_bug[] = { "a", "b", "c" "d", "e", "f",

[PATCH] D85635: [clangd] Compute the interactive code range for semantic highlighting.

nridge added a comment. Do you mean "inactive" (instead of "interactive") in the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85635/new/ https://reviews.llvm.org/D85635 ___ cfe-commits

[PATCH] D85692: python bindings: fix DeprecationWarning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d74dbc3bb1: python bindings: fix DeprecationWarning (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 05d74db - python bindings: fix DeprecationWarning

Author: Nick Desaulniers Date: 2020-08-10T15:25:23-07:00 New Revision: 05d74dbc3bb1d943a029e4abea211288c920f559 URL: https://github.com/llvm/llvm-project/commit/05d74dbc3bb1d943a029e4abea211288c920f559 DIFF:

[PATCH] D85692: python bindings: fix DeprecationWarning

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85692/new/ https://reviews.llvm.org/D85692

[PATCH] D85692: python bindings: fix DeprecationWarning

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, echristo, srhines. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. nickdesaulniers requested review of this revision. Fixes observed warning running `ninja check-all`:

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

For your godbolt example, you hit the heuristic to not warn, if literals count is <= 2. (motivated by many false positives; and I didnt see a true positive case, so..) >> you could emit the warning only if exactly one comma was missing. This could work. ut 11. 8. 2020 o 0:04 Arthur O'Dwyer

[clang] 4f2ad15 - [Clang] implement -fno-eliminate-unused-debug-types

Author: Nick Desaulniers Date: 2020-08-10T15:08:48-07:00 New Revision: 4f2ad15db535873dda9bfe248a2771023b64a43c URL: https://github.com/llvm/llvm-project/commit/4f2ad15db535873dda9bfe248a2771023b64a43c DIFF:

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

This revision was automatically updated to reflect the committed changes. nickdesaulniers marked an inline comment as done. Closed by commit rG4f2ad15db535: [Clang] implement -fno-eliminate-unused-debug-types (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

To decrease the number of false-positives, you could emit the warning only if *exactly one* comma was missing. const char *likely_a_bug[] = { "a", "b", "c" "d", "e", "f", "g", "h", "i" }; const char *likely_not_a_bug[] = { "a", "b" "c", "d" "e", "f" "g" }; const char

Re: [clang] 4dcbb9c - [clang] Add -fno-delayed-template-parsing to the added unit tests in DeclPrinterTest.cpp

Would be helpful to document in the commit message why a change is being made. On Wed, Aug 5, 2020 at 6:13 AM Bruno Ricci via cfe-commits wrote: > > > Author: Bruno Ricci > Date: 2020-08-05T14:13:05+01:00 > New Revision: 4dcbb9cef71afa549afe8f6b4d335b1c996f8079 > > URL: >

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Something like this: const char *Sources[] = { "// \\tparam aaa Bbb\n", "// \\tparam\n" "// aaa Bbb\n", "// \\tparam \n" "// aaa Bbb\n", "// \\tparam aaa\n" "// Bbb\n" }; annoys me :/ Any idea/heuristic how to avoid warning here? po 10. 8. 2020 o 23:48

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

For your cases, we currently do not warn. If possible, fetch the latest Clang trunk and re-evaluate on Firefox. po 10. 8. 2020 o 23:46 Arthur O'Dwyer napísal(a): > > It looks to me as if all of the false-positives so far have been not arrays > but structs. > > struct X { int a; const char *b;

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

It looks to me as if all of the false-positives so far have been *not arrays but structs*. struct X { int a; const char *b; int c; }; X x = { 41, "forty" "two", 43 }; // false-positive here The distinguishing feature here is that if you did insert a comma as suggested by the compiler, then the

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie accepted this revision. dblaikie added a comment. Looks good, thanks! Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %s +//

[PATCH] D85596: [Docs] Link to --print-supported-cpus option

nickdesaulniers added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:346 - Aliases of --print-supported-cpus + Aliases of :option:`--print-supported-cpus` Would you mind adding a `.` for punctuation while you're here? Repository: rG

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

I moved it to -Wextra due to false positives. > Should there be some exception for line length Yeah, but sure how to define the threshold or so. :/ po 10. 8. 2020 o 23:21 dmajor via Phabricator napísal(a): > > dmajor added a comment. > > In the Firefox repo this warning is firing on a number

[clang] b2c9b63 - [Diagnostics] Move -Wstring-concatenation to -Wextra

Author: Dávid Bolvanský Date: 2020-08-10T23:36:33+02:00 New Revision: b2c9b631bb48087c988d798adc5465499b155a9a URL: https://github.com/llvm/llvm-project/commit/b2c9b631bb48087c988d798adc5465499b155a9a DIFF:

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %s +// NO_DEBUG_UNUSED_TYPES:

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %s +// NO_DEBUG_UNUSED_TYPES:

[PATCH] D85575: [ARM] Speed up arm-cortex-cpus.c test

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c8ae4086031: [ARM] Speed up arm-cortex-cpus.c test (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85575/new/

[clang] 9c8ae40 - [ARM] Speed up arm-cortex-cpus.c test

Author: Artem Belevich Date: 2020-08-10T14:27:19-07:00 New Revision: 9c8ae40860311e94de0a898101818f706228e958 URL: https://github.com/llvm/llvm-project/commit/9c8ae40860311e94de0a898101818f706228e958 DIFF:

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80735/new/ https://reviews.llvm.org/D80735 ___

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1,

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

dmajor added a comment. In the Firefox repo this warning is firing on a number of strings that were broken up by clang-format (or humans) for line length, for example

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

tra added a subscriber: echristo. tra added a comment. In D84068#2204713 , @arsenm wrote: >> If we ship them with clang, who/where/how builds them? >> If they come from ROCm packages, how would those packages add stuff into >> *clang* install directory?

[PATCH] D83325: [Sema] Iteratively strip sugar when removing address spaces.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83325/new/ https://reviews.llvm.org/D83325

[PATCH] D85312: [ADT] Move FixedPoint.h from Clang to LLVM.

rjmccall accepted this revision. rjmccall added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85312/new/ https://reviews.llvm.org/D85312 ___ cfe-commits mailing list

[clang] 62223ff - [Diagnostics] Avoid false positives with -Wstring-concatenation

Author: Dávid Bolvanský Date: 2020-08-10T23:05:01+02:00 New Revision: 62223ff1376b540dc9612239fdfb11b376d796d3 URL: https://github.com/llvm/llvm-project/commit/62223ff1376b540dc9612239fdfb11b376d796d3 DIFF:

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1, i64

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8*

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

tra added a comment. > The fix is here https://reviews.llvm.org/D85686 Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80858/new/ https://reviews.llvm.org/D80858 ___ cfe-commits mailing list

[PATCH] D85686: [CUDA][HIP] Do not externalize implicit constant static variable

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ASTContext.cpp:11196 return !getLangOpts().GPURelocatableDeviceCode && - (D->hasAttr() || D->hasAttr()) && + (D->hasAttr() || +

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84992/new/ https://reviews.llvm.org/D84992

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1, i64

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

yaxunl added a comment. In D80858#2207898 , @tra wrote: >> We can restrict externalization to constant variables with explicit >> 'constant' attributes only, which should fix this issue. > > SGTM. If it does not have explicit device-side attribute, it's

[PATCH] D85686: [CUDA][HIP] Do not externalize implicit constant static variable

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. https://reviews.llvm.org/D85686 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaExpr.cpp clang/test/CodeGenCUDA/static-device-var-no-rdc.cu

  1   2   3   >