[PATCH] D85337: [AMDGPU] gfx1031 target

rampitec marked 2 inline comments as done. rampitec added inline comments. Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1844 LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1030), + LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1031),

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

guiand added a comment. I don't think we can necessarily guarantee `argmemonly/readonly/writeonly`, particularly since these library calls can take a lock somewhere inside. I'll definitely add `nocapture` and `willreturn` though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D85685: [WIP] Support dwarf fission for wasm object files

dschuff created this revision. dschuff added reviewers: sbc100, aardappel. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, aprantl. Herald added projects: clang, LLVM. dschuff requested review of this revision. Herald added a subscriber: aheejin. Initial support for

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Logs look quite old. http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/11291/steps/build-stage2-unified-tree/logs/stdio are newest logs? Maybe I can tune the warning more to avoid false positives. po 10. 8. 2020 o 21:46 Kamau Bridgeman via Phabricator napísal(a): > > kamaub

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

Mordante marked an inline comment as done. Mordante added a comment. I added `void g()` since that's valid code which also caused an assertion failure. So the issue isn't in the error recovery but in determining the required IntRange. It seems the code doesn't take

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2503 + llvm::Align Alignment = + CGM.getNaturalTypeAlignment(ETy).getAsAlign(); + AI->addAttrs(llvm::AttrBuilder().addAlignmentAttr(Alignment));

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

kamaub added a comment. Hello, sorry but can you please revert this commit and recommit it when you have a fix or work around that doesn't break our bots: It breaks http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/11228 which builds with `-Werror` Please also note that it

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

tra added a comment. > We can restrict externalization to constant variables with explicit > 'constant' attributes only, which should fix this issue. SGTM. If it does not have explicit device-side attribute, it's never going to need to cross host/device boundary. I guess this applies to vars

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante updated this revision to Diff 284478. Mordante added a comment. Addresses the review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/ https://reviews.llvm.org/D85612 Files: clang/lib/Sema/SemaCast.cpp clang/test/AST/ast-dump-enum-bool.cpp

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2503 + llvm::Align Alignment = + CGM.getNaturalTypeAlignment(ETy).getAsAlign(); + AI->addAttrs(llvm::AttrBuilder().addAlignmentAttr(Alignment));

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. refixing in https://reviews.llvm.org/D80242 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85565/new/ https://reviews.llvm.org/D85565

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Hi @dblaikie , sorry for messing up the upload, I think it's good now, but to see the latest change, you'll need to look at the diff between the 2 prior versions (https://reviews.llvm.org/D80242?vs=284053=284477#toc). I reverted this on Friday. It looks like

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump=json %s | FileCheck %s + rsmith wrote: > aaron.ballman

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284477. nickdesaulniers added a comment. - squash and reupload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files:

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284476. nickdesaulniers added a comment. This revision is now accepted and ready to land. - rebase, move Codegen tests to _cc1, move -g1 test to driver test, use more regex for ![0-9]+, manually test --target=x86_64-apple-macosx10.15.0 which has a

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

efriedma added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84992/new/ https://reviews.llvm.org/D84992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

yaxunl added a comment. In D80858#2207699 , @tra wrote: > Sam, just a FYI that the patch has a couple of unintended consequences. > > We now end up with various things instantiated as device-side __constant__ > objects when they were not before, when we

[PATCH] D68720: Support -fstack-clash-protection for x86

xbolva00 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1778 + HelpText<"Enable stack clash protection">; +def fnostack_clash_protection : Flag<["-"], "fnostack-clash-protection">, Group, + HelpText<"Disable stack clash protection">;

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

aaron.ballman added a comment. In D85193#2207052 , @ArcsinX wrote: > In D85193#2204685 , @aaron.ballman > wrote: > >> Should the `StructuredIndex` still be incremented even in the case of an >> error, as done

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

cameron.mcinally added a comment. MIN/MAX and DIVs are up my alley. I'll try those. Will check out VREDUCE if I get through the others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71767/new/ https://reviews.llvm.org/D71767

[PATCH] D68720: Support -fstack-clash-protection for x86

sberg added inline comments. Herald added a subscriber: dang. Comment at: clang/include/clang/Driver/Options.td:1778 + HelpText<"Enable stack clash protection">; +def fnostack_clash_protection : Flag<["-"], "fnostack-clash-protection">, Group, + HelpText<"Disable stack clash

[PATCH] D85599: [Clang] Consider __builtin_trap() and __builtin_debugtrap() as terminator

ZhangKang updated this revision to Diff 284424. ZhangKang added a comment. Herald added a subscriber: hiraditya. Remoeve isTerminator for TRAP instruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85599/new/ https://reviews.llvm.org/D85599

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 284463. yaxunl marked 2 inline comments as done. yaxunl added a comment. Revised by James' comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. @kuhnel do you want to take a look or is it okay if I just submit the change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ cfe-commits mailing list

[PATCH] D85599: [PowerPC] Remove isTerminator for TRAP instruction

ZhangKang added a comment. In D85599#2206033 , @efriedma wrote: > Fixing a MachineVerifier issue by patching clang is generally wrong; if the > IR is valid, the backend should do something sane with it. If the IR isn't > valid, the IR Verifier should

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D71726#2207148 , @jyknight wrote: > In D71726#2182667 , @tra wrote: > >>> If a target would like to treat single and double fp atomics as >>>

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

tra added a comment. Sam, just a FYI that the patch has a couple of unintended consequences. We now end up with various things instantiated as device-side __constant__ objects when they were not before, when we compile with -std=c++17 (especially with libc++): https://godbolt.org/z/KbTM9M

[PATCH] D85676: [NewPM] collapsing nested pass mangers of the same type

ychen created this revision. ychen added reviewers: asbirlea, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. ychen requested review of this revision. This is one of the reason for extra invalidations in D84959

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

eugenis added a comment. nocapture on the pointer argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85573/new/ https://reviews.llvm.org/D85573 ___ cfe-commits mailing list

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

eugenis added a comment. While we are here, how about setting a few more attributes? argmemonly, readonly/writeonly, willreturn come to mind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85573/new/ https://reviews.llvm.org/D85573

[PATCH] D85312: [ADT] Move FixedPoint.h from Clang to LLVM.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. The patch seems straightforward. Other than moving code and trimming `llvm::` from types, not sure if there's anything else I should expect. LGTM. Repository: rG LLVM Github

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

steakhal added a comment. In D81254#2122449 , @ASDenysPetrov wrote: > @NoQ, thanks for the examples. > > I didn't get the first one. How do you get to the "//In reality we don't > know//", if we don't touch `a[index1]`: If `index1` and `index2` has the

[clang] a3036b3 - Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record

Author: Alexandre Ganea Date: 2020-08-10T13:36:30-04:00 New Revision: a3036b386383f1c1e9d32c2c8dba995087959da3 URL: https://github.com/llvm/llvm-project/commit/a3036b386383f1c1e9d32c2c8dba995087959da3 DIFF:

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

This revision was automatically updated to reflect the committed changes. Closed by commit rG70d583ad1287: [clangd] Have template template arguments target their referenced template decl (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 70d583a - [clangd] Have template template arguments target their referenced template decl

Author: Nathan Ridge Date: 2020-08-10T13:27:23-04:00 New Revision: 70d583ad12872ef8714b15f1d1e982f1db6d9a15 URL: https://github.com/llvm/llvm-project/commit/70d583ad12872ef8714b15f1d1e982f1db6d9a15 DIFF: https://github.com/llvm/llvm-project/commit/70d583ad12872ef8714b15f1d1e982f1db6d9a15.diff

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:1011-1015 + if (Header.front() == '<' && Header.back() == '>') { +IsSystemInclude = true; +Header.pop_back(); +Header.erase(0, 1); + } alexfh

[PATCH] D85666: [clang-tidy] IncludeInserter: allow <> in header name

alexfh created this revision. alexfh added reviewers: aaron.ballman, hokein. Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: clang. alexfh requested review of this revision. Herald added a subscriber: wuzish. This adds a pair of overloads for

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 284425. dgoldman added a comment. Rebase + lint fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4061d9e42cff: [clangd] Fix crash-bug in preamble indexing when using modules. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80525/new/

[clang] 4061d9e - [clangd] Fix crash-bug in preamble indexing when using modules.

Author: Adam Czachorowski Date: 2020-08-10T18:42:57+02:00 New Revision: 4061d9e42cff621462931ac7df9666806c77a237 URL: https://github.com/llvm/llvm-project/commit/4061d9e42cff621462931ac7df9666806c77a237 DIFF:

[PATCH] D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82609/new/ https://reviews.llvm.org/D82609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3843 /// The declaration that this binding binds to part of. + // FIXME: Currently not set during deserialization of the BindingDecl; + // only set when the corresponding DecompositionDecl is

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. I would prefer to avoid the situation where the markings of two otherwise identical files were different, depending on how the files were produced, no matter if it was a common or a special case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

paulwalker-arm added a comment. In D71767#2207158 , @cameron.mcinally wrote: > In D71767#2206947 , @paulwalker-arm > wrote: > >> @cameron.mcinally this is the patch I mentioned the other day, which >> contains

[PATCH] D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF

JVApen added subscribers: Rakete, djasper, klimek, mlekena, MyDeveloperDay, owenpan, sammccall, shenhan. JVApen added a comment. Any chance we can still get this in LLVM 11? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60996/new/

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

nsz added a comment. In D80791#2206933 , @chill wrote: > In D80791#2206853 , @nsz wrote: > >> i think that cannot work. >> >> the implementation is free to inject arbitrary code into >> user code so if the user

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

cameron.mcinally added a comment. In D71767#2206947 , @paulwalker-arm wrote: > @cameron.mcinally this is the patch I mentioned the other day, which contains > the nodes where once I've written suitable tests I'll push separate patches > for. Thanks,

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. Oh, one more note, C11 has -- and clang already supports -- `_Atomic long double x; x += 4;` via lowering to a cmpxchg loop. Now that we have an LLVM IR representation for atomicrmw fadd/fsub, clang should be lowering the _Atomic += to that, too. (Doesn't need to be

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. In D71726#2182667 , @tra wrote: >> If a target would like to treat single and double fp atomics as unsupported, >> it can override the default behavior in its own TargetInfo. I really don't think this should be a target option

[PATCH] D83325: [Sema] Iteratively strip sugar when removing address spaces.

ebevhan updated this revision to Diff 284395. ebevhan retitled this revision from "[Sema] Be more thorough when unpacking the AS-qualified pointee for a pointer conversion." to "[Sema] Iteratively strip sugar when removing address spaces.". ebevhan edited the summary of this revision. ebevhan

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

ArcsinX added a comment. In D85193#2204685 , @aaron.ballman wrote: > Should the `StructuredIndex` still be incremented even in the case of an > error, as done around line 1589 and 1647? Yes, it looks like we need to increment `StructuredIndex`. > Do

[clang-tools-extra] e2d61ae - Correctly set CompilingPCH in PrecompilePreambleAction.

Author: Adam Czachorowski Date: 2020-08-10T17:49:23+02:00 New Revision: e2d61ae5733316a14783b36c84b8e7681b0e3d59 URL: https://github.com/llvm/llvm-project/commit/e2d61ae5733316a14783b36c84b8e7681b0e3d59 DIFF:

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2d61ae57333: Correctly set CompilingPCH in PrecompilePreambleAction. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] f9500cc - [SyntaxTree] Expand support for `NestedNameSpecifier`

Author: Eduardo Caldas Date: 2020-08-10T15:47:20Z New Revision: f9500cc487573c55ea37b4ee6e9162d115753a48 URL: https://github.com/llvm/llvm-project/commit/f9500cc487573c55ea37b4ee6e9162d115753a48 DIFF: https://github.com/llvm/llvm-project/commit/f9500cc487573c55ea37b4ee6e9162d115753a48.diff

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

alexfh accepted this revision. alexfh added a comment. LG with a couple of comments. Do you need someone to land the patch for you? Comment at: clang-tools-extra/clang-tidy/add_new_check.py:139 const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); - if

[clang] 7406eb4 - [Hexagon] Avoid creating an empty target feature

Author: Krzysztof Parzyszek Date: 2020-08-10T10:37:24-05:00 New Revision: 7406eb4f6afd8df9bd4dbb918f5e7005ba71d58c URL: https://github.com/llvm/llvm-project/commit/7406eb4f6afd8df9bd4dbb918f5e7005ba71d58c DIFF:

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz updated this revision to Diff 284390. adamcz added a comment. assert() -> ASSERT_TRUE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85532/new/ https://reviews.llvm.org/D85532 Files: clang-tools-extra/clangd/unittests/CMakeLists.txt

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas updated this revision to Diff 284387. eduucaldas marked 6 inline comments as done and 2 inline comments as done. eduucaldas added a comment. Answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85439/new/

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrorReturnChecker.cpp:63 + const BinaryOperator *BinOp, + const

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

paulwalker-arm added a comment. @cameron.mcinally this is the patch I mentioned the other day, which contains the nodes where once I've written suitable tests I'll push separate patches for. Anything else is fair game. This patch implements VSELECT but that was just to investigate what we

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. In D80791#2206853 , @nsz wrote: > i think that cannot work. > > the implementation is free to inject arbitrary code into > user code so if the user does not tell the implementation > that it wants the entire tu to be bti safe then

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

paulwalker-arm updated this revision to Diff 284380. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71767/new/ https://reviews.llvm.org/D71767 Files:

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. @NoQ just one more ping. You accepted it and then I just revised it again. Could you, please, take a minute and look at it. I'd close it with a great pleasure. It's been hanging too long. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas added a comment. There are some refinements to do, to generate a complete syntax tree. Namely tag decltype-name-specifier and simple-template-specifier children with roles, to allow for accessors. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:838-842 +

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL closed this revision. ShuhongL added a comment. Landed by commit: rGb129c9d81aff8ece71eb29df1e5f31136a48c040 (Sorry, I didn't properly align the tags in commit message and hence this revision was not automatically

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov updated this revision to Diff 284373. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Added recursive_mutex support. Please, look at a test file on TODOs. I want to cover those cases in the future. Could you advise me something on it? CHANGES

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

xazax.hun added a comment. In D85528#2205799 , @NoQ wrote: > I expect at least one LIT test //without// `-analyzer-config > crosscheck-with-z3=true` Agreed. I think the code snippet I proposed would be a great test to include with this revision.

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz updated this revision to Diff 284376. adamcz marked 2 inline comments as done. adamcz added a comment. var rename, comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80525/new/ https://reviews.llvm.org/D80525 Files:

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.h:71 + // required for use of modules. + // FIXME: Intercept the write of implicitly build module to disk and update + // TestFS with that content to avoid using real file system in tests.

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 284375. balazske marked an inline comment as done. balazske added a comment. - Renames. - Changed behavior if function call is compared to returned value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:839-840 + // Skip host-only functions in the CUDA device compilation and device-only + // functions in the host compilation. + if (CGM.getLangOpts().CUDA && tra wrote: > hliao wrote:

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7b683c126b8: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side… (authored by hliao). Repository: rG LLVM Github

[clang] c7b683c - [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

Author: Michael Liao Date: 2020-08-10T11:01:46-04:00 New Revision: c7b683c126b849dab5c81e7deecfc1e61f8563a0 URL: https://github.com/llvm/llvm-project/commit/c7b683c126b849dab5c81e7deecfc1e61f8563a0 DIFF: https://github.com/llvm/llvm-project/commit/c7b683c126b849dab5c81e7deecfc1e61f8563a0.diff

Re: [PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

The 08/10/2020 10:03, Momchil Velikov via Phabricator wrote: > chill added a comment. > > In D80791#2196598 , @nsz wrote: > > > the assumption is that the intended branch protection is implied via > > cmdline flags for the tu and function attributes are

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

riccibruno added inline comments. Comment at: clang/test/CXX/dcl.decl/dcl.meaning/dcl.fct.default/p7.cpp:51 + extern void h8a(int = sizeof(z)); // ok + extern void h8b(int = w); // expected-error {{default argument references local variable 'w'}}

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz added inline comments. Comment at: clang/unittests/Frontend/ASTUnitTest.cpp:146 + auto File = AU->getFileManager().getFileRef("Textual.h", false, false); + assert(File); + // Verify that we do not crash here. adamcz wrote: > kadircet wrote: > >

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

hokein added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint())); TRY_TO(TraverseConceptReference(*TC)); nridge

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

riccibruno updated this revision to Diff 284364. riccibruno marked 2 inline comments as done. riccibruno edited the summary of this revision. riccibruno added a comment. Refer to the binding in the diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz added inline comments. Comment at: clang/unittests/Frontend/ASTUnitTest.cpp:146 + auto File = AU->getFileManager().getFileRef("Textual.h", false, false); + assert(File); + // Verify that we do not crash here. kadircet wrote: > ASSERT_TRUE again You can

Re: [clang] b129c9d - Author: Shuhong Liu

@shuhong@ibm.com: I'm not sure what process you followed to commit this, but the commit message does not seem right. It might make sense to revert this and commit again with the proper message to make annotations from `git blame` work better. -- HT On Mon, Aug 10, 2020 at 10:33 AM Shuhong

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1697 +It's not allowed to annotate a statement with both ``likely`` and +``unlikely``. It's not recommended to annotate both branches of an ``if`` +statement with an attribute.

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz updated this revision to Diff 284365. adamcz marked an inline comment as done. adamcz added a comment. more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85532/new/ https://reviews.llvm.org/D85532 Files:

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestFS.h:51 + // This is useful for testing module support. + bool OverlayRealFileSystem = false; }; also ForModules here?

[PATCH] D84636: [RFC] Make the default LibCall implementations from compiler-rt builtins library more customizable

atrosinenko added a comment. Another note to myself: add `AUX_DECLS(__LibCallName)` to every generic implementation file. They were forgotten unintentionally. Comment at: compiler-rt/lib/builtins/arm-libcall-overrides.h:8

[clang] b129c9d - Author: Shuhong Liu

Author: Shuhong Liu Date: 2020-08-10T10:27:04-04:00 New Revision: b129c9d81aff8ece71eb29df1e5f31136a48c040 URL: https://github.com/llvm/llvm-project/commit/b129c9d81aff8ece71eb29df1e5f31136a48c040 DIFF: https://github.com/llvm/llvm-project/commit/b129c9d81aff8ece71eb29df1e5f31136a48c040.diff

[PATCH] D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath

hokein added a comment. In D85025#2201042 , @rsmith wrote: > Looks reasonable to me. I expect you'll find more places that need to learn > how to handle dependent types in C, but this looks like a solid start. Thanks! Yeah, we'd need to a detailed plan

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

Eugene.Zelenko added inline comments. Comment at: clang/docs/ReleaseNotes.rst:70 motivating use case for these types is to limit 'bit' usage, these types don't - automatically promote to 'int' when operations are done between two ``ExtInt(N)`` - types, instead math occurs

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1523 + TU.ExtraArgs.push_back("-fmodule-map-file=/module.map"); + TU.OverlayRealFileSystem = true; + sammccall wrote: > I'm a bit torn on this - this is

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz updated this revision to Diff 284360. adamcz marked 2 inline comments as done. adamcz added a comment. final(?) review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80525/new/ https://reviews.llvm.org/D80525 Files:

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL updated this revision to Diff 284357. ShuhongL added a comment. Fixed indent and updated error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85315/new/ https://reviews.llvm.org/D85315 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D84226: [AST][RecoveryExpr] Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 284358. hokein added a comment. - rebase; - add comments for CreateDependentBinOp, and make it private based on Richard's comment; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/

[clang] 6ef801a - [AIX] Static init frontend recovery and backend support

Author: Xiangling Liao Date: 2020-08-10T10:10:49-04:00 New Revision: 6ef801aa6bc01fc49a8e83ddb217470b5e2337dd URL: https://github.com/llvm/llvm-project/commit/6ef801aa6bc01fc49a8e83ddb217470b5e2337dd DIFF:

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ef801aa6bc0: [AIX] Static init frontend recovery and backend support (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D84534?vs=283712=284355#toc Repository: rG LLVM

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov updated this revision to Diff 284353. ASDenysPetrov added a comment. Aded enum FuncIdKind to define function Ids. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85431/new/ https://reviews.llvm.org/D85431 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added a comment. Thank you for starting the implementation work on these attributes! Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodDocs];

[clang] fdbd599 - [SyntaxTree] Implement `NestedNameSpecifier` using the `List` base API

Author: Eduardo Caldas Date: 2020-08-10T13:43:21Z New Revision: fdbd5996533dad25f00687f27ce8e7a8b7573ba3 URL: https://github.com/llvm/llvm-project/commit/fdbd5996533dad25f00687f27ce8e7a8b7573ba3 DIFF: https://github.com/llvm/llvm-project/commit/fdbd5996533dad25f00687f27ce8e7a8b7573ba3.diff

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 284343. MForster marked an inline comment as done. MForster added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files:

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 284344. eduucaldas added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

DavidTruby accepted this revision. DavidTruby added a comment. This revision is now accepted and ready to land. LGTM - please wait for someone more familiar with clang-tidy to review as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85218/new/

<    1   2   3   >