[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. It'll be good idea to add test case. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +* Added: Add IdentifierNamingCheck::CaseType, CT_HungarianNotation, supporting naming check with Hungarian notation. + Please move

[PATCH] D86763: RedeclarePropertyAccessor (clang/lib/Sema/SemaObjCProperty.cpp shipped with https://reviews.llvm.org/rG2073dd2da702baca447efaf1879cb6151e8c6100) create a synthesized property accessor

sunbohong created this revision. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. sunbohong requested review of this revision. ...metadata in RewriteModernObjC.cpp. This commit will fix https://bugs.llvm.org/show_bug.cgi?id=47330 . Repository: rG LLVM Github

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop created this revision. russell.gallop added reviewers: cryptoad, aganea, hans. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers, LLVM. russell.gallop requested review of this revision. This is basically

[PATCH] D86695: [RFC] Call ParseLangArgs for all inputs

hvdijk created this revision. Herald added subscribers: cfe-commits, atanasyan, arichardson, sdardis. Herald added a project: clang. hvdijk requested review of this revision. clang/lib/CodeGen/BackendUtil.cpp contains multiple checks for attributes of LangOpts. The option processing that sets up

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:473 def int_aarch64_neon_bfdot : AdvSIMD_Dot_Intrinsic; - def int_aarch64_neon_bfmmla :

[PATCH] D86581: [clang-format] Handle shifts within conditions

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think this LGTM and the solution is much more elegant than mine! You were not stepping on my toes, I'm always happy for someone else to take things over and this is a much

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan added inline comments. Comment at: llvm/include/llvm/IR/FixedPointBuilder.h:171-172 +// lossless, except for overflow to infinity which is unlikely. +return B.CreateFMul(Result, +ConstantFP::get(DstTy, std::pow(2, -(int)SrcSema.getScale(; + }

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. While doing 2-stage builds, the 2 `XFAIL`s due to Bug 42493 were required. However, I've since also done a 1-stage build with gcc 10, which shows Unexpectedly Passed Tests (2): UBSan-Standalone-sparc :: TestCases/Float/cast-overflow.cpp UBSan-Standalone-sparc ::

[PATCH] D86065: [SVE] Make ElementCount members private

david-arm updated this revision to Diff 288260. david-arm edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86065/new/ https://reviews.llvm.org/D86065 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGenTypes.cpp

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

nullptr.cpp added a comment. In D86691#2241401 , @Szelethus wrote: > Nice, thank you! Did you stumble across this, or found it with a tool? I just happened to see these code:-). Maybe we should write a checker to check this situation? I will start doing

[PATCH] D86065: [SVE] Make ElementCount members private

paulwalker-arm added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:108 + + bool isPowerOf2() const { return isPowerOf2_32(Min); } }; I don't believe this is safe. For example we know SVE supported vector lengths only have to be a multiple

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

phosek added a comment. We started seeing assertion failure after rolling a toolchain that contains this change and `git bisect` identified this change. I have filed a bug with a reproducer as PR47324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86688: [RecoveryExpr] Add 11.0.0 release note.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86688 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Nice, thank you! Did you stumble across this, or found it with a tool? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86691/new/

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 288250. c-rhodes added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85736/new/ https://reviews.llvm.org/D85736 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. The summary of this last discussion is that it is not acceptable to have only the simple check for the explicit comparison with a fixed constant. At least not for return types where the "implicit" check (a check that is always true or false for the error return value)

[clang] feed5a7 - [Sema][AArch64] Support arm_sve_vector_bits attribute

Author: Cullen Rhodes Date: 2020-08-27T10:38:32Z New Revision: feed5a7239d8ed0ec9f90775080ce8546bf364df URL: https://github.com/llvm/llvm-project/commit/feed5a7239d8ed0ec9f90775080ce8546bf364df DIFF: https://github.com/llvm/llvm-project/commit/feed5a7239d8ed0ec9f90775080ce8546bf364df.diff

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGfeed5a7239d8: [Sema][AArch64] Support arm_sve_vector_bits attribute (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85736/new/

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

nullptr.cpp created this revision. nullptr.cpp added reviewers: dcoughlin, NoQ, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang.

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

c-rhodes marked 7 inline comments as done. c-rhodes added a comment. @rsandifo-arm @aaron.ballman thanks for reviewing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85736/new/ https://reviews.llvm.org/D85736 ___ cfe-commits mailing list

[PATCH] D86101: [AArch64][SVE] Add missing debug info for ACLE types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e9b66de3f04: [AArch64][SVE] Add missing debug info for ACLE types. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D86101?vs=287911=288254#toc Repository: rG LLVM Github

[clang] 4e9b66d - [AArch64][SVE] Add missing debug info for ACLE types.

Author: Sander de Smalen Date: 2020-08-27T10:56:42+01:00 New Revision: 4e9b66de3f046c1e97b34c938b0920fa6401f40c URL: https://github.com/llvm/llvm-project/commit/4e9b66de3f046c1e97b34c938b0920fa6401f40c DIFF:

[PATCH] D86101: [AArch64][SVE] Add missing debug info for ACLE types.

sdesmalen added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86101/new/ https://reviews.llvm.org/D86101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. > It's worth noting that accessors in the base APIs don't follow this rule. > Should we refactor them as well? I'd say yes. > In this patch? Up to you. Repository: rG LLVM

[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file

atrosinenko added a comment. Uploaded because it was already approved and no other review comments received since then. Anyway, please feel free to request followup changes if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86277/new/

[PATCH] D86581: [clang-format] Handle shifts within conditions

MyDeveloperDay added a comment. @Saldivarcher do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 ___ cfe-commits mailing list

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre updated this revision to Diff 288292. tambre added a comment. Rebase, just in case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86308/new/ https://reviews.llvm.org/D86308 Files: clang/runtime/CMakeLists.txt

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

dylanmckay added a comment. Note to the readers: A recent-ish llvm-dev discussion around this patch can be found in here whrein a consensus is found on the way forward on this patch. Repository: rG LLVM Github Monorepo

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 288302. dougpuob added a comment. Fixed typos and add new Case Type, szHungarianNotation in doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 Files:

[PATCH] D86688: [RecoveryExpr] Add 11.0.0 release note.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ReleaseNotes.rst:51 +Recovery ASTs +^ nit: AST rather than ASTs (matching the flag, and also it's AST is

[PATCH] D86688: [RecoveryExpr] Add 11.0.0 release note.

tschuett added inline comments. Comment at: clang/docs/ReleaseNotes.rst:73 + + // clangd-11 produces a richer AST: + // VarDecl col:5 x 'int' cinit clangd-11 or clang-11? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

atrosinenko updated this revision to Diff 288305. atrosinenko added a comment. - Rebase onto current master branch - Add a dummy `switch` case with `FIXME`, as suggested by @aaron.ballman - Applied a couple of style fixes proposed by linter Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86688: [RecoveryExpr] Add 11.0.0 release note.

sammccall added inline comments. Comment at: clang/docs/ReleaseNotes.rst:65 + + .. code-block:: c++ + Oops, I missed this, I think this should be three code blocks: one for C++, one for the first AST and one for the second AST. Tex like "clang-10 produces the

[PATCH] D86597: [Tooling][Format] Treat compound extensions (foo.bar.cc) as matching foo.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG266825620c7f: [Tooling][Format] Treat compound extensions (foo.bar.cc) as matching foo.h (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2668256 - [Tooling][Format] Treat compound extensions (foo.bar.cc) as matching foo.h

Author: Sam McCall Date: 2020-08-27T15:24:17+02:00 New Revision: 266825620c7f8d10d48abd0346527cea50c8202d URL: https://github.com/llvm/llvm-project/commit/266825620c7f8d10d48abd0346527cea50c8202d DIFF: https://github.com/llvm/llvm-project/commit/266825620c7f8d10d48abd0346527cea50c8202d.diff

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. Please fix Clang-tidy warnings and mention changes in Release Notes. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:317 + if (Style.Case == IdentifierNamingCheck::CaseType::CT_HungarianNotation) { +const

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

nullptr.cpp added a comment. @Szelethus @martong Sorry to interrupt, I don't have commit access, can you help commit this and D86334 ? Yang Fan Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86691/new/

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Before: void f() { MACRO(A * _Nonnull a); } void f() {

[PATCH] D86289: [NFC][compiler-rt] Factor out __mulo[sdt]i3 implementations to .inc file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfce035eae980: [NFC][compiler-rt] Factor out __mulo[sdt]i4 implementations to .inc file (authored by atrosinenko). Changed prior to commit:

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D86065: [SVE] Make ElementCount members private

paulwalker-arm added a comment. I cannot say whether such questions make sense without a deeper investigation, but I can say for certain that EC.isPowerOf2 is a question we cannot answer at compile time. Given this is a mechanical change I would just remove the member function and leave the

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

dylanmckay added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); dylanmckay wrote: >

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson updated this revision to Diff 288316. arichardson added a comment. - fix failing tests after datalayout change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84345/new/ https://reviews.llvm.org/D84345 Files:

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); dylanmckay wrote: >

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. That's awesome! Is it meant to eventually be committed or only be used for comparison purposes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86694/new/ https://reviews.llvm.org/D86694

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan added inline comments. Comment at: clang/test/Preprocessor/init-zos.c:4 + +// S390X-ZOS-GNUXX:#define _EXT 1 +// S390X-ZOS:#define _LONG_LONG 1 MaskRay wrote: > --match-full-lines is different from --match-full-lines --strict-whitespace.

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1726 + } + }]; +} Mordante wrote: > aaron.ballman wrote: > > Something else we should document is what our behavior is when the > > attribute is not immediately inside of

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

atrosinenko added a comment. Pinging @echristo in case there is some trivial way to allocate a calling convention ID (but probably there is not, unless GCC allocated one already). As I understand, without this ID the debugger may show some misleading output for a limited number of LibCalls. On

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2238614 , @martong wrote: > These are really promising figures, nice work! (And the measurement stuff > itself is also a great addition, thanks for that!) Thanks  > Not that it would matter much, but I was just

[PATCH] D86708: [clang-format] Parse volatile as a pointer qualifier

JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. This revision is now accepted and ready to land. LGTM. Wait a bit to give others a chance to chime in before submitting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86708/new/

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

arsenm added a comment. In D86154#2229292 , @nhaehnle wrote: > In D86154#2224272 , @arsenm wrote: > >> In D86154#2224270 , @nhaehnle wrote: >> >>> Note that part of my

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss updated this revision to Diff 288275. danielkiss added a comment. updating tests too. check-llvm, check-clang passes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 Files: llvm/include/llvm/CodeGen/ISDOpcodes.h

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

hans added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:895 + if (!Self.getLangOpts().RTTIData) { +bool isMSVC = Self.getDiagnostics().getDiagnosticOptions().getFormat() == + DiagnosticOptions::MSVC; I'm not sure isMSVC is the

[PATCH] D86698: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 288282. eduucaldas added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86698/new/ https://reviews.llvm.org/D86698 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D86708: [clang-format] Parse volatile as a pointer qualifier

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Before: void f() { MACRO(A * volatile a); } After: void f()

[PATCH] D86065: [SVE] Make ElementCount members private

david-arm added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:108 + + bool isPowerOf2() const { return isPowerOf2_32(Min); } }; paulwalker-arm wrote: > I don't believe this is safe. For example we know SVE supported vector > lengths only

[PATCH] D86698: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86698 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

aaron.ballman added a comment. In D86169#2240384 , @jonathan.protzenko wrote: >> I'm hoping we can devise a way to not require the entity being attributed to >> be passed when parsing the attribute > > That sounds nice. My only concern with this

[PATCH] D86682: [SyntaxTree][NFC][Style] Functions start with lowercase

This revision was automatically updated to reflect the committed changes. Closed by commit rGac87a0b5873c: [SyntaxTree][NFC][Style] Functions start with lowercase (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86682/new/

[clang] fda3fa8 - [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

Author: Eduardo Caldas Date: 2020-08-27T12:55:23Z New Revision: fda3fa822cb6812c8db63f7cee4a8387e71e66ff URL: https://github.com/llvm/llvm-project/commit/fda3fa822cb6812c8db63f7cee4a8387e71e66ff DIFF: https://github.com/llvm/llvm-project/commit/fda3fa822cb6812c8db63f7cee4a8387e71e66ff.diff

[PATCH] D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfda3fa822cb6: [SyntaxTree][NFC] Append get to syntax Nodes accessor names (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES

[clang] ac87a0b - [SyntaxTree][NFC][Style] Functions start with lowercase

Author: Eduardo Caldas Date: 2020-08-27T12:55:24Z New Revision: ac87a0b5873cc14b23eeb25a0586b26cc5c2c33f URL: https://github.com/llvm/llvm-project/commit/ac87a0b5873cc14b23eeb25a0586b26cc5c2c33f DIFF: https://github.com/llvm/llvm-project/commit/ac87a0b5873cc14b23eeb25a0586b26cc5c2c33f.diff

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2239859 , @Mordante wrote: > In D86559#2239013 , @aaron.ballman > wrote: > >> I'd like to understand your reasoning for ignore + diagnose as opposed to >> count attrs (+

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

martong accepted this revision. martong added a comment. In D86691#2241604 , @nullptr.cpp wrote: > In D86691#2241401 , @Szelethus wrote: > >> Nice, thank you! Did you stumble across this, or found it with a tool? >

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko updated this revision to Diff 288306. vsavchenko marked 21 inline comments as done. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86465/new/ https://reviews.llvm.org/D86465 Files:

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: Kai, uweigand, hubert.reinterpretcast, stevewan, SeanP, lalovic. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. abhina.sreeskantharajan requested review of this revision. This

[PATCH] D86711: [clang-format] Parse __attribute((foo)) as a pointer qualifier

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Before: void f() { MACRO(A * __attribute((foo)) a); } After:

[PATCH] D86711: [clang-format] Parse __attribute((foo)) as a pointer qualifier

arichardson added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1895 tok::kw_restrict, tok::kw_volatile, - tok::kw_noexcept) || + tok::kw___attribute, tok::kw_noexcept) ||

[PATCH] D86289: [NFC][compiler-rt] Factor out __mulo[sdt]i3 implementations to .inc file

atrosinenko added a comment. Uploaded because it was already approved and no other review comments received since then. Anyway, please feel free to request followup changes if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86289/new/

[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG182d14db07f1: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file (authored by atrosinenko). Repository: rG LLVM Github

[clang] 45344cf - [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

Author: Raul Tambre Date: 2020-08-27T15:40:15+03:00 New Revision: 45344cf7ac5b848f77825ffa37b0cb3b69b9b07b URL: https://github.com/llvm/llvm-project/commit/45344cf7ac5b848f77825ffa37b0cb3b69b9b07b DIFF: https://github.com/llvm/llvm-project/commit/45344cf7ac5b848f77825ffa37b0cb3b69b9b07b.diff

[libunwind] 45344cf - [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

Author: Raul Tambre Date: 2020-08-27T15:40:15+03:00 New Revision: 45344cf7ac5b848f77825ffa37b0cb3b69b9b07b URL: https://github.com/llvm/llvm-project/commit/45344cf7ac5b848f77825ffa37b0cb3b69b9b07b DIFF: https://github.com/llvm/llvm-project/commit/45344cf7ac5b848f77825ffa37b0cb3b69b9b07b.diff

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45344cf7ac5b: [CMake][compiler-rt][libunwind] Compile assembly

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

dylanmckay added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); arichardson wrote: >

[PATCH] D86710: [clang-format] Parse restrict as a pointer qualifier

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Before: void f() { MACRO(A * restrict a); } After: void f()

[PATCH] D86711: [clang-format] Parse __attribute((foo)) as a pointer qualifier

aaron.ballman added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1895 tok::kw_restrict, tok::kw_volatile, - tok::kw_noexcept) || + tok::kw___attribute, tok::kw_noexcept) ||

[PATCH] D86000: Add an unsigned shift base sanitizer

lebedev.ri added a comment. Release notes missing. I think the canonical way to silence it (via masking?) should be at least mentioned. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3872-3884 llvm::Value *BitsShiftedOff = Builder.CreateLShr( Ops.LHS,

[PATCH] D86668: Fix Calling Convention of __float128 and long double(128bits) in i386

yubing updated this revision to Diff 288218. yubing added a comment. Modify a testcase: clang/test/CodeGenCXX/float128-declarations.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86668/new/ https://reviews.llvm.org/D86668 Files:

[PATCH] D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization

craig.topper added a comment. In D86488#2241176 , @nikic wrote: > This change has a 0.3% compile-time regression >

[PATCH] D86668: Fix Calling Convention of __float128 and long double(128bits) in i386

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1603 + if (IsLinuxABI && Ty->isFloatingType() && getContext().getTypeSize(Ty) == 128) +return 16; + I don't think this should be restricted to just Linux. It's a fix for all OSes

[PATCH] D86065: [SVE] Make ElementCount members private

david-arm added a comment. Hi @ctetreau, ok for now I'm going to completely remove the operators and revert the code using those operators to how it was before. I'm not sure what you mean about the predicate functions so I've left those for now, since they aren't needed for this patch. The

[PATCH] D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization

nikic added a comment. This change has a 0.3% compile-time regression (https://llvm-compile-time-tracker.com/compare.php?from=0c55889d809027136048a0d144209a2bc282e7fc=71f3169e1baeff262583b35ef88f8fb6df7be85e=instructions) and a 0.3% max-rss regression

[PATCH] D86682: [SyntaxTree][NFC][Style] Functions start with lowercase

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86682 Files: clang/lib/Tooling/Syntax/BuildTree.cpp Index:

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

jhenderson added a comment. This looks reasonable to me, but I don't know the surrounding code well enough to be comfortable LGTM-ing it. Sorry! Comment at: llvm/include/llvm/MC/MCAsmInfo.h:387 + // Generated object files can only use features support by GNU ld of this +

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

labath added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1755-1759 + QualType FromTy = ArrayFrom->getElementType(); + QualType ToTy = ArrayTo->getElementType(); + + FromRecordDecl = FromTy->getAsRecordDecl(); + ToRecordDecl =

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein added a comment. In D82657#2240603 , @vvereschaka wrote: > Hi @hokein, > > sorry, but looks like your changes break one of libc++ tests on ARM cross > toolchain build on Windows: `libc++::function_type_default_deleter.fail.cpp` > Here is the first

[PATCH] D86720: [clang][aarch64] Drop experimental from __ARM_FEATURE_SVE_BITS macro

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, david-arm, efriedma. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: aaron.ballman. Herald added a project: clang. c-rhodes requested review of this

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

arichardson added a comment. In D86713#2242253 , @JakeMerdichAMD wrote: > LGTM, again assuming tests pass locally (patch did not resolve). > > Out of curiosity, is _Atomic on your radar? I found some code in clang proper > that handled restrict and

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

JakeMerdichAMD added a comment. In D86713#2242300 , @arichardson wrote: > In D86713#2242253 , @JakeMerdichAMD > wrote: > >> LGTM, again assuming tests pass locally (patch did not resolve). >> >> Out of curiosity,

[PATCH] D86711: [clang-format] Parse __attribute((foo)) as a pointer qualifier

aaron.ballman added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1895 tok::kw_restrict, tok::kw_volatile, - tok::kw_noexcept) || + tok::kw___attribute, tok::kw_noexcept) ||

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki updated this revision to Diff 288373. miyuki added a comment. Small refactoring of bitcode updater tests (use `some-name.ll.bc` names for bitcode files in order to be able to refer to them as `%s.bc` from `some-name.ll`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86065: [SVE] Make ElementCount members private

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. There's probably a few .Min to .getKnownMinValue() conversions where the .Min could be dropped (calls to Builder.CreateVectorSplat for example) but they can be tidied up as

[PATCH] D86000: Add an unsigned shift base sanitizer

vsk added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/Integer/unsigned-shift.cpp:6 + volatile unsigned _v = (val);\ + volatile unsigned _a = (amount); \ + unsigned res = _v << _a; \ jfb wrote: > vsk wrote: > > Does the test not

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher added a comment. @MyDeveloperDay thanks for the kind words, it's much appreciated! I'm just glad I was able to help. Nope, I don't have commit access, can you do me the favor of commiting for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644 if (!LDat) { - Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(), - LK_Shared, Loc); +

[PATCH] D86710: [clang-format] Parse restrict as a pointer qualifier

JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. This revision is now accepted and ready to land. LGTM, assuming tests pass (automated checks failed to resolve your patch since you based it off of your other one). Looks like enabling C99 should have no other effects,

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. This revision is now accepted and ready to land. LGTM, again assuming tests pass locally (patch did not resolve). Out of curiosity, is _Atomic on your radar? I found some code in clang proper that handled restrict and

[PATCH] D86721: [clang-format] Parse double-square attributes as pointer qualifiers

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Before: x = (foo *[[clang::attr]] const) * v;

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

lebedev.ri added a comment. This really needs some docs changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85948/new/ https://reviews.llvm.org/D85948 ___ cfe-commits mailing list

  1   2   3   >