[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. A gentle notification :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

baloghadamsoftware updated this revision to Diff 289703. baloghadamsoftware added a comment. Tests separated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85351/new/ https://reviews.llvm.org/D85351 Files: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaron.ballman added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:922 +// Releases *this and all underlying capabilities, if they are still held. +// There is no warning on double unlock. ~MutexLocker() RELEASE() { This makes it

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

steakhal added a comment. In D86874#inline-803844 , @martong wrote: > I really feel that this check would have a better place in the implementation > of `eval`. This seems really counter-intuitive to do this stuff at the > Checker's level. Is

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:578 +static std::pair +getLikelihood(const Stmt *Stmt) { + if (const auto *AS = dyn_cast(Stmt)) Mordante wrote: > rsmith wrote: > > Mordante wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D87056: [POC] SVE/SVE2 implementation (LLVM 9)

sdesmalen created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, nikic, aaron.ballman, ecnelises, dantrushin, kerbowa, s.egerton, Jim, asbirlea, jfb, arphaman, dexonsmith, rogfer01, steven_wu, atanasyan, mgrang, zzheng, jrtc27, delcypher, simoncook, haicheng, kosarev,

[PATCH] D87031: [libTooling] Provide overloads of `rewriteDescendants` that operate directly on an AST node.

ymandel updated this revision to Diff 289623. ymandel added a comment. Herald added a subscriber: JDevlieghere. fix diff base; make small clang-tidy suggested change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87031/new/

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added a comment. In D85091#2252632 , @Mordante wrote: > In D85091#2250657 , @rsmith wrote: > >> Looking specifically for attributes in the 'then' and 'else' cases of an >> `if` seems like a fine

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:87 +Mutex globalMutex; +void f() EXCLUSIVE_LOCKS_REQUIRED(!globalMutex); + Can you add a test that uses `!::globalMutex`? I'd like to verify that lookup rules

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng added a comment. ping.. @jrt, @lenary, @asb, IMHO, the patch is in good shape now, all concerns raised in comments has been addressed/answered, is there any additional comments before we can land it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 289693. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp

[PATCH] D86508: [clang] improve GCC-compat for C90 __builtin_ functions

aaron.ballman added a comment. This looks reasonable to me. Comment at: clang/docs/LanguageExtensions.rst:2370 +* ``bcmp`` * ``memchr`` Can you mention the deprecation issue here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

ebevhan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13981 +bool overflow; +llvm::APInt product(index); +product += 1; What if index is wider than AddrBits, but the active bits are fewer? Then you might miss out on

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:37 +return false; + constexpr StringRef ExitFunctions[] = {"_Exit", "exit", "quick_exit"}; + return llvm::is_contained(ExitFunctions, FD->getName());

[PATCH] D87064: Thread safety analysis: Test and document release_generic_capability

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87064/new/ https://reviews.llvm.org/D87064

[PATCH] D87065: Thread safety analysis: Document how try-acquire is handled

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for documenting this, that would be confusing without spelling it out explicitly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67935: Add `#pragma clang deprecated`, used to deprecate macros

aaron.ballman added a comment. In D67935#2251145 , @erik.pilkington wrote: > @aaron.ballman: Did you happen to get any feedback on macro attributes? There > are a growing number of macros that we'd like to be able to deprecate, and > having a workable

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

sammccall added a subscriber: rsmith. sammccall added a comment. Neither of the testcases look like the right behavior to me, and I think the bug is elsewhere in clang. The crux is we're forcing `decltype(N)` to be a (unique) dependent type, which feels wrong. This isn't specific to

[PATCH] D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver

hans added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:117 + // do not remove those when using the cl driver. + bool IsDependencyFileArg; + if (Arg.startswith("/showIncludes") || Arg.startswith("-showIncludes"))

[clang] d4f3903 - [libTooling] Provide overloads of `rewriteDescendants` that operate directly on an AST node.

Author: Yitzhak Mandelbaum Date: 2020-09-03T14:39:50Z New Revision: d4f3903131292d36b3bc22c28798b8e9dae20af6 URL: https://github.com/llvm/llvm-project/commit/d4f3903131292d36b3bc22c28798b8e9dae20af6 DIFF: https://github.com/llvm/llvm-project/commit/d4f3903131292d36b3bc22c28798b8e9dae20af6.diff

[PATCH] D87031: [libTooling] Provide overloads of `rewriteDescendants` that operate directly on an AST node.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f390313129: [libTooling] Provide overloads of `rewriteDescendants` that operate directly on… (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

martong created this revision. martong added reviewers: steakhal, balazske, Szelethus, NoQ, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

nemanjai added a comment. Is there a way this test case can somehow be broken up into multiple files? The test case takes a very long time to compile which causes intermittent but frequent failures on one of our bots that runs on a fairly small VM. Most of the failures listed here:

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

hans added a comment. Okay, almost there.. Comment at: clang/lib/Sema/SemaCast.cpp:897 + DiagnosticOptions::MSVC; +if (isMSVC || !DestPointee->isVoidType()) + Self.Diag(OpRange.getBegin(), I don't think the if-statement is necessary.

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

dang added a comment. Yes of course. This is a prerequisite for some other changes that are waiting to land and need polishing. Thanks for doing the revert. I will investigate the failures and recommit it when appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx updated this revision to Diff 289785. chrish_ericsson_atx added a comment. Refactored as ebevhan suggested to simplify patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86796/new/ https://reviews.llvm.org/D86796 Files:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

AlexanderLanin added a comment. Observed behavior: Change: `for(string_view token : split_into_views(file_content, " \t\r\n"))` --> `for(string_view const token : split_into_views(file_content, " \t\r\n"))`. Note: `std::vector split_into_views(string_view input, const char* separators);`

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu updated this revision to Diff 289802. zequanwu added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaronpuchert added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:908 +// Assumes mu is held, implicitly acquires *this and connects it to mu. +MutexLocker(t_mutex , adopt_lock_t) REQUIRES(mu) : mut(mu) {} + `s/t_mutex/Mutex/g`

[PATCH] D87101: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel, nikic, lebedev.ri. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. RKSimon requested review of this revision. We're now getting close to having the necessary analysis/combines etc. for the

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang updated this revision to Diff 289768. akhuang added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87062/new/ https://reviews.llvm.org/D87062 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

Xiangling_L added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86790/new/ https://reviews.llvm.org/D86790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86508: [clang] improve GCC-compat for C90 __builtin_ functions

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2370-2398 +* ``bcmp`` * ``memchr`` -* ``memcmp`` (and its deprecated BSD / POSIX alias ``bcmp``) +* ``memcmp`` +* ``memcpy`` +* ``memmove`` +* ``memset`` +* ``strcat`` aaron.ballman

[PATCH] D86508: [clang] improve GCC-compat for C90 __builtin_ functions

rsmith added a comment. It seems to me that adding new `__builtin_*` functions for GCC compatibility and adding new `LIBBUILTIN`s are unrelated changes, and it might be clearer to split them up into two commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c9239b2 - [Analyzer][docs][NFC] Fix typo in code example

Author: Jan Korous Date: 2020-09-03T09:28:34-07:00 New Revision: c9239b2bf5f00b58aaa431955f24013e0cada0a3 URL: https://github.com/llvm/llvm-project/commit/c9239b2bf5f00b58aaa431955f24013e0cada0a3 DIFF: https://github.com/llvm/llvm-project/commit/c9239b2bf5f00b58aaa431955f24013e0cada0a3.diff

[PATCH] D87097: [analyzer][StdLibraryFunctionsChecker] Do not match based on the restrict qualifier in C++

martong created this revision. martong added reviewers: balazske, steakhal, Szelethus, NoQ, vsavchenko, baloghadamsoftware, gamesh411. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald

[PATCH] D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang

Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:993 + [(set v16i8:$vD, (int_ppc_altivec_vexpandbm + v16i8:$vB))]>; def VEXPANDHM : VXForm_RD5_XO5_RS5<1602, 1,

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. In D80344#2255090 , @asmith wrote: > Yes there was an RFC and discussion and several requests for comments. > http://lists.llvm.org/pipermail/llvm-dev/2020-March/140541.html It is probably good to state so in the patch's

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx marked 3 inline comments as done. chrish_ericsson_atx added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13981 +bool overflow; +llvm::APInt product(index); +product += 1; ebevhan wrote: > What if index

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx marked 2 inline comments as done. chrish_ericsson_atx added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13966 if (index.isUnsigned() || !index.isNegative()) { -// It is possible that the type of the base expression after -//

[PATCH] D87095: [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

pcc added a comment. Hi, thanks for getting started on upstreaming this! But I was wondering: shouldn't this be the *last* patch? I was imagining that you would first upstream support for the `-fptrauth-*` flags, and then at the end you would add an `arm64e` subarch that turns them on by

[PATCH] D86993: Document Clang's expectations of the C standard library.

aaron.ballman added inline comments. Comment at: clang/docs/Toolchain.rst:289 + +C standard library implementations that do not guarantee these properties are +incompatible with Clang and LLVM (and with several other major compilers). While I think it's good

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 289765. rahmanl marked 5 inline comments as done. rahmanl added a comment. - Address +MaskRay's comments: - Change the check prefix simply to "CHECK" for basic-block-sections-labels.ll - Change the triple to x86_64 for this test. - nits. - Remove the "-LABEL"

[PATCH] D87103: [test] Use %t instead of %T to remove race conditions between config-file3.c and target-override.c

MaskRay created this revision. MaskRay added reviewers: dblaikie, nemanjai. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay requested review of this revision. Both tests operate on `%T/testbin`. If the two tests run concurrently, one may fail. This is likely the

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. I feel like this may be trying to do too many things at once. Was there an RFC? There are several patches here: 1. langref 2. llvm side of the patch (maybe should be in the

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

sammccall added a comment. Nit on the commit message: I think this is TemplateArgumentLoc 48 -> 32 bytes, and DynTypedNode 56 -> 40 bytes. Comment at: clang/include/clang/AST/TemplateBase.h:415 -public: - constexpr TemplateArgumentLocInfo() : Template({nullptr, nullptr, 0,

[PATCH] D86993: Document Clang's expectations of the C standard library.

rjmccall added a subscriber: t.p.northover. rjmccall added a comment. @t.p.northover says it's complicated. `memcpy`, `memmove`, `memset`, and `bzero` are (I think) the only ones that LLVM will potentially synthesize from nothing and therefore need to be present even in freestanding builds;

[PATCH] D87103: [test] Use %t instead of %T to remove race conditions between config-file3.c and target-override.c

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87103/new/ https://reviews.llvm.org/D87103

[PATCH] D87101: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

nikic added a comment. I think our abs intrinsic support is already sufficient to start canonicalizing to the intrinsic variant (the same is not true for min/max intrinsics). We might want to make the InstCombine change before this one, to make sure we don't lose CSE opportunities between the

[PATCH] D87095: [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

ab created this revision. Herald added subscribers: cfe-commits, danielkiss, cmtice, rupprecht, dexonsmith, steven_wu, hiraditya, kristof.beyls, arichardson. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added projects: clang, LLVM. ab requested review of this

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx updated this revision to Diff 289753. chrish_ericsson_atx marked 2 inline comments as done. chrish_ericsson_atx added a comment. Addressed reviewer feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86796/new/

[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82725/new/ https://reviews.llvm.org/D82725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82726/new/ https://reviews.llvm.org/D82726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu updated this revision to Diff 289769. zequanwu marked an inline comment as done. zequanwu added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 Files:

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:897 + DiagnosticOptions::MSVC; +if (isMSVC || !DestPointee->isVoidType()) + Self.Diag(OpRange.getBegin(), hans wrote: > I don't think the if-statement is necessary.

[PATCH] D87095: [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

ab added a comment. In D87095#2255010 , @pcc wrote: > But I was wondering: shouldn't this be the *last* patch? I was imagining that > you would first upstream support for the `-fptrauth-*` flags, and then at the > end you would add an `arm64e` subarch

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87062/new/ https://reviews.llvm.org/D87062

[PATCH] D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver

shivanshu3 updated this revision to Diff 289793. shivanshu3 added a comment. - Remove the bool `IsDependencyFileArg` in the implementation of `getClangStripDependencyFileAdjuster()` to make it simpler. - Add an extra argument after -MT in the test case to ensure we do not strip arguments after

[PATCH] D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver

shivanshu3 marked 2 inline comments as done. shivanshu3 added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:117 + // do not remove those when using the cl driver. + bool IsDependencyFileArg; + if (Arg.startswith("/showIncludes") ||

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2254065 , @rjmccall wrote: > The builtins with custom type-checking are all true intrinsics like > `__builtin_operator_new` and so on. They really can't be validly declared by > the user program. The thing that seems

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1047 + getObjFileLowering().getBBAddrMapSection(*MF.getSection()); + if (!BBAddrMapSection) +return; MaskRay wrote: > BBAddrMapSection is always non-null. Delete the

[PATCH] D87031: [libTooling] Provide overloads of `rewriteDescendants` that operate directly on an AST node.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:388 +llvm::Expected> +rewriteDescendants(const Decl , RewriteRule Rule, + const ast_matchers::MatchFinder::MatchResult ); ymandel wrote: >

[PATCH] D87103: [test] Use %t instead of %T to remove race conditions between config-file3.c and target-override.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e09722b27ed: [test] Use %t instead of %T to remove race conditions between config-file3.c… (authored by MaskRay). Repository: rG LLVM Github

[clang] 6e09722 - [test] Use %t instead of %T to remove race conditions between config-file3.c and target-override.c

Author: Fangrui Song Date: 2020-09-03T12:28:53-07:00 New Revision: 6e09722b27ed4d48dfc668b0efc2aed88d701ebf URL: https://github.com/llvm/llvm-project/commit/6e09722b27ed4d48dfc668b0efc2aed88d701ebf DIFF: https://github.com/llvm/llvm-project/commit/6e09722b27ed4d48dfc668b0efc2aed88d701ebf.diff

[PATCH] D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

fhahn accepted this revision. fhahn added a comment. LGTM, thanks for addressing this! Please wait a bit with committing, in case there are additional comments. Comment at: clang/lib/Sema/SemaExpr.cpp:4598 } // If the base is either a MatrixSubscriptExpr or a matrix

[PATCH] D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87102/new/ https://reviews.llvm.org/D87102 ___ cfe-commits mailing list

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rjmccall added a comment. I didn't see the specific example, sorry. I agree that my description is more applicable to builtins in the `__builtin` namespace, which describes most of the builtins with custom typechecking. Is the problem just `__va_start`? If we have to treat all declarations

[PATCH] D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang

Conanap accepted this revision. Conanap added a comment. This revision is now accepted and ready to land. Minor nit, okay if changed for commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82727/new/ https://reviews.llvm.org/D82727

[PATCH] D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, ahatanak, fhahn. Herald added subscribers: ributzka, dexonsmith, jkorous. erik.pilkington requested review of this revision. Previously, this code discarded the result of CheckPlaceholderExpr for non-matrix

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. Yes there was an RFC and discussion and several requests for comments. http://lists.llvm.org/pipermail/llvm-dev/2020-March/140541.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx marked an inline comment as done. chrish_ericsson_atx added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13966 if (index.isUnsigned() || !index.isNegative()) { -// It is possible that the type of the base expression after -//

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

hans added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:897 + DiagnosticOptions::MSVC; +if (isMSVC || !DestPointee->isVoidType()) + Self.Diag(OpRange.getBegin(), zequanwu wrote: > hans wrote: > > I don't think the

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

shafik marked an inline comment as done. shafik added a subscriber: rsmith. shafik added a comment. @martong I have been experimenting w/ how we pass around `ImportDefinitionKind` and pushing it through to more places does not help. I also tried defaulting most locations to `IDK_Everything` to

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish added a comment. Thanks for the comments! PTAL. In D87047#2252982 , @davidxl wrote: > For x86 target, should it be turned on when -fprofile-use= option is > specified unless -fno-split-machine-function is specified? I don't think we are there

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaronpuchert updated this revision to Diff 289826. aaronpuchert marked an inline comment as done. aaronpuchert added a comment. - More detailed description how scoped capabilities work. - Make the comment wording more consistent with existing comments and the previous explanation. - Properly

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf1a96408b1: [DebugInfo] Add size to class declarations in debug info. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx updated this revision to Diff 289815. chrish_ericsson_atx added a comment. NC. Pushing null change in hopes of re-triggering testing. Unit test that failed is low-level LLVM test, which doesn't even exercise the code I've changed here, so I'm assuming it's a spurious

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

yaxunl added a comment. In D84364#2201336 , @tra wrote: > In D84364#2176091 , @yaxunl wrote: > >> I added a `Deferrable` bit to the diagnostics which can be specified in td >> files. This can be added to

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

MaskRay added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1047 + getObjFileLowering().getBBAddrMapSection(*MF.getSection()); + if (!BBAddrMapSection) +return; rahmanl wrote: > MaskRay wrote: > > BBAddrMapSection is always

[libunwind] 673484b - [libunwind] Minor SJLJ config cleanup. NFCI.

Author: Ryan Prichard Date: 2020-09-03T15:59:45-07:00 New Revision: 673484b34189b1bccf73a2ec96968092bc8a26a7 URL: https://github.com/llvm/llvm-project/commit/673484b34189b1bccf73a2ec96968092bc8a26a7 DIFF: https://github.com/llvm/llvm-project/commit/673484b34189b1bccf73a2ec96968092bc8a26a7.diff

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: llvm-commits, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. Herald added a project: LLVM. thakis requested review of this revision. Instead of using

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jyknight added a comment. Do you have open questions on whether some callsites passing "false" here, should be switched to true? Given what's here, I would say that it definitely does not makes sense to add this parameter everywhere. So, for getting something committed: please send a new

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

tra added a comment. LGTM. Nice! To sum it up -- the patch introduces `-fgpu-defer-diag` flag which allows deferring overload resolution diagnostics, if overload set included candidates from both sides. We may be deferring cases when we don't have to (e.g. `df()->()callee2()` should've

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 289805. snehasish added a comment. Add warning when option is enabled without profile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87047/new/ https://reviews.llvm.org/D87047 Files:

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

zixuw added a comment. Okay so I think I traced down to the root problem: the diagnostic message prints out fine because `TextDiagnosticPrinter` uses `FullSourceLoc`, which actually embeds an appropriate `SourceManager` within it: TextDiag->emitDiagnostic(

[clang] aaf1a96 - [DebugInfo] Add size to class declarations in debug info.

Author: Amy Huang Date: 2020-09-03T15:42:27-07:00 New Revision: aaf1a96408b1587b5fb80a3a7c424348cb09e577 URL: https://github.com/llvm/llvm-project/commit/aaf1a96408b1587b5fb80a3a7c424348cb09e577 DIFF: https://github.com/llvm/llvm-project/commit/aaf1a96408b1587b5fb80a3a7c424348cb09e577.diff

[PATCH] D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver

shivanshu3 marked an inline comment as done. shivanshu3 added a comment. Note that I do not have commit access and this change will have to be committed by someone else on my behalf. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86999/new/

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035 + const RecordDecl *D = RD->getDefinition(); + if (D && D->isCompleteDefinition()) +Size = CGM.getContext().getTypeSize(Ty); akhuang wrote: > dblaikie wrote: > > When is a

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx updated this revision to Diff 289819. chrish_ericsson_atx added a comment. NC push did not resolve failed test. Rebased in hopes that whatever has broken the build has been resolved in the intervening commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

atmnpatel updated this revision to Diff 289821. atmnpatel added a comment. Herald added a subscriber: zzheng. Renamed llvm loop metadata, changed deduction rules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/

[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

atmnpatel marked an inline comment as done. atmnpatel added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.h:211 llvm::ArrayRef Attrs, const llvm::DebugLoc , -const llvm::DebugLoc ); +const llvm::DebugLoc , const bool NoProgress =

[clang] e6393ee - Canonicalize declaration pointers when forming APValues.

Author: Richard Smith Date: 2020-09-03T15:35:12-07:00 New Revision: e6393ee813178e9d3306b8e3c6949a4f32f8a2cb URL: https://github.com/llvm/llvm-project/commit/e6393ee813178e9d3306b8e3c6949a4f32f8a2cb DIFF: https://github.com/llvm/llvm-project/commit/e6393ee813178e9d3306b8e3c6949a4f32f8a2cb.diff

[clang] 052dbe2 - Remove unused and dangerous overload of PerformImplicitConversion.

Author: Richard Smith Date: 2020-09-03T15:35:12-07:00 New Revision: 052dbe226cb3540c77cf0b3dc4a51a4ab7726b55 URL: https://github.com/llvm/llvm-project/commit/052dbe226cb3540c77cf0b3dc4a51a4ab7726b55 DIFF: https://github.com/llvm/llvm-project/commit/052dbe226cb3540c77cf0b3dc4a51a4ab7726b55.diff

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert updated this revision to Diff 289833. aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. Add tests with qualified names, let tests rely on shadowing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84604/new/

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:87 +Mutex globalMutex; +void f() EXCLUSIVE_LOCKS_REQUIRED(!globalMutex); + aaron.ballman wrote: > Can you add a test that uses `!::globalMutex`? I'd like to verify

[clang] 0f1be87 - [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

Author: Erik Pilkington Date: 2020-09-03T16:56:35-04:00 New Revision: 0f1be87e294751a0941f1d9b7785ebf4d8072149 URL: https://github.com/llvm/llvm-project/commit/0f1be87e294751a0941f1d9b7785ebf4d8072149 DIFF:

[PATCH] D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f1be87e2947: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling… (authored by erik.pilkington). Herald added a project: clang. Changed prior to commit:

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

yaxunl updated this revision to Diff 289814. yaxunl added a comment. Defer overload resolution diags only if there are wrong-sided candidates. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84364/new/ https://reviews.llvm.org/D84364 Files: clang/include/clang/Basic/Diagnostic.td

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

rjmccall added a comment. We just talk about it. I agree with Nathan that we shouldn't just add this as a short-term hack; we should design the ABI right and then do what we want. I think these are basically all the ABI questions: - Is there a good reason to preserve signature compatibility

  1   2   >