[clang] e38be70 - [Clang] Clarify __builtin_memcpy_inline documentation

2020-09-11 Thread Guillaume Chatelet via cfe-commits
Author: Guillaume Chatelet Date: 2020-09-11T07:20:39Z New Revision: e38be7091ee3d00430652aaa7b66ba3fc8394916 URL: https://github.com/llvm/llvm-project/commit/e38be7091ee3d00430652aaa7b66ba3fc8394916 DIFF: https://github.com/llvm/llvm-project/commit/e38be7091ee3d00430652aaa7b66ba3fc8394916.diff

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

2020-09-11 Thread Guillaume Chatelet via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe38be7091ee3: [Clang] Clarify __builtin_memcpy_inline documentation (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87458/new/

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

2020-09-11 Thread Richard Barton via Phabricator via cfe-commits
richard.barton.arm accepted this revision. richard.barton.arm added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089 ___ cfe-commits mailing list

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

2020-09-11 Thread Rainer Orth via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG76e85ae268f8: [clang][Sparc] Default to -mcpu=v9 for Sparc V8 on Solaris (authored by ro). Repository: rG LLVM Github

[clang] 76e85ae - [clang][Sparc] Default to -mcpu=v9 for Sparc V8 on Solaris

2020-09-11 Thread Rainer Orth via cfe-commits
Author: Rainer Orth Date: 2020-09-11T09:53:19+02:00 New Revision: 76e85ae268f8e64540703b0d1710d27ef0d36040 URL: https://github.com/llvm/llvm-project/commit/76e85ae268f8e64540703b0d1710d27ef0d36040 DIFF: https://github.com/llvm/llvm-project/commit/76e85ae268f8e64540703b0d1710d27ef0d36040.diff

[clang] b8ea47a - Uncapitalize word in LanguageExtensions.rst

2020-09-11 Thread via cfe-commits
Author: Guillaume Chatelet Date: 2020-09-11T10:08:02+02:00 New Revision: b8ea47a38039c57e863e3047c33d8584e21360f0 URL: https://github.com/llvm/llvm-project/commit/b8ea47a38039c57e863e3047c33d8584e21360f0 DIFF:

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

2020-09-11 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2439 +guarantees not to call any external functions. See LLVM IR `llvm.memcpy.inline +`_

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

2020-09-11 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:71 std::unique_ptr openIndex(llvm::StringRef Index) { return loadIndex(Index, /*UseIndex=*/true); why do we have this extra indirection?

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 291152. eduucaldas added a comment. Remove unused include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87495/new/ https://reviews.llvm.org/D87495 Files: clang/include/clang/Tooling/Syntax/BuildTree.h

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

2020-09-11 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2439 +guarantees not to call any external functions. See LLVM IR `llvm.memcpy.inline +`_

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

2020-09-11 Thread Rahman Lavaee via Phabricator via cfe-commits
rahmanl added a comment. In D85408#2266559 , @dblaikie wrote: > In D85408#2262134 , @rahmanl wrote: > >> @efriedma Would you please chime in specially with respect to @MaskRay 's >> comment about the clang test

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

2020-09-11 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 291158. balazske added a comment. - Code formatting fixes. - Updated description. - Improved CalledFunctionsCollector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https://reviews.llvm.org/D87449

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

2020-09-11 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:30-31 +syntax::Leaf *createKeyword(Arena , tok::TokenKind K); +syntax::Leaf *createLeaf(syntax::Arena , const char *spelling, + tok::TokenKind K); +

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

2020-09-11 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. This is new functionality, so I don't think we should merge it so late in the release process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

2020-09-11 Thread Rahman Lavaee via Phabricator via cfe-commits
rahmanl updated this revision to Diff 291156. rahmanl added a comment. - Remove the complex assembly from the clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files: clang/docs/UsersManual.rst

[clang-tools-extra] bceca7a - [clangd][NFC] Get rid of an `else after return`

2020-09-11 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-09-11T11:31:16+02:00 New Revision: bceca7a996248aba44c3e4b4752634114650e6ac URL: https://github.com/llvm/llvm-project/commit/bceca7a996248aba44c3e4b4752634114650e6ac DIFF:

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

2020-09-11 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 291140. lxfind added a comment. Add test case. Verify that the size of the frame reduced by 8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files:

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87495 Files: clang/include/clang/Tooling/Syntax/BuildTree.h

[PATCH] D87498: [SyntaxTree] Rename functions to start with verb

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. According to LLVM coding standards:

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

2020-09-11 Thread Clement Courbet via Phabricator via cfe-commits
courbet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2439 +guarantees not to call any external functions. See LLVM IR `llvm.memcpy.inline +`_ Intrinsic +for more information.

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

2020-09-11 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked 4 inline comments as done. balazske added a comment. It looks like that the `clang-tidy/add_new_check.py` script does not work correctly, at least it "corrupts" the **list.rst** file, and creates files with no newline at end. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87501: [clangd] Track tweaks that fail the apply stage

2020-09-11 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github

[clang] 7527898 - [analyzer][MacroExpansion][NFC] Fix a missing test output check

2020-09-11 Thread Kristóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-09-11T13:48:26+02:00 New Revision: 7527898fef47da929e70c81100a0248c2f445762 URL: https://github.com/llvm/llvm-project/commit/7527898fef47da929e70c81100a0248c2f445762 DIFF: https://github.com/llvm/llvm-project/commit/7527898fef47da929e70c81100a0248c2f445762.diff

[PATCH] D87409: [libTooling] Fix use of `char` in comparison.

2020-09-11 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa5cefd95cc60: [libTooling] Fix use of `char` in comparison. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87409/new/

[clang] a5cefd9 - [libTooling] Fix use of `char` in comparison.

2020-09-11 Thread Yitzhak Mandelbaum via cfe-commits
Author: Yitzhak Mandelbaum Date: 2020-09-11T12:24:09Z New Revision: a5cefd95cc60318fbf8610ee782bd22b492692a2 URL: https://github.com/llvm/llvm-project/commit/a5cefd95cc60318fbf8610ee782bd22b492692a2 DIFF: https://github.com/llvm/llvm-project/commit/a5cefd95cc60318fbf8610ee782bd22b492692a2.diff

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

2020-09-11 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:51 + return createLeaf(A, tok::getKeywordSpelling(K), K); +} + eduucaldas wrote: > gribozavr2 wrote: > > Could we make a combined function that does not require the user to

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

2020-09-11 Thread Raul Tambre via Phabricator via cfe-commits
tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87358: [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits

2020-09-11 Thread Cullen Rhodes via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG002f5ab3b171: [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits (authored by c-rhodes). Changed prior to commit: https://reviews.llvm.org/D87358?vs=290974=291168#toc Repository: rG LLVM Github

[clang] 002f5ab - [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits

2020-09-11 Thread Cullen Rhodes via cfe-commits
Author: Cullen Rhodes Date: 2020-09-11T09:46:35Z New Revision: 002f5ab3b171c7d9c9ea192b04a5303be78f6e52 URL: https://github.com/llvm/llvm-project/commit/002f5ab3b171c7d9c9ea192b04a5303be78f6e52 DIFF: https://github.com/llvm/llvm-project/commit/002f5ab3b171c7d9c9ea192b04a5303be78f6e52.diff

[PATCH] D87358: [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits

2020-09-11 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added inline comments. Comment at: clang/lib/AST/Type.cpp:2324 // scalable and fixed-length vectors. -return Ctx.UnsignedCharTy; - case BuiltinType::SveInt16: -return Ctx.ShortTy; - case BuiltinType::SveUint16: -return Ctx.UnsignedShortTy; - case

[clang] cabd60c - [clang][aarch64] Fix mangling of bfloat16 neon vectors

2020-09-11 Thread Cullen Rhodes via cfe-commits
Author: Cullen Rhodes Date: 2020-09-11T10:11:45Z New Revision: cabd60c26b5df34f096a5a915bde3b1d8ee1 URL: https://github.com/llvm/llvm-project/commit/cabd60c26b5df34f096a5a915bde3b1d8ee1 DIFF: https://github.com/llvm/llvm-project/commit/cabd60c26b5df34f096a5a915bde3b1d8ee1.diff

[PATCH] D87463: [clang][aarch64] Fix mangling of bfloat16 neon vectors

2020-09-11 Thread Ties Stuij via Phabricator via cfe-commits
stuij added a comment. I'm not sure what the procedure is to get patches into LLVM 11, but I think there's still time. Could you try to get this in there as well @c-rhodes ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87463/new/

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

2020-09-11 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 291176. fhahn added a comment. Update code to limit adding noalias to types with `getArgPassingRestrictions() == RecordDecl::APK_CanPassInRegs`. This rules out problematic types, like ones with non-trivial constructors or ObjC structs with weak pointers.

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

2020-09-11 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 291183. fhahn marked an inline comment as done. fhahn added a comment. Add check lines for escape examples. Note that for return-by-value we already add noalias to the pointer unconditionally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 291190. eduucaldas marked 5 inline comments as done. eduucaldas added a comment. Answer inline comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87495/new/ https://reviews.llvm.org/D87495 Files:

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:51 + return createLeaf(A, tok::getKeywordSpelling(K), K); +} + gribozavr2 wrote: > Could we make a combined function that does not require the user to make a > distinction

[clang] 26d9a94 - [analyzer][MacroExpansion][NFC] Fix incorrectly calling parameters arguments

2020-09-11 Thread Kristóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-09-11T13:33:02+02:00 New Revision: 26d9a94681056f88bd3e892f8113093268fa0907 URL: https://github.com/llvm/llvm-project/commit/26d9a94681056f88bd3e892f8113093268fa0907 DIFF: https://github.com/llvm/llvm-project/commit/26d9a94681056f88bd3e892f8113093268fa0907.diff

[PATCH] D87463: [clang][aarch64] Fix mangling of bfloat16 neon vectors

2020-09-11 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added a comment. In D87463#2267613 , @stuij wrote: > I'm not sure what the procedure is to get patches into LLVM 11, but I think > there's still time. Could you try to get this in there as well @c-rhodes ? Cherry-picked into LLVM 11, see:

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

2020-09-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus updated this revision to Diff 291199. Szelethus marked 4 inline comments as done. Szelethus added a comment. Reinstate the assert removed in rG032b78a0762bee129f33e4255ada6d374aa70c71 , add a test. Enforce that

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

2020-09-11 Thread Florian Hahn via Phabricator via cfe-commits
fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2198 +// reference to the underlying object. Mark it accordingly. +Attrs.addAttribute(llvm::Attribute::NoAlias); + rjmccall wrote: >

[clang] 1c08da3 - [analyzer][MacroExpansion] Add a few dumps functions

2020-09-11 Thread Kristóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-09-11T13:29:14+02:00 New Revision: 1c08da38676d15600b5c707cf7522eb4273a5347 URL: https://github.com/llvm/llvm-project/commit/1c08da38676d15600b5c707cf7522eb4273a5347 DIFF: https://github.com/llvm/llvm-project/commit/1c08da38676d15600b5c707cf7522eb4273a5347.diff

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

2020-09-11 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. We forgot to update the signature and definition of `OptTable::findByPrefix`: https://github.com/llvm/llvm-project/blob/257b29715bb27b7d9f6c3c40c481b6a4af0b37e5/llvm/include/llvm/Option/OptTable.h#L154-L155. That's required after updating the definition of

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

2020-09-11 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx marked 11 inline comments as done. chrish_ericsson_atx added a comment. Addressed all feedback from Aaron, except for two comments about reachability that I don't understand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: r364428 - Make CodeGen depend on ASTMatchers

2020-09-11 Thread Vassil Vassilev via cfe-commits
On 9/11/20 5:13 AM, Michael LIAO wrote: That change was added long ago to fix the shared library build. Possibly, there are changes removing that dependency then. Just verified that removing that dependency is just fine.   That's great! Would you commit that change or should I? On Thu,

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

2020-09-11 Thread Caroline via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG257b29715bb2: [flang][driver] Add the new flang compiler and frontend drivers (authored by CarolineConcatto). Changed prior to commit:

[clang] 257b297 - [flang][driver] Add the new flang compiler and frontend drivers

2020-09-11 Thread Caroline Concatto via cfe-commits
Author: Caroline Concatto Date: 2020-09-11T10:55:54+01:00 New Revision: 257b29715bb27b7d9f6c3c40c481b6a4af0b37e5 URL: https://github.com/llvm/llvm-project/commit/257b29715bb27b7d9f6c3c40c481b6a4af0b37e5 DIFF:

[PATCH] D87463: [clang][aarch64] Fix mangling of bfloat16 neon vectors

2020-09-11 Thread Cullen Rhodes via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcabd60c26b5d: [clang][aarch64] Fix mangling of bfloat16 neon vectors (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87463/new/

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

2020-09-11 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx updated this revision to Diff 291184. chrish_ericsson_atx added a comment. Addressed feedback from Aaron Ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86796/new/ https://reviews.llvm.org/D86796 Files:

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

2020-09-11 Thread UTKARSH SAXENA via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 291205. usaxena95 added a comment. Added README.md for the code completion model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files:

[clang] 48b510c - [NFC] Fix compiler warnings due to integer comparison of different signedness

2020-09-11 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-09-11T15:32:03+01:00 New Revision: 48b510c4bc0fe090e635ee0440e46fc176527d7e URL: https://github.com/llvm/llvm-project/commit/48b510c4bc0fe090e635ee0440e46fc176527d7e DIFF: https://github.com/llvm/llvm-project/commit/48b510c4bc0fe090e635ee0440e46fc176527d7e.diff

[PATCH] D87517: [MinGW] Use lib prefix for libraries

2020-09-11 Thread Mateusz Mikuła via Phabricator via cfe-commits
mati865 created this revision. mati865 added a reviewer: LLVM. mati865 added projects: LLVM, clang, LLDB. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, JDevlieghere, mgorny. mati865 requested review of this revision. In MinGW world, UNIX like `lib` prefix is preferred. This

Re: r364428 - Make CodeGen depend on ASTMatchers

2020-09-11 Thread Michael LIAO via cfe-commits
b22d4504968 was committed last night. On Fri, Sep 11, 2020 at 9:30 AM Vassil Vassilev wrote: > > On 9/11/20 5:13 AM, Michael LIAO wrote: > > That change was added long ago to fix the shared library build. > > Possibly, there are changes removing that dependency then. Just > > verified that

[PATCH] D87321: Fix -gz=zlib options for linker

2020-09-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 291227. yaxunl marked 6 inline comments as done. yaxunl added a comment. revised by Fangrui's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87321/new/ https://reviews.llvm.org/D87321 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D87321: Fix -gz=zlib options for linker

2020-09-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/test/Driver/gz.c:1 +// RUN: %clang -### -target x86_64-unknown-linux-gnu -g -gz=none %s 2>&1 | \ +// RUN:FileCheck -check-prefix=NONE %s MaskRay wrote: > This can be merged into `compress.c` > You may delete

[PATCH] D87518: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that appear in an assignment

2020-09-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: xazax.hun, NoQ, vsavchenko, martong, balazske, baloghadamsoftware, steakhal. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin,

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 291239. eduucaldas added a comment. fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87495/new/ https://reviews.llvm.org/D87495 Files: clang/include/clang/Tooling/Syntax/BuildTree.h

[PATCH] D87519: [analyzer][Liveness][NFC] Enqueue the CFGBlocks post-order

2020-09-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: xazax.hun, NoQ, vsavchenko, balazske, martong, baloghadamsoftware, steakhal. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin,

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

2020-09-11 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 291213. ldionne added a comment. Implement the changes for libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87459/new/ https://reviews.llvm.org/D87459 Files: libcxx/include/iterator

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

2020-09-11 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG48b510c4bc0f: [NFC] Fix compiler warnings due to integer comparison of different signedness (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 291229. eduucaldas marked an inline comment as done. eduucaldas added a comment. `createPunctuation`, `createKeyword` -> `createLeaf` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87495/new/

[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:51 + return createLeaf(A, tok::getKeywordSpelling(K), K); +} + gribozavr2 wrote: > eduucaldas wrote: > > gribozavr2 wrote: > > > Could we make a combined function that does not

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

2020-09-11 Thread Russell Gallop via Phabricator via cfe-commits
russell.gallop updated this revision to Diff 291235. russell.gallop edited the summary of this revision. russell.gallop added a comment. Herald added subscribers: phosek, hiraditya. Fixup scudo (sanitizer based) to work on Windows. This makes use of the CRT alloc hooks from D71786

[PATCH] D86841: [clang] Add mayprogress and llvm.loop.mustprogress attribute deduction

2020-09-11 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 291249. atmnpatel added a comment. More tightly follows both the C and C++ standards. `maynotprogress` is only added to C functions when compiled with C11 or later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87522: [SyntaxTree] Add const qualifiers, from [llvm-qualified-auto]

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87522 Files:

[clang] b9bca88 - [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

2020-09-11 Thread Kristóf Umann via cfe-commits
Author: Kristóf Umann Date: 2020-09-11T15:58:48+02:00 New Revision: b9bca883c970d36f408db80df21838c713c326db URL: https://github.com/llvm/llvm-project/commit/b9bca883c970d36f408db80df21838c713c326db DIFF: https://github.com/llvm/llvm-project/commit/b9bca883c970d36f408db80df21838c713c326db.diff

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

2020-09-11 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb9bca883c970: [analyzer][NFC] Dont bind values to ObjCForCollectionStmt, replace it with a… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

2020-09-11 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan updated this revision to Diff 291211. ebevhan added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

2020-09-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus updated this revision to Diff 291231. Szelethus added a comment. Rename the live statements checker to live expressions checker. The test file added in a revert commit changed rather heavily, but it makes sense that these entries are removed IMO. Unless anyone objects, I'll intend to

Re: r364428 - Make CodeGen depend on ASTMatchers

2020-09-11 Thread Vassil Vassilev via cfe-commits
Thanks a lot! On 9/11/20 6:20 PM, Michael LIAO wrote: b22d4504968 was committed last night. On Fri, Sep 11, 2020 at 9:30 AM Vassil Vassilev wrote: On 9/11/20 5:13 AM, Michael LIAO wrote: That change was added long ago to fix the shared library build. Possibly, there are changes removing that

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

2020-09-11 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:94 + +- New :doc:`cert-sig30-c + ` check. Please rebase from trunk. New checks section is above and somehow header is missed in your file. Repository: rG LLVM Github

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

2020-09-11 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan updated this revision to Diff 291203. ebevhan added a comment. Using Type::getFloatingPointTy now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

2020-09-11 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added inline comments. Comment at: llvm/include/llvm/IR/FixedPointBuilder.h:126 + /// \p Ty, or a floating point type with a larger exponent than Ty. + Type *getAccommodatingFloatType(Type *Ty, const FixedPointSemantics ) { +const fltSemantics *FloatSema =

[clang] 4c14ee6 - [SyntaxTree] Rename functions to start with verb

2020-09-11 Thread Eduardo Caldas via cfe-commits
Author: Eduardo Caldas Date: 2020-09-11T14:54:18Z New Revision: 4c14ee61b73746b314d83e7c52e03d6527b78105 URL: https://github.com/llvm/llvm-project/commit/4c14ee61b73746b314d83e7c52e03d6527b78105 DIFF: https://github.com/llvm/llvm-project/commit/4c14ee61b73746b314d83e7c52e03d6527b78105.diff

[PATCH] D87498: [SyntaxTree][NFC] Rename functions to start with verb

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c14ee61b737: [SyntaxTree] Rename functions to start with verb (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87517: [MinGW] Use lib prefix for libraries

2020-09-11 Thread Mateusz Mikuła via Phabricator via cfe-commits
mati865 updated this revision to Diff 291224. mati865 added a comment. Also adjusted llvm-config. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87517/new/ https://reviews.llvm.org/D87517 Files: clang/tools/libclang/CMakeLists.txt

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

2020-09-11 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 291238. balazske added a comment. Added entry to release notes and fixed wrong comment in test headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https://reviews.llvm.org/D87449 Files:

[PATCH] D87520: [tests][compiler-rt] Implement generic_ldbl{80,128}_test targets

2020-09-11 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: MaskRay, howard.hinnant, samsonov. Herald added subscribers: Sanitizers, mgorny, dberris. Herald added a project: Sanitizers. atrosinenko requested review of this revision. Herald added a subscriber: aheejin. This patch introduces

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

2020-09-11 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Release Notes were not updated yet. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-sig30-c.rst:10 +The minimal list of asynchronous-safe system functions is: +``abort()``, ``_Exit()``, ``quick_exit()`` and ``signal()`` (for ``signal``

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

2020-09-11 Thread Manman Ren via Phabricator via cfe-commits
manmanren added a comment. In D86049#2255738 , @rjmccall wrote: > We just talk about it. I agree with Nathan that we shouldn't just add this > as a short-term hack; we should design the ABI right and then do what we want. > > I think these are

[PATCH] D87520: [tests][compiler-rt] Implement generic_ldbl{80,128}_test targets

2020-09-11 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added a comment. See rG553833958fd as an example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87520/new/ https://reviews.llvm.org/D87520

[PATCH] D87321: Fix -gz=zlib options for linker

2020-09-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/compress.c:21 -// RUN: %clang -### -fintegrated-as -gz=none -x assembler -c %s 2>&1 | FileCheck -check-prefix CHECK-OPT_GZ_EQ_NONE %s -// RUN: %clang -### -fintegrated-as -gz=none -c %s 2>&1 | FileCheck

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

2020-09-11 Thread Russell Gallop via Phabricator via cfe-commits
russell.gallop added a comment. In D86694#2242559 , @cryptoad wrote: > In D86694#2242150 , @russell.gallop > wrote: > >> In D86694#2242140 , @cryptoad wrote: >> >>> That's

[PATCH] D87223: [FPEnv] [Clang] Enable constrained FP support for PowerPC

2020-09-11 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8ecc8520bc5b: [FPEnv] [Clang] Enable constrained FP support for PowerPC (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 8ecc852 - [FPEnv] [Clang] Enable constrained FP support for PowerPC

2020-09-11 Thread Qiu Chaofan via cfe-commits
Author: Qiu Chaofan Date: 2020-09-12T00:39:52+08:00 New Revision: 8ecc8520bc5bc20ae00c13e5ae13f8edbb80642e URL: https://github.com/llvm/llvm-project/commit/8ecc8520bc5bc20ae00c13e5ae13f8edbb80642e DIFF: https://github.com/llvm/llvm-project/commit/8ecc8520bc5bc20ae00c13e5ae13f8edbb80642e.diff

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

2020-09-11 Thread Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
rnk added a comment. Looks good, but we should test both sides of the MSVC behavior. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

2020-09-11 Thread Sukraat Ahluwalia via Phabricator via cfe-commits
sukraat91 created this revision. sukraat91 added a reviewer: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. sukraat91 requested review of this revision. This patch solves a bug (https://bugs.llvm.org/show_bug.cgi?id=44598) that was filed for a

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

2020-09-11 Thread Stephen Hines via Phabricator via cfe-commits
srhines added a comment. In D83144#2268760 , @fmayer wrote: > Thanks for the review! Should I wait for Alex to take a look, or is it fine > like this? George added @alexfh a while ago, but if it's ok with you, maybe give him until Tuesday or Wednesday

[PATCH] D87537: [lld][WebAssembly] Add mutable-globals to feature section if needed

2020-09-11 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 updated this revision to Diff 291317. sbc100 edited the summary of this revision. sbc100 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. switch to verification in wasm-ld Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87321: Fix -gz=zlib options for linker

2020-09-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-gz-options.hip:14 +// CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}} +// CHECK: {{"--compress-debug-sections=zlib"}} MaskRay wrote: > Since

[PATCH] D87533: [SyntaxTree][Synthesis] Add support for Tree.

2020-09-11 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 291320. eduucaldas marked an inline comment as done. eduucaldas added a comment. Add argument names to function declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87533/new/

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

2020-09-11 Thread Thomas Lively via Phabricator via cfe-commits
tlively added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:246-252 + llvm::Reloc::Model RelocationModel; + unsigned PICLevel; + bool IsPIE; + std::tie(RelocationModel, PICLevel, IsPIE) = ParsePICArgs(*this, DriverArgs); + if (RelocationModel ==

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

2020-09-11 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 291321. lxfind added a comment. Add test to verify that lifetime.end appears right after the address call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files:

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

2020-09-11 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 291324. lxfind added a comment. remove asan option, not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files: clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

2020-09-11 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

2020-09-11 Thread Sukraat Ahluwalia via Phabricator via cfe-commits
sukraat91 updated this revision to Diff 291334. sukraat91 added a comment. Updated patch to contain changes to variable case from `paramName` to `ParamName`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87540/new/ https://reviews.llvm.org/D87540 Files:

[PATCH] D87321: Fix -gz=zlib options for linker

2020-09-11 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGccb4124a4172: Fix -gz=zlib options for linker (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] ccb4124 - Fix -gz=zlib options for linker

2020-09-11 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-09-11T17:12:58-04:00 New Revision: ccb4124a4172bf2cb2e1cd7c253f0f1654fce294 URL: https://github.com/llvm/llvm-project/commit/ccb4124a4172bf2cb2e1cd7c253f0f1654fce294 DIFF:

[clang] f5ab5b2 - Sema: add support for `__attribute__((__swift_error__))`

2020-09-11 Thread Saleem Abdulrasool via cfe-commits
Author: Saleem Abdulrasool Date: 2020-09-11T21:20:38Z New Revision: f5ab5b20fb2aae5567e6c50cc642ff63eb2146d4 URL: https://github.com/llvm/llvm-project/commit/f5ab5b20fb2aae5567e6c50cc642ff63eb2146d4 DIFF: https://github.com/llvm/llvm-project/commit/f5ab5b20fb2aae5567e6c50cc642ff63eb2146d4.diff

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

2020-09-11 Thread Saleem Abdulrasool via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf5ab5b20fb2a: Sema: add support for `__attribute__((__swift_error__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87331?vs=290990=291336#toc Repository: rG LLVM

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

2020-09-11 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. hmm @rjmccall, I don't think there is a stable way to test this. The code generated for symmetric transfer is way too complicated to stably pattern match one less item in the frame. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >