[clang] 7a932f4 - [Parser] ParseMicrosoftAsmStatement - Replace bit '|' operator with logical '||' operator. (PR47071)

Author: Simon Pilgrim Date: 2020-10-05T14:23:28+01:00 New Revision: 7a932f4f4ccbc0c4294c6911d404f74529f3259b URL: https://github.com/llvm/llvm-project/commit/7a932f4f4ccbc0c4294c6911d404f74529f3259b DIFF: https://github.com/llvm/llvm-project/commit/7a932f4f4ccbc0c4294c6911d404f74529f3259b.diff

[PATCH] D88013: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88013/new/ https://reviews.llvm.org/D88013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 96c8a17 - [clangd] Remove unused using-decls in TypeHierarchyTests, NFC.

Author: Haojian Wu Date: 2020-10-05T13:14:53+02:00 New Revision: 96c8a17c800b2370f6d43fe67559ca10d5e44196 URL: https://github.com/llvm/llvm-project/commit/96c8a17c800b2370f6d43fe67559ca10d5e44196 DIFF: https://github.com/llvm/llvm-project/commit/96c8a17c800b2370f6d43fe67559ca10d5e44196.diff

[PATCH] D88822: [clangd] Describe non-handling of most IWYU pragmas. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG007dd12d5468: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl (authored by martong). Repository: rG LLVM Github

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

martong added a comment. > Currently, we are totally inconsistent about the diagnostics. Either we > should emit a diagnostic before all return false or we should not ever emit > any diags. The diagnostics in their current form are misleading, because > there could be many notes missing. I am

[clang] 007dd12 - [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

Author: Gabor Marton Date: 2020-10-05T14:06:09+02:00 New Revision: 007dd12d546814977519b33ca38b1cc8b31fee26 URL: https://github.com/llvm/llvm-project/commit/007dd12d546814977519b33ca38b1cc8b31fee26 DIFF: https://github.com/llvm/llvm-project/commit/007dd12d546814977519b33ca38b1cc8b31fee26.diff

[PATCH] D88745: [clangd][WIP] Add new code completion signals to improve MRR by 3%.

usaxena95 updated this revision to Diff 296159. usaxena95 edited the summary of this revision. usaxena95 added a comment. Updated the references to old signals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88745/new/

[PATCH] D88828: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D88828: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, but can you add some description about why you've decided to do it now :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88828/new/

[clang-tools-extra] 1425c72 - [clangd] Add isKeyword function.

Author: Haojian Wu Date: 2020-10-05T15:11:24+02:00 New Revision: 1425c72236766ad9107d86cb645ee8c6a3ee0eb1 URL: https://github.com/llvm/llvm-project/commit/1425c72236766ad9107d86cb645ee8c6a3ee0eb1 DIFF: https://github.com/llvm/llvm-project/commit/1425c72236766ad9107d86cb645ee8c6a3ee0eb1.diff

[PATCH] D78902: [Driver] Add output file to properties of Command

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:135 + Bundler, BundlerArgs, Inputs, + InputInfo(, Output.c_str(; } I would suggest to use

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/ASTContext.h:668 + // clang's C-only codepath doesn't support dependent types yet, it is used to + // perform early typo

[PATCH] D88810: [clangd] Add isKeyword function.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:638 + // Keywords are initialized in constructor. + clang::IdentifierTable KeywordsTable(LangOpts); + return KeywordsTable.find(NewName) != KeywordsTable.end(); sammccall wrote:

[PATCH] D88810: [clangd] Add isKeyword function.

hokein updated this revision to Diff 296168. hokein marked an inline comment as done. hokein added a comment. address code comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88810/new/ https://reviews.llvm.org/D88810 Files:

[PATCH] D88810: [clangd] Add isKeyword function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1425c7223676: [clangd] Add isKeyword function. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, gribozavr2, aaron.ballman. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: martong, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun, whisperity, mgorny. Herald added

[PATCH] D88829: [OpenMP][RTL] Remove dead code

grokos added a comment. In D88829#2311768 , @JonChesterfield wrote: > Rolling the reduction in leading whitespace in > nvptx_target_parallel_reduction_codegen.cpp in with the patch might be > contentious, added a couple more reviewers to see if other

[PATCH] D88829: [OpenMP][RTL] Remove dead code

JonChesterfield accepted this revision. JonChesterfield added a comment. Thanks guys, will remember that as the local convention on rolling whitespace changes into other stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88829/new/

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

baloghadamsoftware added a comment. In D88831#2311802 , @lebedev.ri wrote: > In D88831#2311800 , @Eugene.Zelenko > wrote: > >> Does this check make sense in content of other style guides? > > I'd +1 to moving it

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi accepted this revision. sameeranjoshi added a comment. Thanks for patch. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

DiggerLin added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:46 ///< aliases to base ctors when possible. -CODEGENOPT(DataSections , 1, 0) ///< Set when -fdata-sections is enabled. +CODEGENOPT(DataSections

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16447 + +bool AIXBitfieldViolation = false; +if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs()) { Can this change can be split out into its own patch? If it can i would

[PATCH] D88829: [OpenMP][RTL] Remove dead code

JonChesterfield added a comment. Change looks great to me. Rolling the reduction in leading whitespace in nvptx_target_parallel_reduction_codegen.cpp in with the patch might be contentious, added a couple more reviewers to see if other people would prefer that part split out. I'll accept in a

[PATCH] D88833: Do not warn on pointer decays in system macros

fiesh created this revision. fiesh added a reviewer: aaron.ballman. fiesh added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. fiesh requested review of this revision. As system headers are in general out of reach, it makes

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. Continued in https://reviews.llvm.org/D88833 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.org/D31130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri updated this revision to Diff 296173. lebedev.ri added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88789/new/ https://reviews.llvm.org/D88789 Files: clang/test/CodeGen/attr-arm-sve-vector-bits-bitcast.c

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

Eugene.Zelenko added a comment. Does this check make sense in content of other style guides? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://reviews.llvm.org/D88831 ___ cfe-commits

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

lebedev.ri added a comment. In D88831#2311800 , @Eugene.Zelenko wrote: > Does this check make sense in content of other style guides? I'd +1 to moving it to `readability`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88829: [OpenMP][RTL] Remove dead code

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks for removing dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88829/new/ https://reviews.llvm.org/D88829

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jdoerfert accepted this revision. jdoerfert added a comment. LGTM, a new triple makes sense here, we don't support arbitrary combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added a subscriber: jyknight. jdoerfert added a comment. One minor nit from me. @jyknight @aaron.ballman @rjmccall any more thoughts? Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || +

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:74 auto Names = splitQualifiedName(Query); Add a comment here (or elsewhere, I guess) about how qualified names are handled. - exact namespace: boosted on the index

[clang] eaf7329 - [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

Author: Joseph Huber Date: 2020-10-05T11:02:13-04:00 New Revision: eaf73293cb6b8d45dd85ffced57aea7ad4177754 URL: https://github.com/llvm/llvm-project/commit/eaf73293cb6b8d45dd85ffced57aea7ad4177754 DIFF: https://github.com/llvm/llvm-project/commit/eaf73293cb6b8d45dd85ffced57aea7ad4177754.diff

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf73293cb6b: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload (authored by jhuber6). Repository: rG LLVM Github

Re: [PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

Nice! I'm glad to see the patch being revived. Thanks for that :) Em seg, 5 de out de 2020 10:48, fiesh via Phabricator < revi...@reviews.llvm.org> escreveu: > fiesh added a comment. > > Continued in https://reviews.llvm.org/D88833 > > > CHANGES SINCE LAST ACTION >

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. I neglected to hit the "submit" button last week, these are the inline questions I have. Also in addition to the comments above, check-clang is showing 1 LIT test failing AST/const-fpfeatures.cpp I believe the clang constant folder is returning False for the

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:410-411 setRoundingMode(LO.getFPRoundingMode()); +// FENV access is true if rounding math is enabled. +setAllowFEnvAccess((getRoundingMode() == llvm::RoundingMode::Dynamic));

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Google C++ style guide does not have this rule anymore. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/

<    1   2