[PATCH] D88415: [clangd] Introduce memory usage dumping to TUScheduler, for Preambles and ASTCache

kadircet updated this revision to Diff 296691. kadircet marked 3 inline comments as done. kadircet added a comment. - Rename attachMemoryUsage to profile - Group by filename, rather than ast_cache vs preamble - Make use of UsedBytesAST rather than profiling IdleASTs - Rebase Repository: rG

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson updated this revision to Diff 296689. arichardson added a comment. Use an enum config option instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88227/new/ https://reviews.llvm.org/D88227 Files:

[PATCH] D88970: [clangd] Fix argument type (bool->float).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcd8422d7506: [clangd] Fix argument type (bool-float). (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] bcd8422 - [clangd] Fix argument type (bool->float).

Author: Adam Czachorowski Date: 2020-10-07T17:22:00+02:00 New Revision: bcd8422d75069624dc2daf7e5ff4b4f6cbcd6b71 URL: https://github.com/llvm/llvm-project/commit/bcd8422d75069624dc2daf7e5ff4b4f6cbcd6b71 DIFF:

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

kadircet updated this revision to Diff 296684. kadircet marked 4 inline comments as done. kadircet added a comment. - Rename attachMemoryUsage to profile - Split file symbols into symbols/refs/relations granularity - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88970: [clangd] Fix argument type (bool->float).

adamcz created this revision. adamcz added a reviewer: usaxena95. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The default value is 1.3f, but it was cast to

[PATCH] D88968: [WebAssembly] Prototype i16x8.q15mulr_sat_s

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. This saturating, rounding,

[PATCH] D88413: [clangd] Add a metric for tracking memory usage

kadircet updated this revision to Diff 296678. kadircet added a comment. - Rebase and introduce helper for recording a MemoryTree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88413/new/ https://reviews.llvm.org/D88413 Files:

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2066 + // Keep track of defined physregs. + std::set PhysRegOutputs; + Use llvm::SmallSet? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet updated this revision to Diff 296677. kadircet marked 2 inline comments as done. kadircet added a comment. - Make MemoryTree move-only and return refs instead of pointers on child and detail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88963: [SystemZ][z/OS] Add test of zero length bitfield type size larger than target zero length bitfield boundary

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88963/new/ https://reviews.llvm.org/D88963

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet updated this revision to Diff 296675. kadircet added a comment. - Add self Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88411/new/ https://reviews.llvm.org/D88411 Files: clang-tools-extra/clangd/support/CMakeLists.txt

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +CalledFunctions.push_back(CE); +}};

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall accepted this revision. sammccall added a comment. LGTM, thanks! Comment at: clang-tools-extra/clangd/support/MemoryTree.h:57 + /// Returns total number of bytes used by this sub-tree. Performs a traversal. + size_t total() const; + oops, we

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet updated this revision to Diff 296667. kadircet marked 9 inline comments as done. kadircet added a comment. - Rename add{Detail,Child} -> {detail,child} - Get rid of `traverseTree` API and only expose `total` - Add a `children()` getter Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.h:36 + /// No copy of the \p Name. + MemoryTree *addChild(llvm::StringLiteral Name) { return (Name); } + sammccall wrote: > sammccall wrote: > > actually, why do these

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu updated this revision to Diff 296665. jasonliu added a comment. Change lld's forwarder function's signature to match LLVM style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: clang/test/Driver/aix-data-sections.c:7 +// RUN: | FileCheck %s +// CHECK: "-fdata-sections" DiggerLin wrote: > may be good to check the whether other OS platform behavior

[PATCH] D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:71 switch (Info.getID()) { + case diag::err_incomplete_base_class: case diag::err_incomplete_type: nit: maybe revert this change, or put `err_incomplete_type` to the

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +CalledFunctions.push_back(CE); +}};

[PATCH] D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Also sort the list to make it easier to verify with the

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

aaron.ballman added a comment. Despite my earlier happiness with the patch, it's now a bit unclear to me from the C++ Core Guideline wording what the right behavior here actually is. The bounds profile is trying to ensure you don't access out-of-range elements of a container and the decay part

[PATCH] D88963: [SystemZ][z/OS] Add test of zero length bitfield type larger than zero length bitfield boundary

fanbo-meng created this revision. fanbo-meng added reviewers: abhina.sreeskantharajan, hubert.reinterpretcast. Herald added a project: clang. Herald added a subscriber: cfe-commits. fanbo-meng requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D88952: [clang-format][tests] Fix MacroExpander lexer not parsing C++ keywords

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Nice catch, thanks! LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88952/new/ https://reviews.llvm.org/D88952

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

klimek added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8333 +TEST_F(FormatTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) { + // This is a regression test for mis-parsing the & after decltype as a binary arichardson wrote: >

[PATCH] D17053: [libcxx]: vector: Use < instead of != to improve failure mode

ldionne added a comment. Also, regarding `allocator::pointer` vs raw pointers -- if someone defines a fancy pointer type whose `operator<` is significantly more costly than `operator!=`, I think this loop in libc++ is not the first thing that's going to bite them. I don't think that's the

[PATCH] D17053: [libcxx]: vector: Use < instead of != to improve failure mode

ldionne added a comment. In D17053#2315384 , @dexonsmith wrote: > In D17053#632700 , @EricWF wrote: > >> Maybe if we want to improve the failure mode we can add a >> `_LIBCPP_ASSERT(__new_last <= __end, "invalid

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel added a comment. In D88275#2316484 , @aaron.ballman wrote: > Thank you for your patience while we sort this out. I've pinged @steveire > off-list, so hopefully he'll respond with his thoughts. If we don't hear from > Stephen in the next week or

[PATCH] D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets

tpr updated this revision to Diff 296648. tpr added a comment. V3: AMDGCNGPUs table in TargetParser.cpp needs to be in GPUKind order, so fix the GPUKind order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88916/new/

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

aaron.ballman added a comment. In D88275#2313342 , @ymandel wrote: > In D88275#2305989 , @aaron.ballman > wrote: > >> In D88275#2303283 , @ymandel wrote: >> I'm not

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

hans added a comment. In D88831#2316453 , @lebedev.ri wrote: > @hans it would be nice if this could make it into the release, > removing stuff is usually a pretty safe thing to do :) I think it's too late for this release, sorry. I also don't see any

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

nemanjai added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-vsx.c:1 -// REQUIRES: powerpc-registered-target +// requires: powerpc-registered-target // RUN: %clang_cc1 -target-feature +altivec -target-feature +vsx -triple powerpc64-unknown-unknown -emit-llvm %s

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8333 +TEST_F(FormatTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) { + // This is a regression test for mis-parsing the & after decltype as a binary klimek wrote: > I'd

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

klimek added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8333 +TEST_F(FormatTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) { + // This is a regression test for mis-parsing the & after decltype as a binary I'd put this into a new

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

lebedev.ri added a subscriber: hans. lebedev.ri added a comment. @hans it would be nice if this could make it into the release, removing stuff is usually a pretty safe thing to do :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner added a comment. I'm sorry, but I don't know how to reproduce the problem in isolation. We are JIT-compiling fairly complex C++ code, and the crash //sometimes// occurs when, for example, an included header file is not found... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij reopened this revision. stuij added a comment. This revision is now accepted and ready to land. Reopening as this commit made clang/test/CodeGen/volatile.c fail on Arm/AArch64 buildbot hosts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78902: [Driver] Add output file to properties of Command

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

yaxunl added a comment. Can we have a lit test? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

arichardson added a comment. In D86959#2316351 , @arichardson wrote: > In D86959#2313631 , @sammccall wrote: > >> Sorry to be really late here, but this patch regressed some macro >> definitions like: >> >>

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson updated this revision to Diff 296640. arichardson added a comment. remove unneccessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88956/new/ https://reviews.llvm.org/D88956 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, sammccall, klimek, JakeMerdichAMD, curdeius. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. arichardson requested review of this revision. After D86959

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

sepavloff added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:139 + + switch (E->getStmtClass()) { + case Stmt::UnaryOperatorClass: { Actually this is not correct, because subclass relations are not preserved in this case. For instance,

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

arichardson added a comment. In D86959#2313631 , @sammccall wrote: > Sorry to be really late here, but this patch regressed some macro definitions > like: > > #define lambda [](const decltype(x) ) {} > > which now formats as > > #define lambda

[PATCH] D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery.

hokein added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6444 + "should only occur in error-recovery path."); +return CallExpr::Create(Context, Fn, ArgExprs, Context.DependentTy, +VK_RValue, RParenLoc);

[PATCH] D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery.

hokein updated this revision to Diff 296634. hokein added a comment. fix format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84304/new/ https://reviews.llvm.org/D84304 Files: clang/lib/Sema/SemaExpr.cpp clang/test/AST/ast-dump-recovery.c

[PATCH] D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery.

hokein updated this revision to Diff 296633. hokein marked 4 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84304/new/ https://reviews.llvm.org/D84304 Files:

[PATCH] D88952: [clang-format][tests] Fix MacroExpander lexer not parsing C++ keywords

arichardson created this revision. arichardson added reviewers: klimek, sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. While debugging a different clang-format failure, I tried to reuse the MacroExpander lexer, but

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. In D88680#2314415 , @hans wrote: > I've committed this as 66e4f07198761bbb4dcd55235024c1081ed15c75 > so it > has a chance to make it into the 11.0.0 release.

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added inline comments. Comment at: clang/include/clang/Driver/Job.h:165 + const llvm::opt::ArgStringList , ArrayRef Inputs, + ArrayRef Outputs); // FIXME: This really shouldn't be copyable, but is currently copied in some yaxunl

[PATCH] D88088: [clang] improve accuracy of ExprMutAnalyzer

JonasToth updated this revision to Diff 296628. JonasToth added a comment. - fix imprecisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88088/new/ https://reviews.llvm.org/D88088 Files: clang/lib/Analysis/ExprMutationAnalyzer.cpp

[PATCH] D85354: [clangd] Reduce availability of extract function

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:291 + llvm::SmallSet DeclsInExtZone; + for (const Node *Child : ExtZone.Parent->Children) { +auto *RootStmt = Child->ASTNode.get(); sammccall wrote: >

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 296625. sepavloff marked an inline comment as done. sepavloff added a comment. Add default argument for parameter Output in constructors of Command* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/

[PATCH] D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets

tpr updated this revision to Diff 296623. tpr added a comment. Herald added subscribers: cfe-commits, jholewinski. Herald added a project: clang. V2: Add clang changes. Put TargetParser list in order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename.

hokein added a comment. In D1#2313863 , @sammccall wrote: > Can you add a bit more context to the commit message? > > And should we expose this as an extension on `textDocument/prepareRename`? no needed right now. AFAIK, there are no lsp clients that

[PATCH] D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename.

hokein updated this revision to Diff 296622. hokein marked an inline comment as done. hokein added a comment. make NewName optional. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1/new/ https://reviews.llvm.org/D1 Files:

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2090 +CGM.Error(S.getAsmLoc(), "Multiple outputs to hard register: " + GCCReg); + PhysRegOutputs.insert(GCCReg); +} craig.topper wrote: > Can we get rid of the count call

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 296618. jonpa marked an inline comment as done. jonpa added a comment. Updated per review by eliminating the call to 'count'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 Files:

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner added a comment. See https://bugs.llvm.org/show_bug.cgi?id=47742 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___ cfe-commits mailing list

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner created this revision. glevner added reviewers: lhames, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. glevner requested review of this revision. Patch VisitCXXDeleteExpr() in clang::UsedDeclVisitor to avoid it crashing when the expression's destroyed type

[PATCH] D88472: [clangd] Don't set the Underlying bit on targets of UsingDecls.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf24649b77d85: [clangd] Dont set the Underlying bit on targets of UsingDecls. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] f24649b - [clangd] Don't set the Underlying bit on targets of UsingDecls.

Author: Haojian Wu Date: 2020-10-07T10:01:04+02:00 New Revision: f24649b77d856157c64841457dcc4f70530d607c URL: https://github.com/llvm/llvm-project/commit/f24649b77d856157c64841457dcc4f70530d607c DIFF: https://github.com/llvm/llvm-project/commit/f24649b77d856157c64841457dcc4f70530d607c.diff

[PATCH] D88472: [clangd] Don't set the Underlying bit on targets of UsingDecls.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1121 namespace ns { class [[Foo]] {}; } - using ns::F^oo; + using ns::[[F^oo]]; )cpp", sammccall wrote: > I'd like to make a plan to solve this

[PATCH] D88472: [clangd] Don't set the Underlying bit on targets of UsingDecls.

hokein updated this revision to Diff 296612. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88472/new/ https://reviews.llvm.org/D88472 Files:

[clang] 31dc908 - [clang] Use isCompoundAssignmentOp to simplify the code, NFC.

Author: Haojian Wu Date: 2020-10-07T09:50:43+02:00 New Revision: 31dc90801746e12d6ae1f967f455cf43a5bbb039 URL: https://github.com/llvm/llvm-project/commit/31dc90801746e12d6ae1f967f455cf43a5bbb039 DIFF: https://github.com/llvm/llvm-project/commit/31dc90801746e12d6ae1f967f455cf43a5bbb039.diff

[PATCH] D84387: [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

hokein added a comment. > I'm not sure I love having the assertion for contains-errors every place that > handles dependent code in C. My feeling is that the assertion would help for understanding the code (comparing with documenting it somewhere), and we don't have too many places.

[PATCH] D84387: [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

hokein updated this revision to Diff 296611. hokein marked an inline comment as done. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84387/new/ https://reviews.llvm.org/D84387 Files: clang/lib/Sema/SemaCast.cpp

[clang] 334ec6f - [AST][RecoveryExpr] Support dependent conditional operators in C for error recovery.

Author: Haojian Wu Date: 2020-10-07T09:33:57+02:00 New Revision: 334ec6f807fa65e09571fa42a0c3be0eb39e7c0f URL: https://github.com/llvm/llvm-project/commit/334ec6f807fa65e09571fa42a0c3be0eb39e7c0f DIFF: https://github.com/llvm/llvm-project/commit/334ec6f807fa65e09571fa42a0c3be0eb39e7c0f.diff

[PATCH] D84322: [AST][RecoveryExpr] Part3: Support dependent conditional operators in C for error recovery.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG334ec6f807fa: [AST][RecoveryExpr] Support dependent conditional operators in C for error… (authored by hokein). Repository: rG LLVM Github

[PATCH] D84322: [AST][RecoveryExpr] Part3: Support dependent conditional operators in C for error recovery.

hokein updated this revision to Diff 296609. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84322/new/ https://reviews.llvm.org/D84322 Files:

[PATCH] D84322: [AST][RecoveryExpr] Part3: Support dependent conditional operators in C for error recovery.

hokein added inline comments. Comment at: clang/test/Sema/error-dependence.c:18 + // type is required" is not emitted. + ptr > f ? ptr : f; // expected-error {{invalid operands to binary expression}} +} sammccall wrote: > hokein wrote: > > sammccall wrote: >

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2090 +CGM.Error(S.getAsmLoc(), "Multiple outputs to hard register: " + GCCReg); + PhysRegOutputs.insert(GCCReg); +} Can we get rid of the count call above and just use

<    1   2