[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

hans added a comment. The longer timeout didn't help :( I'm not sure what's different about the machine where this is failing. Maybe it's some filesystem issue due to being a VM? Any ideas for good printfs or similar that could be added to figure out exactly what part is failing?

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

saudi added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1420 + if (Var->getInit()) +Value = Var->evaluateValue(); + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { I encountered an assert inside

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

aeubanks added a comment. I've also been seeing some failures on phab reviews, e.g. https://reviews.llvm.org/D89188. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2327976 , @rjmccall wrote: > In D76620#2327910 , @erichkeane > wrote: > >> In D76620#2327901 , @rjmccall wrote: >> >>> You know on

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/ASTImporter.cpp:8109 + FromAttr->getAttributeSpellingListIndex()); + ToAttr->setPackExpansion(FromAttr->isPackExpansion()); +

[PATCH] D88314: Added llvm-string-referencing check

aaron.ballman added a comment. In D88314#2322870 , @bogser01 wrote: > @aaron.ballman Thank you for picking up this review! Running the check over > the entire LLVM causes ~74K warnings across 430 files. As to the false > positive rate it's tricky to

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:103 #ifndef NDEBUG - for (auto *N = New; N; N = N->getNextSibling()) { + for (auto *N = New; N; N = N->NextSibling) { assert(N->Parent == nullptr); eduucaldas wrote: >

[PATCH] D89184: Support complex target features combinations

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D89184#2328144 , @craig.topper wrote: > This is needed for D89105 and was split > from it. D89105

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

FWIW, I don't see any issues with my two bots that use buildbot annotated commands: http://lab.llvm.org:8011/#/builders/sanitizer-windows http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc The individual steps don't highlight as green or red, but that's OK for now. On Mon, Oct 12, 2020 at

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3469 + + // The value can be empty, which indicates the system default should be used. + StringRef CXXABI =

[clang] 10f1ca9 - Revert "[analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions."

Author: Artem Dergachev Date: 2020-10-13T12:07:36-07:00 New Revision: 10f1ca99b498347186ec74b01046ad292bde9a4c URL: https://github.com/llvm/llvm-project/commit/10f1ca99b498347186ec74b01046ad292bde9a4c DIFF:

[PATCH] D78658: [clang][Frontend] Add missing error handling

dblaikie added a comment. In D78658#2327615 , @LemonBoy wrote: >> Perhaps this'd be more robust with ScopeExit? > > Not really, `OnError` is not executed when/if the function succeeds. Ah, sorry - ScopeExit has a 'release()' function intended to

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:618-619 FPOptions OldFPFeatures; +llvm::fp::ExceptionBehavior OldExcept; +llvm::RoundingMode OldRounding; Optional FMFGuard; sepavloff wrote: > Is it possible to merge

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2328305 , @rjmccall wrote: > In D76620#2328031 , @erichkeane > wrote: > >> In D76620#2328011 , @rjmccall wrote: >> >>> In

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2328011 , @rjmccall wrote: > In D76620#2327988 , @erichkeane > wrote: > >> In D76620#2327976 , @rjmccall wrote: >> >>> In

[PATCH] D89184: Support complex target features combinations

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. Sorry, I didn't mean to stamp the change as LGTM overall yet. Can't find a way to un-LGTM, so marking it as `Request Changes` for now. CHANGES SINCE LAST ACTION

[clang] 662ed9e - Revert "[analyzer] NFC: Move IssueHash to libAnalysis."

Author: Artem Dergachev Date: 2020-10-13T12:07:28-07:00 New Revision: 662ed9e67adace3d011f42478bc8bcb1773a2821 URL: https://github.com/llvm/llvm-project/commit/662ed9e67adace3d011f42478bc8bcb1773a2821 DIFF:

[PATCH] D89146: [SyntaxTree] Fix rtti for `Expression`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8f1790fdb8c: [SyntaxTree] Fix rtti for `Expression`. (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89025: [RISCV] Add -mtune support

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM, but I would like other people to also review this, if possible. (Just be sure to check/fix the clang-format warnings and the inline comments). Comment at:

[PATCH] D89025: [RISCV] Add -mtune support

luismarques added a comment. In D89025#2324334 , @khchen wrote: > RISCV supports `-mcpu` with default empty arch to align gcc's `-mtune` > behavior since clang didn't support `-mtune` before. But now clang has > `-mtune`, is it a good idea to remove

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 ___ cfe-commits mailing list

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. You know on both sides that a lambda is used as a kernel, yes? Why not simply introduce that into the mangling of lambdas, so that the subset of lambdas used as kernels form a stable sequence? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 77bb3eb - Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."

Author: Artem Dergachev Date: 2020-10-13T12:03:04-07:00 New Revision: 77bb3ebebbca13f0648beb433fbd1b06ba95a19c URL: https://github.com/llvm/llvm-project/commit/77bb3ebebbca13f0648beb433fbd1b06ba95a19c DIFF:

[clang] 0ec1cf1 - Revert "DirectoryWatcher: add an implementation for Windows"

Author: Reid Kleckner Date: 2020-10-13T12:35:22-07:00 New Revision: 0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577 URL: https://github.com/llvm/llvm-project/commit/0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577 DIFF: https://github.com/llvm/llvm-project/commit/0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577.diff

[PATCH] D89312: [SVE][CodeGen]Use TypeSize comparison functions in clang

CarolineConcatto updated this revision to Diff 297884. CarolineConcatto added a comment. -Use getFixedSize instead of isKnowXY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89312/new/ https://reviews.llvm.org/D89312 Files:

[PATCH] D89125: AMDGPU: Remove -mamdgpu-debugger-abi option

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2eaa914514c: AMDGPU: Remove -mamdgpu-debugger-abi option (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] e2eaa91 - AMDGPU: Remove -mamdgpu-debugger-abi option

Author: Konstantin Zhuravlyov Date: 2020-10-13T12:20:28-04:00 New Revision: e2eaa914514c26c8e51c76148996a2e9cf74613c URL: https://github.com/llvm/llvm-project/commit/e2eaa914514c26c8e51c76148996a2e9cf74613c DIFF:

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. In D76620#2327910 , @erichkeane wrote: > In D76620#2327901 , @rjmccall wrote: > >> You know on both sides that a lambda is used as a kernel, yes? Why not >> simply introduce that into

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} lebedev.ri wrote: > Just put it here? I

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. In D76620#2328031 , @erichkeane wrote: > In D76620#2328011 , @rjmccall wrote: > >> In D76620#2327988 , @erichkeane >> wrote: >> >>> In

[clang] a8f1790 - [SyntaxTree] Fix rtti for `Expression`.

Author: Eduardo Caldas Date: 2020-10-13T14:47:43Z New Revision: a8f1790fdb8ce1c53f024870cd51f32724d4c55f URL: https://github.com/llvm/llvm-project/commit/a8f1790fdb8ce1c53f024870cd51f32724d4c55f DIFF: https://github.com/llvm/llvm-project/commit/a8f1790fdb8ce1c53f024870cd51f32724d4c55f.diff

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. In D76620#2327988 , @erichkeane wrote: > In D76620#2327976 , @rjmccall wrote: > >> In D76620#2327910 , @erichkeane >> wrote: >> >>> In

[PATCH] D89184: Support complex target features combinations

craig.topper added a comment. This is needed for D89105 and was split from it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ cfe-commits mailing list

[PATCH] D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O

compnerd abandoned this revision. compnerd added a comment. Sure, I think I can do that instead. Thanks for pointing me to that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89078/new/ https://reviews.llvm.org/D89078

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:46 + +void ConstCorrectnessCheck::registerMatchers(MatchFinder *Finder) { + const auto ConstType = hasType(isConstQualified()); JonasToth

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Mon, Oct 12, 2020 at 10:01 PM Galina Kistanova via lldb-commits wrote: > If somebody else could move their AnnotatedCommand bots to the staging area, > that would be much appreciated. I moved the libc bots to staging to now. Thanks, Siva Chandra

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 297925. venkataramanan.kumar.llvm added a comment. Updated the patch as per review comments received. The test cases are updated the checks based on the below comment from Francesco. ---Snip-- I think you are over-testing here. It is

Re: [PATCH] D88666: DirectoryWatcher: add an implementation for Windows

If I had to guess, my money would be on a deadlock. To unblock, I'd propose reverting this patch until we can figure it out. During the review, a deadlock was fixed related to the watcher thread, but perhaps we missed one for the notifier thread. On Tue, Oct 13, 2020 at 8:40 AM Hans Wennborg

[PATCH] D89332: Always allow std::function to be copied.

flx created this revision. flx added a reviewer: aaron.ballman. Herald added a project: clang. flx requested review of this revision. Since its call operator is const but can modify the state of its underlying functor we cannot tell whether the copy is necessary or not. This avoids false

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > >

[PATCH] D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/ASTMerge/attr/Inputs/FormatAttr.cpp:2 +int foo(const char * fmt, ...) +__attribute__ ((__format__ (__scanf__, 1, 2)));

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

saudi added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1420 + if (Var->getInit()) +Value = Var->evaluateValue(); + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { saudi wrote: > I encountered an assert inside

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > NoQ wrote:

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} Just put it here? Repository:

[PATCH] D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89319/new/ https://reviews.llvm.org/D89319 ___ cfe-commits mailing list

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2327901 , @rjmccall wrote: > You know on both sides that a lambda is used as a kernel, yes? Why not > simply introduce that into the mangling of lambdas, so that the subset of > lambdas used as kernels form a

[PATCH] D89184: Support complex target features combinations

tra accepted this revision. tra added a subscriber: echristo. tra added a comment. This revision is now accepted and ready to land. @echristo : FYI, just in case you have an opinion on bringing required feature constraint checks one step closer to being Turing-complete. :-) LGTM as far as

[clang] b76dc11 - [analyzer] NFC: Move IssueHash to libAnalysis.

Author: Artem Dergachev Date: 2020-10-13T10:53:10-07:00 New Revision: b76dc111dd02672488df794570d82e3edbbfa5d8 URL: https://github.com/llvm/llvm-project/commit/b76dc111dd02672488df794570d82e3edbbfa5d8 DIFF:

[clang] 44b7cf2 - [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Author: Artem Dergachev Date: 2020-10-13T10:53:10-07:00 New Revision: 44b7cf2983b6a8373c99a9b254f8c3f944e03f35 URL: https://github.com/llvm/llvm-project/commit/44b7cf2983b6a8373c99a9b254f8c3f944e03f35 DIFF:

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd4b3f123d6e: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions. (authored by dergachev.a). Herald added a subscriber: steakhal. Repository: rG LLVM Github Monorepo CHANGES

[clang] fd4b3f1 - [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Author: Artem Dergachev Date: 2020-10-13T10:53:10-07:00 New Revision: fd4b3f123d6e64769881e4c6351d5bbbdac30ce3 URL: https://github.com/llvm/llvm-project/commit/fd4b3f123d6e64769881e4c6351d5bbbdac30ce3 DIFF:

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG44b7cf2983b6: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis. (authored by dergachev.a).

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb76dc111dd02: [analyzer] NFC: Move IssueHash to libAnalysis. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

aaron.ballman added a comment. Thank you for the continued work on this feature! I'd like to better understand the behavior of fallthrough labels because I think there are two conceptual models we could follow. When a label falls through to another label, should both labels be treated as

[clang] 4c10d65 - [AIX] Support two itanium alignment LIT testcases for AIX using regex

Author: Xiangling Liao Date: 2020-10-13T16:47:01-04:00 New Revision: 4c10d6508f546ee986df0994663984cb15354c08 URL: https://github.com/llvm/llvm-project/commit/4c10d6508f546ee986df0994663984cb15354c08 DIFF:

[PATCH] D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c10d6508f54: [AIX] Support two itanium alignment LIT testcases for AIX using regex (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D89064?vs=297848=297950#toc Repository:

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

compnerd updated this revision to Diff 297983. compnerd added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Herald added a project: clang. Rebase; there are a 4 more test failures to go through Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

Conanap marked 3 inline comments as done. Conanap added a comment. Addressed Nemenja's concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84962/new/ https://reviews.llvm.org/D84962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

rnk added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +// NOT-MS-SAME: line: [[@LINE-3]] +//

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy updated this revision to Diff 297959. LemonBoy added a comment. Use `ScopeExit` instead of a bare lambda. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers updated this revision to Diff 297970. nickdesaulniers added a comment. - remove modification to docs about legacy fn attr encoding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 Files:

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers updated this revision to Diff 297969. nickdesaulniers added a comment. - add -passes='cgscc(inline)' to inline_nossp.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 Files:

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added inline comments. Comment at: llvm/docs/BitCodeFormat.rst:953 base 2 of the requested alignment, plus 1 +* bit 40: ``nossp`` ah, I should remove this; this block is legacy encodings which I do not modify. Comment at:

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

dexonsmith added a comment. Note that this is split off from https://reviews.llvm.org/D66782. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89348/new/ https://reviews.llvm.org/D89348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

dexonsmith updated this revision to Diff 297990. dexonsmith added a comment. Fix a few more places where `Invalid` needs to be set to `false`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89348/new/ https://reviews.llvm.org/D89348 Files:

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added a comment. @NoQ > Can we collapse this function further towards this goal? Say, why not pump > every region unconditionally through castRegion()? Does dispatchCast() use > castRegion() internally - and if it does, why are there so many branches in > this function? I've

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: ributzka, martong. Herald added a reviewer: shafik. dexonsmith requested review of this revision. Remove `ContentCache::getBuffer`, which always returned a dereferenceable `MemoryBuffer*` and had a

[PATCH] D78658: [clang][Frontend] Add missing error handling

dblaikie accepted this revision. dblaikie added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:1158-1160 + if (!Clang->hasTarget()) { return true; + } You can remove these braces now - since it's a superfluous change here now there's no need

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

Conanap updated this revision to Diff 297936. Conanap added a comment. Use regex match to check for variable order in IR instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84962/new/ https://reviews.llvm.org/D84962 Files: clang/lib/Headers/altivec.h

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L marked 8 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:340 +LANGOPT(AIXPragmaPack, 1, 0, "AIX #pragma pack handling") + jasonliu wrote: > Not sure if AIXPragmaPack is the best name

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added inline comments. Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:610 + // TODO: reorder + ATTR_KIND_NO_STACK_PROTECT = 70, ATTR_KIND_STACK_PROTECT = 26, nickdesaulniers wrote: > any comments from reviewers before I go and do a

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers updated this revision to Diff 297967. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - address todos and review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

dexonsmith updated this revision to Diff 297987. dexonsmith added a comment. Fixed a bug where `Invalid` was only set when it was `true`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89348/new/ https://reviews.llvm.org/D89348 Files:

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

nickdesaulniers added a comment. https://bugs.llvm.org/show_bug.cgi?id=47837 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-commits mailing list

[clang] ab870f3 - Revert "PR47805: Use a single object for a function parameter in the caller and"

Author: Richard Smith Date: 2020-10-13T15:59:00-07:00 New Revision: ab870f3030fc288cd101905d730ef3425da5ac16 URL: https://github.com/llvm/llvm-project/commit/ab870f3030fc288cd101905d730ef3425da5ac16 DIFF: https://github.com/llvm/llvm-project/commit/ab870f3030fc288cd101905d730ef3425da5ac16.diff

[PATCH] D89184: Support complex target features combinations

echristo added a comment. Hi Peng, Looks interesting, but I think the language support needs some more comments about what's expected and in addition through everything else please? I've added some inline comments with places I think could use it for sure. -eric Comment

[PATCH] D89184: Support complex target features combinations

echristo requested changes to this revision. echristo added a comment. This revision now requires changes to proceed. Mark as requesting changes :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___

[PATCH] D78699: [X86] Passing union type through register.

dyung added a comment. Hi, the test you added seems to pass both before and after your change, is this intended? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78699/new/ https://reviews.llvm.org/D78699

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 297980. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/unittests/clang-tidy/IncludeInserterTest.cpp Index:

[PATCH] D78699: [X86] Passing union type through register.

dyung added inline comments. Comment at: clang/test/CodeGen/X86/avx-union.c:2 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx -emit-llvm -o %t %s || FileCheck < %t %s --check-prefix=CHECK, AVX +// RUN: %clang_cc1 -w -ffreestanding -triple

[clang] e7fe3c6 - Basic: Simplify SourceManager::getBuffer overload, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-13T17:52:59-04:00 New Revision: e7fe3c6dfede8d5781bd000741c3dea7088307a4 URL: https://github.com/llvm/llvm-project/commit/e7fe3c6dfede8d5781bd000741c3dea7088307a4 DIFF:

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8163 "%select{__device__|__global__|__host__|__host__ __device__}0 functions">; -def

[clang] 8d03a97 - PR47805: Use a single object for a function parameter in the caller and

Author: Richard Smith Date: 2020-10-13T15:45:04-07:00 New Revision: 8d03a972ce8e92815ffe3d5d86aa027605ed92e2 URL: https://github.com/llvm/llvm-project/commit/8d03a972ce8e92815ffe3d5d86aa027605ed92e2 DIFF: https://github.com/llvm/llvm-project/commit/8d03a972ce8e92815ffe3d5d86aa027605ed92e2.diff

[PATCH] D89361: [X86][NFC] Fix RUN line bug in the testcase

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd05afcb3f40: [X86][NFC] Fix RUN line bug in the testcase (authored by LiuChen3). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] bd05afc - [X86][NFC] Fix RUN line bug in the testcase

Author: Liu, Chen3 Date: 2020-10-14T12:40:34+08:00 New Revision: bd05afcb3f4093fe76dd64fe2920bfd894ec URL: https://github.com/llvm/llvm-project/commit/bd05afcb3f4093fe76dd64fe2920bfd894ec DIFF: https://github.com/llvm/llvm-project/commit/bd05afcb3f4093fe76dd64fe2920bfd894ec.diff

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rsmith added a comment. FYI: I posted a patch to implement the "manifestly constant evaluated" rule as https://reviews.llvm.org/D89360. It looks like the stricter rule doesn't work in practice; far too much C++ code uses `-frounding-math` and expects to be able to still include things like

[clang] b72813f - [CMake][Fuchsia] Start building arm64 Darwin runtimes

Author: Petr Hosek Date: 2020-10-13T19:50:45-07:00 New Revision: b72813f4d6a0a0f1dc79afc1ca7e0e4d55ad6a72 URL: https://github.com/llvm/llvm-project/commit/b72813f4d6a0a0f1dc79afc1ca7e0e4d55ad6a72 DIFF: https://github.com/llvm/llvm-project/commit/b72813f4d6a0a0f1dc79afc1ca7e0e4d55ad6a72.diff

[clang] 498c7fa - [SemaObjC] Fix a crash on an invalid ternary with ARC pointers

Author: Erik Pilkington Date: 2020-10-13T21:20:20-04:00 New Revision: 498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd URL: https://github.com/llvm/llvm-project/commit/498c7fa48a02a5e0c12bbb90ef8c0d8468affcdd DIFF:

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Hi @aaron.ballman and @njames93, I addressed your code review suggestions and supported Hungarian Notation prefix for decl of enum and class(option) at latest patch. Unfortunately, I encountered a problem that new patch failed on remote BuildBot, it showed the "No

LLVM buildbot will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298026. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files:

[clang] 8f8b9f2 - PR47805: Use a single object for a function parameter in the caller and

Author: Richard Smith Date: 2020-10-13T18:50:46-07:00 New Revision: 8f8b9f2cca0b73314342c721186ae9c860ca273c URL: https://github.com/llvm/llvm-project/commit/8f8b9f2cca0b73314342c721186ae9c860ca273c DIFF: https://github.com/llvm/llvm-project/commit/8f8b9f2cca0b73314342c721186ae9c860ca273c.diff

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rsmith created this revision. rsmith added reviewers: rjmccall, mibintc, sepavloff. Herald added a project: clang. rsmith requested review of this revision. This addresses a regression where pretty much all C++ compilations using -frounding-math now fail, due to rounding being performed in

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

efriedma added inline comments. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:1077 -static bool hasMicrosoftABIRestrictions(const CXXRecordDecl *RD) { +static bool isCXX14Aggregate(const CXXRecordDecl *RD) { // For AArch64, we use the C++14 definition of an aggregate,

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298027. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/unittests/clang-tidy/IncludeInserterTest.cpp Index:

[PATCH] D89184: Support complex target features combinations

LiuChen3 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2389 } -if (!hasRequiredFeatures(ReqFeatures, CGM, FD, MissingFeature)) +if (!llvm::all_of(ReqFeatures, [&](StringRef Feature) { + if (!CallerFeatureMap.lookup(Feature)) {

[PATCH] D78699: [X86] Passing union type through register.

LiuChen3 added a comment. In D78699#2328541 , @dyung wrote: > Hi, the test you added seems to pass both before and after your change, is > this intended? Oh, yes. I made mistake on my RUN line. So these tests are not really checked. Thanks for your

[PATCH] D89184: Support complex target features combinations

LiuChen3 added a comment. > D89105 appears to use only `"avx512vl , > avx512vnni | avxvnni"`. > Does it mean `(avx512vl , avx512vnni) | avxvnni` or `avx512vl , (avx512vnni | > avxvnni)` ? Yes. "avx512vl , avx512vnni | avxvnni" means (avx512vl , avx512vnni) |

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

rnk created this revision. rnk added reviewers: mgrang, efriedma. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: clang. rnk requested review of this revision. The documentation rules indicate that instance methods should return large, trivially copyable aggregates

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298029. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp

  1   2   >