Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

They do on staging. http://lab.llvm.org:8014/#/builders/sanitizer-windows http://lab.llvm.org:8014/#/builders/clang-x64-windows-msvc Galina, when do you plan to push this to the primary server? If it's a few days, I'd rather keep bots on staging to have colors. On Tue, 13 Oct 2020 at 11:11,

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

srj added a comment. This is marked as "needs revision", but it's not clear to me what the requested changes actually are. The proposed fix here may not be perfect, but AFAICT, there is simply no good way to exclude headers that are beyond your control at present. Repository: rL LLVM

[clang] 69f7c00 - Revert "PR47805: Use a single object for a function parameter in the caller and"

Author: Richard Smith Date: 2020-10-13T19:32:03-07:00 New Revision: 69f7c006ff72167231b569a0fd2d7955ca597ffa URL: https://github.com/llvm/llvm-project/commit/69f7c006ff72167231b569a0fd2d7955ca597ffa DIFF: https://github.com/llvm/llvm-project/commit/69f7c006ff72167231b569a0fd2d7955ca597ffa.diff

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rjmccall added a comment. Okay. I can accept the fairly unfortunate thing with `const int` initializers. When is `IsConstantContext` set in C, just static initializers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89360/new/

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng added a comment. > If possible that would good, since -mcpu is deprecated (for e.g. x86_64) or > unsupported in GCC (for e.g. RISC-V). So doing that would further align Clang > with GCC. But I wonder if this might be too problematic, in terms of > compatibility. I am also working

[PATCH] D89361: [X86][NFC] Fix RUN line bug in the testcase

LiuChen3 added a comment. Thanks for all of your help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89361/new/ https://reviews.llvm.org/D89361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. In D89177#2325566 , @phosek wrote: > We've already considered introducing a similar mechanism so thank you for > working on this! There's one issue that I haven't figured out how to resolve > and I'd be interested in your

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Reading up on the Ninja multi-config generator a bit, you can define your own build types, so you should be able to create e.g. one build type for LTO and another for PIC. You'd still need some external logic to define that you use the LTO mode for executables and the

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Use it in BackgroundIndexTest.RelationsMultiFile Repository: rG LLVM

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge added a comment. This patch is a spinoff from my call hierarchy work (which I haven't posted for review yet, though I posted a draft at D89296 ). I'd like to be able to write tests where I can: - specify the contents of multiple header and source files,

[PATCH] D89238: [clangd] Go-to-definition from non-renaming alias is unambiguous.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89238/new/ https://reviews.llvm.org/D89238

[clang] 6c23cbc - [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

Author: Simon Pilgrim Date: 2020-10-13T09:28:39+01:00 New Revision: 6c23cbc5603cf0011f8d57b0354954aeca695daf URL: https://github.com/llvm/llvm-project/commit/6c23cbc5603cf0011f8d57b0354954aeca695daf DIFF: https://github.com/llvm/llvm-project/commit/6c23cbc5603cf0011f8d57b0354954aeca695daf.diff

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c23cbc5603c: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics… (authored by RKSimon). Repository: rG LLVM Github

[PATCH] D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89220/new/ https://reviews.llvm.org/D89220

[PATCH] D89300: [clang-rename] Fix rename on variable templates.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Oh, that's neat, thanks! Comment at: clang/include/clang/AST/DeclTemplate.h:3098 llvm::FoldingSetVector & - getPartialSpecializations(); +

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. - Add assertions for other preconditions. - If nothing is modified, don't mark it. Repository: rG LLVM Github Monorepo

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas updated this revision to Diff 297800. eduucaldas added a comment. minor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89303/new/ https://reviews.llvm.org/D89303 Files: clang/lib/Tooling/Syntax/Tree.cpp Index:

[PATCH] D89300: [clang-rename] Fix rename on variable templates.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added a project: clang. hokein requested review of this revision. This patch adds support for renaming variable templates. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89300 Files:

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet added a comment. In D89277#2326376 , @nridge wrote: > This is neat! Are there plans to add vscode client support to invoke this? Yes, since we control the plugin in vscode we should have a way to invoke it there. (we already have support for

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Mon, 12 Oct 2020 at 22:01, Galina Kistanova wrote: > Thanks, Vitaly! > > Let's have them there for at least 24 hours, shall we? > We can do that. > > Could you move sanitizer-buildbot1, sanitizer-buildbot3, > sanitizer-buildbot7 as well, please? > Done. > AnnotatedCommand on the staging

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek added a comment. In D89177#2326832 , @smeenai wrote: > In D89177#2325566 , @phosek wrote: > >> We've already considered introducing a similar mechanism so thank you for >> working on this! There's one issue

[PATCH] D89301: [X86] Add user-level interrupt instructions

tianqing created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya, mgorny. Herald added projects: clang, LLVM. tianqing requested review of this revision. For more details about these instructions, please refer to the latest ISE document:

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas updated this revision to Diff 297803. eduucaldas added a comment. minor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89303/new/ https://reviews.llvm.org/D89303 Files: clang/lib/Tooling/Syntax/Tree.cpp Index:

[PATCH] D89307: [clangd] Disable extract variable for RHS of assignments

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:400 + // This would just result in duplicating the code. + if (const auto *BO =

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

SouraVX added a comment. Thanks for the patch! Overall it's in pretty nice state and conformant to design highlighted. Could you please `clang-format` this patch, There are lot of `lint` warning that causes lot of noise while reviewing. Couple of NIT comments inline. I've tried marking all

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added a comment. Hi, Thank you for modifying the implementation to facilitate the extension to other targets. Please add `libmvec`-specific tests is `clang/Driver/fveclib.c`, and simplify the loop-vectorize tests. Other than that, I only have minor comments. Francesco

[clang] 9fa7f48 - [Fixed Point] Add fixed-point to floating point cast types and consteval.

Author: Bevin Hansson Date: 2020-10-13T13:26:56+02:00 New Revision: 9fa7f48459761fa13205f4c931484b0977c35746 URL: https://github.com/llvm/llvm-project/commit/9fa7f48459761fa13205f4c931484b0977c35746 DIFF: https://github.com/llvm/llvm-project/commit/9fa7f48459761fa13205f4c931484b0977c35746.diff

[clang] 101309f - [AST] Change return type of getTypeInfoInChars to a proper struct instead of std::pair.

Author: Bevin Hansson Date: 2020-10-13T13:26:56+02:00 New Revision: 101309fe048e66873cfd972c47c4b7e7f2b99f41 URL: https://github.com/llvm/llvm-project/commit/101309fe048e66873cfd972c47c4b7e7f2b99f41 DIFF: https://github.com/llvm/llvm-project/commit/101309fe048e66873cfd972c47c4b7e7f2b99f41.diff

[clang-tools-extra] 002968a - [clang-tidy] Add an example for misc-unused-alias-decls

Author: Sylvestre Ledru Date: 2020-10-13T13:56:04+02:00 New Revision: 002968a320463237f0ccea754a7482b229e34cf1 URL: https://github.com/llvm/llvm-project/commit/002968a320463237f0ccea754a7482b229e34cf1 DIFF:

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:103 #ifndef NDEBUG - for (auto *N = New; N; N = N->getNextSibling()) { + for (auto *N = New; N; N = N->NextSibling) { assert(N->Parent == nullptr);

[PATCH] D89307: [clangd] Disable extract variable for RHS of assignments

kadircet created this revision. kadircet added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D86447: [AST] Change return type of getTypeInfoInChars to a proper struct instead of std::pair.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG101309fe048e: [AST] Change return type of getTypeInfoInChars to a proper struct instead of… (authored by ebevhan). Repository: rG LLVM Github

[PATCH] D86631: [Fixed Point] Add fixed-point to floating point cast types and consteval.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fa7f4845976: [Fixed Point] Add fixed-point to floating point cast types and consteval. (authored by ebevhan). Repository: rG LLVM Github

[PATCH] D89270: [clang-tidy] Add an example for misc-unused-alias-decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG002968a32046: [clang-tidy] Add an example for misc-unused-alias-decls (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fhahn added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls-finite.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt -vector-library=LIBMVEC-X86 -inject-tli-mappings -loop-vectorize -S < %s |

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fhahn added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls.ll:1 +; RUN: opt -vector-library=LIBMVEC -inject-tli-mappings -force-vector-width=4 -force-vector-interleave=1 -loop-vectorize -S < %s | FileCheck %s + spatel

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fhahn added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls-finite.ll:82 + +!1 = distinct !{!1, !2, !3} +!2 = !{!"llvm.loop.vectorize.width", i32 4} fhahn wrote: > I don't think we need this. You can just pass

[PATCH] D89309: [ThinLTO] In documentation, mention possible values for concurrency flags

aganea updated this revision to Diff 297845. aganea added a comment. As suggested by @hans. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89309/new/ https://reviews.llvm.org/D89309 Files: clang/docs/ThinLTO.rst Index: clang/docs/ThinLTO.rst

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added a comment. Hi Fangrui(@MaskRay), are you okay with this patch to land as is? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

Xiangling_L updated this revision to Diff 297848. Xiangling_L added a comment. Use regex to match AIX layout dumping format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89064/new/ https://reviews.llvm.org/D89064 Files: clang/test/Layout/itanium-pack-and-align.cpp

[PATCH] D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with suggestion. Comment at: clang/test/Layout/itanium-pack-and-align.cpp:19 // CHECK-NEXT: 1 | int y -// CHECK-NEXT:

[PATCH] D89309: [ThinLTO] In documentation, mention possible values for concurrency flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1dbf05f5b44d: [ThinLTO][Documentation] Mention possible values for concurrency flags (authored by aganea). Repository: rG LLVM Github Monorepo

[clang] 1dbf05f - [ThinLTO][Documentation] Mention possible values for concurrency flags

Author: Alexandre Ganea Date: 2020-10-13T09:57:58-04:00 New Revision: 1dbf05f5b44db17dcd8520b032e83061189ff4f8 URL: https://github.com/llvm/llvm-project/commit/1dbf05f5b44db17dcd8520b032e83061189ff4f8 DIFF:

[libunwind] 6b7a49b - Fix all the CMake code that can only handle -stdlib= but not --stdlib=

Author: Raphael Isemann Date: 2020-10-13T16:05:21+02:00 New Revision: 6b7a49bb43d58c2c08fddb9f6c538ee52806de0a URL: https://github.com/llvm/llvm-project/commit/6b7a49bb43d58c2c08fddb9f6c538ee52806de0a DIFF:

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

martong created this revision. martong added reviewers: teemperor, shafik. Herald added subscribers: cfe-commits, pengfei, gamesh411, Szelethus, arphaman, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong requested review of this revision. During the

[PATCH] D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr

martong created this revision. martong added reviewers: teemperor, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong requested review of this revision. During the import of FormatAttrs

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. > Perhaps this'd be more robust with ScopeExit? Not really, `OnError` is not executed when/if the function succeeds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

yaxunl added a comment. CUDA/HIP are facing similar issues, i.e. consistency of name mangling of kernels between host/device compilation of the same TU. I hope this feature to be implemented in a generic way so that it may be reusable for other offloading languages. Repository: rG LLVM

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2327617 , @yaxunl wrote: > CUDA/HIP are facing similar issues, i.e. consistency of name mangling of > kernels between host/device compilation of the same TU. I hope this feature > to be implemented in a generic way

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske updated this revision to Diff 297828. balazske added a comment. Removed C++ support. Other small changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https://reviews.llvm.org/D87449 Files:

[PATCH] D89309: [ThinLTO] In documentation, mention possible value for concurrency flags

aganea created this revision. aganea added reviewers: thakis, hans. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. aganea requested review of this revision. As suggested here: https://reviews.llvm.org/D75153#2323939

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

hans added a comment. We're seeing the tests for this fail in Chromium's Clang builds: https://bugs.chromium.org/p/chromium/issues/detail?id=1137737 I'll try increasing the test's timeout for now and see if that helps. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89312: [SVE][CodeGen]Use TypeSize comparison operators in clang

CarolineConcatto created this revision. Herald added subscribers: cfe-commits, psnobl, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. CarolineConcatto requested review of this revision. The patch replaces comparison greater/lower or equal than by TypeSize::isKnownXY,

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2326551 , @rsmith wrote: > In D76620#2324858 , @erichkeane > wrote: > >> The feature that this supports is a part of the SYCL 2020 Provisional Spec, >> I thought that was

[PATCH] D89313: Fix implicit TypeSize casts in EmitCheckValue

CarolineConcatto created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CarolineConcatto requested review of this revision. Using getFixedSize() with: V->getType()->getPrimitiveSizeInBits() like this: V->getType()->getPrimitiveSizeInBits().getFixedSize()

[PATCH] D89284: [clangd] Propagate CollectMainFileRefs to BackgroundIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3c13fab6be: [clangd] Propagate CollectMainFileRefs to BackgroundIndex (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D89146: [SyntaxTree] Fix rtti for `Expression`.

eduucaldas updated this revision to Diff 297842. eduucaldas added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89146/new/ https://reviews.llvm.org/D89146 Files: clang/include/clang/Tooling/Syntax/Nodes.h Index:

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov updated this revision to Diff 297822. ASDenysPetrov added a comment. Updated. Removed a new test file, moved the test to an existing file instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89055/new/ https://reviews.llvm.org/D89055 Files:

[clang] bddef54 - Raise the timeout in DirectoryWatcherTest to 10 s

Author: Hans Wennborg Date: 2020-10-13T14:25:25+02:00 New Revision: bddef54c502811fa1406d1161d4baa15b56ebc32 URL: https://github.com/llvm/llvm-project/commit/bddef54c502811fa1406d1161d4baa15b56ebc32 DIFF: https://github.com/llvm/llvm-project/commit/bddef54c502811fa1406d1161d4baa15b56ebc32.diff

[PATCH] D89309: [ThinLTO] In documentation, mention possible values for concurrency flags

hans added a comment. Thanks for documenting these! I wonder if including the "CPU sockets" part is more confusing than helpful (especially if the reader doesn't know about CPU sockets). The sockets don't really matter here anyway. Sometimes the term "physical core" is used in relation to

[clang] c78da03 - [clang] Improve handling of physical registers in inline assembly operands.

Author: Jonas Paulsson Date: 2020-10-13T15:09:52+02:00 New Revision: c78da037783bda0f27f4d82060149166e6f0c796 URL: https://github.com/llvm/llvm-project/commit/c78da037783bda0f27f4d82060149166e6f0c796 DIFF:

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc78da037783b: [clang] Improve handling of physical registers in inline assembly operands. (authored by jonpa). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

spatel added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls-finite.ll:9 +define void @exp_f32(float* nocapture %varray) { +; CHECK-LABEL: @exp_f32( +; CHECK-NEXT: entry: fpetrogalli wrote: > I think you are over-testing

[PATCH] D89314: [SyntaxTree] Bug fix in `MutationsImpl::addAfter`.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. - Add assertions to other `MutationsImpl` member functions - `findPrevious` is a free function Repository: rG LLVM Github Monorepo

[clang] f84c77f - Revert "Raise the timeout in DirectoryWatcherTest to 10 s"

Author: Hans Wennborg Date: 2020-10-13T15:21:06+02:00 New Revision: f84c77f424e15316f7f46f484880162a7cbcd80b URL: https://github.com/llvm/llvm-project/commit/f84c77f424e15316f7f46f484880162a7cbcd80b DIFF: https://github.com/llvm/llvm-project/commit/f84c77f424e15316f7f46f484880162a7cbcd80b.diff

[clang-tools-extra] cb3c13f - [clangd] Propagate CollectMainFileRefs to BackgroundIndex

Author: Nathan Ridge Date: 2020-10-13T09:20:18-04:00 New Revision: cb3c13fab6beac4666865b68bea59aae593aaf83 URL: https://github.com/llvm/llvm-project/commit/cb3c13fab6beac4666865b68bea59aae593aaf83 DIFF: https://github.com/llvm/llvm-project/commit/cb3c13fab6beac4666865b68bea59aae593aaf83.diff

<    1   2