[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek updated this revision to Diff 303567. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/include/clang/Lex/PreprocessorOptions.h

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Update the ASTNodeTraverser to dump only nodes spelled in source. There are only a few which need to be

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

On Fri, 6 Nov 2020 at 13:30, Alex L wrote: > Hi Rchard, > > Some of our code started triggering the warning you added in this code, > but I'm not sure if the warning is actually valid or not in this case: > > https://godbolt.org/z/9fxs3K > > namespace geo { > template > class optional { >

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added a comment. In D87981#2379249 , @akashk4 wrote: > It would be great if TILE_RELEASE is supported in the backend, so the scope > of transaction is known and the configurations are at least stored to memory > properly. TILERELEASE don't

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

lxfind created this revision. Herald added subscribers: cfe-commits, modimo, wenlei, modocache. Herald added a project: clang. lxfind requested review of this revision. The original bug was discovered in T75057860. Clang front-end emits an AST that looks like this for an co_await expression: |

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCXX/this-nonnull.cpp:1-2 +// RUN: %clang_cc1 -S -emit-llvm -o - -triple %itanium_abi_triple %s | FileCheck %s -check-prefix=CHECK-YES +//

[clang] 0cab911 - [OpenMP5.0] map item can be non-contiguous for target update

Author: cchen Date: 2020-11-06T21:04:37-06:00 New Revision: 0cab91140f61a8271e8eef591f130145dd6e8084 URL: https://github.com/llvm/llvm-project/commit/0cab91140f61a8271e8eef591f130145dd6e8084 DIFF: https://github.com/llvm/llvm-project/commit/0cab91140f61a8271e8eef591f130145dd6e8084.diff LOG:

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cab91140f61: [OpenMP5.0] map item can be non-contiguous for target update (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES

[clang] d2da05d - [test] Fix Other/new-pass-manager.ll & clang/test/Misc/loop-opt-setup.c

Author: Fangrui Song Date: 2020-11-06T21:55:11-08:00 New Revision: d2da05de7c9ec11c3c9f26ea957cbf2225dbd0e5 URL: https://github.com/llvm/llvm-project/commit/d2da05de7c9ec11c3c9f26ea957cbf2225dbd0e5 DIFF: https://github.com/llvm/llvm-project/commit/d2da05de7c9ec11c3c9f26ea957cbf2225dbd0e5.diff

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:121 + set(export_to_clangtargets EXPORT Clang${distribution}Targets) + set_property(GLOBAL PROPERTY CLANG${distribution}_HAS_EXPORTS True) endif() phosek

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. In D90714#2379785 , @mibintc wrote: > you're right about the regex syntax. i think the 4088 is over the max > repetition count and there's also a problem with balanced. not sure what i > did wrong here. if you have a chance to

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 303596. njames93 marked an inline comment as done. njames93 added a comment. Removed Enable. Removed the scalarBool parser as it was only needed by Enable. Removed DynamicDictParser in favour of reworking DictParser to get better control of how to handle

[clang] 0b17c6e - [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

Author: Atmn Patel Date: 2020-11-06T22:06:58-05:00 New Revision: 0b17c6e4479d62bd4ff05c48d6cdf340b198832f URL: https://github.com/llvm/llvm-project/commit/0b17c6e4479d62bd4ff05c48d6cdf340b198832f DIFF: https://github.com/llvm/llvm-project/commit/0b17c6e4479d62bd4ff05c48d6cdf340b198832f.diff

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b17c6e4479d: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops (authored by atmnpatel). Repository: rG LLVM Github

[clang] 569abb5 - [LoopDeletion] Fixes failing test

Author: Atmn Patel Date: 2020-11-06T22:45:28-05:00 New Revision: 569abb530ece721675032d3127bd6d63f252b12b URL: https://github.com/llvm/llvm-project/commit/569abb530ece721675032d3127bd6d63f252b12b DIFF: https://github.com/llvm/llvm-project/commit/569abb530ece721675032d3127bd6d63f252b12b.diff

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/lib/AST/APValue.cpp:1052 + // FIXME: These should be modeled as having the + // LifetimeExtendedTemporaryDecl itself as the base. + auto *MTE = dyn_cast(E);

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572 if (PartialStruct.Base.isValid()) +CurInfo.NonContigInfo.Dims.push_back(0); emitCombinedEntry(CombinedInfo, CurInfo.Types, PartialStruct); MaskRay wrote:

[clang] d3e75d3 - Revert "[CodeGen] Fixes sanitizer test"

Author: Atmn Patel Date: 2020-11-07T00:32:12-05:00 New Revision: d3e75d31e3c831d00277518caee80b15b72666a8 URL: https://github.com/llvm/llvm-project/commit/d3e75d31e3c831d00277518caee80b15b72666a8 DIFF: https://github.com/llvm/llvm-project/commit/d3e75d31e3c831d00277518caee80b15b72666a8.diff

[PATCH] D90984: Update matchers to be traverse-aware

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Don't match Stmt or Decl nodes not spelled in the source when using TK_IgnoreUnlessSpelledInSource. This

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

dblaikie added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2339-2353 /// Determine whether the given types \p T1 and \p T2 are equivalent. - bool hasSameType(QualType T1, QualType T2) const { -return getCanonicalType(T1) == getCanonicalType(T2); +

[PATCH] D90992: [clang-tidy] Use vfs::FileSystem when getting config

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. The config providers that look for configuration files currently take a pointer

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 303597. atmnpatel added a comment. final fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c

[clang] f2e479d - [OpenMP] Fix -Wmisleading-indentation after D84192

Author: Fangrui Song Date: 2020-11-06T20:09:43-08:00 New Revision: f2e479db92452594dfe6aff45ab7841f0a8c69a5 URL: https://github.com/llvm/llvm-project/commit/f2e479db92452594dfe6aff45ab7841f0a8c69a5 DIFF: https://github.com/llvm/llvm-project/commit/f2e479db92452594dfe6aff45ab7841f0a8c69a5.diff

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5181 + mangleType(T); + Out << "0E"; + return; rsmith wrote: > rjmccall wrote: > > This could also be extracted and shared with the template-argument mangler. > > In fact,

[PATCH] D90815: -fbasic-block-sections=list=: Suppress output if failed to open the file

tmsriram accepted this revision. tmsriram added a comment. This revision is now accepted and ready to land. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90815/new/ https://reviews.llvm.org/D90815

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D88295#2365560 , @Quuxplusone wrote: >> So, how about we add another `CES` flag > > As the original author of `CES_AsIfByStdMove`, I am opposed to

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 updated this revision to Diff 303580. njames93 marked 3 inline comments as done. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90555/new/ https://reviews.llvm.org/D90555 Files:

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 marked 6 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:127 + unsigned EnumIntWidth = Ctx.getIntWidth(QualType(EnumT, 0)); + bool EnumIsSigned =

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:101 + unsigned SubIdx = (BitSize == 8) ? X86::sub_8bit : X86::sub_16bit; + unsigned Opc = (BitSize == 8) ? X86::MOV8mr : X86::MOV16mr; + MachineInstr *NewMI = akashk4 wrote: >

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rsmith updated this revision to Diff 303609. rsmith marked 10 inline comments as done. rsmith added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89998/new/ https://reviews.llvm.org/D89998 Files:

[clang] b1878b4 - [CodeGen] Fixes sanitizer test

Author: Atmn Patel Date: 2020-11-06T23:53:38-05:00 New Revision: b1878b4641e06baa754ce6e3e0387b1e7d7dc143 URL: https://github.com/llvm/llvm-project/commit/b1878b4641e06baa754ce6e3e0387b1e7d7dc143 DIFF: https://github.com/llvm/llvm-project/commit/b1878b4641e06baa754ce6e3e0387b1e7d7dc143.diff

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. @rnk @vsk does this look good to you as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90983: Change algorithms to return iterators

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Make it possible to inspect the matched node, possibly to ignore it. Repository: rG LLVM Github Monorepo

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 303598. njames93 added a comment. Fix the unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90531/new/ https://reviews.llvm.org/D90531 Files: clang-tools-extra/clangd/Config.h

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

MaskRay added a comment. > map item can be non-contiguous for target update The subject appears to describe a situation, but patch subjects should usually be imperative Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572 if (PartialStruct.Base.isValid()) +

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rsmith updated this revision to Diff 303611. rsmith marked an inline comment as done. rsmith added a comment. - Factor out duplicated mangling of null pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89998/new/

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

ortogonal created this revision. ortogonal added reviewers: klimek, Alexander-Shukaev, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. ortogonal requested review of this revision. When running git-clang-format in a pre-commit hook it's very useful to be able to

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/ItaniumMangle.cpp:5136 + case APValue::FixedPoint: +llvm_unreachable("Fixed point types are disabled for c++"); +return;

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added a comment. > I guess targets like SPIR will be supporting all features by default? It sounds confusing for me: can you please elaborate about why does SPIR-V target should support all features/extension by default? If we are compiling OpenCL C 3.0 with optional functionality we

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

sammccall accepted this revision. sammccall added a comment. Still LG Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:812 +EmptyDefaults.User = llvm::sys::Process::GetEnv("USER"); +if (!EmptyDefaults.User) + EmptyDefaults.User =

[clang] 2dbcbd3 - [clang-format] do not break before { in JS comments

Author: Krasimir Georgiev Date: 2020-11-06T10:34:10+01:00 New Revision: 2dbcbd357d1da1adf9c512d150e68424faa46d75 URL: https://github.com/llvm/llvm-project/commit/2dbcbd357d1da1adf9c512d150e68424faa46d75 DIFF:

[PATCH] D90908: [clang-format] do not break before { in JS comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbcbd357d1d: [clang-format] do not break before { in JS comments (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90531: [clangd] Add clang-tidy options to config

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Just some simplifications and doc nits left, then please go ahead and land Comment at: clang-tools-extra/clangd/Config.h:74 + + // Configures what clang-tidy

[PATCH] D90908: [clang-format] do not break before { in JS comments

krasimir updated this revision to Diff 303354. krasimir added a comment. update test case range Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90908/new/ https://reviews.llvm.org/D90908 Files: clang/unittests/Format/FormatTestJS.cpp Index:

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

foad added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1580 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrCold, IntrNoMem, IntrHasSideEffects] The intrinsic def needs a

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 303345. LuoYuanke added a comment. Fix lit test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e312e004197: [X86] use macros to split GFNI intrinsics into different kinds (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES

[clang] 5e312e0 - [X86] use macros to split GFNI intrinsics into different kinds

Author: Freddy Ye Date: 2020-11-06T16:03:38+08:00 New Revision: 5e312e0041972668f1bd67ff9ed0f16a594795a3 URL: https://github.com/llvm/llvm-project/commit/5e312e0041972668f1bd67ff9ed0f16a594795a3 DIFF: https://github.com/llvm/llvm-project/commit/5e312e0041972668f1bd67ff9ed0f16a594795a3.diff

[PATCH] D90908: [clang-format] do not break before { in JS comments

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir requested review of this revision. In JavaScript some @tags can be followed by `{`, and machinery that parses these comments will fail to understand the comment if followed by a line

[PATCH] D90908: [clang-format] do not break before { in JS comments

krasimir updated this revision to Diff 303355. krasimir added a comment. collect commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90908/new/ https://reviews.llvm.org/D90908 Files: clang/lib/Format/BreakableToken.cpp

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 303356. balazske added a comment. Small fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. This test was added in 7f38812d5b7e0fd5145e44d5ae831a67d782dca6

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 303397. kbobyrev added a comment. Continue implementation, integrate more tests from clang-rename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files:

[PATCH] D90928: [OpenCL] Add assertions to extension lookup

erik2020 created this revision. erik2020 added a reviewer: ldrumm. erik2020 added a project: clang. Herald added subscribers: cfe-commits, dexonsmith, Anastasia, yaxunl. erik2020 requested review of this revision. Calling any of the `OpenCLOptions::is*()` functions (except `isKnown()`) with an

[PATCH] D90891: [clang] ns_error_domain attribute also supports CFString typed variables

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90891/new/ https://reviews.llvm.org/D90891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

DavidSpickett added a reviewer: kpn. DavidSpickett added a comment. In case this looks like a spammy change, this is for http://llvm.1065342.n5.nabble.com/llvm-dev-RFC-FileCheck-dis-allowing-unused-prefixes-td142255.html AFAICT there is no common IR to check for in this test, unlike the others.

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/UncheckedReturnValueChecker.cpp:41 +BugReporter ) const { +auto FoundCall = callExpr().bind("call"); +auto CallInCompound = compoundStmt(forEach(FoundCall));

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen added a comment. Hi @david-arm I just found that two uses of `llvm.loop.vectorize.width` are not yet updated. - WarnMissedTransforms.cpp in `warnAboutLeftoverTransformations`. - LoopUtils.cpp in `llvm::hasVectorizeTransformation`. The cases seem quite trivial to fix up, can you

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. In D90448#2376710 , @dblaikie wrote: > How's this compare to the similar checks for variable templates? Is there > some code/checking we could share here? The code of checks for variable templates is just before the additional

[PATCH] D90763: Traverse-ignore explicit template instantiations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a tiny commenting request. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:506 +if (const auto *CTSD = Node.get()) { + auto SK =

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} steveire wrote: > aaron.ballman

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Just style nits. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:266 + switch (DC->getDeclKind()) { + // The enclosing DeclContext may not be the

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

sammccall added a comment. Thanks! This makes sense to me, I assumed at first that the expr could be something complicated that we'd have to const-evaluate, thought clearly this already happens (and we do assume it's a ConstantExpr). Comment at:

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

kpn accepted this revision. kpn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90921/new/ https://reviews.llvm.org/D90921 ___

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske updated this revision to Diff 303444. balazske added a comment. Small fixes in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90691/new/ https://reviews.llvm.org/D90691 Files: clang/docs/analyzer/checkers.rst

[PATCH] D90949: [clang-format] avoid introducing multiline comments

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir requested review of this revision. In C++ with -Werror=comment, multiline comments are not allowed. clang-format could accidentally introduce multiline comments when reflowing. This

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 303495. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet updated this revision to Diff 303442. kadircet added a comment. The index has the following query semantics: - Lookup: it only queries the associated index. This is to not regress latency for operations like Hover and Go-To. - FuzzyFind only queries the associated index when

[clang] 7efe07a - Traverse-ignore explicit template instantiations

Author: Stephen Kelly Date: 2020-11-06T15:25:59Z New Revision: 7efe07a12b6967bc358678adf75dffd238a00250 URL: https://github.com/llvm/llvm-project/commit/7efe07a12b6967bc358678adf75dffd238a00250 DIFF: https://github.com/llvm/llvm-project/commit/7efe07a12b6967bc358678adf75dffd238a00250.diff

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. In D68997#2377641 , @stella.stamenova wrote: > This change broke the windows lldb bot: > > http://lab.llvm.org:8011/#/builders/83/builds/570 > > Can you please fix this or revert? Looking at this now. Repository: rG LLVM

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

steakhal added a comment. In D52957#2377914 , @NoQ wrote: > Everything looks good to me here. The new-expression `new int;` has 1 > implicit argument (allocation size passed to the implementation of operator > new, the value is probably 4) and 0

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

ille added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90434/new/ https://reviews.llvm.org/D90434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:110 +OPENCLFEAT_INTERNAL(__opencl_c_generic_address_space, 200, ~0U) +OPENCLFEAT_INTERNAL(__opencl_c_work_group_collective_functions, 200, ~0U)

[PATCH] D90747: [clangd] Mark AsyncTaskRunner::runAsync as const

sammccall added a comment. AsyncTaskRunner is definitely threadsafe, but const doesn't exactly mean threadsafe... This might be OK or maybe we should put `mutable` at the callsite - can you show the real example? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaecd52b97bb4: [Clang][AArch64] Remove unused prefix in constrained rounding test (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[clang] aecd52b - [Clang][AArch64] Remove unused prefix in constrained rounding test

Author: David Spickett Date: 2020-11-06T14:13:46Z New Revision: aecd52b97bb457aaecb0bcb658e6ea684e869de9 URL: https://github.com/llvm/llvm-project/commit/aecd52b97bb457aaecb0bcb658e6ea684e869de9 DIFF: https://github.com/llvm/llvm-project/commit/aecd52b97bb457aaecb0bcb658e6ea684e869de9.diff

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88913/new/ https://reviews.llvm.org/D88913 ___ cfe-commits mailing list

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon created this revision. segoon added a reviewer: alexfh. Herald added subscribers: cfe-commits, lxfind, modocache, xazax.hun, mgorny. Herald added a project: clang. segoon requested review of this revision. Checks for some thread-unsafe functions against a black list of known-to-be-unsafe

[PATCH] D90767: Add new matchers for dependent names in templates

steveire updated this revision to Diff 303462. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90767/new/ https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

lebedev.ri added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-mt-unsafe.cpp:3-4 + +#include +#include + Tests should be hermetic, they can not use headers from system Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=`.

fpetrogalli created this revision. fpetrogalli added reviewers: peterwaller-arm, paulwalker-arm, efriedma, c-rhodes. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli requested review of this

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

thakis added a comment. (If `-mmacosx-version-min` is passed too, open-source clang does the right thing, but for quick command-line testing it'd be nice if both clangs behaved consistently.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90957: Frontend: Skip namespace around createVFSFromCompilerInvocation definition, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, jansvoboda11, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Qualify definitions with `clang::` rather than opening/closing a namespace. https://reviews.llvm.org/D90957

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas updated this revision to Diff 303486. pratlucas added a comment. Updating default extensions in target parser to match tablegen features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90765/new/ https://reviews.llvm.org/D90765 Files:

[PATCH] D90763: Traverse-ignore explicit template instantiations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7efe07a12b69: Traverse-ignore explicit template instantiations (authored by stephenkelly). Changed prior to commit:

[PATCH] D90748: [clangd] Introduce config parsing for External blocks

sammccall added a comment. LG (comment nits) thanks! (Meta-point: not sure how useful splitting this patch out from the compile step is...) Comment at: clang-tools-extra/clangd/ConfigFragment.h:165 llvm::Optional> Background; +/// Configuration information for an

[clang] aa0dc1c - [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup

Author: Balazs Benics Date: 2020-11-06T16:51:34+01:00 New Revision: aa0dc1c3b8628bed8c8b91a75258d13eefa88dfe URL: https://github.com/llvm/llvm-project/commit/aa0dc1c3b8628bed8c8b91a75258d13eefa88dfe DIFF: https://github.com/llvm/llvm-project/commit/aa0dc1c3b8628bed8c8b91a75258d13eefa88dfe.diff

[PATCH] D90754: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa0dc1c3b862: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup (authored by steakhal). Repository: rG LLVM Github Monorepo

[PATCH] D90886: [AMDGPU] Simplify amdgpu-macros.cl test. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fcdfc4398bd: [AMDGPU] Simplify amdgpu-macros.cl test. NFC. (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:254 +// native path. +if (!External.File && !External.Server) { + diag(Error, "At least one of File or Server must be specified.", My math friends would call

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. In D89869#2378235 , @azabaznov wrote: >> I guess targets like SPIR will be supporting all features by default? > > It sounds confusing for me: can you please elaborate about why does SPIR-V > target should support all

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM Comment at: llvm/unittests/Support/TargetParserTest.cpp:10-11 #include "llvm/Support/TargetParser.h" #include "llvm/ADT/STLExtras.h" +#include

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:276 // extern "C" int atexit(void (*f)(void)); - assert(cast(dtorStub)->getFunctionType() == - llvm::FunctionType::get(CGM.VoidTy, false) && + llvm::PointerType *Expected = +

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/UncheckedReturnValueChecker.cpp:41 +BugReporter ) const { +auto FoundCall = callExpr().bind("call"); +auto CallInCompound =

[PATCH] D87981: [X86] AMX programming model prototype.

akashk4 requested changes to this revision. akashk4 added a comment. This revision now requires changes to proceed. It would be great if TILE_RELEASE is supported in the backend, so the scope of transaction is known and the configurations are at least stored to memory properly.

[PATCH] D90775: [clangd] ExternalIndex turns off BackgroundIndex only if it isn't set

sammccall added a comment. I'm not sure we should do this - it complicates the model substantially (I don't think I could explain it to a user), and it still leaves surprising cases. I'm not sure config is the place for a lot of magic do-what-I-mean behavior - it's the place where the user

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

vhscampos added a comment. @Tyker This is causing another build failure in another example: [2858/4034] Building CXX object tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o FAILED: tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o

[PATCH] D90767: Add new matchers for dependent names in templates

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} aaron.ballman wrote: > steveire wrote: >

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc updated this revision to Diff 303477. mibintc added a comment. Fixed test case according to @dblaikie 's suggestion and input, thanks a lot David, the test case is certainly a lot easier to read and understand now. Anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   >