[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

curdeius added a comment. It would be maybe possible to: - address @klimek 's comment and do any other necessary cleanup - create a bug ticket for what @JohelEGP found with ctors - mark clang-format's support of concept as experimental? This patch is getting big IMO and I really think that

[PATCH] D92484: [clangd] Relation slabs should not be accounted when computing backing storage size

ilya-golovenko added a comment. In D92484#2430851 , @sammccall wrote: > Can you give a little context? Why not? It seems `Relations` should be not taken into account because they don't reference a backing storage. Only `SymStorage` and `RefsStorage` are

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. I'm about to push this revision. I will be surprised if it does not break the build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://reviews.llvm.org/D92269 ___ cfe-commits mailing

[clang-tools-extra] a59e504 - [clangd] Fix a nullptr-access crash in canonicalRenameDecl.

Author: Haojian Wu Date: 2020-12-03T12:59:00+01:00 New Revision: a59e504a61a580e7b7d9af0b0380b573cee21a1c URL: https://github.com/llvm/llvm-project/commit/a59e504a61a580e7b7d9af0b0380b573cee21a1c DIFF: https://github.com/llvm/llvm-project/commit/a59e504a61a580e7b7d9af0b0380b573cee21a1c.diff

[PATCH] D92386: [VE] Add standard include path and library path for C++

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92386/new/ https://reviews.llvm.org/D92386 ___

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92484: [clangd] Relation slabs should not be accounted when computing backing storage size

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, you're right. There's no "payload" memory here, and MemIndex::estimateMemoryUsage should already be accounting for all the memory used. (Sorry, it's been a while since I looked

[PATCH] D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

mstorsjo created this revision. mstorsjo added reviewers: amccarth, rnk, chapuni. Herald added a project: clang. mstorsjo requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92570 Files: clang/lib/Headers/mm_malloc.h Index:

[PATCH] D92386: [VE] Add standard include path and library path for C++

kaz7 updated this revision to Diff 309231. kaz7 added a comment. Add environment variable test as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92386/new/ https://reviews.llvm.org/D92386 Files:

[PATCH] D91904: [mac/arm] Fix rtti codegen tests when running on an arm mac

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cbf61be8be5: [mac/arm] Fix rtti codegen tests when running on an arm mac (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0cbf61b - [mac/arm] Fix rtti codegen tests when running on an arm mac

Author: Nico Weber Date: 2020-12-03T09:11:03-05:00 New Revision: 0cbf61be8be546257854d1a2e5d6c675f5838a63 URL: https://github.com/llvm/llvm-project/commit/0cbf61be8be546257854d1a2e5d6c675f5838a63 DIFF: https://github.com/llvm/llvm-project/commit/0cbf61be8be546257854d1a2e5d6c675f5838a63.diff

[clang] 152df3a - arm64: count Triple::aarch64_32 as an aarch64 target and enable leaf frame pointers

Author: Tim Northover Date: 2020-12-03T11:09:44Z New Revision: 152df3add156b68aca7bfb06b62ea85fa127f3b1 URL: https://github.com/llvm/llvm-project/commit/152df3add156b68aca7bfb06b62ea85fa127f3b1 DIFF: https://github.com/llvm/llvm-project/commit/152df3add156b68aca7bfb06b62ea85fa127f3b1.diff

[PATCH] D91147: AArch64: classify Triple::aarch64_32 as AArch64

t.p.northover closed this revision. t.p.northover added a comment. Thanks Gerolf. Committed: To github.com:llvm/llvm-project.git ae9d96a656a1..152df3add156 master -> master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91147/new/ https://reviews.llvm.org/D91147

[PATCH] D92573: [clang] Add a C++17 deduction guide testcase.

hokein created this revision. hokein added a reviewer: adamcz. Herald added a project: clang. hokein requested review of this revision. >From https://bugs.llvm.org/show_bug.cgi?id=47219. It was crashing before the commit 1e14588d0f68

[clang] 68f2ff5 - clang/darwin: Don't use response files with ld64

Author: Nico Weber Date: 2020-12-03T09:00:10-05:00 New Revision: 68f2ff59d114a5511e197472d2d4f23fea7ff0f5 URL: https://github.com/llvm/llvm-project/commit/68f2ff59d114a5511e197472d2d4f23fea7ff0f5 DIFF: https://github.com/llvm/llvm-project/commit/68f2ff59d114a5511e197472d2d4f23fea7ff0f5.diff

[PATCH] D92357: clang/darwin: Don't use response files with ld64

This revision was automatically updated to reflect the committed changes. Closed by commit rG68f2ff59d114: clang/darwin: Dont use response files with ld64 (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91904: [mac/arm] Fix rtti codegen tests when running on an arm mac

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91904/new/ https://reviews.llvm.org/D91904 ___ cfe-commits mailing list

[clang] 415fab6 - [TableGen] Eliminate the 'code' type

Author: Paul C. Anagnostopoulos Date: 2020-12-03T10:19:11-05:00 New Revision: 415fab6f67b4db59abe533130272d55b4efbf0cb URL: https://github.com/llvm/llvm-project/commit/415fab6f67b4db59abe533130272d55b4efbf0cb DIFF:

[PATCH] D92573: [clang] Add a C++17 deduction guide testcase.

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Thanks, adding this test is a very good idea. Comment at: clang/test/PCH/cxx17-deduction-guide-decl.cpp:16 + +// Class template argument deduction +template

[clang] 7d30df7 - [VE] Add standard include path and library path for C++

Author: Kazushi (Jam) Marukawa Date: 2020-12-03T22:22:56+09:00 New Revision: 7d30df7b59973a42a93c86cb501bd3d0fbb07404 URL: https://github.com/llvm/llvm-project/commit/7d30df7b59973a42a93c86cb501bd3d0fbb07404 DIFF:

[PATCH] D92386: [VE] Add standard include path and library path for C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d30df7b5997: [VE] Add standard include path and library path for C++ (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92484: [clangd] Relation slabs should not be accounted when computing backing storage size

ilya-golovenko added a comment. In D92484#2430985 , @sammccall wrote: > Thanks, you're right. There's no "payload" memory here, and > MemIndex::estimateMemoryUsage should already be accounting for all the memory > used. > > (Sorry, it's been a while

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

jamieschmeiser accepted this revision. jamieschmeiser added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216

[PATCH] D92484: [clangd] Relation slabs should not be accounted when computing backing storage size

sammccall added a comment. Can you give a little context? Why not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92484/new/ https://reviews.llvm.org/D92484 ___ cfe-commits mailing list

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 309252. aorlov added a comment. Fixed typos. Made minor changes in test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files:

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong marked an inline comment as done. martong added a comment. > I was thinking about to create a separate ASTImporter implementation > specifically for CTU and LLDB could have it's own implementation. For that we > just need to create an interface class with virtual functions. One

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added a comment. In D87216#2431508 , @ychen wrote: > It is very unfortunate that we have to manage and translate between two sets > of names (one pass name and one type name). This makes me wonder if we just > keep the pass name as the return

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap added a comment. addressed a comment Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9366 +SplatNode = DAG.getNode( +PPCISD::XXSPLTI32DX, SDLoc(SplatNode), MVT::v2i64, SplatNode, +DAG.getTargetConstant(isLE ? 1 : 0, SplatNode,

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

kpn created this revision. kpn added reviewers: sepavloff, mibintc. kpn added a project: clang. kpn requested review of this revision. Herald added a subscriber: cfe-commits. This test shows we're in some cases not getting strictfp information from the AST. Correct that. Repository: rG LLVM

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko updated this revision to Diff 309336. anastasiia_lukianenko retitled this revision from "[clang-format] Add BreakBeforeStructInitialization configuration" to "[clang-format] Add BeforeStructInitialization option in BraceWrapping configuration". anastasiia_lukianenko added

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

curdeius accepted this revision. curdeius added a comment. LGTM Comment at: clang/lib/Format/Format.cpp:963 LLVMStyle.SpacesInCStyleCastParentheses = false; + LLVMStyle.SpacesInLineComments = {/*Minimum=*/1, /*Maximum=*/-1u}; LLVMStyle.SpaceAfterCStyleCast = false;

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 309340. jdoerfert marked 4 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files:

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:999-1002 + // OpenMP lambdas might get assumumption attributes. + if (LangOpts.OpenMP) +ActOnFinishedFunctionDefinitionInOpenMPAssumeScope(Method); + ABataev wrote: > Are there any

[PATCH] D92579: [clangd] AddUsing: Fix a crash on ElaboratedTypes without NestedNameSpecfiiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc282b7de5a5d: [clangd] AddUsing: Fix a crash on ElaboratedTypes without NestedNameSpecfiiers. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c282b7d - [clangd] AddUsing: Fix a crash on ElaboratedTypes without NestedNameSpecfiiers.

Author: Adam Czachorowski Date: 2020-12-03T20:25:38+01:00 New Revision: c282b7de5a5de8151a19228702867e2299f1d3fe URL: https://github.com/llvm/llvm-project/commit/c282b7de5a5de8151a19228702867e2299f1d3fe DIFF:

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, I'm not sure if others have any comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 309335. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. rebase before making any further changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files:

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2314 + nextToken(); + if (FormatTok->Tok.is(tok::less)) { +while (!FormatTok->Tok.is(tok::greater)) {

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

dblaikie added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:190-196 +// Use a custom deleter for the TrueMatcherInstance ManagedStatic. This prevents +// an assert firing when the refcount is nonzero while running its destructor. +struct

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

shafik added a comment. `ASTImporter` changes looks good to me. Comment at: clang/lib/AST/ASTImporter.cpp:6525 + + const ASTContext = Importer.getToContext(); + if (E->isResultDependent()) { nitpick `context` -> `ToCtx` to be consistent with other code.

[clang-tools-extra] 2d539d7 - [clangd] Relation slabs should not be accounted when computing backing storage size

Author: Ilya Golovenko Date: 2020-12-03T16:56:53+03:00 New Revision: 2d539d78549fbe26144d5ff491de338413bd99d3 URL: https://github.com/llvm/llvm-project/commit/2d539d78549fbe26144d5ff491de338413bd99d3 DIFF:

[PATCH] D92484: [clangd] Relation slabs should not be accounted when computing backing storage size

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d539d78549f: [clangd] Relation slabs should not be accounted when computing backing storage… (authored by walrus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92363: [HIP] Warn no --offload-arch option

yaxunl added a comment. In D92363#2426401 , @tra wrote: > While I agree that the default GPU choice is not likely to be correct, or > usable, for everyone, but the warning seems to be a half-measure. > If the default is not usable, then it should not be

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder created this revision. tmroeder added reviewers: aaron.ballman, klimek. Herald added subscribers: teemperor, martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. tmroeder requested review of this revision. Herald added a project: clang. This allows ASTs to be

[PATCH] D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces

arphaman created this revision. arphaman added reviewers: erik.pilkington, MadCoder. Herald added subscribers: ributzka, jfb, jkorous. arphaman requested review of this revision. Herald added a project: clang. Categories that add protocol conformances to classes with direct members should

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay added a comment. Having reviewed the current status I'm going to leave this patch with just minor changes from where its been for some time, if others feel it has merits in landing as experimental support I'd be happy with that. I would rather build from a base than try and keep

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3203-3206 + if (!SkippedClauses && Assumptions.empty()) +Diag(Loc, diag::err_omp_no_clause_for_directive) +<< llvm::omp::getAllAssumeClauseOptions() +<<

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 309357. bader added a comment. Apply code review comment from @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang/AST/Type.h

[PATCH] D92606: Clean up debug locations for logical-and/or expressions

probinson created this revision. probinson added reviewers: dblaikie, rnk. probinson added a project: debug-info. probinson requested review of this revision. Herald added a project: clang. Attaches a more appropriate debug location to the PHIs used for the short-circuit evaluations, and makes

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. @orivej please can you look where we create AST nodes for these builtins and ensure that the "pointer" argument is actually converted into a pointer beforehand? I'm afraid i

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

Anastasia added a comment. In D92231#2425323 , @Anastasia wrote: > In D92231#2425305 , @PiotrFusik > wrote: > >> The specification for these extensions was edited by Ben Ashbaugh @Intel. >> I've asked him about

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 309338. aeubanks added a comment. forward declare class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files: llvm/include/llvm/IR/IRPrintingPasses.h

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 309350. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Address the issue with still munching the semi mark as experimental in the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4596 + IRFuncTy->getParamType(FirstIRArg)); +} + bader wrote: > rjmccall wrote: > > This seems problematic; code like this shouldn't be

[PATCH] D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

mstorsjo added inline comments. Comment at: clang/lib/Headers/mm_malloc.h:42 void *__mallocedMemory; #if defined(__MINGW32__) __mallocedMemory = __mingw_aligned_malloc(__size, __align); rnk wrote: > This has been here since 2011, and somehow nobody

[PATCH] D92597: ARCMigrate: Initialize fields in EditEntry inline, NFC

dexonsmith created this revision. dexonsmith added reviewers: jansvoboda11, JDevlieghere, akyrtzi. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Initialize the fields inline instead of having to manually write out a default

[PATCH] D92363: [HIP] Warn no --offload-arch option

tra added a comment. In D92363#2431812 , @yaxunl wrote: > > There are still valid use cases for not providing GPU arch. For example, > users would like to test syntax of a HIP program for which GPU arch does not > matter, or users would like to get

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

flx updated this revision to Diff 309361. flx added a comment. Fixed clang tidy warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91893/new/ https://reviews.llvm.org/D91893 Files:

[PATCH] D92606: Clean up debug locations for logical-and/or expressions

rnk added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4293 + { +// There is no need to emit line number for unconditional branch. +auto NL = ApplyDebugLocation::CreateEmpty(CGF); I see this is consistent with LAnd handling above, but

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

dexonsmith added inline comments. Comment at: llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:75-76 RefCountedBase() = default; + // Copy and move constructors/assignments are no-ops as the RefCount isn't + // dictated by the class directly. RefCountedBase(const

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

ychen added a comment. In D87216#2431626 , @aeubanks wrote: > In D87216#2431508 , @ychen wrote: > >> It is very unfortunate that we have to manage and translate between two sets >> of names (one pass name and one

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:963 LLVMStyle.SpacesInCStyleCastParentheses = false; + LLVMStyle.SpacesInLineComments = {/*Minimum=*/1, /*Maximum=*/-1u}; LLVMStyle.SpaceAfterCStyleCast = false; I don't know

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:963 LLVMStyle.SpacesInCStyleCastParentheses = false; + LLVMStyle.SpacesInLineComments = {/*Minimum=*/1, /*Maximum=*/-1u}; LLVMStyle.SpaceAfterCStyleCast = false; curdeius

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 309344. tmroeder edited the summary of this revision. tmroeder added a comment. Fix a typo in the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files:

[PATCH] D92597: ARCMigrate: Initialize fields in EditEntry inline, NFC

JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92597/new/ https://reviews.llvm.org/D92597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added a comment. As someone who has extensivly worked with conscepts I cannot stress how much this would improve my live CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___ cfe-commits mailing

[PATCH] D72184: [BPF] support atomic instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG286daafd6512: [BPF] support atomic instructions (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne added a comment. In D91311#2423809 , @rsmith wrote: > In D91311#2418881 , @ldionne wrote: > >> In D91311#2417293 , @rsmith wrote: >> >>> In D91311#2416940

[PATCH] D92579: [clangd] AddUsing: Fix a crash on ElaboratedTypes without NestedNameSpecfiiers.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92579

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3516 +``_Nullable_result`` pointer can be ``nil``, just like ``_Nullable``. Where this +attribute differs from ``_Nullable`` is when its used on a parameter to a +completion handler in a

[PATCH] D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Headers/mm_malloc.h:42 void *__mallocedMemory; #if defined(__MINGW32__) __mallocedMemory = __mingw_aligned_malloc(__size, __align);

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3490 +OMPC_MAP_MODIFIER_present); +ImplicitMapModifierLoc[ClauseKind].push_back(SourceLocation()); + } cchen wrote: > ABataev wrote: > > Why need to add

[PATCH] D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file.

This revision was automatically updated to reflect the committed changes. Closed by commit rG517828a31b0d: [clangd] Bundle code completion items when the include paths differ, but… (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f77c948 - [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

Author: Ahmed Bougacha Date: 2020-12-03T07:53:59-08:00 New Revision: f77c948d56b09b839262e258af5c6ad701e5b168 URL: https://github.com/llvm/llvm-project/commit/f77c948d56b09b839262e258af5c6ad701e5b168 DIFF:

[PATCH] D87095: [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf77c948d56b0: [Triple][MachO] Define arm64e, an AArch64 subarch for Pointer Auth. (authored by ab). Changed prior to

[PATCH] D87095: [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

ab added a comment. Thanks Tim! f77c948d56b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87095/new/ https://reviews.llvm.org/D87095

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

aaron.ballman accepted this revision. aaron.ballman added a comment. In D92439#2431256 , @jdoerfert wrote: > In D92439#2429815 , @jyu2 wrote: > >> In D92439#2429511 ,

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 309268. alokmishra.besu added a comment. Updated version of metadirective supporting OpenMP 5.0 features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files:

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:183 + + /// Adds a diagnostic to report errors in the checks configuration. + DiagnosticBuilder checks -> check's Comment at:

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:373 +/// +class OMPMetaDirective final : public OMPExecutableDirective { + friend class ASTStmtReader; alokmishra.besu wrote: > ABataev wrote: > > I think, metadirective should be a

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall. aaron.ballman requested review of this revision. We currently reject this valid C construct by claiming it declares a non-local variable: `for (struct { int i; } s={0}; s.i != 0; s.i--) ;` The problem is that

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9357 + + if (Lo) { +SplatNode = Braces can be omitted here and on 9364 if it's just a single statement. Comment at:

[clang] aa11556 - [ASTMatchers][NFC] Made variadic operator funcs static

Author: Nathan James Date: 2020-12-03T15:47:54Z New Revision: aa1155634fe41a53988a277ca7668a8d69f59f94 URL: https://github.com/llvm/llvm-project/commit/aa1155634fe41a53988a277ca7668a8d69f59f94 DIFF: https://github.com/llvm/llvm-project/commit/aa1155634fe41a53988a277ca7668a8d69f59f94.diff LOG:

[clang] c00516d - Try to fix tests on Windows after 0cbf61be8be

Author: Nico Weber Date: 2020-12-03T10:55:05-05:00 New Revision: c00516d52054e31179ce921a35a3815032feed0f URL: https://github.com/llvm/llvm-project/commit/c00516d52054e31179ce921a35a3815032feed0f DIFF: https://github.com/llvm/llvm-project/commit/c00516d52054e31179ce921a35a3815032feed0f.diff

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:1952 - STMT_MS_DEPENDENT_EXISTS, // MSDependentExistsStmt - EXPR_LAMBDA,// LambdaExpr STMT_COROUTINE_BODY, alokmishra.besu wrote: >

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

vsavchenko accepted this revision. vsavchenko added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92432/new/ https://reviews.llvm.org/D92432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jdoerfert added a comment. In D92439#2431270 , @aaron.ballman wrote: > In D92439#2431256 , @jdoerfert wrote: > >> In D92439#2429815 , @jyu2 wrote: >> >>> In D92439#2429511

[clang-tools-extra] 517828a - [clangd] Bundle code completion items when the include paths differ, but resolve to the same file.

Author: Adam Czachorowski Date: 2020-12-03T16:33:15+01:00 New Revision: 517828a31b0d1b7cfd1fd261046746bd8778420a URL: https://github.com/llvm/llvm-project/commit/517828a31b0d1b7cfd1fd261046746bd8778420a DIFF:

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 309270. trixirt added a comment. move enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files: clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2522 + // Add to the lookupTable because we could not do that in MapImported. + Importer.AddToLookupTable(ToTypedef); + shafik wrote: > I am not

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

ychen accepted this revision. ychen added a comment. It is very unfortunate that we have to manage and translate between two sets of names (one pass name and one type name). This makes me wonder if we just keep the pass name as the return value of PassInfoMixin::name and get rid of class name

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:373 +/// +class OMPMetaDirective final : public OMPExecutableDirective { + friend class ASTStmtReader; I think, metadirective should be a kind of a container for different

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt added a comment. How this is run in the kernel is a wip so adding it to the commit log is not very helpful. Here is the lkml rfc https://lkml.org/lkml/2020/11/21/190 This calling in the kernel needs needs to change because of the refactor. The auto suggestions fail to build, so they are

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jdoerfert added a comment. In D92439#2429815 , @jyu2 wrote: > In D92439#2429511 , @jdoerfert wrote: > >> Still unsure if we should also error out for NVPTX but that is a different >> story. Looks OK from my side,

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

Quuxplusone added a comment. The subject line says "access checking on specializations and instantiations," but I don't see any tests for explicit instantiations here — just specializations. In particular, I'm very interested to know if P0692 is intended to have any effect on the legality of

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen updated this revision to Diff 309292. cchen added a comment. Update based on comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 Files: clang/include/clang/Basic/OpenMPKinds.def

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:373 +/// +class OMPMetaDirective final : public OMPExecutableDirective { + friend class ASTStmtReader; ABataev wrote: > I think, metadirective should be a kind of a

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 309382. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:495 + // compilation uses DWARF5. + virtual unsigned GetAdjustedDwarfVersion(unsigned v) const { return v; } + Given these semantics (pass/return the version) maybe

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

MaskRay updated this revision to Diff 309434. MaskRay marked an inline comment as done. MaskRay added a comment. Improve odr-vtable.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92078/new/ https://reviews.llvm.org/D92078 Files:

  1   2   >