[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

njames93 updated this revision to Diff 309524. njames93 added a comment. Remove unnecessary comment added in ASTMatchersInternal.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92480/new/ https://reviews.llvm.org/D92480 Files:

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

njames93 updated this revision to Diff 309521. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91885/new/ https://reviews.llvm.org/D91885 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:276 + // Never ignore these. +} else if (!Context.isCheckEnabled(Error.DiagnosticName) && + Error.DiagLevel

[PATCH] D92628: [HIP] Fix bug in driver about wavefront size

This revision was automatically updated to reflect the committed changes. Closed by commit rG0519e1ddb388: [HIP] Fix bug in driver about wavefront size (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0519e1d - [HIP] Fix bug in driver about wavefront size

Author: Yaxun (Sam) Liu Date: 2020-12-04T08:36:52-05:00 New Revision: 0519e1ddb3885d070f054ca30a7487f915f6f795 URL: https://github.com/llvm/llvm-project/commit/0519e1ddb3885d070f054ca30a7487f915f6f795 DIFF:

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 updated this revision to Diff 309519. njames93 added a comment. Whoops missed one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 Files:

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

njames93 created this revision. njames93 added reviewers: Eugene.Zelenko, aaron.ballman. Herald added subscribers: kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using bools instead of integers

[PATCH] D92384: [AST][NFC] Silence GCC warning about broken strict aliasing rules

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92384/new/ https://reviews.llvm.org/D92384

[PATCH] D92650: [RISCV] Define preprocessor definitions for 'V' extension.

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92650/new/ https://reviews.llvm.org/D92650 ___

[PATCH] D92650: [RISCV] Define preprocessor definitions for 'V' extension.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, asb, luismarques, evandro. Herald added subscribers: frasercrmck, NickHung, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

njames93 updated this revision to Diff 309512. njames93 added a comment. Made ManagedStatic code transparent to users for RefCounted objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92480/new/ https://reviews.llvm.org/D92480 Files:

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor testing request. Comment at: clang/lib/AST/ASTTypeTraits.cpp:138 +return ASTNodeKind(NKI_##A##Attr); +#include "clang/Basic/AttrList.inc" + } ymandel wrote: >

[PATCH] D92269: [TableGen] Eliminate the 'code' type

silvas added a comment. Wow, awesome work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://reviews.llvm.org/D92269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92269: [TableGen] Eliminate the 'code' type

This revision was automatically updated to reflect the committed changes. Closed by commit rG415fab6f67b4: [TableGen] Eliminate the code type (authored by Paul-C-Anagnostopoulos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/

[PATCH] D92642: [clangd] Fix an assertion violation in rename.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG445289aa63e1: [clangd] Fix an assertion violation in rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 445289a - [clangd] Fix an assertion violation in rename.

Author: Haojian Wu Date: 2020-12-04T12:23:26+01:00 New Revision: 445289aa63e1b82b9eea6497fb2d0443813a9d4e URL: https://github.com/llvm/llvm-project/commit/445289aa63e1b82b9eea6497fb2d0443813a9d4e DIFF: https://github.com/llvm/llvm-project/commit/445289aa63e1b82b9eea6497fb2d0443813a9d4e.diff

[PATCH] D92642: [clangd] Fix an assertion violation in rename.

hokein updated this revision to Diff 309506. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92642/new/ https://reviews.llvm.org/D92642 Files:

[PATCH] D92647: Refactor codes and tests to make it work in PCH builds

psionic12 created this revision. psionic12 added reviewers: aaron.ballman, john.brawn. psionic12 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The former codes won't work for cases which PCH involves  in a build workflow, this patch 

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:41 +const char *getLanguage(const clang::LangOptions ) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) +return "C"; Testing for specific C versions seems a bit weird

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko updated this revision to Diff 309497. vsavchenko added a comment. Fix incorrect comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 Files: clang/include/clang/Analysis/PathDiagnostic.h

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. In D92639#2433303 , @OikawaKirie wrote: > It is really a good idea! Thanks  > The operations that would not leave an event in the report are now clearly > printed. > > But there are three arrows that confuse me in the

[PATCH] D92642: [clangd] Fix an assertion violation in rename.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:949 + {R"cpp(// disallow rename on non-normal identifiers. + @interface Foo {}

[PATCH] D92646: [Tooling] JSONCompilationDatabase::loadFromBuffer retains the buffer, copy it.

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added a subscriber: kadircet. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This function doesn't seem to be used in-tree outside

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko added a comment. For now without my patch current behavior is the following: Your examples listed below: asm("AA" : "DEF" : "GHI"); asm volatile(

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:190-196 +// Use a custom deleter for the TrueMatcherInstance ManagedStatic. This prevents +// an assert firing when the refcount is nonzero while running its destructor. +struct

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

njames93 updated this revision to Diff 309489. njames93 added a comment. Made this just focus on the destruction asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92480/new/ https://reviews.llvm.org/D92480 Files:

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Its close Comment at: clang/lib/Format/Format.cpp:751 /*AfterFunction=*/false,

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

njames93 updated this revision to Diff 309486. njames93 added a comment. Removed const qualifier on Providers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91925/new/ https://reviews.llvm.org/D91925 Files:

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

OikawaKirie added a comment. It is really a good idea! The operations that would not leave an event in the report are now clearly printed. But there are three arrows that confuse me in the example report: the assignment `x = 0` (x -> 0 -> x), the function call `dereference(x)` (x ->

[PATCH] D92570: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

This revision was automatically updated to reflect the committed changes. Closed by commit rGc17fdca1883d: [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c17fdca - [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

Author: Martin Storsjö Date: 2020-12-04T11:34:12+02:00 New Revision: c17fdca1883ddee94c6b7e055428d4445ab13e42 URL: https://github.com/llvm/llvm-project/commit/c17fdca1883ddee94c6b7e055428d4445ab13e42 DIFF:

[PATCH] D92642: [clangd] Fix an assertion violation in rename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. NamedDecl::getName() asserts the name must be an

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added a comment. In D92245#2425817 , @emaste wrote: >> How do things go wrong on Darwin? I was under the impression that this was >> implemented in LLVM as strictly inline code, no runtime support required. > > That is my impression as

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

teemperor added a comment. Having the comparison code would be nice. The custom types in the associated types aren't compared by the generic code, so an overload like this in the `StmtComparer` class should be enough: bool IsStmtEquivalent(const GenericSelectionExpr *E1, const

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay added a comment. In D79773#2432088 , @miscco wrote: > As someone who has extensively worked with concepts I cannot stress how much > this would improve my live and I'd like to think that this will help even in its current form, but it

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

martong added a comment. In D92600#2433263 , @martong wrote: > It might be worth to extend StmtComparer > > as well with

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

martong added a comment. It might be worth to extend StmtComparer as well with this Expr. I mean, probably two selections exprs should be considered equal if

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added a subscriber: kadircet. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Previously, loading one from a file meant allowing the

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:91 + // Whether a new CDB has been loaded but not broadcast yet. + bool Dirty = false; + // Last loaded CDB, meaningful if CachePopulated is set. kadircet

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. Here is how it looks for that test file: F14534708: report-6ea17d.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall updated this revision to Diff 309474. sammccall marked 6 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92381/new/ https://reviews.llvm.org/D92381 Files:

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, Szelethus, steakhal, martong, ASDenysPetrov. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. There is no such thing as an object "teleporting" in C++. Objects are always observed in memory with a specific address. When an argument is passed in registers, its address can be observed to be different on both sides, and that is not permitted; there must be some

[PATCH] D92573: [clang] Add a C++17 deduction guide testcase.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b9fc44d8128: [clang] Add a C++17 deduction guide testcase. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5b9fc44 - [clang] Add a C++17 deduction guide testcase.

Author: Haojian Wu Date: 2020-12-04T09:02:50+01:00 New Revision: 5b9fc44d8128717ef2f219b061c018abb85c717f URL: https://github.com/llvm/llvm-project/commit/5b9fc44d8128717ef2f219b061c018abb85c717f DIFF: https://github.com/llvm/llvm-project/commit/5b9fc44d8128717ef2f219b061c018abb85c717f.diff

[PATCH] D92573: [clang] Add a C++17 deduction guide testcase.

hokein added inline comments. Comment at: clang/test/PCH/cxx17-deduction-guide-decl.cpp:16 + +// Class template argument deduction +template adamcz wrote: > You can drop these 3 lines, they're not needed for the crash repro. Also, > c-tor doesn't have to be

[PATCH] D92573: [clang] Add a C++17 deduction guide testcase.

hokein updated this revision to Diff 309469. hokein added a comment. address comment, simplify the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92573/new/ https://reviews.llvm.org/D92573 Files:

<    1   2   3