[PATCH] D94803: [clang][cli] Generate HeaderSearch options separately

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0e8a9e5a2f0: [clang][cli] Generate HeaderSearch options separately (authored by jansvoboda11). Changed prior to commit:

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319547. abhina.sreeskantharajan added a comment. Fix CI: Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 Files:

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the builtin functions brought by the `cl_khr_subgroup_ballot` extension to

[PATCH] D95061: [OpenCL][Docs] Moved information about internals from UsersManual into OpenCLSupport

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7cc3a083fce: [OpenCL][Docs] Moved info from UsersManual into OpenCLSupport. (authored by Anastasia). Herald added a project: clang. Changed prior to commit:

[PATCH] D95519: [clang-tidy] bugprone-assert-side-effect: Warn on NSAssert by default.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! > I'm also interested in making an even more agressive step in this direction > and adding an option to accept any macro that ends with "...assert" suffix, >

[PATCH] D95487: Itanium Mangling: Fix handling of in .

jyknight added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3912 +IsPrimaryExpr = false; + }; + rjmccall wrote: > I think it might be more reasonable to just check for the relatively small > number of primary-expression cases in

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added a comment. In D94472#2523053 , @Bigcheese wrote: > The only issue I have with this if always parsing twice has a noticeable > performance impact for any users of Clang. Can we measure the impact? If it's > small (< 100ms ?) then

[PATCH] D94802: [clang][cli] Parse HeaderSearch options separately

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05127fba4b66: [clang][cli] Parse HeaderSearch options separately (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=" for MSInlineASM

This revision was automatically updated to reflect the committed changes. Closed by commit rG1edb76cc91e7: [X86] merge ={eax} and ~{eax} into =eax for MSInlineASM (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/

[PATCH] D95526: [Syntax] Add syntax-tree-dump in clang-check.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. hokein requested review of this revision. Herald added a project: clang. This is useful to experiment/develop syntax trees. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95526

[PATCH] D95488: Itanium Mangling: In 'enable_if', omit X/E around .

jyknight updated this revision to Diff 319578. jyknight added a comment. Add neglected clang-abi-compat.cpp change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95488/new/ https://reviews.llvm.org/D95488 Files: clang/lib/AST/ItaniumMangle.cpp

[PATCH] D95229: [clangd] Treat optional field type mismatches as soft failures

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:837 return false; + tryMap(Params, "triggerCharacter", R.triggerCharacter, P); R.triggerKind = static_cast(TriggerKind); sammccall wrote: > why are we no longer checking

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

mantognini added a comment. Looks sensible to me. Comment at: clang/test/SemaOpenCLCXX/members.cl:17 - -template struct remove_reference { typedef T type; }; -template struct remove_reference { typedef T type; }; I wonder, do we lose coverage by removing

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:58 + +namespace { + aaron.ballman wrote: > Is there a need for the anonymous namespace? (We typically only use them when > defining a class

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 319526. jansvoboda11 added a comment. Compare once and twice generated arguments, fix re-ordering of UserEntries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

awarzynski added a comment. Thank you for working on this @FarisRehman ! I've left a few inline comments, but nothing major. Really nice to see this being added and working as expected! Comment at: clang/include/clang/Driver/Options.td:4074-4076 +def ffixed_line_length_VALUE

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

stefanp added a comment. I have a few comments. Most of them are nits but there is a functional issue as well. For the testing: Do we have a test for the `PPC64R2SaveStub` in the situation where the offset fits in 34 bits? Comment at: lld/ELF/Driver.cpp:768 + // This

[PATCH] D95519: [clang-tidy] bugprone-assert-side-effect: Warn on NSAssert by default.

vsavchenko added a comment. LGTM, but it would be great if code owners take a look as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95519/new/ https://reviews.llvm.org/D95519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:58 + +namespace { + Is there a need for the anonymous namespace? (We typically only use them when defining a class and try to make them as

[PATCH] D95166: Disable rosegment for old Android versions.

dmajor added a comment. Firefox has a build break from this change. In certain Android configurations we use bfd or gold. The statement in the commit message "Android only supports LLD" is news to me, could you point me to any references for this? Repository: rG LLVM Github Monorepo

[PATCH] D95229: [clangd] Treat optional field type mismatches as soft failures

kadircet updated this revision to Diff 319551. kadircet marked 2 inline comments as done. kadircet added a comment. - rename to mapOptOrNull - revert leftover changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95229/new/

[PATCH] D95349: [clangd] Allow diagnostics to be suppressed with configuration

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:319 -if (!CTChecks.empty()) { - ASTDiags.setLevelAdjuster([](DiagnosticsEngine::Level DiagLevel, - const clang::Diagnostic ) { +

[PATCH] D95229: [clangd] Treat optional field type mismatches as soft failures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf20232b8e18: [clangd] Treat null optional fields as missing (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95532: [clang][cli] Use variadic macros for parsing/generating

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes all macros forwarding to `PARSE_OPTION_WITH_MARSHALLING` and

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319543. abhina.sreeskantharajan added a comment. I've changed the host check to use python's sys.platform to determine the host as an alternative to using LLVM_HOST_TRIPLE. It will save us the effort of making sure it's defined in all

[PATCH] D95516: [clang][cli] Benchmark command line round-trip

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: mgorny. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a micro-benchmark for command line

[PATCH] D95348: [clang][cli] Port OpenMP-related LangOpts to marshalling system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ad94c126aac: [clang][cli] Port OpenMP-related LangOpts to marshalling system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D95519: [clang-tidy] bugprone-assert-side-effect: Warn on NSAssert by default.

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, vsavchenko. NoQ added a project: clang-tools-extra. Herald added subscribers: martong, Charusso, xazax.hun. NoQ requested review of this revision. This is basically standard Objective-C assert. While we could always pass it as

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6448 + CmdArgs.push_back("-target-feature"); + CmdArgs.push_back("+outline-atomics"); +} This needs a Clang driver tests. Repository: rG LLVM Github Monorepo

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

dexonsmith added a comment. Can you include the use in the patch? I’m not sure having the AllocateString API totally makes sense, vs moving in a string pool that was independently used during generation, but maybe in context? I also wonder what command-line option is forcing this. Ideally we

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 319566. bader added a comment. Rebase patch on ToT and applied small refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang/AST/Type.h

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some members of CompilerInvocation store `StringRef`s pointing to the command line

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader updated this revision to Diff 319579. bader added a comment. Depends on D89909 Apply improvements developed in out-of-tree repository, which mostly are refactoring of SemaSYCL.cpp file. Rebase on ToT + D89909 (which only

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dang, pengfei. Herald added a reviewer: jansvoboda11. thakis requested review of this revision. On non-Windows platforms, --sysroot can be used to make the compiler use a single, hermetic directory for all

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867 +extern const internal::MapAnyOfMatcher +callOrConstruct; + steveire wrote: > aaron.ballman wrote: > > steveire wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D95516: [clang][cli] Benchmark command line round-trip

jansvoboda11 added inline comments. Comment at: clang/benchmarks/CMakeLists.txt:3 + +target_link_libraries(CompilerInvocationBench + PRIVATE Not sure if we should do anything else here. I mostly cargo-culted this from clangd. Comment at:

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:349-351 +triple = "" +if hasattr(self.config, 'host_triple'): +triple = self.config.host_triple

[PATCH] D95349: [clangd] Allow diagnostics to be suppressed with configuration

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:319 -if (!CTChecks.empty()) { - ASTDiags.setLevelAdjuster([](DiagnosticsEngine::Level DiagLevel, - const clang::Diagnostic ) { +

[PATCH] D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:81 case diag::err_func_def_incomplete_result: + case diag::err_field_incomplete_or_sizeless: //

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/members.cl:17 - -template struct remove_reference { typedef T type; }; -template struct remove_reference { typedef T type; }; mantognini wrote: > I wonder, do we lose coverage by removing

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

alexfh added a comment. This patch causes practically infinite traversal times on code that contains deeply nested lambdas. I'll try to get a suitable repro, but could you maybe revert this in the meantime? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94827: [SimplifyCFG] If provided, preserve Dominator Tree

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94827/new/ https://reviews.llvm.org/D94827 ___

[PATCH] D94827: [SimplifyCFG] If provided, preserve Dominator Tree

lebedev.ri added a comment. @kuhar @mkazantsev wanna get in on the hype train? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94827/new/ https://reviews.llvm.org/D94827 ___ cfe-commits mailing list

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. @JDevlieghere, would you care to review? This is another instance of moving away from system binaries to whatever the user / package manager wants the build to use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-rvv-intrinsics-generic/vadd.c:10 + +// ASM-NOT: warning +#include jrtc27 wrote: > Asm checks are discouraged in Clang. If you want to check for Clang warnings, > use -verify, and in this

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 319488. khchen marked 21 inline comments as done. khchen added a comment. 1. address @jrtc27's comments. I really appreciate your help very much. 2. use downstream test generator and move all tests to rvv-intrinsics-generic and rvv-intrinsics. Repository:

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

kadircet created this revision. kadircet added reviewers: MyDeveloperDay, curdeius. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently getStyle() fails immediately if FallbackStyle is not a predefined style, even when it is

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

jansvoboda11 added a comment. In D95514#2525255 , @dexonsmith wrote: > Can you include the use in the patch? > I also wonder what command-line option is forcing this. The use-case that requires it is here:

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

sammccall updated this revision to Diff 319592. sammccall retitled this revision from "[clangd] WIP playing with semantic highlighting modifiers" to "[clangd] Implement semanticTokens modifiers". sammccall edited the summary of this revision. sammccall added a comment. Update phab with commit

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Right, thanks for the explanations. They make sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95442/new/ https://reviews.llvm.org/D95442

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

sammccall updated this revision to Diff 319594. sammccall added a comment. Tidy up, explain static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77811/new/ https://reviews.llvm.org/D77811 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:613 + // settings. This allows the format to back up one level in those cases. + if (!AddLevel &&

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-len2.cpp:10 + +void declaration(int Param, int Other); // NO-WARN: No chance to change this function. + aaron.ballman wrote: > I think

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX marked 4 inline comments as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:433 PreambleSymbols.update( -Uri, std::make_unique(std::move(*IF->Symbols)), +FilePath ? *FilePath :

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. The truncate conditions look a lot better and the test coverage seems reasonable now. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added a comment. Maybe we should just go with `Windows Kits/10" -- the space is only seen at the driver->cc1 boundary and it works fine there, and the 10 can be inferred from /winsdkversion. On the other hand, thinking about how to create such a sysroot directory, saying "just copy

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. @rnk Taking it upon yourself to revert this without approval and without communication on all branches, especially given the earlier suggestion by @rsmith to only revert this on the LLVM 12 branch, is an abuse of your commit privileges as far as I am concerned.

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

jansvoboda11 added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:144 + /// Container holding strings allocated during round-trip. + mutable std::forward_list AllocatedStrings; + dexonsmith wrote: > I suggest using

[PATCH] D95526: [Syntax] Add syntax-tree-dump in clang-check.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-check/ClangCheck.cpp:141 +class BuildSyntaxTree : public clang::ASTFrontendAction { +public: DumpSyntaxTree since

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX updated this revision to Diff 319602. ArcsinX added a comment. - Set `IdxContents` at `FileSymbols` object breation instead of at `FileSymbols::buildIndex()` call. - Revert change of the preamble index key scheme - Add comment for `IndexContents` - `IndexDataKind` => `IndexContents`

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD updated this revision to Diff 319607. RedDocMD added a comment. Removing duplication of CXXBaseSpecifiers when they are created for PointerToMember Removed hackish weakening of assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

mstorsjo added a comment. > "Windows Kits/10" has the drawback that it contains a space and yet another > number. Ideally the contents of that directory would be available under some > short name, so I went with /winsdkdir /win_sdk. I'm not married to this > though. Maybe /WinSdk looks move

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

dexonsmith added a comment. In D95514#2525517 , @jansvoboda11 wrote: > In D95514#2525255 , @dexonsmith > wrote: > >> Can you include the use in the patch? >> I also wonder what command-line option is forcing

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith, rjmccall, rtrieu. Herald added subscribers: lxfind, jdoerfert. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, when trying to access a member of a

[PATCH] D77811: [clangd] WIP playing with semantic highlighting modifiers

sammccall updated this revision to Diff 319591. sammccall added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Rebase, polish, add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77811/new/

[PATCH] D95031: [clangd] Log warning when using legacy (theia) semantic highlighting.

sammccall added a comment. In D95031#2509896 , @nridge wrote: > Thanks for the heads up! It would be nice to get D77702 > landed before the removal of > `TheiaSemanticHighlighting`. I'll try to find some time to rebase

[PATCH] D94827: [SimplifyCFG] If provided, preserve Dominator Tree

lebedev.ri updated this revision to Diff 319624. lebedev.ri retitled this revision from "[SimplifyCFG] Require and preserve dominator tree" to "[SimplifyCFG] If provided, preserve Dominator Tree". lebedev.ri edited the summary of this revision. lebedev.ri added a comment. Let me resell this.

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

MaskRay added a comment. `#!/usr/bin/env perl -w` (2 arguments) unfortunately does not work on Linux and many other systems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

MaskRay added a comment. Several `llvm/utils/` scripts can probably just be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___ cfe-commits mailing list

[PATCH] D95487: Itanium Mangling: Fix handling of in .

jyknight added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3912 +IsPrimaryExpr = false; + }; + jyknight wrote: > rjmccall wrote: > > I think it might be more reasonable to just check for the relatively small > > number of

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rjmccall added inline comments. Comment at: clang/include/clang/AST/CXXInheritance.h:77 - CXXBasePath() = default; + /// Additional data stashed on the base path by its consumers. + union { rsmith wrote: > rjmccall wrote: > > rsmith wrote: > > > rjmccall

[PATCH] D95532: [clang][cli] Use variadic macros for parsing/generating

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95532/new/ https://reviews.llvm.org/D95532

[clang] 8ca3360 - Itanium Mangling: Fix handling of in .

Author: James Y Knight Date: 2021-01-27T16:46:52-05:00 New Revision: 8ca33605ff0cfc536f5c6710fb5f6378bf11959a URL: https://github.com/llvm/llvm-project/commit/8ca33605ff0cfc536f5c6710fb5f6378bf11959a DIFF:

[clang] a7246ba - Itanium Mangling: In 'enable_if', omit X/E around .

Author: James Y Knight Date: 2021-01-27T16:46:52-05:00 New Revision: a7246ba02a8923f316419a62d836dbe1c0b437bd URL: https://github.com/llvm/llvm-project/commit/a7246ba02a8923f316419a62d836dbe1c0b437bd DIFF:

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rnk added a comment. OK, thanks for the direction. We'll try to port code to use the device you listed. I see you think we need a new warning for this, a clang 12 release note, and then this can reland. @hvdijk , that plan looks good to me, and I'll let you and Richard sort it out. I don't

[clang] 9c7aeae - Itanium Mangling: Mangle `__alignof__` differently than `alignof`.

Author: James Y Knight Date: 2021-01-27T16:46:51-05:00 New Revision: 9c7aeaebb3ac1b94200b59b111742cb6b8f090c2 URL: https://github.com/llvm/llvm-project/commit/9c7aeaebb3ac1b94200b59b111742cb6b8f090c2 DIFF:

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319671. tbaeder added a comment. Forgot clang-format of course, sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaExprMember.cpp

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

steveire updated this revision to Diff 319672. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94865/new/ https://reviews.llvm.org/D94865 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

kromanenkov added a comment. Looks like you run formatter on the whole file, maybe narrow down its scope a little? For example, only for the touched function? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95307/new/

[PATCH] D95575: clang-cl: Accept /std:c11, /std:c17 flags

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dang, kristof.beyls. Herald added a reviewer: jansvoboda11. thakis requested review of this revision. clang-cl already defaults to C17 for .c files, but no harm in accepting these flags. Fixes PR48185.

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

dmajor added a comment. If I'm reading git correctly, the change is still present on the 12.x branch. Should it be reverted there too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91913/new/ https://reviews.llvm.org/D91913

[PATCH] D95560: [CUDA][HIP] Fix function scope static variable

tra added a comment. > A static variable in device and global functions is supposed to have > implicit device attribute. Currently it does not. This causes incorrect > diagnostics about host variables accessed by device functions. Correct diagnostics sevice-side local static vars is a valid

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:157 llvm::Function *makeModuleDtorFunction() override; + void + adjustShadowVarLinkage(const VarDecl *D, clang-format it? `void` hanging all by itself looks odd.

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1478 + enum class AtomicOperationKind { +Unsupported, +Init, This shouldn't be here; if you have places that don't always represent an atomic operation, queries for the

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. In D76802#2526483 , @MaskRay wrote: > Looks quite good. > > In D76802#2526382 , @phosek wrote: > >> @MaskRay does this look good to you? > > Looks like GNU ld has an infinite loop problem

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak reopened this revision. ahatanak added a comment. This revision is now accepted and ready to land. Address post-commit review comments. - Use operand bundle instead of attribute. - Emit a call to `@llvm.objc.clang.arc.noop.use` in the front-end so that the optimization passes know the

[PATCH] D95583: Frontend: Add -f{, no-}implicit-modules-uses-lock and -Rmodule-lock

dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, jansvoboda11. Herald added subscribers: dang, ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Add -cc1 flags `-fmodules-uses-lock` and `-fno-modules-uses-lock` to allow the lock manager

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 319762. phosek added a reviewer: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. In D91913#2526866 , @dmajor wrote: > If I'm reading git correctly, the change is still present on the 12.x branch. > Should it be reverted there too? I could have sworn that I saw it already reverted on the 12.x branch too, but I

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 319719. ahatanak retitled this revision from "[ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR" to "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

MaskRay added a comment. > Implement option to omit P10 instructions from > stubs Please mention the option name directly. Please avoid P10 - the abbreviation is confusing. Comment at: lld/ELF/Config.h:74 +// For

[PATCH] D95581: Frontend: Refactor compileModuleAndReadAST, NFC

dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. This renames `compileModuleAndReadAST`, adding a `BehindLock` suffix, and refactors it to

[PATCH] D95589: [RISCV] Support experimental 'P' extension 0.9

Jim created this revision. Jim added reviewers: craig.topper, HsiangKai, jrtc27, kito-cheng, luismarques. Herald added subscribers: frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D95590: [RISCV] Define preprocessor definitions for 'P' extension

Jim created this revision. Jim added reviewers: craig.topper, HsiangKai, kito-cheng, jrtc27, luismarques. Herald added subscribers: frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke added inline comments. Comment at: llvm/include/llvm-c/Core.h:163 LLVMX86_MMXTypeKind, /**< X86 MMX */ + LLVMX86_AMXTypeKind, /**< X86 AMX */ LLVMTokenTypeKind, /**< Tokens */ MaskRay wrote: > cuviper wrote: > > This is a breaking change

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2688-2689 // ::= S # __attribute__((__swiftcall__)) // Clang-only + // ::= T # __attribute__((__swiftasynccall__)) // + //

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rsmith added a comment. rG0436ec2128c9775ba13b0308937238fc79673fdd enables `__VA_OPT__` across language modes and allows support for it to be detected by `#ifdef`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5d3dca2 - Ignore unknown attribute warnings in this test

Author: Aaron Ballman Date: 2021-01-27T15:45:35-05:00 New Revision: 5d3dca24aab847f0fdfd558987c1c28469e2f31e URL: https://github.com/llvm/llvm-project/commit/5d3dca24aab847f0fdfd558987c1c28469e2f31e DIFF: https://github.com/llvm/llvm-project/commit/5d3dca24aab847f0fdfd558987c1c28469e2f31e.diff

[PATCH] D95487: Itanium Mangling: Fix handling of in .

rsmith accepted this revision. rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:549 void mangleInitListElements(const InitListExpr *InitList); - void mangleDeclRefExpr(const NamedDecl *D); - void mangleExpression(const Expr *E, unsigned Arity =

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

cuviper added inline comments. Comment at: llvm/include/llvm-c/Core.h:163 LLVMX86_MMXTypeKind, /**< X86 MMX */ + LLVMX86_AMXTypeKind, /**< X86 AMX */ LLVMTokenTypeKind, /**< Tokens */ This is a breaking change to the C ABI -- can we move it to the

  1   2   3   >