[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

njames93 added a comment. In D95714#2540626 , @poelmanc wrote: > Thanks for all the great feedback I received here. To give credit where > credit's due, this updated revision to UseNullptrCheck.cpp is now actually > 100% @steveire's //suggested// code.

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. In D95166#2540399 , @danalbert wrote: >> We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're >> likely set on our end. > > https://reviews.llvm.org/D76452 not being accepted means that Android > toolchains

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95099/new/ https://reviews.llvm.org/D95099 ___ cfe-commits mailing list

[clang] aade0ec - Fix the guaranteed alignment of memory returned by malloc/new on Darwin

Author: Akira Hatanaka Date: 2021-02-03T19:40:51-08:00 New Revision: aade0ec23b5986a9c478c4093d029a5db8a2c012 URL: https://github.com/llvm/llvm-project/commit/aade0ec23b5986a9c478c4093d029a5db8a2c012 DIFF:

[PATCH] D95910: Fix the guaranteed alignment of memory returned by malloc/new on Darwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaade0ec23b59: Fix the guaranteed alignment of memory returned by malloc/new on Darwin (authored by ahatanak). Repository: rG LLVM Github Monorepo

[clang] a2c1054 - [ASTReader] Always rebuild a cached module that has errors

Author: Ben Barham Date: 2021-02-03T22:06:46-08:00 New Revision: a2c1054c303f20be006e9ef20739dbb88bd9ae02 URL: https://github.com/llvm/llvm-project/commit/a2c1054c303f20be006e9ef20739dbb88bd9ae02 DIFF: https://github.com/llvm/llvm-project/commit/a2c1054c303f20be006e9ef20739dbb88bd9ae02.diff

[PATCH] D95989: [ASTReader] Always rebuild a cached module that has errors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c1054c303f: [ASTReader] Always rebuild a cached module that has errors (authored by bnbarham, committed by akyrtzi). Repository: rG LLVM Github

[PATCH] D95989: [ASTReader] Always rebuild a cached module that has errors

bnbarham updated this revision to Diff 321308. bnbarham set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95989/new/ https://reviews.llvm.org/D95989 Files:

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

Jim added inline comments. Comment at: clang/test/CodeGen/RISCV/vadd.c:22 +{ +return __builtin_rvv_vadd_vv_i8m1_vl(arg_0, arg_1, arg_2); +} Is it necessary with prefix "__builtin_"? Refer to

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

jrtc27 added inline comments. Comment at: clang/test/CodeGen/RISCV/vadd.c:22 +{ +return __builtin_rvv_vadd_vv_i8m1_vl(arg_0, arg_1, arg_2); +} Jim wrote: > Is it necessary with prefix "__builtin_"? > Refer to >

[clang] a2fdf9d - [hip][cuda] Enable extended lambda support on Windows.

Author: Michael Liao Date: 2021-02-04T01:38:29-05:00 New Revision: a2fdf9d4d734732a6fa9288f1ffdf12bf8618123 URL: https://github.com/llvm/llvm-project/commit/a2fdf9d4d734732a6fa9288f1ffdf12bf8618123 DIFF: https://github.com/llvm/llvm-project/commit/a2fdf9d4d734732a6fa9288f1ffdf12bf8618123.diff

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2fdf9d4d734: [hip][cuda] Enable extended lambda support on Windows. (authored by hliao). Changed prior to commit:

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. In D95915#2539483 , @jdoerfert wrote: > Also, now you don't warn for different missing runtimes, which seems odd. What do you mean? Is the value returned from `GetRuntimeLibType()` ever going to change? CHANGES SINCE LAST

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2540705 , @thakis wrote: > In D95166#2540399 , @danalbert wrote: > >>> We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're >>> likely set on our end. >>

[PATCH] D95989: [ASTReader] Always rebuild a cached module that has errors

bnbarham updated this revision to Diff 321305. bnbarham added a comment. Added a couple semi-colons to the test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95989/new/ https://reviews.llvm.org/D95989 Files: clang/lib/Serialization/ASTReader.cpp

[PATCH] D96000: Don't emit coverage mapping for excluded functions

phosek created this revision. phosek added reviewers: davidxl, vsk. Herald added a subscriber: wenlei. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a function or a file is excluded using -fprofile-list= option, don't emit

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. In D95915#2541129 , @Hahnfeld wrote: > My proposal would be to cache the return value of the three routines in > `ToolChain`. This has the advantage that the values get parsed only once and > there is at most one warning. I

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added a comment. In D95915#2541132 , @tbaeder wrote: > That's what I was looking at right now as well, since using > `std::call_once()` already means the methods can't be `const` anymore anyway. > Might as well just cache the value. You can

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:333 + // not invalidated. + DynTypedNodeList Parents(DynTypedNode::create(RenamedDecl)); + auto GetSingleParent = [&](DynTypedNode Node) -> const DynTypedNode * { If the

[clang] 3b9de99 - Give this test a target triple.

Author: Richard Smith Date: 2021-02-03T23:38:52-08:00 New Revision: 3b9de993c9dffd0941ad79c80a2cb7785bc63f03 URL: https://github.com/llvm/llvm-project/commit/3b9de993c9dffd0941ad79c80a2cb7785bc63f03 DIFF: https://github.com/llvm/llvm-project/commit/3b9de993c9dffd0941ad79c80a2cb7785bc63f03.diff

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added a comment. My proposal would be to cache the return value of the three routines in `ToolChain`. This has the advantage that the values get parsed only once and there is at most one warning. I don't know how this plays with parallelization efforts, but I don't think we should

[clang] cde8d2f - Fix miscompile when performing template instantiation of non-dependent

Author: Richard Smith Date: 2021-02-03T23:38:02-08:00 New Revision: cde8d2fddbff55cae520d90f47f6faf124d3f953 URL: https://github.com/llvm/llvm-project/commit/cde8d2fddbff55cae520d90f47f6faf124d3f953 DIFF: https://github.com/llvm/llvm-project/commit/cde8d2fddbff55cae520d90f47f6faf124d3f953.diff

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95918/new/ https://reviews.llvm.org/D95918

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre updated this revision to Diff 321107. thopre marked 2 inline comments as done. thopre added a comment. - Fix order of sub operands in comments and use fully parenthesized expression - Explain how LShr is equivalent to < 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

jdoerfert added a comment. Drive by: I don't believe a static variable is a good idea. Also the name is not really informative. A member in `ToolChain` with a proper name would be nicer (IMHO). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915

[clang] 81b6987 - [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

Author: Kevin P. Neal Date: 2021-02-03T11:49:17-05:00 New Revision: 81b69879c946533c71cc484bd8d9202bf1e34bfe URL: https://github.com/llvm/llvm-project/commit/81b69879c946533c71cc484bd8d9202bf1e34bfe DIFF: https://github.com/llvm/llvm-project/commit/81b69879c946533c71cc484bd8d9202bf1e34bfe.diff

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG81b69879c946: [FPEnv][X86] Platform builtins edition: clang should get from the AST the… (authored by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2536661 , @arsenm wrote: > In D78979#2536590 , @Anastasia wrote: > >> @arsenm I would like to see if we can finalize this patch soon. Do you think >> you will have a capacity

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-handler.rst:29-30 + `_ + for more information). This is not an extension of the

[PATCH] D92270: [ConstantFold] Fold more operations to poison

RKSimon added a comment. https://bugs.llvm.org/show_bug.cgi?id=49005 seems to be due to this (either directly or it has unearthed an existing problem) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92270/new/ https://reviews.llvm.org/D92270

[PATCH] D62574: Add support for target-configurable address spaces.

danilaml added a comment. So is missing an in-tree user (like AMDGPU) the only thing that prevents from merging this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574

[PATCH] D95871: [clang] Store the location for invalid type of a declarator.

sammccall added a comment. It would be nice to have a testcase with a nontrivial range so we can see the choice of location... Comment at: clang/lib/Sema/SemaType.cpp:5659 if (D.isInvalidType()) -return Context.getTrivialTypeSourceInfo(T); - +return

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein added a comment. Thanks, this looks right to me. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:338 + const CompoundStmt *EnclosingScope = ParentNode->get(); + if (const auto *If = ParentNode->get()) +if (const auto *Then = dyn_cast(If->getThen()))

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder updated this revision to Diff 321022. tbaeder added a comment. Noticed similar/worse behavior for -rtlib. Expanded the patch to that and -unwindlib as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 Files:

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

steakhal added a comment. In D95860#2536721 , @balazske wrote: > In D95860#2536609 , @steakhal wrote: > >> Please, also add a regression test for Haoxin Tu's reproducer. >> >> // RUN: %clang %s >> >> //

[clang] e635feb - [OpenCL] Fix address space in binding of initializer lists to referencs

Author: Anastasia Stulova Date: 2021-02-03T12:48:21Z New Revision: e635feb15a91e6eeb77876031be2811e63d542f3 URL: https://github.com/llvm/llvm-project/commit/e635feb15a91e6eeb77876031be2811e63d542f3 DIFF: https://github.com/llvm/llvm-project/commit/e635feb15a91e6eeb77876031be2811e63d542f3.diff

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

This revision was automatically updated to reflect the committed changes. Closed by commit rGe635feb15a91: [OpenCL] Fix address space in binding of initializer lists to referencs (authored by Anastasia). Herald added a project: clang. Changed prior to commit:

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D95886: [OpenCL][Docs] Link page explaining tooling for offline compilation

svenvh added inline comments. Comment at: clang/docs/UsersManual.rst:2835 `_ -to produce SPIR-V binary. - +to produce SPIR-V binary. More detail are provided in the following +online resource - `the offline compilation from

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre created this revision. thopre added reviewers: efriedma, kpn, mibintc, sepavloff, rjmccall. Herald added subscribers: dexonsmith, pengfei. thopre requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. __builtin_isnan currently

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske added a comment. But I do not know if there is a better solution, if the file ID is different these are in different files, one included from the other. If the "include locations" are not accessible in the same way as macro locations we can not get the place (of the #include

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers abandoned this revision. vabridgers added a comment. Abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D93787 ___ cfe-commits mailing list

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 321074. RedDocMD added a comment. Remoevd the use of std::list with llvm::SmallVector. Removed the need to delete elements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. @vsavchenko could you please see the current logic if it is better now? Comment at: clang/test/Analysis/pointer-to-member.cpp:304 + grandpa.field = 10; + int Grandfather::*gpf1 = static_cast(sf); + int Grandfather::*gpf2 =

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a comment. Thanks @rsmith, will do. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 ___ cfe-commits mailing list

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added a comment. Also, all these `PathRange` and `PathList` don't really reflect what they stand for semantically and talk more about implementation. It's not the problem of this patch, but it doesn't make your logic easier to comprehend. Comment at:

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein added a comment. thanks, looks better now, just some nits to improve the code readability. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:332 + DynTypedNodeList Parents = Ctx.getParents(RenamedDecl); + if (Parents.size() != 1 || !Parents.begin()->get()) +

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

This revision was automatically updated to reflect the committed changes. Closed by commit rGe48f444751cf: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array… (authored by ilya, committed by einvbri vince.a.bridg...@ericsson.com). Repository: rG LLVM Github Monorepo

[clang] e48f444 - [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

Author: Ilya Mirsky Date: 2021-02-03T07:50:50-06:00 New Revision: e48f444751cf781c42934b242b81f549da77bad0 URL: https://github.com/llvm/llvm-project/commit/e48f444751cf781c42934b242b81f549da77bad0 DIFF: https://github.com/llvm/llvm-project/commit/e48f444751cf781c42934b242b81f549da77bad0.diff

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 321078. RedDocMD added a comment. Made assertion more verbose Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 Files:

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers added a comment. Abandoning this change request in favor of @steakhal 's more comprehensive change @ https://reviews.llvm.org/D93222 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D93787

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the fix, the changes LGTM! Do you need me to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d38973a - [clang][AVR] Improve avr-ld command line options

Author: Ben Shi Date: 2021-02-03T18:23:01+08:00 New Revision: d38973aa4d6a2c8be97b9781ca7325ca3eb0c40d URL: https://github.com/llvm/llvm-project/commit/d38973aa4d6a2c8be97b9781ca7325ca3eb0c40d DIFF: https://github.com/llvm/llvm-project/commit/d38973aa4d6a2c8be97b9781ca7325ca3eb0c40d.diff LOG:

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGd38973aa4d6a: [clang][AVR] Improve avr-ld command line options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D93579?vs=318881=321035#toc Repository: rG LLVM Github

[clang-tools-extra] 54afcad - [clangd] Report xref for base methods.

Author: Utkarsh Saxena Date: 2021-02-03T12:07:43+01:00 New Revision: 54afcade3bbcf4a085c8a8c3c22429921420e54d URL: https://github.com/llvm/llvm-project/commit/54afcade3bbcf4a085c8a8c3c22429921420e54d DIFF:

[PATCH] D95852: [clangd] Report xref for base methods.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54afcade3bbc: [clangd] Report xref for base methods. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs

kadircet created this revision. kadircet added a reviewer: hokein. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95935 Files:

[clang] 3fda262 - [clang][AVR][NFC] Fix a typo

Author: Ben Shi Date: 2021-02-03T20:00:06+08:00 New Revision: 3fda262b7d7bdbf9db5b1d6602602733b4cf4f35 URL: https://github.com/llvm/llvm-project/commit/3fda262b7d7bdbf9db5b1d6602602733b4cf4f35 DIFF: https://github.com/llvm/llvm-project/commit/3fda262b7d7bdbf9db5b1d6602602733b4cf4f35.diff LOG:

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

DavidSpickett updated this revision to Diff 321037. DavidSpickett added a comment. - Added split -Wa test for -mthumb - Use `--check-prefix`/`--check-prefixes` - Comment at top of march/mcpu file to explain choice of test CPUs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9caf364d69db: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs (authored by svenvh). Changed prior to commit:

[clang] 9caf364 - [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-03T10:23:49Z New Revision: 9caf364d69db3cd0ce0fba99dba95dbc2b646fbc URL: https://github.com/llvm/llvm-project/commit/9caf364d69db3cd0ce0fba99dba95dbc2b646fbc DIFF: https://github.com/llvm/llvm-project/commit/9caf364d69db3cd0ce0fba99dba95dbc2b646fbc.diff

[clang] e6a62ac - [OpenCL] Add cl_khr_subgroup_non_uniform_vote to TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-03T10:23:52Z New Revision: e6a62ac62571229d941dfe81affabdbc47e478eb URL: https://github.com/llvm/llvm-project/commit/e6a62ac62571229d941dfe81affabdbc47e478eb DIFF: https://github.com/llvm/llvm-project/commit/e6a62ac62571229d941dfe81affabdbc47e478eb.diff

[PATCH] D95852: [clangd] Report xref for base methods.

usaxena95 updated this revision to Diff 321038. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95852/new/ https://reviews.llvm.org/D95852 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

DavidSpickett marked 6 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42 +/// We use the target CPU for both. +// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a8 -Wa,-march=armv8a %s 2>&1 | \

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske updated this revision to Diff 321039. balazske added a comment. Existing test moved to Frontend, added new test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95860/new/ https://reviews.llvm.org/D95860 Files:

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

Anastasia added a comment. In D95608#2537316 , @rjmccall wrote: > Thanks, LGTM. > > I think idiomatically we normally just use `(void)` instead of spelling it > out with `static_cast`, since there's only one possible meaning for a cast to > `void`. I

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321050. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files:

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:339 + if (const auto *If = ParentNode->get()) +if (const auto *Then = dyn_cast(If->getThen())) + EnclosingScope = Then; hokein wrote: > thinking more about the

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321053. kbobyrev added a comment. Don't spell out DynTypedNodeList and don't include ParentMapContext.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files:

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

steakhal added a comment. In D95860#2538802 , @balazske wrote: > Existing test moved to Frontend, added new test. Awesome, thanks! On the functional side of things, I'm not sure if we should skip or not. But simply skipping those seems like you are

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321052. kbobyrev added a comment. Save few LOCs by checking for nullptr in CheckDeclStmt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files:

[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs

kadircet updated this revision to Diff 321054. kadircet added a comment. - Also handle memberrefexpr case. Fixes https://github.com/clangd/clangd/issues/676. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95935/new/ https://reviews.llvm.org/D95935

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321055. kbobyrev added a comment. Revert last change: leads to incomplete types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files:

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for working on this @FarisRehman ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95460/new/ https://reviews.llvm.org/D95460

[PATCH] D95852: [clangd] Report xref for base methods.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/XRefs.cpp:1294 + OverriddenMethods.insert(ID); +getOverriddenMethods(Base, OverriddenMethods); + }

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske updated this revision to Diff 321041. balazske added a comment. Reformatting test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95860/new/ https://reviews.llvm.org/D95860 Files: clang/lib/Frontend/DiagnosticRenderer.cpp

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske added a comment. I realized that the added test cases show different problems: One is when one of `Begin` or `End` is invalid, other if the FileID's are different. Probably we can find a better solution for the second problem. So the patch needs to be splitted and the case with the

[PATCH] D95876: [clang-cl] Remove the /fallback option

hans updated this revision to Diff 321080. hans marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95876/new/ https://reviews.llvm.org/D95876 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst

[PATCH] D95876: [clang-cl] Remove the /fallback option

hans added a comment. Please take another look. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:669 const InputInfoList , const ArgList , const char *LinkingOutput) const { ArgStringList CmdArgs; thakis wrote: > Doesn't this whole function exist

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321095. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files:

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:226 +llvm::make_range(BaseList.begin(), BaseList.end()), +[](const auto ) -> bool { return I.second; }); + vsavchenko wrote: > I think it's all a bit too

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:355 + // This helper checks if there is a condition variable has NewName. + auto CheckConditionVariable = [&](const auto *Scope) -> const NamedDecl * { +if (!Scope)

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kbobyrev added a comment. @sammccall Ping, this is a real patch :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89870/new/ https://reviews.llvm.org/D89870 ___ cfe-commits mailing list

[clang] 7a45f27 - [OpenCL][Docs] Fix command line flag in the example.

Author: Anastasia Stulova Date: 2021-02-03T14:07:46Z New Revision: 7a45f27ba156e311bf1deaa42761ec08d8e34d05 URL: https://github.com/llvm/llvm-project/commit/7a45f27ba156e311bf1deaa42761ec08d8e34d05 DIFF: https://github.com/llvm/llvm-project/commit/7a45f27ba156e311bf1deaa42761ec08d8e34d05.diff

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321086. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve most comments but one: some comments & examples in the code incoming in the next diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95951: [OpenCL] Add cl_khr_subgroup_non_uniform_arithmetic to TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtin functions brought by the cl_khr_subgroup_non_uniform_arithmetic

[clang] e59d336 - [test] Use host platform specific error message substitution in lit tests - continued

Author: Abhina Sreeskantharajan Date: 2021-02-03T09:53:22-05:00 New Revision: e59d336e75f4670b1a702c2281b3fed27ba4c426 URL: https://github.com/llvm/llvm-project/commit/e59d336e75f4670b1a702c2281b3fed27ba4c426 DIFF:

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe59d336e75f4: [test] Use host platform specific error message substitution in lit tests… (authored by abhina.sreeskantharajan). Repository: rG

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:226 +llvm::make_range(BaseList.begin(), BaseList.end()), +[](const auto ) -> bool { return I.second; }); + RedDocMD wrote: > vsavchenko wrote: > > I

[PATCH] D88299: [clang-format] Add MacroUnexpander.

sammccall added a comment. Thanks a lot for all the time explaining, I get this at least at a high level now. I have trouble following the ins and outs of the algorithm, but I think I understand most of it and tests cover the rest. Regarding tests: I have trouble reasoning about whether all

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2988 CodeGenFunction::CGFPOptionsRAII FPOptsRAII(*this, E); -// FIXME: for strictfp/IEEE-754 we need to not trap on SNaN here. Value *V = EmitScalarExpr(E->getArg(0)); What

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:322 - Scopes.push_back(""); + std::set Scopes; + Scopes.insert(""); nit:

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

steakhal added a comment. In D93787#2539111 , @vabridgers wrote: > Abandoning this change request in favor of @steakhal 's more comprehensive > change @ https://reviews.llvm.org/D93222 Let me know if that patch-stack resolves your crash. I don't mind

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. > Anastasia added a comment. > In D89909#2536331 > https://reviews.llvm.org/D89909#2536331, @bader wrote: > >> In D89909#2536157 >> https://reviews.llvm.org/D89909#2536157, @Anastasia

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2988 CodeGenFunction::CGFPOptionsRAII FPOptsRAII(*this, E); -// FIXME: for strictfp/IEEE-754 we need to not trap on SNaN here. Value *V =

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

protze.joachim added a comment. For me this patch breaks building llvm. Before this patch, I successfully built llvm using a llvm/10 installation on the system. What is probably special with our llvm installation is that we by default use libc++ rather than libstdc++. FAILED:

[PATCH] D95790: [WIP][clang][cli] Documentation of CompilerInvocation parsing/generation

jansvoboda11 updated this revision to Diff 321103. jansvoboda11 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Polish, document ImpliedByAnyOf and ShouldParse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. In D86295#2519851 , @ASDenysPetrov wrote: > What about this change? Did you make more measurements? IMO it needs more justification and measurement to land it. If my measurement was correct then it would decrease the

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske added a comment. Probably it is not worth to find a better solution. In the case of CloneChecker the range starts and ends on different line that is not possible to print on a single line in the output. This code could work: // Then, crawl the expansion chain for the end of the

<    1   2   3   >