[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 321425. azabaznov added a comment. Adjusted test one more time: moved header functionality into separate test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files:

[PATCH] D96036: [clang][codegen] Remember string used to create llvm::Regex for optimization remarks

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Regular expression patterns passed through the command line are being used to create an

[PATCH] D96016: Release notes: Deprecate the clang-cl /fallback flag (patch for the release/12.x branch)

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. Yes, go ahead and push this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96016/new/ https://reviews.llvm.org/D96016

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

curdeius added a comment. Don't forget to mark comments as Done when... they're done :). Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IndentAccessModifiers** (``bool``) + Makes an indentation level for record (``class``, ``struct``, ``union``)

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. We're getting close :). Comment at: clang/unittests/Format/FormatTest.cpp:19056 +TEST_F(FormatTest, IndentAccessModifiers) { + FormatStyle Style =

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, lhames, rjmccall, teemperor, aprantl. Herald added a subscriber: mgorny. v.g.vassilev requested review of this revision. In http://lists.llvm.org/pipermail/llvm-dev/2020-July/143257.html we have mentioned our plans to make

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. Core LLVM parts LGTM, thanks! I'm going to mark this as accepted, given that the other parts have been reviewed earlier already Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

FarisRehman created this revision. Herald added subscribers: dang, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D96027: [clangd] Trace queue state for each TUScheduler action.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, javed.absar. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The new trace event

[PATCH] D95886: [OpenCL][Docs] Link page explaining tooling for offline compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fb4341519ef: [OpenCL][Docs] Link page explaining tooling for offline compilation. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0fb4341 - [OpenCL][Docs] Link page explaining tooling for offline compilation.

Author: Anastasia Stulova Date: 2021-02-04T14:01:27Z New Revision: 0fb4341519ef3ac06518ba56bb100277d89cdf11 URL: https://github.com/llvm/llvm-project/commit/0fb4341519ef3ac06518ba56bb100277d89cdf11 DIFF: https://github.com/llvm/llvm-project/commit/0fb4341519ef3ac06518ba56bb100277d89cdf11.diff

[PATCH] D95624: [OpenCL][PR48896] Fix default address space in template argument deduction

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c65993be186: [OpenCL] Fix default address space in template argument deduction. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0c65993 - [OpenCL] Fix default address space in template argument deduction.

Author: Anastasia Stulova Date: 2021-02-04T13:51:53Z New Revision: 0c65993be186640463ac90415113474d35889dbb URL: https://github.com/llvm/llvm-project/commit/0c65993be186640463ac90415113474d35889dbb DIFF: https://github.com/llvm/llvm-project/commit/0c65993be186640463ac90415113474d35889dbb.diff

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

ASDenysPetrov added a comment. Herald added a subscriber: nullptr.cpp. Hi, folk! Please, review this tiny patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95799/new/ https://reviews.llvm.org/D95799

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES

[PATCH] D96009: [clangd] Improve name conflict detection

kbobyrev updated this revision to Diff 321398. kbobyrev marked an inline comment as done. kbobyrev added a comment. Use FunctionProtoTypeLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96009/new/ https://reviews.llvm.org/D96009 Files:

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IndentAccessModifiers** (``bool``) + Makes an indentation level for record (``class``, ``struct``, ``union``) Budovi wrote: > curdeius wrote: > > curdeius wrote: > > >

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 321392. Budovi added a comment. Changes: - Added release notes - Changed the documentation (tried to make it more clear in response to the confusion about the added option) Hopefully there is a full context in the patch this time. CHANGES SINCE LAST

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/test/Sema/reserved-identifier.c:49-50 +// FIXME: According to clang declaration context layering, _preserved belongs to +// the translation unit, so we emit a warning. It's unclear that's what the +// standard mandate, but

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry, forgot to stamp this! Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:419 CollectMainFileRefs(CollectMainFileRefs), +

[PATCH] D96017: [clang-check] Add tokens-dump in clang-check.

hokein created this revision. hokein added a reviewer: kbobyrev. hokein requested review of this revision. Herald added a project: clang. It is useful for syntax-tree developement. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96017 Files:

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 321385. azabaznov added a comment. Features remain defined in header for OpenCL C 2.0; adjusted the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files:

[PATCH] D94533: [clang] Add AddClang.cmake to the list of the CMake modules that are installed

This revision was automatically updated to reflect the committed changes. Closed by commit rG62e4f22e297a: [clang] Add AddClang.cmake to the list of the CMake modules that are installed (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 62e4f22 - [clang] Add AddClang.cmake to the list of the CMake modules that are installed

Author: Andrzej Warzynski Date: 2021-02-04T12:38:38Z New Revision: 62e4f22e297ade62fd1e463e7c846df96148ffc4 URL: https://github.com/llvm/llvm-project/commit/62e4f22e297ade62fd1e463e7c846df96148ffc4 DIFF: https://github.com/llvm/llvm-project/commit/62e4f22e297ade62fd1e463e7c846df96148ffc4.diff

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

thakis added a comment. Hi, a whole bunch of cuda-related tests failed on windows with this in (http://45.33.8.238/win/32620/summary.html). Did you run check-clang before committing? I reverted this for now in 4874ff02417916cc9ff994b34abcb5e563056546

[PATCH] D96009: [clangd] Improve name conflict detection

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:343 const auto *Parent = GetSingleParent(DynTypedNode::create(RenamedDecl)); - if (!Parent ||

[PATCH] D96016: Release notes: Deprecate the clang-cl /fallback flag (patch for the release/12.x branch)

hans created this revision. hans added a reviewer: tstellar. hans requested review of this revision. Herald added a project: clang. As discussed in https://lists.llvm.org/pipermail/cfe-dev/2021-January/067524.html The flag has been removed on the main branch in D95876

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D95860#2539453 , @balazske wrote: > Probably it is not worth to find a better solution. In the case of > CloneChecker the range starts and ends

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1513c142f4: [flang][driver] Add forced form flags and -ffixed-line-length (authored by FarisRehman). Repository: rG LLVM Github Monorepo

[clang] 3a1513c - [flang][driver] Add forced form flags and -ffixed-line-length

Author: Faris Rehman Date: 2021-02-04T12:24:15Z New Revision: 3a1513c142f4a1ddb97d882a12c89f90cb2529ac URL: https://github.com/llvm/llvm-project/commit/3a1513c142f4a1ddb97d882a12c89f90cb2529ac DIFF: https://github.com/llvm/llvm-project/commit/3a1513c142f4a1ddb97d882a12c89f90cb2529ac.diff LOG:

[clang] 4874ff0 - Revert "[hip][cuda] Enable extended lambda support on Windows."

Author: Nico Weber Date: 2021-02-04T07:10:46-05:00 New Revision: 4874ff02417916cc9ff994b34abcb5e563056546 URL: https://github.com/llvm/llvm-project/commit/4874ff02417916cc9ff994b34abcb5e563056546 DIFF: https://github.com/llvm/llvm-project/commit/4874ff02417916cc9ff994b34abcb5e563056546.diff

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 321375. ggeorgakoudis added a comment. Fix type for IfCond, formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files:

[PATCH] D95886: [OpenCL][Docs] Link page explaining tooling for offline compilation

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95886/new/ https://reviews.llvm.org/D95886 ___ cfe-commits mailing list

[PATCH] D95886: [OpenCL][Docs] Link page explaining tooling for offline compilation

Anastasia updated this revision to Diff 321369. Anastasia added a comment. Addressed Sven's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95886/new/ https://reviews.llvm.org/D95886 Files: clang/docs/UsersManual.rst Index: clang/docs/UsersManual.rst

[PATCH] D96009: [clangd] Improve name conflict detection

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up on D95925

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:433 PreambleSymbols.update( -Uri, std::make_unique(std::move(*IF->Symbols)), +FilePath ? *FilePath : (consumeError(FilePath.takeError()), Uri), +

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 ___ cfe-commits mailing list

[PATCH] D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang

ostannard created this revision. ostannard added reviewers: serge-sans-paille, jnspaulsson, bzEq, tnfchris. Herald added subscribers: danielkiss, kristof.beyls. ostannard requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows the

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 ___

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder updated this revision to Diff 321349. tbaeder added a comment. Here a version without the local static bools. If this is good to go, I can add some tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 Files:

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov updated this revision to Diff 321348. azabaznov added a comment. Renamed language options and adjusted comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 Files:

[PATCH] D95876: [clang-cl] Remove the /fallback option

This revision was automatically updated to reflect the committed changes. Closed by commit rG6625680a581c: [clang-cl] Remove the /fallback option (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95876/new/

[clang] 6625680 - [clang-cl] Remove the /fallback option

Author: Hans Wennborg Date: 2021-02-04T10:33:16+01:00 New Revision: 6625680a581c5e29c53d9f58d864cc6cd3cd05f6 URL: https://github.com/llvm/llvm-project/commit/6625680a581c5e29c53d9f58d864cc6cd3cd05f6 DIFF: https://github.com/llvm/llvm-project/commit/6625680a581c5e29c53d9f58d864cc6cd3cd05f6.diff

[clang] 225ccf0 - [clang][cli] Command line round-trip for HeaderSearch options

Author: Jan Svoboda Date: 2021-02-04T10:18:34+01:00 New Revision: 225ccf0c50a8d4e03b51f2f09a8e8776328363d8 URL: https://github.com/llvm/llvm-project/commit/225ccf0c50a8d4e03b51f2f09a8e8776328363d8 DIFF: https://github.com/llvm/llvm-project/commit/225ccf0c50a8d4e03b51f2f09a8e8776328363d8.diff

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG225ccf0c50a8: [clang][cli] Command line round-trip for HeaderSearch options (authored by jansvoboda11). Changed prior to commit:

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eec9a380a24: [clangd] Detect rename conflicits within enclosing scope (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 5eec9a3 - [clangd] Detect rename conflicits within enclosing scope

Author: Kirill Bobyrev Date: 2021-02-04T09:45:42+01:00 New Revision: 5eec9a380a24bf0611c676b5da4933949c787a6b URL: https://github.com/llvm/llvm-project/commit/5eec9a380a24bf0611c676b5da4933949c787a6b DIFF:

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:411 + if (const auto *EnclosingFor = Parent->get()) +return CheckCompoundStmt(EnclosingFor->getBody(), NewName); + another case we could add is FunctionDecl, if we rename

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321336. kbobyrev marked an inline comment as done. kbobyrev added a comment. Pass const ref to DynTypedNode in helper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925

[PATCH] D95782: [Syntax] Support condition for IfStmt.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c1a23303de9: [Syntax] Support condition for IfStmt. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6c1a233 - [Syntax] Support condition for IfStmt.

Author: Haojian Wu Date: 2021-02-04T09:15:30+01:00 New Revision: 6c1a23303de9d957cf45ebd04daba862519e393d URL: https://github.com/llvm/llvm-project/commit/6c1a23303de9d957cf45ebd04daba862519e393d DIFF: https://github.com/llvm/llvm-project/commit/6c1a23303de9d957cf45ebd04daba862519e393d.diff

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:334 + DynTypedNodeList Parents(DynTypedNode::create(RenamedDecl)); + auto GetSingleParent = [&](DynTypedNode Node) -> const DynTypedNode * { +Parents = Ctx.getParents(Node);

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321334. kbobyrev marked 5 inline comments as done and an inline comment as not done. kbobyrev added a comment. Fix a couple problems pointed out during the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95782: [Syntax] Support condition for IfStmt.

hokein added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:803 + bool TraverseIfStmt(IfStmt *S) { +bool Result = [&, this]() { sammccall wrote: > is it clear to you what all this code is doing? > It does seem to fit the pattern used

<    1   2