[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tbaeder added a comment. In D96070#2543172 , @mstorsjo wrote: > In particular, if libcxx is built with `LIBCXX_ENABLE_STATIC_ABI_LIBRARY` > enabled, the libcxxabi static library is merged into libc++.a, making static > linking work just fine. I can't

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. I think this patch is in pretty good shape, the outstanding comments are either minor or thoughts about future changes. I am curious what you think of the extension idea for readonly

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5b627aa4fe7: [OpenCL] Introduce new language options for OpenCL keywords. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES

[clang] a5b627a - [OpenCL] Introduce new language options for OpenCL keywords.

Author: Anton Zabaznov Date: 2021-02-05T11:18:48+03:00 New Revision: a5b627aa4fe749f8df0a27fcb1f6fe3b59a21e09 URL: https://github.com/llvm/llvm-project/commit/a5b627aa4fe749f8df0a27fcb1f6fe3b59a21e09 DIFF:

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 321673. yubing added a comment. Rebase and fix the bug in amx_api.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. Herald added a subscriber: nullptr.cpp. In D92639#2505163 , @ASDenysPetrov wrote: > @vsavchenko > >> F14534708: report-6ea17d.html > > I checked it in IE. It doesn't draw arrows.

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing updated this revision to Diff 321675. yubing added a comment. Rebase and add a testcase for dpbf16ps intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files:

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:166 + ArrowMap(unsigned Size) : Base(Size, 0) {} + unsigned getTotalNumberOfArrows() const { return at(0); } +}; ASDenysPetrov wrote: > # Whether `size()` is not

[PATCH] D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS

chill added inline comments. Comment at: llvm/docs/LangRef.rst:1220 +``alignstack()`` +This indicates the alignment that should be considered by the backend when +assigning this parameter to a stack slot during calling convention rnk wrote: > This seems

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

joerg added a comment. I can't speak for other systems, but forcing libpthread to be linked is in general not desirable as it creates a non-trivial runtime cost, especially when is not used. That's still a pretty common use case of C++. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added a comment. In D95877#2542578 , @RedDocMD wrote: > @vsavchenko, after some experimentation, I found out that handling > reinterpret_cast will be a real pain. Consider the following: > > struct Base { > int field; > }; > >

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

LuoYuanke added a comment. Would you rebase to see if the lit test failure is related to this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 ___

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

mstorsjo added a comment. In D96070#2544297 , @tbaeder wrote: > In D96070#2543172 , @mstorsjo wrote: > >> In particular, if libcxx is built with `LIBCXX_ENABLE_STATIC_ABI_LIBRARY` >> enabled, the libcxxabi static

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:476 + if (!Kind || (Result && Kind != Result)) +continue; + Result = Kind; nridge wrote: > This is a change of behaviour from before, in the case where

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added a comment. Strange. llvm/test/CodeGen/X86/AMX/amx-low-intrinsics.ll can pass in my local machine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594

[PATCH] D96000: Don't emit coverage mapping for excluded functions

phosek updated this revision to Diff 321670. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96000/new/ https://reviews.llvm.org/D96000 Files: clang/lib/CodeGen/CodeGenPGO.cpp clang/test/CodeGen/profile-filter.c Index:

[PATCH] D96000: Don't emit coverage mapping for excluded functions

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:27 +// EXCLUDE: @__covrec_{{[0-9A-F]+}}u = linkonce_odr hidden constant <{ i64, i32, i64, i64, [{{.*}} x i8] }> <{ {{.*}} }>, section "__llvm_covfun" +//

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi planned changes to this revision. Budovi added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19056 +TEST_F(FormatTest, IndentAccessModifiers) { + FormatStyle Style = getLLVMStyle(); + Style.AllowShortEnumsOnASingleLine = false;

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:210 + "repeated elements"); +BaseSpecSeen.insert(BaseType); } Containers like `map` and `set` usually return a pair for `insert`, where the second

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added a comment. @NoQ > Ugh, sorry, no, that's `evalCast()`. Like `evalBinOp()` etc. My bad. Can we > also use `evalCast()`? Finally :-) Now we can use `evalCast()` instead of `CastRetrievedVal()`. It would be nice if you could look at D96090 .

[PATCH] D96112: [Syntax] No crash on OpaqueValueExpr.

hokein created this revision. hokein added a reviewer: kbobyrev. hokein requested review of this revision. Herald added a project: clang. OpaqueValueExpr doesn't correspond to the concrete syntax, it has invalid source location, ignore them. Repository: rG LLVM Github Monorepo

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added a comment. In D93298#253 , @asb wrote: > I started reviewing this alongside the specification in > https://github.com/riscv/riscv-zfinx/blob/master/Zfinx_spec.adoc. At the time > of writing, it seems to define "zfinx" but not

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov updated this revision to Diff 321693. ASDenysPetrov added a comment. Updated. Rolled the fix over the evalCast refactoring. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89055/new/ https://reviews.llvm.org/D89055 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

steakhal added a comment. Please, consider removing D95799 from the parent revisions if that is not a hard requirement of this patch. It would be awesome to land your patches on dealing with cast problems in the close future. Dealing with floating-point values

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17996 +format(ForSourceLong, Style)); +} + tiagoma wrote: > tiagoma wrote: > > njames93 wrote: > > > MyDeveloperDay wrote: > > > > MyDeveloperDay wrote: > > > > >

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske updated this revision to Diff 321685. balazske added a comment. Added explanation to source code. Added more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95860/new/ https://reviews.llvm.org/D95860 Files:

[PATCH] D96113: Add test coverage for hasParent() usage

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96113 Files:

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:38 +typedef uint cl_mem_fence_flags; +#define CLK_GLOBAL_MEM_FENCE 0x02 + Should we add this conditionally if the base header is not included? In the subsequent

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

asb added a comment. I started reviewing this alongside the specification in https://github.com/riscv/riscv-zfinx/blob/master/Zfinx_spec.adoc. At the time of writing, it seems to define "zfinx" but not "zfhinx" and "zfdinx" as seem to be used in this patch. I think intent is that rv32ifd_zfinx

[clang-tools-extra] 91698fe - [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

Author: Aleksandr Platonov Date: 2021-02-05T13:35:07+03:00 New Revision: 91698fe45f6068c5a6f8284e5e8e19a8d89dfea8 URL: https://github.com/llvm/llvm-project/commit/91698fe45f6068c5a6f8284e5e8e19a8d89dfea8 DIFF:

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91698fe45f60: [clangd] Take into account what is in the index (symbols, references, etc.) at… (authored by ArcsinX). Repository: rG LLVM Github

[PATCH] D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang

ostannard updated this revision to Diff 321689. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96007/new/ https://reviews.llvm.org/D96007 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/stack-clash-protection.c

[PATCH] D96050: [OpenCL] Do not enforce ASTContext for OCL2Qual

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Cool! Makes sense, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96050/new/ https://reviews.llvm.org/D96050

[clang-tools-extra] edc8f0b - TypeMismatchCheck.cpp - fix Wdocumentation warning. NFCI.

Author: Simon Pilgrim Date: 2021-02-05T10:57:39Z New Revision: edc8f0b407a1ca5373f72af6a5ed658929603be9 URL: https://github.com/llvm/llvm-project/commit/edc8f0b407a1ca5373f72af6a5ed658929603be9 DIFF: https://github.com/llvm/llvm-project/commit/edc8f0b407a1ca5373f72af6a5ed658929603be9.diff

[PATCH] D93003: [libunwind] LIBUNWIND_HERMETIC_STATIC_LIBRARY fixes

rprichard updated this revision to Diff 321701. rprichard added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just fix ELF and leave Mach-O as-is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added a subscriber: kristof.beyls. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Having to match on the typeLoc in AsIs mode is

[PATCH] D96043: Treat opencl_unroll_hint subject errors as semantic rather than parse errors

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96043/new/ https://reviews.llvm.org/D96043

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

steakhal added a comment. void clang_analyzer_dumpi(int); void clang_analyzer_dumpf(float); void clang_analyzer_dumpip(int*); void clang_analyzer_dumpfp(float*); void SymbolCast_of_float_type_aux(int *p) { *p += 1; clang_analyzer_dumpi(*p); // (Previously): Unknown ->

[PATCH] D93003: [libunwind] LIBUNWIND_HERMETIC_STATIC_LIBRARY fixes

rprichard added a comment. After renaming the CMake option, CMake prints a warning if I set the old option: CMake Warning: Manually-specified variables were not used by the project: LIBUNWIND_HERMETIC_STATIC_LIBRARY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added a comment. Herald added subscribers: StephenFan, vkmr. In D92715#2520925 , @craig.topper wrote: > I wonder if these types should be prefixed with "__clang_" like AArch64 tuple > types? It seems only AArch64 tuple types have "__clang_"

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. In D92715#2544178 , @HsiangKai wrote: > In D92715#2520925 , @craig.topper > wrote: > >> I wonder if these types should be prefixed with "__clang_" like AArch64 >> tuple types? > > It

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

nikic added a comment. Herald added a reviewer: jansvoboda11. @guiand Do you plan to continue working on this patch? If not, I would try to finalize it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand added a comment. Changing the mechanism to explicit opt-in seems like a good idea, and bypasses the test issues. If everyone agrees about proceeding with this, I can fix up this patch within the next couple days and we can hopefully wrap this up! Repository: rG LLVM Github Monorepo

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a reviewer: sgraenitz. teemperor added a comment. Another round of comments. Also a general note that applies to a bunch of places, if you specify the function names in comments when calling a function, you have to add a trailing `=` so that clang-tidy can actually check this

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 321714. RedDocMD marked an inline comment as done. RedDocMD added a comment. Added TODO for reinterpret_cast, moved assertion code to its own block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/

[clang-tools-extra] d1978fa - [clangd] Deduplicate scopes in IncludeFixer queries

Author: Kadir Cetinkaya Date: 2021-02-05T14:02:50+01:00 New Revision: d1978fa4bf0d7da0b3cd88879e9411467edcb01f URL: https://github.com/llvm/llvm-project/commit/d1978fa4bf0d7da0b3cd88879e9411467edcb01f DIFF:

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1978fa4bf0d: [clangd] Deduplicate scopes in IncludeFixer queries (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95942/new/

[PATCH] D96126: [clangd] Integrate BSP with ClangdServer

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. In D93298#2544775 , @asb wrote: > In D93298#2544459 , @StephenFan > wrote: > >> According to @jrtc27 's review that is >> "As for Zfinx itself, well, the idea is fine, but I really detest

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. @aaron.ballman Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 ___ cfe-commits mailing list

[PATCH] D95951: [OpenCL] Add cl_khr_subgroup_non_uniform_arithmetic to TableGen BIFs

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Comment at: clang/lib/Sema/OpenCLBuiltins.td:1529 + foreach name = ["reduce_", "scan_exclusive_", "scan_inclusive_"] in { +foreach op = ["add",

[clang] 3fe3946 - [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly

Author: Akira Hatanaka Date: 2021-02-05T05:55:18-08:00 New Revision: 3fe3946d9a958b7af6130241996d9cfcecf559d4 URL: https://github.com/llvm/llvm-project/commit/3fe3946d9a958b7af6130241996d9cfcecf559d4 DIFF:

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. This check, more specifically the fixes, seem quite dangerous. Changing function signatures is highly likely to cause compilation issues. For a starters this check doesn't

[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5173 + if (auto *PLE = llvm::dyn_cast(Base)) +Base = PLE->getExpr(PLE->getNumExprs() - 1); + if (OtherOpBase) {

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. In D94880#2544895 , @aaron.ballman wrote: > In D94880#2544873 , @steveire wrote: > >> That page collapses the documentation for each matcher, as you know. >> >> You need to expand the

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because it no longer relies on finding implicit

[PATCH] D96140: [clang-tidy] Simplify inefficient algorithm check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The normalization of matchers means that this now

[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95935/new/ https://reviews.llvm.org/D95935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96124: [clangd] Introduce BuildSystem

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, mgorny. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Interface for BuildSystem

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

steveire added a comment. @Eugene.Zelenko Why did you remove me from the reviewers list? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96082/new/ https://reviews.llvm.org/D96082 ___ cfe-commits mailing

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added a comment. In D93298#2544775 , @asb wrote: > In D93298#2544459 , @StephenFan > wrote: > >> According to @jrtc27 's review that is >> "As for Zfinx itself, well, the idea is fine, but I really

[PATCH] D95951: [OpenCL] Add cl_khr_subgroup_non_uniform_arithmetic to TableGen BIFs

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1529 + foreach name = ["reduce_", "scan_exclusive_", "scan_inclusive_"] in { +foreach op = ["add", "min", "max", "mul"] in { + def : Builtin<"sub_group_non_uniform_" # name # op, [AGenType1,

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 321724. Budovi added a comment. Changes: - Added a unit test with a different `IndentWidth` - Removed a unit test that contained a class nested in function; didn't add much IMHO - Added brief comments about potentially non-obvious behaviour to some tests

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:180 +bool noRepeatedElements( +const llvm::ImmutableList ) { nit: functions represent actions, in languages verbs act the same way, so it's recommended to

[PATCH] D96131: [clang-tidy] Simplify function complexity check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, lebedev.ri, xazax.hun. Herald added a reviewer: lebedev.ri. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D96135: [clang-tidy] Simplify braced init check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The normalization of matchers means that this now

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:180 +bool noRepeatedElements( +const llvm::ImmutableList ) { vsavchenko wrote: > nit: functions represent actions, in

[PATCH] D96139: [clang-tidy] Simplify inaccurate erase check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The normalization of matchers means that this now

[PATCH] D96027: [clangd] Trace queue state for each TUScheduler action.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1054 Requests.push_back({std::move(Task), std::string(Name), steady_clock::now(), -

[clang] 447dc85 - Revert "[PowerPC] [Clang] Enable float128 feature on P9 by default"

Author: Qiu Chaofan Date: 2021-02-05T20:33:56+08:00 New Revision: 447dc856b243b99ce70019ba1187c39746f4e0e9 URL: https://github.com/llvm/llvm-project/commit/447dc856b243b99ce70019ba1187c39746f4e0e9 DIFF: https://github.com/llvm/llvm-project/commit/447dc856b243b99ce70019ba1187c39746f4e0e9.diff

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel updated this revision to Diff 321715. LukasHanel added a comment. Address review comments, fix C++ unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96082/new/ https://reviews.llvm.org/D96082 Files:

[PATCH] D96125: [clangd] Diagfixer for layering violations

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Introduce a diagfixer that can update

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman added a comment. In D94880#2544782 , @steveire wrote: > @aaron.ballman Any further comments? Thank you for pinging, this fell off my queue! The only further comments I have about about my confusion with `with`. In D94880#2536485

[clang] 2fbbb18 - Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly"

Author: Akira Hatanaka Date: 2021-02-05T06:00:05-08:00 New Revision: 2fbbb18c1dbeb124dfc3c2aebae97d4780ff9bd6 URL: https://github.com/llvm/llvm-project/commit/2fbbb18c1dbeb124dfc3c2aebae97d4780ff9bd6 DIFF:

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. That page collapses the documentation for each matcher, as you know. You need to expand the docs for `mapAnyOf`, as you know. You seem to know all this. What's the remaining issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 42e0189 - [OpenCL] Add cl_khr_subgroup_shuffle* to TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-05T14:16:13Z New Revision: 42e018997b23af74eee4acdc0388ae44b36d69f9 URL: https://github.com/llvm/llvm-project/commit/42e018997b23af74eee4acdc0388ae44b36d69f9 DIFF: https://github.com/llvm/llvm-project/commit/42e018997b23af74eee4acdc0388ae44b36d69f9.diff

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. I believe that the MCJIT failures are due to bug https:/bugs.llvm.org/show_bug.cgi?id=24978 rather than a problem in the Scudo port so I have added details of how I hit it to that bugzilla and opened two reviews to get this landed:

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rsmith wrote: > rjmccall wrote: > > rsmith wrote:

[clang] 45ccfd9 - Treat opencl_unroll_hint subject errors as semantic rather than parse errors

Author: Aaron Ballman Date: 2021-02-05T07:20:41-05:00 New Revision: 45ccfd9c9d0311371a8217c15c2ef3ba969a0aff URL: https://github.com/llvm/llvm-project/commit/45ccfd9c9d0311371a8217c15c2ef3ba969a0aff DIFF: https://github.com/llvm/llvm-project/commit/45ccfd9c9d0311371a8217c15c2ef3ba969a0aff.diff

[PATCH] D96043: Treat opencl_unroll_hint subject errors as semantic rather than parse errors

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review! I've commit in 45ccfd9c9d0311371a8217c15c2ef3ba969a0aff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop created this revision. russell.gallop added reviewers: cryptoad, aganea. Herald added subscribers: phosek, mgorny. russell.gallop requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Based on

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD marked 2 inline comments as done. RedDocMD added a comment. @vsavchenko , does it look okay now? Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:27 #include +#include #include vsavchenko wrote: > We don't need this anymore :) Wow,

[PATCH] D96123: [clangd] Expose actOnAllPArentDirectories helper

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Will be used in other components that need

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel marked 9 inline comments as done. LukasHanel added a comment. Thanks for the review! Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-useless-return-value.rst:43 +int ret = 0; +return; + } Eugene.Zelenko wrote: > Return is

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

asb added a comment. In D93298#2544459 , @StephenFan wrote: > According to @jrtc27 's review that is > "As for Zfinx itself, well, the idea is fine, but I really detest the way > it's being done as an extension to F/D/Zfh. Running F code on an FZfh

[PATCH] D96016: Release notes: Deprecate the clang-cl /fallback flag (patch for the release/12.x branch)

hans closed this revision. hans added a comment. Pushed as 72f12467ded52160d52025e13a6217f00fe25f68 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96016/new/

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fe3946d9a95: [ObjC][ARC] Use operand bundle clang.arc.rv instead of explicitly (authored by ahatanak). Repository: rG LLVM Github Monorepo

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:38 +typedef uint cl_mem_fence_flags; +#define CLK_GLOBAL_MEM_FENCE 0x02 + Anastasia wrote: > Should we add this conditionally if the base header is not included? > >

[PATCH] D96130: Correct swift_bridge duplicate attribute warning logic

aaron.ballman created this revision. aaron.ballman added a reviewer: compnerd. aaron.ballman requested review of this revision. Herald added a project: clang. The `swift_bridge` attribute warns when the attribute is applied multiple times to the same declaration. However, it warns about the

[clang-tools-extra] 2cba22c - [clang-tidy] Simplify implementation of container-size-empty

Author: Stephen Kelly Date: 2021-02-05T14:03:41Z New Revision: 2cba22c23a769103f4f0c31968620a488f13b625 URL: https://github.com/llvm/llvm-project/commit/2cba22c23a769103f4f0c31968620a488f13b625 DIFF: https://github.com/llvm/llvm-project/commit/2cba22c23a769103f4f0c31968620a488f13b625.diff

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG538677abbde4: Add an API to simplify setting TraversalKind in clang-tidy matchers (authored by stephenkelly). Changed prior to commit:

[PATCH] D91303: [clang-tidy] readability-container-size-empty: simplify implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cba22c23a76: [clang-tidy] Simplify implementation of container-size-empty (authored by stephenkelly). Herald added a subscriber: nullptr.cpp.

[clang] 538677a - Add an API to simplify setting TraversalKind in clang-tidy matchers

Author: Stephen Kelly Date: 2021-02-05T14:03:40Z New Revision: 538677abbde4e74795d0bc21a77a3d263893c37d URL: https://github.com/llvm/llvm-project/commit/538677abbde4e74795d0bc21a77a3d263893c37d DIFF: https://github.com/llvm/llvm-project/commit/538677abbde4e74795d0bc21a77a3d263893c37d.diff

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman accepted this revision. aaron.ballman added a comment. In D94880#2544873 , @steveire wrote: > That page collapses the documentation for each matcher, as you know. > > You need to expand the docs for `mapAnyOf`, as you know. > > You seem to

[clang] 4a64d8f - [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly

Author: Akira Hatanaka Date: 2021-02-05T06:09:42-08:00 New Revision: 4a64d8fe392449b205e59031aad5424968cf7446 URL: https://github.com/llvm/llvm-project/commit/4a64d8fe392449b205e59031aad5424968cf7446 DIFF:

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

thakis added a comment. This breaks check-clang everywhere: http://45.33.8.238/linux/38812/step_7.txt Please run tests before landing. Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't issue a warning from within a template

[clang] 4cbea09 - [ASTMatchers] Fix segfault when Action is nullptr

Author: Stephen Kelly Date: 2021-02-05T15:17:13Z New Revision: 4cbea09431cd7d976770348d8e3d67cf1d3637e8 URL: https://github.com/llvm/llvm-project/commit/4cbea09431cd7d976770348d8e3d67cf1d3637e8 DIFF: https://github.com/llvm/llvm-project/commit/4cbea09431cd7d976770348d8e3d67cf1d3637e8.diff

  1   2   >