[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

balazske updated this revision to Diff 323896. balazske marked 3 inline comments as done. balazske added a comment. Fixed problems with documentation and improved test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96719/new/

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:106 +<< "for source file " << FileName; +EXPECT_EQ(Manager.getIncludePriority("", true), 0) +<< "for source file " << FileName; I would also

[PATCH] D96730: [clangd] Modules can have a public API. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdServer.h:349 + ModuleSet *Modules; const GlobalCompilationDatabase nit: ` = nullptr`

[PATCH] D96726: [clangd] Give modules access to filesystem, scheduler, and index.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/Module.h:1 +//===--- Module.h - Plugging features into clangd -*-C++-*-===// +//

[PATCH] D96755: [clangd] Shutdown sequence for modules, and doc threading requirements

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This allows modules to do work on

[PATCH] D96755: [clangd] Shutdown sequence for modules, and doc threading requirements

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:180 +for (auto : *Modules) + Mod.blockUntilIdle(Deadline::infinity()); + } why is our contract saying that just calling `stop` is not enough? i think clangdserver

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks so much for pushing this through, it looks great. In D92290#2564656 , @nridge wrote: > I haven't refactored the tests to pass in a null

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

kadircet added a comment. mostly LG. some comments around the way we set up outgoinmethod stubs though. Comment at: clang-tools-extra/clangd/LSPBinder.h:88 + template + void outgoingMethod(llvm::StringLiteral Method, + OutgoingMethod ) {

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 323962. massberg added a comment. Change option name, improve description and minor fixes. - Change name FlagBasicIncrements to DescribeBasicIncrements. - Improve description of this option and added an example. - Minor code fixes. Repository: rG LLVM

[PATCH] D96761: [clang][cli] Generate -f[no-]finite-loops arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG32389346ed83: [clang][cli] Generate -f[no-]finite-loops arguments (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96761/new/

[clang] 3238934 - [clang][cli] Generate -f[no-]finite-loops arguments

Author: Jan Svoboda Date: 2021-02-16T14:39:20+01:00 New Revision: 32389346ed83e14b7a9bd3a31a96181c6a1cdb5e URL: https://github.com/llvm/llvm-project/commit/32389346ed83e14b7a9bd3a31a96181c6a1cdb5e DIFF: https://github.com/llvm/llvm-project/commit/32389346ed83e14b7a9bd3a31a96181c6a1cdb5e.diff

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

jhenderson added a comment. In D95246#2565351 , @abhina.sreeskantharajan wrote: > Do you know what is different between your environments which is causing the > spelling to be capitalized? This might help me determine how to fix the > current host

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

pdhaliwal added a comment. This does fixes the save-temps but only when -o is not specified. If -o is specified the name of host object file and host-wrapper object file (second last phase) is same, which fails the linker. This does not seem to be related to this patch. Repository: rG LLVM

[clang-tools-extra] 40cc63e - [clangd] Modules can have a public API. NFC

Author: Sam McCall Date: 2021-02-16T15:22:57+01:00 New Revision: 40cc63ea6eec7874d3a358f9fa549ef2f6543512 URL: https://github.com/llvm/llvm-project/commit/40cc63ea6eec7874d3a358f9fa549ef2f6543512 DIFF: https://github.com/llvm/llvm-project/commit/40cc63ea6eec7874d3a358f9fa549ef2f6543512.diff

[PATCH] D96730: [clangd] Modules can have a public API. NFC

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG40cc63ea6eec: [clangd] Modules can have a public API. NFC (authored by sammccall). Changed prior to commit:

[PATCH] D96784: Pass the cmdline aapcs bitfield options to cc1

stuij created this revision. Herald added a subscriber: kristof.beyls. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following commits added commandline arguments to control following the Arm Procedure Call Standard for certain

[clang] 3c8bf29 - Reduce the number of attributes attached to each function

Author: serge-sans-paille Date: 2021-02-16T16:19:54+01:00 New Revision: 3c8bf29f14e45cdf4c5dc5edcb3bb2f02cc9f394 URL: https://github.com/llvm/llvm-project/commit/3c8bf29f14e45cdf4c5dc5edcb3bb2f02cc9f394 DIFF:

[PATCH] D96400: Reduce the number of attributes attached to each function

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c8bf29f14e4: Reduce the number of attributes attached to each function (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

jdoerfert added a comment. In D96769#2565751 , @pdhaliwal wrote: > emit-llvm-bc does not correctly solve the problem. It works because [input, > compile, assemble, backend] actions collapse to a single action by driver. > This single command handles

[clang] ed86328 - [clang][cli] Add explicit round-trip test

Author: Jan Svoboda Date: 2021-02-16T14:56:26+01:00 New Revision: ed86328515888b762277a118773b2f41b106d016 URL: https://github.com/llvm/llvm-project/commit/ed86328515888b762277a118773b2f41b106d016 DIFF: https://github.com/llvm/llvm-project/commit/ed86328515888b762277a118773b2f41b106d016.diff

[PATCH] D96705: [clang][cli] Add explicit round-trip test

This revision was automatically updated to reflect the committed changes. Closed by commit rGed8632851588: [clang][cli] Add explicit round-trip test (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96705/new/

[PATCH] D96716: [flang][driver] Add debug dump options

awarzynski added a comment. I think that this patch does a great job demonstrating the use of frontend actions and how _action_ compiler flags map to them. Given how `Fortran::semantics::Semantics` are defined and created, I think that adding _semantics_ as a member variable to

[PATCH] D96726: [clangd] Give modules access to filesystem, scheduler, and index.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6e52d8fa721: [clangd] Give modules access to filesystem, scheduler, and index. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D96726?vs=323809=323992#toc Repository: rG

[clang-tools-extra] b6e52d8 - [clangd] Give modules access to filesystem, scheduler, and index.

Author: Sam McCall Date: 2021-02-16T15:30:08+01:00 New Revision: b6e52d8fa7217db319e240854a9d8ff3133d02b6 URL: https://github.com/llvm/llvm-project/commit/b6e52d8fa7217db319e240854a9d8ff3133d02b6 DIFF: https://github.com/llvm/llvm-project/commit/b6e52d8fa7217db319e240854a9d8ff3133d02b6.diff

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D96789: [OpenCL] Move printf declaration to opencl-c-base.h

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Supporting `printf` with `-fdeclare-opencl-builtins` would require special handling

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2562097 , @Meinersbur wrote: > Who is going to commit? I can commit it as soon as you accepted it if you don't mind of course. Comment at: clang/include/clang/AST/StmtOpenMP.h:651-677 + static bool

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/LSPBinder.h:88 + template + void outgoingMethod(llvm::StringLiteral Method, + OutgoingMethod ) { kadircet wrote: > well this

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! You may wanna wait for someone more knowledgeable about CTU to give it another accept. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94673/new/

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg marked 4 inline comments as done. massberg added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.h:24-26 +/// * `FlagBasicIncrements`- if set to `true`, additional to flagging +//

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

aaron.ballman added a comment. In D96082#2561806 , @steveire wrote: > In D96082#2550468 , @LukasHanel > wrote: > >> In D96082#2549943 , @steveire wrote: >> >>> In

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. In D95246#2564137 , @ASDenysPetrov wrote: > This patch causes fails in a bunch of test files. When I roll it back, it > passes. > Below you can see fail output of `ubsan-blacklist-vfs.c` and >

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

ikudrin created this revision. ikudrin added reviewers: ayermolo, dblaikie, aprantl, MaskRay. ikudrin added projects: LLVM, clang, debug-info. Herald added subscribers: jansvoboda11, dang. ikudrin requested review of this revision. The option was added in D90507

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

jdoerfert added a comment. Could you somewhere explain why emit-llvm-bc is not enough? This simply reverts its introduction without saying why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96769/new/ https://reviews.llvm.org/D96769

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov added a comment. Thanks for review. Last change is a small fix for if clang-tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 ___

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:169 "bugprone-terminating-continue"); +CheckFactories.registerCheck( +"bugprone-thread-canceltype-asynchronous"); I think this

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini. Herald added subscribers: dexonsmith, ebevhan, yaxunl. Herald added a reviewer: jansvoboda11. Anastasia requested review of this revision. Files compiled with C++ for OpenCL can have a distinct file extension -

[PATCH] D96777: [clang][driver] Set the input type to Fortran when reading from stdin

awarzynski created this revision. Herald added subscribers: usaxena95, kadircet. Herald added a reviewer: sscalpone. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This patch makes sure that for the following

[PATCH] D96690: [clangd] Treat paths case-insensitively depending on the platform

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, thank you! Comment at: clang-tools-extra/clangd/support/Path.cpp:22 -bool pathEqual(PathRef A, PathRef B) { -#if defined(_WIN32) || defined(__APPLE__) -

[PATCH] D87146: [analyzer] Implement shared semantics checks for XNU functions in PthreadLockChecker

steakhal added a comment. Could you please give a few links to some documentation about the functions you are trying to model? Is https://developer.apple.com/library/archive/documentation/Darwin/Conceptual/KernelProgramming/synchronization/synchronization.html a legitimate resource for this?

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

sgraenitz added a subscriber: anarazel. sgraenitz added a comment. Hi Vassil, thanks for upstreaming this! I think it goes into a good direction. The last time I looked at the Cling sources downstream, it was based on LLVM release 5.0. The IncrementalJIT class was based on what we call OrcV1

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall updated this revision to Diff 324012. sammccall marked an inline comment as done. sammccall added a comment. rebase & address comments (except bind out API, still to come) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

pdhaliwal added a comment. emit-llvm-bc does not correctly solve the problem. It works because [input, compile, assemble, backend] actions collapse to a single action by driver. This single command handles emit-llvm-bc properly. But when save-temps is specified, this collapsing does not happen

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. Perhaps paraphrase that and add it to the commit message (which is derived from the text at the top of this page) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96769/new/ https://reviews.llvm.org/D96769

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. > either way I'm a dead end — I don't consider myself authorized to "accept" > Clang changes. > You're still going to have to attract the attention of someone with the > authority

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev marked 2 inline comments as done. ABataev added a comment. In D86119#2562187 , @grokos wrote: > In D86119#2561163 , @abhinavgaba > wrote: > >> Thanks for the changes, Alexey! I tried the patch locally, and

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

svenvh added inline comments. Comment at: clang/docs/OpenCLSupport.rst:67 +All the options in this section are frontend-only and therefore if used +with regular clang driver they require frontend forwarding e.g. ``-cc1`` +or ``-Xclang``.

[PATCH] D96561: [clang-tidy] add -use-color option to clang-tidy-diff.py

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96561/new/ https://reviews.llvm.org/D96561

[PATCH] D96690: [clangd] Treat paths case-insensitively depending on the platform

kadircet updated this revision to Diff 323997. kadircet marked an inline comment as done. kadircet added a comment. - s/pathIsAncestor/pathStartsWith - Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96690/new/

[PATCH] D96690: [clangd] Treat paths case-insensitively depending on the platform

kadircet added inline comments. Comment at: clang-tools-extra/clangd/support/Path.cpp:22 -bool pathEqual(PathRef A, PathRef B) { -#if defined(_WIN32) || defined(__APPLE__) - return A.equals_lower(B); -#else - return A == B; -#endif +bool pathIsAncestor(PathRef Ancestor,

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov updated this revision to Diff 324004. azabaznov added a comment. Fix clang-tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D96195: [HIP] Fix managed variable linkage

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96195/new/ https://reviews.llvm.org/D96195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D96784: Pass the cmdline aapcs bitfield options to cc1

DavidSpickett added a comment. Looks ok but needs tests. See clang/test/Driver for examples of checking -### output. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1525 +void AddAAPCSVolatileBitfieldArgs(const ArgList , ArgStringList ) { + if

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

balazske updated this revision to Diff 324013. balazske added a comment. Adding missed alias to CERT module. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96719/new/ https://reviews.llvm.org/D96719 Files:

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:54 +public: + std::unique_ptr semantics_; }; awarzynski wrote: > Do we need to expose it? Shouldn't this be private? It will not compile if the variable is private as

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

mantognini added a comment. I feel this would be a valuable addition, indeed. Only a minor question from me. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) I'm not

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge updated this revision to Diff 323906. nridge added a comment. address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92290/new/ https://reviews.llvm.org/D92290 Files: clang-tools-extra/clangd/ASTSignals.cpp

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3342-3346 inline std::error_code parseConfiguration(StringRef Config, FormatStyle *Style, bool AllowUnknownOptions = false) { return

[clang] 96d229c - [flang][driver] Add options for unparsing

Author: Andrzej Warzynski Date: 2021-02-16T09:32:51Z New Revision: 96d229c9abdfb2836e18a554bfb63b5d52aeebfa URL: https://github.com/llvm/llvm-project/commit/96d229c9abdfb2836e18a554bfb63b5d52aeebfa DIFF: https://github.com/llvm/llvm-project/commit/96d229c9abdfb2836e18a554bfb63b5d52aeebfa.diff

[PATCH] D96483: [flang][driver] Add options for unparsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96d229c9abdf: [flang][driver] Add options for unparsing (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

poelmanc added a comment. Thanks for the speedy reply and the great tool. With appropriate Regex and Priority settings, `IncludeCategories` worked flawlessly for me aside from not identifying the main header. Treating `#include "foo/bar/baz.h"` as the main header in file `bar/random/baz.h`

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman updated this revision to Diff 323929. FarisRehman added a comment. Rebase off main Rebase off main and update some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96716/new/ https://reviews.llvm.org/D96716 Files:

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10826ea7b1c1: [flang][driver] Add extension options and -finput-charset (authored by FarisRehman). Changed prior to commit:

[clang] 10826ea - [flang][driver] Add extension options and -finput-charset

Author: Faris Rehman Date: 2021-02-16T11:27:06Z New Revision: 10826ea7b1c12c2afe421448996f98ed66869020 URL: https://github.com/llvm/llvm-project/commit/10826ea7b1c12c2afe421448996f98ed66869020 DIFF: https://github.com/llvm/llvm-project/commit/10826ea7b1c12c2afe421448996f98ed66869020.diff LOG:

[clang] 13f4448 - [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

Author: Denys Petrov Date: 2021-02-16T14:30:51+02:00 New Revision: 13f4448ae7db1a477ec2d48776e46415a3401314 URL: https://github.com/llvm/llvm-project/commit/13f4448ae7db1a477ec2d48776e46415a3401314 DIFF: https://github.com/llvm/llvm-project/commit/13f4448ae7db1a477ec2d48776e46415a3401314.diff

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

This revision was automatically updated to reflect the committed changes. Closed by commit rG13f4448ae7db: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

MyDeveloperDay added a comment. I think I'd be concern about the `` case (lets ignore the fact that I should be including so imagine I'm writing a string class and I have string.cpp including "string.h" but as part of my string class because I'm somehow extending std::string #include

[PATCH] D96761: [clang][cli] Generate -f[no-]finite-loops arguments

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, fhahn. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch generates the `-f[no-]finite-loops` arguments from

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

stefanp accepted this revision as: stefanp. stefanp added a comment. This revision is now accepted and ready to land. I just have one final nit otherwise LGTM. Feel free to fix that on commit. Please wait a couple of days and see if @MaskRay has any further comments. Comment

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

pdhaliwal created this revision. pdhaliwal added reviewers: jdoerfert, JonChesterfield, ronlieb. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1,

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27 + // expected-error@-3 0+{{no matching function for call to 'barrier'}} + //

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: njames93, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is

[PATCH] D96761: [clang][cli] Generate -f[no-]finite-loops arguments

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96761/new/ https://reviews.llvm.org/D96761

[PATCH] D96690: [clangd] Treat paths case-insensitively depending on the platform

kadircet updated this revision to Diff 323951. kadircet added a comment. Herald added subscribers: ormris, mgorny. - Don't case fold stored strings, or the ones passing interface boundaries - Define a `pathIsAncestor` helper instead and use that for comparison of MountPoint - Expose a

[PATCH] D96725: [clang-tidy] Fix modernize-use-using in extern C code

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-using.cpp:305 }; + +extern "C" { steveire wrote: > njames93 wrote: > > steveire wrote: > > > Can you add tests for typedefs in other scopes like > > > >

[clang-tools-extra] 9510b09 - [clangd] Factor out the heuristic resolver code into its own class

Author: Nathan Ridge Date: 2021-02-16T04:10:52-05:00 New Revision: 9510b09402659e6ba6e29b9caf0504c89bc72871 URL: https://github.com/llvm/llvm-project/commit/9510b09402659e6ba6e29b9caf0504c89bc72871 DIFF: https://github.com/llvm/llvm-project/commit/9510b09402659e6ba6e29b9caf0504c89bc72871.diff

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9510b0940265: [clangd] Factor out the heuristic resolver code into its own class (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kadircet added a comment. (sorry for forgetting about this) Comment at: clang-tools-extra/clangd/CodeComplete.cpp:450 +if (Snippet->front() == '<') + return Snippet->substr(0, Snippet->find('(')); +return ""; what if we have `(` in the

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

njames93 added a comment. I did have another plan for a different way to go about this, not sure if its really any better though. It involved building a vector of the edits the config would apply to its parent. Then after the parent is parsed just applying those edits. It results in only 1 pass

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov added a comment. Ping. By the way I realize I may not have put the new tests in the appropriate place. Any guidance there welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95409/new/ https://reviews.llvm.org/D95409

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4231 +def flarge_sizes : Flag<["-"],"flarge-sizes">, Group, + HelpText<"Set the default KIND for INTEGER to 8.">; } tskeith wrote: > That's not what -flarge-sizes does. Here

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. Change looks reasonable. Does this fix save-temps as intended? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96769/new/ https://reviews.llvm.org/D96769 ___ cfe-commits

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman updated this revision to Diff 323938. FarisRehman added a comment. Rebase off main Rebase off main and remove dependency on patch D96344 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96407/new/

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

pdhaliwal added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3057 + for (unsigned I = 0; I < ToolChains.size(); ++I) { +Action * = OpenMPDeviceActions[I]; +// AMDGPU does not support linking of object files, so we skip This logic

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! can't wait for the unique_function sfinae fix :) Comment at: clang-tools-extra/clangd/LSPBinder.h:185 + +LSPBinder::UntypedOutgoingNotification inline

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Ping! Please, don't pass by this patch. I need your competent evaluation to load it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

dblaikie added a comment. @hoy Could you explain a bit further why these two features are incompatible/what the crash looks like? At first glance I wouldn't expect any debug info mode to be incompatible with any non-debug-info mode (maybe less useful, but not crashy levels of incompatible).

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh added inline comments. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) mantognini wrote: > I'm not sure we want that -- I'm actually fine if we don't -- but I

[PATCH] D87519: [analyzer][Liveness][NFC] Enqueue the CFGBlocks post-order

steakhal added a comment. What about analyzing a Sema translation unit? That should be beefy enough to have a longer runtime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87519/new/ https://reviews.llvm.org/D87519

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2565945 , @Meinersbur wrote: > In D76342#2565686 , @ABataev wrote: > >> I can commit it as soon as you accepted it if you don't mind of course. > > I do not mind Ok, will commit

[PATCH] D67429: Improve code generation for thread_local variables:

wolfgangp added a comment. Ping. Just wondering if there are any new insights on the issue reported in PR48030 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

apazos added a comment. This looks like a straightforward implementation. The only caveat is that the XAR immediate does not represent a lane, and hence the need for a custom immediate range check. Looks sensible to me. @labrinea and others at ARM, do have any other comment before this is

[PATCH] D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Needs an example in the "Creating new Command Line Option" section, but with that it looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

varungandhi-apple created this revision. varungandhi-apple added a reviewer: rjmccall. Herald added subscribers: dexonsmith, pengfei, kbarton, kristof.beyls, jgravelle-google, sbc100, nemanjai, dschuff. varungandhi-apple requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

ayermolo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96783/new/ https://reviews.llvm.org/D96783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96244: [clangd] Introduce Modules

dblaikie added a comment. "modules" is a pretty overloaded term in Clang (between llvm Modules and Clang Modules and now C++ standard Modules) - any chance of some other term that might be less overloaded in this space? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

pdhaliwal added a comment. It is because of how addClangTargetOptions is invoked. In case of save-temps, it is being invoked for all the actions resulting in target cc1 call. That's why all these invocations have -emit-llvm-bc. I guess we need Action as an argument to addClangTargetOptions.

  1   2   >