[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. In D97183#2596865 , @steakhal wrote: > If the inner pointer participates in a branch condition guarding the > dereference, that memory region is gotta be important, right? So, we should > mark it so. > A BugreportVisitor could

[clang] fdae557 - [clang] DeltaTree::AddDelta - fix "initialization is never read" clang-tidy warning. NFCI.

Author: Simon Pilgrim Date: 2021-03-02T15:01:34Z New Revision: fdae5573f54dd5f790630f5bba7f08bb00d62846 URL: https://github.com/llvm/llvm-project/commit/fdae5573f54dd5f790630f5bba7f08bb00d62846 DIFF: https://github.com/llvm/llvm-project/commit/fdae5573f54dd5f790630f5bba7f08bb00d62846.diff

[clang-tools-extra] bf935a0 - [clangd] Make categorical features 64 bit in DecisionForest Model.

Author: Utkarsh Saxena Date: 2021-03-02T16:22:30+01:00 New Revision: bf935a034b345e905907c80030c67ef8f737d56a URL: https://github.com/llvm/llvm-project/commit/bf935a034b345e905907c80030c67ef8f737d56a DIFF:

[PATCH] D97770: [clangd] Make categorical features 64 bit in DecisionForest Model.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf935a034b34: [clangd] Make categorical features 64 bit in DecisionForest Model. (authored by usaxena95). Repository: rG LLVM Github Monorepo

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1828-1830 + // Allow only GNU attributes here. + if (!attrs.hasOnlyGNUAttributes()) +ProhibitAttributes(attrs); aaron.ballman wrote: > We really should be using

[PATCH] D97773: [clangd] Make WorkspaceSymbols request work with empty queries

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd uses codecompletion limit as the limit

[clang] 0caf736 - [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

Author: Alexey Bataev Date: 2021-03-02T07:11:06-08:00 New Revision: 0caf736d7e1d16d1059553fc28dbac31f0b9f788 URL: https://github.com/llvm/llvm-project/commit/0caf736d7e1d16d1059553fc28dbac31f0b9f788 DIFF: https://github.com/llvm/llvm-project/commit/0caf736d7e1d16d1059553fc28dbac31f0b9f788.diff

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0caf736d7e1d: [OPENMP50]Mapping of the subcomponents with the default mappers. (authored by ABataev). Repository: rG LLVM Github Monorepo

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc updated this revision to Diff 327446. mibintc added a comment. @aaron.ballman Is this what you have in mind to improve the diagnostic? There are other places in the file that assume FDecl can be null so I just copied that code. Also since the arm warning diagnostic is exactly similar,

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:297-298 +def err_anyx86_interrupt_regsave : Error< + "interrupt service routine may only call routine" + " with attribute no_caller_saved_registers">; def

[clang-tools-extra] 7f086d7 - Revert "[clangd] Use ML Code completion ranking as default."

Author: Utkarsh Saxena Date: 2021-03-02T15:04:23+01:00 New Revision: 7f086d74c347750c1da619058eb5b3e79c2fae14 URL: https://github.com/llvm/llvm-project/commit/7f086d74c347750c1da619058eb5b3e79c2fae14 DIFF:

[clang-tools-extra] 7556abf - [clangd] findExplicitReferences impl filters nulls centrally. NFC

Author: Sam McCall Date: 2021-03-02T15:55:03+01:00 New Revision: 7556abf82137b57be9e32475a1995f936a22cd16 URL: https://github.com/llvm/llvm-project/commit/7556abf82137b57be9e32475a1995f936a22cd16 DIFF: https://github.com/llvm/llvm-project/commit/7556abf82137b57be9e32475a1995f936a22cd16.diff

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. Thank you for delivering it, @HazardyKnusperkeks. One thing concerns me though. I'm not an author of changes done in clang/docs/ClangFormatStyleOptions.rst in lines 2372, 3069-3073, 3075, 3077, 3082-3086, 3088, 3093-3097, 3099, 3104-3108, and 3110-3111. Perhaps it's

[clang] 888c5c2 - AArch64: report fp16 arithmetic is present for apple-a11 CPU.

Author: Tim Northover Date: 2021-03-02T15:07:18Z New Revision: 888c5c24cab63091774b7065e6925177bb43787d URL: https://github.com/llvm/llvm-project/commit/888c5c24cab63091774b7065e6925177bb43787d DIFF: https://github.com/llvm/llvm-project/commit/888c5c24cab63091774b7065e6925177bb43787d.diff

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/reinterpret-cast-pointer-to-member.cpp:29-31 + Some some; + some.*sf = 14; + clang_analyzer_eval(some.*sf == 14); // expected-warning{{UNKNOWN}}

[PATCH] D97771: [cte][NFC] Remove all references to stdlib stream headers.

njames93 created this revision. njames93 added reviewers: aaron.ballman, sammccall, alexfh. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inclusion of iostream is

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added a comment. In D97183#2597099 , @RedDocMD wrote: > The InnerPointerVal memory region is not marked as interesting as of now, I > have tried that out. The branch condition constraint is set by the > ConstraintManager and it is queried via

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX planned changes to this revision. ArcsinX added a comment. In D97535#2596992 , @kadircet wrote: > But until that day, I suppose the best we can do is change the contract of > `FileSymbols` to sey keys are always `URIs representing the file

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, martong, thopre, hiraditya. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch consists of changes to

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

kcc added reviewers: kcc, pcc, vitalybuka. kcc added a comment. We can't possibly maintain two variants of scudo. All effort is currently spent on the newer (standalone) version. I am afraid we will have to delete the older (non-standalone) variant entirely. (And the sooner the better)

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple updated this revision to Diff 327510. varungandhi-apple added a comment. Add null check for callee; instead of using getFunctionType() directly. Otherwise, it leads to a crash when compiling gtest-all.cc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95017: [clang-format] Add case aware include sorting.

PragmaNull added a comment. In D95017#2595230 , @HazardyKnusperkeks wrote: > > Do you make a change? Otherwise I will do, but that will take some time, > because I'm rather busy. Sorry, I have not; unfortunately I've been rather busy myself and

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal added inline comments. Comment at: clang/test/Analysis/reinterpret-cast-pointer-to-member.cpp:29-31 + Some some; + some.*sf = 14; + clang_analyzer_eval(some.*sf == 14); // expected-warning{{UNKNOWN}} RedDocMD wrote: > steakhal wrote: > > RedDocMD

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. @rjmccall @jyknight Ping. Any further concerns? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97741: [clang+lld] Pass -platform_version args to ld64.lld

This revision was automatically updated to reflect the committed changes. Closed by commit rG18fa1d380d6c: [clang+lld] Pass -platform_version args to ld64.lld (authored by int3). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97741/new/

[clang] 18fa1d3 - [clang+lld] Pass -platform_version args to ld64.lld

Author: Jez Ng Date: 2021-03-02T12:52:54-05:00 New Revision: 18fa1d380d6c693beac017f8c17958464ffd5b8f URL: https://github.com/llvm/llvm-project/commit/18fa1d380d6c693beac017f8c17958464ffd5b8f DIFF: https://github.com/llvm/llvm-project/commit/18fa1d380d6c693beac017f8c17958464ffd5b8f.diff LOG:

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

sammccall added a comment. In D97738#2597296 , @kadircet wrote: > as discussed offline, i am hesitant about `validateEdits` layering at the > moment. but i suppose the best thing to do is move it into clangdserver and > expose a structrual api, as you

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

sammccall updated this revision to Diff 327481. sammccall marked 3 inline comments as done. sammccall added a comment. address comments remove one more redundant getDraft() check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97738/new/

[clang] 72bf4c6 - [clang][cli] NFC: Use .str() instead of operator<

Author: Jan Svoboda Date: 2021-03-02T13:02:04+01:00 New Revision: 72bf4c6d99223e75aa9afd36d078ed0931fb6533 URL: https://github.com/llvm/llvm-project/commit/72bf4c6d99223e75aa9afd36d078ed0931fb6533 DIFF: https://github.com/llvm/llvm-project/commit/72bf4c6d99223e75aa9afd36d078ed0931fb6533.diff

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. I'm somewhat bothered that this patch is not landed yet. :| I made a **crude** mock to trigger the bug using `LD_PRELOAD`. F15707493: LD_PRELOAD-workaround.patch The test reproduces the issue and passes if you apply the fix from

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

svenvh added a comment. LGTM mostly, but would like to hear the opinion of others on the discussion about "useful". Comment at: clang/docs/OpenCLSupport.rst:221 +triggers in the parsing) should not be added to clang. Moreover, the acceptable +behavior of pragmas should

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet added a comment. Right, i see the problem you are trying to solve, and all of this is a mess working nicely in unisom, but falls apart if you try to isolate each piece :/ (hence the need for figuring out list of files while indexing instead) But until that day, I suppose the best we

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2587033 , @azabaznov wrote: >> FYI, I would even be ok if we remove the need for enabling non-core > > AFAIU this can be done not for every extension to maintain backward > compatibility. This should not result in

[PATCH] D97187: [Clang][Sema] Warn when function argument is less aligned than parameter

tmatheson added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97187/new/ https://reviews.llvm.org/D97187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

sammccall added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:1153 // Create the target instance. - Clang->setTarget(TargetInfo::CreateTargetInfo( - Clang->getDiagnostics(), Clang->getInvocation().TargetOpts)); This part is not used by

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc created this revision. mibintc added reviewers: ABataev, aaron.ballman. Herald added a subscriber: kristof.beyls. mibintc requested review of this revision. Herald added a project: clang. In the bug report, @DavidKreitzer wrote: clang should be giving an error for this test, because we

[PATCH] D97069: [clang] SimpleMFlag helper in Options.td

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21280d35d652: [clang] SimpleMFlag helper in Options.td (authored by rampitec). Herald added a project: clang. Herald added a subscriber:

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 327363. khchen marked 11 inline comments as done. khchen added a comment. address @jrtc27's comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files:

[clang] 08ccea0 - [clang][cli] NFC: Use .str() instead of operator<

Author: Jan Svoboda Date: 2021-03-02T13:14:00+01:00 New Revision: 08ccea019fda514ae36454f8d607b6c3cb08698e URL: https://github.com/llvm/llvm-project/commit/08ccea019fda514ae36454f8d607b6c3cb08698e DIFF: https://github.com/llvm/llvm-project/commit/08ccea019fda514ae36454f8d607b6c3cb08698e.diff

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman updated this revision to Diff 327412. aaron.ballman added a comment. Rebased and added a Frontend-specific test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/reinterpret-cast-pointer-to-member.cpp:20 int DoubleDerived::*ddf = ::field; int Base::*bf = reinterpret_cast(reinterpret_cast(reinterpret_cast(ddf))); Base base;

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

lebedev.ri added a comment. Once again, can we please split this into two patches? I'm quite happy with the `DescribeBasicIncrements` stuff, that can be merged right now. But i'm not quite sold on the macro stuff. We don't have that for readability-function-size, nor does the CC spec say

[clang] 4545813 - [clang][cli] NFC: Rename marshalling multiclass

Author: Jan Svoboda Date: 2021-03-02T11:53:40+01:00 New Revision: 4545813b17e3079af424764a7aa44b629e04b7c1 URL: https://github.com/llvm/llvm-project/commit/4545813b17e3079af424764a7aa44b629e04b7c1 DIFF: https://github.com/llvm/llvm-project/commit/4545813b17e3079af424764a7aa44b629e04b7c1.diff

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia updated this revision to Diff 327400. Anastasia added a comment. Reuploaded with changes from the 1st review round. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 Files: clang/include/clang/Basic/OpenCLExtensions.def

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. @NoQ, I guess I would need to figure out a way to find out if the raw pointer obtained from `get()` is being used somewhere or is being constrained. I am trying to first figure out whether the raw pointer is being constrained to null, causing a null-deref to detected.

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added a comment. If the inner pointer participates in a branch condition guarding the dereference, that memory region is gotta be important, right? So, we should mark it so. A BugreportVisitor could easily transfer the information about the fact that the dereference was guarded by

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 ___

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added a comment. Thanks for working on this. LGTM in general. I'll let Marco comment on the latest changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 ___ cfe-commits mailing list

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG438b5bb05a42: [clangd] Use ML Code completion ranking as default. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96353/new/

[clang-tools-extra] 438b5bb - [clangd] Use ML Code completion ranking as default.

Author: Utkarsh Saxena Date: 2021-03-02T10:05:37+01:00 New Revision: 438b5bb05a429d697674088d400e4800c1108658 URL: https://github.com/llvm/llvm-project/commit/438b5bb05a429d697674088d400e4800c1108658 DIFF:

[clang] 5ba568f - [clang][docs] Fix code blocks rendering

Author: Jan Svoboda Date: 2021-03-02T11:33:10+01:00 New Revision: 5ba568f21b51825522f3a60a4ba656cf37a144c9 URL: https://github.com/llvm/llvm-project/commit/5ba568f21b51825522f3a60a4ba656cf37a144c9 DIFF: https://github.com/llvm/llvm-project/commit/5ba568f21b51825522f3a60a4ba656cf37a144c9.diff

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 327396. RedDocMD added a comment. Should not emit note if raw pointer cannot be tracked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files:

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:311 + Value *ResElt = B.CreateAdd(EltC, SubVecR); + Value *NewVecC = B.CreateInsertElement(VecCPhi, ResElt, IdxC); + Value *NewVecD = B.CreateInsertElement(VecDPhi, ResElt, IdxC);

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:292 +for (const auto : *Slab) { + if (Sym.Definition) +Files.insert(Sym.Definition.FileURI); kadircet wrote: > ArcsinX wrote: > > kadircet wrote: > > > it

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf updated this revision to Diff 327378. qiucf retitled this revision from "[PowerPC] [Clang] Enable float128 feature on Altivec targets" to "[PowerPC] [Clang] Enable float128 feature on VSX targets". qiucf edited the summary of this revision. qiucf set the repository for this revision to rG

[PATCH] D91164: [clang-tidy] Improve C++ support in bugprone-signal-handler.

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:100-101 const LangOptions ) const { - // FIXME: Make the checker useful on C++ code. - if (LangOpts.CPlusPlus) + // FIXME: Improve C++ support. + if

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. They are being applied to the `@try` at least (`-ast-print` prints them) and we do some error checking for missing call expressions in `handleNoMergeAttr()` in `SemaStmtAttr.cpp`. I don't know much about Objective C so I am not sure how to check that the attribute

[clang-tools-extra] bad8e57 - Fix DecisionForestBenchmark.cpp compile errors

Author: Utkarsh Saxena Date: 2021-03-02T10:27:46+01:00 New Revision: bad8e577f9c75c8b84efca79980781599e8e9f86 URL: https://github.com/llvm/llvm-project/commit/bad8e577f9c75c8b84efca79980781599e8e9f86 DIFF:

[PATCH] D97620: Fix DecisionForestBenchmark.cpp compile errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGbad8e577f9c7: Fix DecisionForestBenchmark.cpp compile errors (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97620/new/

[clang] 3fa0e79 - [OpenCL] Use StringMap instead of std::map

Author: Sven van Haastregt Date: 2021-03-02T09:37:26Z New Revision: 3fa0e793729a4caca2f35ebe7c0b25a2615b8e8f URL: https://github.com/llvm/llvm-project/commit/3fa0e793729a4caca2f35ebe7c0b25a2615b8e8f DIFF: https://github.com/llvm/llvm-project/commit/3fa0e793729a4caca2f35ebe7c0b25a2615b8e8f.diff

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf updated this revision to Diff 327388. qiucf added a comment. Fix redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815 Files: clang/lib/Basic/Targets/PPC.cpp

[clang] 1b6eb56 - Stop traping on sNaN in __builtin_isinf

Author: Thomas Preud'homme Date: 2021-03-02T15:54:56Z New Revision: 1b6eb56aa0ea2931866455a21a138fc09c08e905 URL: https://github.com/llvm/llvm-project/commit/1b6eb56aa0ea2931866455a21a138fc09c08e905 DIFF: https://github.com/llvm/llvm-project/commit/1b6eb56aa0ea2931866455a21a138fc09c08e905.diff

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small change to the diagnostic (routine -> a function, and adding single quotes around the syntax element in the diagnostic). Comment at:

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc updated this revision to Diff 327465. mibintc added a comment. Thanks I'll wait to see if there are any more remarks, and push it later today or tomorrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97764/new/

[PATCH] D97119: [flang][driver] Add options for -std=f2018

richard.barton.arm added a comment. I agree with @tskeith that `-Mstandard` is not exactly orthogonal to `-std`, the former being about warning for non-standard extensions/deviations and the latter being about use of standard fortran, but from a different standard version. I would expect

[PATCH] D97771: [cte][NFC] Remove all references to stdlib stream headers.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM (apart from Aaron's comment!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97771/new/ https://reviews.llvm.org/D97771

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

vgeof added a comment. I just wanted to upvote the Macro parameter addition ! In my team, we use macros for logging purpose. We don't have access to their implementations, and they all have (sadly) a high complexity score. So we write a lot of functions like this one, which in my opinion

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added a comment. t Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:58-62 + bool IsPointer = false; + // IsConstant indices are "int", but have the constant expression. + bool IsImmediate = false; + // const qualifier. + bool IsConstant = false;

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 327470. abhina.sreeskantharajan added a comment. Thanks for the feedback! I haven't addressed all the comments yet but I've made major renaming changes and hope to get feedback on it. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D97773: [clangd] Make WorkspaceSymbols request work with empty queries

sammccall added a comment. I've asked on the bug for some more context for the request. I don't see a problem with this change per se but I'm not sure it'll actually fix the bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97773/new/

[clang-tools-extra] 91679c9 - [clangd] Include macro expansions in documentSymbol hierarchy

Author: Sam McCall Date: 2021-03-02T17:52:24+01:00 New Revision: 91679c95bbedf4f816a456028ebd23ea6c5cc08f URL: https://github.com/llvm/llvm-project/commit/91679c95bbedf4f816a456028ebd23ea6c5cc08f DIFF: https://github.com/llvm/llvm-project/commit/91679c95bbedf4f816a456028ebd23ea6c5cc08f.diff

[PATCH] D97615: [clangd] Include macro expansions in documentSymbol hierarchy

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rG91679c95bbed: [clangd]

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added a comment. Hi Tom, @tahonermann I renamed the LiteralTranslator class to LiteralConverter.cpp and have renamed a lot of the functions. Let me know what you think. I agree that the setConverters function is awkward, the problem stems from initializing the member

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

thopre created this revision. thopre added reviewers: mibintc, kpn, efriedma, sepavloff, rjmccall, jonpa. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D9 Files:

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b6eb56aa0ea: Stop traping on sNaN in __builtin_isinf (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97771: [cte][NFC] Remove all references to stdlib stream headers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:38 + if (!Buffer) { +llvm::errs() << "Error cannot open JSON request file:" << FileName << ": " + << Buffer.getError().message() << "\n";

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/src/data_sharing.cu:34 +EXTERN void *__kmpc_alloc_shared(size_t DataSize) { + return (void *)SafeMalloc(DataSize, "Alloc Shared"); } Add a TODO: 1) Use a small shared buffer 2)

[PATCH] D97771: [cte][NFC] Remove all references to stdlib stream headers.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:38 + if (!Buffer) { +llvm::errs() << "Error cannot open JSON request file:" << FileName << ": " + << Buffer.getError().message() << "\n";

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 6 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:191 +Preprocessor , tok::TokenKind kind, +ConversionState TranslationState =

[clang-tools-extra] 890190a - Revert "Revert "[clangd] Use ML Code completion ranking as default.""

Author: Utkarsh Saxena Date: 2021-03-02T18:03:52+01:00 New Revision: 890190a61d648755c9213d4a38af294f7dad3de2 URL: https://github.com/llvm/llvm-project/commit/890190a61d648755c9213d4a38af294f7dad3de2 DIFF:

[PATCH] D97752: Fix -gz=zlib options for linker for FreeBSD too

This revision was automatically updated to reflect the committed changes. Closed by commit rG462cf39a5c18: [Driver] Fix -gz=zlib options for linker also on FreeBSD (authored by emaste). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 462cf39 - [Driver] Fix -gz=zlib options for linker also on FreeBSD

Author: Ed Maste Date: 2021-03-02T08:44:24-05:00 New Revision: 462cf39a5c180621b56f7602270ce33eb7b68d23 URL: https://github.com/llvm/llvm-project/commit/462cf39a5c180621b56f7602270ce33eb7b68d23 DIFF: https://github.com/llvm/llvm-project/commit/462cf39a5c180621b56f7602270ce33eb7b68d23.diff

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 327426. aaron.ballman added a comment. Address review comments from @rnk Only define the `static_assert` macro if one is not already defined and test the expected behavior. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin added a comment. Herald added a subscriber: jansvoboda11. Gentle ping @sfertile , any new comment on the patch ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal added inline comments. Comment at: clang/test/Analysis/reinterpret-cast-pointer-to-member.cpp:29-31 + Some some; + some.*sf = 14; + clang_analyzer_eval(some.*sf == 14); // expected-warning{{UNKNOWN}} RedDocMD wrote: > steakhal wrote: > > The

[PATCH] D97770: [clangd] Make categorical features 64 bit in DecisionForest Model.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. CodeCompletionContext::Kind has 36 Kinds. The completion model used to support

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

sammccall updated this revision to Diff 327445. sammccall marked 6 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97617/new/ https://reviews.llvm.org/D97617 Files:

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:657 +void VisitObjCInterfaceDecl(const ObjCInterfaceDecl *OID) { + if (OID->hasDefinition()) +visitProtocolList(OID->protocols(), OID->protocol_locs());

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. Ping? Comment at: clang/test/CodeGen/builtin_float_strictfp.c:21 + // NOFP16-NEXT: [[IHALF:%.*]] = load i16, i16* [[LDADDR]], align 2 + // NOFP16-NEXT: [[CONV:%.*]] = call float @llvm.convert.from.fp16.f32(i16 [[IHALF]]) + // NOFP16-NEXT:

[PATCH] D97752: Fix -gz=zlib options for linker for FreeBSD too

yaxunl added a comment. In D97752#2596277 , @emaste wrote: > I can drop the Fixes trailer (I added it as we've adopted it in FreeBSD from > Linux). That said, the referenced patch changed Gnu, AMDGPU, and HIP. My main > goal here is to get the final

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

kadircet added a comment. as discussed offline, i am hesitant about `validateEdits` layering at the moment. but i suppose the best thing to do is move it into clangdserver and expose a structrual api, as you proposed, which can be done independently. Comment at:

[clang-tools-extra] 289fee4 - [clangd] Show hex value of numeric constants

Author: Sam McCall Date: 2021-03-02T16:33:02+01:00 New Revision: 289fee4ab7626447a7efcc245eba2f475d00810e URL: https://github.com/llvm/llvm-project/commit/289fee4ab7626447a7efcc245eba2f475d00810e DIFF: https://github.com/llvm/llvm-project/commit/289fee4ab7626447a7efcc245eba2f475d00810e.diff

[PATCH] D97226: [clangd] Show hex value of numeric constants

This revision was automatically updated to reflect the committed changes. Closed by commit rG289fee4ab762: [clangd] Show hex value of numeric constants (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D97226?vs=325807=327450#toc Repository: rG LLVM Github Monorepo

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1828-1830 + // Allow only GNU attributes here. + if (!attrs.hasOnlyGNUAttributes()) +ProhibitAttributes(attrs); tbaeder wrote: > aaron.ballman wrote: > > We

[PATCH] D97773: [clangd] Make WorkspaceSymbols request work with empty queries

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM OK, I think we've established that the request was for a way to dump out clangd's whole index, and workspace/symbol isn't actually a good way to do that. Nevertheless, this seems

[PATCH] D97320: Use a fast path when initializing LineOffsetMapping

lattner added a comment. Nice, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97320/new/ https://reviews.llvm.org/D97320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire updated this revision to Diff 327559. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97156/new/ https://reviews.llvm.org/D97156 Files: clang/docs/tools/dump_ast_matchers.py

[PATCH] D96347: Include function return type in JSON AST dumps.

Temtaime added a comment. Merge it, please. I badly need this field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96347/new/ https://reviews.llvm.org/D96347 ___ cfe-commits mailing list

[PATCH] D88220: [C++20] P1825R0: More implicit moves

rsmith added inline comments. Comment at: clang/www/cxx_status.html:1206-1210 + + More implicit moves + https://wg21.link/p1825r0;>P1825R0 (DR) + Clang 13 + We have, so far, listed DR papers only in the section of `cxx_status` for the

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, but please make sure that Richard is happy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 ___

  1   2   >