[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400-1406 + LLVM_ATTRIBUTE_UNUSED inline bool areFeasible(ConstraintRangeTy Constraints) { +return llvm::none_of( +

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

vsavchenko updated this revision to Diff 329903. vsavchenko marked an inline comment as done. vsavchenko added a comment. Make `areFeasible` function static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98341/new/ https://reviews.llvm.org/D98341

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6a0560bf258: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics. (authored by khchen). Changed prior to commit:

[clang-tools-extra] 4f1bbc0 - [clangd] Introduce a CommandLineConfigProvider

Author: Kadir Cetinkaya Date: 2021-03-11T13:35:05+01:00 New Revision: 4f1bbc0b842621d2048ed8687e328e2eab375b0a URL: https://github.com/llvm/llvm-project/commit/4f1bbc0b842621d2048ed8687e328e2eab375b0a DIFF:

[PATCH] D98029: [clangd] Introduce a CommandLineConfigProvider

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f1bbc0b8426: [clangd] Introduce a CommandLineConfigProvider (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 329931. stelios-arm marked an inline comment as done. stelios-arm added a comment. 1. Addressed the comment made by @SjoerdMeijer and added the comment for the MRS instruction. 2. Added the `+rang` feature in `arm_acle.c ` CHANGES SINCE LAST ACTION

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia added a comment. @tstellar is it ok if I commit this to the release branch or do you prefer to do it yourself? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98076/new/ https://reviews.llvm.org/D98076 ___ cfe-commits mailing list

[PATCH] D98211: Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. The description of the problem, and hte patch and tests seem to make sense, so I think this should be ok. Please give some of the others a little bit of time before committing to

[PATCH] D98211: Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well, but feel free to give the other reviewers a chance to weigh in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98211/new/ https://reviews.llvm.org/D98211

[clang] d53866f - Fix MSVC "result of 32-bit shift implicitly converted to 64 bits" warnings. NFCI.

Author: Simon Pilgrim Date: 2021-03-11T10:29:14Z New Revision: d53866ff473d4023b0e3db68a1b91cfa59aacbb9 URL: https://github.com/llvm/llvm-project/commit/d53866ff473d4023b0e3db68a1b91cfa59aacbb9 DIFF: https://github.com/llvm/llvm-project/commit/d53866ff473d4023b0e3db68a1b91cfa59aacbb9.diff

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. kbobyrev requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, LLVM. This was

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm created this revision. ldrumm added reviewers: Anastasia, mibintc, bader, yaxunl. ldrumm added a project: clang. Herald added a subscriber: wenlei. ldrumm requested review of this revision. `__translate_sampler_initializer` has a calling convention of `spir_func`, but clang generated calls

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 329913. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files:

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

martong added reviewers: aaron.ballman, riccibruno, dblaikie. martong added subscribers: aaron.ballman, dblaikie. martong added a comment. Hi @aaron.ballman @riccibruno @dblaikie, I am adding you as a reviewer because it seems you have great experience with Clang's AST. Could you please take a

[PATCH] D98364: [clangd] Use ref counted strings throughout for File Contents

njames93 updated this revision to Diff 329933. njames93 marked 4 inline comments as done. njames93 added a comment. Remove some unneeded changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98364/new/ https://reviews.llvm.org/D98364 Files:

[clang] cb559c8 - [Sema] Add some basic lambda capture fix-its

Author: Nathan James Date: 2021-03-11T13:46:25Z New Revision: cb559c8d5ebea60b07dec4654064ed775890b93b URL: https://github.com/llvm/llvm-project/commit/cb559c8d5ebea60b07dec4654064ed775890b93b DIFF: https://github.com/llvm/llvm-project/commit/cb559c8d5ebea60b07dec4654064ed775890b93b.diff LOG:

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb559c8d5ebe: [Sema] Add some basic lambda capture fix-its (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96975/new/

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 329941. stelios-arm added a comment. Rephrased a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98264/new/ https://reviews.llvm.org/D98264 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbafcb4c6841a: [OpenCL][Docs] Add guidelines for new extensions and features. (authored by Anastasia). Herald added a project: clang. Changed prior

[clang] bafcb4c - [OpenCL][Docs] Add guidelines for new extensions and features.

Author: Anastasia Stulova Date: 2021-03-11T14:28:48Z New Revision: bafcb4c6841a302d502b14fb93101fb590459935 URL: https://github.com/llvm/llvm-project/commit/bafcb4c6841a302d502b14fb93101fb590459935 DIFF: https://github.com/llvm/llvm-project/commit/bafcb4c6841a302d502b14fb93101fb590459935.diff

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 329894. v.g.vassilev added a comment. Address most of the formatting suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files: clang/include/clang/CodeGen/CodeGenAction.h

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet added a comment. thanks! this mostly LG, just a couple comments here and there. > The current format is "store seconds since X event". I think this is great for certain things like freshness, so thanks! > Should we store UNIX timestamps instead? This is probably not portable until >

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

steakhal accepted this revision. steakhal added a comment. Looks good btw. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400-1406 + LLVM_ATTRIBUTE_UNUSED inline bool areFeasible(ConstraintRangeTy Constraints) { +return llvm::none_of( +

[PATCH] D98364: [clangd] Use ref counted strings throughout for File Contents

njames93 updated this revision to Diff 329939. njames93 added a comment. Remove other unnecessary ownership. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98364/new/ https://reviews.llvm.org/D98364 Files:

[clang] 46354ba - [OpaquePtrs] Remove some uses of type-less CreateLoad APIs (NFC)

Author: Nikita Popov Date: 2021-03-11T14:40:57+01:00 New Revision: 46354bac76f60e988537181b3609a8e3ac89f523 URL: https://github.com/llvm/llvm-project/commit/46354bac76f60e988537181b3609a8e3ac89f523 DIFF: https://github.com/llvm/llvm-project/commit/46354bac76f60e988537181b3609a8e3ac89f523.diff

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia added a comment. Sorry for the last-minute change, I have decided to add this too: +- Removed extensions without kernel language changes: + ``cl_khr_select_fprounding_mode``, ``cl_khr_gl_sharing``, ``cl_khr_icd``, + ``cl_khr_gl_event``, ``cl_khr_d3d10_sharing``,

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

svenvh accepted this revision. svenvh added a comment. In D98076#2619425 , @Anastasia wrote: > Sorry for the last-minute change, I have decided to add this too: > > +- Removed extensions without kernel language changes: > +

[clang] 807466e - [OpenMP] Restore backwards compatibility for libomptarget

Author: Joseph Huber Date: 2021-03-11T09:52:11-05:00 New Revision: 807466ef28125cf7268c860b09d5563c9c93602a URL: https://github.com/llvm/llvm-project/commit/807466ef28125cf7268c860b09d5563c9c93602a DIFF: https://github.com/llvm/llvm-project/commit/807466ef28125cf7268c860b09d5563c9c93602a.diff

[clang] df2a6ee - [Sema] Use castAs<> instead getAs<> for dereferenced pointer casts. NFCI.

Author: Simon Pilgrim Date: 2021-03-11T14:51:25Z New Revision: df2a6ee3247c9d00b42c14ea924fd25cc45bda87 URL: https://github.com/llvm/llvm-project/commit/df2a6ee3247c9d00b42c14ea924fd25cc45bda87 DIFF: https://github.com/llvm/llvm-project/commit/df2a6ee3247c9d00b42c14ea924fd25cc45bda87.diff

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple updated this revision to Diff 329889. varungandhi-apple added a comment. Use musttail call instead of tail call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95984/new/ https://reviews.llvm.org/D95984 Files:

[PATCH] D98164: [clangd] Drop explicit specifier on define out-of-line

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1a5df174e1d: [clangd] Drop explicit specifier on define out-of-line (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98164/new/

[clang-tools-extra] b1a5df1 - [clangd] Drop explicit specifier on define out-of-line

Author: Kadir Cetinkaya Date: 2021-03-11T13:27:24+01:00 New Revision: b1a5df174e1d5a58f2498c30795cf18c9bf3e1b1 URL: https://github.com/llvm/llvm-project/commit/b1a5df174e1d5a58f2498c30795cf18c9bf3e1b1 DIFF:

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG807466ef2812: [OpenMP] Restore backwards compatibility for libomptarget (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 87358db - [clang][ARM] Refactor ComputeLLVMTriple code for ARM

Author: David Spickett Date: 2021-03-11T10:25:16Z New Revision: 87358dba8182b4ee2d9eedabb8afb319b59a322b URL: https://github.com/llvm/llvm-project/commit/87358dba8182b4ee2d9eedabb8afb319b59a322b DIFF: https://github.com/llvm/llvm-project/commit/87358dba8182b4ee2d9eedabb8afb319b59a322b.diff

[PATCH] D98253: [clang][ARM] Refactor ComputeLLVMTriple code for ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rG87358dba8182: [clang][ARM] Refactor ComputeLLVMTriple code for ARM (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98253/new/

[PATCH] D98371: [clangd] Group filename calculations in SymbolCollector, and cache mroe.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. the savings look great, thanks! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:217 + llvm::SmallString<256> AbsPath = Path; + // We don't

[PATCH] D98329: [clangd] Add cache for FID to Header mappings

kadircet abandoned this revision. kadircet added a comment. abandoning in favor of D98371 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98329/new/ https://reviews.llvm.org/D98329

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12 +if (ENABLE_GRPC_REFLECTION) + set(REFLECTION_LIBRARY grpc++_reflection) kadircet wrote: > can we move this piece into FindGRPC.cmake instead? Yes, but

[PATCH] D98414: [clangd] Turn off implicit cancellation based on client capabilities

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Capability is in upcoming 3.17:

[PATCH] D98242: [clangd] Store system relative includes as verbatim

kadircet updated this revision to Diff 329930. kadircet added a comment. - Rebase - Add a storage for returned verbatim header spellings, as getHeaderIncludeUncached can only return a ref. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98242/new/

[PATCH] D98418: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h

svenvh created this revision. svenvh added reviewers: stuart, Anastasia. svenvh added a project: clang. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The OpenCL C specification v3.0.6 s6.15.12.7.5 mentions: For

[PATCH] D98364: [clangd] Use ref counted strings throughout for File Contents

njames93 added a comment. I've cleaned some changes up a bit. I do agree its not as important as the dirty buffer case, but this is about uniformity as much as anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98364/new/

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12 +if (ENABLE_GRPC_REFLECTION) + set(REFLECTION_LIBRARY grpc++_reflection) can we move this piece into FindGRPC.cmake instead? Comment

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

vsavchenko updated this revision to Diff 329901. vsavchenko added a comment. Fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98341/new/ https://reviews.llvm.org/D98341 Files:

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

vsavchenko updated this revision to Diff 329928. vsavchenko added a comment. Remove unused global variable from the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98341/new/ https://reviews.llvm.org/D98341 Files:

[PATCH] D98416: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://llvm.org/PR49498. The

[PATCH] D98424: [clangd] Reject renames to non-identifier characters

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] dcdd476 - [OpenCL] Add missing atomic_xchg overload

Author: Sven van Haastregt Date: 2021-03-11T10:20:29Z New Revision: dcdd476c46dcab6e11d4421475e3792e65c1dd1f URL: https://github.com/llvm/llvm-project/commit/dcdd476c46dcab6e11d4421475e3792e65c1dd1f DIFF: https://github.com/llvm/llvm-project/commit/dcdd476c46dcab6e11d4421475e3792e65c1dd1f.diff

[PATCH] D98242: [clangd] Store system relative includes as verbatim

sammccall added a comment. I've landed the caching patch so this is good to go. The merge is *conceptually* trivial but the enclosing function has moved so you may need to reapply it by hand, sorry... Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:801 + if

[clang-tools-extra] cec62ae - [clangd] Fix buildbots without grpc enabled

Author: Kadir Cetinkaya Date: 2021-03-11T13:46:52+01:00 New Revision: cec62ae28a5fc5698a1b720a67187972c8e125cb URL: https://github.com/llvm/llvm-project/commit/cec62ae28a5fc5698a1b720a67187972c8e125cb DIFF:

[PATCH] D98415: [aarch64][WOA64][docs] Release note for WoA-hosted LLVM 12 binary

maxim-kuvyrkov created this revision. maxim-kuvyrkov added reviewers: richard.townsend.arm, tstellar. Herald added subscribers: danielkiss, kristof.beyls. maxim-kuvyrkov requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia updated this revision to Diff 329944. Anastasia added a comment. - Added nested pointer item - Elaborated list of removed extensions with no kernel language changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98076/new/ https://reviews.llvm.org/D98076 Files:

[clang-tools-extra] b8c5837 - [clangd] Group filename calculations in SymbolCollector, and cache mroe.

Author: Sam McCall Date: 2021-03-11T12:59:26+01:00 New Revision: b8c58374f66b2a03ff3f48c419037d463c5b80ed URL: https://github.com/llvm/llvm-project/commit/b8c58374f66b2a03ff3f48c419037d463c5b80ed DIFF: https://github.com/llvm/llvm-project/commit/b8c58374f66b2a03ff3f48c419037d463c5b80ed.diff

[PATCH] D98371: [clangd] Group filename calculations in SymbolCollector, and cache mroe.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rGb8c58374f66b: [clangd] Group filename calculations in SymbolCollector, and cache mroe. (authored by

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Thanks! LGTM. I think we should consider deprecating `spir_func` calling convention in favor of default calling convention. I don't much value in having it today. Repository: rG LLVM Github

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

steakhal added inline comments. Comment at: clang/test/Analysis/PR49490.cpp:12 + +int *ints; +int oob_access(); I think you can remove this line. We already have a global variable to be invalidated by the evaluation of `oob_access()` call. Repository: rG

[clang] 1fd4bee - [flang][driver] Add -fdebug-module-writer option

Author: Arnamoy Bhattacharyya Date: 2021-03-11T08:04:37-05:00 New Revision: 1fd4beecc8bb1148123265a63e0bff92b626c4a3 URL: https://github.com/llvm/llvm-project/commit/1fd4beecc8bb1148123265a63e0bff92b626c4a3 DIFF:

[PATCH] D98424: [clangd] Reject renames to non-identifier characters

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:473-488 +static bool mayBeValidIdentifier(llvm::StringRef Ident) { + assert(llvm::json::isUTF8(Ident)); + if (Ident.empty()) +return false; + // We don't check all the rules for

[PATCH] D57838: [clang-cl] support /Oy- on aarch64

krico4272 added a comment. Herald added a subscriber: danielkiss. In D57838#1388400 , @mstorsjo wrote: > LGTM In D57838#1388400 , @mstorsjo wrote: > LGTM F15823649: reboot.zip

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 329989. RedDocMD added a comment. Calling trackExpressionValue to mark InnerPointerVal as interesting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files:

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau requested review of this revision. ctetreau added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___ cfe-commits mailing list

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12 +if (ENABLE_GRPC_REFLECTION) + set(REFLECTION_LIBRARY grpc++_reflection) kbobyrev wrote: > kadircet wrote: > > can we move this piece into

[PATCH] D98424: [clangd] Reject renames to non-identifier characters

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:473-488 +static bool mayBeValidIdentifier(llvm::StringRef Ident) { + assert(llvm::json::isUTF8(Ident)); + if (Ident.empty()) +return false; + // We don't check all the rules for

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 329972. djtodoro added a comment. - rebase on top of trunk - refactor the code ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

hjelmn created this revision. hjelmn added reviewers: krasimir, djasper. hjelmn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The option SpaceBeforeForLoopSemiColon controls whether clang-format puts a space before the semi-colons in a

[PATCH] D98436: [Hexagon] Support inlined use of cs0 and cs1

sidneym created this revision. sidneym added reviewers: bcain, kparzysz. Herald added a subscriber: hiraditya. sidneym requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Allow inline assembly to reference cs0 and cs1 registers.

[PATCH] D98433: [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius updated this revision to Diff 329998. curdeius added a comment. Revert unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98433/new/ https://reviews.llvm.org/D98433 Files: clang/lib/Parse/ParseExprCXX.cpp

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. @NoQ, I am using `trackExpressionValue` to add intersetingness to the `InnerPointerVal`. That solves the original problem. However, it is causing the **MoveChecker** to add extra warnings to use-after-move cases. Essentially, when a `unique_ptr` is moved and

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski added a comment. Thank you for updating this @arnamoy10 ! Comment at: flang/lib/Frontend/CompilerInvocation.cpp:26 #include "llvm/Support/raw_ostream.h" + +#include "llvm/Support/FileSystem.h" Not needed Comment at:

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau planned changes to this revision. ctetreau added a comment. Herald added subscribers: dcaballe, cota. I plan to revive this patch. I will try to rig it to only require 3.6 or above is testing is enabled using LLVM_INCLUDE_TESTS. Hopefully if any build bots haven't been fixed by now,

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 329970. arnamoy10 added a comment. Herald added a subscriber: ormris. 1. Updated to set the default search directory for the intrinsic module 2. Modified the test case to check the prepend behavior CHANGES SINCE LAST ACTION

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 329976. arnamoy10 added a comment. Clang-formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 329982. ASDenysPetrov added a comment. Updated. In D96090#2618410 , @NoQ wrote: > In all cases we're supposed to have an **original** type, whether we need it > or not. Simply because we're simulating a typed

[PATCH] D98165: [clangd] Make ProjectAwareIndex optionally sync

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98165/new/ https://reviews.llvm.org/D98165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98037/new/ https://reviews.llvm.org/D98037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions.

jyknight added a comment. Ping, thanks! Or, if you have suggestions on how to make it easier to review, I'd be open to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86855/new/ https://reviews.llvm.org/D86855

[PATCH] D98414: [clangd] Turn off implicit cancellation based on client capabilities

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdServer.h:153 +/// to cancel. Clients that always cancel stale requests should clear this. +bool

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov added a comment. In D97388#2615104 , @NoQ wrote: > Ok then, let's try to land it! 爛 Thanks for the approval. Before land this we should land the preparatory revision D97296 . Please, take a look. CHANGES

[PATCH] D98414: [clangd] Turn off implicit cancellation based on client capabilities

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:153 +/// to cancel. Clients that always cancel stale requests should clear this. +bool ImplicitCancellation = true; + this makes sense as is, but i wonder if we should

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau updated this revision to Diff 329965. ctetreau added a comment. This revision is now accepted and ready to land. Only require if adding test suite targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/

[PATCH] D98424: [clangd] Reject renames to non-identifier characters

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 +case InvalidName::BadIdentifier: + return "the chosen name \"{0}\" is not a valid

[PATCH] D98433: [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius created this revision. curdeius added reviewers: rsmith, aaron.ballman, faisalv. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - http://eel.is/c++draft/expr.prim.lambda - http://wg21.link/P1102 Repository: rG LLVM

[PATCH] D98433: [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius added a comment. Is there something else that I should test? Comment at: clang/lib/Parse/ParseExprCXX.cpp:1447 +std::vector EmptyParamInfo; +ParseLambdaSpecifiers(/*LParenLoc=*/NoLoc, /*RParenLoc=*/NoLoc, + EmptyParamInfo,

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn updated this revision to Diff 33. fhahn added a comment. Thank you very much John! I applied your suggestions to the wording and removed the unneeded language feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97857/new/

[PATCH] D98414: [clangd] Turn off implicit cancellation based on client capabilities

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:153 +/// to cancel. Clients that always cancel stale requests should clear this. +bool ImplicitCancellation = true; + kadircet wrote: > this makes sense as is, but i

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

serge-sans-paille added a comment. would it make sense to syndicate the minimal version in a single variable, say `LLVM_MINIMAL_PYTHON_VERSION`, and use it in several place instead of hard-coding the value across multiple files? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

manojgupta accepted this revision. manojgupta added a comment. @MaskRay I have verified that Chrome OS builds are not affected by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97894/new/ https://reviews.llvm.org/D97894

[clang] 8d8a919 - [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

Author: Fangrui Song Date: 2021-03-11T10:13:01-08:00 New Revision: 8d8a9190db19b487198680adab9a6ca173f20bb3 URL: https://github.com/llvm/llvm-project/commit/8d8a9190db19b487198680adab9a6ca173f20bb3 DIFF: https://github.com/llvm/llvm-project/commit/8d8a9190db19b487198680adab9a6ca173f20bb3.diff

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d8a9190db19: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330023. arnamoy10 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Updating the patch to make -pedantic and -f2018 behave the same way, also updated the test case accordingly. CHANGES SINCE LAST ACTION

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ConfigFragment.h:244 + struct CompletionBlock { +/// Whether code completion should include results from scopes that are

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

kadircet updated this revision to Diff 330036. kadircet marked an inline comment as done. kadircet added a comment. - Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98037/new/ https://reviews.llvm.org/D98037 Files:

[PATCH] D98440: [NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes

aeubanks added a comment. This doesn't break the pipeline tests in llvm/test/Other? Running check-llvm with expensive checks is probably a good idea to see if there are any weird issues. Otherwise seems fine to me. Comment at:

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97857/new/ https://reviews.llvm.org/D97857

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

arlosi created this revision. Herald added subscribers: jansvoboda11, dexonsmith, dang. arlosi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds clang-cl support for the /ZH: option used to select MD5, SHA1, or SHA_256 hashing

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. The original implementation of the attribute on GitHub.com/apple/llvm-project also used the identifier instead of the declref, so we would like to go back to that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98450/new/ https://reviews.llvm.org/D98450

[PATCH] D98436: [Hexagon] Support inlined use of cs0 and cs1

sidneym updated this revision to Diff 330032. sidneym added a comment. Same patch, just added full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98436/new/ https://reviews.llvm.org/D98436 Files: clang/lib/Basic/Targets/Hexagon.cpp

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a reviewer: EricWF. akhuang added a subscriber: EricWF. akhuang added a comment. @EricWF, comments on using this attribute in libc++ vs fixing the code otherwise? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/

[PATCH] D98440: [NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes

mtrofin created this revision. mtrofin added reviewers: asbirlea, aeubanks. Herald added subscribers: steven_wu, hiraditya. mtrofin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Check with the analysis result by calling

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac292dafa776: [clangd] Add config block for Completion and option for AllScopes (authored by kadircet). Repository: rG LLVM Github Monorepo

  1   2   >