[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

efriedma added inline comments. Comment at: clang/test/Sema/vla.c:134 + // expected-warning@+1{{variable length array folded to constant array as an extension}} + char (*a9)[] = (char[2][ksize]) {{1,2,3,4},{4,3,2,1}}; + aaron.ballman wrote: > efriedma wrote:

[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

Jim created this revision. Jim added reviewers: khchen, craig.topper. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f198b0c27b0: [X86] Pass to transform amx intrinsics to scalar operation. (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

hjelmn updated this revision to Diff 330865. hjelmn added a comment. One more issue with the test. Made a mistake with whether there is a space before the colon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

hjelmn updated this revision to Diff 330834. hjelmn added a comment. Fixed a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:20 +#undef BUILTIN Can you undef TARGET_BUILTIN here too? I missed that when I added it on line 15. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98665: Correct Doxygen syntax for inline code

aaronpuchert created this revision. aaronpuchert added reviewers: george.karpenkov, gribozavr2. Herald added subscribers: dexonsmith, martong. Herald added a reviewer: aaron.ballman. aaronpuchert requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov added a comment. I don't know what is going on with the clang-format linux failure here. The patch it suggests looks awful... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98160/new/ https://reviews.llvm.org/D98160

[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[clang] fc12a64 - [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

Author: Pushpinder Singh Date: 2021-03-16T04:58:14Z New Revision: fc12a64ecc71bf6789b3ca67d3cda77acc8785f9 URL: https://github.com/llvm/llvm-project/commit/fc12a64ecc71bf6789b3ca67d3cda77acc8785f9 DIFF: https://github.com/llvm/llvm-project/commit/fc12a64ecc71bf6789b3ca67d3cda77acc8785f9.diff

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc12a64ecc71: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98638: [RFC][Coroutine] Force stack allocation after await_suspend() call

ChuanqiXu added a comment. It looks like there are two things this patch wants to do: 1. Don't put the temporary generated by symmetric-transfer on the coroutine frame. 2. Offer a mechanism to force some values (it is easy to extend Alloca to Value) to put in the stack instead of the coroutine

Re: [clang] 774b707 - Revert "Workaround a -Wmisleading-indentation warning"

Would be great to include details of why the patch was reverted - helps folks understand if this patch will address any issues they're seeing, or help avoid someone causing the same problem with a similar patch in the future. On Wed, Mar 10, 2021 at 3:36 PM Stephen Kelly via cfe-commits <

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 330860. atirit added a comment. Fixed remote build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

aaron.ballman added a comment. I'm not opposed to the attribute per se, but I'd like to understand the motivation behind it a bit more. It seems like it solves a special edge case for a specific linker and I'm wondering if that's sufficient motivation for the community to support the attribute

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith updated this revision to Diff 330629. bsmith added a comment. Herald added a subscriber: dexonsmith. - Add AutoUpgrade code to convert aarch64.neon.frintn to roundeven - Add test for above AutoUpgrade Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98030: [IR] Add vscale_range IR function attribute

paulwalker-arm added inline comments. Comment at: clang/test/CodeGen/arm-sve-vector-bits-vscale-range.c:10-14 +// CHECK-128: attributes #0 = { {{.*}} vscale_range(1,1) {{.*}} } +// CHECK-256: attributes #0 = { {{.*}} vscale_range(2,2) {{.*}} } +// CHECK-512: attributes #0 = {

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

kito-cheng added a comment. GCC use `vr` for vector register and `vm` for vector mask register. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98616/new/ https://reviews.llvm.org/D98616 ___ cfe-commits

[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

jansvoboda11 updated this revision to Diff 330647. jansvoboda11 added a comment. Implement suggested improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94950/new/ https://reviews.llvm.org/D94950 Files: clang/lib/Lex/LiteralSupport.cpp

[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1639 const char *Prefix = ThisTokBuf; - while (ThisTokBuf[0] != '(') + while (ThisTokBuf - Prefix < 16 && ThisTokBuf[0] != '(') ++ThisTokBuf; beccadax

[clang] ff91206 - [ASTMatchers][Dynamic] Add missing matchers from Registry

Author: Nathan James Date: 2021-03-15T13:07:39Z New Revision: ff9120636e9c890b4db735d252d16b92091dde55 URL: https://github.com/llvm/llvm-project/commit/ff9120636e9c890b4db735d252d16b92091dde55 DIFF: https://github.com/llvm/llvm-project/commit/ff9120636e9c890b4db735d252d16b92091dde55.diff LOG:

[PATCH] D98556: [ASTMatchers][Dynamic] Add missing matchers from Registry

This revision was automatically updated to reflect the committed changes. Closed by commit rGff9120636e9c: [ASTMatchers][Dynamic] Add missing matchers from Registry (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98556/new/

[PATCH] D98583: [ASTMatchers] Fix documentation for hasAnyBody matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG6badd3c52dc8: [ASTMatchers] Fix documentation for hasAnyBody matcher (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98583/new/

[clang] 6badd3c - [ASTMatchers] Fix documentation for hasAnyBody matcher

Author: Nathan James Date: 2021-03-15T13:06:49Z New Revision: 6badd3c52dc8a9c0a253a48722c569bfea4f URL: https://github.com/llvm/llvm-project/commit/6badd3c52dc8a9c0a253a48722c569bfea4f DIFF: https://github.com/llvm/llvm-project/commit/6badd3c52dc8a9c0a253a48722c569bfea4f.diff LOG:

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, nice one, LGTM. Comment at: llvm/test/CodeGen/AArch64/rand.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN:

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen added a comment. Thanks. This looks sensible, from what I can tell. Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:158 ]>; +def SDTFPRoundEvenOp : SDTypeProfile<1, 1, [ // froundeven + SDTCisFP<0>, SDTCisFP<1>, SDTCisOpSmallerThanOp<0, 1>,

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

jrtc27 added a comment. In D98616#2626094 , @jrtc27 wrote: > In D98616#2626093 , @kito-cheng > wrote: > >> GCC use `vr` for vector register and `vm` for vector mask register. > > How does that even work? Aren't

[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23cc8ebf59c6: [clang][lex] Speculative fix for buffer overrun on raw string parse (authored by jansvoboda11). Changed prior to commit:

[clang] 23cc8eb - [clang][lex] Speculative fix for buffer overrun on raw string parse

Author: Jan Svoboda Date: 2021-03-15T15:13:47+01:00 New Revision: 23cc8ebf59c661ebb988370a0edbcda37b61080a URL: https://github.com/llvm/llvm-project/commit/23cc8ebf59c661ebb988370a0edbcda37b61080a DIFF: https://github.com/llvm/llvm-project/commit/23cc8ebf59c661ebb988370a0edbcda37b61080a.diff

[PATCH] D97717: [SYCL] Rework the SYCL driver options

jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. I like the simplification of the command line interface. I have concerns about changing the tests just to make them pass though. Comment at:

[PATCH] D98416: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

aaron.ballman added a comment. Herald added a project: clang-tools-extra. > However this has opened a can of worms. Currenty float a = > std::numeric_limits::infinity(); is marked as narrowing. I think this is technically not narrowing, per http://eel.is/c++draft/dcl.init.list#7.2, because the

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

jrtc27 added a comment. In D98616#2626093 , @kito-cheng wrote: > GCC use `vr` for vector register and `vm` for vector mask register. How does that even work? Aren't multi character strings a set of options? Repository: rG LLVM Github Monorepo

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 330568. atirit added a comment. Added comments for the previous commit's changes and cleaned up those changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 Files:

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks added a comment. Please add a note to the release notes and also a test for a range based for with initializer (c++20). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3690-3691 +return (isAllowedByAfterEnum && isAllowedByShortEnums) || (Line.startsWith(tok::kw_class) && Style.BraceWrapping.AfterClass) ||

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. @NoQ, could you please have a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 ___ cfe-commits mailing list

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 330578. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files:

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. I would like to request that this commit be considered for merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 ___ cfe-commits

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3669-3688 +bool lineContainsBreakingTokens = false; +const FormatToken *breakingSearchToken = +while ((breakingSearchToken = breakingSearchToken->Next)) { + bool hasBreakingComma =

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

CarolineConcatto added a comment. Hi @ bsmith, Thank you for adding me as a reviewer, although I don't think I am the more qualified to approve or not this patch. But I have a question: Why is this patch only changing int_aarch64_neon_frintn and not int_aarch64_sve_frintn? Is there a

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm added inline comments. Comment at: clang/test/CodeGen/arm_acle.c:908 +#if __ARM_64BIT_STATE && defined(__ARM_FEATURE_RNG) +// AArch64-v8_3-LABEL: @test_rndr( +// AArch64-v8_3-NEXT: entry: SjoerdMeijer wrote: > stelios-arm wrote: > > SjoerdMeijer

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 330570. atirit added a comment. Attempting to fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330573. kbobyrev marked an inline comment as done. kbobyrev added a comment. Herald added a project: clang-tools-extra. Add the variable to Features.inc.in and canonicalize. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Let some time to others to have a look before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98214/new/

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

lebedev.ri added a comment. I think the implicit question is: won't this regress headers that are meant to be compatible with earlier standards? Did the original review mention anything about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/arm_acle.c:908 +#if __ARM_64BIT_STATE && defined(__ARM_FEATURE_RNG) +// AArch64-v8_3-LABEL: @test_rndr( +// AArch64-v8_3-NEXT: entry: stelios-arm wrote: > SjoerdMeijer wrote: > > Not sure if I

[PATCH] D98622: [-Wcalled-once-parameter] Let escapes overwrite MaybeCalled states

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit makes escapes symmetrical, meaning that having escape before

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. > Do you also get fatal error: 'opencl-c-base.h' file not found? If so, we > might need at least to file a clang bug that we should look at before the > next release. I'm able to reproduce it when not setting `-target` option explicitly: $

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

azabaznov added a comment. @Anastasia, thanks for landing this! Sorry for delay, I though that this can wait until Monday Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/ https://reviews.llvm.org/D98539

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

tmatheson added a comment. This seems quite an early point to bail out, so it will prevent some errors/warnings associated with initialization from being emitted. For example, this warning is currently emitted but would be suppressed by this patch: union { virtual int a(); int b =

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 330596. DmitryPolukhin added a comment. Rebase again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files:

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. In D97125#2603832 , @thopre wrote: > Requesting review since the logic has changed. This time I've also tested > isfinite against glibc's result. All looks good. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added a comment. As already described in the update I changed the option name and how it behaves. It is now more in line with EmptyLineBeforeAccessModifier. I hope this was the correct way to push the rewrite, since all line remarks are now off. Comment at:

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

njames93 added a comment. In D97563#2625513 , @lebedev.ri wrote: > I think the implicit question is: won't this regress headers that are meant > to be compatible with earlier standards? > Did the original review mention anything about this? Clang-tidy

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin added a comment. In D97563#2624680 , @njames93 wrote: > Is DAG required because the header file warnings are printed in a different > order depending on things like platform? @njames93 Thank you for review! Yes, on Windows build bot

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

aaron.ballman added a comment. The attribute bits look fine to me aside from the documentation request. Comment at: clang/include/clang/Basic/Attr.td:738 let Args = [UnsignedArgument<"Count">, DefaultIntArgument<"Offset", 0>]; let Documentation =

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:476 - // intrinsic. - def int_aarch64_neon_frintn : AdvSIMD_1FloatArg_Intrinsic; - If you are removing the old intrinsic (which is great), then it will need some AutoUpgrade

[PATCH] D98521: [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for replacements.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98521/new/ https://reviews.llvm.org/D98521

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330592. kbobyrev added a comment. Include Features.inc in Server.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang-tools-extra/clangd/CMakeLists.txt

[clang] 1974065 - [AST] Add generator for source location introspection

Author: Stephen Kelly Date: 2021-03-15T10:52:44Z New Revision: 19740652c4c4329e2b9e77f96e5e31c360b4e8bb URL: https://github.com/llvm/llvm-project/commit/19740652c4c4329e2b9e77f96e5e31c360b4e8bb DIFF: https://github.com/llvm/llvm-project/commit/19740652c4c4329e2b9e77f96e5e31c360b4e8bb.diff

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

luismarques added a comment. This makes sense to me but I'm not quite sure about the implications, especially when we consider compatibility. I think we need more eyes on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 330616. stelios-arm added a comment. Added tests in `arm_acle.c`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98264/new/ https://reviews.llvm.org/D98264 Files: clang/include/clang/Basic/BuiltinsAArch64.def

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12 +if (ENABLE_GRPC_REFLECTION) + set(REFLECTION_LIBRARY grpc++_reflection) kadircet wrote: > kbobyrev wrote: > > kadircet wrote: > > > can we move this

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330589. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files:

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith added a comment. > Why is this patch only changing int_aarch64_neon_frintn and not > int_aarch64_sve_frintn? > Is there a particular reason to do so? Things are done slightly differently for SVE in this regard, in principal yes, we could emit roundeven instead of frintn from the ACLE

[PATCH] D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:432 If a statement is marked ``nomerge`` and contains call expressions, those call -expressions inside the statement will not be merged during optimization. This +expressions inside the

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski added a comment. I tried reproducing the CI failures reported at the top (in particular `intrinsic_module_path.f90`), but haven't had much luck. @arnamoy10 - how about you? Could you `clang-format` this patch when uploading the next diff? Thank you! Comment at:

[PATCH] D97119: [flang][driver] Add options for -std=f2018

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:3535-3536 MarshallingInfoFlag>; -def pedantic : Flag<["-", "--"], "pedantic">, Group, Flags<[CC1Option]>, - MarshallingInfoFlag>; +def pedantic : Flag<["-", "--"], "pedantic">, Group,

[PATCH] D93164: [AST] Add generator for source location introspection

thakis added a comment. ast-dump-tool is still somewhere in lib/ instead of in tools/ in the reland as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164

[clang] c0cd527 - [ast-dump-tool] fix regression if --empty-implementation but --json-input-path is not

Author: Nico Weber Date: 2021-03-15T08:48:26-04:00 New Revision: c0cd5274ccdbe57edb20b0375b73a75c70a48882 URL: https://github.com/llvm/llvm-project/commit/c0cd5274ccdbe57edb20b0375b73a75c70a48882 DIFF: https://github.com/llvm/llvm-project/commit/c0cd5274ccdbe57edb20b0375b73a75c70a48882.diff

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S updated this revision to Diff 330588. Max_S added a comment. Changed the option to EmptyLineAfterAccessModifier and allowed the options Never, Leave and Always. Updated the tests accordingly and also added an entry in the changelog. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

paulwalker-arm added a comment. In D98487#2625673 , @bsmith wrote: >> Why is this patch only changing int_aarch64_neon_frintn and not >> int_aarch64_sve_frintn? >> Is there a particular reason to do so? > > Things are done slightly differently for SVE in

[clang] 74c270f - [ASTMatchers] Don't forward matchers in MapAnyOf

Author: Nathan James Date: 2021-03-15T14:16:52Z New Revision: 74c270f33eb16d336b4ab834e18b27f8efcbabe8 URL: https://github.com/llvm/llvm-project/commit/74c270f33eb16d336b4ab834e18b27f8efcbabe8 DIFF: https://github.com/llvm/llvm-project/commit/74c270f33eb16d336b4ab834e18b27f8efcbabe8.diff LOG:

[PATCH] D98497: [ASTMatchers] Don't forward matchers in MapAnyOf

This revision was automatically updated to reflect the committed changes. Closed by commit rG74c270f33eb1: [ASTMatchers] Dont forward matchers in MapAnyOf (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98497/new/

[clang] f60b353 - Stop traping on sNaN in __builtin_isinf

Author: Thomas Preud'homme Date: 2021-03-15T15:38:08Z New Revision: f60b35340fd70acb3c8003349931f085305886ad URL: https://github.com/llvm/llvm-project/commit/f60b35340fd70acb3c8003349931f085305886ad DIFF: https://github.com/llvm/llvm-project/commit/f60b35340fd70acb3c8003349931f085305886ad.diff

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

This revision was automatically updated to reflect the committed changes. Closed by commit rGf60b35340fd7: Stop traping on sNaN in __builtin_isinf (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 330681. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Herald added a project: clang-tools-extra. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3683 +Style.BraceWrapping.AfterEnum; +bool isLineTooBig = (strlen(Right.TokenText.data()) + + Right.OriginalColumn) > Style.ColumnLimit; curdeius

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 330670. stelios-arm added a comment. Change the `rand.ll` llc arguments to the ones that are only relevant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98264/new/ https://reviews.llvm.org/D98264 Files:

[PATCH] D98521: [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for replacements.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0333dde923c4: [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 0333dde - [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for replacements.

Author: Nathan James Date: 2021-03-15T14:20:48Z New Revision: 0333dde923c42219863f314d6c9fc0dcd352ef02 URL: https://github.com/llvm/llvm-project/commit/0333dde923c42219863f314d6c9fc0dcd352ef02 DIFF: https://github.com/llvm/llvm-project/commit/0333dde923c42219863f314d6c9fc0dcd352ef02.diff LOG:

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGda55af7f1d34: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] da55af7 - [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

Author: Dmitry Polukhin Date: 2021-03-15T07:32:45-07:00 New Revision: da55af7f1d348c133774d8e8117d60462363fef5 URL: https://github.com/llvm/llvm-project/commit/da55af7f1d348c133774d8e8117d60462363fef5 DIFF:

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

kito-cheng added a comment. Provide more implementation detail on GCC, - if a letter are used as a prefix of multi-char constraint, then it can't be used as a single letter constraint - e.g. If we defined `vr` and `vm` then we can't define `v` as constraint - constraint with same prefix

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith added inline comments. Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:158 ]>; +def SDTFPRoundEvenOp : SDTypeProfile<1, 1, [ // froundeven + SDTCisFP<0>, SDTCisFP<1>, SDTCisOpSmallerThanOp<0, 1>, SDTCisSameNumEltsAs<0, 1> dmgreen wrote: >

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330675. kbobyrev added a comment. Add explicit CMake option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

aaron.ballman added a comment. Thank you for looking into this! It looks like there are some unit test failures from the change: https://buildkite.com/llvm-project/premerge-checks/builds/29754#a9b04ab5-e326-4ff1-beea-773f21a33349 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

jdoerfert resigned from this revision. jdoerfert added a comment. I see the need for this to work, unsure if this is the right way, we need to make progress though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96769/new/

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

whisperity added a comment. In D98635#2626464 , @whisperity wrote: > Strange because I specifically ran both `check-clang` **and** > `check-clang-tools` locally, but will look into this. Turns out there is a `check-clang-extra-unit` too, and it looks

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

sammccall added a comment. Herald added a project: clang-tools-extra. I'm getting a little nervous about the amount of stuff we're packing into modules without in-tree examples. I should split out some of the "standard" features into modules as that's possible already. My model for modules

[PATCH] D98505: [clangd] Propagate data in diagnostics

sammccall added inline comments. Herald added a project: clang-tools-extra. Comment at: clang-tools-extra/clangd/Diagnostics.h:58 + /// If true, Clangd will populate the data field in LSP diagnostic + /// representation. This is used to prevent extra data transfer with old +

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab86edbc88fa: [AArch64] Implement __rndr, __rndrrs intrinsics (authored by stelios-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not handlings SourceRange highlights

whisperity created this revision. whisperity added reviewers: aaron.ballman, njames93. whisperity added projects: clang, clang-tools-extra. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun. whisperity requested review of this revision. Herald added a

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith updated this revision to Diff 330691. bsmith marked 3 inline comments as done. bsmith added a comment. - Prevent vscale_range(0,0) from crashing and instead don't add the attribute - Improve CHECK lines in arm-sve-vector-bits-vscale-range.c test - Test vscale_range(0,0) case and move some

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

zibi added a comment. LGTM, I just wonder if we can make an extra parameter to be default. I notice some places that is a default parameter but not in all instances. With default parameter some of the calls might be simplified if there is no need to override it. Comment at:

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 330694. stelios-arm added a comment. Typo fix for `__ARM_FEATURE_RNG` macro check in `aarch64-target-features.c`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98264/new/ https://reviews.llvm.org/D98264 Files:

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3579 +SectionCBVector.push_back(SectionCB); + } +} else { jdoerfert wrote: > Why do we unpack the children here instead of making a single call back for > the

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. This has been merged, closing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. Abandon CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcfd3fda7190: [OpenCL] Respect calling convention for builtin (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/

  1   2   >