[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity marked 12 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:657-660 +} else { + ParamTypes.push_back(QualType()); + ParamNames.push_back(StringRef()); +}

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

fanbo-meng updated this revision to Diff 331553. fanbo-meng added a comment. Herald added subscribers: sstefan1, phosek, s.egerton, jfb, mgrang, simoncook, fedor.sergeev, aheejin, krytarowski, dschuff. Herald added a reviewer: jfb. Herald added a reviewer: jdoerfert. clang-formatted CHANGES

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

protze.joachim added a comment. Hi Andrzej, thanks for the detailed insights. I think I really misunderstood, what the -W flags can do here. I also was not up-to-date regarding the state of the flang implementation. I just found, that compiling Spec OMP 2012 with clang-12 worked fine with my

[PATCH] D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeefda605fe17: [flang][driver] Add support for `-fget-symbols-sources` (authored by awarzynski). Changed prior to commit:

[clang] eefda60 - [flang][driver] Add support for `-fget-symbols-sources`

Author: Andrzej Warzynski Date: 2021-03-18T14:13:24Z New Revision: eefda605fe1701937a8fe5379357e0990ad2fb4e URL: https://github.com/llvm/llvm-project/commit/eefda605fe1701937a8fe5379357e0990ad2fb4e DIFF: https://github.com/llvm/llvm-project/commit/eefda605fe1701937a8fe5379357e0990ad2fb4e.diff

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331581. njames93 added a comment. Fix formatting issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/test/SemaCXX/constructor-initializer.cpp

[PATCH] D98834: [OPENMP51]Support for the 'destroy' clause with interop variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f8e158f57c: [OPENMP51]Support for the destroy clause with interop variable. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] c2f8e15 - [OPENMP51]Support for the 'destroy' clause with interop variable.

Author: Mike Rice Date: 2021-03-18T09:12:56-07:00 New Revision: c2f8e158f57c173298ac39db8fd44211604ed003 URL: https://github.com/llvm/llvm-project/commit/c2f8e158f57c173298ac39db8fd44211604ed003 DIFF: https://github.com/llvm/llvm-project/commit/c2f8e158f57c173298ac39db8fd44211604ed003.diff

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity marked 5 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:377 + + bool indicatesMixability() const { return Flags > MIX_None; } + aaron.ballman wrote: >

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske updated this revision to Diff 331485. balazske added a comment. Add accidentally removed empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502 Files:

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. This patch broke clang-ppc64le-rhel builder. The patch makes MSVC-compatible driver honour CLANG_DEFAULT_LINKER setting, which this builder sets to “lld”. Therefore there’s an expected change in the output now that CLANG_DEFAULT_LINKER can override link.exe.

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 331528. arnamoy10 added a comment. Fixing bug in test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 331560. whisperity marked 2 inline comments as done. whisperity added a comment. - **NFC** Fixed some nits - Added a new check option, //`MinimumIdentifierNameLength`// instead of a hardcoded `3` value. Defaults to `3`. - Fixed an issue with heuristics

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95736/new/ https://reviews.llvm.org/D95736 ___ cfe-commits mailing list

[PATCH] D98855: [OpenCL] Support template parameters for as_type

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaOpenCLCXX/template-astype.cl:5 +auto templated_astype(T x) { + return as_int2(x); + // expected-error@-1{{invalid reinterpretation:

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

aaronpuchert updated this revision to Diff 331567. aaronpuchert added a comment. Negative capabilities don't need to be considered as managed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98747/new/ https://reviews.llvm.org/D98747 Files:

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

jnykiel updated this revision to Diff 331570. jnykiel retitled this revision from "[Tooling] Handle compilation databases with clang-cl commands generated by CMake 3.19+" to "[Tooling] Handle compilation databases containing commands with double dashes". jnykiel edited the summary of this

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

awarzynski added a comment. Hi @protze.joachim, Thank you for your feedback. I'm sorry that this is causing issues in your set-up. In D95460#2632844 , @protze.joachim wrote: > Before this patch, clang would happily ignore a `-ffree-form` flag. It's a

[PATCH] D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer.

jansvoboda11 removed a reviewer: jansvoboda11. jansvoboda11 added inline comments. Herald added a subscriber: jansvoboda11. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:640 +StringRef CheckList = A->getValue(); +Opts.TidyChecks.emplace_back(CheckList); + }

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:347-349 +static bool areTypesCompatible(QualType ArgType, QualType ParamType, + const ASTContext ) { + if (ArgType.isNull()

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 331564. whisperity marked 4 inline comments as done. whisperity added a comment. **NFC** Turned some `Optional` into just `T`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78652/new/

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:529 +/// ReturnStmts return them from the function. +class Returned { + llvm::SmallVector ReturnedParams; aaron.ballman wrote: > whisperity

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov added a comment. @SureYeaah , does this fix your internal buildbot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862 ___ cfe-commits mailing list

[PATCH] D98415: [aarch64][WOA64][docs] Release note for WoA-hosted LLVM 12 binary

maxim-kuvyrkov closed this revision. maxim-kuvyrkov added a comment. This is merged to release/12.x branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98415/new/ https://reviews.llvm.org/D98415 ___

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity marked an inline comment as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:657-660 +} else { + ParamTypes.push_back(QualType()); + ParamNames.push_back(StringRef()); +}

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. In D97869#2628679 , @azabaznov wrote: > I have one more though. > > I like the idea of turning `opencl-c.h` into the test: as it is already in > the repo and is already being used for quite a while we can assume it as a >

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2632848 , @rjmccall wrote: > In D96033#2630978 , @v.g.vassilev > wrote: > I'm nervous in general about the looming idea of declaration unloading, but the fact

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:292 + std::string driverPath = llvm::sys::fs::getMainExecutable(nullptr, nullptr); + driverPath = driverPath.substr(0, driverPath.size() - 9); + return

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

fanbo-meng created this revision. fanbo-meng added reviewers: abhina.sreeskantharajan, muiez, Kai, anirudhp, DanielMcIntosh-IBM. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On z/OS there is a hard limitation on on the

[PATCH] D98868: [Driver] Add -print-runtime-dir

zero9178 created this revision. zero9178 added reviewers: rnk, phosek, MaskRay. Herald added subscribers: jansvoboda11, dang. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a new command line option to clang which

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

fanbo-meng updated this revision to Diff 331559. fanbo-meng added a comment. remove accidentally included diff patch file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98864/new/ https://reviews.llvm.org/D98864 Files: clang/include/clang/Basic/TargetInfo.h

[clang] c539be1 - [Hexagon] Add support for named registers cs0 and cs1

Author: Sid Manning Date: 2021-03-18T09:53:22-05:00 New Revision: c539be1dcbcf88530cfaf1728b077feb564b72ec URL: https://github.com/llvm/llvm-project/commit/c539be1dcbcf88530cfaf1728b077feb564b72ec DIFF: https://github.com/llvm/llvm-project/commit/c539be1dcbcf88530cfaf1728b077feb564b72ec.diff

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:377 + + bool indicatesMixability() const { return Flags > MIX_None; } + Should this be `MIX_WorkaroundDisableCanonicalEquivalence` instead

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov created this revision. maxim-kuvyrkov added a reviewer: asl. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After https://reviews.llvm.org/D98493 clang driver for *-msvc target uses linker from

[PATCH] D98867: [HIP] Fix ROCm detection

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. ROCm has changed installation path to /opt/rocm-{release}. Add detection for that. Also support ROCM_PATH environment variable.

[PATCH] D72235: [clang-tidy] new altera unroll loops check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Mostly just nits for the check, otherwise this LGTM. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:65 +} +if (isa(Loop) ||

[PATCH] D98873: Document -fcrash-diagnostics-dir

probinson created this revision. probinson added a reviewer: hans. Herald added subscribers: jansvoboda11, dang. probinson requested review of this revision. Herald added a project: clang. This was added in LLVM 7.0 but without help text or other docs. Repository: rG LLVM Github Monorepo

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

luismarques added a comment. I just looked at this again and I don't have the full context in my mind right now but won't the test just exercise the BareMetal toolchain and not your changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. In D98113#2634758 , @luismarques wrote: > I just looked at this again and I don't have the full context in my mind > right now but won't the test just exercise the BareMetal toolchain and not > your changes? I've since lost my

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331582. njames93 added a comment. Arc got confused Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

asl added a comment. Indeed! And even worse, there is another 'A' shadowing definition below :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 ___ cfe-commits

[PATCH] D98757: [AMX] Not fold constant bitcast into amx intrisic

fhahn added a comment. In D98757#2633396 , @xiangzhangllvm wrote: > In D98757#2631042 , @lebedev.ri > wrote: > >> The ongoing special-casing of `X86_AMXTy` through the llvm due to the >> inability of the

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. What if CLANG_DEFAULT_LINKER=ld? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493 ___ cfe-commits mailing list

[PATCH] D98855: [OpenCL] Support template parameters for as_type

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Implement the TreeTransform for AsTypeExpr. Split `BuildAsTypeExpr` out of

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:51 +{true, 40, 50}, // Substring. +{true, 50, 66}, // Levenshtein. +{true, 75, 85}, // Jaro-Winkler. varjujan

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. Thank you. I'm not looking at this test case: void opaque(void); void opaque2(void); void opaque3(void); @class C; int main(int argc, const char * argv[]) { __attribute__((nomerge)) @try { opaque(); } @catch(C *c) { opaque2(); }

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER is set to ld. It would be nice to make the tests more tolerant. Can we revert this patch until then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c5c4a88 - [OpenCL] Remove spurious atomic_fetch tablegen builtins

Author: Sven van Haastregt Date: 2021-03-18T12:17:12Z New Revision: c5c4a88a840037fd38cb35d5efd524d51dcc091b URL: https://github.com/llvm/llvm-project/commit/c5c4a88a840037fd38cb35d5efd524d51dcc091b DIFF: https://github.com/llvm/llvm-project/commit/c5c4a88a840037fd38cb35d5efd524d51dcc091b.diff

[PATCH] D98520: [OpenCL] Remove spurious atomic_fetch tablegen builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5c4a88a8400: [OpenCL] Remove spurious atomic_fetch tablegen builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98520/new/

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing! I'm curious, how did you find this case? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98852/new/

[clang] 8b8b9af - [-Wcalled-once-parameter][NFC] Fix GCC compilation error

Author: Valeriy Savchenko Date: 2021-03-18T14:49:24+03:00 New Revision: 8b8b9af8c9132acb446fc42569de8a0f57c6b556 URL: https://github.com/llvm/llvm-project/commit/8b8b9af8c9132acb446fc42569de8a0f57c6b556 DIFF:

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen created this revision. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls, mgorny. sdesmalen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In order to bring up scalable vector support in LLVM

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:31-32 + + char DissimilarBelow; + char SimilarAbove; + aaron.ballman wrote: > `signed char` since we're doing `> -1` below? Or better yet,

[PATCH] D98688: [-Wcalled-once-parameter] Harden analysis in terms of block use

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1a7d5a7b0ec: [-Wcalled-once-parameter] Harden analysis in terms of block use (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c1fb23c - [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec

Author: Balazs Benics Date: 2021-03-18T13:06:38+01:00 New Revision: c1fb23c1aadd22e736c4a1c36c146bbfbc48f959 URL: https://github.com/llvm/llvm-project/commit/c1fb23c1aadd22e736c4a1c36c146bbfbc48f959 DIFF: https://github.com/llvm/llvm-project/commit/c1fb23c1aadd22e736c4a1c36c146bbfbc48f959.diff

[clang] e5cd5b3 - [test] Fix variable definition in acle_sve_ld1.sh

Author: Thomas Preud'homme Date: 2021-03-18T12:15:45Z New Revision: e5cd5b352ff481f02e1f4555033edf87112dcc0c URL: https://github.com/llvm/llvm-project/commit/e5cd5b352ff481f02e1f4555033edf87112dcc0c DIFF: https://github.com/llvm/llvm-project/commit/e5cd5b352ff481f02e1f4555033edf87112dcc0c.diff

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5cd5b352ff4: [test] Fix variable definition in acle_sve_ld1.sh (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98852/new/

[PATCH] D98824: [Tooling] Handle compilation databases with clang-cl commands generated by CMake 3.19+

kadircet added a comment. thanks for looking into this! we also had a related report about this in clangd , but didn't have time to dive into it. this is definitely fixing an issue in interpolating compilation database, but unfortunately there are

[PATCH] D98694: [-Wcalled-once-parameter] Fix false positives for cleanup attr

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a7afc9a8843: [-Wcalled-once-parameter] Fix false positives for cleanup attr (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, jrtc27, rogfer01, frasercrmck, HsiangKai, evandro. Herald added subscribers: vkmr, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck,

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

thopre created this revision. thopre added reviewers: andwar, david-arm, sdesmalen, SjoerdMeijer, kmclaughlin. Herald added a subscriber: tschuett. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang test acle_sve_ld1.sh is

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 331532. whisperity marked 3 inline comments as done. whisperity added a comment. **NFC** Made the code more legible, updated and clarified some comments, fixed grammar issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske updated this revision to Diff 331484. balazske added a comment. Change of text in dump, add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502 Files:

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov added a comment. The patch was wrong. We use "const Arg *A" at the end of GetLinkerPath, so can't remove it. I thought I tested this, but, apparently, not. Reverted in 62948c4532d59b59f63409eae5d7f9e4990e5626

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity marked 8 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:51 +{true, 40, 50}, // Substring. +{true, 50, 66}, // Levenshtein. +{true, 75, 85}, //

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

varjujan added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:51 +{true, 40, 50}, // Substring. +{true, 50, 66}, // Levenshtein. +{true, 75, 85}, // Jaro-Winkler. whisperity wrote: >

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2634107 , @SureYeaah wrote: > We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER > is set to ld. It would be nice to make the tests more tolerant. > > Can we revert this patch until then?

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

thopre added a comment. In D98852#2634189 , @sdesmalen wrote: > LGTM, thanks for fixing! > > I'm curious, how did you find this case? :) The issue was caught by a patch of mine to FileCheck: https://reviews.llvm.org/D98691 Repository: rG LLVM Github

[clang] 62948c4 - Revert "[NFC] Minor cleanup to use default setting of getLastArg()"

Author: Maxim Kuvyrkov Date: 2021-03-18T08:07:02Z New Revision: 62948c4532d59b59f63409eae5d7f9e4990e5626 URL: https://github.com/llvm/llvm-project/commit/62948c4532d59b59f63409eae5d7f9e4990e5626 DIFF: https://github.com/llvm/llvm-project/commit/62948c4532d59b59f63409eae5d7f9e4990e5626.diff

[PATCH] D87981: [X86] AMX programming model.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:90 +INITIALIZE_PASS_BEGIN(X86PreTileConfig, "tilepreconfig", + "Tile Register Configure", false, false) +INITIALIZE_PASS_DEPENDENCY(MachineDominatorTree)

[clang] f1a7d5a - [-Wcalled-once-parameter] Harden analysis in terms of block use

Author: Valeriy Savchenko Date: 2021-03-18T12:12:18+03:00 New Revision: f1a7d5a7b0ec810057ff6e88371ab86d1fce812c URL: https://github.com/llvm/llvm-project/commit/f1a7d5a7b0ec810057ff6e88371ab86d1fce812c DIFF:

[clang] 4a7afc9 - [-Wcalled-once-parameter] Fix false positives for cleanup attr

Author: Valeriy Savchenko Date: 2021-03-18T12:32:16+03:00 New Revision: 4a7afc9a8843f4793296a260f7153fd2ef4ec497 URL: https://github.com/llvm/llvm-project/commit/4a7afc9a8843f4793296a260f7153fd2ef4ec497 DIFF:

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2634089 , @SureYeaah wrote: > What if CLANG_DEFAULT_LINKER=ld? @SureYeaah , then *-msvc targets will attempt to use "ld" linker as instructed. Or are you asking about something else? Repository: rG LLVM

[clang] d8b8f54 - [Reland] "Do not apply calling conventions to MSVC entry points"

Author: Elizabeth Andrews Date: 2021-03-18T04:26:47-07:00 New Revision: d8b8f544d9de30cd14584094596090d3f9992345 URL: https://github.com/llvm/llvm-project/commit/d8b8f544d9de30cd14584094596090d3f9992345 DIFF:

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

This revision was automatically updated to reflect the committed changes. eandrews marked an inline comment as done. Closed by commit rGd8b8f544d9de: [Reland] Do not apply calling conventions to MSVC entry points (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D98707: [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1fb23c1aadd: [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec (authored by Balazs Benics balazsben...@sigmatechnology.se). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98876: [clang][ASTImporter] Add import support for SourceLocExpr.

balazske created this revision. Herald added subscribers: martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is

[PATCH] D98338: [clang-tidy] Fix bugprone-terminating-continue when continue appears inside a switch

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Herald added a project: clang-tools-extra. LGTM, but please commit with a better commit message. Comment at:

[PATCH] D98892: [HWASan] Mention x86_64 aliasing mode in design doc.

morehouse updated this revision to Diff 331670. morehouse added a comment. - Format `fork()` as code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98892/new/ https://reviews.llvm.org/D98892 Files:

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tianshilei1992 created this revision. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tra added a comment. > My question is, if DeviceOffloadingKind == Action::OFK_Cuda, and we use -S, > do we also want to skip as well? I do not think so. Libdevice is needed to implement some libcalls that LLVM currently does not know how to handle. We do need it even when we compile with `-S`.

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

zoecarver created this revision. zoecarver added a reviewer: rsmith. zoecarver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because MSVC will not treat the definition of a static data member as part of the declaration, it will not get

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

zoecarver added a comment. So, as I mentioned in the description of this patch, the reason that these members are treated as definitions is that Clang implicitly marks them as inline when targeting MS. This is sort of interesting a) because it only applies to constexpr vars, and b) because

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

rsmith added a comment. In D98904#2636021 , @zoecarver wrote: > So, as I mentioned in the description of this patch, the reason that these > members are treated as definitions is that Clang implicitly marks them as > inline when targeting MS. This is

[PATCH] D98907: [WebAssembly] Remove qfma/qfms from wasm_simd128.h

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These experimental builtin

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98887/new/ https://reviews.llvm.org/D98887 ___

[PATCH] D98746: [clang][amdgpu] Use implicit code object default

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1115-1124 + // Currently defaults to 3 in AMDGPUBaseInfo.cpp + // Using that default lets clang emit IR for amdgcn when llvm has been built + // without that target, provided the user wants this

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c740b29fae3: [clang-cl] make -ffile-compilation-dir a CoreOption. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98892: [HWASan] Mention x86_64 aliasing mode in design doc.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:279 + +HWASAN's approach is not applicable to 32-bit architectures. This

[PATCH] D98893: Updated comment "the low bit" -> "the integer".

haberman created this revision. haberman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98893 Files: clang/include/clang/Sema/Initialization.h Index:

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic created this revision. asavonic added a reviewer: andrew.w.kaylor. Herald added a subscriber: pengfei. asavonic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch attempts to fix a compiler crash that occurs when `long

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

amyk added a comment. Hi, Thanks for fixing the tests. I've tested this patch on the environment of `clang-ppc64le-rhel` (https://lab.llvm.org/buildbot/#/builders/57), and there seems to be two failures that still remain: Failed Tests (2): Clang :: OpenMP/linking.c Clang ::

[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

haberman marked an inline comment as done. haberman added a comment. > Thanks! Do we need InitializedEntity::getDecl to return a pointer to > non-const? Yes, if I try to propagate `const` the change starts to snowball. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98881: [RISCV] Fix mcount name for Linux

jrtc27 added a comment. This should really be for all OSes on RISC-V, which I think means copying it N times? :/ (GCC defines MCOUNT_NAME in riscv/riscv.h, not riscv/linux.h) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98881/new/

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

rjmccall added a comment. Yes, I think that would be reasonable, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 ___ cfe-commits mailing list

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tianshilei1992 added a comment. In D98902#2635930 , @tra wrote: >> My question is, if DeviceOffloadingKind == Action::OFK_Cuda, and we use -S, >> do we also want to skip as well? > > I do not think so. Libdevice is needed to implement some libcalls that

[PATCH] D98338: [clang-tidy] Fix bugprone-terminating-continue when continue appears inside a switch

njames93 updated this revision to Diff 331713. njames93 marked an inline comment as done. njames93 added a comment. Add test case for do inside switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98338/new/ https://reviews.llvm.org/D98338

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

kkwli0 added a comment. I tried the patch in our environment and it works. LG. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98902/new/ https://reviews.llvm.org/D98902 ___ cfe-commits mailing

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.org/D97993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98904: Instantiate static constexpr data members on MS ABI.

zoecarver added a comment. > (I think you're missing something here to trigger the instantiation of the > class, such as Invalid x;.) Yes, you're right. > The above example is valid in C++17 onwards, because in C++17 onwards, static > constexpr data members are implicitly inline, and the

  1   2   >