[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 335195. ffrankies added a comment. - Addressed comments from the automated pre-merge checks - Moved link to external documentation to the end of `clang-tools-extra/docs/clang-tidy/checks/altera-id-dependent-backward-branch.rst` as requested by

[PATCH] D99688: [CUDA][HIP] rename -fcuda-flush-denormals-to-zero

This revision was automatically updated to reflect the committed changes. Closed by commit rG907af8439672: [CUDA][HIP] rename -fcuda-flush-denormals-to-zero (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 907af84 - [CUDA][HIP] rename -fcuda-flush-denormals-to-zero

Author: Yaxun (Sam) Liu Date: 2021-04-05T00:13:51-04:00 New Revision: 907af8439672e47cf978b43625d9318dd34e13ab URL: https://github.com/llvm/llvm-project/commit/907af8439672e47cf978b43625d9318dd34e13ab DIFF:

[PATCH] D99688: [CUDA][HIP] rename -fcuda-flush-denormals-to-zero

yaxunl updated this revision to Diff 335192. yaxunl marked an inline comment as done. yaxunl added a comment. rebase and add tests for old options CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99688/new/ https://reviews.llvm.org/D99688 Files: clang/include/clang/Driver/Options.td

[PATCH] D99688: [CUDA][HIP] rename -fcuda-flush-denormals-to-zero

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/cuda-flush-denormals-to-zero.cu:2 // Checks that cuda compilation does the right thing when passed -// -fcuda-flush-denormals-to-zero. This should be translated to +//

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 335182. SaurabhJha added a comment. Move the definition of MatrixCast to the bottom in OperationKinds.def Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 Files:

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. In D99037#2668295 , @SaurabhJha wrote: > One other problem is somehow this test is failing > https://github.com/llvm/llvm-project/blob/main/clang/test/SemaOpenCL/sampler_t_overload.cl#L6 > with this error. > >

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:29 + // Is this: long r = int(x) * int(y); ? + // FIXME: shall we skip brackets/casts/etc? + auto *BO = dyn_cast(E);

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 335169. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. @aaron.ballman thank you for taking a look! Addressing all review notes other than `ssize_t` and `static_cast<>()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. One other problem is somehow this test is failing https://github.com/llvm/llvm-project/blob/main/clang/test/SemaOpenCL/sampler_t_overload.cl#L6 with this error. /tmp/clang/test/SemaOpenCL/sampler_t_overload.cl:6:30: error: initializer element is not a

[clang] 292726b - [HIP, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-04T19:30:49+01:00 New Revision: 292726b6443c7d7be4bb03af40cd3f60188b2ff7 URL: https://github.com/llvm/llvm-project/commit/292726b6443c7d7be4bb03af40cd3f60188b2ff7 DIFF:

[PATCH] D99832: [HIP, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG292726b6443c: [HIP, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99832/new/

[PATCH] D99831: [HIP-Clang, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rGa41b5100e438: [HIP-Clang, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99831/new/

[clang] a41b510 - [HIP-Clang, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-04T19:30:27+01:00 New Revision: a41b5100e43810694c09469bc725f560e7ef239f URL: https://github.com/llvm/llvm-project/commit/a41b5100e43810694c09469bc725f560e7ef239f DIFF:

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +}

[PATCH] D99852: [Driver] Detect libstdc++ include paths for native gcc (-m32 and -m64) on Debian i386

This revision was automatically updated to reflect the committed changes. Closed by commit rGe92d2b80c6c9: [Driver] Detect libstdc++ include paths for native gcc (-m32 and -m64) on… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e92d2b8 - [Driver] Detect libstdc++ include paths for native gcc (-m32 and -m64) on Debian i386

Author: Fangrui Song Date: 2021-04-04T10:15:12-07:00 New Revision: e92d2b80c6c913b5c506df06a913a2ecbf761617 URL: https://github.com/llvm/llvm-project/commit/e92d2b80c6c913b5c506df06a913a2ecbf761617 DIFF: https://github.com/llvm/llvm-project/commit/e92d2b80c6c913b5c506df06a913a2ecbf761617.diff

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- created this revision. Qix- added a reviewer: aaron.ballman. Qix- added a project: clang. Herald added a subscriber: mgorny. Qix- requested review of this revision. Herald added a subscriber: cfe-commits. Currently, user-defined attributes (e.g. those registered via Clang plugins) don't

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 335154. Ericson2314 added a comment. Put on top of D99860 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 Files:

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added a comment. See also D99860 . We may still want to remove `clang/runtime`, but I don't think it's necessary. I will turn this revision into one on top of that just for for removing `clang/runtime`. Repository: rG LLVM Github Monorepo

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. It turns out we don't neeed to remove `clang/runtime` to make this work, as @phosek

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 335149. Ericson2314 added a comment. Remove stray `COMPILER_RT_INSTALL_PATH` I am uncertain about is the redefining of `CMAKE_INSTALL_PREIX` in `compiler-rt/cmake/base-config-ix.cmake`. This occurs under `LLVM_TREE_AVAILABLE`. If this is just for

[PATCH] D99852: [Driver] Detect libstdc++ include paths for native gcc (-m32 and -m64) on Debian i386

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Many thanks. it fixed my issues! /usr/include/i386-linux-gnu/c++/8 is indeed much nicer :) Thanks for all your hard work on fixing the header detection. it was indeed too

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. In D98070#2616042 , @lebedev.ri wrote: > Please also add a test with global `IgnoreMacros=1` and >

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5011 +!ValType->isFloatingType()) { + Diag(ExprRange.getBegin(), diag::err_atomic_op_needs_atomic_int_ptr_or_fp) << IsC11 << Ptr->getType() << Ptr->getSourceRange();

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a comment. In D75844#2668095 , @thakis wrote: > The test fails on macOS: http://45.33.8.238/macm1/6821/step_6.txt > > Please take a look and revert for now if it takes a while to fix. I've committed a speculative fix in

[clang] 241d42c - Speculative fix for failing build bot.

Author: Aaron Ballman Date: 2021-04-04T10:58:56-04:00 New Revision: 241d42c38226e46ff01b774da3167ec54420bf24 URL: https://github.com/llvm/llvm-project/commit/241d42c38226e46ff01b774da3167ec54420bf24 DIFF: https://github.com/llvm/llvm-project/commit/241d42c38226e46ff01b774da3167ec54420bf24.diff

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

thakis added a comment. The test fails on macOS: http://45.33.8.238/macm1/6821/step_6.txt Please take a look and revert for now if it takes a while to fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:67 + << FixItHint::CreateInsertion(E->getBeginLoc(), +"(" + Ty.getAsString() + ")(") + <<

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 marked an inline comment as done. benshi001 added a comment. In D96853#2661168 , @Anastasia wrote: > In D96853#2660443 , @benshi001 wrote: > >> In D96853#2659266 ,

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +

[PATCH] D99831: [HIP-Clang, test] Fix use of undef FileCheck var

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99831/new/ https://reviews.llvm.org/D99831

[PATCH] D99832: [HIP, test] Fix use of undef FileCheck var

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99832/new/ https://reviews.llvm.org/D99832

[PATCH] D99857: [OpenCL, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: hliao, craig.topper, neil.hickey, yaxunl, baldrick. Herald added subscribers: ldrumm, Anastasia. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGenOpenCL/fpmath.cl uses a variable defined in an earlier

[PATCH] D99852: [Driver] Detect libstdc++ include paths for native gcc (-m32 and -m64) on Debian i386

MaskRay added a comment. From an upstream multiarch build of gcc, the libstdc++ search paths are /tmp/opt/gcc-debug/lib/gcc/x86_64-pc-linux-gnu/11.0.1/../../../../include/c++/11.0.1 /tmp/opt/gcc-debug/lib/gcc/x86_64-pc-linux-gnu/11.0.1/../../../../include/c++/11.0.1/x86_64-pc-linux-gnu