[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski updated this revision to Diff 335587. awarzynski added a comment. Remove unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99645/new/ https://reviews.llvm.org/D99645 Files: clang/include/clang/Driver/Options.td

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

dblaikie added a comment. In D99160#2670460 , @djtodoro wrote: > In D99160#2669576 , @dblaikie wrote: > >> In D99160#2668977 , @djtodoro wrote: >> >>> I think that the Debug

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: flang/test/Parser/omp-allocate-unparse.f90:1 -! RUN: %f18 -fdebug-no-semantics -funparse -fopenmp %s | FileCheck %s +! RUN: %flang_fc1 -fdebug-unparse-no-sema -fopenmp %s | FileCheck %s ! Check Unparsing of OpenMP Allocate directive

[PATCH] D99963: [RISCV][Clang] Add RVV merge intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99963/new/ https://reviews.llvm.org/D99963

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

aganea created this revision. aganea added reviewers: abhina.sreeskantharajan, rnk, amccarth, MaskRay, mstorsjo. aganea requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Validate that we properly generating a single line ending on Windows

[PATCH] D99683: [HIP] Support ThinLTO

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:1904-1907 +def foffload_lto : Flag<["-"], "foffload-lto">, Flags<[CoreOption]>, Group, + HelpText<"Enable LTO in 'full' mode for offload compilation">; +def fno_offload_lto : Flag<["-"],

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99741/new/ https://reviews.llvm.org/D99741

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

ashermancinelli added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:127 + + auto {*ci.parsing().parseTree()}; + Is this variable unused? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:315 +multiclass RVVFloatingWidenTerBuiltinSet { + let HasMaskedOffOperand = false, Log2LMUL = [-2, -1, 0, 1, 2] in { +defm "" : RVVOutOp1Op2BuiltinSet HsiangKai wrote: > > why is there

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 335573. yaxunl added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99601/new/ https://reviews.llvm.org/D99601

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 335571. yaxunl marked an inline comment as done. yaxunl added a comment. revert the change about option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

NoQ accepted this revision. NoQ added a comment. I mean, the extent of an `ElementRegion` //is// the size of a single element. The reason why our intrinsic isn't doing what you expect is because we represent the pointer with offset as `ElementRegion` regardless of whether operator `[]` was

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

yroux added a comment. > I've committed this and it looks like the bot is back to green :) > https://lab.llvm.org/buildbot/#/builders/65/builds/1400. Sorry for the > delayed fix Great, thanks a lot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2670552 , @yroux wrote: > Hi, > > Sorry I'm bit lost in the various patches proposed to fix the issue > introduced by https://reviews.llvm.org/D97785 > My understanding is that this is missing one to

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added a comment. If there are no more comments, I'll commit the patch soon. What do you think? @aprantl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99250/new/ https://reviews.llvm.org/D99250 ___

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82b3e28e836d: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead… (authored by abhina.sreeskantharajan). Repository:

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c:35 +vint16mf4_t test_vwadd_vx_i16mf4(vint8mf8_t op1, int8_t op2, size_t vl) { + return vwadd_vx(op1, op2, vl); +} khchen wrote: > khchen wrote: > >

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

vsavchenko added a comment. In D69726#2671611 , @Charusso wrote: > In D69726#2671526 , @vsavchenko > wrote: > >> @Charusso >> It looks like this patch introduced a some weird false positive on >> PostgreSQL

[PATCH] D99959: [analyzer][NFC] Add tests for extents

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. More tests are great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99959/new/ https://reviews.llvm.org/D99959

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked an inline comment as done. yaxunl added a comment. In D99683#2669136 , @yaxunl wrote: > In D99683#2669080 , @tejohnson wrote: > >> In D99683#2669047 , @yaxunl

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/x86-64-intrcc-uintr.ll:1 +; RUN: llc < %s | FileCheck %s -check-prefixes=CHECK,CHECK-USER +; RUN: llc -O0 < %s | FileCheck %s -check-prefixes=CHECK0,CHECK0-USER Please use

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski updated this revision to Diff 335566. awarzynski added a comment. Update `f18.cpp` and driver-help.f90 to improve testing - added -fdebug-unparse-no-sema and -fdebug-dump-parse-tree-no-sema in f18.cpp (for compatibility with flang-new) - updated driver-help.f90 with the new options

[PATCH] D99194: [analyzer] Fix body farm for Obj-C++ properties

NoQ added inline comments. Comment at: clang/lib/Analysis/BodyFarm.cpp:757 + if (PI->getPropertyDecl()) { +Prop = PI->getPropertyDecl(); +if (Prop->getGetterName() == MD->getSelector()) At this point `Prop` may contain a completely unrelated

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17944 + + // P extension +#define EMIT_BUILTIN(NAME, INT) \ Please put this above the vector extension since the comment says "vector builtins are handled from here"

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

kda updated this revision to Diff 335558. kda added a comment. fixed tests for asan_interface.inc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99630/new/ https://reviews.llvm.org/D99630 Files: clang/docs/AddressSanitizer.rst

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

svenvh created this revision. svenvh added reviewers: Anastasia, azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The .rgba vector component accessors are supported in OpenCL C

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso added a comment. In D69726#2671526 , @vsavchenko wrote: > @Charusso > It looks like this patch introduced a some weird false positive on PostgreSQL > F16161734: report-guc.c-ParseLongOption-13-1.html > >

[PATCH] D99199: Make -fcrash-diagnostics-dir control the Windows (mini-)dump location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04b3c8c52c54: Pass -fcrash-diagnostics-dir along to LLVM (authored by probinson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 04b3c8c - Pass -fcrash-diagnostics-dir along to LLVM

Author: Paul Robinson Date: 2021-04-06T09:30:52-07:00 New Revision: 04b3c8c52c549ee57e69a1b23484b8c4109f83b8 URL: https://github.com/llvm/llvm-project/commit/04b3c8c52c549ee57e69a1b23484b8c4109f83b8 DIFF: https://github.com/llvm/llvm-project/commit/04b3c8c52c549ee57e69a1b23484b8c4109f83b8.diff

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

delesley accepted this revision. delesley added a comment. This revision is now accepted and ready to land. I am convinced by your argument. I think it is reasonable to assume that if someone is using an RAII object, then the underlying object is responsible for managing double locks/unlocks,

[PATCH] D99659: [analyzer][taint] Extent of heap regions should get taint sometimes

steakhal abandoned this revision. steakhal added a comment. Obsoleted by D69726 . This effort continues as the NFC D99959 patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99758: [index] Improve macro indexing support

This revision was automatically updated to reflect the committed changes. Closed by commit rG93c87fc06eca: [index] Improve macro indexing support (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99758/new/

[clang] 93c87fc - [index] Improve macro indexing support

Author: Ben Langmuir Date: 2021-04-06T09:12:14-07:00 New Revision: 93c87fc06eca8d8a65ff6c0bdd9f2671227224ac URL: https://github.com/llvm/llvm-project/commit/93c87fc06eca8d8a65ff6c0bdd9f2671227224ac DIFF: https://github.com/llvm/llvm-project/commit/93c87fc06eca8d8a65ff6c0bdd9f2671227224ac.diff

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (Do we have a bug this fixes?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99934/new/ https://reviews.llvm.org/D99934

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 335542. mizvekov added a comment. - Rebased on top of D99696 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files:

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

vsavchenko added a comment. @Charusso It looks like this patch introduced a some weird false positive on PostgreSQL F16161734: report-guc.c-ParseLongOption-13-1.html I'll try to look at it myself and minimize it, but maybe you can get an idea from a full

[PATCH] D99965: [RISCV][Clang] Add more RVV load/store intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D99964: [RISCV][Clang] Add all RVV Reduction intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 335532. mizvekov added a comment. - small Doxygen fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files: clang/include/clang/Sema/Sema.h

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

aaronpuchert added a comment. Ping @aaron.ballman, @delesley. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98747/new/ https://reviews.llvm.org/D98747 ___ cfe-commits mailing list

[clang-tools-extra] 14a7296 - [clang][clangd] Avoid inconsistent target creation

Author: oToToT Date: 2021-04-06T23:23:34+08:00 New Revision: 14a7296c0120913e949739e4e90ea5a5f1bd8af1 URL: https://github.com/llvm/llvm-project/commit/14a7296c0120913e949739e4e90ea5a5f1bd8af1 DIFF: https://github.com/llvm/llvm-project/commit/14a7296c0120913e949739e4e90ea5a5f1bd8af1.diff LOG:

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

This revision was automatically updated to reflect the committed changes. Closed by commit rG14a7296c0120: [clang][clangd] Avoid inconsistent target creation (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/

[PATCH] D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability

This revision was automatically updated to reflect the committed changes. Closed by commit rGb660abc80d0d: [ObjC] Add a command line flag that disables recognition of objc_direct for… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[clang] b660abc - [ObjC] Add a command line flag that disables recognition of objc_direct for testability

Author: Erik Pilkington Date: 2021-04-06T11:17:01-04:00 New Revision: b660abc80d0d0943c54e9440636ddfa89c2d626d URL: https://github.com/llvm/llvm-project/commit/b660abc80d0d0943c54e9440636ddfa89c2d626d DIFF:

[PATCH] D99959: [analyzer][NFC] Add tests for extents

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, Charusso. Herald added subscribers: ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. steakhal

[PATCH] D99837: [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23929af383f2: [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation (authored by abhina.sreeskantharajan). Repository: rG

[clang] 23929af - [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation

Author: Abhina Sreeskantharajan Date: 2021-04-06T10:49:09-04:00 New Revision: 23929af383f27a6ddf23704192a25591481152b3 URL: https://github.com/llvm/llvm-project/commit/23929af383f27a6ddf23704192a25591481152b3 DIFF:

[PATCH] D99837: [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. It works now, thanks! :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99837/new/ https://reviews.llvm.org/D99837

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

steakhal added a comment. In D99658#2665730 , @NoQ wrote: > What about `clang_analyzer_getExtent([2])` then? I guess `(extent of heap segment that starts at symbol of type 'int *' conjured at statement 'new int [ext]') - 8` is the value I expect - which

[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

loic-joly-sonarsource added inline comments. Comment at: clang/test/Analysis/PR47511.cpp:5 + +#include "Inputs/std-compare.h" + For such a simple test, there is no need to use the full-fledged header, the following would suffice: ``` namespace std { struct

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske added a comment. Rename the check to "unhandled-bad_alloc" (or similar")? And the error message to " missing exception handler 'std::bad_alloc' "? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ https://reviews.llvm.org/D97196

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

Ericson2314 added a comment. In D99860#2670359 , @phosek wrote: > I'm worried that overriding `CMAKE_INSTALL_PREFIX` is going to break the > runtimes build where we build compiler-rt, libcxx, libcxxabi, libunwind in a > single CMake build, and

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske updated this revision to Diff 335505. balazske added a comment. Removed check of possible exceptions from constructor call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ https://reviews.llvm.org/D97196 Files:

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:105 + +llvm::StringRef getSystemGPUArch(const ToolChain ) { + // detect the AMDGPU installed in system This function is useful for AMDGPU toolchain and HIP toolchain. Can it

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. It would be good for @rjmccall / @rsmith / etc to actually finish reviewing this and accept it. I would personally want to see the next patches - what changes are needed for llvm analysis, transforms? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen marked 2 inline comments as done. khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:315 +multiclass RVVFloatingWidenTerBuiltinSet { + let HasMaskedOffOperand = false, Log2LMUL = [-2, -1, 0, 1, 2] in { +defm "" :

[PATCH] D99901: [Driver][test] Test intended target only

jsji updated this revision to Diff 335500. jsji added a comment. Remove typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99901/new/ https://reviews.llvm.org/D99901 Files: clang/test/Driver/nostdincxx.cpp Index:

[PATCH] D99901: [Driver][test] Test intended target only

jsji added inline comments. Comment at: clang/test/Driver/nostdincxx.cpp:4 // RUN: not %clangxx -nostdlibinc %s 2>&1 | FileCheck %s -// RUN: not %clangxx -fsyntax-only -nostdinc -nostdinc++ %s 2>&1 | FileCheck /dev/null --implicit-check-not=-Wunused-command-line-argument +//

[PATCH] D99901: [Driver][test] Test intended target only

jsji updated this revision to Diff 335499. jsji added a comment. Use -arch instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99901/new/ https://reviews.llvm.org/D99901 Files: clang/test/Driver/nostdincxx.cpp Index:

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. This change is partly motivated by wanting to check in runtime tests for openmp that execute on whatever hardware is available locally. It is functionally similar to an out of tree bash script called mygpu that contains manually curated tables of pci.ids and to

[clang] 849d372 - [NFC][Clang] Speculative fix for builtins-ppc-quadword-noi128.c

Author: Roman Lebedev Date: 2021-04-06T16:15:23+03:00 New Revision: 849d3729433e05e6d89892c1814fa07ed3ec18e2 URL: https://github.com/llvm/llvm-project/commit/849d3729433e05e6d89892c1814fa07ed3ec18e2 DIFF: https://github.com/llvm/llvm-project/commit/849d3729433e05e6d89892c1814fa07ed3ec18e2.diff

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

spatel added inline comments. Comment at: clang/test/CodeGen/libcalls.c:127 // CHECK-NO-DAG: attributes [[NUW_RN]] = { nounwind readnone{{.*}} } +// CHECK-YES-NOT: attributes [[NUW_RN]] = { nounwind readnone{{.*}} } // CHECK-NO-DAG: attributes [[NUW_RNI]] = { nofree nosync

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal planned changes to this revision. pdhaliwal added a comment. Working on tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 ___ cfe-commits mailing

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, ronlieb, jdoerfert, ABataev, gregrodgers. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, mgorny, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 335489. yaxunl added a comment. revised by John's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +

[clang] 2901dc7 - Don't directly dereference getAs<> casts to avoid potential null dereferences. NFCI.

Author: Simon Pilgrim Date: 2021-04-06T12:24:19+01:00 New Revision: 2901dc7575873ed4bdfa1d7a0e79020e7a9ffb3d URL: https://github.com/llvm/llvm-project/commit/2901dc7575873ed4bdfa1d7a0e79020e7a9ffb3d DIFF: https://github.com/llvm/llvm-project/commit/2901dc7575873ed4bdfa1d7a0e79020e7a9ffb3d.diff

[clang-tools-extra] 82b3e28 - [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

Author: Abhina Sreeskantharajan Date: 2021-04-06T07:23:31-04:00 New Revision: 82b3e28e836d2f5c8cfd6e1047b93c088522365a URL: https://github.com/llvm/llvm-project/commit/82b3e28e836d2f5c8cfd6e1047b93c088522365a DIFF:

[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1316 Stmt *SubStmt) { -return SemaRef.ActOnAttributedStmt(AttrLoc, Attrs, SubStmt); +return SemaRef.BuildAttributedStmt(AttrLoc, Attrs, SubStmt); }

[clang] 65c22ac - Silence -Woverloaded-virtual warnings from generated code; NFC

Author: Aaron Ballman Date: 2021-04-06T07:19:07-04:00 New Revision: 65c22acfa4a412066e47c3171ff26fcbd62f970e URL: https://github.com/llvm/llvm-project/commit/65c22acfa4a412066e47c3171ff26fcbd62f970e DIFF: https://github.com/llvm/llvm-project/commit/65c22acfa4a412066e47c3171ff26fcbd62f970e.diff

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c:35 +vint16mf4_t test_vwadd_vx_i16mf4(vint8mf8_t op1, int8_t op2, size_t vl) { + return vwadd_vx(op1, op2, vl); +} khchen wrote: > craig.topper wrote: > > Why do

[PATCH] D99715: [CMake] Fix Python 3 lookup when building LLVM with tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGb78e883fd8b3: [CMake] Fix Python 3 lookup when building LLVM with tests (authored by gargaroff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/

[clang] b78e883 - [CMake] Fix Python 3 lookup when building LLVM with tests

Author: Dominik Montada Date: 2021-04-06T13:09:06+02:00 New Revision: b78e883fd8b3745250220776dd8bb635edd95539 URL: https://github.com/llvm/llvm-project/commit/b78e883fd8b3745250220776dd8bb635edd95539 DIFF:

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

yroux added a comment. Hi, Sorry I'm bit lost in the various patches proposed to fix the issue introduced by https://reviews.llvm.org/D97785 My understanding is that this is missing one to fix our Windows on ARM bots (broken for more than 2 weeks now) So it'd be great to have it applied

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:1017 + static bool isInitMethod(Selector MethodSelector) { +return MethodSelector.getNameForSlot(0).startswith_lower(INIT_PREFIX); + }

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

vsavchenko updated this revision to Diff 335462. vsavchenko added a comment. Use builtin way of checking for init methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99601/new/ https://reviews.llvm.org/D99601 Files:

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder abandoned this revision. tbaeder added a comment. Abandoning this since it's probably not worth it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 ___ cfe-commits mailing list

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I randomly noticed this comment (introduced in a3e01cf822f7415337e5424af3c6f4c94a12c1b9 from @rsmith),

[PATCH] D99610: [RISCV][Clang] Add all RVV Fixed-Point Arithmetic intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2a3601aa5a5: [RISCV][Clang] Add all RVV Fixed-Point Arithmetic intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo

[PATCH] D99528: [RISCV][Clang] Add more RVV Integer intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe252b509ee6: [RISCV][Clang] Add more RVV Integer intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99525: [RISCV][Clang] Add RVV vnsra, vnsrl and vwmul intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a18ea01f197: [RISCV][Clang] Add RVV vnsra, vnsrl and vwmul intrinsic functions. (authored by khchen). Changed prior to commit:

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG66c05609e0d5: [RISCV][Clang] Add some RVV Integer intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99524/new/

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

usaxena95 created this revision. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99934 Files: clang/lib/Tooling/Syntax/Tokens.cpp Index:

[PATCH] D99715: [CMake] Fix Python 3 lookup when building LLVM with tests

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/ https://reviews.llvm.org/D99715

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

LuoYuanke added a comment. LGMT. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99708/new/ https://reviews.llvm.org/D99708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

gargaroff updated this revision to Diff 335438. gargaroff added a comment. Remove find_package call from Tooling/CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/ https://reviews.llvm.org/D99715 Files:

[PATCH] D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbee4813789a3: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bee4813 - [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol.

Author: Balázs Kéri Date: 2021-04-06T11:15:29+02:00 New Revision: bee4813789a378584d43c65497a5efd2353a6606 URL: https://github.com/llvm/llvm-project/commit/bee4813789a378584d43c65497a5efd2353a6606 DIFF: https://github.com/llvm/llvm-project/commit/bee4813789a378584d43c65497a5efd2353a6606.diff

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

cor3ntin added a comment. > Treating a namespace-`std` function template as a builtin isn't entirely > novel; we already do this for MSVC's `std::_GetExceptionInfo` (though we > don't actually handle that properly: we're missing the "namespace `std`" > check, at least). Treating the builtin

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. sorry for the delay here. thanks, this LGTM! i've got a single concern in `CompilerInstance::createTarget` though. it will overwrite aux target for cuda, openmp and sycl (as it

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:706 + + setOperationAction(ISD::BITCAST, VT, Legal); + Jim wrote: > craig.topper wrote: > > What about bitcast from float/double to any of these vector types? I'm > > guess

[PATCH] D99414: [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2935737da32d: [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line… (authored by jansvoboda11). Repository: rG LLVM

[clang] 2935737 - [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line parsing

Author: Jan Svoboda Date: 2021-04-06T10:40:47+02:00 New Revision: 2935737da32dd21bf02e1a3c912a340de660d557 URL: https://github.com/llvm/llvm-project/commit/2935737da32dd21bf02e1a3c912a340de660d557 DIFF: https://github.com/llvm/llvm-project/commit/2935737da32dd21bf02e1a3c912a340de660d557.diff

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

Jim updated this revision to Diff 335428. Jim added a comment. Subtarget.hasStdExtP() -> Subtarget.hasStdExtZpn() for addRegisterClass CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99158/new/ https://reviews.llvm.org/D99158 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D99683: [HIP] Support ThinLTO

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1904-1907 +def foffload_lto : Flag<["-"], "foffload-lto">, Flags<[CoreOption]>, Group, + HelpText<"Enable LTO in 'full' mode for offload compilation">; +def fno_offload_lto : Flag<["-"],

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

tianqing updated this revision to Diff 335426. tianqing added a comment. Update handling of -mcmodel=kernel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99708/new/ https://reviews.llvm.org/D99708 Files: clang/lib/Headers/uintrintrin.h llvm/lib/Target/X86/X86ExpandPseudo.cpp

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. In D99160#2669576 , @dblaikie wrote: > In D99160#2668977 , @djtodoro wrote: > >> I think that the Debug Entry Values feature should not be enabled by default >> for non optimized code, so

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

Jim added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17944 + + // P extension +#define EMIT_BUILTIN(NAME, INT) \ I have concern here. It has lots of duplicate code if the code style is the same as B in the top. And the name of macro is not

[PATCH] D99527: [RISCV][Clang] Add RVV Widening Integer Extension intrinsic functions.

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Basic/riscv_vector.td:338 + string type_range> { + let IRName = intrinsic_name, IRNameMask = intrinsic_name

<    1   2   3   >