[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

JDevlieghere added a comment. Given that these tests are macOS specific and already require a specific SDK, I'll just update them to use the compiler from the SDK instead of the just-built one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#2706467 , @dblaikie wrote: > FWIW, I'd love it if we could do a full dead-store warning, which would be a > superset of this. I think we have enough infrastructure in the analysis based > warnings (I think the

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dblaikie added a comment. In D100581#2706554 , @xbolva00 wrote: > In D100581#2706467 , @dblaikie > wrote: > >> FWIW, I'd love it if we could do a full dead-store warning, which would be a >> superset of this. I

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

ldionne added a comment. In D45639#2706589 , @dexonsmith wrote: > I'm not sure I'm totally following, but just want to double check that the > tests won't somehow use the libc++ from the SDK instead of ToT? I guess the > test uses `-nostdinc++` or

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 339355. abhina.sreeskantharajan added a reviewer: ThePhD. abhina.sreeskantharajan added a comment. Thanks for catching that. This sets the __clang_literal_encoding__ to Opts.ExecCharset or defaults to SystemCharset. Repository: rG LLVM

[PATCH] D99983: Provide TreeTransform::TransformAttr the transformed statement; NFC

haberman accepted this revision. haberman added a comment. This revision is now accepted and ready to land. This seems fine to me, but I'll defer to @rsmith for final review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99983/new/ https://reviews.llvm.org/D99983

[PATCH] D100968: Update shebang for clang-format-diff script to python3.

MaskRay added a comment. Still LG:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100968/new/ https://reviews.llvm.org/D100968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100981: Delete le32/le64 targets

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. Thanks. I had heard in the past that there were some other folks who had used le32/le64 as a "generic" target (in fact that's why it's named so generically, rather than being called "pnacl"

[PATCH] D100000: [clang] WIP: Implement simpler alternative to two-phase lookup for NRVO

mizvekov updated this revision to Diff 339349. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files: clang/include/clang/AST/Expr.h

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

aaron.ballman added a comment. In D98450#2699970 , @arphaman wrote: > Your argument makes sense. The problem right now is that clang doesn't allow > the name to be used even when the user marks up availability correctly trying > to guard the use of the

[clang] 5a2d78b - [HIP] Add option -fgpu-inline-threshold

Author: Yaxun (Sam) Liu Date: 2021-04-21T17:18:18-04:00 New Revision: 5a2d78b1639738fbde85248413c1cfd2df55683a URL: https://github.com/llvm/llvm-project/commit/5a2d78b1639738fbde85248413c1cfd2df55683a DIFF:

[PATCH] D99233: [HIP] Add option -fgpu-inline-threshold

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2d78b16397: [HIP] Add option -fgpu-inline-threshold (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 339400. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. I got LGTM for this before, but I'll leave it open for a few days to address any new comments folks might have. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3523 +else + Opts.CXXABI = TargetCXXABI::getKind(CXXABI); + }

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

dexonsmith created this revision. dexonsmith added a reviewer: vsk. dexonsmith requested review of this revision. Herald added a project: clang. The profiling runtime was designed to work without static initializers or a a filesystem (see 117cf2bd1ff585f9754b5f30f5a4cfd65b230bbf and others). The

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2147-2150 +This attribute can only be used to set up the aliases for certain RISC-V +C intrinsic functions; it is intended for use only inside ``riscv_*.h`` +and is not a general mechanism for

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77357208c46a: [CodeView] Add CodeView support for PGO debug information (authored by Holman, committed by rnk). Repository: rG LLVM Github

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk added a comment. In D4#2706515 , @Holman wrote: > Can someone help me get this checked in? Sure, I went ahead and pushed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

vsk added a subscriber: efriedma. vsk added a comment. Thanks for doing this! + Eli to comment on whether any workarounds documented in https://lists.llvm.org/pipermail/llvm-dev/2017-September/117156.html are still necessary. To my knowledge it's not currently necessary to explicitly pass

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

This revision was automatically updated to reflect the committed changes. Closed by commit rG775a9483e55e: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

dexonsmith updated this revision to Diff 339423. dexonsmith added a comment. Incorporate feedback from @vsk: - a bit more explanatory text for the overall context - explicitly reference the static initializers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101000/new/

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

jamieschmeiser created this revision. jamieschmeiser added reviewers: rsmith, saar.raz. jamieschmeiser requested review of this revision. Herald added a project: clang. When vector is found as a type or non-type id, check if it is really the altivec vector token. Call TryAltiVecVectorToken when

[PATCH] D99299: Normalize interaction with boolean attributes

dblaikie added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:660-663 +bool AttributeImpl::getValueAsBool() const { + assert(getValueAsString().empty() || getValueAsString() == "false" || getValueAsString() == "true"); + return getValueAsString() == "true"; +}

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

lxfind added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2689 - size_t __builtin_coro_size() + size_t __builtin_coro_size(bool alloc) void *__builtin_coro_frame() ChuanqiXu wrote: > ychen wrote: > > ChuanqiXu wrote: > > > ychen wrote:

[libunwind] f749550 - [libcxx] Stop using use c++ subdirectory for libc++ library

Author: Petr Hosek Date: 2021-04-21T15:39:03-07:00 New Revision: f749550cfe9f0bf2364abb2139835348587062ed URL: https://github.com/llvm/llvm-project/commit/f749550cfe9f0bf2364abb2139835348587062ed DIFF: https://github.com/llvm/llvm-project/commit/f749550cfe9f0bf2364abb2139835348587062ed.diff

[clang] f749550 - [libcxx] Stop using use c++ subdirectory for libc++ library

Author: Petr Hosek Date: 2021-04-21T15:39:03-07:00 New Revision: f749550cfe9f0bf2364abb2139835348587062ed URL: https://github.com/llvm/llvm-project/commit/f749550cfe9f0bf2364abb2139835348587062ed DIFF: https://github.com/llvm/llvm-project/commit/f749550cfe9f0bf2364abb2139835348587062ed.diff

[PATCH] D100869: [libcxx] Stop using use c++ subdirectory for libc++ library

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf749550cfe9f: [libcxx] Stop using use c++ subdirectory for libc++

[clang] 775a948 - [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

Author: Fangrui Song Date: 2021-04-21T15:58:20-07:00 New Revision: 775a9483e55efb365691bc425ed107568ad6daf8 URL: https://github.com/llvm/llvm-project/commit/775a9483e55efb365691bc425ed107568ad6daf8 DIFF: https://github.com/llvm/llvm-project/commit/775a9483e55efb365691bc425ed107568ad6daf8.diff

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

dexonsmith marked an inline comment as done. dexonsmith added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:368 + +In C++ files, declare these as ``extern "C"``. + vsk wrote: > I think we should leave a note about how to avoid pulling in

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

yaxunl updated this revision to Diff 339353. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99233/new/ https://reviews.llvm.org/D99233 Files:

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dblaikie added a comment. FWIW, I'd love it if we could do a full dead-store warning, which would be a superset of this. I think we have enough infrastructure in the analysis based warnings (I think the sufficiency of the infrastructure is demonstrated by the "may be used uninitialized"

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman added a comment. Can someone help me get this checked in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 ___ cfe-commits mailing list

[PATCH] D93031: Enable fexec-charset option

cor3ntin added a comment. >> We should use the original source form of the string literal when >> pretty-printing a `StringLiteral` or `CharacterLiteral`; there are a bunch >> of UTF-8 assumptions baked into `StmtPrinter` that will need revisiting. And >> we'll need to modify the handful of

[PATCH] D100466: clang-format: [JS] merge import lines.

jgorbe added a comment. Hi, one of our tests is failing because of this patch and it looks like an actual bug. clang-format now turns this file: import './a'; import {bar} from './a'; into this: barimport './a'; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6331680 - Re-land "[Driver] Support default libc++ library location on Darwin"

Author: Jonas Devlieghere Date: 2021-04-21T14:22:13-07:00 New Revision: 6331680ad2ad000fdaf7e72f3c1880c7908ffa25 URL: https://github.com/llvm/llvm-project/commit/6331680ad2ad000fdaf7e72f3c1880c7908ffa25 DIFF:

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

JDevlieghere added a comment. In D45639#2706364 , @JDevlieghere wrote: > Given that these tests are macOS specific and already require a specific SDK, > I'll just update them to use the compiler from the SDK instead of the > just-built one. Done in

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

dexonsmith added a comment. > No, the bot is also meant to catch changes to libc++ breaking LLDB (or at > least making sure we update the corresponding data formatters). > Given that these tests are macOS specific and already require a specific SDK, > I'll just update them to use the

[PATCH] D100830: [RISCV] [1/2] Add IR intrinsic for Zbp extension

LevyHsu updated this revision to Diff 339105. LevyHsu marked 6 inline comments as done. LevyHsu added a comment. 1. clang/test/CodeGen/RISCV/rvb-intrinsics/riscv32-zbp.c clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbp.c llvm/test/MC/RISCV/rv32b-aliases-valid.s

[PATCH] D100626: [analyzer][NFC] Remove duplicated work from retain count leak report

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100626/new/ https://reviews.llvm.org/D100626

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2147-2150 +This attribute can only be used to set up the aliases for certain RISC-V +C intrinsic functions; it is intended for use only inside ``riscv_*.h`` +and is not a general mechanism for

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

NoQ added a comment. In https://bugs.llvm.org/show_bug.cgi?id=45786 the godbolt link shows that there are still problems with `addressof` (yes, their "trunk" clang is fresh enough). They seem to have `__addressof` instead of `addressof` so maybe we should cover that case real quick. Or maybe

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

craig.topper added a comment. I just posted https://reviews.llvm.org/D100889 which should allow the frontend to treat all comparisons the same way. It also avoids using the long expansion for vmsge.vx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3523 +else + Opts.CXXABI = TargetCXXABI::getKind(CXXABI); + } The original command-line arguments must be generated from this in `GenerateLangArgs`. See

[PATCH] D100929: [Clang] Allow the combination of loader_uninitialized and address spaces

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, aaron.ballman. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added a project: clang. When an object is allocated in a non-default address space we do not need to check for a

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enabled explicitly building inferred modules. Effectively a cherry-pick of

[PATCH] D100933: [clang] Recognize ppc32 as valid mcpu value

LemonBoy created this revision. LemonBoy added a reviewer: PowerPC. Herald added subscribers: shchenz, kbarton, nemanjai. LemonBoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ppc32` cpu model was introduced a while ago in

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

fhahn added a comment. In D100834#2702550 , @kpn wrote: > I don't know the matrix implementation so I can't swear this hits every place > needed, but the uses of CGFPOptionsRAII in this patch look correct at least. Other parts of the extension include

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

vhscampos added a comment. Thanks Peter. Since one week has passed, I plan to commit these changes by the end of the day if nothing surfaces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100372/new/ https://reviews.llvm.org/D100372

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( +

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

frasercrmck added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1048 + return Cmp < 0; + // Some mask intrinsics use the same IRName as unmasked. + // Sort the unmasked intrinsics first.

[PATCH] D100852: [analyzer] Track leaking object through stores

vsavchenko added a comment. In D100852#2704282 , @NoQ wrote: > I think this is already way better than before. I see that `OSDynamicCast` > isn't supported yet and we seem to hit the same wall as D97183 > because

[PATCH] D100930: [Clang] Add clang attribute `clang_builtin_alias`.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01, khchen, aaron.ballman. Herald added subscribers: StephenFan, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng,

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 64bc44f - [llvm-rc] Run clang to preprocess input files

Author: Martin Storsjö Date: 2021-04-21T11:50:10+03:00 New Revision: 64bc44f5ddfb6da4b6a8b51ea9a03f8772b3ae95 URL: https://github.com/llvm/llvm-project/commit/64bc44f5ddfb6da4b6a8b51ea9a03f8772b3ae95 DIFF:

[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64bc44f5ddfb: [llvm-rc] Run clang to preprocess input files (authored by mstorsjo). Changed prior to commit:

[PATCH] D96286: [clangd][NFC] Change TidyProvider cache to use a linked list approach

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96286/new/ https://reviews.llvm.org/D96286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100830: [RISCV] [1/2] Add IR intrinsic for Zbp extension

LevyHsu updated this revision to Diff 339138. LevyHsu added a comment. 1. llvm/lib/Target/RISCV/RISCVISelLowering.cpp - Fix format issue with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100830/new/ https://reviews.llvm.org/D100830

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:460-468 +TARGET_BUILTIN(__nvvm_redux_sync_add_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_min_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_max_s32, "SiSii",

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

NoQ added a comment. This is a major improvement. `MallocChecker` will have to catch up on that. Hopefully through increased code re-use. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:651 + + return Result; +} I

[PATCH] D100919: [AArch64] Support customizing stack protector guard

kristof.beyls added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:26 -// RUN: not %clang -target aarch64-linux-gnu -mstack-protector-guard-offset=10 %s 2>&1 | \ +// RUN: not %clang -target arm-linux-gnuebi -mstack-protector-guard-offset=10 %s 2>&1 |

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai added a comment. @aaron.ballman, could we discuss the generalization in https://reviews.llvm.org/D100930? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611

[clang] 0ad50bf - Revert "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed"

Author: Pushpinder Singh Date: 2021-04-21T08:05:38Z New Revision: 0ad50bf27f892873427bd372a8e7d2e9b234586d URL: https://github.com/llvm/llvm-project/commit/0ad50bf27f892873427bd372a8e7d2e9b234586d DIFF: https://github.com/llvm/llvm-project/commit/0ad50bf27f892873427bd372a8e7d2e9b234586d.diff

[PATCH] D100852: [analyzer] Track leaking object through stores

NoQ added a comment. I think this is already way better than before. I see that `OSDynamicCast` isn't supported yet and we seem to hit the same wall as D97183 because inter-operation between `trackExpressionValue` and the checkers isn't implemented yet.

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 updated this revision to Diff 339136. jansvoboda11 added a comment. Apply clang-format suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 Files: clang/include/clang/Basic/Module.h

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG11072a0bdbc0: [RISCV][Clang] Add RVV AMO builtins (authored by arcbbb). Changed prior to commit: https://reviews.llvm.org/D100448?vs=338419=339139#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100852: [analyzer] Track leaking object through stores

vsavchenko updated this revision to Diff 339143. vsavchenko marked an inline comment as done. vsavchenko added a comment. Add a comment and replace getAs with castAs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100852/new/

[clang] 5f02c30 - Fix clang/test/Frontend/plugin-annotate-functions.c

Author: John Brawn Date: 2021-04-21T14:00:38+01:00 New Revision: 5f02c308e68d2412e2555017d4dbe3e2cc122913 URL: https://github.com/llvm/llvm-project/commit/5f02c308e68d2412e2555017d4dbe3e2cc122913 DIFF: https://github.com/llvm/llvm-project/commit/5f02c308e68d2412e2555017d4dbe3e2cc122913.diff

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

xbolva00 added a comment. In D99790#2680857 , @jyknight wrote: > It seems like there's a bug with vtable thunks getting the wrong information. > This appears to be a pre-existing bug, but this change has caused it to start > actively breaking code. > >

[PATCH] D100933: [clang] Recognize ppc32 as valid mcpu value

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e336511f18a: [clang] Recognize ppc32 as valid mcpu value (authored by LemonBoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100933/new/

[clang] 8e33651 - [clang] Recognize ppc32 as valid mcpu value

Author: LemonBoy Date: 2021-04-21T15:11:01+02:00 New Revision: 8e336511f18ab56cd0c8d93b5c18219df411963a URL: https://github.com/llvm/llvm-project/commit/8e336511f18ab56cd0c8d93b5c18219df411963a DIFF: https://github.com/llvm/llvm-project/commit/8e336511f18ab56cd0c8d93b5c18219df411963a.diff

[clang] a63c9b2 - Do not pass null attributes to BuildAttributedStmt during instantiation

Author: Aaron Ballman Date: 2021-04-21T09:30:56-04:00 New Revision: a63c9b25620c8a4da9fcf1e1e8535d3110819ec0 URL: https://github.com/llvm/llvm-project/commit/a63c9b25620c8a4da9fcf1e1e8535d3110819ec0 DIFF: https://github.com/llvm/llvm-project/commit/a63c9b25620c8a4da9fcf1e1e8535d3110819ec0.diff

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM, let's just rename `template-diagnostics.clcpp` into something like `template-opencl-types.clcpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100860/new/

[PATCH] D100953: clang-format: [JS] do not wrap after `asserts`

mprobst created this revision. mprobst added reviewers: krasimir, h-joo. mprobst requested review of this revision. Herald added a project: clang. `asserts` is a pseudo keyword in TypeScript used in return types. Wrapping after it triggers automatic semicolon insertion, which breaks the code

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

aaron.ballman added a comment. In D100762#2699350 , @dexonsmith wrote: > In D100762#2699252 , @arichardson > wrote: > >> I'm not sure it's a good idea to remove the `-ast-dump=json` option. While >> this is

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. I was under the impression that `#!/usr/bin/env sh` is a sensible invocation for running a shell on various systems. The current theory for this struggling with the ppc buildbot is that fedora doesn't support that. Ad hoc searching suggests 'sh' is required to

[clang] dc256a4 - [flang][driver] Add support for `-fget-definition`

Author: Andrzej Warzynski Date: 2021-04-21T09:31:36Z New Revision: dc256a443a456a8e0e4d72736fee1c9442bcf4bd URL: https://github.com/llvm/llvm-project/commit/dc256a443a456a8e0e4d72736fee1c9442bcf4bd DIFF: https://github.com/llvm/llvm-project/commit/dc256a443a456a8e0e4d72736fee1c9442bcf4bd.diff

[PATCH] D100558: [flang][driver] Add support for `-fget-definition`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc256a443a45: [flang][driver] Add support for `-fget-definition` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

simon_tatham created this revision. simon_tatham added reviewers: mstorsjo, thakis. Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls. simon_tatham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[clang] 066b8f2 - [llvm-rc] Try to fix the Preprocessor/llvm-rc.rc test on non arm/x86 architectures

Author: Martin Storsjö Date: 2021-04-21T12:47:33+03:00 New Revision: 066b8f2fc6d584635a017a0a15494ce4460744e3 URL: https://github.com/llvm/llvm-project/commit/066b8f2fc6d584635a017a0a15494ce4460744e3 DIFF:

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

simon_tatham added a comment. Yes, it looks easy enough to add something in `llvm/unittests/ADT/TripleTest.cpp` to directly test `getARMCPUForArch`. I'd mildly prefer to do that //as well// as having the test here, because the call site in the clang driver is quite complicated. My real aim is

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo accepted this revision. mstorsjo added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100937/new/ https://reviews.llvm.org/D100937 ___ cfe-commits mailing list

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); bader

[clang] 77e170d - [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

Author: Simon Tatham Date: 2021-04-21T11:20:05+01:00 New Revision: 77e170db8678e582af986ffe27e12df196e4357b URL: https://github.com/llvm/llvm-project/commit/77e170db8678e582af986ffe27e12df196e4357b DIFF: https://github.com/llvm/llvm-project/commit/77e170db8678e582af986ffe27e12df196e4357b.diff

[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

thakis added a comment. Purely FYI: the `--` in the test isn't needed just on macOS but also on Linux if your checkout is eg under /usr: http://45.33.8.238/linux/44652/step_7.txt (clang-cl has some nice diag if the /U flag is an existing file, since that happens fairly often. Maybe llvm-rc

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen updated this revision to Diff 339169. steffenlarsen added a comment. Changes: - Removed integer type from builtin and intrinsic names. - Signedness in builtin and intrinsic names moved to operator name, i.e. umin and umax. - Removed redundant addition variant. CHANGES SINCE LAST

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

olestrohm updated this revision to Diff 339175. olestrohm added a comment. Inlined the `thread_local` check and moved `static clk_event_t` into the appropriate test. I did not move the `thread_local` check since NewVD had the wrong value for `TSCS`, so D was required. CHANGES SINCE LAST

[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

arsenm added inline comments. Comment at: llvm/lib/Target/PowerPC/GISel/PPCCallLowering.cpp:46-58 +/** + * @brief Lower incoming arguments into generic MIR, this method is responsible + * for splitting aggregate arguments into multiple single value types as well + * as setting

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3973-3974 + // as true by default. + if (const Arg *A = Args.getLastArg(options::OPT_gstrict_dwarf)) +(void)checkDebugInfoOption(A, Args, D, TC); + if

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. You have a clang-format warning, aside from that LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100826/new/

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

dblaikie added a comment. Do you know if you're going to be using LTO with DBX? If so, to respect this flag, it would need to be added to LLVM IR module metadata (like the Dwarf Version and Debug Info Version fields) rather than as an MCOption. (we're pretty wishy-washy about what things we

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

probinson added a comment. Nit on the description, this patch supports -gstrict-dwarf in the frontend. Comment at: clang/docs/ClangCommandLineReference.rst:3549-3550 +Use DWARF extensions in later DWARF versions. + .. option:: -gz=, -gz (equivalent to -gz=zlib)

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 338695. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-rvalue-ref.cpp Index:

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 338755. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-rvalue-ref.cpp Index:

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz created this revision. shchenz added reviewers: dblaikie, probinson, aprantl, jsji, Esme, echristo, PowerPC. shchenz added a project: debug-info. Herald added a subscriber: hiraditya. shchenz requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

dblaikie added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3549-3550 +Use DWARF extensions in later DWARF versions. + .. option:: -gz=, -gz (equivalent to -gz=zlib) This description is probably backwards/doesn't explicitly clarify

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz updated this revision to Diff 338752. shchenz marked 2 inline comments as done. shchenz added a comment. address @dblaikie comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100809/new/ https://reviews.llvm.org/D100809 Files:

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 338697. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz created this revision. shchenz added reviewers: dblaikie, probinson, aprantl, jsji, Esme, echristo, PowerPC. shchenz added a project: debug-info. Herald added subscribers: jansvoboda11, dexonsmith, dang. shchenz requested review of this revision. Herald added a project: clang. Herald

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2697732 , @dblaikie wrote: > In D100630#2697728 , @shchenz wrote: > >> In D100630#2694681 , @probinson >> wrote: >> >>> If DBX is

  1   2   3   >