[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341326. Ericson2314 added a comment. Fix bug makeing polly path full, and rebase fixing conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

MaskRay added a comment. The refactoring part seems useful on its own. The controversial 4-byte alignment part should be split. Doesn't GNU as use 4 for most architectures as well? Why do you want to change it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

jrtc27 added a comment. Herald added a subscriber: JDevlieghere. What's the benefit of less-aligned functions? Is that not more likely to get poor performance due to cache line straddling of the first instruction? Regardless, the functional change should be separated out from the refactoring.

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341213. Ericson2314 added a comment. Fix stray ':' typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341339. Ericson2314 added a comment. Resubmit now prior diff is rebased, so CI doesn't trip up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added a comment. In D99484#2724055 , @Ericson2314 wrote: > Fix bug makeing polly path full, and rebase fixing conflicts What was the problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

MaskRay accepted this revision. MaskRay added a comment. The path component `x86_64-unknown-linux-gnu` (not multiarch `x86_64-linux-gnu`) looks good to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea12d779bc23: [libc++] Support per-target __config_site in

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 341262. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

MaskRay added inline comments. Comment at: clang/test/Driver/linux-header-search.cpp:16 // CHECK-BASIC-LIBCXX-SYSROOT: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-BASIC-LIBCXX-SYSROOT: "-internal-isystem" "[[SYSROOT]]/usr/include/x86_64-unknown-linux-gnu/c++/v1" //

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. In D99484#2724343 , @Meinersbur wrote: > In D99484#2724055 , @Ericson2314 > wrote: > >> Fix bug makeing polly path full, and rebase fixing conflicts > > What was the problem? I

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added a comment. In D99484#2724435 , @Ericson2314 wrote: > I effectively replaced `${CMAKE_INSTALL_PREFIX}/lib` with > `${CMAKE_INSTALL_LIBDIR}`, which evaluates (by default) merely to `lib`. The > fix was `${CMAKE_INSTALL_FULL_LIBDIR}` which

[PATCH] D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1808 +With this extension it is possible to enable the use of some restricted types in kernel parameters. +The restrictions can be relaxed using regular OpenCL extension pragma mechanism +detailed in

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/DeclareLoopVariableInTheInitializerCheck.cpp:37 + bool VisitDeclRefExpr(DeclRefExpr *D) { +if (const VarDecl *To = dyn_cast(D->getDecl())) { + if (To == MatchedDecl &&

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

This revision was automatically updated to reflect the committed changes. Closed by commit rGc20410618827: [Clang][OpenMP] Frontend work for sections - D89671 (authored by AMDChirag). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/

[clang] c204106 - [Clang][OpenMP] Frontend work for sections - D89671

Author: Chirag Khandelwal Date: 2021-04-29T19:52:27+05:30 New Revision: c20410618827b7870fbc86d45ff8e9b11bc169b4 URL: https://github.com/llvm/llvm-project/commit/c20410618827b7870fbc86d45ff8e9b11bc169b4 DIFF:

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko updated this revision to Diff 341537. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 created this revision. flip1995 added reviewers: MaskRay, rnk, asb. Herald added subscribers: frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, rupprecht, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27,

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

Anastasia added a comment. If I build docs now I get the following output: llvm-project/build-doc/tools/clang/docs/SYCLSupport.rst:102: WARNING: Error in "code-block" directive: 1 argument(s) required, 0 supplied. .. code-block:: TODO: add support for

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

yaxunl abandoned this revision. yaxunl added a comment. In D101389#2724757 , @rjmccall wrote: > In D101389#2724700 , @yaxunl wrote: > >> In D101389#2724636 , @rjmccall

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

MaskRay added a comment. The `InitMCObjectFileInfo` refactoring is good, but I'll suggest `initMCObjectFileInfo(MCContext , bool PIC, bool LargeCodeModel)` (change the function name to `lowerCase`, and reorder MCContext before bool arguments). The refactoring adding `Triple` to

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

scott.linder created this revision. scott.linder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduce an extra scope (another static function) to replace calls to `unique_ptr::reset` with implicit destructors via RAII. Repository:

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 341503. AMDChirag added a comment. Rebase to retrigger build The build failed previously - seemingly with a test case that has nothing to do with this patch. Retriggering and Rebasing the commit to ensure the same. Repository: rG LLVM Github Monorepo

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

DNS320 updated this revision to Diff 341492. DNS320 marked 7 inline comments as done. DNS320 added a comment. I updated the check according to the last review. The check should now fully implement the defined enforcement chapter from the ES.74 C++ Core Guideline. About searching for declRefExpr

[PATCH] D101479: [Driver] Support libc++ in MSVC

thakis added a comment. can you add a test for the linker invocation too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 ___ cfe-commits mailing list

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: polly/cmake/CMakeLists.txt:104-110 +set(tgt_prefix "${CMAKE_INSTALL_FULL_BINDIR}/") else() -set(tgt_prefix "lib/") +set(tgt_prefix "${CMAKE_INSTALL_FULL_LIBDIR}/") endif() - set(tgt_path

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. In D101491#2724025 , @delcypher wrote: > @jansvoboda11 Should I use the the alias feature so that the old > `-fsanitize-address-destructor-kind` argument is still parsed? I'm not sure >

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

bader added a comment. In D99488#2725435 , @Anastasia wrote: > If I build docs now I get the following output: > > llvm-project/build-doc/tools/clang/docs/SYCLSupport.rst:102: WARNING: Error > in "code-block" directive: > 1 argument(s) required, 0

[clang] 3eb2be6 - Unbreak no-asserts testing

Author: David Zarzycki Date: 2021-04-29T10:01:37-04:00 New Revision: 3eb2be67b997ea62f47dbe90a62e828ecfb266a8 URL: https://github.com/llvm/llvm-project/commit/3eb2be67b997ea62f47dbe90a62e828ecfb266a8 DIFF:

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:836-837 + NewState, NewNode, + C.getNoteTag([Msg](PathSensitiveBugReport , + llvm::raw_ostream ) { OS << Msg; })); }

[PATCH] D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters

olestrohm updated this revision to Diff 341526. olestrohm set the repository for this revision to rG LLVM Github Monorepo. olestrohm added a comment. Added a link to the C++ for OpenCL specification and cleaned up the text according to the requests. Repository: rG LLVM Github Monorepo

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

Anastasia added a comment. In D99488#2725501 , @bader wrote: > In D99488#2725435 , @Anastasia wrote: > >> If I build docs now I get the following output: >> >>

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

scott.linder added reviewers: MaskRay, dineshkb-amd, aykevl. scott.linder added a comment. I'm not sure who else to add, please feel free to update the reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101542/new/

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. Thanks for the review! I already thought that I will have to split this up, so I made the commits self contained so I'll do that. One question before I start: Where should I split this? Should I only split out the RISC-V patch and leave the changes that targets can

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

DNS320 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/DeclareLoopVariableInTheInitializerCheck.cpp:28 + + diag(MatchedForStmt->getBeginLoc(), + "Prefer to declare a loop variable in the initializer part of a "

[clang] 8fb0d6d - [OpenCL][Docs] Describe extension for legacy atomics with generic addr space.

Author: Anastasia Stulova Date: 2021-04-29T14:02:34+01:00 New Revision: 8fb0d6df11e4d2b4a534c96fcc1b55459940151e URL: https://github.com/llvm/llvm-project/commit/8fb0d6df11e4d2b4a534c96fcc1b55459940151e DIFF:

[PATCH] D101089: [OpenCL] Document legacy atomics with generic address space

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fb0d6df11e4: [OpenCL][Docs] Describe extension for legacy atomics with generic addr space. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to

[PATCH] D101092: [OpenCL][Docs] Misc updates about C++ for OpenCL and offline compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ed6e87ab02d: [OpenCL][Docs] Misc updates to C++ for OpenCL and offline compilation (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Repository: rG LLVM Github

[clang] 1ed6e87 - [OpenCL][Docs] Misc updates to C++ for OpenCL and offline compilation

Author: Anastasia Stulova Date: 2021-04-29T14:15:07+01:00 New Revision: 1ed6e87ab02db4fb9379b80c820bebad9869aa4d URL: https://github.com/llvm/llvm-project/commit/1ed6e87ab02db4fb9379b80c820bebad9869aa4d DIFF:

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher added a comment. In D101491#2725348 , @jansvoboda11 wrote: > In D101491#2724025 , @delcypher > wrote: > >> @jansvoboda11 Should I use the the alias feature so that the old >>

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726337 , @estewart08 wrote: > In D99432#2726060 , @ABataev wrote: > >> In D99432#2726050 , @estewart08 >> wrote: >> >>> In

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies marked an inline comment as done. ffrankies added a comment. @Eugene.Zelenko @aaron.ballman Are there any more changes that need to be made to this check or comments that need to be addressed? Comment at:

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d42b2ee7baf: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix. (authored by delcypher). Repository: rG LLVM

[clang] 2d42b2e - [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

Author: Dan Liew Date: 2021-04-29T11:55:42-07:00 New Revision: 2d42b2ee7bafe76d6b2c792b73f7371cb1cf8d94 URL: https://github.com/llvm/llvm-project/commit/2d42b2ee7bafe76d6b2c792b73f7371cb1cf8d94 DIFF: https://github.com/llvm/llvm-project/commit/2d42b2ee7bafe76d6b2c792b73f7371cb1cf8d94.diff

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

shafik added inline comments. Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:909 + new llvm::MCContext(llvm::Triple(triple), asm_info_up.get(), + reg_info_up.get(), nullptr, subtarget_info_up.get())); if (!context_up)

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

dblaikie added subscribers: respindola, doug.gregor. dblaikie added a comment. Along time ago Clang had a fairly strong aversion to implementing "off by default" warnings (though clearly weak-vtables was an exception to that - it's a pretty esoteric warning even at the best of times/without

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726588 , @estewart08 wrote: > In D99432#2726391 , @ABataev wrote: > >> In D99432#2726337 , @estewart08 >> wrote: >> >>> In

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2726025 , @ABataev wrote: > In D99432#2726019 , @estewart08 > wrote: > >> In reference to https://bugs.llvm.org/show_bug.cgi?id=48851, I do not see >> how this helps SPMD

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis added a comment. In D95976#2725027 , @protze.joachim wrote: > Please update the test with a NFC commit. Thanks, @protze.joachim. The changes look good. I'll get that NFC commit in soon-ish, unless you would like to take over.

[PATCH] D101551: [CMake] Set correct CXX_FLAGS for relative-vtables variants

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We overrite CXX_FLAGS to enable relative vtables, but doing so overwrites generic

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-narrowing-conversions.rst:51 + + Narrowing conversions from any type in this semicolon

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval updated this revision to Diff 341589. clementval added a comment. Fix global variable names. Separator comes from OpenMP runtime information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:158 std::string ReferencesText; -bool SymbolsInOrder = true; -for (unsigned i = 0, e = Indices.size(); i != e; ++i) { - JsModuleReference Reference = References[Indices[i]];

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726019 , @estewart08 wrote: > In reference to https://bugs.llvm.org/show_bug.cgi?id=48851, I do not see how > this helps SPMD mode with team privatization of declarations in-between > target teams and parallel

[clang] ba63124 - [CMake] Set correct CXX_FLAGS for relative-vtables variants

Author: Petr Hosek Date: 2021-04-29T10:34:37-07:00 New Revision: ba631240ae9ccbf70f57c0ba22cf2dd5a3592da2 URL: https://github.com/llvm/llvm-project/commit/ba631240ae9ccbf70f57c0ba22cf2dd5a3592da2 DIFF: https://github.com/llvm/llvm-project/commit/ba631240ae9ccbf70f57c0ba22cf2dd5a3592da2.diff

[PATCH] D101551: [CMake] Set correct CXX_FLAGS for relative-vtables variants

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba631240ae9c: [CMake] Set correct CXX_FLAGS for relative-vtables variants (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. For coroutine `f0` in `test/CodeGenCoroutines/coro-alloc.cpp` The allocation looks like this: ; Function Attrs: noinline nounwind optnone mustprogress define dso_local void @f0() #0 { entry: %0 = alloca %struct.global_new_delete_tag, align 1 %1 = alloca

[PATCH] D101338: [MS] Preserve base register %rbx around cpuid

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Seems reasonable, thanks. We really ought to solve the general problem one day. It is kind of pig-headed that the backend just picks two arbitrary CSRs, the base and frame pointers, and doesn't

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:252 + SmallVector + sortModuleReferences(SmallVector ) { +// Sort module references. `References` seem read-only. Can you make it `const Smallvector &`?

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. Hm ... I see BarrierNoop pass being added before `annotation-remarks`. Why's that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99599/new/ https://reviews.llvm.org/D99599

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 341592. ychen added a comment. - fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCoroutine.cpp

[PATCH] D101479: [Driver] Support libc++ in MSVC

rnk added a comment. The test doesn't seem to pass on Jenkins. Maybe we need a REQUIRES line or a fake sysroot or something for the test. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1332 + + auto AddLibcxxIncludePath = [&](StringRef Path) { +std::string Version =

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2726391 , @ABataev wrote: > In D99432#2726337 , @estewart08 > wrote: > >> In D99432#2726060 , @ABataev wrote: >> >>> In D99432#2726050

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

rjmccall added a comment. Seems conceptually okay, given that we have an option to control it. Comment at: clang/lib/CodeGen/CGStmt.cpp:796 + bool EmitBoolCondBranch = !C || !C->isOne(); + bool CondIsConst = C; const SourceRange = S.getSourceRange();

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir added a comment. @h-joo , seems we had a comment race :D cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 ___ cfe-commits mailing list

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta added a subscriber: rnk. xgupta added a comment. In D101352#2726406 , @jrtc27 wrote: > I'm not convinced by these changes? Yes, I also thought first, clang man page can't be incorrect/inconsistent. I think @rnk can suggest the changes as he has

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101542/new/ https://reviews.llvm.org/D101542

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

bader added a comment. Thanks! I've uploaded this version to https://reviews.llvm.org/D101549. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 ___ cfe-commits

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. @haowei What are LLVM configuration options? Also please send output from /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -flegacy-pass-manager -fdebug-pass-structure -O0 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, jfb, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This allows us

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 341591. ychen added a comment. - fix a bug. ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2705 } - if (FormatTok->Tok.is(tok::l_brace)) { + if (FormatTok->Tok.is(tok::equal)) { +nextToken(); MyDeveloperDay wrote: > shouldn't this be > >

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726050 , @estewart08 wrote: > In D99432#2726025 , @ABataev wrote: > >> In D99432#2726019 , @estewart08 >> wrote: >> >>> In reference to

[PATCH] D101549: [Doc] Fix sphynx warnings about wrong code-block format

bader created this revision. bader added a reviewer: Anastasia. Herald added a subscriber: ebevhan. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101549 Files:

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen planned changes to this revision. ychen added a comment. Found a bug. Will fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 ___ cfe-commits mailing

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. We are seeing test failures in our builders with message after your patch. Could you take a look and fix this unit test please? FAIL: Clang :: Driver/debug-pass-structure.c (6773 of 27894) TEST 'Clang :: Driver/debug-pass-structure.c' FAILED

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. In D99599#2726252 , @evgeny777 wrote: > @haowei What are LLVM configuration options? Also please send output from > > /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -flegacy-pass-manager > -fdebug-pass-structure -O0 -S -emit-llvm

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher updated this revision to Diff 341596. delcypher added a comment. Rename def too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101491/new/ https://reviews.llvm.org/D101491 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher added a comment. @jansvoboda11 I'm going to land this patch as is (with your nit fixed). If you would like me to add an alias please follow up with me and I can put up a patch to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

shafik added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:589 + TheTarget->createMCObjectFileInfo( + /*PIC*/ false, Ctx)); + Ctx.setObjectFileInfo(MOFI.get()); `/*PIC=*/false` Comment at:

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In reference to https://bugs.llvm.org/show_bug.cgi?id=48851, I do not see how this helps SPMD mode with team privatization of declarations in-between target teams and parallel regions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

jrtc27 added a comment. I'm not convinced by these changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101352/new/ https://reviews.llvm.org/D101352 ___ cfe-commits mailing list

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. Output from `clang -flegacy-pass-manager -fdebug-pass-structure -O0 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null 2>&1`: Pass Arguments: -tti -targetlibinfo Target Transform Information Target Library

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan updated this revision to Diff 341610. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 Files: compiler-rt/lib/hwasan/hwasan_interceptors.cpp

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan added a comment. In D99381#2723563 , @vitalybuka wrote: > In D99381#2721619 , @phosek wrote: > >> What I think @vitalybuka meant is keeping >> `sanitizer_platform_limits_fuchsia.h` as you had it, but

[PATCH] D101564: [OpenMP] Fix second debug name from map clause

jdenny created this revision. jdenny added reviewers: jhuber6, jdoerfert. Herald added subscribers: guansong, yaxunl. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. This patch fixes a bug from D89802 .

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert created this revision. aaronpuchert added reviewers: dblaikie, rsmith. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implicit instantiations of template classes with virtual methods might cause the vtable (and

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

steveire added a comment. I implemented something like this recently too. The code I was trying to refactor was something like auto ii = 0; for (ii = 0; ii < thing.size(); ++ii) { // code } // code for (ii = 0; ii < thing.size(); ++ii) { // code } // code for (ii

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a comment. In D101566#2727312 , @dblaikie wrote: > I think it'd be good to gather that data first before committing it to Clang > - that's usually what we try to do to justify the warning. Well, except that this isn't a new warning.

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked 4 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">;

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

Meinersbur added a comment. testcase That is, something that calls createOffloadMaptypes/createOffloadMapnames independently of any front-end. Can be as simply as calling it and checking

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek updated this revision to Diff 341652. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 Files: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2720277 , @thakis wrote: > In D100807#2719873 , @arphaman > wrote: > >> We have M1 CI running internally but it's post >> commit only right now

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341683. dgoldman added a comment. Fix casing warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dblaikie added a comment. In D100581#2727330 , @mbenfield wrote: > Another try at these warnings, using the implementation strategy outlined by > rsmith. > > A couple other notes: > > - At the moment I've removed these warnings from the diagnostic

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

NoQ added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints-note-tags.cpp:16 +int test_note(int x, int y) { +__single_val_1(x); // expected-note{{Applied constraint: The 1st arg should be within the range [1, 1]}} +return y / (1

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. Will also make a new revision tomorrow with these warnings added to the appropriate groups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. regarding adding these to a warning group in a separate change, it's easier to revert a smaller second change that adds this to warning groups, and easier to iterate upon in tree when there are discovered issues it's not dead code if it has tests Repository: rG

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >