[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

morehouse added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:55-59 +// Utilize Intel LAM in sanitizers. Currently only used in combination with +// -fsanitize=hwaddress. This is an experimental flag which may be removed in +// the future. +// TODO: Use

[clang-tools-extra] 5389a05 - [docs] Fix documentation for bugprone-dangling-handle

Author: Malcolm Parsons Date: 2021-05-12T17:20:15+01:00 New Revision: 5389a05836e74e3acab6dbda7e80ea43e3bc6304 URL: https://github.com/llvm/llvm-project/commit/5389a05836e74e3acab6dbda7e80ea43e3bc6304 DIFF:

[PATCH] D102313: [docs] Fix documentation for bugprone-dangling-handle

This revision was automatically updated to reflect the committed changes. Closed by commit rG5389a05836e7: [docs] Fix documentation for bugprone-dangling-handle (authored by malcolm.parsons). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102313/new/

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

asb added a comment. In D70401#2733003 , @khchen wrote: > Hi, I would like to add ilp32e ABI support in llvm > Is there anyone working on this? > It seem the one thing missed is ilp32e ABI should disallow D ISA extension. > Is there anything else? Nobody

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann created this revision. mgartmann added reviewers: aaron.ballman, njames93, alexfh. mgartmann added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, mgorny, nemanjai. mgartmann requested review of this revision. Finds base classes and structs whose

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane updated this revision to Diff 344813. erichkeane added a comment. Moved `IfStmt`/discarded case logic to ExprEvaluatorBase per @rsmith 's suggestion. This is the 'highest' in the tree that has a `Sema`/`ASTContext` reference, so anything 'higher' in the tree would be higher touch.

[PATCH] D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/addrspace-constructors.clcpp:36 + Z() __local = default; + Z() __global = default; + constexpr Z() __constant : z(0) {} olestrohm wrote: > Anastasia wrote: > > We seem to be missing the

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

simon_tatham added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:1532 // // So this foldl expression implements what you'd write in Python as // [srctype for srctype in T.All if srctype != desttype] If you've removed my unreadable

[PATCH] D100985: [OpenCL] Remove pragma requirement for functions from Arm dot extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58d18dde5cca: [OpenCL] Remove pragma requirement from Arm dot extension. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. My bad. My last comment: LangOptions::SYCL::Ver2017 LangOptions::SYCL_2017 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added a comment. In D102261#2754289 , @tschuett wrote: > My bad. My last comment: > > LangOptions::SYCL::Ver2017 > LangOptions::SYCL_2017 To me, those convey the same amount of information, so the use of the scoped enum doesn't get us

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

xgupta resigned from this revision. xgupta added a comment. I am really an idol reviewer for this patch -:) don't know anything about AMDGPU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:55-59 +// Utilize Intel LAM in sanitizers. Currently only used in combination with +// -fsanitize=hwaddress. This is an experimental flag which may be removed in +// the future. +// TODO:

[clang] cbd93ce - Revert "[PowerPC] [Clang] Enable float128 feature on VSX targets"

Author: Qiu Chaofan Date: 2021-05-12T16:51:52+08:00 New Revision: cbd93cee9bf014402a7405479ba21f6f3340a126 URL: https://github.com/llvm/llvm-project/commit/cbd93cee9bf014402a7405479ba21f6f3340a126 DIFF: https://github.com/llvm/llvm-project/commit/cbd93cee9bf014402a7405479ba21f6f3340a126.diff

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 344726. mgartmann added a comment. Remove any parentheses and slashes from the check's section in `ReleaseNotes.rst` in order to try to fix the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 344731. mgartmann added a comment. Remove text from `ReleaseNotes.rst` to narrow down the cause for the failing build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/

[PATCH] D102313: [docs] Fix documentation for bugprone-dangling-handle

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102313/new/ https://reviews.llvm.org/D102313

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

aaron.ballman added a comment. In D102213#2753388 , @vsavchenko wrote: > I honestly don't see a reason why it's not a part of `forFunction`. > `forFunction` matches C++ methods and lambdas, Obj-C methods and blocks don't > seem that much more special

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:250 +/// guarantee this. +ContainerType unite(const ContainerType , const ContainerType ); ASDenysPetrov wrote: > vsavchenko

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

Anastasia updated this revision to Diff 344784. Anastasia added a comment. Added suggestions from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101843/new/ https://reviews.llvm.org/D101843 Files: clang/docs/LanguageExtensions.rst

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane added inline comments. Comment at: clang/lib/AST/Stmt.cpp:1000-1003 + if (Optional Result = + const_cast(this)->getNondiscardedCase(Ctx)) +return *Result; + return None; rsmith wrote: > Can this simply be > ``` > return

[PATCH] D102369: [ASTMatchers][NFC] Remove runtime checks where compile time is sufficient

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, alexfh. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some polymorphic matchers use dyn_cast in cases where we know the type from the

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

aganea added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:145 + StringRef SearchPath; +#ifdef _WIN32 + // Make the search insensitive to case and separators. amccarth wrote: > rnk wrote: > > I feel like this should somehow be a property

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

leonardchan created this revision. leonardchan added a project: clang. Herald added subscribers: dang, phosek. leonardchan requested review of this revision. All fuchsia targets will now use the relative-vtables ABI by default. Repository: rG LLVM Github Monorepo

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

eugenis added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:55-59 +// Utilize Intel LAM in sanitizers. Currently only used in combination with +// -fsanitize=hwaddress. This is an experimental flag which may be removed in +// the future. +// TODO: Use

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

amccarth added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:145 + StringRef SearchPath; +#ifdef _WIN32 + // Make the search insensitive to case and separators. rnk wrote: > I feel like this should somehow be a property of the input

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jdoerfert added a comment. tests missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102361/new/ https://reviews.llvm.org/D102361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 10c779d - [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

Author: Pushpinder Singh Date: 2021-05-13T01:34:03Z New Revision: 10c779d2065f7e216660f1687244269afcee13b1 URL: https://github.com/llvm/llvm-project/commit/10c779d2065f7e216660f1687244269afcee13b1 DIFF: https://github.com/llvm/llvm-project/commit/10c779d2065f7e216660f1687244269afcee13b1.diff

[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

This revision was automatically updated to reflect the committed changes. Closed by commit rG10c779d2065f: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102065/new/

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

thakis added a comment. We share obj files built on linux and on windows. So that's a goal for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102339/new/ https://reviews.llvm.org/D102339 ___

[clang] ce6cc87 - [clang] Minor fix for MarkVarDeclODRUsed

Author: Yaxun (Sam) Liu Date: 2021-05-12T22:32:10-04:00 New Revision: ce6cc87ce9e96eaa5e5ef0c1f5dc07b41381996d URL: https://github.com/llvm/llvm-project/commit/ce6cc87ce9e96eaa5e5ef0c1f5dc07b41381996d DIFF:

[PATCH] D102294: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages in condition.

NoQ updated this revision to Diff 345018. NoQ added a comment. We do actually have variadic `isa<>`! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102294/new/ https://reviews.llvm.org/D102294 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp

[clang] f690715 - Revert "[clang-repl] Land initial infrastructure for incremental parsing"

Author: Vassil Vassilev Date: 2021-05-13T04:44:19Z New Revision: f6907152db3d70606817ffe28274c6a90b331bbc URL: https://github.com/llvm/llvm-project/commit/f6907152db3d70606817ffe28274c6a90b331bbc DIFF: https://github.com/llvm/llvm-project/commit/f6907152db3d70606817ffe28274c6a90b331bbc.diff

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen marked an inline comment as done. ychen added inline comments. Comment at: clang/include/clang/AST/StmtCXX.h:356-359 Expr *Allocate = nullptr; Expr *Deallocate = nullptr; +Expr *AlignedAllocate = nullptr; +Expr *AlignedDeallocate = nullptr;

[clang] 2f9d8b0 - PR50306: When instantiating a generic lambda with a constrained 'auto',

Author: Richard Smith Date: 2021-05-12T18:45:33-07:00 New Revision: 2f9d8b08ea658b612065cbf7d4b0fbd7f28bb36a URL: https://github.com/llvm/llvm-project/commit/2f9d8b08ea658b612065cbf7d4b0fbd7f28bb36a DIFF: https://github.com/llvm/llvm-project/commit/2f9d8b08ea658b612065cbf7d4b0fbd7f28bb36a.diff

[clang] e1aa528 - Handle unexpanded packs appearing in type-constraints.

Author: Richard Smith Date: 2021-05-12T18:45:34-07:00 New Revision: e1aa528d3aaf5fcf9c50d1e34b39dbde1e63801d URL: https://github.com/llvm/llvm-project/commit/e1aa528d3aaf5fcf9c50d1e34b39dbde1e63801d DIFF: https://github.com/llvm/llvm-project/commit/e1aa528d3aaf5fcf9c50d1e34b39dbde1e63801d.diff

[clang] 4c88cfb - Add test for substitutability of variable templates in closure type

Author: Richard Smith Date: 2021-05-12T18:45:33-07:00 New Revision: 4c88cfb1dc79227be78f8dade966934384914e5e URL: https://github.com/llvm/llvm-project/commit/4c88cfb1dc79227be78f8dade966934384914e5e DIFF: https://github.com/llvm/llvm-project/commit/4c88cfb1dc79227be78f8dade966934384914e5e.diff

[clang] e0acfed - Clean up handling of constrained parameters in lambdas.

Author: Richard Smith Date: 2021-05-12T18:45:33-07:00 New Revision: e0acfed7ed5173b437868f75fc394084487e390a URL: https://github.com/llvm/llvm-project/commit/e0acfed7ed5173b437868f75fc394084487e390a DIFF: https://github.com/llvm/llvm-project/commit/e0acfed7ed5173b437868f75fc394084487e390a.diff

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. Additionally, `forCallable(functionDecl())` is not equivalent to `forFunction()` (the former silently matches less stuff). So anybody who had `functionDecl()` spelled out explicitly in their code will observe a silent change in behavior. I think that most of the time the

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 345029. Meinersbur added a comment. - Preserve relative order between OriginalInits and interleaved transformation's PreInits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur added a comment. Removed [WIP] flag; ready to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99459/new/ https://reviews.llvm.org/D99459 ___ cfe-commits mailing list

[clang] 44a4000 - [clang-repl] Land initial infrastructure for incremental parsing

Author: Vassil Vassilev Date: 2021-05-13T04:23:24Z New Revision: 44a4000181e1a25027e87f2ae4e71cb876a7a275 URL: https://github.com/llvm/llvm-project/commit/44a4000181e1a25027e87f2ae4e71cb876a7a275 DIFF: https://github.com/llvm/llvm-project/commit/44a4000181e1a25027e87f2ae4e71cb876a7a275.diff

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44a4000181e1: [clang-repl] Land initial infrastructure for incremental parsing (authored by v.g.vassilev). Herald added a project: clang. Changed

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. Thanks everybody for reviewing and help making this patch better!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with comment. Comment at: clang/test/Parser/altivec-zvector-bool.c:20-23 +__vector _Bool char Bc; +__vector _Bool short Bsh; +__vector

[clang] a0ca4c4 - [Debug-Info] add -gstrict-dwarf support in backend

Author: Chen Zheng Date: 2021-05-12T23:00:52-04:00 New Revision: a0ca4c46ca35957a38a6023fa84afda2fc9ba0ec URL: https://github.com/llvm/llvm-project/commit/a0ca4c46ca35957a38a6023fa84afda2fc9ba0ec DIFF: https://github.com/llvm/llvm-project/commit/a0ca4c46ca35957a38a6023fa84afda2fc9ba0ec.diff

[clang-tools-extra] 99d63cc - Add type information to integral template argument if required.

Author: Pratyush Das Date: 2021-05-12T19:00:08Z New Revision: 99d63ccff04b672694f8a2b3eed024b873dc163d URL: https://github.com/llvm/llvm-project/commit/99d63ccff04b672694f8a2b3eed024b873dc163d DIFF: https://github.com/llvm/llvm-project/commit/99d63ccff04b672694f8a2b3eed024b873dc163d.diff LOG:

[PATCH] D77598: Integral template argument suffix and cast printing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99d63ccff04b: Add type information to integral template argument if required. (authored by reikdas, committed by v.g.vassilev). Repository: rG

[PATCH] D102168: Use an allow list on reserved macro identifiers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102168/new/ https://reviews.llvm.org/D102168 ___ cfe-commits mailing

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 344904. aabbaabb marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CMakeLists.txt

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. I'm also mildly worried that Function is not the technically correct term. Maybe we should mark the old matcher as deprecated instead? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213

[PATCH] D102337: [clang-tidy] Fix test that requires Windows platofrm

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102337/new/ https://reviews.llvm.org/D102337 ___ cfe-commits mailing list

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl closed this revision. yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17145 }; -if (Var && Var->hasGlobalStorage() && !IsEmittedOnDeviceSide(Var)) { - SemaRef.targetDiag(Loc,

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. The breakage is loud; the code will no longer compile when the intermediate `decl()` (or `namedDecl()`, or whatever) is not present. The more annoying part is that when you add `namedDecl()` back (or if you had it spelled out this way from the start, which doesn't make

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I'm not certain what this 'aligned' limitation for nvptx syncthreads is, but can't think of a corresponding one for amdgcn. So we may not need the LDS barrier construction,

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/src/omptarget.cu:195 + +EXTERN __attribute__((weak)) +int32_t __kmpc_target_init(ident_t *Ident, bool IsSPMD, jdoerfert wrote: > JonChesterfield wrote: > > why are these

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 344949. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Teresa's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

asavonic added a comment. In D101156#2724789 , @rjmccall wrote: > What's the crash exactly/ Is IRGen just unhappy about processing the user > definition when we've generated a declaration with a different type? Because > we're already supposed to be

[clang-tools-extra] 2117613 - [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Author: Stephen Concannon Date: 2021-05-12T20:51:25+02:00 New Revision: 211761332e4381c37edd91be7c59fc048014ff4e URL: https://github.com/llvm/llvm-project/commit/211761332e4381c37edd91be7c59fc048014ff4e DIFF:

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

This revision was automatically updated to reflect the committed changes. Closed by commit rG211761332e43: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in… (authored by Stephen, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:262-264 +/// Unprototyped integer arguments are extended to 32 bits. +ExtendTo32, +/// Unprototyped integer arguments are extended to 64 bits. The comments

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

rsmith added inline comments. Comment at: clang/test/Sema/pointer-addition.cpp:5-6 + char *f = (char*)0; + f = (char*)((char*)0 - f); // expected-warning {{performing pointer arithmetic on a null pointer has undefined behavior}} + f = (char*)(f - (char*)0); //

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane added inline comments. Comment at: clang/include/clang/AST/EvaluatedExprVisitor.h:37 + // 'constexpr-if'. + bool shouldVisitDiscardedCase() const { return true; } #define PTR(CLASS) typename Ptr::type rsmith wrote: > Maybe

[clang] 08ba9ce - Suppress Deferred Diagnostics in discarded statements.

Author: Erich Keane Date: 2021-05-12T12:48:47-07:00 New Revision: 08ba9ce1ef7214623d4104e72d817c73644a0884 URL: https://github.com/llvm/llvm-project/commit/08ba9ce1ef7214623d4104e72d817c73644a0884 DIFF: https://github.com/llvm/llvm-project/commit/08ba9ce1ef7214623d4104e72d817c73644a0884.diff

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

This revision was automatically updated to reflect the committed changes. Closed by commit rG08ba9ce1ef72: Suppress Deferred Diagnostics in discarded statements. (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D102251?vs=344813=344920#toc Repository: rG LLVM

[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb7e81c64bd: Fix bad mangling of data-member-prefix for a closure in the initializer of a… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5bb7e81 - Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

Author: Richard Smith Date: 2021-05-12T13:13:21-07:00 New Revision: 5bb7e81c64bd29edd1c9ebadd4e4717919def0bf URL: https://github.com/llvm/llvm-project/commit/5bb7e81c64bd29edd1c9ebadd4e4717919def0bf DIFF: https://github.com/llvm/llvm-project/commit/5bb7e81c64bd29edd1c9ebadd4e4717919def0bf.diff

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov updated this revision to Diff 344939. AndreyChurbanov added a comment. Addressed review comments. Fixed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97085/new/ https://reviews.llvm.org/D97085 Files:

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added inline comments. Comment at: clang/test/CodeGen/extend-arg-64.c:19 + +int vararg(int, ...); + aaron.ballman wrote: > Can you also add a test for K C functions? e.g., `int knr();` `sum = > knr(sum, u32, s32, u16, s16, u8, s8);` > > Also, can you

[clang] d8c227b - Revert "Produce warning for performing pointer arithmetic on a null pointer."

Author: Nico Weber Date: 2021-05-12T14:53:50-04:00 New Revision: d8c227ba05d065046bdb8671f1df73dabaffa222 URL: https://github.com/llvm/llvm-project/commit/d8c227ba05d065046bdb8671f1df73dabaffa222 DIFF: https://github.com/llvm/llvm-project/commit/d8c227ba05d065046bdb8671f1df73dabaffa222.diff

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy created this revision. Herald added a subscriber: wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++ constructors/destructors need to go through a different constructor to construct a GlobalDecl object in order to

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert updated this revision to Diff 344918. jdoerfert added a comment. Herald added a subscriber: jvesely. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101976/new/ https://reviews.llvm.org/D101976 Files:

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:467 + if (!CalleeMD->isDefined()) { +CGM.ErrorUnsupported(ThunkGD.getDecl(), "thunk for forward declaration"); +return; efriedma wrote: > "IsUnprototyped" means that we have

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:467 + if (!CalleeMD->isDefined()) { +CGM.ErrorUnsupported(ThunkGD.getDecl(), "thunk for forward declaration"); +return; lebedev.ri wrote: > efriedma wrote: > > "IsUnprototyped"

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds a module level metadata flag indicating that

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 344941. v.g.vassilev added a comment. clang-tidy and clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files: clang/include/clang/CodeGen/CodeGenAction.h

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:496 dbgs() << "ignored! No qualifying callee with summary found.\n"); continue; } tejohnson wrote: > yaxunl

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 345053. ychen marked an inline comment as done. ychen added a comment. - Address feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files:

<    1   2