[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

sberg added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:7794-7798 +if (BO->getLHS()->getType()->isDependentType() || +BO->getRHS()->getType()->isDependentType()) +{ + if (BO->getOpcode() != BO_Assign) +return;

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 351099. vsavchenko added a comment. Rebase and change how we call track for values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files:

[PATCH] D104012: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps` to `DependencyScanning` library

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To prevent the creation of diagnostics file, `clang-scan-deps` strips the

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko updated this revision to Diff 351098. vsavchenko marked 4 inline comments as done. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103605/new/ https://reviews.llvm.org/D103605 Files:

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 351102. vsavchenko added a comment. Rebase and change `KnownSVal` to `SVal` in `trackStoredValue` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files:

[PATCH] D103628: [analyzer] Turn ReturnVisitor into a tracking visitor

vsavchenko updated this revision to Diff 351104. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103628/new/ https://reviews.llvm.org/D103628 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 ___ cfe-commits mailing list

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 351083. ksyx added a comment. add: zmmul arch string test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h

[clang] c5ffc6f - [OpenCL] Add builtin header test

Author: Sven van Haastregt Date: 2021-06-10T10:05:53+01:00 New Revision: c5ffc6f8bd6ae0e187de8b6a0e4300161952ba66 URL: https://github.com/llvm/llvm-project/commit/c5ffc6f8bd6ae0e187de8b6a0e4300161952ba66 DIFF:

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

balazske updated this revision to Diff 351082. balazske added a comment. Added AST dump without clang-format into test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103792/new/ https://reviews.llvm.org/D103792 Files:

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

vsavchenko added a comment. In D103630#2809658 , @NoQ wrote: > I guess you should mark all of these commits as NFC? I thought about, but they do change one thing: return value of `trackExpressionValue`. With each commit it's getting more consistent.

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:110 + /// (inlined defensive checks, returned null). + bool EnableNullFPSuppression = true; +}; xazax.hun wrote: > I vaguely remember we

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

DavidSpickett added a comment. Hi @pmatos, this has caused SVE related failures on our AArch64 bot (and probably others): https://lab.llvm.org/buildbot/#/builders/43/builds/7187 Not an SVE expert myself but if you need help figuring it out I can find someone to help out I'm sure. Repository:

[PATCH] D103631: [analyzer] Turn TrackControlDependencyCond into a tracking visitor

vsavchenko updated this revision to Diff 351107. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103631/new/ https://reviews.llvm.org/D103631 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

Jim added a comment. It should add arch string tests such as in clang/test/Driver/riscv-arch.c. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 ___ cfe-commits mailing list

[clang] 31859f8 - Implementation of global.get/set for reftypes in LLVM IR

Author: Paulo Matos Date: 2021-06-10T10:07:45+02:00 New Revision: 31859f896cf90d64904134ce7b31230f374c3fcc URL: https://github.com/llvm/llvm-project/commit/31859f896cf90d64904134ce7b31230f374c3fcc DIFF: https://github.com/llvm/llvm-project/commit/31859f896cf90d64904134ce7b31230f374c3fcc.diff

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. pmatos marked 2 inline comments as done. Closed by commit rG31859f896cf9: Implementation of global.get/set for reftypes in LLVM IR (authored by pmatos). Repository:

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. @njames93, Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

vsavchenko updated this revision to Diff 351106. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103630/new/ https://reviews.llvm.org/D103630 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

olestrohm added inline comments. Comment at: clang/test/AST/ast-dump-implicit-members.clcpp:10 + +// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept' +// CHECK: CXXConstructorDecl {{.*}} implicit constexpr S 'void (const __generic S &)

[clang] 64de876 - Revert "Implementation of global.get/set for reftypes in LLVM IR"

Author: David Spickett Date: 2021-06-10T10:11:17Z New Revision: 64de8763aa7cabc5aee4312ae2f9a68d8fd10bfa URL: https://github.com/llvm/llvm-project/commit/64de8763aa7cabc5aee4312ae2f9a68d8fd10bfa DIFF: https://github.com/llvm/llvm-project/commit/64de8763aa7cabc5aee4312ae2f9a68d8fd10bfa.diff

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

skirkovski added a comment. Hi @catskul, @MyDeveloperDay, Is there still interest in this feature ? My organization has had an internal implementation of this for years and I would like to replace it with an upstream version (and this one seems almost approved). Let me know if I can help

[clang-tools-extra] 0ce61d4 - Add explicit braces to silence warning about ambiguous 'else' inside the EXPECT_EQ macro. NFCI.

Author: Simon Pilgrim Date: 2021-06-10T10:55:24+01:00 New Revision: 0ce61d47c03df280ce41e226527f8c72fcfa4b13 URL: https://github.com/llvm/llvm-project/commit/0ce61d47c03df280ce41e226527f8c72fcfa4b13 DIFF: https://github.com/llvm/llvm-project/commit/0ce61d47c03df280ce41e226527f8c72fcfa4b13.diff

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2274 + const StackFrameContext *Origin) { + Tracker::create(Report)->track(V, R, Opts, Origin); +} NoQ wrote: > How does

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

DavidSpickett added a comment. Also affecting riscv-v (riscvv?) so I've reverted the change. https://lab.llvm.org/buildbot/#/builders/67/builds/3087 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425

[PATCH] D103633: [analyzer] Refactor trackExpressionValue to accept TrackingOptions

vsavchenko updated this revision to Diff 351108. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103633/new/ https://reviews.llvm.org/D103633 Files:

[clang] ac677e6 - [OpenCL] Relax test implicit members in C++ for OpenCL

Author: Ole Strohm Date: 2021-06-10T10:18:52+01:00 New Revision: ac677e69bdfc84fc64bfbc83977282d5c5223206 URL: https://github.com/llvm/llvm-project/commit/ac677e69bdfc84fc64bfbc83977282d5c5223206 DIFF: https://github.com/llvm/llvm-project/commit/ac677e69bdfc84fc64bfbc83977282d5c5223206.diff

[clang] 7fb1f62 - [clang][Arm] Require arm and aarch64 target for bf16 intrinsics test

Author: David Spickett Date: 2021-06-10T09:45:10Z New Revision: 7fb1f62d12c67d4d3193c84687f0d1267d11ba99 URL: https://github.com/llvm/llvm-project/commit/7fb1f62d12c67d4d3193c84687f0d1267d11ba99 DIFF: https://github.com/llvm/llvm-project/commit/7fb1f62d12c67d4d3193c84687f0d1267d11ba99.diff

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm updated this revision to Diff 351165. olestrohm added a comment. Added a comment explaining what the check is meant for. Also added a `CHECK-NOT: used` to properly test that the __generic constructor is not used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102850/new/

[PATCH] D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch moves enabling system header deps from `clang-scan-deps` into the

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG49eba8bf1780: [clang] Do not crash when ArgTy is null in CheckArgAlignment (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/

[clang] 49eba8b - [clang] Do not crash when ArgTy is null in CheckArgAlignment

Author: Adam Czachorowski Date: 2021-06-10T16:54:15+02:00 New Revision: 49eba8bf1780684f1173a455b909ce37008eaa09 URL: https://github.com/llvm/llvm-project/commit/49eba8bf1780684f1173a455b909ce37008eaa09 DIFF:

[clang] 936d675 - [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

Author: Markus Böck Date: 2021-06-10T17:02:44+02:00 New Revision: 936d6756ccfbe207a181b692b828f9fd8f1489f2 URL: https://github.com/llvm/llvm-project/commit/936d6756ccfbe207a181b692b828f9fd8f1489f2 DIFF: https://github.com/llvm/llvm-project/commit/936d6756ccfbe207a181b692b828f9fd8f1489f2.diff

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

This revision was automatically updated to reflect the committed changes. Closed by commit rG936d6756ccfb: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

DNS320 added a comment. Friendly Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102576/new/ https://reviews.llvm.org/D102576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104046: [analyzer] Simplify the process of producing notes for stores

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this

[PATCH] D103749: [clang][driver] Add -foperator-names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9833b57981c4: [clang][driver] Add -foperator-names (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c70b0e8 - [clang-cl] Add /permissive and /permissive-

Author: Markus Böck Date: 2021-06-10T17:06:19+02:00 New Revision: c70b0e808da8e1650f3ee426698a8b87c94b8910 URL: https://github.com/llvm/llvm-project/commit/c70b0e808da8e1650f3ee426698a8b87c94b8910 DIFF: https://github.com/llvm/llvm-project/commit/c70b0e808da8e1650f3ee426698a8b87c94b8910.diff

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc70b0e808da8: [clang-cl] Add /permissive and /permissive- (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104031/new/ https://reviews.llvm.org/D104031

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

svenvh created this revision. svenvh added reviewers: azabaznov, Anastasia. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add an emitter to produce something similar to `opencl-c.h` from

[clang] 3a7a774 - Add a page to track the status of C proposals in Clang.

Author: Aaron Ballman Date: 2021-06-10T12:00:52-04:00 New Revision: 3a7a7749417854827cf621eaef6012d31e7a82ab URL: https://github.com/llvm/llvm-project/commit/3a7a7749417854827cf621eaef6012d31e7a82ab DIFF: https://github.com/llvm/llvm-project/commit/3a7a7749417854827cf621eaef6012d31e7a82ab.diff

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille updated this revision to Diff 351191. serge-sans-paille added a comment. Added test + fix suggested by @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 Files: clang/lib/AST/Expr.cpp

[clang] c3cc14f - Revert "[clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp-contract=on"

Author: Melanie Blower Date: 2021-06-10T12:19:02-04:00 New Revision: c3cc14f87f78f8172b74175bbd2557cfb9384900 URL: https://github.com/llvm/llvm-project/commit/c3cc14f87f78f8172b74175bbd2557cfb9384900 DIFF:

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong marked an inline comment as done. martong added a comment. I have the first measurements results in the attached zip file. The file contains the html file generated by csa-testbench. It's name contains `CTU` but actually it was a regular non-CTU analysis. The most interesting is

[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

mbenfield accepted this revision. mbenfield added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103949/new/ https://reviews.llvm.org/D103949 ___ cfe-commits mailing list

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

darwin created this revision. darwin added a project: clang-format. darwin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This a bug fix of https://bugs.llvm.org/show_bug.cgi?id=50116 First revision only contains the change of the test

[PATCH] D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `clang-scan-deps` tool has some logic that parses and modifies the original

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:418 if (dep_list[i].base_addr != 0) { + KMP_DEBUG_ASSERT( + dep_list[i].flag == KMP_DEP_IN || dep_list[i].flag == KMP_DEP_OUT || protze.joachim wrote: > I

[PATCH] D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This moves another piece of logic specific to `clang-scan-deps` into the

[PATCH] D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library

jansvoboda11 added a subscriber: saudi. jansvoboda11 added a comment. FYI @saudi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104030/new/ https://reviews.llvm.org/D104030 ___ cfe-commits mailing list

[PATCH] D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104033/new/ https://reviews.llvm.org/D104033

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

darwin added a comment. Sorry, I may need some help here. It shows "Context not available.", how do I correct it? Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104044/new/ https://reviews.llvm.org/D104044

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please, amend the comment as suggested in the final commit Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + // Method overloading is handled above,

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. The bot is showing a fail due to this patch, see https://lab.llvm.org/buildbot#builders/110/builds/4007 It looks like my updates to LNT earlier this week haven't been migrated to the bot, is that right? See

[PATCH] D103987: Start tracking Clang's C implementation status

aaron.ballman closed this revision. aaron.ballman added a comment. In D103987#2809125 , @jyknight wrote: > Sounds like a great plan to me. > > I might suggest adding some text about the page being incomplete, so that > people don't wonder if the blank

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 351195. andrewjcg added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One of the goals of the dependency scanner is to provide command-lines that can be used

[clang] 9833b57 - [clang][driver] Add -foperator-names

Author: Markus Böck Date: 2021-06-10T17:01:35+02:00 New Revision: 9833b57981c4e9402a326b5acd805e074cd2c802 URL: https://github.com/llvm/llvm-project/commit/9833b57981c4e9402a326b5acd805e074cd2c802 DIFF: https://github.com/llvm/llvm-project/commit/9833b57981c4e9402a326b5acd805e074cd2c802.diff

[PATCH] D103961: [analyzer] Extract InlinedFunctionCallHandler

vsavchenko updated this revision to Diff 351115. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103961/new/ https://reviews.llvm.org/D103961 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[clang] cc86b87 - [CodeGen] limit tests to current pass manager to avoid variability; NFC

Author: Sanjay Patel Date: 2021-06-10T08:50:06-04:00 New Revision: cc86b87a57000ba673edaf95f65913412928f003 URL: https://github.com/llvm/llvm-project/commit/cc86b87a57000ba673edaf95f65913412928f003 DIFF: https://github.com/llvm/llvm-project/commit/cc86b87a57000ba673edaf95f65913412928f003.diff

[clang] 0c32ffc - [OpenMP] Add type to firstprivate symbol for const firstprivate values

Author: Joseph Huber Date: 2021-06-10T09:02:20-04:00 New Revision: 0c32ffceedca2a0d7026fc142bab8ac259131386 URL: https://github.com/llvm/llvm-project/commit/0c32ffceedca2a0d7026fc142bab8ac259131386 DIFF: https://github.com/llvm/llvm-project/commit/0c32ffceedca2a0d7026fc142bab8ac259131386.diff

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c32ffceedca: [OpenMP] Add type to firstprivate symbol for const firstprivate values (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1501 - * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=fast``). This is the default behavior. + *

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko added a comment. Oh boy! I screwed up with interactive rebases 沈 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 ___ cfe-commits mailing list

[PATCH] D104021: [clang-tidy] LIT test fix for Remark diagnostic

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104021/new/ https://reviews.llvm.org/D104021

[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

vsavchenko updated this revision to Diff 351145. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103644/new/ https://reviews.llvm.org/D103644 Files:

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

hokein accepted this revision. hokein added a comment. Thanks! Really hope this is the last time to fix this crash. Comment at: clang/lib/Sema/SemaChecking.cpp:4574 // getTypeAlignInChars requires complete types - if (ParamTy->isIncompleteType() ||

[PATCH] D103914: [analyzer] Extract ArrayIndexHandler

vsavchenko updated this revision to Diff 351113. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103914/new/ https://reviews.llvm.org/D103914 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

mizvekov added a comment. Also by the way D100713 is not really a dependency here, this DR can land on it's own if that is not clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100733/new/

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600-2604 + RValue FactorRVal = EmitAnyExpr(FactorExpr, AggValueSlot::ignored(), + /*ignoreResult=*/true); + Factor = +

[PATCH] D103633: [analyzer] Refactor trackExpressionValue to accept TrackingOptions

vsavchenko updated this revision to Diff 351143. vsavchenko added a comment. Remove unintnentionally merged changes from the next commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103633/new/ https://reviews.llvm.org/D103633 Files:

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

MyDeveloperDay added a subscriber: HazardyKnusperkeks. MyDeveloperDay added a comment. @curdeius , @HazardyKnusperkeks any thoughts, personally I don't have any problems with this even if its not my personal preference. @skirkovski if this is something you need we might need for you to take

[PATCH] D104021: [clang-tidy] LIT test fix for Remark diagnostic

ivanmurashko created this revision. ivanmurashko added reviewers: aaron.ballman, alexfh, DmitryPolukhin. ivanmurashko added projects: clang, clang-tools-extra. Herald added a subscriber: xazax.hun. ivanmurashko requested review of this revision. Herald added a subscriber: cfe-commits. There is a

[clang] 734213d - Fix test hip-device-compile.hip

Author: Yaxun (Sam) Liu Date: 2021-06-10T09:13:27-04:00 New Revision: 734213d7b51f9ea22a9d122c0646ca5b69f88ac8 URL: https://github.com/llvm/llvm-project/commit/734213d7b51f9ea22a9d122c0646ca5b69f88ac8 DIFF:

[PATCH] D104018: [clang-tidy] Allow disabling integer narrowing conversions for cppcoreguidelines-narrowing-conversions

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. gchatelet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko updated this revision to Diff 351125. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 Files:

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

skirkovski added a comment. In D90238#2810132 , @MyDeveloperDay wrote: > @curdeius , @HazardyKnusperkeks any thoughts, personally I don't have any > problems with this even if its not my personal preference. @skirkovski if > this is something you need

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103995/new/ https://reviews.llvm.org/D103995

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

melver added a comment. In D103958#2809353 , @efriedma wrote: > You could break `__builtin_load_with_control_dependency(x)` into something > like `__builtin_control_dependency(READ_ONCE(x))`. I don't think any > transforms will touch that in practice,

[clang-tools-extra] 89c41c3 - [clang-tidy] Allow disabling integer narrowing conversions for cppcoreguidelines-narrowing-conversions

Author: Guillaume Chatelet Date: 2021-06-10T12:41:57Z New Revision: 89c41c335dac288d991d1e99ad19493bc89439e4 URL: https://github.com/llvm/llvm-project/commit/89c41c335dac288d991d1e99ad19493bc89439e4 DIFF: https://github.com/llvm/llvm-project/commit/89c41c335dac288d991d1e99ad19493bc89439e4.diff

[PATCH] D104018: [clang-tidy] Allow disabling integer narrowing conversions for cppcoreguidelines-narrowing-conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rG89c41c335dac: [clang-tidy] Allow disabling integer narrowing conversions for… (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

xbolva00 added inline comments. Comment at: clang/docs/UsersManual.rst:1501 - * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=fast``). This is the default behavior. + *

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. If I can get someone to submit this on my behalf I think we can call it a day. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 ___

[PATCH] D103902: [analyzer] Extract NilReceiverHandler

vsavchenko updated this revision to Diff 35. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103902/new/ https://reviews.llvm.org/D103902 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D103677: [analyzer] Extract ControlDependencyHandler

vsavchenko updated this revision to Diff 351110. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103677/new/ https://reviews.llvm.org/D103677 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D103633: [analyzer] Refactor trackExpressionValue to accept TrackingOptions

vsavchenko added a comment. Oof, I also screwed up rebasing this commit as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103633/new/ https://reviews.llvm.org/D103633 ___ cfe-commits mailing list

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

mizvekov updated this revision to Diff 351123. mizvekov added a comment. Rebase. Now that we have isPRValue, this is hopefully less controversial now :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100733/new/ https://reviews.llvm.org/D100733

[PATCH] D101630: [HIP] Add --gpu-bundle-output

yaxunl added a comment. got test failures on some bots. fixed by 734213d7b51f9ea22a9d122c0646ca5b69f88ac8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101630/new/

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 351155. adamcz added a comment. updated after the CXXDefaultArgExpr containsErrors() change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files:

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

xbolva00 added inline comments. Comment at: clang/docs/UsersManual.rst:1501 - * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=fast``). This is the default behavior. + *

[PATCH] D103633: [analyzer] Refactor trackExpressionValue to accept TrackingOptions

vsavchenko updated this revision to Diff 351109. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103633/new/ https://reviews.llvm.org/D103633 Files:

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 351121. vsavchenko added a comment. Remove parts from the next commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files:

[PATCH] D103982: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa95937452f23: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr (authored by adamcz). Repository: rG LLVM Github Monorepo

[clang] a959374 - [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr

Author: Adam Czachorowski Date: 2021-06-10T14:51:08+02:00 New Revision: a95937452f237fad10e6b7e43154c17c6b8476c4 URL: https://github.com/llvm/llvm-project/commit/a95937452f237fad10e6b7e43154c17c6b8476c4 DIFF:

[clang] 8daac37 - [clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp-contract=on

Author: Melanie Blower Date: 2021-06-10T09:30:41-04:00 New Revision: 8daac3714083aa5507622dba858344051f6b5574 URL: https://github.com/llvm/llvm-project/commit/8daac3714083aa5507622dba858344051f6b5574 DIFF:

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. Closed by commit rG8daac3714083: [clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp… (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/D74436?vs=345526=351156#toc Repository:

[PATCH] D95496: [clang][OpenMP] Augment ForStmt/CXXForRangeStmt for OpenMP canonical loops.

Meinersbur abandoned this revision. Meinersbur added a comment. Obsolete since D94973 was committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95496/new/ https://reviews.llvm.org/D95496

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:98-101 auto Matches = match(findAll(declStmt(has(varDecl(equalsNode( .bind("declStmt")), +Body, Context);

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

HazardyKnusperkeks added a comment. I think this would be a nice addition, and in the past I would have used it. I really like the option `Pointer`. If this will be pursued I will be happy to review it. Comment at: clang/unittests/Format/FormatTest.cpp:895 +

  1   2   >