[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay added a comment. > And also another different in that case (without lambda): > > ASSERT_NO_THROW( > { > iterator += 507408; > }); > > is now format like this: > > ASSERT_NO_THROW({ iterator += 507408; }); I think this

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks great to me, I think the patch is good to go as long as Valeriy's comment is addressed :) Speaking of specs, hold up, we're forgetting something very important. `make_unique()` also has

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

NoQ added a comment. I think notes are fairly straightforward: if we're tracking one smart pointer below the swap, we should stop tracking it and start tracking the other smart pointer above the swap. If both were tracked, keep tracking both (but in swapped manners, assuming we're tracking

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

christophe-calmejane added a comment. In D104222#2821375 , @MyDeveloperDay wrote: >> @MyDeveloperDay >> Of course, sorry for the delay, here it is: >> https://github.com/christophe-calmejane/Hive/blob/master/.clang-format > > You don't have

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:54 +inline uptr GetShadowOffset() { + return SANITIZER_FUCHSIA ? 0 : __hwasan_shadow_memory_dynamic_address; +} mcgrathr wrote: > vitalybuka wrote: > > mcgrathr wrote: > > > I

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:54 +inline uptr GetShadowOffset() { + return SANITIZER_FUCHSIA ? 0 : __hwasan_shadow_memory_dynamic_address; +} vitalybuka wrote: > mcgrathr wrote: > > I think you'll eventually

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske updated this revision to Diff 352372. balazske added a comment. Using `addDeclToContexts`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay added a comment. Part of the problem here is we are not really parsing the Lambda but trying to break based on token annotation only. This can tend to be a bit fragile (normally around corner cases) The previous approach I think was not constrained enough to just lambdas which

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay added a comment. > @MyDeveloperDay > Of course, sorry for the delay, here it is: > https://github.com/christophe-calmejane/Hive/blob/master/.clang-format You don't have `AllowShortLambdasOnASingleLine` set to be `false` or `None` If you did The only difference (with this

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

christophe-calmejane added a comment. > If you did The only difference (with this current patch) would be the > positioning of the first arguments on `paramBeforeAndAfterLambda` and > `doubleLambda` (I'm not sure the reason for why that is) @MyDeveloperDay The reason is the fix I talked about

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added a comment. This has been landed in the 12.0.1 RC https://github.com/llvm/llvm-project/commit/c7d7ace46258b04aa4b5df08952bfebc6fc4ce94 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay added a comment. In D104222#2820001 , @HazardyKnusperkeks wrote: > Just asking: Would it be different if there is `auto`, `decltype(auto)`, > `decltype(a+b)`, `typename` or `template` as trailing return type? It would be good if you

[PATCH] D104097: [analyzer] Fix calculating offset for fields with an empty type

jubnzv updated this revision to Diff 352361. jubnzv added a comment. Added two tests that check whether we still calculate padding correctly for structs with `[[no_unique_address]]` on two consecutive fields CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104097/new/

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

christophe-calmejane added a comment. In D104222#2819403 , @MyDeveloperDay wrote: > @christophe-calmejane are you able to post your .clang-format styles that you > are using, I'm struggling to see where its not matching your style (other > than brace

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay added a comment. For this case: > return iter::chain.from_iterable( > [](auto&& ite) -> auto& > { > return ite.second; > }); The code has not been classified as a Lambda AnnotatedTokens(L=0): M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=return L=6 PPK=2

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6be6e31f181: [flang][driver] Add `-fdebug-dump-all` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D104305?vs=352234=352364#toc Repository: rG LLVM Github Monorepo

[clang] a6be6e3 - [flang][driver] Add `-fdebug-dump-all`

Author: Andrzej Warzynski Date: 2021-06-16T07:54:27Z New Revision: a6be6e31f1810012922e50dab0d4c15cdf990d2e URL: https://github.com/llvm/llvm-project/commit/a6be6e31f1810012922e50dab0d4c15cdf990d2e DIFF: https://github.com/llvm/llvm-project/commit/a6be6e31f1810012922e50dab0d4c15cdf990d2e.diff

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. It looks not easy to review completely. After a rough review, the first suggest is to remove the contents that should be in 'D102147 ', it makes the complex problem more complex I think. I would try to do more detailed review and

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1397 +(LHS.To() < 0 && RHS.To() < 0 && Max > 0) || +(LHS.To() < 0 && RHS.To() < 0 && Max > 0)) { + return {RangeFactory, Tmin, Tmax}; This

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

shchenz added a comment. Thanks for review @stuart In D104291#2819398 , @stuart wrote: > This looks good to me. > > @jzzheng22 informs me there was a comment in D99250 > to the effect that DW_LANG_C_plus_plus_03 > is

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4590b406c02e: [Debug-Info] guard DW_LANG_C_plus_plus_14 under strict dwarf (authored by shchenz). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

stuart added a comment. > There is no `CPlusPlus03` in `LangOptions`, so it is better not to merge > `DW_LANG_C_plus_plus_03` support with D99250 > . Oh - I see, `c++03` is defined in LangStandards.def an alias for `c++98`, as the former essentially consists

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

predator5047 updated this revision to Diff 352400. predator5047 added a comment. Updated the test case so it is clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102186/new/ https://reviews.llvm.org/D102186 Files:

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko requested changes to this revision. vsavchenko added a comment. This revision now requires changes to proceed. Hey, great work! I think that casts are extremely important, but it looks like you mixed so many things into this patch. Let's make one step at a time a split it into (at

[libunwind] 5636402 - [libcxx] Fix exception raised during downstream bare-metal libunwind tests

Author: Amilendra Kodithuwakku Date: 2021-06-16T13:35:36+01:00 New Revision: 5636402bc0c92eec2faf46edb0fb733d78fa259e URL: https://github.com/llvm/llvm-project/commit/5636402bc0c92eec2faf46edb0fb733d78fa259e DIFF:

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1409-1415 + if ((LHS.From() > 0 && RHS.From() > 0 && Min < 0) || + (LHS.From() < 0 && RHS.From() < 0 && Min > 0) || + (LHS.To() > 0 && RHS.To() > 0 && Max < 0) || +

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 352403. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files: clang/include/clang/Driver/Options.td

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

predator5047 marked an inline comment as done. predator5047 added inline comments. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:7 + +class EqDefaultCompare { + int unused_; hans wrote: > The test case feels a little strange to me, I mean the

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1409-1415 + if ((LHS.From() > 0 && RHS.From() > 0 && Min < 0) || + (LHS.From() < 0 && RHS.From() < 0 && Min > 0) || + (LHS.To() > 0 && RHS.To() > 0 && Max < 0) || +

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1409-1415 + if ((LHS.From() > 0 && RHS.From() > 0 && Min < 0) || + (LHS.From() < 0 && RHS.From() < 0 && Min > 0) || + (LHS.To() > 0 && RHS.To() > 0 && Max < 0) || +

[PATCH] D104381: [analyzer] Added a test case for PR46264

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, steakhal. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov requested review of this

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. What about this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

This revision was automatically updated to reflect the committed changes. Closed by commit rG610fea65e296: [OpenMP] libomp: fixed implementation of OMP 5.1 inoutset task dependence type (authored by AndreyChurbanov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1401-1402 + +// FIXME: This case in particular is resulting in failed assertion. +Range First = Range(Tmin, Max); +Range Second = Range(Min, Tmax);

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1397 +(LHS.To() < 0 && RHS.To() < 0 && Max > 0) || +(LHS.To() < 0 && RHS.To() < 0 && Max > 0)) { + return {RangeFactory, Tmin, Tmax};

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1409-1415 + if ((LHS.From() > 0 && RHS.From() > 0 && Min < 0) || + (LHS.From() < 0 && RHS.From() < 0 && Min > 0) || + (LHS.To() > 0 && RHS.To() > 0 && Max < 0) || +

[PATCH] D104376: [clangd] Correct SelectionTree behavior around anonymous field access.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. struct A { struct {

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added subscribers: shchenz, kbarton. stefanp requested review of this revision. Herald added a project: clang. Added a number of different builtins that exist in the XL compiler. Most of these builtins already exist in

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay updated this revision to Diff 352444. MyDeveloperDay added a comment. I wanted to add some more tests and this really only manifested itself using `lock` and `using` although the use of them is not generally broken when not using them in a Lambda expression CHANGES SINCE LAST

[PATCH] D104390: [libTooling] Change `access` stencil to recognize use of `operator*`.

ymandel updated this revision to Diff 352450. ymandel added a comment. cleanup tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104390/new/ https://reviews.llvm.org/D104390 Files: clang/lib/Tooling/Transformer/Stencil.cpp

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added a comment. In D103967#2809590 , @NoQ wrote: > Yes we should definitely have as much as possible in the state dump. Okay, I've updated likewise and added two test files to check them in State->dump. Repository: rG LLVM Github Monorepo

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. ping @Quuxplusone this is being used as a diagnostic flag that aliases "-Wframe-larger-than", I think if we want to add more user-facing documentation to clarify things we should revisit what the "-Wframe-larger-than=" tracks as well. Currently there isn't too

[clang] f387c85 - [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

Author: Yitzhak Mandelbaum Date: 2021-06-16T15:18:40Z New Revision: f387c8545d3a729eaf0e76c22f445a2209705814 URL: https://github.com/llvm/llvm-project/commit/f387c8545d3a729eaf0e76c22f445a2209705814 DIFF: https://github.com/llvm/llvm-project/commit/f387c8545d3a729eaf0e76c22f445a2209705814.diff

[PATCH] D104317: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

This revision was automatically updated to reflect the committed changes. Closed by commit rGf387c8545d3a: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use… (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104348: [index] Fix performance regression with indexing macros

benlangmuir closed this revision. benlangmuir added a comment. Pushed rG773ad55a393f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104348/new/ https://reviews.llvm.org/D104348

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

hans created this revision. hans added a reviewer: thakis. Herald added a subscriber: dang. hans requested review of this revision. Herald added a project: clang. This patch does three things: - Map the /external:I flag to -isystem - Add support for the /external:env: flag which reads system

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

erichkeane added a comment. This seems to do a lot of work that I think already exists, I believe I've seen that SPIRV targets already prohibit long-double, so doing another implementation specifically for x86 seems like the wrong approach. I'd suggest seeing if the SPIRV version works for

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. (answered now, I forgot to submit this yesterday -.- ) In D102107#2819869 , @lebedev.ri wrote: > (This is not offload-specific, right?) It is not. It applies to all parallel regions. We still use the variadic call on the

[PATCH] D104348: [index] Fix performance regression with indexing macros

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104348/new/ https://reviews.llvm.org/D104348

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan updated this revision to Diff 352476. leonardchan marked an inline comment as done. leonardchan added a comment. Rebased and formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 Files:

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 352431. Conanap added a comment. Rebase and added 64 bit sema checking Rebased to include the updated location for the builtin alias definition location, as well as added 64 bit checking for 64 bit only builtins in sema checking. Repository: rG LLVM

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, exv, lbk, jbcoe. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=50727 When processing C# Lambda

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic added a comment. @erichkeane, can you please check if this patch is OK for Clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98895/new/ https://reviews.llvm.org/D98895 ___ cfe-commits

[PATCH] D104392: [HIP] Add support functions for C++ polymorphic types

scchan created this revision. scchan added a reviewer: yaxunl. scchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add runtime functions to detect invalid calls to pure or deleted virtual functions Repository: rG LLVM Github

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

steakhal added a comment. I suspect that the exploded-graph-rewriter should be updated as well so that the HTML dumps also carry this information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967

[PATCH] D103850: [clang] diagnose instead of assert for defaulted comparison return type deduction.

rsmith added inline comments. Comment at: clang/test/CXX/class/class.compare/class.spaceship/p2.cpp:200 + struct b3 { +auto operator<=>(b3 const &) const = default; // expected-error {{cannot be deduced because three-way comparison for member 'f' would compare as builtin

[PATCH] D103855: [clang] Exclude function pointers on DefaultedComparisonAnalyzer

rsmith added a comment. I think we need to take this to the C++ committee. For example, consider a case like: struct A { using T1 = void(*)(); using T2 = int; operator T1(); operator T2(); }; struct B { A a; friend auto operator<=>(B, B) = default; }; Under the

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352423. serge-sans-paille added a comment. Tried another not-so-intrusive approach. @rsmith? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104299/new/ https://reviews.llvm.org/D104299 Files: clang/include/clang/Sema/Sema.h

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. We used this kind of codegen initially but later found out that it causes a large overhead when gathering pointers into a record. What about hybrid scheme where the first args are passed as arguments and others (if any) are gathered into a record? Repository: rG

[PATCH] D104389: [ASTMatchers] Fix bug in `hasUnaryOperand`

ymandel created this revision. ymandel added a reviewer: gribozavr2. ymandel requested review of this revision. Herald added a project: clang. Currently, `hasUnaryOperand` fails for the overloaded `operator*`. This patch fixes the bug and adds tests for this case. Repository: rG LLVM Github

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

yaxunl added a comment. Does this pass internal CI (ePSDB) ? I am concerned about the enforcement of the canonical format of target triple since this may break backward compatibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/

[PATCH] D104390: [libTooling] Change `access` stencil to recognize use of `operator*`.

ymandel created this revision. ymandel added a reviewer: gribozavr2. ymandel requested review of this revision. Herald added a project: clang. Currently, `access` doesn't recognize a dereferenced smart pointer. So, `access(e, "field")` where `e = *x`, yields: - `x->field`, for normal-pointer x,

[PATCH] D104390: [libTooling] Change `access` stencil to recognize use of `operator*`.

ymandel updated this revision to Diff 352453. ymandel added a comment. add comments and simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104390/new/ https://reviews.llvm.org/D104390 Files: clang/lib/Tooling/Transformer/Stencil.cpp

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 352464. martong added a comment. - Extend printJson to handle equivalency info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 Files:

[PATCH] D104392: [HIP] Add support functions for C++ polymorphic types

yaxunl added a comment. can you add a test to https://github.com/llvm/llvm-project/blob/main/clang/test/Headers/hip-header.hip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104392/new/ https://reviews.llvm.org/D104392

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

thakis added a comment. Nice, that's much less convoluted than I had feared :) Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1255 +} + } + `/external:env` should happen after winsysroot I think. sysroots try to make builds hermetic and env vars defeat

[clang] 773ad55 - [index] Fix performance regression with indexing macros

Author: Ben Langmuir Date: 2021-06-16T10:16:26-07:00 New Revision: 773ad55a393f368cc92b1611c52e493ed45a353f URL: https://github.com/llvm/llvm-project/commit/773ad55a393f368cc92b1611c52e493ed45a353f DIFF: https://github.com/llvm/llvm-project/commit/773ad55a393f368cc92b1611c52e493ed45a353f.diff

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

Quuxplusone added a comment. Some tiny nits. I can't think of any interesting block-related cases (but my knowledge of blocks is apparently very rusty at this point). Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1100 +// This is the last chance we have of

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

awarzynski added a comment. Apologies, this is my fault. Should be fixed: https://github.com/llvm/llvm-project/commit/46446e398b5202303280d9e18676c07529f1d0b0. I pushed it without a review as it felt rather straightforward and I wanted to make sure that you are unblocked. If for whatever

[PATCH] D103855: [clang] Exclude function pointers on DefaultedComparisonAnalyzer

mizvekov added a comment. I see. I can change this patch so it just implicitly deletes the operator in case we decide to pick function pointers, without the hard error introduced by the previous patch. And if the comitee decides to stop providing relational operators for function pointers, we

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

klausler added a comment. No; I'm hitting this problem with an in-tree static build of llvm-project/main. Weird. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. In D103096#2821750 , @vsavchenko wrote: > Hey, great work! I think that casts are extremely important, but it looks > like you mixed so many things into this patch. Let's make one step at a time > a split it into (at

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

klausler added a comment. The non-shared-library build of the current llvm-project/main tree fails on this new test; it looks as if gfortran is being invoked and passed an option that it does not recognize. The shared library build passes all tests. Repository: rG LLVM Github Monorepo

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

PeteSteinfeld added a comment. In D104305#2822589 , @klausler wrote: > The non-shared-library build of the current llvm-project/main tree fails on > this new test; it looks as if gfortran is being invoked and passed an option > that it does not

[clang] 439c920 - [ASTMatchers] Fix bug in `hasUnaryOperand`

Author: Yitzhak Mandelbaum Date: 2021-06-16T20:17:56Z New Revision: 439c9206945aba15d74d5bcaef3bf3f4d1e32b5e URL: https://github.com/llvm/llvm-project/commit/439c9206945aba15d74d5bcaef3bf3f4d1e32b5e DIFF: https://github.com/llvm/llvm-project/commit/439c9206945aba15d74d5bcaef3bf3f4d1e32b5e.diff

[PATCH] D104389: [ASTMatchers] Fix bug in `hasUnaryOperand`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG439c9206945a: [ASTMatchers] Fix bug in `hasUnaryOperand` (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103850: [clang] diagnose instead of assert for defaulted comparison return type deduction.

mizvekov added inline comments. Comment at: clang/test/CXX/class/class.compare/class.spaceship/p2.cpp:200 + struct b3 { +auto operator<=>(b3 const &) const = default; // expected-error {{cannot be deduced because three-way comparison for member 'f' would compare as builtin

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

bjope added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99439/new/ https://reviews.llvm.org/D99439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104420: thread_local support for AIX

jamieschmeiser created this revision. jamieschmeiser added reviewers: hubert.reinterpretcast, sfertile, cebowleratibm, DiggerLin, rsmith. jamieschmeiser requested review of this revision. Herald added a project: clang. Changes to support thread_local storage on AIX. The AIX linker will

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks added a comment. In D104096#2820206 , @skirkovski wrote: > Ping, > > I do not have commit access, can someone submit this as time permits ? Please state the name and email for the commit, I will commit it on the weekend.

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added a comment. @dylanmckay is there anything else I need to update on this patch? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 ___

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

PeteSteinfeld added a comment. For what it's worth, here's my cmake command that results in a successful static full build: cmake -G Ninja ../llvm \ -DCMAKE_BUILD_TYPE=Release \ -DLLVM_LIT_ARGS=-v \ -DFLANG_ENABLE_WERROR=On \

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

vitalybuka accepted this revision. vitalybuka added a reviewer: mcgrathr. vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:62 AST_MATCHER_FUNCTION(StatementMatcher, isInitializedFromReferenceToConst) { auto OldVarDeclRef = This name seems a little off now.

[clang] c7ed4fe - [libTooling] Change `access` stencil to recognize use of `operator*`.

Author: Yitzhak Mandelbaum Date: 2021-06-16T20:34:00Z New Revision: c7ed4fe56e0a6c664c5fb5dedaedb426abe7224d URL: https://github.com/llvm/llvm-project/commit/c7ed4fe56e0a6c664c5fb5dedaedb426abe7224d DIFF: https://github.com/llvm/llvm-project/commit/c7ed4fe56e0a6c664c5fb5dedaedb426abe7224d.diff

[PATCH] D104390: [libTooling] Change `access` stencil to recognize use of `operator*`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7ed4fe56e0a: [libTooling] Change `access` stencil to recognize use of `operator*`. (authored by ymandel). Repository: rG LLVM Github Monorepo

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. I don't know how to commit. Happy to do it if I have the permissions & appropriate instructions. Name: Vitali Lovich E-mail: vlov...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102706/new/ https://reviews.llvm.org/D102706

[PATCH] D102730: [clang-format] Support custom If macros

vlovich added a comment. Just back from vacation so will try to polish this off today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 352566. mizvekov added a comment. Fix Arthur's nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files: clang/include/clang/Sema/Sema.h

[PATCH] D104424: [Sema] Fix for PR50741

chrish_ericsson_atx created this revision. chrish_ericsson_atx added reviewers: erichkeane, aaron.ballman, abhinavgaba. chrish_ericsson_atx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed crash when doing pointer math on a void

[PATCH] D104424: [Sema] Fix for PR50741

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Two small changes to the test that you can do as a part of committing. Thanks! Comment at: clang/test/Sema/unbounded-array-bounds.c:17

[clang] 12c90e2 - [clang] NRVO: Improvements and handling of more cases.

Author: Matheus Izvekov Date: 2021-06-17T01:56:38+02:00 New Revision: 12c90e2e25dfd1d38250055efc21acb42d158912 URL: https://github.com/llvm/llvm-project/commit/12c90e2e25dfd1d38250055efc21acb42d158912 DIFF:

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12c90e2e25df: [clang] NRVO: Improvements and handling of more cases. (authored by mizvekov). Changed prior to commit:

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 352617. ychen marked 3 inline comments as done. ychen added a comment. - Remove AlignedAllocator & AlignedDeallocator. - Use 'OverAllocateFrame' - Get rid of `if (HasAlignArg)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:743-744 +CGM.getIntrinsic(llvm::Intrinsic::coro_align, SizeTy)); +auto *AlignedUpAddr = EmitBuiltinAlignTo(AlignedAllocateCall, CoroAlign, +

[PATCH] D104424: [Sema] Fix for PR50741

abhinavgaba added a comment. @erichkeane, can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424 ___ cfe-commits mailing list

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai updated this revision to Diff 352572. vsapsai added a comment. Test when a non-modular header *is* visible through a module import (mostly for completeness). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 352573. vlovich added a comment. Review response I've updated coverage for AllowShortIfStatementsOnASingleLine and BreakBeforeBraces. SpacesInConditionalStatement is what the existing tests were covering so I don't think there's anything there to update. I

  1   2   >