[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

MaskRay added a comment. In D104831#2838835 , @hoy wrote: > In D104831#2837712 , @MaskRay wrote: > >>> Adding the platform tripplet x86_64-redhat-linux-gnu the while list of >>> supported x86_64 triplets so that

[PATCH] D104804: [AMDGPU] Add gfx1035 target

aakanksha555 updated this revision to Diff 354270. aakanksha555 marked 4 inline comments as done. aakanksha555 added a comment. Addressed feedback; fixed typo and missing check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/

[PATCH] D104804: [AMDGPU] Add gfx1035 target

foad added a comment. Looks OK. Have you run check-llvm and check-clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/ https://reviews.llvm.org/D104804 ___ cfe-commits mailing list

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

dblaikie added a comment. In D104777#2838211 , @aaron.ballman wrote: > In D104777#2837794 , @dblaikie > wrote: > >> In D104777#2837347 , >> @brunodefraine wrote: >>

[PATCH] D104804: [AMDGPU] Add gfx1035 target

MaskRay added inline comments. Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:189 +# RUN: sed -e 's//64/' -e 's//AMDGCN_GFX1035/' %s | yaml2obj -o %t.o.AMDGCN_GFX1035 +# RUN: llvm-readobj -S --file-headers %t.o.AMDGCN_GFX1035 | FileCheck

[PATCH] D104804: [AMDGPU] Add gfx1035 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3453f3dd46f5: [AMDGPU] Add gfx1035 target (authored by aakanksha555). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

tstellar added a comment. In D104831#2838835 , @hoy wrote: > In D104831#2837712 , @MaskRay wrote: > >>> Adding the platform tripplet x86_64-redhat-linux-gnu the while list of >>> supported x86_64 triplets so

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy added a comment. In D104831#2839301 , @tstellar wrote: > In D104831#2838835 , @hoy wrote: > >> In D104831#2837712 , @MaskRay >> wrote: >> Adding the platform

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:301 + const OverloadedOperatorKind OOK = FD->getOverloadedOperator(); + if (!(OOK == OO_Equal || OOK == OO_ExclaimEqual || OOK == OO_Less || +OOK == OO_LessEqual || OOK

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy added a comment. In D104831#2837712 , @MaskRay wrote: >> Adding the platform tripplet x86_64-redhat-linux-gnu the while list of >> supported x86_64 triplets so that it can be used with the --gcc-toolchain >> option to bypass this process and

[PATCH] D104381: [analyzer] Added a test case for PR46264

NoQ added a comment. I bisected. This bug was fixed intentionally by D85817 , forgot to close I guess. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104381/new/ https://reviews.llvm.org/D104381

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

Anastasia added a comment. LGTM! Thanks I agree we should have the same behavior for both options. Technically `-finclude-default-header` could be added in both steps but it is only effective in parsing the sources and does nothing otherwise. But it seems cleaner to align it with the header

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo added a comment. In D104819#2839263 , @dexonsmith wrote: > LGTM, once @MaskRay is happy. I have a couple of minor comments inline too. > > (I also see that there are some clang-format suggestions in the unit tests; > not sure any of them are

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay updated this revision to Diff 354205. MyDeveloperDay added a comment. Fix `parseBracedList()` to do what `parseStructuralElement()` does (with regard to breaking `AfterFunction`, I'm not completely convinced `AfterFunction` should have been reused for that but might be too late

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

steffenlarsen created this revision. steffenlarsen added a reviewer: tra. Herald added subscribers: hiraditya, yaxunl, jholewinski. steffenlarsen requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Adds NVPTX

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. In D93525#2838535 , @yaxunl wrote: > LGTM. Thanks! Pls make sure it passes internal CI (ePSDB) before committing. Sure, I will take care of it. Thanks! Any comments @jdoerfert ? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong added a comment. > I don't really get why we get not simplified symbol to begin with. This is because of the Environment bindings. I.e.` b1` is bound to `$a0 - $b0 + $c` when we evaluate `int b1 = (unsigned)a1 + c;`. This binding is not changed/updated, so when we evaluate the division

[PATCH] D102507: [HIP] Support in device code

yaxunl added a comment. In D102507#2833594 , @ldionne wrote: > In D102507#2830688 , @yaxunl wrote: > >> In D102507#2792087 , @rsmith wrote: >> >>> @ldionne How should we

[PATCH] D104550: [analyzer] Implement getType for SVal

ASDenysPetrov added a comment. I'm in favor of this patch. It will help simplify `SValBuilder::evalCast`, which takes an optional parameter `OriginalTy` and acts differently based on whether it has been passed or has not. Since `sizeof(SVal)` became bigger (x1.5). I'm wondering of how much

[PATCH] D104550: [analyzer] Implement getType for SVal

vsavchenko added a comment. In D104550#2838827 , @ASDenysPetrov wrote: > I'm in favor of this patch. It will help simplify `SValBuilder::evalCast`, > which takes an optional parameter `OriginalTy` and acts differently based on > whether it has been

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2838754 , @craig.topper wrote: > Doesn't gcc also fold isnan to false under fast math? If we diverge here that > means your code would only work correctly with clang. GCC does the same transformation, ICC and MSVC

[PATCH] D102507: [HIP] Support in device code

tra added a comment. The key difference between C++ and CUDA/HIP, as implemented in clang, is that `__host__` and `__device__` attributes are considered during function overloading in CUDA and HIP, so `__host__ void foo()`, `__device__ void foo()` and `__host__ __device__ void foo()` are three

[PATCH] D104804: [AMDGPU] Add gfx1035 target

aakanksha555 added a comment. In D104804#2838883 , @foad wrote: > Looks OK. Have you run check-llvm and check-clang? I did, no other failing tests observed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354323. RedDocMD added a comment. Removed re-invention, added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In general, I think this looks good (I did find one minor nit that removes an include, but that can be fixed as you land). There's an open question for @jansvoboda11 and it'd be

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added a comment. Awesome, thanks for swiftly addressing it! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1981 for (const SymbolRef : ClassMembers) { -SymbolRef SimplifiedMemberSym = ::simplify(State, MemberSym); +SymbolRef

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

awarzynski updated this revision to Diff 354294. awarzynski added a subscriber: PeteSteinfeld. awarzynski added a comment. Rename the new flag as `-fno-analyzed-objects-for-unparse` Based on the discussion, I've renamed the flag to better reflect the intention. Does it make more sense now?

[PATCH] D104822: [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

craig.topper updated this revision to Diff 354297. craig.topper added a comment. Add constant argument range checking to SemaChecking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104822/new/ https://reviews.llvm.org/D104822 Files:

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

rsmith added a comment. I would prefer to split this into two changes: 1. Stop providing a builtin overload candidate `R operator<=>(P, P)` where `P` is a function pointer type, to be consistent with the behavior of the built-in `<=>` operator. 2. Stop providing `<`/`<=`/`>`/`>=` support for

[clang] b3ccf4f - [clang-format][NFC] Fix documentation

Author: Björn Schäpers Date: 2021-06-24T21:19:14+02:00 New Revision: b3ccf4fc02cdb12eb0929ad9f9dfdec39b785e6a URL: https://github.com/llvm/llvm-project/commit/b3ccf4fc02cdb12eb0929ad9f9dfdec39b785e6a DIFF:

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2520 + /// readability to have the signature indented two levels and to use + /// ``OuterScope``. The KJ style guide requires ``OuterScope`. + /// `KJ style guide Here

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong updated this revision to Diff 354274. martong added a comment. - Use simplify from RangedConstraintManager Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104844/new/ https://reviews.llvm.org/D104844 Files:

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

mibintc updated this revision to Diff 354300. mibintc added a comment. Rebasing. Hope this clears lit fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99675/new/ https://reviews.llvm.org/D99675 Files: llvm/docs/LangRef.rst

[clang] 3453f3d - [AMDGPU] Add gfx1035 target

Author: Aakanksha Patil Date: 2021-06-24T14:32:41-04:00 New Revision: 3453f3dd46f5214e028cb33818b10c5d995cd858 URL: https://github.com/llvm/llvm-project/commit/3453f3dd46f5214e028cb33818b10c5d995cd858 DIFF:

[clang] 8db0dbb - [CodeGen] Don't create fake FunctionDecls when generating block/byref

Author: Akira Hatanaka Date: 2021-06-24T11:45:52-07:00 New Revision: 8db0dbbe2c0544c38f33cf64b4cdd5135d524b23 URL: https://github.com/llvm/llvm-project/commit/8db0dbbe2c0544c38f33cf64b4cdd5135d524b23 DIFF:

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 updated this revision to Diff 354324. jhuber6 added a comment. Addings tests and a module flag for openmp target devices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102361/new/ https://reviews.llvm.org/D102361 Files:

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice. Thank you for adding support for these missing instructions! LGTM, modulo a few of cosmetic nits. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:762 +// Builtins

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

lattner accepted this revision. lattner added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104819/new/ https://reviews.llvm.org/D104819 ___ cfe-commits mailing list

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + vsavchenko wrote: > martong

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354301. mibintc added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/Builtins.def

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. We have a failing test here (test at line 473). Which makes me wonder if the `handleComparision` function is at all called. This is something I need to check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, once @MaskRay is happy. I have a couple of minor comments inline too. (I also see that there are some clang-format suggestions in the unit tests; not sure any of them are

[PATCH] D104550: [analyzer] Implement getType for SVal

Szelethus added a comment. In D104550#2838845 , @vsavchenko wrote: >> Another thing is that we can garantee returning `QualType`. I mean, we can >> replace `Optional` with `QualType` itself. `QualType` has a default ctor and >> `isNull` predicate,

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

HazardyKnusperkeks added a comment. In D104774#2838287 , @MyDeveloperDay wrote: > @HazardyKnusperkek Its probably my "bad" I should said "LGTM but maybe wait > for the others to comment", but I'm fundamentally ok I think with the change. > (we'll just

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

chrish_ericsson_atx added a comment. In D104285#2836190 , @ASDenysPetrov wrote: >> I think the presence of the initializer list in the test case is not >> necessary to trigger the spurious warnings > > Could you please provide some test cases that you

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

dexonsmith added a comment. In D104819#2839315 , @mstorsjo wrote: > In D104819#2839263 , @dexonsmith > wrote: > >> Just be sure to clang-format when you do the mechanical changes in the >> follow up patches.) >

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 354218. whisperity added a comment. **NC** Rebase & more buildbot shenanigans so we can get a pass! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78652/new/ https://reviews.llvm.org/D78652 Files:

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 354231. SaurabhJha added a comment. Address round 2 comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst Index:

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2838653 , @tlively wrote: > The opaque pointers project is documented here: > https://llvm.org/docs/OpaquePointers.html. It's been making very slow > progress for the past few years but has recently been picking up

[PATCH] D104854: Introduce intrinsic llvm.isnan

craig.topper added a comment. Doesn't gcc also fold isnan to false under fast math? If we diverge here that means your code would only work correctly with clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/

[PATCH] D90399: [clang-tidy] non-portable-integer-constant check

whisperity added inline comments. Herald added a subscriber: cfe-commits. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:38 #include "NoEscapeCheck.h" +#include "NonportableintegerconstantCheck.h" #include "NotNullTerminatedResultCheck.h"

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

aaron.ballman added a comment. In D104777#2837794 , @dblaikie wrote: > In D104777#2837347 , @brunodefraine > wrote: > >> In D104777#2836669 , @dblaikie >> wrote: >> >>>

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 354210. whisperity added a comment. **NC** Rebase, buildbots, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75041/new/ https://reviews.llvm.org/D75041 Files:

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/AST/ASTContext.cpp:2570-2571 +getSubobjectSizeInBits(const FieldDecl *Field, const ASTContext ) { + if (Field->getType()->isRecordType()) { +const RecordDecl *RD =

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. Somehow the builds are failing even though this patch contains no code changes. Comment at: clang/docs/LanguageExtensions.rst:526 +The matrix type extension also supports operations between a matrix and a scalar. + fhahn wrote: >

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff created this revision. sepavloff added reviewers: efriedma, kpn, thopre, jonpa, cameron.mcinally, RKSimon, craig.topper. Herald added subscribers: jdoerfert, pengfei, hiraditya. sepavloff requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber:

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. Sorry, I committed this without the `Differential Revision: https://reviews.llvm.org/D104198` line. Is there a way to change the commit message after it is in main? I could not push after `git commit --amend` Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] c5028f3 - [Clang] XFAIL sanitize-coverage-old-pm.c on 32bit Armv8l

Author: Muhammad Omair Javaid Date: 2021-06-24T15:48:13+05:00 New Revision: c5028f3473ed50a7433fe278984cd1a755b338b9 URL: https://github.com/llvm/llvm-project/commit/c5028f3473ed50a7433fe278984cd1a755b338b9 DIFF:

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118 ___ cfe-commits mailing list

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. In D104198#2838658 , @SaurabhJha wrote: > Sorry, I committed this without the `Differential Revision: > https://reviews.llvm.org/D104198` line. Is there a way to change the commit > message after it is in main? I could not push

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + vsavchenko wrote: > I don't like the idea of duplicating it into every

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

jdoerfert accepted this revision. jdoerfert added a comment. Looks reasonable to me. We can always refine it as we go. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:137 +/// * GPUArch (Optional) - Processor name, like gfx906 or sm_30 +/// In presence

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 354229. whisperity added a comment. **NC** Rebase and buildbot trigger. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97297/new/ https://reviews.llvm.org/D97297 Files:

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 354232. SaurabhJha added a comment. Rebase with latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst Index:

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha closed this revision. SaurabhJha added a comment. This is closed by this commit https://github.com/llvm/llvm-project/commit/cd256c8bcc9723f0ce7a32957f26600c966fa07c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

whisperity updated this revision to Diff 354203. whisperity added a comment. **NC** Fix lint mishap that occurred during previous rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96355/new/ https://reviews.llvm.org/D96355 Files:

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. In D104616#2835061 , @xazax.hun wrote: > In D104616#2835030 , @RedDocMD > wrote: > >> Looks like I have wasted a good deal of effort. :( > > Sorry about that! :( If we learned anything

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2838468 , @thopre wrote: > Are you planning to do this for the other FP test builtin (isinf, isfinite, > isinf_sign, isnormal)? Yes, they have similar problems. If someone would like to implement them it would be

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added a subscriber: aeubanks. tlively added a comment. The opaque pointers project is documented here: https://llvm.org/docs/OpaquePointers.html. It's been making very slow progress for the past few years but has recently been picking up steam under the direction of @aeubanks. Search

[PATCH] D90399: [clang-tidy] non-portable-integer-constant check

steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/NonportableintegerconstantCheck.cpp:54 + +MaskStr = StringRef(MaskStr.lower()); +if (!MaskStr.consume_front("0x")) You are assigning a pointer to a temporal std::string.

[PATCH] D104854: Introduce intrinsic llvm.isnan

jdoerfert added a comment. In D104854#2838495 , @sepavloff wrote: > In D104854#2838468 , @thopre wrote: > >> Are you planning to do this for the other FP test builtin (isinf, isfinite, >> isinf_sign, isnormal)?

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added a comment. In D104844#2838674 , @martong wrote: >> I don't really get why we get not simplified symbol to begin with. > > This is because of the Environment bindings. I.e.` b1` is bound to `$a0 - $b0 > + $c` when we evaluate `int b1 =

[PATCH] D104804: [AMDGPU] Add gfx1035 target

foad added inline comments. Comment at: clang/test/Driver/amdgpu-mcpu.cl:138 // GFX1034: "-target-cpu" "gfx1034" +// GFX1034: "-target-cpu" "gfx1035" Typo in check prefix. Why didn't this make the test fail? Comment at:

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo added a comment. In D104819#2837421 , @dexonsmith wrote: > Given how large this is, would it be reasonable to split this up a bit more? > > What I might do if this were my patch: get a review of the API change + the > manual changes in one

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo updated this revision to Diff 354178. mstorsjo added a comment. Reduced this patch only to updating of the StringRef class itself and its unit test, removing the mechanical changes. Removed superfluous method name duplication in doxygen comments. Repository: rG LLVM Github Monorepo

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

dexonsmith added a comment. Given how large this is, would it be reasonable to split this up a bit more? What I might do if this were my patch: get a review of the API change + the manual changes in one patch (assuming there aren't many manual changes), then land the remaining mechanical

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#2837136 , @mstorsjo wrote: > In D104556#2837104 , @rnk wrote: > >> Swift wanted the same thing, so I think the answer is yes, we should ask. > > What would the benefit of that

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

MaskRay added inline comments. Comment at: llvm/include/llvm/ADT/StringRef.h:192 -/// equals_lower - Check for string equality, ignoring case. +/// equals_insensitive - Check for string equality, ignoring case. LLVM_NODISCARD

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + I don't like the idea of duplicating it into every `assume` method.

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov updated this revision to Diff 354225. ASDenysPetrov added a comment. Added assertions. Added two helper functions for `castTo` method. Moved some distinct code to them. Fixed clang-tidy complaints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. Thanks for the latest changes! Comment at: clang/docs/LanguageExtensions.rst:526 +The matrix type extension also supports operations between a matrix and a scalar. + I'm not a native speaker, but I am not sure if `between` is the best

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. In D104198#2838416 , @SaurabhJha wrote: > Somehow the builds are failing even though this patch contains no code > changes. There a few reasons as to why the tests may fail unrelated to the patch (flaky tests, infrastructure

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Are you planning to do this for the other FP test builtin (isinf, isfinite, isinf_sign, isnormal)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks! Pls make sure it passes internal CI (ePSDB) before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2837417 , @tlively wrote: > In D104797#2836475 , @pmatos wrote: > >> @tlively Do you think it would be ok to re-add the code removed in >> `ac81cb7e` but only error if the

[clang] cd256c8 - Add documentation for compound assignment and type conversion of matrix types

Author: Saurabh Jha Date: 2021-06-24T15:50:58+01:00 New Revision: cd256c8bcc9723f0ce7a32957f26600c966fa07c URL: https://github.com/llvm/llvm-project/commit/cd256c8bcc9723f0ce7a32957f26600c966fa07c DIFF: https://github.com/llvm/llvm-project/commit/cd256c8bcc9723f0ce7a32957f26600c966fa07c.diff

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2838659 , @jdoerfert wrote: > In D104854#2838495 , @sepavloff > wrote: > >> In D104854#2838468 , @thopre wrote: >> >>> Are you

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 354197. saiislam added a comment. Generalized padding of Triple fields of Bundle Entry ID while generating command for clang-offload-bundler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

MyDeveloperDay added a comment. @HazardyKnusperkek Its probably my "bad" I should said "LGTM but maybe wait for the others to comment", but I'm fundamentally ok I think with the change. (we'll just revert if it breaks stuff! ;-)) We are free to add review comments after the fact, @owenpan has

[PATCH] D97204: [RFC] Clang 64-bit source locations

simon_tatham added a comment. Hmmm. Two people have pointed out to me that my strategy of having a 32-bit `SourceLocations::LowBits` and an 0- or 32-bit `SourceLocations::OptionalHighBits` doesn't actually work, because an empty struct still takes at least 1 byte. So this version of the patch

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM,thanks. Comment at: clang/docs/LanguageExtensions.rst:546 + +The matrix type extension supports compound assignments for addition, subtraction, and multiplication

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. Thanks, the build is also passing now so I will land this in a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 ___ cfe-commits

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. In D104198#2838665 , @fhahn wrote: > In D104198#2838658 , @SaurabhJha > wrote: > >> Sorry, I committed this without the `Differential Revision: >> https://reviews.llvm.org/D104198`

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp updated this revision to Diff 354422. stefanp added a comment. Updated the name of the option to cover all of the inconsistencies for vector pixel/bool. Future patches will continue to use this option to define the behaviour of these two types. Reworded the warning message. Added

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 354424. manas added a comment. Fix issues involving usage of `uadd_ov` and family of functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files:

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. I reported bugs of using clang-cl and lld to test https://github.com/microsoft/compiler-tests/tree/master/seh 2. clang-cl.exe + lld linker a. x4ptcu.c: build error https://bugs.llvm.org/show_bug.cgi?id=50859 b. seh0015.c, seh0017.c: build crash

[PATCH] D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons

rsmith added a comment. Thanks, the summary gave me a chuckle :) Comment at: clang/lib/Sema/SemaExpr.cpp:11809-11812 +Diag(Loc, IsError + ? diag::err_typecheck_ordered_comparison_of_function_pointers + :

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

browneee created this revision. browneee added reviewers: stephan.yichao.zhao, gbalats. Herald added subscribers: pengfei, hiraditya. browneee requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits.

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov added a comment. First part of the split implemented at: https://reviews.llvm.org/D104892 I will reuse this DR for the second part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104680/new/ https://reviews.llvm.org/D104680

  1   2   >