[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart added a comment. On reflection, I don't think it makes sense to make use of DW_LANG_C_plus_plus_17 or DW_LANG_C_plus_plus_20 in Clang just yet, as these are generally not supported by other tooling. I am a bit confused by DWARF publishing these tags ahead of time, yet tooling having not

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

This revision was automatically updated to reflect the committed changes. Closed by commit rGe47027d091de: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/

[clang] e47027d - [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

Author: Stuart Brady Date: 2021-06-25T11:48:42+01:00 New Revision: e47027d091deb4a0774eab911411a27092a60916 URL: https://github.com/llvm/llvm-project/commit/e47027d091deb4a0774eab911411a27092a60916 DIFF: https://github.com/llvm/llvm-project/commit/e47027d091deb4a0774eab911411a27092a60916.diff

[PATCH] D104550: [analyzer] Implement getType for SVal

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SVals.cpp:154 + Optional VisitLocGotoLabel(loc::GotoLabel GL) { +return QualType{Context.VoidPtrTy}; + } NoQ wrote: > ASDenysPetrov wrote: > > vsavchenko wrote: > > >

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

ronlieb added subscribers: estewart08, ashi1. ronlieb added a comment. @estewart08 @ashi1 please review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 ___

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

sammccall added a comment. Back from vacation! Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:420 + if (!File) +return false; // do not skip non-file locations + StringRef FileName(File->getName()); this is probably worth some explanation

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay added a comment. ping, if there are no other opinions I plan to land this sometime this weekend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 ___ cfe-commits mailing list

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354460. RedDocMD added a comment. Removed dump statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:466 + + clang_analyzer_eval(ptr == ptr); // expected-warning{{TRUE}} + clang_analyzer_eval(ptr > ptr); // expected-warning{{FALSE}} xazax.hun wrote: > Putting tests like this on the

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354459. RedDocMD added a comment. Refactored code, removed duplications, fixed tests, added some more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D104804: [AMDGPU] Add gfx1035 target

jhenderson added inline comments. Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:189 +# RUN: sed -e 's//64/' -e 's//AMDGCN_GFX1035/' %s | yaml2obj -o %t.o.AMDGCN_GFX1035 +# RUN: llvm-readobj -S --file-headers %t.o.AMDGCN_GFX1035 | FileCheck

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, ye-luo, ronlieb, gregrodgers, jdoerfert. Herald added subscribers: guansong, yaxunl, jvesely. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1981 for (const SymbolRef : ClassMembers) { -SymbolRef SimplifiedMemberSym = ::simplify(State, MemberSym); +SymbolRef SimplifiedMemberSym =

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG0646e3625499: [Analyzer][solver] Fix crashes during symbol simplification (authored by martong). Changed prior to commit:

[clang] 0646e36 - [Analyzer][solver] Fix crashes during symbol simplification

Author: Gabor Marton Date: 2021-06-25T11:49:26+02:00 New Revision: 0646e3625499b08a3ac9efd48396f3b463a19139 URL: https://github.com/llvm/llvm-project/commit/0646e3625499b08a3ac9efd48396f3b463a19139 DIFF: https://github.com/llvm/llvm-project/commit/0646e3625499b08a3ac9efd48396f3b463a19139.diff

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong marked 2 inline comments as done. martong added a comment. Valeriy, thanks for the assiduous and quick review! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1981 for (const SymbolRef : ClassMembers) { -SymbolRef SimplifiedMemberSym =

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD marked 4 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:301 + const OverloadedOperatorKind OOK = FD->getOverloadedOperator(); + if (!(OOK == OO_Equal || OOK == OO_ExclaimEqual || OOK ==

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, darwin. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=50525 AlignConsecutiveAssignments/Declarations

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

sberg added a comment. And, again for the record, with a build of LibreOffice with clang-cl (and `-Xclang -std=c++2b`) on Windows, at least against the C++ standard library from Visual Studio 2019 version 16.20.2, I ran into two issues in the standard library itself, when using `std::getline`

[PATCH] D104899: [clang][tests] Specify unwindlib in aix-ld tests

tbaeder created this revision. tbaeder added a reviewer: tstellar. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang can be configured with a different default unwindlib, for example gcc. In that case, `-lunwind` will not be

[PATCH] D104505: [HIP] Defer operator overloading errors

ro added a comment. This patch broke the Solaris/sparcv9 and Solaris/amd64 buildbots:

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/test/Analysis/constant-folding.c:330 +clang_analyzer_eval((c + d) == INT_MAX - 22); // expected-warning{{FALSE}} + } +} vsavchenko wrote: > manas wrote: > > vsavchenko wrote: > > > I don't see the cases where

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 354441. manas added a comment. Add tests for overflows on both ends Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files:

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/test/Analysis/constant-folding.c:264-266 + if (a == UINT_MAX && b == UINT_MAX) { +clang_analyzer_eval((a + b) == UINT_MAX - 1); // expected-warning{{TRUE}} + } We need a test with ranges and unsigned

[PATCH] D104898: [clang-repl] Allow passing in code as positional arguments.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, teemperor, aprantl, sgraenitz. v.g.vassilev requested review of this revision. Now we can do things like: clang-repl "int i = 1;" "int j = 2;". https://reviews.llvm.org/D104898 Files: clang/test/Interpreter/execute.cpp

<    1   2