[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

2021-07-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105001/new/ https://reviews.llvm.org/D105001

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

2021-07-19 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 359677. cor3ntin added a comment. Fix cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D106252: Implement P2092

2021-07-19 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 359676. cor3ntin added a comment. Fix cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 Files: clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D105926: [PowerPC] Extra test case for LDARX

2021-07-19 Thread Albion Fung via Phabricator via cfe-commits
Conanap added a comment. In D105926#2885291 , @teemperor wrote: > Sorry for raising an unrelated topic here, but I can't reach @Conanap > directly via the mail from the git commits: @Conanap could you please create > the git branches for your patches

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

2021-07-19 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 updated this revision to Diff 359704. MarcusJohnson91 added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. Few tweaks since last time, nothing big CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103426/new/

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

2021-07-19 Thread Justas Janickas via Phabricator via cfe-commits
Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:26 #ifdef CL20 // Accept explicitly pointer to generic address space in OpenCL v2.0. Anastasia wrote: > while we are at it, do you

[PATCH] D106255: [Clang][RISCV] Correct the alignment of stores generated by vlseg/vlsegff.

2021-07-19 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 359718. HsiangKai added a comment. Update vlsegff test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106255/new/ https://reviews.llvm.org/D106255 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

2021-07-19 Thread Jeremy Morse via Phabricator via cfe-commits
jmorse added a comment. This is going to be excellent for linux targets and similar, In D106084#2882970 , @probinson wrote: > + @jmorse who is better placed than I am to say whether this is what Sony > would prefer. Slightly trickier -- our debugger

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

2021-07-19 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 359703. HsiangKai added a comment. Correct the alignment of store. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103796/new/ https://reviews.llvm.org/D103796 Files:

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

2021-07-19 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, kerbowa, yaxunl, nhaehnle, jvesely. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires support of

[PATCH] D106252: Implement P2092

2021-07-19 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Simple requierements in requierement body shall not start with requires. A warning was already in place so we just turn this warning into an error.

[PATCH] D105926: [PowerPC] Extra test case for LDARX

2021-07-19 Thread Albion Fung via Phabricator via cfe-commits
Conanap updated this revision to Diff 359681. Conanap added a comment. Removed metadata, -O3 to generate the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://reviews.llvm.org/D105926 Files:

[PATCH] D106254: [OpenCL][NFC] Refactors conditional versioning

2021-07-19 Thread Justas Janickas via Phabricator via cfe-commits
Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Removes run line declaration -DCL20 and substitutes it with condition

[PATCH] D105703: [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via Phabricator via cfe-commits
fmayer updated this revision to Diff 359715. fmayer added a comment. style fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via Phabricator via cfe-commits
fmayer updated this revision to Diff 359716. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via Phabricator via cfe-commits
fmayer updated this revision to Diff 359714. fmayer marked 6 inline comments as done. fmayer added a comment. improve test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files:

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

2021-07-19 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. @dblaikie now that the dependent patch has been merged and (presumably) stuck, do you think we can proceed with this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619

[PATCH] D105703: [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via Phabricator via cfe-commits
fmayer updated this revision to Diff 359726. fmayer added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D106201: [clangd] Add tests covering existing header-guard behavior. NFC

2021-07-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. i mostly agree with the desired behaviours laid out by the tests, mentioned a coupe extra cases and wrinkly looking parts in comments. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:724 + + TU.Code = R"cpp( +#pragma once

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

2021-07-19 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 359694. balazske added a comment. Removed `Instance`, small rename, fix of warning text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104925/new/ https://reviews.llvm.org/D104925 Files:

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

2021-07-19 Thread Justas Janickas via Phabricator via cfe-commits
Topotuna updated this revision to Diff 359702. Topotuna added a comment. Separate NFC performed in D106254 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105987/new/ https://reviews.llvm.org/D105987 Files: clang/lib/Headers/opencl-c-base.h

[PATCH] D106152: [analyzer] Move test case to existing test file and remove duplicated test file.

2021-07-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 359710. ASDenysPetrov retitled this revision from "[analyzer] Remove test file as duplicated." to "[analyzer] Move test case to existing test file and remove duplicated test file.". ASDenysPetrov edited the summary of this revision. ASDenysPetrov added

[PATCH] D106227: Fix duplicate checks in clangd comments

2021-07-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106227/new/ https://reviews.llvm.org/D106227

[clang-tools-extra] 73e4b5c - [clang-tidy] Add 'readability-suspicious-call-argument' check

2021-07-19 Thread via cfe-commits
Author: Whisperity Date: 2021-07-19T10:18:09+02:00 New Revision: 73e4b5cfa8ea6dda3624e03beb60827db12bb3a3 URL: https://github.com/llvm/llvm-project/commit/73e4b5cfa8ea6dda3624e03beb60827db12bb3a3 DIFF: https://github.com/llvm/llvm-project/commit/73e4b5cfa8ea6dda3624e03beb60827db12bb3a3.diff

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

2021-07-19 Thread Whisperity via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73e4b5cfa8ea: [clang-tidy] Add

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

2021-07-19 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:34-35 +const char *Desc_StreamEof = "Stream already in EOF"; +const char *Desc_ResourceLeak = "Resource leak"; +

[PATCH] D106152: [analyzer] Remove test file as duplicated.

2021-07-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. In D106152#2885091 , @NoQ wrote: > I have no opinion here. There's nothing wrong with having more tests and they > don't look like exact duplicates of each other(?) In D106152#2885091

[PATCH] D106255: [Clang][RISCV] Correct the alignment of stores generated by vlseg/vlsegff.

2021-07-19 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones,

[PATCH] D105703: [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via Phabricator via cfe-commits
fmayer added inline comments. Comment at: llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll:27 + +attributes #0 = { mustprogress nofree nounwind uwtable willreturn "frame-pointer"="non-leaf" "min-legal-vector-width"="0" "no-trapping-math"="true"

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

2021-07-19 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1732-1734 +// __opencl_c_3d_image_writes feature. OpenCL C v3.0 API s4.2 - For devices +// that support OpenCL 3.0, cl_khr_3d_image_writes must be returned when and +// only when the optional

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

2021-07-19 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. balazske requested review of this

[clang] 807d501 - Revert "[hwasan] Use stack safety analysis."

2021-07-19 Thread Florian Mayer via cfe-commits
Author: Florian Mayer Date: 2021-07-19T12:08:32+01:00 New Revision: 807d50100c3c6cd5e6ec89d6ac1afddd0c3f7133 URL: https://github.com/llvm/llvm-project/commit/807d50100c3c6cd5e6ec89d6ac1afddd0c3f7133 DIFF: https://github.com/llvm/llvm-project/commit/807d50100c3c6cd5e6ec89d6ac1afddd0c3f7133.diff

[PATCH] D105703: [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via Phabricator via cfe-commits
fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Broke some postsubmit bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

2021-07-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 359768. ASDenysPetrov added a comment. Fixed a case mentioned by @chrish_ericsson_atx. Added the cases to the common bunch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104285/new/ https://reviews.llvm.org/D104285 Files:

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-19 Thread Victor Huang via Phabricator via cfe-commits
NeHuang accepted this revision. NeHuang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 ___ cfe-commits mailing list

[clang] 73840f9 - thread_local support for AIX

2021-07-19 Thread Jamie Schmeiser via cfe-commits
Author: Jamie Schmeiser Date: 2021-07-19T10:03:22-04:00 New Revision: 73840f9f81413f21d3c8fab0ed85917aca2b5d34 URL: https://github.com/llvm/llvm-project/commit/73840f9f81413f21d3c8fab0ed85917aca2b5d34 DIFF:

[PATCH] D104420: thread_local support for AIX

2021-07-19 Thread Jamie Schmeiser via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73840f9f8141: thread_local support for AIX (authored by jamieschmeiser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-19 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359783. quinnp added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-07-19 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a subscriber: ronlieb. JonChesterfield added a comment. @ronlieb bisected amdgpu crashing to this too, rocm 'veccopy' case tries to dereference 0. Might be the same failure mode as the above or a different one, the hsa error reporting is quite coarse grained. Suggest we

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

2021-07-19 Thread Justas Janickas via Phabricator via cfe-commits
Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: jeroen.dobbelaere, ldrumm, dexonsmith, dang, yaxunl. Topotuna requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. The commit

[PATCH] D106227: Fix duplicate checks in clangd comments

2021-07-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG195786d7c260: Fix duplicate checks in clangd comments (authored by 1ntEgr8, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 195786d - Fix duplicate checks in clangd comments

2021-07-19 Thread Kadir Cetinkaya via cfe-commits
Author: Elton Date: 2021-07-19T15:14:55+02:00 New Revision: 195786d7c2609f71e81156a09d3a20c98f7ba163 URL: https://github.com/llvm/llvm-project/commit/195786d7c2609f71e81156a09d3a20c98f7ba163 DIFF: https://github.com/llvm/llvm-project/commit/195786d7c2609f71e81156a09d3a20c98f7ba163.diff LOG:

[PATCH] D106201: [clangd] Add tests covering existing header-guard behavior. NFC

2021-07-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 359771. sammccall marked 5 inline comments as done. sammccall added a comment. Added cases to address comments, and added comments about semicolons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106201/new/

[PATCH] D106201: [clangd] Add tests covering existing header-guard behavior. NFC

2021-07-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:725 + TU.Code = R"cpp( +#pragma once +; kadircet wrote: > ``` > #include "self.h" > #pragma once > ``` > > might also be an interesting case (with

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

2021-07-19 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:395 MethodNameLoc), - MethodType, MethodTypeInfo, SC_None, + MethodType, MethodTypeInfo, SC_None, /*UsesFPIntrin*/ false,

[PATCH] D105703: [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12268fe14a1a: [hwasan] Use stack safety analysis. (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 12268fe - [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via cfe-commits
Author: Florian Mayer Date: 2021-07-19T11:54:44+01:00 New Revision: 12268fe14a1a65d4b62f0b6e5beab46ba8501ae7 URL: https://github.com/llvm/llvm-project/commit/12268fe14a1a65d4b62f0b6e5beab46ba8501ae7 DIFF: https://github.com/llvm/llvm-project/commit/12268fe14a1a65d4b62f0b6e5beab46ba8501ae7.diff

[PATCH] D99081: [clang-tidy] ensure run-clang-tidy reports children killed by signals

2021-07-19 Thread Ian Campbell via Phabricator via cfe-commits
ijc added a comment. Herald added a subscriber: cfe-commits. @sylvestre.ledru do I need to do anything more for this to get merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99081/new/ https://reviews.llvm.org/D99081

[PATCH] D105703: [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via Phabricator via cfe-commits
fmayer added a comment. I removed the stack-safety-analysis-asm.c test because I don't think it really adds anything and it caused problems. SGTY? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703

[PATCH] D99081: [clang-tidy] ensure run-clang-tidy reports children killed by signals

2021-07-19 Thread Ian Campbell via Phabricator via cfe-commits
ijc added a comment. @sylvestre.ledru yes please that would be great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99081/new/ https://reviews.llvm.org/D99081 ___ cfe-commits mailing list

[clang-tools-extra] f6ba035 - [clang-tidy] ensure run-clang-tidy reports children killed by signals

2021-07-19 Thread Sylvestre Ledru via cfe-commits
Author: Ian Campbell Date: 2021-07-19T14:18:26+02:00 New Revision: f6ba03584b3ce5dab45d8c1fe84e89d4d668574d URL: https://github.com/llvm/llvm-project/commit/f6ba03584b3ce5dab45d8c1fe84e89d4d668574d DIFF: https://github.com/llvm/llvm-project/commit/f6ba03584b3ce5dab45d8c1fe84e89d4d668574d.diff

[PATCH] D105493: [clang] Change set type used for SourceLocation.

2021-07-19 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. simon_tatham marked an inline comment as done. Closed by commit rGcef56d58dbbb: [clang] Change set type used for SourceLocation. (authored by simon_tatham). Changed prior to commit:

[clang] cef56d5 - [clang] Change set type used for SourceLocation.

2021-07-19 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2021-07-19T13:36:36+01:00 New Revision: cef56d58dbbb3bc993531c14af5e3edd2841029d URL: https://github.com/llvm/llvm-project/commit/cef56d58dbbb3bc993531c14af5e3edd2841029d DIFF: https://github.com/llvm/llvm-project/commit/cef56d58dbbb3bc993531c14af5e3edd2841029d.diff

[PATCH] D106227: Fix duplicate checks in clangd comments

2021-07-19 Thread Elton Leander Pinto via Phabricator via cfe-commits
1ntEgr8 added a comment. In D106227#2886547 , @kadircet wrote: > thanks! please let me know if I should land this for you (and provide an > email address for attributing the commit to) sure thing! you can attribute it to eltonp3...@gmail.com

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-19 Thread Amy Kwan via Phabricator via cfe-commits
amyk accepted this revision. amyk added a comment. My comments were addressed and I agree with the new indentation - LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

2021-07-19 Thread Lei Huang via Phabricator via cfe-commits
lei added inline comments. Comment at: llvm/test/CodeGen/builtins-ppc-xlcompat-move-tofrom-regs.ll:3 +; NOTE: Had to manually modify the last test case (mtmsr) to allow the +; NOTE: common check of mtmsr instead of 4 different check prefixes ; RUN: llc -verify-machineinstrs

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

2021-07-19 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161-162 +const StringRef RawFilename) { + llvm::SmallString<256> Filename; + llvm::sys::path::native(RawFilename, Filename); + dexonsmith

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

2021-07-19 Thread Amy Kwan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd5aa657a520: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src… (authored by amyk). Changed prior to commit:

[clang] dd5aa65 - [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

2021-07-19 Thread Amy Kwan via cfe-commits
Author: Amy Kwan Date: 2021-07-19T09:10:06-05:00 New Revision: dd5aa657a520adcff84bb6149dd20cd8a2c8c6c6 URL: https://github.com/llvm/llvm-project/commit/dd5aa657a520adcff84bb6149dd20cd8a2c8c6c6 DIFF: https://github.com/llvm/llvm-project/commit/dd5aa657a520adcff84bb6149dd20cd8a2c8c6c6.diff

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

2021-07-19 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov updated this revision to Diff 359734. azabaznov added a comment. Change diagnostic output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106260/new/ https://reviews.llvm.org/D106260 Files:

[PATCH] D105703: [hwasan] Use stack safety analysis.

2021-07-19 Thread Florian Mayer via Phabricator via cfe-commits
fmayer updated this revision to Diff 359749. fmayer added a comment. remove stack safety asm test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

2021-07-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. @chrish_ericsson_atx OK. I think I found the issue. Could you please check whether it works for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104285/new/ https://reviews.llvm.org/D104285 ___ cfe-commits

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

2021-07-19 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 359772. mibintc added a reviewer: zahiraam. mibintc added a comment. Respond to @aaron.ballman 's review, rebased & used clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/

[PATCH] D99081: [clang-tidy] ensure run-clang-tidy reports children killed by signals

2021-07-19 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. Oh, I missed your message. I can land it for you, ok? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99081/new/ https://reviews.llvm.org/D99081 ___ cfe-commits mailing

[PATCH] D99081: [clang-tidy] ensure run-clang-tidy reports children killed by signals

2021-07-19 Thread Sylvestre Ledru via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ba03584b3c: [clang-tidy] ensure run-clang-tidy reports children killed by signals (authored by ijc, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

2021-07-19 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104925/new/ https://reviews.llvm.org/D104925

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

2021-07-19 Thread Bradley Smith via Phabricator via cfe-commits
bsmith added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:505-506 + } else if (getContext().getTargetInfo().hasFeature("sve")) { +CurFn->addFnAttr( +llvm::Attribute::getWithVScaleRangeArgs(getLLVMContext(), 0, 16)); }

[PATCH] D106285: [Analyzer][solver] Fix inconsistent equivalence class data

2021-07-19 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added a reviewer: vsavchenko. Herald added subscribers: manas, steakhal, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[PATCH] D106074: [AIX] Emit unsupported 128-bit long double option for AIX

2021-07-19 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4845 + if (Arg *A = Args.getLastArg(options::OPT_mlong_double_128)) { +// AIX doesn't support 128-bit long double yet. +if (Triple.isOSAIX()) cebowleratibm

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-07-19 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104386/new/ https://reviews.llvm.org/D104386

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

2021-07-19 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. New .callgraph section layout LGTM. Please also address any further feedback from Fangrui. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106282: [PowerPC] Update builtins-ppc-altivec.c to be run under `-faltivec-src-compat=mixed`

2021-07-19 Thread Amy Kwan via Phabricator via cfe-commits
amyk created this revision. amyk added reviewers: PowerPC, nemanjai, stefanp. amyk added projects: LLVM, PowerPC, clang. Herald added subscribers: shchenz, kbarton. amyk requested review of this revision. This patch adds the `-faltivec-src-compat=mixed` option to the `builtins-ppc-altivec.c`

[PATCH] D105926: [PowerPC] Extra test case for LDARX

2021-07-19 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://reviews.llvm.org/D105926

[clang] 356300a - [NFC][PowerPC] Update builtins-ppc-altivec.c to be run under `-faltivec-src-compat=mixed`

2021-07-19 Thread Amy Kwan via cfe-commits
Author: Amy Kwan Date: 2021-07-19T11:20:21-05:00 New Revision: 356300a3510c48f1f446cbdf580294b577435589 URL: https://github.com/llvm/llvm-project/commit/356300a3510c48f1f446cbdf580294b577435589 DIFF: https://github.com/llvm/llvm-project/commit/356300a3510c48f1f446cbdf580294b577435589.diff

[PATCH] D106252: Implement P2092

2021-07-19 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 359824. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 Files: clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

2021-07-19 Thread Saurabh Jha via Phabricator via cfe-commits
SaurabhJha added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

2021-07-19 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161-162 +const StringRef RawFilename) { + llvm::SmallString<256> Filename; + llvm::sys::path::native(RawFilename, Filename); + jansvoboda11

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

2021-07-19 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. With the call to `llvm::sys::path::native` scoped only to `IgnoredFiles`, would this patch LGTY? Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161-162 +const StringRef RawFilename) { +

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-07-19 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis added a comment. Thanks for spotting. Test are auto-gened through update scripts so it should be easy to compare. I'll fix and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107

[clang] 77bb82d - [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

2021-07-19 Thread Hsiangkai Wang via cfe-commits
Author: Hsiangkai Wang Date: 2021-07-19T23:17:01+08:00 New Revision: 77bb82d068568a950f196e62beaa88fb08c57232 URL: https://github.com/llvm/llvm-project/commit/77bb82d068568a950f196e62beaa88fb08c57232 DIFF:

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

2021-07-19 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77bb82d06856: [Clang][RISCV] Support half-precision floating point for RVV intrinsics. (authored by HsiangKai). Changed prior to commit:

[PATCH] D106282: [PowerPC] Update builtins-ppc-altivec.c to be run under `-faltivec-src-compat=mixed`

2021-07-19 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Please don't forget to mark this as NFC in the title. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106282/new/

[PATCH] D106285: [Analyzer][solver] Fix inconsistent equivalence class data

2021-07-19 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 359813. martong added a comment. - Remove unnecessary comment (the API tells it all) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106285/new/ https://reviews.llvm.org/D106285 Files:

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

2021-07-19 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sure, sounds good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619

[PATCH] D106201: [clangd] Add tests covering existing header-guard behavior. NFC

2021-07-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:725 + TU.Code = R"cpp( +#pragma once +; sammccall wrote: > kadircet

[PATCH] D106203: [clangd] Propagate header-guarded flag from preamble to main AST

2021-07-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/Preamble.cpp:87 + +const SourceManager = CI.getSourceManager(); +const FileEntry *MainFE =

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

2021-07-19 Thread Paul Walker via Phabricator via cfe-commits
paulwalker-arm added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:505-506 + } else if (getContext().getTargetInfo().hasFeature("sve")) { +CurFn->addFnAttr( +llvm::Attribute::getWithVScaleRangeArgs(getLLVMContext(), 0, 16)); }

[PATCH] D106282: [NFC][PowerPC] Update builtins-ppc-altivec.c to be run under `-faltivec-src-compat=mixed`

2021-07-19 Thread Amy Kwan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG356300a3510c: [NFC][PowerPC] Update builtins-ppc-altivec.c to be run under `-faltivec-src… (authored by amyk). Repository: rG LLVM Github

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

2021-07-19 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D106084#2886659 , @jmorse wrote: > This is going to be excellent for linux targets and similar, > > In D106084#2882970 , @probinson > wrote: > >> + @jmorse who is better placed than

[PATCH] D106277: [SVE] Remove the interface for in favour of the IR attributes

2021-07-19 Thread Dylan Fleming via Phabricator via cfe-commits
DylanFleming-arm created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya,

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

2021-07-19 Thread Bradley Smith via Phabricator via cfe-commits
bsmith added a reviewer: paulwalker-arm. bsmith added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:505-506 + } else if (getContext().getTargetInfo().hasFeature("sve")) { +CurFn->addFnAttr( +

[PATCH] D106112: [clang-format] Break an unwrapped line at a K C parameter decl

2021-07-19 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. In D106112#2885604 , @owenpan wrote: > I just reviewed the differences between K C (circa 1978) and ANSI/ISO C > again and didn't see anything else that would impact clang-format, so a new >

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

2021-07-19 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Mostly minor comments, but it'll be good to have another look to make sure they're all addressed. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15101 +//

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

2021-07-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 359797. ASDenysPetrov added a comment. Fixed concern about index type being either ` int64_t` or `uint64_t`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104285/new/ https://reviews.llvm.org/D104285 Files: clang/include/clang/AST/Expr.h

[PATCH] D106074: [AIX] Emit unsupported 128-bit long double option for AIX

2021-07-19 Thread Chris Bowler via Phabricator via cfe-commits
cebowleratibm requested changes to this revision. cebowleratibm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4845 + if (Arg *A = Args.getLastArg(options::OPT_mlong_double_128)) { +// AIX doesn't

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

2021-07-19 Thread Kiran Chandramohan via Phabricator via cfe-commits
kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. Please update the commit message with information about changes in Clang tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

2021-07-19 Thread Victor Huang via Phabricator via cfe-commits
NeHuang marked 4 inline comments as done. NeHuang added a comment. Rebased the patch with ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 ___ cfe-commits

[clang] 6103fdf - [ifs][elfabi] Merge llvm-ifs/elfabi tools

2021-07-19 Thread Haowei Wu via cfe-commits
Author: Haowei Wu Date: 2021-07-19T11:23:19-07:00 New Revision: 6103fdfab4e2c051c070e2994db8b696fc440048 URL: https://github.com/llvm/llvm-project/commit/6103fdfab4e2c051c070e2994db8b696fc440048 DIFF: https://github.com/llvm/llvm-project/commit/6103fdfab4e2c051c070e2994db8b696fc440048.diff

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

2021-07-19 Thread Haowei Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6103fdfab4e2: [ifs][elfabi] Merge llvm-ifs/elfabi tools (authored by haowei). Changed prior to commit:

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

2021-07-19 Thread Jose Manuel Monsalve Diaz via Phabricator via cfe-commits
josemonsalve2 created this revision. josemonsalve2 added reviewers: ABataev, jdoerfert, JonChesterfield, ggeorgakoudis, jhuber6, baziotis, sstefan1, uenoku, tianshilei1992. Herald added subscribers: jfb, guansong, yaxunl. josemonsalve2 requested review of this revision. Herald added a project:

  1   2   >