[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360064. RedDocMD added a comment. Removed unnecessary white space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files:

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252 +static bool isStdFunctionCall(const CallEvent ) { + return Call.getDecl() && Call.getDecl() ->getDeclContext()->isStdNamespace(); +} vsavchenko wrote: > nit:

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:380-391 +if (BT == _UseAfterClose) + Message = "Stream closed here"; +else if (BT == _UseAfterOpenFailed) + Message = "Assuming opening the stream fails here"; +

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252 +static bool isStdFunctionCall(const CallEvent ) { + return Call.getDecl() && Call.getDecl() ->getDeclContext()->isStdNamespace(); +} nit: there's an extra

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252-255 + const auto *Decl = Call.getDecl(); + if (!Decl) +return false; + return Decl->getDeclContext()->isStdNamespace(); vsavchenko wrote: > Can we use a

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360061. RedDocMD added a comment. More refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser added a comment. In D106333#2889168 , @junparser wrote: > @efriedma with this patch, all of conversion between VLST and VLAT should > have same vector size(getElementType() * getElementCount()). The regression > in D105097

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Made some buildbot unhappy again. Sorry :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus added a comment. An ever so gentle ping :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105819/new/ https://reviews.llvm.org/D105819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 5f08219 - Revert "[hwasan] Use stack safety analysis."

Author: Florian Mayer Date: 2021-07-20T10:36:46+01:00 New Revision: 5f08219322456b867605e4a19003f58ee418758f URL: https://github.com/llvm/llvm-project/commit/5f08219322456b867605e4a19003f58ee418758f DIFF: https://github.com/llvm/llvm-project/commit/5f08219322456b867605e4a19003f58ee418758f.diff

[PATCH] D106064: [clang][deps] Normalize ignored filenames in minimizing file system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63fd109d3aa6: [clang][deps] Normalize ignored filenames in minimizing file system (authored by jansvoboda11). Changed prior to commit:

[clang] 63fd109 - [clang][deps] Normalize ignored filenames in minimizing file system

Author: Jan Svoboda Date: 2021-07-20T11:31:31+02:00 New Revision: 63fd109d3aa6db48e38e1c78f6084ad257f2c37d URL: https://github.com/llvm/llvm-project/commit/63fd109d3aa6db48e38e1c78f6084ad257f2c37d DIFF: https://github.com/llvm/llvm-project/commit/63fd109d3aa6db48e38e1c78f6084ad257f2c37d.diff

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna added inline comments. Comment at: clang/include/clang/Basic/LangStandards.def:187 Digraphs | HexFloat | OpenCL) +LANGSTANDARD_ALIAS_DEPR(openclcpp10, "clc++") Anastasia wrote: > I am not sure we should move it into the deprecated

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna updated this revision to Diff 360059. Topotuna added a comment. `clc++` made no longer deprecated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/LangStandards.def

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c63ed10b3b: [hwasan] Use stack safety analysis. (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e9c63ed - [hwasan] Use stack safety analysis.

Author: Florian Mayer Date: 2021-07-20T10:06:35+01:00 New Revision: e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118 URL: https://github.com/llvm/llvm-project/commit/e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118 DIFF: https://github.com/llvm/llvm-project/commit/e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118.diff

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 360055. pmatos added a comment. Rebase on top of main and add non-integral address spaces to emscripten OS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files:

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360054. fmayer marked an inline comment as done. fmayer added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files:

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252-255 + const auto *Decl = Call.getDecl(); + if (!Decl) +return false; + return Decl->getDeclContext()->isStdNamespace(); Can we use a one-liner that I

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

simon_tatham added a comment. I looked into this yesterday, and realised that I don't actually know what the use case //is// for emitting `!srcloc` metadata in an IR file. It's more or less ignored by llc, as far as I can see: if there's a late-breaking error in the inline asm string, you just

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360051. RedDocMD added a comment. Refactored out check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files:

[PATCH] D106349: [clang-format] respect AfterEnum for enums

m1cha added a comment. I just noticed that phabricator strips the commit message so here it is: There is some similar looking code in `TokenAnnotator.cpp` but given that I've never worked on clang-format before I don't know what the purpose of that code is and how it's related to

[PATCH] D106349: [clang-format] respect AfterEnum for enums

m1cha created this revision. m1cha added a reviewer: MyDeveloperDay. m1cha requested review of this revision. Herald added a project: clang. See the commit message for more details. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106349 Files:

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko added a comment. Also, I tested this fix on a set of open-source projects and I don't see any problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296

[PATCH] D106285: [Analyzer][solver] Fix inconsistent equivalence class data

vsavchenko added a comment. Ah, I see now! I think we could've put together a somewhat easier test knowing what's wrong, but it's not important at all. Thanks for addressing this issue! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106285/new/

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

vsavchenko added a comment. In D106136#2889610 , @martong wrote: > In D106136#2883707 , @vsavchenko > wrote: > >> In D106136#2883100 , @martong >> wrote: >> >>> Thanks

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:254-257 + const auto *Decl = Call.getDecl(); + if (!Decl) +return false; + if (!Decl->getDeclContext()->isStdNamespace()) I think you can have a separate

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. D105221 so LGTM too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/

[PATCH] D103873: [Clang][RISCV] Implement vsoxseg and vsuxseg.

HsiangKai updated this revision to Diff 360042. HsiangKai added a comment. Remove RV32 test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103873/new/ https://reviews.llvm.org/D103873 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-bits'.

khchen created this revision. khchen added reviewers: jrtc27, MaskRay, kito-cheng. Herald added subscribers: vkmr, frasercrmck, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

martong abandoned this revision. martong added a comment. In D106136#2883707 , @vsavchenko wrote: > In D106136#2883100 , @martong wrote: > >> Thanks for taking your time to take a look. And I accept your

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added a comment. Would this test do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360027. RedDocMD added a comment. Added a simple test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files:

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

HsiangKai updated this revision to Diff 360026. HsiangKai added a comment. Remove RV32 test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103809/new/ https://reviews.llvm.org/D103809 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:275 +return false; + const auto *Decl = Call.getDecl(); + if (!Decl) xazax.hun wrote: > Can we model a function call without a declaration? I wonder if we

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

HsiangKai updated this revision to Diff 360024. HsiangKai added a comment. Remove RV32 test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103796/new/ https://reviews.llvm.org/D103796 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

lbenes added a comment. LGTM. No more test failures or build errors. And the libreoffice .configure error has been resolved now too. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106119/new/ https://reviews.llvm.org/D106119

[PATCH] D106344: [PowerPC] Correct behavior of __compare_and_swap

lkail created this revision. lkail added reviewers: jsji, nemanjai, w2yehia, shchenz, PowerPC. Herald added subscribers: jfb, kbarton. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. XL's `__compare_and_swap` has a weird behavior

<    1   2   3