[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 363196. gandhi21299 added a comment. refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D106349: [clang-format] respect AfterEnum for enums

m1cha added a comment. Well it's pretty much exactly the same except for the change in `ShouldBreakBeforeBrace`. Somebody with more knowledge about clang-format than me should try to figure out why it's not needed. If it's actually not needed than this change does not need to be merged.

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. In D106349#2914448 , @m1cha wrote: > I don't have commit access. How does that even work? The documentation is > very scarce about this but for security reasons I'd expect there to be a very > limited set of people

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

dblaikie added a comment. Just because I was curious. Some grep/seding. Nothing definitive: 10188 %clang 1289 %clang_analyze_cc1 32253 %clang_cc1 22 clang-check 503 %clang_cl 59 clang-offload-bundler 2 clang-offload-wrapper 69 clang-rename 2 clang-repl

[PATCH] D106349: [clang-format] respect AfterEnum for enums

lunasorcery added a comment. Copying over the comment I left on D99840 explaining it - my existing change only works because it gets bailed out by further code in TokenAnnotator.cpp. I think your change still is valuable since it's more correct. > Looking at

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added inline comments. Comment at: llvm/test/Transforms/InstCombine/fpclass.ll:29 + ret <2 x i1> %t +} + RKSimon wrote: > You probably need some negative tests (no flags, ninf instead of nnan etc.)? Added few such tests. Repository: rG LLVM Github

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

mstorsjo added a comment. FYI, 13.0.0 rc1 is getting tagged on Monday, so it’d be good to have the branch in a usable state by then, either with all fixes we currently have in main, or reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 363159. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. addressed reviewers' feedback: - changed a builtin name, - corrected tests, - minor formatting nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1532ed27582: [InstrProfiling] Make CountersPtr in __profd_ relative (authored by MaskRay). Changed prior to commit:

[clang] 2a28478 - [ConstantFold] Get rid of special cases for sizeof etc.

Author: Eli Friedman Date: 2021-07-31T13:20:47-07:00 New Revision: 2a2847823f0d13188c43ebdd0baf42a95df750c7 URL: https://github.com/llvm/llvm-project/commit/2a2847823f0d13188c43ebdd0baf42a95df750c7 DIFF: https://github.com/llvm/llvm-project/commit/2a2847823f0d13188c43ebdd0baf42a95df750c7.diff

[PATCH] D107116: [ConstantFold] Get rid of special cases for sizeof etc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a2847823f0d: [ConstantFold] Get rid of special cases for sizeof etc. (authored by efriedma). Herald added a project: clang. Herald added a

[PATCH] D104854: Introduce intrinsic llvm.isnan

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. (Since there have been a bunch of reviewers involved, please give a few days before you merge.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

SeTSeR added a comment. In D94639#2917445 , @rnk wrote: > In D94639#2917340 , @SeTSeR wrote: > >> Hello! As far as I understand, Clang does not preserve info about namespace >> for functions declared in namespaces

[PATCH] D107116: [ConstantFold] Get rid of special cases for sizeof etc.

mstorsjo added a comment. Thanks! Do you think this would be suitable for the 13.x release branch too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107116/new/ https://reviews.llvm.org/D107116 ___

[clang] 8b33839 - [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

Author: Hsiangkai Wang Date: 2021-08-01T05:58:17+08:00 New Revision: 8b33839f010fe780fdaf68160be7c45d07fdfcad URL: https://github.com/llvm/llvm-project/commit/8b33839f010fe780fdaf68160be7c45d07fdfcad DIFF:

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

Meinersbur updated this revision to Diff 363334. Meinersbur added a comment. - Use %clang_cc1 because %clang adds options according to it triple, i.e. -fms-extensions is added implicitly for Windows targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

mstorsjo created this revision. mstorsjo added reviewers: v.g.vassilev, teemperor. Herald added a subscriber: mgorny. mstorsjo requested review of this revision. Herald added a project: clang. Use `clang_target_link_libraries` to avoid duplicate libraries when the same symbol is provided both by

[clang] 6eb2ffb - Fix a couple regression tests I missed updating in 2a284782

Author: Eli Friedman Date: 2021-07-31T13:41:15-07:00 New Revision: 6eb2ffbaeb56c8b08ad17c823e1699b964e10b8b URL: https://github.com/llvm/llvm-project/commit/6eb2ffbaeb56c8b08ad17c823e1699b964e10b8b DIFF: https://github.com/llvm/llvm-project/commit/6eb2ffbaeb56c8b08ad17c823e1699b964e10b8b.diff

[PATCH] D107116: [ConstantFold] Get rid of special cases for sizeof etc.

efriedma added a comment. Just committed 6eb2ffba to fix a couple regression tests. Seems low-risk to cherry-pick to 13.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107139: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b33839f010f: [RISCV] Rename vector inline constraint from v to vr and vm in IR. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

protze.joachim added a comment. Any chance that we get this into llvm/13? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353 ___ cfe-commits mailing list

[clang] 29b263a - [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'

Author: Alexandros Lamprineas Date: 2021-07-31T09:51:28+01:00 New Revision: 29b263a34f1afbae9c95bf48eab7e8aac8132a80 URL: https://github.com/llvm/llvm-project/commit/29b263a34f1afbae9c95bf48eab7e8aac8132a80 DIFF:

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29b263a34f1a: [Clang][AArch64] Inline assembly support for the ACLE type data512_t (authored by labrinea). Repository: rG LLVM Github Monorepo

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 363289. v.g.vassilev added a comment. Try to fix the issues reported by the pre-merge-checks. clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: