[PATCH] D107939: [clang][Arm] Fix the default floating point ABI for 'armv7-pc-win32-macho'

sarahpurohit accepted this revision. sarahpurohit added a comment. I do not have commit access. Can someone pull this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107939/new/ https://reviews.llvm.org/D107939

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AlternativeTokensCheck.cpp:85 + assert(First != nullptr); + if (std::isalpha(*First) || Loc.isMacroID()) +return; aaron.ballman wrote: > `isLetter()`? (or potentially

[PATCH] D107961: [clang-format] Distinguish K C function definition and attribute

owenpan updated this revision to Diff 366176. owenpan added a comment. Added keywords `register`, `struct`, and `union` back. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107961/new/ https://reviews.llvm.org/D107961 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens in declarations

cjdb added a comment. In D107292#2939521 , @aaron.ballman wrote: > In D107292#2923261 , @cjdb wrote: > >> Patch 2: expressions >> >> xor {} >> bitand x // warning will suggest std::addressof in C++ land >> and

[clang] ee620b1 - [clang][Arm] Fix the default floating point ABI for

Author: Sarah Purohit Date: 2021-08-12T21:46:30-07:00 New Revision: ee620b1743bc524ce4b84d8113cb5b43ddcf3b59 URL: https://github.com/llvm/llvm-project/commit/ee620b1743bc524ce4b84d8113cb5b43ddcf3b59 DIFF: https://github.com/llvm/llvm-project/commit/ee620b1743bc524ce4b84d8113cb5b43ddcf3b59.diff

[PATCH] D107939: [clang][Arm] Fix the default floating point ABI for 'armv7-pc-win32-macho'

This revision was automatically updated to reflect the committed changes. Closed by commit rGee620b1743bc: [clang][Arm] Fix the default floating point ABI for (authored by sarahpurohit, committed by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108013: [NFC] Rename AttributeList::has/getAttribute() -> has/getAttributeImpl()

aeubanks created this revision. Herald added subscribers: ormris, foad, dexonsmith, lxfind, okura, jdoerfert, kuter, kerbowa, pengfei, Jim, hiraditya, jgravelle-google, sbc100, nhaehnle, jvesely, dylanmckay, dschuff, arsenm, jholewinski. aeubanks added reviewers: rnk, efriedma. aeubanks

[PATCH] D107939: [clang][Arm] Fix the default floating point ABI for 'armv7-pc-win32-macho'

sarahpurohit updated this revision to Diff 366179. sarahpurohit added a comment. Resolved syntax error with braces. No functional change otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107939/new/ https://reviews.llvm.org/D107939 Files:

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:953 +#define _mm512_cvt_roundpd_ph(A, R) \ + (__m128h) __builtin_ia32_vcvtpd2ph512_mask( \ + (__v8df)(A),

[PATCH] D107961: [clang-format] Distinguish K C function definition and attribute

owenpan created this revision. owenpan added reviewers: krasimir, MyDeveloperDay. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up on https://reviews.llvm.org/D107950 which

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:4838 { X86::VMULSDZrr_Intk,X86::VMULSDZrm_Intk, TB_NO_REVERSE }, + { X86::VMULSHZrr_Intk,X86::VMULSHZrm_Intk, TB_NO_REVERSE }, {

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei updated this revision to Diff 365995. pengfei marked an inline comment as done. pengfei added a comment. Address Yuanke's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105264/new/ https://reviews.llvm.org/D105264 Files:

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 added a comment. In D107682#2936040 , @MaskRay wrote: > Seems a new RUN line is needed. If having too many mock trees are > inconvenient, consider `clang/unittests/Driver/ToolChainTest.cpp` I am not familiar with the way in

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. In D106137#2941616 , @DavidSpickett wrote: > This has broken cmake config on the out of tree flang bot: > https://lab.llvm.org/buildbot/#/builders/175/builds/2026 > > (with perhaps the least helpful cmake error I've ever

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov updated this revision to Diff 366009. ASDenysPetrov added a comment. Changed according to comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104285/new/ https://reviews.llvm.org/D104285 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Type.h

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

erichkeane added a comment. In D107349#2941257 , @mehdi_amini wrote: > Revert to unbreak bots (like this one : > https://lab.llvm.org/buildbot/#/builders/13/builds/10930 ) Looks like this should be a pretty trivial test update at least. Repository:

[PATCH] D107960: [clang][analyzer] Make ReturnPtrRange checker warn at negative index.

balazske created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, arphaman, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. balazske requested review of

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

LuoYuanke added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:1748 + +#define _mm_cvt_roundsh_i32(A, R) \ + (int)__builtin_ia32_vcvtsh2si32((__v8hf)(A), (int)(R)) Does it also return i32 in

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 365996. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree_2/opt/local/avr/include/.keep

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman closed this revision. aaron.ballman added a comment. In D97753#2941277 , @0x8000- wrote: > The diff was generated with format-patch, so can be applied with "git am". > > The envelope: > >> commit d98d336b452876cfbc32ad1b76319912c45b646b

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

This revision was automatically updated to reflect the committed changes. Closed by commit rGccb5b9bbfb5c: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for… (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107960: [clang][analyzer] Make ReturnPtrRange checker warn at negative index.

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. If `assumeInBound()` behaves unexpectedly, we should probably fix that instead. This change would workaround the issue, instead of fixing it. By fixing the root cause all users

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

This revision was automatically updated to reflect the committed changes. Closed by commit rG99e00663d4cd: [PowerPC] Fix return address computation for __builtin_return_address (authored by NeHuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] d2c5cbc - Add a check for enforcing minimum length for variable names

Author: Florin Iucha Date: 2021-08-12T11:31:26-04:00 New Revision: d2c5cbc3a856c2f8bbda05540fa761bb94ba32f6 URL: https://github.com/llvm/llvm-project/commit/d2c5cbc3a856c2f8bbda05540fa761bb94ba32f6 DIFF: https://github.com/llvm/llvm-project/commit/d2c5cbc3a856c2f8bbda05540fa761bb94ba32f6.diff

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

DavidSpickett added a comment. This has broken cmake config on the out of tree flang bot: https://lab.llvm.org/buildbot/#/builders/175/builds/2026 (with perhaps the least helpful cmake error I've ever seen) Not personally familiar with what "out of tree" means for flang but you should be able

[PATCH] D107946: [X86] Reverse *_set_ph and *_setr_ph 's set order.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c1468854d70: [X86] Reverse *_set_ph and *_setr_ph s set order. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 6c14688 - [X86] Reverse *_set_ph and *_setr_ph 's set order.

Author: Freddy Ye Date: 2021-08-12T16:27:04+08:00 New Revision: 6c1468854d70091ec9b53f97ff33e4a09d95443a URL: https://github.com/llvm/llvm-project/commit/6c1468854d70091ec9b53f97ff33e4a09d95443a DIFF: https://github.com/llvm/llvm-project/commit/6c1468854d70091ec9b53f97ff33e4a09d95443a.diff

[clang-tools-extra] 39bbbc2 - [clang-tidy][docs] Remove the entry about 'cppcoreguidelines-init-variables' from the release notes

Author: Whisperity Date: 2021-08-12T10:41:46+02:00 New Revision: 39bbbc2c2a2442f1a612fac27efc8a5cb77fe61a URL: https://github.com/llvm/llvm-project/commit/39bbbc2c2a2442f1a612fac27efc8a5cb77fe61a DIFF: https://github.com/llvm/llvm-project/commit/39bbbc2c2a2442f1a612fac27efc8a5cb77fe61a.diff

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:41 +static const RISCVSupportedExtensionInfo SupportedExtensionInfos[] = { +{"i", RISCVExtensionVersion{2, 0}}, {"e", RISCVExtensionVersion{1, 9}}, +{"m", RISCVExtensionVersion{2, 0}}, {"a",

[clang] 696ad3c - [OpenCL] Tidy up preserve_vec3 test

Author: Sven van Haastregt Date: 2021-08-12T14:51:20+01:00 New Revision: 696ad3c491a249f585ba79e0ecf80c5dc003f8f3 URL: https://github.com/llvm/llvm-project/commit/696ad3c491a249f585ba79e0ecf80c5dc003f8f3 DIFF:

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Quuxplusone added a comment. > I suggest that this patch be divided into two patches. In the current patch, > fix the wrong AutoFix. What the current check should look like is left in the > second patch for discussion. @Sockke do you mind simplifying this patch and > only achieving the first

[PATCH] D107963: [OpenCL] Fix as_type(vec3) invalid store creation

svenvh created this revision. svenvh added reviewers: Anastasia, jaykang10. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. With `-fpreserve-vec3-type` enabled, a cast was not created when

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 added a comment. The file/directory structure in basic_avr_tree_2/opt/local is the same as mhjacobson's machine. Here's what my directory tree looks like. My gcc install consists of: /opt/local/bin/avr-gcc-10.3.0 /opt/local/lib/gcc/avr/10.3.0/libgcc.a

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___ cfe-commits

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

DylanFleming-arm updated this revision to Diff 366001. DylanFleming-arm added a comment. Added checks for MaxVScale > 0 Changed getMaxNumElemenets() to take Function* instead of Instruction* Fixed clang-tidy warning I haven't included a test for vscale_range(2, 0) here, as one was added in the

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits

[PATCH] D107961: [clang-format] Distinguish K C function definition and attribute

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:17 #include "FormatToken.h" -#include "clang/Basic/TokenKinds.h" #include "llvm/ADT/STLExtras.h" Why is this not needed anymore? Repository: rG LLVM Github

[clang] ccb5b9b - [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

Author: Hongtao Yu Date: 2021-08-12T08:52:49-07:00 New Revision: ccb5b9bbfb5cef1aa2982481894f30c8f81d5253 URL: https://github.com/llvm/llvm-project/commit/ccb5b9bbfb5cef1aa2982481894f30c8f81d5253 DIFF: https://github.com/llvm/llvm-project/commit/ccb5b9bbfb5cef1aa2982481894f30c8f81d5253.diff

[clang-tools-extra] a49ca19 - Speculatively fix the build bots.

Author: Aaron Ballman Date: 2021-08-12T11:56:17-04:00 New Revision: a49ca198bad91b7696b54b3ca65585b92305b386 URL: https://github.com/llvm/llvm-project/commit/a49ca198bad91b7696b54b3ca65585b92305b386 DIFF: https://github.com/llvm/llvm-project/commit/a49ca198bad91b7696b54b3ca65585b92305b386.diff

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

aaron.ballman added inline comments. Comment at: clang/unittests/AST/AttrTest.cpp:19 +TEST(Attr, Doc) { + EXPECT_THAT(Attr::getDocumentation(attr::Used), + testing::HasSubstr("The compiler must emit the definition even " It seems this is failing

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365802. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365855. gandhi21299 added a comment. - eliminated unsafe hardware remarks in SIISelLowering.cpp - updated cas loop remark and corresponding tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365859. gandhi21299 added a comment. removed AMDGPU check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files:

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added a comment. In D106891#2940411 , @gandhi21299 wrote: > - eliminated unsafe hardware remarks in SIISelLowering.cpp Most of this patch is not needed now. You do not need to pass ORE to targets, it is a part of the next patch.

[PATCH] D106614: [Clang] add btf_tag attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106614/new/ https://reviews.llvm.org/D106614

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added a comment. You also need to retitle it now, it is not about AMDGPU and not about FP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:629 + Remark << "A compare and swap loop was generated for an atomic " +"operation " +"at " Need to name the operation.

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. @rsmith Can you please check is this a correct way to add headers known to preprocessor? (Lines 173-191) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___ cfe-commits

[clang] 4593492 - [clang-format] improve distinction of K function definitions vs attributes

Author: Krasimir Georgiev Date: 2021-08-12T10:29:06+02:00 New Revision: 45934922fa88b7542c8bcd86889d062fb78efdda URL: https://github.com/llvm/llvm-project/commit/45934922fa88b7542c8bcd86889d062fb78efdda DIFF:

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

pdhaliwal created this revision. pdhaliwal added reviewers: ronlieb, JonChesterfield. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. I see, thank you very much for the explanation! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:410 +if (Completion.Deprecated) { + Completion.Deprecated

[clang] 5ed9e5c - [clang] [MinGW] Consider the per-target libc++ include directory too

Author: Martin Storsjö Date: 2021-08-12T13:27:09+03:00 New Revision: 5ed9e5c2c0ee9a77ed4a2a5bd817b03acf78fbac URL: https://github.com/llvm/llvm-project/commit/5ed9e5c2c0ee9a77ed4a2a5bd817b03acf78fbac DIFF:

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman added a comment. In D97753#2940414 , @0x8000- wrote: > @aaron.ballman - thank you for the review; please submit on my behalf. Happy to do so, which name and email address would you like me to use for patch attribution? CHANGES SINCE

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:2382-2385 +def fopenmp_extensions : Flag<["-"], "fopenmp-extensions">, Group, + Flags<[CC1Option, NoArgumentUnused]>; +def fno_openmp_extensions : Flag<["-"],

[PATCH] D107950: [clang-format] improve distinction of K function definitions vs attributes

owenpan added a comment. In D107950#2941015 , @MyDeveloperDay wrote: > I personally think tok::identifier tends to be just too general However, you can't avoid it as it's used for user-defined types: typedef unsigned char byte; byte *f(a)

[PATCH] D107958: [clang-format] NFC update the ClangFormatStyleOption.rst following previous change

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, lunasorcery. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. clang/docs/tool/dump_format_style.py was not run as part of D99840:

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke marked 8 inline comments as done. Sockke added a comment. In D107450#2938824 , @MTC wrote: > I think we're a bit off track, and @Sockke wants to accomplish more than one > goal in the same patch. I have summarized what we are currently

[PATCH] D107893: [clang] [MinGW] Consider the per-target libc++ include directory too

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ed9e5c2c0ee: [clang] [MinGW] Consider the per-target libc++ include directory too (authored by mstorsjo). Changed prior to commit:

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107952/new/ https://reviews.llvm.org/D107952

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Added modules for headers known to HeadersSearch, including textual ones. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___ cfe-commits mailing list

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- added a comment. The diff was generated with format-patch, so can be applied with "git am". The envelope: > commit d98d336b452876cfbc32ad1b76319912c45b646b (HEAD -> > readability-variable-name-length-main) > Author: Florin Iucha > Date: Mon Mar 1 00:57:01 2021 -0500 > > Add a

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 365941. kito-cheng added a comment. Changes: - Rename class, strip the `Info`: - `RISCVSupportedExtensionInfo` -> `RISCVSupportedExtension` - Rename variables: - `SupportedExtensionInfos` -> `SupportedExtensions` -

[clang] a1ef81d - [Matrix] Overload stride arg in matrix.columnwise.load/store.

Author: Florian Hahn Date: 2021-08-12T10:45:25+01:00 New Revision: a1ef81de35a4bac6d3b22e9d7186d880124d7a55 URL: https://github.com/llvm/llvm-project/commit/a1ef81de35a4bac6d3b22e9d7186d880124d7a55 DIFF: https://github.com/llvm/llvm-project/commit/a1ef81de35a4bac6d3b22e9d7186d880124d7a55.diff

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1ef81de35a4: [Matrix] Overload stride arg in matrix.columnwise.load/store. (authored by fhahn). Changed prior to commit:

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn updated this revision to Diff 365959. fhahn added a comment. rebased after latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102478/new/ https://reviews.llvm.org/D102478 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

JonChesterfield added a comment. This is semantically different to using mlink-builtin-bitcode with clang. The former internalizes all the symbols after they are introduced, using llvm-link does not. I'm not immediately sure whether that is a problem - the symbols in rocm device libs should

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

pdhaliwal updated this revision to Diff 365965. pdhaliwal added a comment. Remove redundant test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107952/new/ https://reviews.llvm.org/D107952 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 365969. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Serialization/ASTWriter.cpp

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 365968. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Serialization/ASTWriter.h

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

akuegel added a comment. It seems this patch caused a test failure in MLIR: test/Target/LLVMIR/llvm-intrinsics.mlir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107349/new/ https://reviews.llvm.org/D107349

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

mehdi_amini added a comment. Revert to unbreak bots (like this one : https://lab.llvm.org/buildbot/#/builders/13/builds/10930 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107349/new/ https://reviews.llvm.org/D107349

[clang] 28c0479 - Revert "[Matrix] Overload stride arg in matrix.columnwise.load/store."

Author: Mehdi Amini Date: 2021-08-12T11:57:19Z New Revision: 28c04794df74ad3c38155a244729d1f8d57b9400 URL: https://github.com/llvm/llvm-project/commit/28c04794df74ad3c38155a244729d1f8d57b9400 DIFF: https://github.com/llvm/llvm-project/commit/28c04794df74ad3c38155a244729d1f8d57b9400.diff LOG:

[PATCH] D107950: [clang-format] improve distinction of K function definitions vs attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG45934922fa88: [clang-format] improve distinction of KR function definitions vs attributes (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

fhahn added a comment. In D107349#2922208 , @erichkeane wrote: > This looks fine to me, and seems to fix my problem, thanks! I didn't spot > anything obvious,and proof-read the LangRef and think it is all fine, but am > not really the expert here, so

[clang] f52fc59 - [flang][driver] Add support for Frontend Plugins

Author: Stuart Ellis Date: 2021-08-12T11:42:16+01:00 New Revision: f52fc591fa34a8c85577108358b3b36c42b6d364 URL: https://github.com/llvm/llvm-project/commit/f52fc591fa34a8c85577108358b3b36c42b6d364 DIFF: https://github.com/llvm/llvm-project/commit/f52fc591fa34a8c85577108358b3b36c42b6d364.diff

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf52fc591fa34: [flang][driver] Add support for Frontend Plugins (authored by stuartellis, committed by awarzynski). Repository: rG LLVM Github

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

pdhaliwal added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain.c:80 +// CHECK-LIB-DEVICE:

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107641/new/ https://reviews.llvm.org/D107641 ___ cfe-commits

[PATCH] D107095: Implement #pragma clang header_unsafe

aaron.ballman added a comment. In D107095#2940638 , @beanz wrote: > +@lebedev.ri > > @aaron.ballman thank you for all the feedback and support! > > I'm not really sure where to go on the naming. I'm not attached to > `header_unsafe`, and totally

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 marked 2 inline comments as done. gandhi21299 added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631 +"at " + << (AI->getSyncScopeID() ? "system" : "single thread") + << " memory scope");

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield created this revision. JonChesterfield added reviewers: arsenm, jdoerfert. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a project: clang. Fixes miscompile of calls

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:64 + return OMPC_MAP_MODIFIER_unknown; +if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold) return OMPC_MAP_MODIFIER_unknown; ABataev wrote: > I would

[PATCH] D106738: [RISCV] Use getNaturalPointeeTypeAlignment to get alignment for stores created for vector builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6171f84942ce: [RISCV] Use getNaturalPointeeTypeAlignment to get alignment for stores created… (authored by craig.topper). Repository: rG LLVM

[clang] 6171f84 - [RISCV] Use getNaturalPointeeTypeAlignment to get alignment for stores created for vector builtins.

Author: Craig Topper Date: 2021-08-12T10:05:27-07:00 New Revision: 6171f84942ce2136b464ac0e8e620c6908f64cc6 URL: https://github.com/llvm/llvm-project/commit/6171f84942ce2136b464ac0e8e620c6908f64cc6 DIFF: https://github.com/llvm/llvm-project/commit/6171f84942ce2136b464ac0e8e620c6908f64cc6.diff

[clang] f66ba5f - [Sema] Fix -Wparentheses warning from gcc. NFC

Author: Craig Topper Date: 2021-08-12T10:05:27-07:00 New Revision: f66ba5fcef19ff03532d993ac4af1362a89b833f URL: https://github.com/llvm/llvm-project/commit/f66ba5fcef19ff03532d993ac4af1362a89b833f DIFF: https://github.com/llvm/llvm-project/commit/f66ba5fcef19ff03532d993ac4af1362a89b833f.diff

[clang] f999312 - Recommit "[Matrix] Overload stride arg in matrix.columnwise.load/store."

Author: Florian Hahn Date: 2021-08-12T18:31:57+01:00 New Revision: f999312872b811b550533640b92ecb234cf5c642 URL: https://github.com/llvm/llvm-project/commit/f999312872b811b550533640b92ecb234cf5c642 DIFF: https://github.com/llvm/llvm-project/commit/f999312872b811b550533640b92ecb234cf5c642.diff

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 366050. nickdesaulniers marked 4 inline comments as done. nickdesaulniers added a comment. - combine c++ w/ c test - use -verify= rather than -D - remove REQUIRES - go back to string comparison Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:964-965 +bool match = +(EA->isError() && NewAttrSpellingIndex < ErrorAttr::GNU_warning) || +(EA->isWarning() && NewAttrSpellingIndex >= ErrorAttr::GNU_warning); +if

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield added reviewers: ye-luo, yaxunl. JonChesterfield added a subscriber: ye-luo. JonChesterfield added a comment. @ye-luo this fixes the modf and sincos test cases from https://github.com/ye-luo/openmp-target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366014. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631 +"at " + << (AI->getSyncScopeID() ? "system" : "single thread") + << " memory scope"); gandhi21299 wrote: > rampitec wrote:

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631 +"at " + << (AI->getSyncScopeID() ? "system" : "single thread") + << " memory scope"); rampitec wrote: > gandhi21299

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Assuming this causes us to generate an `alloc as(5)` for `__tmp`, LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107971/new/

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield added a comment. In D107971#2941666 , @jdoerfert wrote: > Assuming this causes us to generate an `alloc as(5)` for `__tmp`, LG Yes, with the running example and this patch we get the perfect: %__tmp = alloca double, align 8,

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield added a comment. Failed a CI job that builds an openmp test in an environment without omp.h, will revert. Thoughts on fixing? Putting the omp allocator definition in this header is likely to collide with a real omp.h. Fairly clean fix is to move the definitions into the

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:64 + return OMPC_MAP_MODIFIER_unknown; +if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold) return OMPC_MAP_MODIFIER_unknown; ABataev wrote: > jdenny

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:64 + return OMPC_MAP_MODIFIER_unknown; +if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold) return OMPC_MAP_MODIFIER_unknown; jdenny wrote: > ABataev

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631 +"at " + << (AI->getSyncScopeID() ? "system" : "single thread") + << " memory scope"); gandhi21299 wrote: > rampitec wrote:

[clang] b611354 - [openmp] Annotate tmp variables with omp_thread_mem_alloc

Author: Jon Chesterfield Date: 2021-08-12T17:30:22+01:00 New Revision: b6113548c9217fb8a6d0e9ac5bef5584c1aa614d URL: https://github.com/llvm/llvm-project/commit/b6113548c9217fb8a6d0e9ac5bef5584c1aa614d DIFF:

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6113548c921: [openmp] Annotate tmp variables with omp_thread_mem_alloc (authored by JonChesterfield). Repository: rG LLVM Github Monorepo

  1   2   3   >