[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens in declarations

cjdb added a comment. In D107292#2939521 , @aaron.ballman wrote: > In D107292#2923261 , @cjdb wrote: > >> Patch 2: expressions >> >> xor {} >> bitand x // warning will suggest std::addressof in C++ land >> and

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AlternativeTokensCheck.cpp:85 + assert(First != nullptr); + if (std::isalpha(*First) || Loc.isMacroID()) +return; aaron.ballman wrote: > `isLetter()`? (or potentially

[PATCH] D108013: [NFC] Rename AttributeList::has/getAttribute() -> has/getAttributeImpl()

aeubanks created this revision. Herald added subscribers: ormris, foad, dexonsmith, lxfind, okura, jdoerfert, kuter, kerbowa, pengfei, Jim, hiraditya, jgravelle-google, sbc100, nhaehnle, jvesely, dylanmckay, dschuff, arsenm, jholewinski. aeubanks added reviewers: rnk, efriedma. aeubanks

[PATCH] D107939: [clang][Arm] Fix the default floating point ABI for 'armv7-pc-win32-macho'

This revision was automatically updated to reflect the committed changes. Closed by commit rGee620b1743bc: [clang][Arm] Fix the default floating point ABI for (authored by sarahpurohit, committed by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ee620b1 - [clang][Arm] Fix the default floating point ABI for

Author: Sarah Purohit Date: 2021-08-12T21:46:30-07:00 New Revision: ee620b1743bc524ce4b84d8113cb5b43ddcf3b59 URL: https://github.com/llvm/llvm-project/commit/ee620b1743bc524ce4b84d8113cb5b43ddcf3b59 DIFF: https://github.com/llvm/llvm-project/commit/ee620b1743bc524ce4b84d8113cb5b43ddcf3b59.diff

[PATCH] D107939: [clang][Arm] Fix the default floating point ABI for 'armv7-pc-win32-macho'

sarahpurohit updated this revision to Diff 366179. sarahpurohit added a comment. Resolved syntax error with braces. No functional change otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107939/new/ https://reviews.llvm.org/D107939 Files:

[PATCH] D107961: [clang-format] Distinguish K C function definition and attribute

owenpan updated this revision to Diff 366176. owenpan added a comment. Added keywords `register`, `struct`, and `union` back. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107961/new/ https://reviews.llvm.org/D107961 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D107939: [clang][Arm] Fix the default floating point ABI for 'armv7-pc-win32-macho'

sarahpurohit accepted this revision. sarahpurohit added a comment. I do not have commit access. Can someone pull this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107939/new/ https://reviews.llvm.org/D107939

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:953 +#define _mm512_cvt_roundpd_ph(A, R) \ + (__m128h) __builtin_ia32_vcvtpd2ph512_mask( \ + (__v8df)(A),

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but may wait 1 or 2 days for the comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105264/new/

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

LuoYuanke added inline comments. Comment at: clang/lib/Headers/avx512vlfp16intrin.h:368 +_mm256_reduce_add_ph(__m256h __W) { + return __builtin_ia32_reduce_fadd_ph256(0.0f16, __W); +} From https://llvm.org/docs/LangRef.html#llvm-vector-reduce-add-intrinsic,

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:1748 + +#define _mm_cvt_roundsh_i32(A, R) \ + (int)__builtin_ia32_vcvtsh2si32((__v8hf)(A), (int)(R)) LuoYuanke wrote: > Does it also

[PATCH] D107540: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1de32d6ddd9: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107540/new/

[clang] b1de32d - [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

Author: Michael Kruse Date: 2021-08-12T21:02:19-05:00 New Revision: b1de32d6ddd90046171ecee0047fbf448a97e16f URL: https://github.com/llvm/llvm-project/commit/b1de32d6ddd90046171ecee0047fbf448a97e16f DIFF: https://github.com/llvm/llvm-project/commit/b1de32d6ddd90046171ecee0047fbf448a97e16f.diff

[PATCH] D107939: [clang][Arm] Fix the default floating point ABI for 'armv7-pc-win32-macho'

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:319 +// "apcs-gnu". +if (Triple.isOSBinFormatMachO() && !useAAPCSForMachO(Triple)) { + return

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

thakis added a comment. Also, I tweaked the tablegen bits a bit to be more like all the other tablegen bits in 189911203779e793cb7767ad233d9994a88c7ea3 . Hope that's ok :) Repository: rG LLVM Github Monorepo CHANGES

[clang] 1899112 - [gn build] manually port 18f9e25ce1fa43 (AttrDocTable)

Author: Nico Weber Date: 2021-08-12T21:30:59-04:00 New Revision: 189911203779e793cb7767ad233d9994a88c7ea3 URL: https://github.com/llvm/llvm-project/commit/189911203779e793cb7767ad233d9994a88c7ea3 DIFF: https://github.com/llvm/llvm-project/commit/189911203779e793cb7767ad233d9994a88c7ea3.diff

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

thakis added a comment. The docs are in rST format. Is that the format LSP wants? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107703/new/ https://reviews.llvm.org/D107703 ___ cfe-commits mailing list

[PATCH] D107540: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

Meinersbur updated this revision to Diff 366161. Meinersbur marked 7 inline comments as done. Meinersbur added a comment. - Address @ftynse's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107540/new/ https://reviews.llvm.org/D107540 Files:

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song added a comment. @dblaikie The clang attr handling patch (D106614 ). Could you help review this patch which handles IR/BitCode Read/Write for btf_tag attributes? This patch contains a common function which will be used by other DItypes, so this

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song updated this revision to Diff 366156. yonghong-song added a comment. - fix clang-format warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106615/new/ https://reviews.llvm.org/D106615 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

bnbarham updated this revision to Diff 366154. bnbarham added a comment. Forgot to add the braces back in for the case statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107690/new/ https://reviews.llvm.org/D107690 Files:

[PATCH] D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths.

akhuang updated this revision to Diff 366153. akhuang added a comment. add case for include_nexts; I don't entirely understand this part of the code so not sure if it's what we want, but it seems to make building with -no-canonical-prefixes happier Repository: rG LLVM Github Monorepo

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. The only nitpicky thing is I don't remember if the code style requires braces around multi-line case blocks or not. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

bnbarham updated this revision to Diff 366152. bnbarham marked an inline comment as done. bnbarham edited the summary of this revision. bnbarham added a comment. Changed to keep setting the umbrella header/directory with a FIXME that it currently doesn't work for framework modules. Repository:

[PATCH] D106614: [Clang] add btf_tag attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b194ef1ab3b: [Clang] add btf_tag attribute (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1b194ef - [Clang] add btf_tag attribute

Author: Yonghong Song Date: 2021-08-12T16:34:22-07:00 New Revision: 1b194ef1ab3b856afb8458fa9c58408360d292cb URL: https://github.com/llvm/llvm-project/commit/1b194ef1ab3b856afb8458fa9c58408360d292cb DIFF: https://github.com/llvm/llvm-project/commit/1b194ef1ab3b856afb8458fa9c58408360d292cb.diff

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 366143. xbolva00 marked an inline comment as not done. xbolva00 added a comment. New test with volatile int. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 Files:

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 marked an inline comment as not done. xbolva00 added inline comments. Comment at: clang/test/Sema/warn-bitwise-and-bool.c:21-22 +void test(boolean a, boolean b, int i) { + b = a & b; + b = a & foo(); // expected-warning {{bitwise and of boolean expressions; did

[PATCH] D95583: Frontend: Add -f{, no-}implicit-modules-uses-lock and -Rmodule-lock

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb714f73defc8: Frontend: Add -f{,no-}implicit-modules-uses-lock and -Rmodule-lock (authored by dexonsmith). Changed prior to commit:

[clang] b714f73 - Frontend: Add -f{,no-}implicit-modules-uses-lock and -Rmodule-lock

Author: Duncan P. N. Exon Smith Date: 2021-08-12T15:58:19-07:00 New Revision: b714f73defc8e0755c7c7cf043df1f1c21344839 URL: https://github.com/llvm/llvm-project/commit/b714f73defc8e0755c7c7cf043df1f1c21344839 DIFF:

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7428-7430 +def warn_bitwise_and_bool : Warning< + "bitwise and of boolean expressions; did you mean logical and?">, + InGroup; Quuxplusone wrote: > I suggest that the

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

mclow.lists added a comment. I suggest you take all the techniques at http://graphics.stanford.edu/~seander/bithacks.html and make sure they don't cause a warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 366141. kstoimenov added a comment. Added code generation tests and fixed some bugs along the way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files:

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 366139. xbolva00 added a comment. Added new tests. Thanks for recommendations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D107632: [clangd] Avoid "expected one compiler job" by picking the first eligible job.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG2ff7ca98a99b: [clangd] Avoid expected one compiler job by picking the first eligible job. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 2ff7ca9 - [clangd] Avoid "expected one compiler job" by picking the first eligible job.

Author: Sam McCall Date: 2021-08-13T00:36:30+02:00 New Revision: 2ff7ca98a99bbfc4f44b8ba1e2e4e594f8ee253e URL: https://github.com/llvm/llvm-project/commit/2ff7ca98a99bbfc4f44b8ba1e2e4e594f8ee253e DIFF: https://github.com/llvm/llvm-project/commit/2ff7ca98a99bbfc4f44b8ba1e2e4e594f8ee253e.diff

[PATCH] D107632: [clangd] Avoid "expected one compiler job" by picking the first eligible job.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Compiler.cpp:42 const clang::Diagnostic ) { + DiagnosticConsumer::HandleDiagnostic(DiagLevel, Info);

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

vsapsai added a comment. Why are you not just changing `return OutOfDate` to `return Failure` for SUBMODULE_UMBRELLA_HEADER and SUBMODULE_UMBRELLA_DIR? I have no strong opinion on this but it feels more in line with the rest of the changes. Also I've tried to do that and nothing seems to be

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

Quuxplusone added subscribers: mclow.lists, Quuxplusone. Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7428-7430 +def warn_bitwise_and_bool : Warning< + "bitwise and of boolean expressions; did you mean logical and?">, +

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 366130. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaChecking.cpp

[PATCH] D107365: clangd: Make documentation property of completion items more similar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b28835b3754: clangd: Make documentation property of completion items more similar (authored by ckandeler, committed by sammccall). Changed prior

[clang-tools-extra] 6b28835 - clangd: Make documentation property of completion items more similar

Author: Christian Kandeler Date: 2021-08-13T00:18:15+02:00 New Revision: 6b28835b3754aa3b795e7684b3e7f465b516f753 URL: https://github.com/llvm/llvm-project/commit/6b28835b3754aa3b795e7684b3e7f465b516f753 DIFF:

[PATCH] D95581: Frontend: Refactor compileModuleAndReadAST, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc130300f8ba0: Frontend: Refactor compileModuleAndReadAST, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c130300 - Frontend: Refactor compileModuleAndReadAST, NFC

Author: Duncan P. N. Exon Smith Date: 2021-08-12T15:16:08-07:00 New Revision: c130300f8ba0363749cf2490bbd43515fad8a759 URL: https://github.com/llvm/llvm-project/commit/c130300f8ba0363749cf2490bbd43515fad8a759 DIFF:

[PATCH] D107137: clangd: Provide hover info for include directives

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c8602b53fd: clangd: Provide hover info for include directives (authored by ckandeler, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107137: clangd: Provide hover info for include directives

sammccall added a comment. All done! Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107137/new/ https://reviews.llvm.org/D107137 ___ cfe-commits mailing list

[clang-tools-extra] f9c8602 - clangd: Provide hover info for include directives

Author: Christian Kandeler Date: 2021-08-13T00:07:23+02:00 New Revision: f9c8602b53fd277e1428cb6e8e63485b14520a82 URL: https://github.com/llvm/llvm-project/commit/f9c8602b53fd277e1428cb6e8e63485b14520a82 DIFF:

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn for bitwise and of bools with side effects

xbolva00 added a comment. Open questions: 1, warn for pattern boolA & boolB always? I think that we will have some false positives. 2, restrict this warning even more? RHS must be a call? 3, something similar for bitwise or? @hans @nickdesaulniers maybe you want to try this new warning on

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn for bitwise and of bools with side effects

xbolva00 created this revision. xbolva00 added reviewers: hans, nickdesaulniers, aaron.ballman, rsmith. xbolva00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Motivation:

[clang-tools-extra] ece4e92 - [CodeComplete] Basic code completion for attribute names.

Author: Sam McCall Date: 2021-08-12T23:49:10+02:00 New Revision: ece4e920852185b332c2f7ba027e0c4a2972855a URL: https://github.com/llvm/llvm-project/commit/ece4e920852185b332c2f7ba027e0c4a2972855a DIFF: https://github.com/llvm/llvm-project/commit/ece4e920852185b332c2f7ba027e0c4a2972855a.diff

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGece4e9208521: [CodeComplete] Basic code completion for attribute names. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny added inline comments. Comment at: clang/include/clang/Driver/Options.td:2383 +defm openmp_extensions: BoolFOption<"openmp-extensions", + LangOpts<"OpenMPExtensions">, DefaultFalse, + PosFlag jdenny wrote: > > ABataev wrote: > > > Why do you want to disable it by

[PATCH] D107836: [Attributes]: refactor to expose ParsedAttrInfo::acceptsLangOpts. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b99acbff250: [Attributes]: refactor to expose ParsedAttrInfo::acceptsLangOpts. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3b99acb - [Attributes]: refactor to expose ParsedAttrInfo::acceptsLangOpts. NFC

Author: Sam McCall Date: 2021-08-12T23:47:01+02:00 New Revision: 3b99acbff2504d9f056c6bb76974286322e60382 URL: https://github.com/llvm/llvm-project/commit/3b99acbff2504d9f056c6bb76974286322e60382 DIFF: https://github.com/llvm/llvm-project/commit/3b99acbff2504d9f056c6bb76974286322e60382.diff

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08c04ca00542: [clangd] Overload bundles are only deprecated if each overloads is. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 08c04ca - [clangd] Overload bundles are only deprecated if each overloads is.

Author: Sam McCall Date: 2021-08-12T23:46:08+02:00 New Revision: 08c04ca00542bc2605e7c5d723f8cf478f012f61 URL: https://github.com/llvm/llvm-project/commit/08c04ca00542bc2605e7c5d723f8cf478f012f61 DIFF: https://github.com/llvm/llvm-project/commit/08c04ca00542bc2605e7c5d723f8cf478f012f61.diff

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

This revision was automatically updated to reflect the committed changes. Closed by commit rG8930af45c35b: [PowerPC] Implement XL compatibility builtin __addex (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/

[clang] 8930af4 - [PowerPC] Implement XL compatibility builtin __addex

Author: Lei Huang Date: 2021-08-12T16:38:21-05:00 New Revision: 8930af45c35b5224d3b90c8408957f6b7bfa1be0 URL: https://github.com/llvm/llvm-project/commit/8930af45c35b5224d3b90c8408957f6b7bfa1be0 DIFF: https://github.com/llvm/llvm-project/commit/8930af45c35b5224d3b90c8408957f6b7bfa1be0.diff

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

dblaikie added a comment. Probably still worth fixing the bug too? (though maybe not a priority once it's moved out into -Wunreachable-code) - though the general fix, as discussed on the bug (comment 18 and 19 about why this doesn't already produce an unreachable-code warning), may require a

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

xbolva00 added a comment. Yes, something like that, plus I think you want put UnreachableCodeFallthrough into group UnreachableCode as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107933/new/ https://reviews.llvm.org/D107933

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance added a comment. So something more along the lines of diff diff --git a/clang/include/clang/Basic/DiagnosticGroups.td b/clang/include/clang/Basic/DiagnosticGroups.td index 1555a9ee2465..0aa9a82e3d11 100644 --- a/clang/include/clang/Basic/DiagnosticGroups.td +++

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 366094. lei added a comment. Fix name of new warning message to be more accuratly represent the diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Files:

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Anastasia added a comment. Great! Thanks! The suggested minor test clean-up can be addressed in the final commit! Comment at: clang/test/SemaOpenCL/nosvm.cl:10 +// expected-warning@-2 {{'nosvm' attribute is deprecated and ignored in OpenCL C version 2.0}} +#elif

[PATCH] D107961: [clang-format] Distinguish K C function definition and attribute

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:17 #include "FormatToken.h" -#include "clang/Basic/TokenKinds.h" #include "llvm/ADT/STLExtras.h" HazardyKnusperkeks wrote: > Why is this not needed anymore? It was added in [[

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e11ccad837c: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86 (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES

[clang] 1e11cca - [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

Author: Thomas Preud'homme Date: 2021-08-12T21:38:35+01:00 New Revision: 1e11ccad837c2d0d848349e7bc8f5800e5d365fc URL: https://github.com/llvm/llvm-project/commit/1e11ccad837c2d0d848349e7bc8f5800e5d365fc DIFF:

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:2383 +defm openmp_extensions: BoolFOption<"openmp-extensions", + LangOpts<"OpenMPExtensions">, DefaultFalse, + PosFlag ABataev wrote: > > Why do you want to disable it by default? > I thought

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny added inline comments. Comment at: clang/include/clang/Driver/Options.td:2383 +defm openmp_extensions: BoolFOption<"openmp-extensions", + LangOpts<"OpenMPExtensions">, DefaultFalse, + PosFlag Why do you want to disable it by default? I thought that's what we agreed

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

xbolva00 added a comment. I think we should just move it, not delete it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107933/new/ https://reviews.llvm.org/D107933 ___ cfe-commits mailing list

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov updated this revision to Diff 366083. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107339/new/ https://reviews.llvm.org/D107339 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp Index:

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

vsapsai planned changes to this revision. vsapsai added a comment. Need to detect mismatches in nested structs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance added a comment. > In D107933#2942023 , @xbolva00 > wrote: > >> > > GCC does not warn (with common -Wall) for this case, right? I think Clang > should not as well. Correct, GCC does not warn at all about unreachable fallthrough

[PATCH] D107073: [analyzer] Disable direct binding from list initialization for constant arrays of local storage duration.

ASDenysPetrov updated this revision to Diff 366081. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107073/new/ https://reviews.llvm.org/D107073 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/initialization.c

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2042-2044 +.. option:: -fopenmp-extensions, -fno-openmp-extensions + +Enable all Clang extensions for OpenMP directives and clauses. Default value? Comment at:

[PATCH] D106681: [analyzer] Retrieve a value from list initialization of constant multi-dimensional array.

ASDenysPetrov updated this revision to Diff 366079. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106681/new/ https://reviews.llvm.org/D106681 Files: clang/lib/StaticAnalyzer/Core/MemRegion.cpp clang/lib/StaticAnalyzer/Core/RegionStore.cpp

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107667/new/ https://reviews.llvm.org/D107667

[PATCH] D107843: [X86] Add parentheses around casts in some of the X86 intrinsic headers.

craig.topper updated this revision to Diff 366071. craig.topper added a comment. Add test case to the bottom of sse41-builtins.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107843/new/ https://reviews.llvm.org/D107843 Files:

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:410 +if (Completion.Deprecated) { + Completion.Deprecated = + (C.SemaResult && kbobyrev wrote: > sammccall wrote: > > kbobyrev wrote: > > > The comment you

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 366069. kstoimenov added a comment. Started using R8 instead of RAX beacuse of some test failures. Also fixed the "Yes means No and No means Yes. Delete all files [Y]? " bug :-) for the load/store functions.

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rG18f9e25ce1fa: [AST][clangd] Expose documentation of Attrs on hover. (authored by sammccall). Changed

[clang] 18f9e25 - [AST][clangd] Expose documentation of Attrs on hover.

Author: Sam McCall Date: 2021-08-12T21:16:37+02:00 New Revision: 18f9e25ce1fa43f8663bd03f908ef9b27a0788f8 URL: https://github.com/llvm/llvm-project/commit/18f9e25ce1fa43f8663bd03f908ef9b27a0788f8 DIFF: https://github.com/llvm/llvm-project/commit/18f9e25ce1fa43f8663bd03f908ef9b27a0788f8.diff

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

sammccall marked 9 inline comments as done. sammccall added inline comments. Comment at: clang/unittests/AST/AttrTest.cpp:19 +TEST(Attr, Doc) { + EXPECT_THAT(Attr::getDocumentation(attr::Used), + testing::HasSubstr("The compiler must emit the definition even "

[PATCH] D107836: [Attributes]: refactor to expose ParsedAttrInfo::acceptsLangOpts. NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! If @john.brawn has concerns, we can address them post commit. Comment at: clang/include/clang/Sema/ParsedAttr.h:96 + /// Check if this attribute is

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

stefanp accepted this revision. stefanp added a comment. Thank you for adding the `DiagGroup`. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 ___

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

dblaikie added a comment. In D107933#2942023 , @xbolva00 wrote: > GCC does not warn (with common -Wall) for this case, right? I think Clang > should not as well. > > ImplicitFallthroughUnreachable could be enabled with -Wunreachable-code, if > you

[libunwind] 2f1ee56 - [unwind] Handle UNW_X86_64_RIP register

Author: Vitaly Buka Date: 2021-08-12T12:08:07-07:00 New Revision: 2f1ee56f3cb8adb5aeadba3f66a8fc39fba1604d URL: https://github.com/llvm/llvm-project/commit/2f1ee56f3cb8adb5aeadba3f66a8fc39fba1604d DIFF: https://github.com/llvm/llvm-project/commit/2f1ee56f3cb8adb5aeadba3f66a8fc39fba1604d.diff

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny marked 4 inline comments as done. jdenny added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:64 + return OMPC_MAP_MODIFIER_unknown; +if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold) return OMPC_MAP_MODIFIER_unknown;

[PATCH] D107836: [Attributes]: refactor to expose ParsedAttrInfo::acceptsLangOpts. NFC

sammccall added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:96 + /// Check if this attribute is allowed by the language we are compiling. + virtual bool acceptsLangOpts(const LangOptions ) const { return true; } + aaron.ballman wrote: >

[PATCH] D107836: [Attributes]: refactor to expose ParsedAttrInfo::acceptsLangOpts. NFC

sammccall updated this revision to Diff 366064. sammccall added a comment. Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107836/new/ https://reviews.llvm.org/D107836 Files: clang/docs/ReleaseNotes.rst

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 366062. lei added a comment. Update diag id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

xbolva00 added a comment. GCC does not warn (with common -Wall) for this case, right? I think Clang should not as well. ImplicitFallthroughUnreachable could be enabled with -Wunreachable-code, if you think we should have it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631 +"at " + << (AI->getSyncScopeID() ? "system" : "single thread") + << " memory scope"); gandhi21299 wrote: > rampitec wrote:

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631 +"at " + << (AI->getSyncScopeID() ? "system" : "single thread") + << " memory scope"); rampitec wrote: > gandhi21299

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nickdesaulniers added inline comments. Comment at: clang/test/SemaCXX/switch-implicit-fallthrough.cpp:211-214 +case 224: + n += 400; +case 225: // expected-warning{{unannotated fall-through between switch labels}} expected-note{{insert '[[clang::fallthrough]];' to

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 366051. stevewan added a comment. Rebase to latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:964-965 +bool match = +(EA->isError() && NewAttrSpellingIndex < ErrorAttr::GNU_warning) || +(EA->isWarning() && NewAttrSpellingIndex >= ErrorAttr::GNU_warning); +if

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 366050. nickdesaulniers marked 4 inline comments as done. nickdesaulniers added a comment. - combine c++ w/ c test - use -verify= rather than -D - remove REQUIRES - go back to string comparison Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

cor3ntin added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AlternativeTokensCheck.cpp:69 + // Only insert spaces if there aren't already spaces between operators + StringRef SpaceBefore = std::isspace(lookahead(SM, Loc, -1)) ? "" : " "; + StringRef

[clang] f999312 - Recommit "[Matrix] Overload stride arg in matrix.columnwise.load/store."

Author: Florian Hahn Date: 2021-08-12T18:31:57+01:00 New Revision: f999312872b811b550533640b92ecb234cf5c642 URL: https://github.com/llvm/llvm-project/commit/f999312872b811b550533640b92ecb234cf5c642 DIFF: https://github.com/llvm/llvm-project/commit/f999312872b811b550533640b92ecb234cf5c642.diff

  1   2   3   >