[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372570. daltenty added a comment. - Fix additional test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + ZarkoCA wrote: > sfertile wrote: > > The

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. I'm a little bit confused here. Where is the speed-up coming from? Is it because ObjCMethodList for `init` not being serialized? I'm asking because right now I don't see how `seen` helps with that. My current understanding is that `Sema::addMethodToGlobalList` is too

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +//

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#3000223 , @erichkeane wrote: > In D108643#3000193 , @rjmccall > wrote: > >> In D108643#2999776 , @erichkeane >> wrote: >> !

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. In D108643#3000540 , @rjmccall wrote: > The question is whether you can rely on extension at places that receive an > arbitrary ABI-compatible value, like function parameters or loads. If nobody > who receives such a value

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

woodruffw updated this revision to Diff 372595. woodruffw added a comment. Increase the context for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 Files: clang/lib/Frontend/ASTConsumers.cpp

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372615. hoy added a comment. Updating D109638 : [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 626586f - Re-Revert "clang-tidy: introduce readability-containter-data-pointer check"

Author: Nico Weber Date: 2021-09-14T22:27:59-04:00 New Revision: 626586fc253c6f032aedb325dba6b1ff3f11875e URL: https://github.com/llvm/llvm-project/commit/626586fc253c6f032aedb325dba6b1ff3f11875e DIFF: https://github.com/llvm/llvm-project/commit/626586fc253c6f032aedb325dba6b1ff3f11875e.diff

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372584. cchen added a comment. Fix based on suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy added a comment. In D109638#3000682 , @wenlei wrote: >> It isn't common when the program is built with the frame pointer omission >> disabled, but can still happen with third-party static libs built with frame >> pointer omitted. > > Did you mean

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG299b5d420df1: [CSSPGO] Enable pseudo probe instrumentation in O0 mode. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 299b5d4 - [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

Author: Hongtao Yu Date: 2021-09-14T18:13:29-07:00 New Revision: 299b5d420df15fafc9936bc24995f6cd6ad325be URL: https://github.com/llvm/llvm-project/commit/299b5d420df15fafc9936bc24995f6cd6ad325be DIFF: https://github.com/llvm/llvm-project/commit/299b5d420df15fafc9936bc24995f6cd6ad325be.diff

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#3000556 , @erichkeane wrote: > In D108643#3000540 , @rjmccall > wrote: > >> > > I don't work on the microcode, it is just what I was told when we asked about > this. SO

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

wenlei added a comment. > It isn't common when the program is built with the frame pointer omission > disabled, but can still happen with third-party static libs built with frame > pointer omitted. Did you mean disabled -> enabled? > This could happen to frame-pointer-based unwinding and the

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

jdoerfert added a comment. Great! This should work. Though we need actual tests ;) I also provided you with two minor edits below to make it easier to read, no functional change though. Comment at: clang/lib/Sema/SemaOpenMP.cpp:737-738 +if (ScopeEntry) +

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wenlei accepted this revision. wenlei added a comment. lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.llvm.org/D109531 ___ cfe-commits mailing list

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372604. hoy added a comment. Addressing Wenlei's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109638/new/ https://reviews.llvm.org/D109638 Files:

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy added inline comments. Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772 +void PerfReaderBase::emitAccumulatedWarnings() { + for (auto Address : InvalidReturnAddresses) { wenlei wrote: > nit: emitAccumulatedWarnings -> warnTruncatedStack Makes sense.

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

rjmccall added a comment. Hmm. I think "v-tables are in the address space of the object pointer" is not a good assumption. Probably this ought to be determined by the C++ ABI for the target. In principle it could even be class-specific, but I think we can start by assuming it's universal.

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:746 +} + } + } jdoerfert wrote: > jdoerfert wrote: > > So, SmalVector has a pop_back_val which we could use to verify the > > properties are the ones we expect. However, we

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3000469 , @vsapsai wrote: > I'm a little bit confused here. Where is the speed-up coming from? Is it > because ObjCMethodList for `init` not being serialized? I'm asking because > right now I don't see how `seen` helps

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz updated this revision to Diff 372597. rmaz added a comment. Updated to use a GlobalMethods struct which contains the global method lists as well as the sets used to de-duplicate added methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz updated this revision to Diff 372598. rmaz added a comment. update to fix lint warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109632/new/ https://reviews.llvm.org/D109632 Files: clang/include/clang/Sema/Sema.h

[PATCH] D109799: [RISCV] add Half-precision test for load/store

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: craig.topper, HsiangKai. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm except two nits. Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772 +void PerfReaderBase::emitAccumulatedWarnings() { + for (auto Address :

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

thakis added a comment. The test is still failing on Windows, see e.g. http://45.33.8.238/win/45205/step_8.txt or https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8836086236638553313/+/u/package_clang/stdout?format=raw or

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 372514. saiislam added a comment. Rebase and a minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @thakis - thanks, seems that I had a part of the change sitting in my stash ... I had added a `-NOT` to verify the behaviour, and forgot to remove it. I'll revert the revert with the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

HazardyKnusperkeks added a comment. If there are no new tests, what went wrong before? Said invalid code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109752/new/ https://reviews.llvm.org/D109752 ___

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#2999776 , @erichkeane wrote: >> ! In D108643#2965852 , @rjmccall >> wrote: >> >> The choice that high bits are unspecified rather than extended is an >> interesting one.

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added subscribers: craig.topper, andrew.w.kaylor. erichkeane added a comment. In D108643#3000193 , @rjmccall wrote: > In D108643#2999776 , @erichkeane > wrote: > >>> ! In D108643#2965852

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372529. cchen added a comment. Fix based on feedback (wait for comment about moving ConstructTrait to IRBuilder) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. Thanks for your reply and sorry about my very sluggish reply! I am looking into updating the docs as you suggested, and that got me looking at this doc page . Interestingly,

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. In D109362#2999688 , @uweigand wrote: > Looking at the common code parts, it seems the behavior of MM_GOFF is > actually identical to MM_ELF. Is this correct? If so, do we really need a > different format type here? At a

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372548. vaibhav.y added a comment. Format clang/lib/Basic/Sarif.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. In D109557#2998727 , @csmulhern wrote: > In D109557#2998213 , > @HazardyKnusperkeks wrote: > >> With context he meant the diff context. >>

[PATCH] D109128: [VFS] Use original path when falling back to external FS

JDevlieghere added a comment. Yes, Keith and I came to the same conclusion yesterday. I was worried about tracking both paths at all times, but I like your suggestion of only changing the path when requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:8188-8190 + for (auto *L = L; L = L->getNext()) { +seen.insert(L->getMethod()); + } dexonsmith wrote: > I find quadratic algorithms a bit scary, even when current benchmarks

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. In D109128#3000157 , @JDevlieghere wrote: > Yes, Keith and I came to the same conclusion yesterday. I was worried about > tracking both paths at all times, but I like your suggestion of only changing > the path when

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372542. vaibhav.y added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:746 +} + } + } jdoerfert wrote: > So, SmalVector has a pop_back_val which we could use to verify the properties > are the ones we expect. However, we would need to first

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds range checking for some Power10 altivec builtins. Range checking is done in

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 372541. quinnp added a comment. Removing an extra space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added a reviewer: vsapsai. dexonsmith added a subscriber: vsapsai. dexonsmith added a comment. Thanks for looking at this! I have a couple of comments inline. @vsapsai, can you also take a look? Comment at: clang/lib/Serialization/ASTReader.cpp:8188-8190 + for

[clang-tools-extra] 49992c0 - Revert "Revert "clang-tidy: introduce readability-containter-data-pointer check""

Author: Saleem Abdulrasool Date: 2021-09-14T10:52:35-07:00 New Revision: 49992c04148e5327bef9bd2dff53a0d46004b4b4 URL: https://github.com/llvm/llvm-project/commit/49992c04148e5327bef9bd2dff53a0d46004b4b4 DIFF:

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. I've tried making an integration test in addition to the unit test, but I couldn't find a way to make lit ignore the crashed process exit status: FAIL: Clangd :: crash.test (1049 of 1049) TEST 'Clangd :: crash.test' FAILED

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372543. vaibhav.y added a comment. Fixup name of class defined in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files:

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0057c7185d1c: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address. (authored by hoy). Repository: rG LLVM Github Monorepo

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

owenpan added a comment. Yes, the said invalid code may get reformatted. However, the main purpose of this patch is to fix the efficiency issue as nested function declarators would no longer be checked for possible K C function definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

NoQ added a comment. In D105756#2990495 , @mizvekov wrote: > Hello! Thanks for reporting this. Thanks for fixing! In D105756#2990495 , @mizvekov wrote: > The double implicit lvalue-to-rvalue cast is an

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. In D108695#2999677 , @Szelethus wrote: > rGfb4d590a622f4031900516360c07ee6ace01c5e6 > should > sort this out! Yes now it works. Thank you! Repository:

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. 1. modf works now. 2. if I modify the complile.sh clang++ -fopenmp -fopenmp-targets=nvptx64 -c classA.cpp rm -f libmylib.a ar qc libmylib.a classA.o ranlib libmylib.a clang++ -fopenmp -fopenmp-targets=nvptx64 main.cpp -L. -lmylib ./a.out doesn't work. I

<    1   2