[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen requested changes to this revision. dmgreen added a comment. This revision now requires changes to proceed. > As I did the downstream work for this, I'm happy with it to go in in this > form. This doesn't seem.. wise. Please make sure the reviews you do are at a sufficient quality, and

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. As I did the downstream work for this, I'm happy with it to go in in this form. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3-4 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o -

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:27 +// THINLTO-OLDPM-NOT: PGOIndirectCallPromotion +// THINLTO-OLDPM: Unroll loops +// THINLTO-OLDPM-NOT: Unroll loops When printing out passes

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I guess this will prevent member functions in classes being treated as K functions right? if thats the case them this LGTM Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372696. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files:

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ created this revision. mubashar_ added a reviewer: MarkMurrayARM. Herald added subscribers: hiraditya, kristof.beyls. mubashar_ requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch enables support for

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. > Okay. Sorry if I came down on you personally, I know what it's like to be in > the middle on things like this Thank you, I very much appreciate that. > I'm not sure if there's a way to get LLVM to treat loaded values as only > having N valid bits. > > Do you have

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

JonChesterfield added a comment. In D105191#3001508 , @saiislam wrote: > PS: We (mulit-company OpenMP-dev meetings) have been tracking this feature > for a while and we would very much like it to be picked for llvm-13. I think llvm-13 is on -final now

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#3001056 , @ye-luo wrote: > 1. modf works now. > > 2. if I modify the complile.sh > > clang++ -fopenmp -fopenmp-targets=nvptx64 -c classA.cpp > rm -f libmylib.a > ar qc libmylib.a classA.o > ranlib libmylib.a >

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM, but the most recent way of implementing this (using target features) was something I suggested to Alexandros based on @ostannard's feedback about LTO. I think it is cleaner, and this

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

catenacyber added a comment. Should we still bump `INSTR_PROF_RAW_VERSION ` so that we are able to distinguish profraw files produced by clang13 and the ones produced by clang14 ? Right now, both produce `LLVM raw profile data, version 7` Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea updated this revision to Diff 372677. labrinea added a comment. Changes in this revision: - added `-verify-machineinstrs` to the tests - that yield two bugs that I had to address: *** Bad machine code: Explicit operand marked as def *** - function:func - basic block: %bb.0

[PATCH] D109506: [clangd] Print current request context along with the stack trace

sammccall added a comment. This is mostly LG with nits, but I think the code-completion handler is wrong, and the tests as written won't build on windows. In D109506#2992201 , @sammccall wrote: > Oops, forgot one thing: you probably want to instrument

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 372573. gandhi21299 added a comment. - converted the HIP test into a CUDA test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 Files:

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 372551. gandhi21299 added a comment. - added the include header for HIP runtime Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 Files:

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea updated this revision to Diff 372674. labrinea added a comment. Changes in this revision: - Replaced the backend option that enables the mitigation with a subtarget feature so that it works with LTO (@lenary thanks for the offline hint) - Enabled the subtarget feature on the affected

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei updated this revision to Diff 372664. pengfei marked 2 inline comments as done. pengfei added a comment. Address Yuanke's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llvm.org/D109607 Files:

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Topotuna marked an inline comment as done. Closed by commit rG3b9470a6c46d: [OpenCL] Supports optional image types in C++ for OpenCL 2021 (authored by Topotuna).

[clang] 3b9470a - [OpenCL] Supports optional image types in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-15T10:03:47+01:00 New Revision: 3b9470a6c46d0ecdb586a5a1e9223ea0c832337c URL: https://github.com/llvm/llvm-project/commit/3b9470a6c46d0ecdb586a5a1e9223ea0c832337c DIFF:

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. In D109362#3000284 , @anirudhp wrote: > In D109362#2999688 , @uweigand > wrote: > >> Looking at the common code parts, it seems the behavior of MM_GOFF is >> actually identical to

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/X86/avx512fp16-abi.c:153 +struct float2 { + struct {} s; + float a; Add a test case for "{ struct {}; half; struct {}; half;}? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

LuoYuanke added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3421 +if (T0->isHalfTy()) + T1 = getFPTypeAtOffset(IRType, IROffset + 4, TD); +// If we can't get a second FP type, return a simple half or float. Not quite understanding

[PATCH] D109812: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix

mgorny created this revision. mgorny added reviewers: tstellar, cryptoad. Herald added a subscriber: dberris. mgorny requested review of this revision. 9ee64c374605683ae80b9641d5312a72c2a67336 has started using

[PATCH] D109739: [X86][InlineAsm][Bugfix] Use mem size information (*word ptr) for "global variable + registers" memory expression in inline asm.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f1c71aeacc1: [X86][InlineAsm] Use mem size information (*word ptr) for global variable +… (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[clang] 1f1c71a - [X86][InlineAsm] Use mem size information (*word ptr) for "global variable + registers" memory expression in inline asm.

Author: Xiang1 Zhang Date: 2021-09-15T16:11:14+08:00 New Revision: 1f1c71aeacc1c4eab385c074714508b6e7121f73 URL: https://github.com/llvm/llvm-project/commit/1f1c71aeacc1c4eab385c074714508b6e7121f73 DIFF: https://github.com/llvm/llvm-project/commit/1f1c71aeacc1c4eab385c074714508b6e7121f73.diff

<    1   2