[clang-tools-extra] 7394d3b - Investigate D110386 Windows failures

Author: Kirill Bobyrev Date: 2021-09-28T09:53:01+02:00 New Revision: 7394d3ba276adeb1527428b2355a920129a2b9b1 URL: https://github.com/llvm/llvm-project/commit/7394d3ba276adeb1527428b2355a920129a2b9b1 DIFF:

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:400-401 + bool SuppressionIsSpecific; + for (const auto : Lines) { +if (isNOLINTFound("NOLINTBEGIN", CheckName, Line, , + )) {

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

bakinovsky-m added a comment. In D110525#3025314 , @aaron.ballman wrote: > I'm not certain how, but somehow this review is set to be uneditable, so I > cannot mark it as accepted (or close it later once it lands). > >> bakinovsky-m created this object

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

martong added a reviewer: steakhal. martong added a comment. Adding @steakhal as reviewer because of other reviewers inactivity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102

[clang-tools-extra] d1c6e54 - Investigate D110386 failures even further

Author: Kirill Bobyrev Date: 2021-09-28T12:02:13+02:00 New Revision: d1c6e54930f200c40820868c086e114cee1ec693 URL: https://github.com/llvm/llvm-project/commit/d1c6e54930f200c40820868c086e114cee1ec693 DIFF:

[clang] 23a5090 - [clang-format][docs] mark new clang-format configuration options based on which version they would GA

Author: mydeveloperday Date: 2021-09-28T11:42:19+01:00 New Revision: 23a5090c6ac7a207f49a11bf868a7c3fae2aeea2 URL: https://github.com/llvm/llvm-project/commit/23a5090c6ac7a207f49a11bf868a7c3fae2aeea2 DIFF:

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23a5090c6ac7: [clang-format][docs] mark new clang-format configuration options based on which… (authored by MyDeveloperDay). Repository: rG LLVM

[clang-tools-extra] e7a5347 - Revert "[clangd] Refactor IncludeStructure: use File (unsigned) for most computations"

Author: Kirill Bobyrev Date: 2021-09-28T13:34:42+02:00 New Revision: e7a5347b55e6050106bb61fa9a54920720806e07 URL: https://github.com/llvm/llvm-project/commit/e7a5347b55e6050106bb61fa9a54920720806e07 DIFF:

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1838-1841 def BTFTag : DeclOrTypeAttr { let Spellings = [Clang<"btf_tag">]; let Args = [StringArgument<"BTFTag">]; + let Subjects = SubjectList<[Var, Function, Record, Field, TypedefName],

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman closed this revision. aaron.ballman added a comment. In D108560#3027105 , @salman-javed-nz wrote: > Yes, I will need your help to commit. > > Salman Javed > m...@salmanjaved.org > > Thank you very much for the review. Looking back at my

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp updated this revision to Diff 375545. carlosgalvezp retitled this revision from "[clang-tidy] Fix false positive in cppcoreguidelines-virtual-class-destructor " to "[clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor ". carlosgalvezp edited the

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added a comment. By one other bug I mean an entirely separate bug that I will handle in a separate PR. Sorry if that was confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110481/new/ https://reviews.llvm.org/D110481

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

erichkeane added a comment. A couple of small things, otherwise I'm happy; but Aaron has some bigger opens above, plus clang-format, plus the modules from Richard. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:257 + +def err_unevaluated_string_prefix : Error< +

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. I agree with @steakhal , that perhaps we could come up with a somewhat more compact and elegant implementation in the future. Nevertheless, I think this patch in its current form is already

[PATCH] D110614: [clang-tidy] Fix false positive in cppcoreguidelines-virtual-class-destructor

carlosgalvezp created this revision. carlosgalvezp added reviewers: mgartmann, aaron.ballman, alexfh, alexfh_. carlosgalvezp added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. carlosgalvezp requested review of this revision. Incorrectly triggers

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

martong added a comment. In D106102#3019921 , @manas wrote: > I haven't tried specializing that `VisitBinaryOperator` method which converts > Ranges from RangeSets (as @vsavchenko mentioned). Should this case for NE > stay here in the switch or move?

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in 4f01a02d738b033c10bfed5b47014fc197509a4f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D110525#3026757 , @bakinovsky-m wrote: > In D110525#3025300 , @aaron.ballman > wrote: >

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. Yes, I will need your help to commit. Salman Javed m...@salmanjaved.org Thank you very much for the review. Looking back at my initial initial submission a few weeks ago, I can see all the valuable improvements the review process has made. Hopefully people

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

ASDenysPetrov added inline comments. Comment at: clang/test/Analysis/constraint-assignor.c:18 + clang_analyzer_warnIfReached(); // no-warning + (void)x; // keep the constraints alive. +} steakhal wrote: > It's still mindboggling that we need to do this. This

[clang] 45e75d9 - Update the message for template-template param keyword for C++17

Author: Erich Keane Date: 2021-09-28T06:02:29-07:00 New Revision: 45e75d93821f7e4f04d9f42cb19f729b346e7c0c URL: https://github.com/llvm/llvm-project/commit/45e75d93821f7e4f04d9f42cb19f729b346e7c0c DIFF: https://github.com/llvm/llvm-project/commit/45e75d93821f7e4f04d9f42cb19f729b346e7c0c.diff

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

balazske added a comment. If the `ASTImporter` and parts of `ASTNodeImporter` are made public API then it can be possible to add generation of import code to the **.td** files, this should be the best solution. In similar way, import of `Stmt` and `Expr` nodes can be generated if possible.

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

martong added a comment. In D110528#3026921 , @balazske wrote: > If the `ASTImporter` and parts of `ASTNodeImporter` are made public API then > it can be possible to add generation of import code to the **.td** files, > this should be the best

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. I cannot tell without context whether the codegen changes for the `f32->i32` convert + insert case (for example `@test2` in `test/CodeGen/PowerPC/test-vector-insert.ll`) but it

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp updated this revision to Diff 375549. carlosgalvezp added a comment. -Remove "public" when checking for base virtual destructor, it's not relevant. -More consistent naming. -Fix formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110614/new/

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki created this revision. Herald added subscribers: yaxunl, mgorny. linjamaki edited the summary of this revision. linjamaki updated this revision to Diff 375488. linjamaki added a comment. linjamaki edited the summary of this revision. linjamaki added a reviewer: yaxunl. linjamaki

[PATCH] D110612: [Utils] Use common substs in update_cc_test_checks

arichardson added reviewers: jdoerfert, ggeorgakoudis. arichardson added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:223 def exec_run_line(exe): popen = subprocess.Popen(exe, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution in git? Repository: rG

[clang] 3d6f49a - Simplify handling of builtin with inline redefinition

Author: serge-sans-paille Date: 2021-09-28T13:24:25+02:00 New Revision: 3d6f49a56995b845c40be5827ded5d1e3f692cec URL: https://github.com/llvm/llvm-project/commit/3d6f49a56995b845c40be5827ded5d1e3f692cec DIFF:

[PATCH] D109967: Simplify handling of builtin with inline redefinition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d6f49a56995: Simplify handling of builtin with inline redefinition (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110398: [clang][ASTImporter] Import ConstructorUsingShadowDecl correctly.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Nice work! Thanks for the assiduous tests! Comment at: clang/unittests/AST/ASTImporterTest.cpp:6827-6828 +FirstDeclMatcher().match( +TU,

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. Also, the pre-merge build failure is confirmed to be a problem with the build system and not the contents of my patch. https://github.com/google/llvm-premerge-checks/issues/353 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor corrections in comments, thank you for the fix! Comment at: clang/lib/Sema/SemaStmt.cpp:381-382 - DiagRuntimeBehavior(Loc, nullptr,

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kees great, thanks for confirming - I just landed the patch. Can you share a pointer to the missing pieces? I'm interested in implemented the missing parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110482: [clang] Implement if consteval (P1938)

erichkeane added a comment. So I have some heartburn about `IsNegatedConsteval`. A part of me wants to suggest ditching the `ConstexprKind` and creating a new scoped-enum `IfStmtKind` (perhaps in the same file) that has just `None,Constexpr,Consteval,NotConsteval`. Its already a bit hinky

[PATCH] D110395: [clang][ASTImporter] Import InheritedConstructor and ConstructorUsingShadowDecl.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: steakhal. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110395/new/ https://reviews.llvm.org/D110395

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz updated this revision to Diff 375512. salman-javed-nz marked 4 inline comments as done. salman-javed-nz retitled this revision from "[clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines" to "[clang-tidy] Add support

[clang-tools-extra] c0687e1 - Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

Author: Salman Javed Date: 2021-09-28T07:53:23-04:00 New Revision: c0687e1984a82925918c874b7bb68ad34c32aed0 URL: https://github.com/llvm/llvm-project/commit/c0687e1984a82925918c874b7bb68ad34c32aed0 DIFF: https://github.com/llvm/llvm-project/commit/c0687e1984a82925918c874b7bb68ad34c32aed0.diff

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki created this revision. Herald added subscribers: dang, kerbowa, yaxunl, mgorny, nhaehnle, jvesely. linjamaki updated this revision to Diff 375526. linjamaki added a comment. linjamaki published this revision for review. Herald added a project: clang. Herald added a subscriber:

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 updated this revision to Diff 375544. feg208 added a comment. Gets rid of the crash for the second added case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110481/new/ https://reviews.llvm.org/D110481 Files:

[PATCH] D110612: [Utils] Use common substs in update_cc_test_checks

sebastian-ne created this revision. sebastian-ne added reviewers: foad, arichardson. sebastian-ne requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Use substitution methods from common.py in update_cc_test_checks.py.

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375487. cor3ntin added a comment. - Add IfStmt::isNegatedConsteval to track whether the if consteval statement was negated - Add json/text AST dumps tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 4f01a02 - Fix documentation typos; NFC

Author: M Bakinovsky Date: 2021-09-28T06:56:49-04:00 New Revision: 4f01a02d738b033c10bfed5b47014fc197509a4f URL: https://github.com/llvm/llvm-project/commit/4f01a02d738b033c10bfed5b47014fc197509a4f DIFF: https://github.com/llvm/llvm-project/commit/4f01a02d738b033c10bfed5b47014fc197509a4f.diff

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added a comment. So I added in the second case but commented it out as it gets misformatted. However it doesn't assert which was the alarming outcome. I have one other bug to clean up here and I am going to open a bug to fix the line breaking after initial { in certain cases since the

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp updated this revision to Diff 375546. carlosgalvezp added a comment. Rename Class to Struct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110614/new/ https://reviews.llvm.org/D110614 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualClassDestructorCheck.cpp

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1603-1604 + template + bool handleRem(const SymT *Sym, RangeSet Constraint) { +// a % b != 0 implies that a != 0. steakhal wrote: > Why is this not

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 375648. saiislam added a comment. fixed the typos in the test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files:

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1821-1823 +<< UDSuffixBuf << UDSuffix +<< SourceRange(UDSuffixTokLoc, UDSuffixTokLoc) +<< SourceRange(TokLoc, TokLoc); erichkeane

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kda : thanks for the builbot reference. The issue you're pointing at occurs *before* bd379915de38a9af3d65e19075a6a64ebbb8d6db which specifically fixes the issue spotted by the buildbot.

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis: fine on OSX: http://45.33.8.238/macm1/18808/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 ___

RE: [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[AMD Official Use Only] Hi George, I will do it now ... -Original Message- From: Giorgis Georgakoudis via Phabricator Sent: Tuesday, September 28, 2021 1:30 PM To: georgakoud...@llnl.gov; jdoerf...@anl.gov; jhub...@vols.utk.edu Cc: llvm-comm...@lists.llvm.org;

[PATCH] D109967: Simplify handling of builtin with inline redefinition

kda added a comment. Broke fast buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/12360 reverting... A guide to reproducing sanitizer bots can be found here: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] fd582ee - [CUDA] Move CUDA SDK include path further down the include search path.

Author: Artem Belevich Date: 2021-09-28T11:29:28-07:00 New Revision: fd582eeffe582665eacac522617a15e17e9872cd URL: https://github.com/llvm/llvm-project/commit/fd582eeffe582665eacac522617a15e17e9872cd DIFF:

[PATCH] D110596: [CUDA] Move CUDA SDK include path further down the include search path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd582eeffe58: [CUDA] Move CUDA SDK include path further down the include search path. (authored by tra). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 9b944c1 - Revert "Add support for `NOLINTBEGIN` ... `NOLINTEND` comments"

Author: Aaron Ballman Date: 2021-09-28T14:49:27-04:00 New Revision: 9b944c184396ce55a3ad608779cc326ba12c9ee3 URL: https://github.com/llvm/llvm-project/commit/9b944c184396ce55a3ad608779cc326ba12c9ee3 DIFF: https://github.com/llvm/llvm-project/commit/9b944c184396ce55a3ad608779cc326ba12c9ee3.diff

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 375667. Conanap added a comment. Added context, changed var names in aptterns CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap marked 2 inline comments as done. Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:4150 +0))>; +def : Pat<(v4i32 (insertelt v4i32:$VEC, DblToUInt.A, 0)), + (v4i32 (XXINSERTW v4i32:$VEC,

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1821-1823 +<< UDSuffixBuf << UDSuffix +<< SourceRange(UDSuffixTokLoc, UDSuffixTokLoc) +<< SourceRange(TokLoc, TokLoc); aaron.ballman

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:876 +/// In C++20: +/// template-head: [C++ temp.pre] +/// template '<' template-parameter-list '>' requires-clause[opt]

[clang] 0d76d48 - Revert "Simplify handling of builtin with inline redefinition"

Author: Kevin Athey Date: 2021-09-28T11:30:37-07:00 New Revision: 0d76d4833dd2815e0b1c786250f474d222f6a0a1 URL: https://github.com/llvm/llvm-project/commit/0d76d4833dd2815e0b1c786250f474d222f6a0a1 DIFF: https://github.com/llvm/llvm-project/commit/0d76d4833dd2815e0b1c786250f474d222f6a0a1.diff

[PATCH] D110364: [clang] Rework dontcall attributes

aeubanks created this revision. Herald added subscribers: ormris, dexonsmith, jdoerfert, pengfei, steven_wu, hiraditya. aeubanks updated this revision to Diff 374663. aeubanks added a comment. aeubanks added reviewers: dblaikie, nickdesaulniers. aeubanks published this revision for review. Herald

[PATCH] D110364: [clang] Rework dontcall attributes

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. thanks for the patch! Comment at: llvm/lib/IR/DiagnosticInfo.cpp:408-427 + if (F->hasFnAttribute("dontcall-error")) { +unsigned LocCookie = 0; +

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 375666. jozefl marked 5 inline comments as done. jozefl added a comment. Thanks, good points, I have addressed them in this updated patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. In D109703#3018935 , @krisb wrote: > @dblaikie yeah, the problem(s) seemed easier and smaller :( > > Basically, we have two issues with local scopes here: > (1) function-scoped entities like static variables, type >

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

martong added a comment. Thanks Vince! Nice work! Do you think it would be worth to have a test that checks the equality of a double pointer and a bi-dimensional array? Something like: void struct_pointer_canon(struct s **ps) { struct s ss = **ps; clang_analyzer_eval(&(ps[0][0].v) ==

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 375672. saiislam added a comment. fixed nvptx test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375645. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files:

[clang] c3717b6 - Simplify handling of builtin with inline redefinition

Author: serge-sans-paille Date: 2021-09-28T21:00:47+02:00 New Revision: c3717b6858d32d64514a187ede1a77be8ba4e542 URL: https://github.com/llvm/llvm-project/commit/c3717b6858d32d64514a187ede1a77be8ba4e542 DIFF:

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added a comment. Ok, Aaron and I are pretty confused here I think (based on offline discussions), so I'm hoping for some guidance. `ParseTemplateTemplateParameter` does all the work to parse a template-template parameter, then calls `ActOnTemplateTemplateParameter`, which handles

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ronlieb added a comment. i backed up to your reverted patch, and applied this one. I see some new errors libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target.cpp libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_data.cpp libomptarget :: amdgcn-amd-amdhsa ::

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers created this revision. vabridgers added reviewers: steakhal, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision.

[clang] bd37991 - Refine the constraint for isInlineBuiltinDeclaration

Author: serge-sans-paille Date: 2021-09-28T16:07:33+02:00 New Revision: bd379915de38a9af3d65e19075a6a64ebbb8d6db URL: https://github.com/llvm/llvm-project/commit/bd379915de38a9af3d65e19075a6a64ebbb8d6db DIFF:

[clang] 1cd3ae0 - Fix missing return from 9324cc2ca951fe5fe11c85470cb08e699c59499c

Author: Erich Keane Date: 2021-09-28T07:30:06-07:00 New Revision: 1cd3ae019892c81a8a81daf4e2baffa3be6270db URL: https://github.com/llvm/llvm-project/commit/1cd3ae019892c81a8a81daf4e2baffa3be6270db DIFF: https://github.com/llvm/llvm-project/commit/1cd3ae019892c81a8a81daf4e2baffa3be6270db.diff

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1541 + if (IsConsteval && NotLocation.isValid()) { +if (ElseStmt.isUnset()) + ElseStmt = Actions.ActOnNullStmt(ThenStmtLoc); aaron.ballman wrote: > cor3ntin wrote: > >

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers planned changes to this revision. vabridgers added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 ___ cfe-commits mailing list

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen updated this revision to Diff 375619. ychen marked an inline comment as done. ychen added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files:

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane updated this revision to Diff 375680. erichkeane added a comment. Moments after my last comment, i figured out the scope issue, which makes the names in the template-template-parameter parameter-list in scope for this requires clause. I don't think it makes SENSE that this is the

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Please see comments inline Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:43 +/// std::lower_bound is used to perform an efficient binary search on the data. +static

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

aaron.ballman added a comment. Btw, the CI failure for `x64 debian > Clang.SemaTemplate::concepts.cpp` looks relevant. Not certain why I don't see a similar failure for Windows though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110641/new/ https://reviews.llvm.org/D110641

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman added a comment. I had to revert in 9b944c184396ce55a3ad608779cc326ba12c9ee3 because there are testing failures. FAIL: Clang Tools :: clang-tidy/infrastructure/nolintbeginend.cpp (1 of 1)

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis if rG1ecb1bc3e214 doesn't work, I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

erichkeane added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1821-1823 +<< UDSuffixBuf << UDSuffix +<< SourceRange(UDSuffixTokLoc, UDSuffixTokLoc) +<< SourceRange(TokLoc, TokLoc); cor3ntin wrote:

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:108 + unsigned CharWidth, DiagnosticsEngine *Diags, + const LangOptions , bool Unevaluated) { const char *EscapeBegin = ThisTokBuf; cor3ntin wrote:

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3022209 , @vsapsai wrote: > That patch looks correct, I was experimenting with exactly the same local > change. Have you tried D110123 on your > original build? In my testing with

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:876 +/// In C++20: +/// template-head: [C++ temp.pre] +/// template '<' template-parameter-list '>' requires-clause[opt] aaron.ballman wrote: > Rather than duplicate

[clang] c6edf26 - [docs ]Fix indentation

Author: Akira Hatanaka Date: 2021-09-28T11:31:39-07:00 New Revision: c6edf26f9a283564a5697068c845a8ff03386086 URL: https://github.com/llvm/llvm-project/commit/c6edf26f9a283564a5697068c845a8ff03386086 DIFF:

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. Avoiding serializing external methods in `ASTMethodPoolTrait` is working successfully, although the times are not as good as using set deduplication: | **file** | **baseline** | **set dedupe** | **no external** | | Total | 149.68 | 92.97 | 109.83

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added a comment. In D110641#3028173 , @aaron.ballman wrote: > Btw, the CI failure for `x64 debian > Clang.SemaTemplate::concepts.cpp` looks > relevant. Not certain why I don't see a similar failure for Windows though. Looks like I miseed up

[PATCH] D109967: Simplify handling of builtin with inline redefinition

thakis added a comment. This breaks tests on windows and macOS eg http://45.33.8.238/win/46075/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/

[PATCH] D109967: Simplify handling of builtin with inline redefinition

thakis added a comment. For macOS, see eg http://45.33.8.238/macm1/18806/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 ___ cfe-commits mailing

[clang] 1ecb1bc - Fix memcpy-nobuiltin.c test case

Author: serge-sans-paille Date: 2021-09-28T21:55:42+02:00 New Revision: 1ecb1bc3e214c8da53a7fda14f428786441109d7 URL: https://github.com/llvm/llvm-project/commit/1ecb1bc3e214c8da53a7fda14f428786441109d7 DIFF:

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. In D108643#3026550 , @rjmccall wrote: > I think it would be better to provide a generic ABI specification that is > designed to "lower" `_BitInt` types into more basic concepts that ABIs > typically already have rules for.

[clang] 27a972a - Diagnose -Wunused-value based on CFG reachability

Author: Yuanfang Chen Date: 2021-09-28T10:00:15-07:00 New Revision: 27a972a699cd875c7fa9114dc0888015cd724f31 URL: https://github.com/llvm/llvm-project/commit/27a972a699cd875c7fa9114dc0888015cd724f31 DIFF: https://github.com/llvm/llvm-project/commit/27a972a699cd875c7fa9114dc0888015cd724f31.diff

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 375634. ggeorgakoudis added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Update memory allocation for aggregate argument. Introduce runtime interface to allocate from local memory, when in SPMD mode, or heap, when

[PATCH] D110596: [CUDA] Move CUDA SDK include path further down the include search path.

tra added a comment. @tambre I've tested the patch on experimental debian docker and it appears to work with a symlink `/usr/lib/cuda/include` ->`/usr/include`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110596/new/

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:151 + // allocas. + Builder.CreateStore(Init, Var); } hsmhsm wrote: > jdoerfert wrote: > > hsmhsm wrote: > > > jdoerfert wrote: > > > > I'm not even sure this is necessarily correct. >

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108299/new/ https://reviews.llvm.org/D108299

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

xgupta added a comment. nice work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei marked 4 inline comments as done. masoud.ataei added a comment. Sorry that it took me so long to reply reviews. Thank you for reviewing this patch. Comment at: clang/include/clang/Driver/Options.td:1732-1733 NegFlag>; -def fapprox_func : Flag<["-"],

  1   2   3   >