[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 -- ... +- -Wbool-operation warns about use of bitwise with boolean operands -Wbitwise-instead-of-logical (part of -Wbool-operation) warns … ? Repository: rG LLVM Github

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru added a comment. @xbolva00 sorry but you would like -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands which have side effects or -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 377500. saiislam marked 3 inline comments as done. saiislam added a comment. Function name refactoring for AddStaticDeviceLibs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

linjamaki added a comment. In D110685#3044993 , @Anastasia wrote: > Ok, is the idea to deprecate this flag once we switch to `llc` by default > then? The idea is to remove the flags if no one else needs them when the HIPSPV tool chain switches over to

[PATCH] D111224: [clang] Traverse enum integer-base specifiers in RAV

kadircet created this revision. kadircet added reviewers: nridge, hokein. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Visit enum integer-base specifiers

[PATCH] D111224: [clang] Traverse enum integer-base specifiers in RAV

kadircet updated this revision to Diff 377527. kadircet added a comment. - Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111224/new/ https://reviews.llvm.org/D111224 Files:

[clang] 49dbde9 - [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

Author: Amy Kwan Date: 2021-10-06T08:49:37-05:00 New Revision: 49dbde9c9e5149bcc8b906f7dbd040be76a2a267 URL: https://github.com/llvm/llvm-project/commit/49dbde9c9e5149bcc8b906f7dbd040be76a2a267 DIFF: https://github.com/llvm/llvm-project/commit/49dbde9c9e5149bcc8b906f7dbd040be76a2a267.diff

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

This revision was automatically updated to reflect the committed changes. Closed by commit rG49dbde9c9e51: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[libunwind] 60fe1f5 - [runtimes][ci] Run the tests for libunwind in the CI

Author: Louis Dionne Date: 2021-10-06T11:25:26-04:00 New Revision: 60fe1f59d08b815a280761e625d12a74a501f444 URL: https://github.com/llvm/llvm-project/commit/60fe1f59d08b815a280761e625d12a74a501f444 DIFF: https://github.com/llvm/llvm-project/commit/60fe1f59d08b815a280761e625d12a74a501f444.diff

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

Anastasia added a comment. In D110618#3039275 , @linjamaki wrote: > In D110618#3032899 , @Anastasia > wrote: > >> Considering that SPIR-V translation step is also required for other >> languages would it make

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru updated this revision to Diff 377483. sylvestre.ledru added a comment. Take in account the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 Files: clang/docs/ReleaseNotes.rst

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru updated this revision to Diff 377486. sylvestre.ledru added a comment. add "which have side effects" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 Files: clang/docs/ReleaseNotes.rst

[PATCH] D111218: [AMDGPU][OpenMP] Remove optnone from outlined functions

jdoerfert added a comment. What if we track down the problem instead? This will simply pop up again in O0 user code, no? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111218/new/ https://reviews.llvm.org/D111218

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in bader

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

JonChesterfield edited reviewers, added: tianshilei1992, ye-luo, grokos; removed: ggeorgakoudis. JonChesterfield added a comment. Not pretty but unblocking D102107 is important. Could you write up your current understanding of what we're miscompiling for

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

pdhaliwal planned changes to this revision. pdhaliwal added a comment. I don't have any concrete evidence but I have some doubt on presence of function pointers causing backend to behave improperly. Also, here removing optnone alone suffices to fix the issue. Repository: rG LLVM Github

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

pdhaliwal updated this revision to Diff 377502. pdhaliwal added a comment. Only removing optnone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111218/new/ https://reviews.llvm.org/D111218 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index:

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

aaron.ballman added a comment. I think this is reasonable, but can you update the summary to also explain why these changes are useful? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a nit, but please give some time for @rjmccall to review as well in case he spots something I've missed. Comment at: clang/lib/Sema/TreeTransform.h:3844 + if (auto *AIL = dyn_cast(Init)) { +

[PATCH] D111190: Comment parsing: Complete list of Doxygen commands

aaronpuchert updated this revision to Diff 377492. aaronpuchert added a comment. Also support `\ifnot` but give up on treating `\if`/`\endif` as `VerbatimBlockCommand`. That's not meaningful anyway if we don't understand `\else` or `\endif`. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3557 +def warn_availability_fuchsia_unavailable_minor : Warning< + "Fuchsia API Level only support 'major', not '.minor[.subminor]'">, + InGroup;

[PATCH] D111218: [AMDGPU][OpenMP] Remove optnone from outlined functions

JonChesterfield added a comment. Root cause would definitely be better but we don't have one at present and would like to unblock the linked diff. O0 is likely to have more problems than just this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 377504. carlosgalvezp added a comment. Remove redundant "*" if branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/ https://reviews.llvm.org/D111208 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 377551. carlosgalvezp added a comment. Fixed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/ https://reviews.llvm.org/D111208 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. In D108003#3044853 , @sylvestre.ledru wrote: > It found a few issues on Firefox: > https://bugzilla.mozilla.org/show_bug.cgi?id=1734285 > > I think it should be added it in the release notes: > https://reviews.llvm.org/D111215

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

martong updated this revision to Diff 377482. martong added a comment. - Rebase - Mark the dump methods with LLVM_DUMP_METHOD - Add Range::dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110911/new/ https://reviews.llvm.org/D110911 Files:

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

Anastasia added a comment. Herald added a subscriber: ormris. Ok, is the idea to deprecate this flag once we switch to `llc` by default then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110685/new/ https://reviews.llvm.org/D110685

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

jdoerfert added a comment. I first had to read up on pop_macro -.-. Still unsure if it is OK to push it once and pop it twice, that works fine? Can't we move the string include earlier, grouped with stdlib and cmath? then we don't need to play with __THROW twice. Other than that it seems

[PATCH] D111224: [clang] Traverse enum integer-base specifiers in RAV

hokein added a comment. the RAV change looks good. I think it might be worth to split this patch (one for RAV, one for libindex). Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1866 + if (auto *TSI = D->getIntegerTypeSourceInfo()) +

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:72 + multiple warnings in the same line. - Added support for `NOLINTBEGIN` ... `NOLINTEND` comments to suppress Clang-Tidy warnings over multiple lines. Please

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

pdhaliwal added a comment. I have created a patch (D111218 ) with fix for amdgcn. This is a temporary fix. I will still keep on looking into it until I find a real root cause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111232: [clang] Don't mark _ReadBarrier(), _ReadWriteBarrier(), _WriteBarrier() deprecated

thakis created this revision. thakis added reviewers: hans, rnk. thakis requested review of this revision. It's true that docs.microsoft.com says: """The _ReadBarrier, _WriteBarrier, and _ReadWriteBarrier compiler intrinsics and the MemoryBarrier macro are all deprecated and should not be used.

[clang] f9457f1 - [clang] Don't mark _ReadBarrier, _ReadWriteBarrier, _WriteBarrier deprecated

Author: Nico Weber Date: 2021-10-06T10:50:02-04:00 New Revision: f9457f1f88b3e835fca8942b5272f3ecf26d4e98 URL: https://github.com/llvm/llvm-project/commit/f9457f1f88b3e835fca8942b5272f3ecf26d4e98 DIFF: https://github.com/llvm/llvm-project/commit/f9457f1f88b3e835fca8942b5272f3ecf26d4e98.diff

[PATCH] D111232: [clang] Don't mark _ReadBarrier(), _ReadWriteBarrier(), _WriteBarrier() deprecated

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9457f1f88b3: [clang] Dont mark _ReadBarrier, _ReadWriteBarrier, _WriteBarrier deprecated (authored by thakis). Herald added a project: clang.

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, jdoerfert, jhuber6, ggeorgakoudis. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald

[PATCH] D110676: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. I compared the auto generated check lines with original ones. Overall I think this will make life easier since it seems easier to inspect autogenerated lines than manually updating them.

[PATCH] D111232: [clang] Don't mark _ReadBarrier(), _ReadWriteBarrier(), _WriteBarrier() deprecated

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Sounds very reasonable to me. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111232/new/ https://reviews.llvm.org/D111232 ___ cfe-commits

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:677 + SwapOpts(Res); + bool Success2 = Parse(Res, GeneratedArgs1, Diags); + saudi wrote: > Hello, > > I encountered crashes on Windows targets, related to this line,

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. One small comment about side effects, otherwise LG. Please wait a +-day for potentional review comments. Comment at: clang/docs/ReleaseNotes.rst:54 -- ... +-

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

xbolva00 added a comment. First form is better I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] b9b90bb - [clang] Replace report_fatal_error(std::string) uses with report_fatal_error(Twine)

Author: Simon Pilgrim Date: 2021-10-06T11:43:19+01:00 New Revision: b9b90bb5426ffc23cf90f133a90d1469d263522c URL: https://github.com/llvm/llvm-project/commit/b9b90bb5426ffc23cf90f133a90d1469d263522c DIFF: https://github.com/llvm/llvm-project/commit/b9b90bb5426ffc23cf90f133a90d1469d263522c.diff

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

martong updated this revision to Diff 377495. martong marked 2 inline comments as done. martong added a comment. - Add better comments to `simplify` functions - Add a new check and explanation to the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:390-396 /// Try to simplify a given symbolic expression's associated value based on the /// constraints in State. This is needed because the Environment

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. I see the problem. It appears when you meet, say, '>' in a //true// branch and '<=' in a //false// branch which then turns into `>` again and trigger the flag, but shouldn't.

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

balazske added reviewers: aaron.ballman, martong, jranieri-grammatech, sammccall. balazske added a comment. Herald added a subscriber: rnkovacs. These options are added to make the configuration more comfortable if only functions are to be added or removed from the list. I plan another commit

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

kamaub created this revision. kamaub added reviewers: PowerPC, nemanjai, lei, stefanp. Herald added subscribers: shchenz, kbarton. kamaub requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The builtin __rlwnm is currently constrained to

[clang] b29186c - [analyzer] canonicalize special case of structure/pointer deref

Author: Vince Bridgers Date: 2021-10-06T05:18:27-05:00 New Revision: b29186c08ae230d0decbca67565be68919c6b24d URL: https://github.com/llvm/llvm-project/commit/b29186c08ae230d0decbca67565be68919c6b24d DIFF:

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

This revision was automatically updated to reflect the committed changes. Closed by commit rGb29186c08ae2: [analyzer] canonicalize special case of structure/pointer deref (authored by vabridgers, committed by einvbri vince.a.bridg...@ericsson.com). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Extend the check with option to include

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

martong updated this revision to Diff 377564. martong added a comment. - Update to use a single variable to track the state - Make CurrentOP `const` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110910/new/ https://reviews.llvm.org/D110910 Files:

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added a comment. In D104285#3044103 , @NoQ wrote: > Hey, I brought you some regressions! > >> ! In D104285#3044804 , @martong >> wrote: > > const VarDecl *VD = VR->getDecl()->getCanonicalDecl();

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. In D109144#3045883 , @bader wrote: > In D109144#3042247 , @Anastasia > wrote: > >> 1. Implementing SPIR-V target as SPIR target. @bader do you suggest that we >> add `spirv` triple

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks updated this revision to Diff 377633. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451 Files: clang/lib/CodeGen/CGBlocks.cpp clang/lib/CodeGen/CGCall.cpp

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra updated this revision to Diff 377573. tra edited the summary of this revision. tra added a comment. Added a missing push_macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110781/new/ https://reviews.llvm.org/D110781 Files:

[clang] afdac5f - [clang] Allow printing 64 bit ints in diagnostics

Author: Arthur Eubanks Date: 2021-10-06T09:53:47-07:00 New Revision: afdac5fbcb6a375245d435e4427086a376de59ff URL: https://github.com/llvm/llvm-project/commit/afdac5fbcb6a375245d435e4427086a376de59ff DIFF:

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

phosek added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia"; aaron.ballman wrote: > I

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka created this revision. vitalybuka added reviewers: morehouse, eugenis. Herald added a subscriber: mgorny. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This way is easier to

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8f6c85a831f: [analyzer][NFC] Add RangeSet::dump (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110911/new/

[clang] b8f6c85 - [analyzer][NFC] Add RangeSet::dump

Author: Gabor Marton Date: 2021-10-06T18:45:07+02:00 New Revision: b8f6c85a831ffb62563a519d1db0b8695c628def URL: https://github.com/llvm/llvm-project/commit/b8f6c85a831ffb62563a519d1db0b8695c628def DIFF: https://github.com/llvm/llvm-project/commit/b8f6c85a831ffb62563a519d1db0b8695c628def.diff

[clang] f0ffff4 - [CMake] Fix typo in error message for LLD in bootstrap builds.

Author: Frederic Cambus Date: 2021-10-06T22:38:12+05:30 New Revision: f043b765ee0484e5303edc82f9e528a3547e URL: https://github.com/llvm/llvm-project/commit/f043b765ee0484e5303edc82f9e528a3547e DIFF:

[PATCH] D110836: [CMake] Fix typo in error message for LLD in bootstrap builds.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf043b765: [CMake] Fix typo in error message for LLD in bootstrap builds. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra updated this revision to Diff 377587. tra added a comment. re-set __THROW to an empty value. It's still needed for CUDA-7.5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110781/new/ https://reviews.llvm.org/D110781 Files:

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

bader added a comment. In D109144#3042247 , @Anastasia wrote: > 1. Implementing SPIR-V target as SPIR target. @bader do you suggest that we > add `spirv` triple to clang and map it into SPIR taget or do you suggest > something different? What I have

[PATCH] D111242: Add `TypeLoc`-related matchers.

ymandel added a comment. Nice! Just some minor notes. Comment at: clang/docs/LibASTMatchersReference.html:636 -Matcherhttps://clang.llvm.org/doxygen/classclang_1_1Decl.html;>DeclblockDeclMatcherhttps://clang.llvm.org/doxygen/classclang_1_1BlockDecl.html;>BlockDecl...

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377650. vitalybuka added a comment. update a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. Thanks for working on this. Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCInstPrinter.cpp:161 // where th can be omitted when it is 0. dcbtst is the same. -

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110641/new/ https://reviews.llvm.org/D110641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

ASDenysPetrov added a comment. LGTM Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1129-1134 +// We use this variable to store the last queried operator (`QueriedOP`) +// for which the `getCmpOpState` returned with `Unknown`. If there are two +

[clang] a2796f1 - [Driver][test] Add Debian multiarch lib/clang/14.0.0/x86_64-linux-gnu and include/x86_64-linux-gnu/c++/v1 tests

Author: Fangrui Song Date: 2021-10-06T10:49:25-07:00 New Revision: a2796f1e86555fc0848b060a3bc0fe03e4ecf93b URL: https://github.com/llvm/llvm-project/commit/a2796f1e86555fc0848b060a3bc0fe03e4ecf93b DIFF: https://github.com/llvm/llvm-project/commit/a2796f1e86555fc0848b060a3bc0fe03e4ecf93b.diff

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

aaron.ballman added reviewers: erichkeane, rsmith. aaron.ballman added a comment. Thank you for this new feature work! Adding a few more reviewers to the mix. Can you also add a release note for the new functionality? Comment at:

[PATCH] D111242: Add `TypeLoc`-related matchers.

ymandel added a comment. Also, please list the new matchers in the patch description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111242/new/ https://reviews.llvm.org/D111242 ___ cfe-commits mailing

[clang] f37e8b0 - [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

Author: Michael Kruse Date: 2021-10-06T10:49:07-05:00 New Revision: f37e8b0b831e61d3b6033829fff05d6d193ab735 URL: https://github.com/llvm/llvm-project/commit/f37e8b0b831e61d3b6033829fff05d6d193ab735 DIFF: https://github.com/llvm/llvm-project/commit/f37e8b0b831e61d3b6033829fff05d6d193ab735.diff

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf37e8b0b831e: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

martong added a comment. Thanks for the review Denys! I've updated accordingly to your suggestion, it is certainly more efficient. However, I've found your solution more difficult to follow, thus I've added some more explanatory comments. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110911/new/ https://reviews.llvm.org/D110911

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105690/new/ https://reviews.llvm.org/D105690

[PATCH] D111207: Driver: Add a gcc equivalent triple to the list of triples to search

MaskRay added a comment. I think we should reduce normalization for include/library path detection in the clang driver (D110663 ), instead of adding more customization for each platform. Some clang driver code uses os and environment to check feature

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

rnk added a comment. In D95#3044594 , @mstorsjo wrote: > This looks ok to me I guess. Technically in this case, this is pretty much > equivalent to `#ifdef _WIN32`, i.e. any form when running on windows, where > the process considers itself windows

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 created this revision. jcking1034 added reviewers: ymandel, tdl-g. jcking1034 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Contributes several matchers that involve `TypeLoc`s. Repository: rG LLVM Github Monorepo

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 updated this revision to Diff 377590. jeremyd2019 added a comment. Switched to #ifdef _WIN32 instead of checking triple CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95/new/ https://reviews.llvm.org/D95 Files: clang/lib/Tooling/JSONCompilationDatabase.cpp

[PATCH] D111134: Add basic aarch64-none-elf bare metal driver.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:133 + + if (Triple.getVendor() != llvm::Triple::UnknownVendor) +return false; Is vendor check necessary? Comment at: clang/test/Driver/baremetal.cpp:105

[clang] 8d64314 - Reland [IR] Increase max alignment to 4GB

Author: Arthur Eubanks Date: 2021-10-06T11:03:51-07:00 New Revision: 8d64314ffea55f2ad94c1b489586daa8ce30f451 URL: https://github.com/llvm/llvm-project/commit/8d64314ffea55f2ad94c1b489586daa8ce30f451 DIFF:

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

erichkeane added a comment. I agree with aaron, the ParseUsingDeclaration bit should be aware of the DeclaratorContext and emit the error there, rather than try to parse it as whatever and THEN error. The problem is the user-interface at that point, which is to spend a few cycles correcting

[PATCH] D110451: [IR] Increase max alignment to 4GB

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:179 -static const unsigned kAllocaRzSize = 32; +static const uint64_t kAllocaRzSize = 32; You may switch to namespace scope/global `constexpr` while touching

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

Conanap created this revision. Conanap added reviewers: nemanjai, jsji, PowerPC. Conanap added projects: clang, LLVM, PowerPC. Herald added subscribers: kbarton, hiraditya. Conanap requested review of this revision. On AIX, the system assembler does not support the extended mnemonics `dcbtt` and

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3041672 , @phosek wrote: > In D110663#3041379 , @MaskRay wrote: > >> In D110663#3029577 , @phosek wrote: >> >>> This is going to break

[clang] 792be5d - [analyzer][solver] Fix CmpOpTable handling bug

Author: Gabor Marton Date: 2021-10-06T18:28:03+02:00 New Revision: 792be5df92e8d068ca32444383bc4e9e7f024bd8 URL: https://github.com/llvm/llvm-project/commit/792be5df92e8d068ca32444383bc4e9e7f024bd8 DIFF: https://github.com/llvm/llvm-project/commit/792be5df92e8d068ca32444383bc4e9e7f024bd8.diff

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG792be5df92e8: [analyzer][solver] Fix CmpOpTable handling bug (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:1372 +(VMANDN_MM VR:$vd, VR:$vs2, VR:$vs1), 0>; + +def : InstAlias<"vmornot.mm $vd, $vs2, $vs1", Probably not worth having a blank line between vmandnot and

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra added a comment. In D110781#3045280 , @jdoerfert wrote: > I first had to read up on pop_macro -.-. Still unsure if it is OK to push it > once and pop it twice, that works fine? Good catch. > Can't we move the string include earlier, grouped with

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

aaron.ballman added a comment. I think this is missing changes to the documentation as well. In D111228#3045319 , @balazske wrote: > These options are added to make the configuration more comfortable if only > functions are to be added or removed from

[PATCH] D110451: [IR] Increase max alignment to 4GB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf84c1fe7813: [IR] Increase max alignment to 4GB (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] df84c1f - [IR] Increase max alignment to 4GB

Author: Arthur Eubanks Date: 2021-10-06T09:54:14-07:00 New Revision: df84c1fe78130a86445d57563dea742e1b85156a URL: https://github.com/llvm/llvm-project/commit/df84c1fe78130a86445d57563dea742e1b85156a DIFF:

[clang] 72cf8b6 - Revert "[IR] Increase max alignment to 4GB"

Author: Arthur Eubanks Date: 2021-10-06T10:21:35-07:00 New Revision: 72cf8b60445441635745ee65ff0c1f9c1a4418fe URL: https://github.com/llvm/llvm-project/commit/72cf8b60445441635745ee65ff0c1f9c1a4418fe DIFF:

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

aeubanks created this revision. aeubanks added reviewers: hans, rsmith. Herald added a reviewer: aaron.ballman. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Followup to D110451 which set

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:553 +def err_expected_alias_after_using_in_init_statement : Error< + "expected alias declaration after using in init statement">; +def ext_alias_in_init_statement : ExtWarn<

[PATCH] D110252: Added note about Whatstyle and Unformat

HazardyKnusperkeks resigned from this revision. HazardyKnusperkeks added a comment. I too think this should not directly mentioned in clang-format documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110252/new/

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 377566. ricejasonf marked an inline comment as done. ricejasonf added a comment. Remove unnecessary cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 Files:

  1   2   >