[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

dblaikie added a comment. Plan is still to address the "this only works with disable free" issue? (I've some preference that be addressed before this feature is turned on by default) & is there a flag to pass to turn this off if someone had trouble with it? (doesn't necessarily have to be, but

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 379284. carlosgalvezp added a comment. Expand documentation to make it clear that globbing is supported for NOLINT, NOLINTNEXTLINE as well as NOLINTBEGIN/END. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks for fixing this! Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:351 + EXPECT_DECLS("TemplateArgumentLoc", {"template class ...T"}); +

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. Yes, I think it would be fine to fork off a conversation about what the ABI should be; I didn't meant to completely derail this patch. To be frank, my expectation was that more of this was already settled and documented, so we just needed to add that documentation

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Excellent! All lines are covered. Great job. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1619 + return true; +const SymExpr *LHS =

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. To confirm if (x) for(int i=0;i<10;i++) foo(); will be transformed to if (x) for (int i = 0; i < 10; i++) { foo(); } but this itself will NOT be transformed to if (x) { for (int i = 0; i < 10; i++) { foo(); }

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 379321. mubashar_ added a comment. Added crypto and non-crypto related tests for mcpu in aarch64-cpus.c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst

[clang] 28fa77f - [clang][modules] Avoid using uninitialized SourceLocation

Author: Jan Svoboda Date: 2021-10-13T11:24:01+02:00 New Revision: 28fa77feeb7db46abea1a6699d7a88a02d8dab46 URL: https://github.com/llvm/llvm-project/commit/28fa77feeb7db46abea1a6699d7a88a02d8dab46 DIFF: https://github.com/llvm/llvm-project/commit/28fa77feeb7db46abea1a6699d7a88a02d8dab46.diff

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

kbobyrev updated this revision to Diff 379318. kbobyrev added a comment. Rename the test to have more meaning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111698/new/ https://reviews.llvm.org/D111698 Files:

[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

mstorsjo created this revision. mstorsjo added reviewers: MaskRay, rnk. Herald added a subscriber: kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. This doesn't practically affect the code generation. Repository: rG LLVM Github Monorepo

[PATCH] D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Do you need me to commit on your behalf? I'm happy to do so, but given the number of quality submissions you've had, I'm wondering if you'd like to obtain

[libunwind] df3de76 - [libc++abi] Change LIBCXXABI_NO_TIMER to LIBCXXABI_USE_TIMER

Author: Louis Dionne Date: 2021-10-13T08:02:31-04:00 New Revision: df3de7647e034797ae3c965d6737bc0a4bc7a779 URL: https://github.com/llvm/llvm-project/commit/df3de7647e034797ae3c965d6737bc0a4bc7a779 DIFF: https://github.com/llvm/llvm-project/commit/df3de7647e034797ae3c965d6737bc0a4bc7a779.diff

[PATCH] D111245: [analyzer] Bifurcate on getenv() calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7fc150309d27: [analyzer] Bifurcate on getenv() calls (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D111296: [analyzer] Introduce the assume-controlled-environment config option

This revision was automatically updated to reflect the committed changes. Closed by commit rGedde4efc66df: [analyzer] Introduce the assume-controlled-environment config option (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 379329. kito-cheng marked 11 inline comments as done. kito-cheng added a comment. Changes: - Address @craig.topper's comment - Add XLen to constructor of RISCVISAInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:388 +const std::vector ) { + std::unique_ptr ISAInfo(new RISCVISAInfo()); + assert(XLen == 32 || XLen == 64); craig.topper wrote: > Use > > ``` > auto

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. In D109144#3050945 , @linjamaki wrote: >> What I have in mind is to continue using SPIR target for now (until SPIR-V >> back-end is added). > >> For instance, SYCL compiler emits code for SPIR target and code format is >>

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

urnathan commandeered this revision. urnathan edited reviewers, added: rsmith; removed: urnathan. urnathan added a comment. Taking control to close it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102650/new/ https://reviews.llvm.org/D102650

[PATCH] D111711: [clangd] IncludeCleaner: ReferencedLocationCrawler should handle FunctionDecls

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader

Sockke updated this revision to Diff 379296. Sockke edited the summary of this revision. Sockke added a reviewer: MTC. Sockke added a comment. Update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111625/new/ https://reviews.llvm.org/D111625 Files:

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. In D95168#3060296 , @tiagoma wrote: > go for it @tiagoma to be honest this actually works pretty well, I've been using it in a private build on the large project I work on and I've been ripping through some of the

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

kbobyrev updated this revision to Diff 379317. kbobyrev added a comment. Mention the ScratchBuffer explicitly in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111698/new/ https://reviews.llvm.org/D111698 Files:

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1669-1711 // The array index has to be known. if (auto CI = R->getIndex().getAs()) { -// If it is not an array, return Undef. -QualType T =

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

martong added a comment. I am close to accepting this. However, D111542 should be its parent patch. I think similar issues could arise here as well, so, redecl chain tests would be really beneficial. CHANGES SINCE LAST ACTION

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

martong added a comment. Could you please rebase on top of D111542 ? That would make the changes direct and clear and the review would be easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111654/new/

[clang-tools-extra] fba563e - [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

Author: Adam Czachorowski Date: 2021-10-13T13:15:36+02:00 New Revision: fba563e92b6412f49e7e49299d3d27f04f2e1400 URL: https://github.com/llvm/llvm-project/commit/fba563e92b6412f49e7e49299d3d27f04f2e1400 DIFF:

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfba563e92b64: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111708: [libTooling] Add "switch"-like Stencil combinator

ymandel created this revision. ymandel added a reviewer: tdl-g. ymandel requested review of this revision. Herald added a project: clang. Adds `selectBound`, a `Stencil` combinator that allows the user to supply multiple alternative cases, discriminated by bound node IDs. Repository: rG LLVM

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12798 + /// Access to SYCL kernels. + SmallVectorImpl () { return SYCLKernels; } + `ArrayRef getSYCLKernels()` Comment at: clang/lib/Sema/SemaSYCL.cpp:90 + +class

[clang] d45526e - [doc][clang] correct version for p0388 implementation

Author: Nathan Sidwell Date: 2021-10-13T04:12:07-07:00 New Revision: d45526e6c34a82376f05b702a2969b4c4970cb1c URL: https://github.com/llvm/llvm-project/commit/d45526e6c34a82376f05b702a2969b4c4970cb1c DIFF:

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

adamcz updated this revision to Diff 379335. adamcz marked an inline comment as done. adamcz added a comment. removed unnecessary Flags.clear() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111648/new/ https://reviews.llvm.org/D111648 Files:

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

urnathan abandoned this revision. urnathan added a comment. Implemented as part of D102645 , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102650/new/ https://reviews.llvm.org/D102650

[clang] 7fc1503 - [analyzer] Bifurcate on getenv() calls

Author: Balazs Benics Date: 2021-10-13T10:50:26+02:00 New Revision: 7fc150309d27b0f98239bec758b895efda8c0481 URL: https://github.com/llvm/llvm-project/commit/7fc150309d27b0f98239bec758b895efda8c0481 DIFF: https://github.com/llvm/llvm-project/commit/7fc150309d27b0f98239bec758b895efda8c0481.diff

[clang] edde4ef - [analyzer] Introduce the assume-controlled-environment config option

Author: Balazs Benics Date: 2021-10-13T10:50:26+02:00 New Revision: edde4efc66df2257f0b2351d5f98b4fbb2ced620 URL: https://github.com/llvm/llvm-project/commit/edde4efc66df2257f0b2351d5f98b4fbb2ced620 DIFF: https://github.com/llvm/llvm-project/commit/edde4efc66df2257f0b2351d5f98b4fbb2ced620.diff

[PATCH] D33029: [clang-format] add option for dangling parenthesis

Det87 added a comment. @catskul yeah, are we waiting for a response, or is this good to go? Tagging everybody who might know something. @seesemichaelj @djasper @jakar @blandcr @MyDeveloperDay @bbassi CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/

[clang] b8ff780 - [clang][NFC] Correct doc markup

Author: Nathan Sidwell Date: 2021-10-13T04:20:15-07:00 New Revision: b8ff780f205022d354b7604ebf1307e696804ac7 URL: https://github.com/llvm/llvm-project/commit/b8ff780f205022d354b7604ebf1307e696804ac7 DIFF:

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:124 const auto = SM.getSLocEntry(FID).getExpansion(); -add(Exp.getSpellingLoc()); +if (!SM.isWrittenInScratchSpace(Exp.getSpellingLoc())) + add(Exp.getSpellingLoc());

[PATCH] D111711: [clangd] IncludeCleaner: ReferencedLocationCrawler should handle FunctionDecls

kbobyrev updated this revision to Diff 379367. kbobyrev added a comment. Make the logic correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111711/new/ https://reviews.llvm.org/D111711 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:45 + /// accessor class. + static bool isSyclAccessorType(const QualType ); + erichkeane wrote: > Isn't there a big rewrite going on downstream of these with > `sycl_special_class`? Why are

[PATCH] D111725: [clang][deps] NFC: Rename scanning CompilerInstance

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner works with multiple instances of `Compiler{Instance,Invocation}`.

[clang] aae776a - [clang] NFC: Move class to make it reusable

Author: Jan Svoboda Date: 2021-10-13T18:09:52+02:00 New Revision: aae776a5341ccf90a2c0a4e2e952ae4ec5ffb422 URL: https://github.com/llvm/llvm-project/commit/aae776a5341ccf90a2c0a4e2e952ae4ec5ffb422 DIFF: https://github.com/llvm/llvm-project/commit/aae776a5341ccf90a2c0a4e2e952ae4ec5ffb422.diff

[clang] 08c8016 - [clang][modules] Cache loads of modules imported by PCH

Author: Jan Svoboda Date: 2021-10-13T18:09:52+02:00 New Revision: 08c8016cfb2af9463514709271ae8c4ad6b19377 URL: https://github.com/llvm/llvm-project/commit/08c8016cfb2af9463514709271ae8c4ad6b19377 DIFF: https://github.com/llvm/llvm-project/commit/08c8016cfb2af9463514709271ae8c4ad6b19377.diff

[PATCH] D111560: [clang][modules] Cache loads of modules imported by PCH

This revision was automatically updated to reflect the committed changes. Closed by commit rG08c8016cfb2a: [clang][modules] Cache loads of modules imported by PCH (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D111560?vs=378945=379431#toc Repository: rG LLVM

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

martong updated this revision to Diff 379434. martong marked 5 inline comments as done. martong added a comment. - Use getAsSymbol to initialize the simplified member symbol - Add some more explanation to ento::simplify - Add a comment about checking only feasiblity - Add a new test case for the

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:392-397 +/// Try to simplify a given symbolic expression based on the constraints in +/// State. This is needed because the Environment bindings are not

[PATCH] D33029: [clang-format] add option for dangling parenthesis

catskul added inline comments. Comment at: include/clang/Format/Format.h:793 + /// \endcode + bool DanglingParenthesis; + seesemichaelj wrote: > catskul wrote: > > stringham wrote: > > > djasper wrote: > > > > stringham wrote: > > > > > djasper wrote: > > > >

[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111707/new/ https://reviews.llvm.org/D111707

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

eugenis added a comment. Right, but a cache for SanitizerArgs is not enough to avoid repeated diagnostics, is it? Ex. if I request a non-existing sanitizer, I think I would get errors from host arg parsing, as well as from each of device1 and device2, because each device will have a unique

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

tra added a comment. I think for a Sema change there should be a **Sema** test, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 ___ cfe-commits mailing

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 379444. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. adding codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files:

[clang-tools-extra] ea72b55 - bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader

Author: liuke Date: 2021-10-13T12:31:02-04:00 New Revision: ea72b55b5c7c281cb21bb7bd50e6e039ca63dfe8 URL: https://github.com/llvm/llvm-project/commit/ea72b55b5c7c281cb21bb7bd50e6e039ca63dfe8 DIFF: https://github.com/llvm/llvm-project/commit/ea72b55b5c7c281cb21bb7bd50e6e039ca63dfe8.diff LOG:

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

yaxunl added a comment. we need a codegen test for the case Comment at: clang/lib/Sema/SemaExpr.cpp:6550 // type to a default address space pointee type -if (ArgAS != LangAS::Default || ParamAS == LangAS::Default) continue; we still

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

Anastasia added a comment. In D110618#3054257 , @pekka.jaaskelainen wrote: >> I don't feel it is different for OpenCL though... I am not in favour of >> repeating the same functionality for every language since the requirement >> will be likely

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

rsmith added a comment. I'm concerned that this is adding complexity to paper over a bug elsewhere. Creating an `IdentifierInfo` should never cause unrelated uses of that identifier to change their meaning or behavior. My guess is that there's a bug in how we resolve or merge identifier

[clang] 1bef229 - [clang] Delete unused class DiagsUninitializedSeveretyRAII

Author: Nico Weber Date: 2021-10-13T14:27:26-04:00 New Revision: 1bef22950a5c72fe630f4d6aa7f161bc1e2cb2d1 URL: https://github.com/llvm/llvm-project/commit/1bef22950a5c72fe630f4d6aa7f161bc1e2cb2d1 DIFF: https://github.com/llvm/llvm-project/commit/1bef22950a5c72fe630f4d6aa7f161bc1e2cb2d1.diff

[PATCH] D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader

aaron.ballman closed this revision. aaron.ballman added a comment. In D111625#3061736 , @Sockke wrote: > In D111625#3060978 , @aaron.ballman > wrote: > >> LGTM, thank you! Do you need me to commit on your

[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

MaskRay added inline comments. Comment at: clang/test/Driver/pic.c:322 // RUN: | FileCheck %s --check-prefix=CHECK-PIC2 +// RUN: %clang -c %s -target aarch64-windows-msvc -### 2>&1 \ +// RUN: | FileCheck %s --check-prefix=CHECK-PIC2 perhaps change

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM other than that comment about removing 'b' from AllStdExts. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:39 + +static constexpr StringLiteral AllStdExts =

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl added a comment. In D111443#3052697 , @tra wrote: > In D111443#3052381 , @yaxunl wrote: > >> In D111443#3052099 , @tra wrote: >> >>> I'm curious why we need the

[clang] fb4c451 - [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'

Author: Mike Rice Date: 2021-10-13T09:34:09-07:00 New Revision: fb4c451001d06c600394382e2c6ad6872f78f646 URL: https://github.com/llvm/llvm-project/commit/fb4c451001d06c600394382e2c6ad6872f78f646 DIFF: https://github.com/llvm/llvm-project/commit/fb4c451001d06c600394382e2c6ad6872f78f646.diff

[PATCH] D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4c451001d0: [OPENMP51]Initial parsing/sema for adjust_args clause for declare variant (authored by mikerice). Herald added projects: clang, Flang.

[PATCH] D111726: [HIP] Fix test rcom-detect.hip

mgorny added a comment. I can confirm that the tests pass for me with this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111726/new/ https://reviews.llvm.org/D111726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:45 + /// accessor class. + static bool isSyclAccessorType(const QualType ); + Isn't there a big rewrite going on downstream of these with `sycl_special_class`? Why are we trying to

[clang] 89ec99c - [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

Author: Kamau Bridgeman Date: 2021-10-13T09:40:06-05:00 New Revision: 89ec99c778943151213118f096e8008197c9ba10 URL: https://github.com/llvm/llvm-project/commit/89ec99c778943151213118f096e8008197c9ba10 DIFF:

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG89ec99c77894: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter (authored by kamaub). Changed prior to commit: https://reviews.llvm.org/D111229?vs=379149=379375#toc

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

aaron.ballman added a comment. FWIW, it seems like precommit CI is failing with problems in `x64 windows > Clang.SemaSYCL::accessors-targets.cpp` (which is largely hidden by the spam from the CI pipeline, unfortunately). Also, you should address the tidy warnings. Comment

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 379419. gandhi21299 added a comment. removed irrelevant lines in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with the new test Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:124 const auto = SM.getSLocEntry(FID).getExpansion(); -

[PATCH] D111724: [clang][deps] NFC: Remove redundant CompilerInstance reference

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ModuleDepCollectorPP` class holds a reference to `ModuleDepCollector` as well as

[PATCH] D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader

Sockke added a comment. In D111625#3060978 , @aaron.ballman wrote: > LGTM, thank you! Do you need me to commit on your behalf? I'm happy to do so, > but given the number of quality submissions you've had, I'm wondering if > you'd like to obtain commit

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. I would like to explain the position of the OpenCL tooling community and the directions we would like to take with SPIR-V support in LLVM. We believe that SPIR-V triple and target should be added explicitly to LLVM/Clang for the following reasons: - It would be

[PATCH] D111728: [clang][deps] NFC: Rename building CompilerInvocation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner works with multiple instances of `Compiler{Instance,Invocation}`.

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 created this revision. gandhi21299 added a reviewer: yaxunl. gandhi21299 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow (implicit) address space casting between LLVM-equivalent target address spaces. Repository: rG

[PATCH] D111560: [clang][modules] Cache loads of modules imported by PCH

jansvoboda11 added a comment. In D111560#3059128 , @dexonsmith wrote: > LGTM. It'd be nice to split out the move of `ReadModuleNames` into an NFC > prep patch for a cleaner commit history before pushing, but up to you. Committed in prep patch:

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke marked 12 inline comments as done. Sockke added a comment. Kindly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

kbobyrev updated this revision to Diff 379366. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111698/new/ https://reviews.llvm.org/D111698 Files:

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:170 +TEST(IncludeCleaner, ScratchBuffer) { + TestTU TU; sammccall wrote: > this doesn't seem to test very much, a comment should indicate that this is >

[PATCH] D111726: [HIP] Fix test rcom-detect.hip

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. This patches fixes https://bugs.llvm.org/show_bug.cgi?id=51404 Some builds use custom resource directory for clang, therefore the test cannot assume default resource directory for clang. Use

[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 closed this revision. jansvoboda11 added a comment. Fixed in 28fa77feeb7db46abea1a6699d7a88a02d8dab46 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

jansvoboda11 updated this revision to Diff 379424. jansvoboda11 added a comment. Use clearer wording in member name & documentation, use `std::string` instead of `StringRef` for storing module name to solve lifetime issues (surfaced in CI). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111720: [clang][deps] Ensure reported context hash is strict

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One of main goals of the dependency scanner is to be strict about module compatibility.

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

aeubanks created this revision. aeubanks added a reviewer: dblaikie. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously without -disable-free, -clear-ast-before-backend would crash in ~ASTContext() due to various reasons.

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aeubanks added a comment. In D111270#3060484 , @dblaikie wrote: > Plan is still to address the "this only works with disable free" issue? (I've > some preference that be addressed before this feature is turned on by default)

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379559. keith marked 4 inline comments as done. keith added a comment. Update to remap file paths after fetching them from the external FS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. Ok I've updated the diff here based on @dexonsmith's original suggestion, and some offline discussion with @JDevlieghere The new logic remaps the files and statuses, in the fallback to the external FS case, to use the originally requested path. I opted not to use the

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews updated this revision to Diff 379562. eandrews added a comment. Added a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 Files: clang/lib/CodeGen/CodeGenTypes.cpp clang/test/CodeGenSYCL/functionptr-addressspace.cpp Index:

[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

mstorsjo added a comment. In D111707#3062361 , @MaskRay wrote: > I was thinking of when testing "windows" x "pic", whether the test should > reside in "windows" or "pic". > If in "windows", we can decrease the number of RUN lines and use one RUN line >

[PATCH] D110123: [Proof of concept] Serialize fewer transitive methods in `METHOD_POOL`.

vsapsai updated this revision to Diff 379516. vsapsai added a comment. Try to preserve the order of methods when populating the global method pool. This attempt is more successful at keeping the existing code working though I still have 1 unexpected warning that requires further investigation.

[PATCH] D111529: Specify Clang vector builtins.

fhahn updated this revision to Diff 379517. fhahn marked 2 inline comments as done. fhahn added a comment. Another stab at phrasing the reduction step. Also added a note that the implementation is work-in-progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. It's good to know `ASTReader::ReadMethodPool` is pretty close for both approaches. And as far as I understand, it includes the code ReadMethodPoolVisitor Visitor(*this, Sel, PriorGeneration); ModuleMgr.visit(Visitor); so the module visiting doesn't seem to be too

[PATCH] D111760: [clang] Support __float128 on DragonFlyBSD.

fcambus created this revision. fcambus added reviewers: emaste, joerg, mgorny, krytarowski. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111760 Files:

[PATCH] D111725: [clang][deps] NFC: Rename scanning CompilerInstance

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111725/new/ https://reviews.llvm.org/D111725

[PATCH] D111720: [clang][deps] Ensure reported context hash is strict

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58 + // Ensure the reported context hash is strict. + CI.getHeaderSearchOpts().ModulesStrictContextHash = true; + IIUC, explicit modules don't really

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a subscriber: jansvoboda11. dexonsmith added a comment. @jansvoboda11, can you help to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111468/new/

[clang] e567f37 - [clang] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2021-10-13T20:41:55-07:00 New Revision: e567f37dabc242cb02fb8b8b288fd05a0aebfb8f URL: https://github.com/llvm/llvm-project/commit/e567f37dabc242cb02fb8b8b288fd05a0aebfb8f DIFF: https://github.com/llvm/llvm-project/commit/e567f37dabc242cb02fb8b8b288fd05a0aebfb8f.diff

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

lkail accepted this revision as: lkail. lkail added a comment. This revision is now accepted and ready to land. This LGTM as the start point to support int128 on AIX. We might need more patches involving libraries in the LLVM monorepo, we can do that progressively. Repository: rG LLVM Github

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 379598. noajshu added a comment. Rebase against main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp

[PATCH] D111724: [clang][deps] NFC: Remove redundant CompilerInstance reference

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111724/new/ https://reviews.llvm.org/D111724

[PATCH] D111728: [clang][deps] NFC: Rename building CompilerInvocation

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111728/new/ https://reviews.llvm.org/D111728

  1   2   >