[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

rogfer01 added a comment. In D111617#3060377 , @HsiangKai wrote: > Although it reduces the header size, this patch will increase the binary size > of clang. Options we can consider to mitigate this: - See if we can be more economical reprenting the

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

ortogonal updated this revision to Diff 381150. ortogonal added a comment. Just refactor it to latest main. I hope this will re-trigger a new build so I can investigate if there are still tests that fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

steakhal accepted this revision. steakhal added a comment. I love it. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6189 + // Check if the import was correct. + CXXConstructorDecl *ToCtor = *ToL->ctor_begin(); + const auto *ToFPT = ToCtor->getType()->getAs();

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add flags

crayroud updated this revision to Diff 381168. crayroud added a comment. This new version adds the possibility to configure space before opening parentheses independently from one another. Instead of creating a new SBPO_ mode for each combinations. CHANGES SINCE LAST ACTION

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add flags

MyDeveloperDay added a comment. Fundamentally this looks ok to me, the biggest concern is fathoming out the change in TokenAnnotator.cpp to mean the same thing, but I think that is what the tests should be for I think. One think I do is use the output of this

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add flags

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3341 +/// \endcode +bool AfterFunctionDeclarationName; +/// If ``true``, put a space between function definition name and opening Could you sort these?

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

balazske marked 4 inline comments as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6189 + // Check if the import was correct. + CXXConstructorDecl *ToCtor = *ToL->ctor_begin(); + const auto *ToFPT = ToCtor->getType()->getAs();

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

MyDeveloperDay added a subscriber: lodato. MyDeveloperDay added a comment. @lodato if you are still around (I see no changes since 2017), we may be able to add you as a "Co-author" I'm not sure of the policy, (again I would need your name and email address) Co-authored-by: name Repository:

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

ortogonal added a comment. Thanks for all your help (superfast as well) Yes I need help commiting. My name: Erik Larsson My email: karl.erik.lars...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90996/new/

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev updated this revision to Diff 381198. kbobyrev added a comment. Add one more test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112209/new/ https://reviews.llvm.org/D112209 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

RE: [PATCH] D111109: AddGlobalAnnotations for function with or without function body.

Hi Alex, I’ll take a look. Not sure how long it takes though. Please revert it. I don’t have the permission to commit yet. Could you share more information about the crash? What is the command line to repro the crash and which environment it crashed. Thanks Xiang Sent from

RE: [PATCH] D111109: AddGlobalAnnotations for function with or without function body.

Hi Alex, I tried compile your repro on Windows with clang -S But it didn’t crash. Could you share the command line and environment to repro the crash? Thanks Xiang Sent from Mail for Windows From: Alexander

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

steakhal added inline comments. Comment at: clang/test/Analysis/initialization.c:103 +void glob_arr_index4() { + clang_analyzer_eval(glob_arr_no_init[2]); // expected-warning{{UNKNOWN}} +} ASDenysPetrov wrote: > ASDenysPetrov wrote: > > steakhal wrote: > > >

[PATCH] D111760: [clang] Support __float128 on DragonFlyBSD.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb471e25a5924: [clang] Support __float128 on DragonFlyBSD. (authored by fcambus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111760/new/

[clang] b471e25 - [clang] Support __float128 on DragonFlyBSD.

Author: Frederic Cambus Date: 2021-10-21T11:18:52+02:00 New Revision: b471e25a59241b6b60e75494ca7b8d775a4131a2 URL: https://github.com/llvm/llvm-project/commit/b471e25a59241b6b60e75494ca7b8d775a4131a2 DIFF:

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

peterwaller-arm added a comment. (Accept, but please run clang format) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111790/new/ https://reviews.llvm.org/D111790 ___ cfe-commits mailing list

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

balazske updated this revision to Diff 381154. balazske added a comment. Improved test, set of TypeSourceInfo is not needed any more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112013/new/ https://reviews.llvm.org/D112013 Files:

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 381157. kbobyrev added a comment. Elaborate a bit more on Strict mode for UnusedHeaders. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files:

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

MyDeveloperDay added a comment. FYI I doubt you'll get a response from the original clang-format code owners as they have moved on. But I can take a look Before giving this the ok, I'd like to understand a little more. if I make a (bad)formatting change in a file which is not already staged

[PATCH] D112158: mips: fix search path for multilib o32

wzssyqa added a comment. In D112158#3077049 , @atanasyan wrote: > - Does this problem exist on all versions of Debian or starting from specific > version only? This feature starts from llvm-8. And this problem is since then. > - This fix needs test

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

pengfei updated this revision to Diff 381179. pengfei added a comment. Fix bugs. Ready for review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112143/new/ https://reviews.llvm.org/D112143 Files: clang/include/clang/Driver/Options.td

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Much, thank you for seeing this over the line, This LGTM, lets wait a bit in case any of the others have a comment. I assume you need help committing this? if so we need your

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

MyDeveloperDay added a comment. No problem, I hope your ok if @lodato gets back to us, I think we should probably try and credit them a least a little. Like I said let us wait a bit for people to have a chance to take a look (I'm not in the US hence why I've seen it already), I doubt there

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 381192. kbobyrev added a comment. Prevent accidental changes from getting into this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files:

[PATCH] D112158: mips: fix search path for multilib o32

atanasyan added a comment. - Does this problem exist on all versions of Debian or starting from specific version only? - This fix needs test cases. Take a look at "Check linker invocation on Debian 6 MIPS 32/64-bit" in the `clang/test/Driver/linux-ld.c` for example. Repository: rG LLVM

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 381190. kbobyrev added a comment. [clangd] IncludeCleaner: Implement more complicated rules for considering enums forward declarations "used" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

ortogonal added a comment. Thanks for looking into this! The feature `--staged` adds the possibility to ONLY run clang format on what is staged. Lets say you have main.cpp where you have done two changes. You stage one of them using: $ git add -p main.cpp You now have a state were one of

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev updated this revision to Diff 381195. kbobyrev added a comment. Remove unwanted (though good) formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112209/new/ https://reviews.llvm.org/D112209 Files:

[PATCH] D110127: [Clang] Support typedef with btf_decl_tag attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110127/new/ https://reviews.llvm.org/D110127

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

hans accepted this revision. hans added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112190/new/ https://reviews.llvm.org/D112190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

ntfshard added a comment. It seems I faced with degradation in compile time. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:68 +return hash_value( +std::pair(Tag.getDevice(), Tag.getFile())); + } In this line a narrow conversion, and

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov updated this revision to Diff 381252. ASDenysPetrov added a comment. Rebased. Updated comment for obscure behaviour of `getAnyInitializer` function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111542/new/ https://reviews.llvm.org/D111542 Files:

Re: [PATCH] D111109: AddGlobalAnnotations for function with or without function body.

On Thu, Oct 21, 2021 at 8:49 AM stan li wrote: > Hi Alex, > > I tried compile your repro on Windows with > > clang -S > > But it didn’t crash. > > > > Could you share the command line and environment to repro the crash? > I'm seeing the crash on linux on x86 with just `clang q.cc`. However, on

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong added a comment. I think, the visual comments that we have in `intersect` makes the code of `intersect` a lot easier to follow. Could you please add similar visual comments here? Also, I find `First` and `Second` in `intersect` way more better naming than `I1` and `I2`, could you

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3822 +def DiagnoseAs : InheritableAttr { + let Spellings = [Clang<"diagnose_as">]; + let Args = [ExprArgument<"Function">, george.burgess.iv wrote: > purely subjective nit:

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1649-1653 + // NOTE: `VD` is always non-null if `Init` is non-null, so we can check for + // null only one of them. + const Expr *Init = VD->getAnyInitializer(VD); if (!Init)

[PATCH] D112159: Relax assert in ExprConstant to a return None.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I checked the call sites to see if any were missed and I did not spot uses that should also be changed. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8b14b682c33: [clang][deps] Make resource directory deduction configurable (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112159: Relax assert in ExprConstant to a return None.

JonChesterfield added a comment. Thanks! Lots of call sites to check, appreciate the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112159/new/ https://reviews.llvm.org/D112159 ___ cfe-commits

[clang] b8b14b6 - [clang][deps] Make resource directory deduction configurable

Author: Jan Svoboda Date: 2021-10-21T14:06:52+02:00 New Revision: b8b14b682c339c9ab85360d24ba9b888d52fdfbb URL: https://github.com/llvm/llvm-project/commit/b8b14b682c339c9ab85360d24ba9b888d52fdfbb DIFF: https://github.com/llvm/llvm-project/commit/b8b14b682c339c9ab85360d24ba9b888d52fdfbb.diff

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

paulwalker-arm added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:454 - if (Opts.ArmSveVectorBits) { -Builder.defineMacro("__ARM_FEATURE_SVE_BITS", Twine(Opts.ArmSveVectorBits)); + if (Opts.VScaleMin) { +

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

lodato requested changes to this revision. lodato added a comment. This revision now requires changes to proceed. Thanks for pushing this through, @ortogonal! The change LGTM, except the two minor issues listed. Name: Mark Lodato Email: lod...@google.com Comment at:

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov updated this revision to Diff 381240. ASDenysPetrov added a comment. Added a comment to //initialization.c//, that we can reason about values of constant array which doesn't have an initializer. This is not such simple for C++, since there are much more ways to initialize the

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 updated this revision to Diff 381210. jansvoboda11 added a comment. Add `REQUIRES: shell` to the test, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files:

[PATCH] D111720: [clang][deps] Ensure reported context hash is strict

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58 + // Ensure the reported context hash is strict. + CI.getHeaderSearchOpts().ModulesStrictContextHash = true; + dexonsmith wrote: > jansvoboda11

[PATCH] D111993: [libomptarget][WIP] Patch amdgpu DeviceRTL until it compiles

JonChesterfield abandoned this revision. JonChesterfield added a comment. Going to discard this and recreate as a new patch which includes the two cmake ones (D111983 and D111987 ) Repository: rG LLVM Github Monorepo

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Mon, Oct 18, 2021 at 4:13 PM Richard Smith wrote: > > On Mon, 18 Oct 2021 at 12:56, Aaron Ballman wrote: >> >> On Mon, Oct 18, 2021 at 3:52 PM Richard Smith wrote: >> > >> > On Mon, 18 Oct 2021 at 12:48, Aaron Ballman >> > wrote: >> >> >> >> On Mon, Oct 18, 2021 at 3:33 PM Richard Smith

[clang] aad244d - Revert "AddGlobalAnnotations for function with or without function body."

Author: Aaron Ballman Date: 2021-10-21T07:08:18-04:00 New Revision: aad244dfc566236e9d3ef48c7aea3616bb6aab14 URL: https://github.com/llvm/llvm-project/commit/aad244dfc566236e9d3ef48c7aea3616bb6aab14 DIFF: https://github.com/llvm/llvm-project/commit/aad244dfc566236e9d3ef48c7aea3616bb6aab14.diff

[PATCH] D111720: [clang][deps] Ensure reported context hash is strict

This revision was automatically updated to reflect the committed changes. Closed by commit rG954d77b98dd6: [clang][deps] Ensure reported context hash is strict (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D111720?vs=379397=381213#toc Repository: rG LLVM

[clang] 954d77b - [clang][deps] Ensure reported context hash is strict

Author: Jan Svoboda Date: 2021-10-21T13:49:47+02:00 New Revision: 954d77b98dd69c6bcf808e3dac871171d4832bad URL: https://github.com/llvm/llvm-project/commit/954d77b98dd69c6bcf808e3dac871171d4832bad DIFF: https://github.com/llvm/llvm-project/commit/954d77b98dd69c6bcf808e3dac871171d4832bad.diff

[PATCH] D107347: [Sema] haveSameParameterTypes - replace repeated isNull() test with assertions

jansvoboda11 added a comment. FYI, it seems like a branch containing this patch was accidentally pushed to GitHub: https://github.com/llvm/llvm-project/tree/5357a98c823a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107347/new/

[PATCH] D112059: Fix inline builtin handling in case of redefinition

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1302 // in case the function pointer is referenced somewhere. - if (FD->isInlineBuiltinDeclaration() && Fn) { + if (Fn) { std::string FDInlineName = (Fn->getName() +

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

hokein added a comment. This patch seems to case a new crash, details are at https://bugs.llvm.org/show_bug.cgi?id=52250. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 ___ cfe-commits mailing list

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:68 +return hash_value( +std::pair(Tag.getDevice(), Tag.getFile())); + } ntfshard wrote: > In this line a narrow

Re: [PATCH] D111109: AddGlobalAnnotations for function with or without function body.

On Wed, Oct 20, 2021 at 5:28 PM stan li wrote: > > Hi Alex, > > I’ll take a look. Not sure how long it takes though. > > Please revert it. I don’t have the permission to commit yet. I've reverted in aad244dfc566236e9d3ef48c7aea3616bb6aab14 while the crash is being investigated. ~Aaron

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

martong accepted this revision. martong added a comment. Thanks for updating the test case! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112013/new/ https://reviews.llvm.org/D112013 ___ cfe-commits

[clang] 2461666 - [clang][deps] NFC: Remove redundant CompilerInstance reference

Author: Jan Svoboda Date: 2021-10-21T13:50:46+02:00 New Revision: 24616664afd455d7fde9cf4c631ff30347196bbc URL: https://github.com/llvm/llvm-project/commit/24616664afd455d7fde9cf4c631ff30347196bbc DIFF: https://github.com/llvm/llvm-project/commit/24616664afd455d7fde9cf4c631ff30347196bbc.diff

[clang] 207e9fd - [clang][deps] NFC: Rename scanning CompilerInstance

Author: Jan Svoboda Date: 2021-10-21T13:51:00+02:00 New Revision: 207e9fdea704dd8c6db077971d958abb8b4d6d84 URL: https://github.com/llvm/llvm-project/commit/207e9fdea704dd8c6db077971d958abb8b4d6d84 DIFF: https://github.com/llvm/llvm-project/commit/207e9fdea704dd8c6db077971d958abb8b4d6d84.diff

[clang] c62220f - [clang][deps] NFC: Rename building CompilerInvocation

Author: Jan Svoboda Date: 2021-10-21T13:51:27+02:00 New Revision: c62220f9623dde699b88baf47c0a3dca400767fb URL: https://github.com/llvm/llvm-project/commit/c62220f9623dde699b88baf47c0a3dca400767fb DIFF: https://github.com/llvm/llvm-project/commit/c62220f9623dde699b88baf47c0a3dca400767fb.diff

[PATCH] D111725: [clang][deps] NFC: Rename scanning CompilerInstance

This revision was automatically updated to reflect the committed changes. Closed by commit rG207e9fdea704: [clang][deps] NFC: Rename scanning CompilerInstance (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111725/new/

[PATCH] D111728: [clang][deps] NFC: Rename building CompilerInvocation

This revision was automatically updated to reflect the committed changes. Closed by commit rGc62220f9623d: [clang][deps] NFC: Rename building CompilerInvocation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111728/new/

[PATCH] D111724: [clang][deps] NFC: Remove redundant CompilerInstance reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG24616664afd4: [clang][deps] NFC: Remove redundant CompilerInstance reference (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112159: Relax assert in ExprConstant to a return None.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff4f48adb26: Relax assert in ExprConstant to a return None. (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112159/new/

[clang] 7ff4f48 - Relax assert in ExprConstant to a return None.

Author: Jon Chesterfield Date: 2021-10-21T13:09:56+01:00 New Revision: 7ff4f48adb26429086d6fd85a14336e57cd340dc URL: https://github.com/llvm/llvm-project/commit/7ff4f48adb26429086d6fd85a14336e57cd340dc DIFF:

[PATCH] D110436: Add %n format specifier warning to clang-tidy

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PercentNFormatSpecifierCheck.cpp:26-27 + bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier , + const char *startSpecifier, +

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked an inline comment as done. yaxunl added a comment. In D70172#3077696 , @hokein wrote: > This patch seems to cause a new crash, details are at > https://bugs.llvm.org/show_bug.cgi?id=52250. I will take a look. Thanks. CHANGES SINCE LAST

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

ortogonal updated this revision to Diff 381269. ortogonal added a comment. Update description on function `compute_diff` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90996/new/ https://reviews.llvm.org/D90996 Files:

[clang] b396010 - [Clang] Support typedef with btf_decl_tag attributes

Author: Yonghong Song Date: 2021-10-21T08:41:49-07:00 New Revision: b396010240cda92f5fcfa30cba1b9ad905561eae URL: https://github.com/llvm/llvm-project/commit/b396010240cda92f5fcfa30cba1b9ad905561eae DIFF: https://github.com/llvm/llvm-project/commit/b396010240cda92f5fcfa30cba1b9ad905561eae.diff

[PATCH] D110127: [Clang] Support typedef with btf_decl_tag attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGb396010240cd: [Clang] Support typedef with btf_decl_tag attributes (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110127/new/

[PATCH] D112229: Reapply [ORC-RT] Configure the ORC runtime for more architectures and platforms

benlangmuir created this revision. benlangmuir added a reviewer: lhames. Herald added subscribers: kristof.beyls, mgorny. benlangmuir requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Reapply 5692ed0cce8c95

[PATCH] D110436: Add %n format specifier warning to clang-tidy

Jaysonyan added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PercentNFormatSpecifierCheck.cpp:43-57 + auto PrintfDecl = functionDecl(hasName("::printf")); + auto FprintfDecl = functionDecl(hasName("::fprintf")); + auto VfprintfDecl =

[PATCH] D112235: [HIP][OpenMP] Fix assertion in deferred diag due to incomplete class definition

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added a subscriber: guansong. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fix assertion in UsedDeclVisitor where clang is trying to look up a

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, ldionne, cjdb, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. C17 deprecated `ATOMIC_VAR_INIT` with the resolution of DR 485. C++ followed suit when adopting P0883R2 for

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

aaron.ballman added a comment. I reviewed this a bit, but I think it might be heading in a slightly wrong direction. I think you should be using an `AttributedType` but I don't think we need to add `AttributedBTFType` as a subclass to do this. An `AttributedType` holds the type kind

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

jdoerfert added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:23 -extern uint32_t __omp_rtl_debug_kind; +// extern uint32_t __omp_rtl_debug_kind; JonChesterfield wrote: > Otherwise the missing symbols prevents linking, not

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

aeubanks added inline comments. Comment at: clang/test/Misc/clear-ast-before-backend-plugins.c:3-8 +// RUN: %clang_cc1 -mllvm -debug-only=codegenaction -clear-ast-before-backend -emit-obj -o /dev/null -load %llvmshlibdir/PrintFunctionNames%pluginext %s 2>&1 | FileCheck %s

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:23 -extern uint32_t __omp_rtl_debug_kind; +// extern uint32_t __omp_rtl_debug_kind; jdoerfert wrote: > JonChesterfield wrote: > > Otherwise the missing

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added a comment. @Anastasia, @yaxunl, do you think it's possible to refactor code generation for blocks such that block literal for global blocks (with no captures) would be emitted in constant address space? Now it's emitted in global address space (for example

[clang] cfca2ae - Update the C++ and C status pages now that Clang 13 has been released

Author: Aaron Ballman Date: 2021-10-21T12:13:19-04:00 New Revision: cfca2ae1f5babaf0877bbd3ce8665b9db3344411 URL: https://github.com/llvm/llvm-project/commit/cfca2ae1f5babaf0877bbd3ce8665b9db3344411 DIFF: https://github.com/llvm/llvm-project/commit/cfca2ae1f5babaf0877bbd3ce8665b9db3344411.diff

[PATCH] D110452: [modules] Fix tracking ObjCInterfaceType decl when there are multiple definitions.

vsapsai updated this revision to Diff 381313. vsapsai added a comment. Another rebase and pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110452/new/ https://reviews.llvm.org/D110452 Files: clang/include/clang/AST/Type.h

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield created this revision. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, mgorny, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1, wdng. Herald added a reviewer:

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added a comment. @martong > I am close to accepting this. However, D111542 > should be its parent patch. I think > similar issues could arise here as well, so, redecl chain tests would be > really beneficial. I think I'm done. You can proceed

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, yaxunl, svenvh. Herald added a subscriber: ldrumm. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires support of

[clang] b8da594 - Reapply [ORC-RT] Configure the ORC runtime for more architectures and platforms

Author: Ben Langmuir Date: 2021-10-21T09:00:18-07:00 New Revision: b8da594750762f811283820c19b02cedfb6632d4 URL: https://github.com/llvm/llvm-project/commit/b8da594750762f811283820c19b02cedfb6632d4 DIFF: https://github.com/llvm/llvm-project/commit/b8da594750762f811283820c19b02cedfb6632d4.diff

[PATCH] D112229: Reapply [ORC-RT] Configure the ORC runtime for more architectures and platforms

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8da59475076: Reapply [ORC-RT] Configure the ORC runtime for more architectures and platforms (authored by benlangmuir). Repository: rG LLVM

[clang] acfe7d8 - Update the title and encoding for the C++ status page

Author: Aaron Ballman Date: 2021-10-21T12:14:44-04:00 New Revision: acfe7d895d2f0897fe8f79151a491e75a7a99a25 URL: https://github.com/llvm/llvm-project/commit/acfe7d895d2f0897fe8f79151a491e75a7a99a25 DIFF: https://github.com/llvm/llvm-project/commit/acfe7d895d2f0897fe8f79151a491e75a7a99a25.diff

[clang] 19b07ec - Reland [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

Author: Arthur Eubanks Date: 2021-10-21T09:25:53-07:00 New Revision: 19b07ec00062daffcb2fb132f4ac0f2484ff44fa URL: https://github.com/llvm/llvm-project/commit/19b07ec00062daffcb2fb132f4ac0f2484ff44fa DIFF:

[PATCH] D110436: Add %n format specifier warning to clang-tidy

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PercentNFormatSpecifierCheck.cpp:43-57 + auto PrintfDecl = functionDecl(hasName("::printf")); + auto FprintfDecl = functionDecl(hasName("::fprintf")); + auto VfprintfDecl =

[clang] 408075e - Add the papers that were applied to the latest C2x working draft

Author: Aaron Ballman Date: 2021-10-21T13:38:57-04:00 New Revision: 408075ec6a955998eea3549fa7f79c512c6b02d1 URL: https://github.com/llvm/llvm-project/commit/408075ec6a955998eea3549fa7f79c512c6b02d1 DIFF: https://github.com/llvm/llvm-project/commit/408075ec6a955998eea3549fa7f79c512c6b02d1.diff

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

ortogonal added inline comments. Comment at: clang/tools/clang-format/git-clang-format:140 if not opts.diff: die('--diff is required when two commits are given') else: lodato wrote: > Does there need to be an equivalent check that --staged

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov updated this revision to Diff 381274. ASDenysPetrov added a comment. Rebased. Improved behavior to make `glob_invalid_index8` case passed and some other cases. Added more tests. Added tests for universal characters. CHANGES SINCE LAST ACTION

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:23 -extern uint32_t __omp_rtl_debug_kind; +// extern uint32_t __omp_rtl_debug_kind; Otherwise the missing symbols prevents linking, not clear why it works

[clang] f6811ce - [DebugInfo] Support typedef with btf_decl_tag attributes

Author: Yonghong Song Date: 2021-10-21T08:42:58-07:00 New Revision: f6811cec84218912d1c7c9b0b8d308834e6e24e3 URL: https://github.com/llvm/llvm-project/commit/f6811cec84218912d1c7c9b0b8d308834e6e24e3 DIFF: https://github.com/llvm/llvm-project/commit/f6811cec84218912d1c7c9b0b8d308834e6e24e3.diff

[PATCH] D110129: [DebugInfo] Support typedef with btf_decl_tag attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6811cec8421: [DebugInfo] Support typedef with btf_decl_tag attributes (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:636-638 +unsigned AS = PointeeType->isFunctionTy() + ? getDataLayout().getProgramAddressSpace() + : Context.getTargetAddressSpace(ETy);

[clang] 2dcad77 - [clang] Don't clear AST if we have consumers running after the main action

Author: Arthur Eubanks Date: 2021-10-21T09:03:57-07:00 New Revision: 2dcad7754a204d5dbb78fef8f6b13cd005456e33 URL: https://github.com/llvm/llvm-project/commit/2dcad7754a204d5dbb78fef8f6b13cd005456e33 DIFF:

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dcad7754a20: [clang] Dont clear AST if we have consumers running after the main action (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112235: [HIP][OpenMP] Fix assertion in deferred diag due to incomplete class definition

tra added a reviewer: rsmith. tra added a subscriber: rsmith. tra added a comment. Looks reasonable to me, but, considering that it's generic C++ code, I think it would be prudent go double check that. @rsmith - WDYT? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112235/new/

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. bump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >