[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 381852. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

linjamaki updated this revision to Diff 381857. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110685/new/ https://reviews.llvm.org/D110685 Files: clang/include/clang/Driver/Options.td

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

qiucf updated this revision to Diff 381868. qiucf added a reviewer: rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112401/new/ https://reviews.llvm.org/D112401 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

stuij created this revision. Herald added a subscriber: kristof.beyls. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the extension string "+pacbti" was given in -march=... or -mcpu=... options the compiler shall define the

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. In D108696#3083081 , @Quuxplusone wrote: > In D108696#3082866 , @ChuanqiXu > wrote: > >> @Quuxplusone gentle ping~ > > I think this PR is mostly above my pay grade. :) Sorry for

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. <3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112296/new/ https://reviews.llvm.org/D112296

[PATCH] D112422: [clang][ARM] emit PACBTI-M feature defines

stuij created this revision. Herald added a subscriber: kristof.beyls. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. emit __ARM_FEATURE_BTI_DEFAULT and __ARM_FEATURE_PAC_DEFAULT defines when those features have been enabled This

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki updated this revision to Diff 381847. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki updated this revision to Diff 381858. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaType.cpp

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske created this revision. Herald added subscribers: carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The CERT rule ERR33-C

[PATCH] D112410: [SPIR-V] Add a tool chain for SPIR-V (incomplete)

linjamaki created this revision. Herald added a subscriber: ThomasRaoux. linjamaki published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a tool chain (TC) for SPIR-V for demonstration purposes. The TC is not complete but it is

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

steakhal accepted this revision. steakhal added a comment. Minor nits. Aside from that just land it. Thanks for the fix. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1654 + // NOTE: If `Init` is non-null, then a new `VD` is non-null for sure. So check + //

[clang] e1fdec8 - [analyzer] Add std::string checker

Author: Balazs Benics Date: 2021-10-25T11:15:40+02:00 New Revision: e1fdec875ff13504057fa01227458c9afa08222f URL: https://github.com/llvm/llvm-project/commit/e1fdec875ff13504057fa01227458c9afa08222f DIFF: https://github.com/llvm/llvm-project/commit/e1fdec875ff13504057fa01227458c9afa08222f.diff

[clang] caeef19 - [analyzer] Allow cmake options to be passed to satest container

Author: Manas Date: 2021-10-25T11:15:40+02:00 New Revision: caeef1995ab47387fa8da3e958afc5637b4e893d URL: https://github.com/llvm/llvm-project/commit/caeef1995ab47387fa8da3e958afc5637b4e893d DIFF: https://github.com/llvm/llvm-project/commit/caeef1995ab47387fa8da3e958afc5637b4e893d.diff LOG:

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

stuij created this revision. Herald added subscribers: libcxx-commits, kristof.beyls. Herald added a project: libunwind. Herald added a reviewer: libunwind. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements the

[PATCH] D112406: [Driver][AArch64]Add driver support for neoverse-512tvb target

CarolineConcatto created this revision. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls. CarolineConcatto requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The support for neoverse-512tvb mirrors the same

[PATCH] D112406: [Driver][AArch64]Add driver support for neoverse-512tvb target

dmgreen added a comment. This is a bit of a shame. I was hoping we wouldn't need the same hacks as GCC. The llvm cost modelling can work quite differently at times to GCC and I didn't think we were close enough to optimal code to need to worry about these kinds of differences. I guess having

[PATCH] D112408: [WIP][RISCV] Add the zve extension according to the v1.0-rc2 spec

frasercrmck added a comment. Don't we need to teach ISel some tricks before we consider these extensions supported? E.g., we need to stop i64 vectors being legal under zve32x or zve32f. Comment at: llvm/lib/Target/RISCV/RISCV.td:182 +def FeatureExtZve32x +:

[PATCH] D111247: [analyzer] Add std::string checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1fdec875ff1: [analyzer] Add std::string checker (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaeef1995ab4: [analyzer] Allow cmake options to be passed to satest container (authored by manas, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

martong added a comment. Thanks for the report @bjope and thanks for the action @manas and @steakhal ! Sorry guys, I should have run our CI safety net jobs for this patch. I tend to do that with all my solver related patches, I really don't know why I thought this was different. Repository:

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

steakhal accepted this revision. steakhal added a comment. Sorry for blocking the review of this one for so long. Comment at: clang/test/Analysis/initialization.c:103 +void glob_arr_index4() { + clang_analyzer_eval(glob_arr_no_init[2]); // expected-warning{{UNKNOWN}} +}

[PATCH] D112415: [Driver] ignore -maccumulate_outgoing_args option

pengfei created this revision. pengfei added reviewers: efriedma, erichkeane, LuoYuanke. Herald added a subscriber: dang. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://llvm.org/bugs/show_bug.cgi?id=28145

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ReleaseNotes.rst:227 correctly places the opening brace according to ``BraceWrapping.AfterEnum``. +- Option ``AlignAfterOpenBracket: BlockIndent`` has been added. If set, it will + always break after an open

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add flags

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3422 ///true: false: - ///for (auto v : values) {} vs. for(auto v: values) {} + ///for (auto v : values) {} vs. for

[PATCH] D112403: [clangd] Respect diagnostic suppression during preamble build

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki created this revision. Herald added subscribers: ThomasRaoux, dang, mgorny. linjamaki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a tool for constructing commands for translating LLVM IR to SPIR-V. Used by HIPSPV tool

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki updated this revision to Diff 381851. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 381855. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files: clang/include/clang/Basic/Cuda.h

[PATCH] D112359: [NFC][RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381866. eopXD added a comment. Update clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei created this revision. pengfei added reviewers: MaskRay, hjl.tools, erichkeane, LuoYuanke, craig.topper. Herald added subscribers: dang, hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381873. eopXD edited the summary of this revision. eopXD added a comment. Since parsing logic is unified, code of RISCVAsmParser can be reduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1757-1760 + // FIXME: Nevertheless, we can't do the same for cases, like: + // const char *str = "123"; // literal length is 4 + // char c = str[41];// offset is 41 + // It

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 381850. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 Files: clang/lib/Basic/Targets/SPIR.h

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 381854. linjamaki added a comment. Rebase and use SPIRV::constructTranslateCommand() to contruct the LLVM-SPIR-V translation command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/coroutines-exp-namespace.cpp:2 +// This file is the same with coroutines.cpp except the coroutine components are defined in std::experimental namespace. +// This intention of this test is to make sure the legacy

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Awesome! So clean, and I also like the tests. Good job. Comment at: clang/test/Analysis/solver-sym-simplification-adjustment.c:58 + if (b != 1) { // b == 1 --> c

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Introduce assembly support for Armv8.1-M PACBTI extension. This is an optional

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij created this revision. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls. Herald added a reviewer: aaron.ballman. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Handle branch protection option on

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add flags

crayroud added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3170 + // to add a space only before the first one + bool IsFirstLParen = true; + const FormatToken *Tok = Right.Previous; I will simplify the following using

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1618-1627 +const SymbolRef LHS = Sym->getLHS(); +const llvm::APSInt = +Builder.getBasicValueFactory().getValue(0, Sym->getType()); +// a % b != 0

[clang] 44e803e - [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

Author: Denys Petrov Date: 2021-10-25T15:14:10+03:00 New Revision: 44e803ef6d41770adf309960e37bcc6a75dbbe2c URL: https://github.com/llvm/llvm-project/commit/44e803ef6d41770adf309960e37bcc6a75dbbe2c DIFF: https://github.com/llvm/llvm-project/commit/44e803ef6d41770adf309960e37bcc6a75dbbe2c.diff

[clang] 3b1165b - [analyzer] Retrieve incomplete array extent from its redeclaration.

Author: Denys Petrov Date: 2021-10-25T15:14:10+03:00 New Revision: 3b1165ba3d15de83699be3ff4be3b6adf4d6e977 URL: https://github.com/llvm/llvm-project/commit/3b1165ba3d15de83699be3ff4be3b6adf4d6e977 DIFF: https://github.com/llvm/llvm-project/commit/3b1165ba3d15de83699be3ff4be3b6adf4d6e977.diff

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG44e803ef6d41: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b1165ba3d15: [analyzer] Retrieve incomplete array extent from its redeclaration. (authored by ASDenysPetrov). Changed prior to commit: https://reviews.llvm.org/D111542?vs=381252=381944#toc

[clang] 333c36b - [clang][unittests] Fix shared lib builds

Author: Kadir Cetinkaya Date: 2021-10-25T15:09:45+02:00 New Revision: 333c36bec09a954b59ceb01e21f1525f17530ec0 URL: https://github.com/llvm/llvm-project/commit/333c36bec09a954b59ceb01e21f1525f17530ec0 DIFF:

[PATCH] D112390: [AIX][ZOS] Disable tests due to lack of Objective-C support

Jake-Egan updated this revision to Diff 381979. Jake-Egan added a comment. Fixed objc_direct.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112390/new/ https://reviews.llvm.org/D112390 Files: clang/test/Modules/ModuleDebugInfo.cpp

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:38 bool VisitTagType(TagType *TT) { +// For enumerations we will require only the definition if it's present and +// the underlying type is not specified. I don't

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong marked 6 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1619-1620 +const SymbolRef LHS = Sym->getLHS(); +const llvm::APSInt = +Builder.getBasicValueFactory().getValue(0,

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet added a comment. As per the comment in BuiltinTypes.def (see below), `Dependent` is allowed in context where the type is deducible, but is there any reason **not** to deduce the type if we can do it cheaply in some cases ? // This represents the type of an expression whose type is //

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111985/new/ https://reviews.llvm.org/D111985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 9ab9caf - [clang] Visit enum base specifiers in libIndex

Author: Kadir Cetinkaya Date: 2021-10-25T13:16:14+02:00 New Revision: 9ab9caf214f47ea0ccf5cd3eb0aef2fcb88bd6e1 URL: https://github.com/llvm/llvm-project/commit/9ab9caf214f47ea0ccf5cd3eb0aef2fcb88bd6e1 DIFF:

[PATCH] D111259: [clang] Fix range for forward-declared enums

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rGffa96f022c3f: [clang] Fix range for forward-declared enums (authored by kadircet). Changed prior to commit:

[clang] ffa96f0 - [clang] Fix range for forward-declared enums

Author: Kadir Cetinkaya Date: 2021-10-25T13:16:14+02:00 New Revision: ffa96f022c3ff03888afca8fdda766fe556eb9c5 URL: https://github.com/llvm/llvm-project/commit/ffa96f022c3ff03888afca8fdda766fe556eb9c5 DIFF:

[clang-tools-extra] 4e4511d - [clang] Traverse enum base specifier in RAV

Author: Kadir Cetinkaya Date: 2021-10-25T13:16:14+02:00 New Revision: 4e4511df8d33a6fc02d5e46c681855db495187cd URL: https://github.com/llvm/llvm-project/commit/4e4511df8d33a6fc02d5e46c681855db495187cd DIFF:

[PATCH] D111260: [clang] Visit enum base specifiers in libIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab9caf214f4: [clang] Visit enum base specifiers in libIndex (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111260/new/

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1623 if (!Constraint.containsZero()) { - State = RCM.assumeSymNE(State, LHS, Zero, Zero); + State = RCM.assumeSymRel(State, LHS, BO_NE, Zero); if

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12715-12716 + ExprResult SemaBuiltinElementwiseMath(CallExpr *TheCall, +ExprResult CallResult); + Why oh why did we start slapping `Sema`

[PATCH] D112235: [HIP][OpenMP] Fix assertion in deferred diag due to incomplete class definition

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/OpenMP/deferred-diags.cpp:40 +// Test deleting object with incomplete class definition does not causing +// assertion. +namespace TestDeleteIncompleteClassDefinition {

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

danielkiss added inline comments. Comment at: libunwind/src/Registers.hpp:2245-2246 + if (regNum == UNW_ARM_RA_AUTH_CODE) +return true; + Maybe we could gate this on __ARM_FEATURE_PAUTH because it won't work anyway without the feature enabled for

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh updated this revision to Diff 381772. shraiysh added a comment. Rebase with main, updated syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111992/new/ https://reviews.llvm.org/D111992 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

peixin added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5993 case OMPC_adjust_args: + case OMPC_memory_order: llvm_unreachable("Clause is not allowed in 'omp atomic'."); The memory_order clause in clang side is not handled in this

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

steakhal added a comment. This is an important step towards better handling of global initializer expressions. I'm looking forward to it. Although, I have concerns to address. Comment at: clang/lib/AST/Type.cpp:141-143 +/// Return an array with extents of the declared array

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Collect the macro definition

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1757-1760 + // FIXME: Nevertheless, we can't do the same for cases, like: + // const char *str = "123"; // literal length is 4 + // char c = str[41];// offset is 41 +

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1623 if (!Constraint.containsZero()) { - State = RCM.assumeSymNE(State, LHS, Zero, Zero); + State =

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh added inline comments. Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:1246 +StringRef memOrder = op.memory_order().getValue(); +if (memOrder.equals("acq_rel") || memOrder.equals("release")) + return op.emitError( shraiysh wrote: >

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

peixin added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5993 case OMPC_adjust_args: + case OMPC_memory_order: llvm_unreachable("Clause is not allowed in 'omp atomic'."); peixin wrote: > The memory_order clause in clang side is not

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh added a comment. Thanks for the review @peixin. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:513 + +def AtomicReadOp : OpenMP_Op<"atomic.read"> { + let arguments = (ins OpenMP_PointerLikeType:$address, peixin wrote: > How do you plan to

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov added a comment. In D106681#3083409 , @steakhal wrote: > Sorry for blocking the review of this one for so long. Thank you for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106681/new/ https://reviews.llvm.org/D106681

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1654 + // NOTE: If `Init` is non-null, then a new `VD` is non-null for sure. So check + // `Init` for null only and don't worry about the replaced `VD`. if (!Init)

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. I have one small comment, but otherwise LGTM. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1558 + + if (Reg && !isValidSysReg(Reg, Read,

[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

lpetre created this revision. lpetre updated this revision to Diff 381958. lpetre added a comment. lpetre updated this revision to Diff 381960. lpetre retitled this revision from "Fix the EndLoc calculation for ObjCObjectPointer" to "[AST] Fix the EndLoc calculation for ObjCObjectPointer". lpetre

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 381974. csmulhern marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ce46a1d43c6: [AArch64][Driver][SVE] Allow -msve-vector-bits=n+ syntax to mean no maximum… (authored by bsmith). Repository: rG LLVM Github

[clang] 0ce46a1 - [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

Author: Bradley Smith Date: 2021-10-25T11:10:52Z New Revision: 0ce46a1d43c6c2e0df429a6a80848d4acc781eb6 URL: https://github.com/llvm/llvm-project/commit/0ce46a1d43c6c2e0df429a6a80848d4acc781eb6 DIFF: https://github.com/llvm/llvm-project/commit/0ce46a1d43c6c2e0df429a6a80848d4acc781eb6.diff

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

joerg added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:99 +cl::desc("Skips setting up the RAX register when SSE is disabled and there " + "are no variable arguments passed in vector registers."), +cl::Hidden); The

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

martong added inline comments. Comment at: clang/include/clang/AST/Type.h:2953 const llvm::APInt () const { return Size; } + SmallVector getAllExtents() const; const Expr *getSizeExpr() const { Could this be a free function (not a member function)? That

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet created this revision. courbet added reviewers: rsmith, aaron.ballman. courbet requested review of this revision. Herald added a project: clang. Example: template auto f(T* t) { return *t; } Before that change, the `UnaryOperator` for `*t` has type ``. After the change, its

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

sammccall added a comment. Mostly dumb nitpicks because this is user-facing magic strings... let's chat before doing another round so I'm not wasting your time. --- You've done some renaming from UnusedInclude -> UnusedHeaders. I feel bad because I did say in the last round > "Unused

[PATCH] D111224: [clang] Traverse enum integer-base specifiers in RAV

kadircet closed this revision. kadircet marked an inline comment as done. kadircet added a comment. Landed as https://github.com/llvm/llvm-project/commit/4e4511df8d33a6fc02d5e46c681855db495187cd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111120: [clangd] Find explicit references in the base-specifier of an enum decl

nridge abandoned this revision. nridge added a comment. Yep, thanks very much for the more complete fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D20/new/ https://reviews.llvm.org/D20 ___

[PATCH] D109506: [clangd] Print current request context along with the stack trace

sammccall added a comment. In D109506#3059313 , @0x1eaf wrote: > I've instrumented preamble building, but haven't instrumented background > indexing which is outside of `TUScheduler.cpp` and would require exposing > `crashDump*` helpers and preferably

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

carlosgalvezp updated this revision to Diff 382012. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112334/new/ https://reviews.llvm.org/D112334 Files:

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

carlosgalvezp added a comment. Thanks for the review! I'm not super happy with the commit in the sense that it feels more like a workaround than a proper fix, with the hardcoded name `__cuda_built_in` and so on. But honestly I don't know how implement it more properly, for example check if

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:45-50 +// The following functions are +// deliberately excluded because they can +// be called with NULL argument and in +// this case the check is not applicable: +// mblen,

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

carlosgalvezp added a comment. Also: - Please add a unit test. You, can probably re-use the corresponding `bugprone` test and tell it to add the `cert-err33-c` check as well. If they are too different I suppose it's fine to create it's own standalone test? - Mention this new check in the

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

tra added a comment. LGTM. This could be useful for other types. E.g. `long double` is technically not supported by NVPTX. We current demote it to double, so host-side does not cause errors, but ideally it should be treated similar to what you propose for i128 here. Comment

[PATCH] D112406: [WIP][Driver][AArch64]Add driver support for neoverse-512tvb target

CarolineConcatto updated this revision to Diff 382004. CarolineConcatto added a comment. - remove neoverse-512tvb from Host.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112406/new/ https://reviews.llvm.org/D112406 Files:

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

martong added a comment. Thanks, this looks good to me! However, please wait for clang-tidy owners' approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.org/D112409

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

aaron.ballman added inline comments. Comment at: clang/test/Sema/builtins-elementwise-math.c:42 + // expected-error@-1 {{argument types do not match, 'float4' (vector of 4 'float' values) != 'int3' (vector of 3 'int' values)}} +} aaron.ballman wrote: > fhahn

[clang] d869939 - [OPENMP51]Initial parsing/sema for append_args clause for 'declare variant'

Author: Mike Rice Date: 2021-10-25T09:38:50-07:00 New Revision: d8699391a431af5730fe36ac4b05840020c42203 URL: https://github.com/llvm/llvm-project/commit/d8699391a431af5730fe36ac4b05840020c42203 DIFF: https://github.com/llvm/llvm-project/commit/d8699391a431af5730fe36ac4b05840020c42203.diff

[PATCH] D111854: [OPENMP51]Initial parsing/sema for append_args clause for 'declare variant'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8699391a431: [OPENMP51]Initial parsing/sema for append_args clause for declare variant (authored by mikerice). Herald added projects: clang, Flang.

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev updated this revision to Diff 381992. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112209/new/ https://reviews.llvm.org/D112209 Files:

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:38 bool VisitTagType(TagType *TT) { +// For enumerations we will require only the definition if it's present and +// the underlying type is not specified.

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D112334#3081213 , @carlosgalvezp wrote: > Btw, regarding this `CHECK-MESSAGES-NOT`, how does it work? I can't find it > in

[PATCH] D112235: [HIP][OpenMP] Fix assertion in deferred diag due to incomplete class definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGa5435844f0e6: [HIP][OpenMP] Fix assertion in deferred diag (authored by yaxunl). Herald added a project:

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:38 bool VisitTagType(TagType *TT) { +// For enumerations we will require only the definition if it's present and +// the underlying type is not specified.

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] a543584 - [HIP][OpenMP] Fix assertion in deferred diag

Author: Yaxun (Sam) Liu Date: 2021-10-25T11:07:40-04:00 New Revision: a5435844f0e67c70963a1a743fef41b1a8eac4d3 URL: https://github.com/llvm/llvm-project/commit/a5435844f0e67c70963a1a743fef41b1a8eac4d3 DIFF:

  1   2   >