[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

martong added a subscriber: vabridgers. martong added a comment. Adding @vabridgers as a subscriber, he might be interested in this. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1675 + // belong to an array with one element of type T. + // Hence, the

[clang-tools-extra] 32f1029 - [clangd] Track performance of IncludeCleaner

Author: Kirill Bobyrev Date: 2021-10-29T12:59:22+02:00 New Revision: 32f102912493db3df864cc80d5bb602962839f68 URL: https://github.com/llvm/llvm-project/commit/32f102912493db3df864cc80d5bb602962839f68 DIFF:

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

This revision was automatically updated to reflect the committed changes. Closed by commit rG32f102912493: [clangd] Track performance of IncludeCleaner (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112783/new/

[PATCH] D112059: Fix inline builtin handling in case of redefinition

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a formatting nit. I don't think the precommit CI failures are related to your patch from what I was seeing, but may be worth keeping an eye on once you land just in case. Comment at:

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.org/D112409

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

martong accepted this revision. martong added a comment. Nice work! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107339/new/ https://reviews.llvm.org/D107339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb added a comment. I have split off the LOAD_STACK_GUARD changes into [ARM] implement LOAD_STACK_GUARD for remaining targets Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:4900 +.addImm(15) +.addImm(0) +.addImm(13)

[PATCH] D112289: Support: Use sys::path::is_style_{posix,windows}() in a few places

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, too. D112786 does a couple more things that do pretty much the same - I don't mind if you want to fold them into this, or keep it as-is, with the

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

aaron.ballman added a comment. In D99#3095623 , @yonghong-song wrote: >> Ah, yeah, I see what you mean - that does seem sort of unfortunate. Is it >> possible these attributes could only appear on typedefs and they'd be more >> readily carried

[PATCH] D112765: [AST] injected-class-name is not a redecl, even in template specializations

hokein added a comment. I think we also want to update the ast dumper bit: https://github.com/llvm/llvm-project/blob/main/clang/lib/AST/ASTDumper.cpp#L94-L100 Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1841-1842 +

[PATCH] D112491: Add `LambdaCapture`-related matchers.

aaron.ballman added a reviewer: sammccall. aaron.ballman added a subscriber: sammccall. aaron.ballman added a comment. In general, I'm happy with this. Adding @sammccall in case I've missed anything regarding the AST matcher internals or design concerns. Comment at:

[PATCH] D112791: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

yaxunl added inline comments. Comment at: llvm/include/llvm/IR/Constants.h:1317 /// would make it harder to remove ConstantExprs altogether. - Instruction *getAsInstruction() const; + Instruction *getAsInstruction(Instruction *InsertBefore = nullptr) const;

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

sammccall added a comment. To summarize what I remember from the offline discussion: - when we have multiple decls, eliminating as many as possible will reduce false negatives. - reducing false negatives isn't our top priority, so we should focus only on the most impactful/safe cases - if we

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

martong accepted this revision. martong added a comment. Herald added a subscriber: rnkovacs. Thanks @ZarkoCA, LGTM, but please address the sensible changes advised by Aaron. And thanks @aaron.ballman for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112765: [AST] injected-class-name is not a redecl, even in template specializations

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1841-1842 + /*DelayTypeCreation=*/IsInjectedClassName); + if (IsInjectedClassName) +SemaRef.Context.getTypeDeclType(Record, cast(Owner));

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

aaron.ballman added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135 StringRef ) const { - llvm::AArch64::ParsedBranchProtection PBP; - if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err)) +

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16155 + if (getLangOpts().CPlusPlusModules) { +auto *GlobalModule = +PushGlobalModuleFragment(ExternLoc, /*IsImplicit=*/true); `Module *` instead of `auto *` (the type

[PATCH] D112765: [AST] injected-class-name is not a redecl, even in template specializations

hokein added a comment. looks like https://github.com/llvm/llvm-project/blob/main/clang/include/clang/AST/RecursiveASTVisitor.h#L1684-L1686 can be simplified as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112765/new/

[PATCH] D112791: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112791/new/ https://reviews.llvm.org/D112791 ___ cfe-commits mailing list

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. oops forgot to LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112783/new/ https://reviews.llvm.org/D112783

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne added a comment. Herald added a project: Flang. If there is no plan to move forward with generating `.docx` documentation, can we please abandon this review? I'm trying to clean up libc++'s review queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

zixuan-wu added a comment. Herald added subscribers: VincentWu, luke957. Hi, @kito-cheng as your this patch unify the extension handing in one same place by new infra, are you going to support the multiple extension version in next step? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

aaron.ballman added reviewers: alexfh, tonic. aaron.ballman added a subscriber: tonic. aaron.ballman added a comment. In D112730#3095767 , @carlosgalvezp wrote: > Also, I've sent a mail to AUTOSAR directly asking for consent, so there's no > doubt.

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. > people DO incorporate clang-tidy into their own commercial offerings Gna, that //can// be a problem. I wonder if in that case it would be possible to add a few lines into the `LLVM Exceptions` part of the license. If it's too much of a hassle I guess I'll need

[PATCH] D51650: Implement target_clones multiversioning

erichkeane added a comment. In D51650#3095997 , @danielkiss wrote: > Hi @erichkeane, > > At Arm we are going to add the multiversioning support for Arm targets[1][2]. > It would be nice to land this change because we could build top of it. > Please let

[PATCH] D112791: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

foad updated this revision to Diff 383341. foad added a comment. Add comment about InsertBefore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112791/new/ https://reviews.llvm.org/D112791 Files: clang/lib/CodeGen/CGCUDANV.cpp

[PATCH] D112791: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b758925adf6: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction (authored by foad). Repository: rG LLVM Github Monorepo

[clang] 1b75892 - [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

Author: Jay Foad Date: 2021-10-29T15:02:58+01:00 New Revision: 1b758925adf6d78c89c70d2673689695e90fa993 URL: https://github.com/llvm/llvm-project/commit/1b758925adf6d78c89c70d2673689695e90fa993 DIFF: https://github.com/llvm/llvm-project/commit/1b758925adf6d78c89c70d2673689695e90fa993.diff

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus added a comment. Sure, I reverted to the previous revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus updated this revision to Diff 383293. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 Files: clang/tools/scan-build/libexec/ccc-analyzer Index: clang/tools/scan-build/libexec/ccc-analyzer

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

tambre added a comment. This breaks the following code: struct sub { char data; }; struct main { constexpr main() { member = {}; } sub member; }; constexpr main a{}; With: fmt.cpp:16:16: error: constexpr variable

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. `swift_attr` has no subjects, so this will attempt to spray the attribute onto literally *everything*. That makes this incredibly risky to use with the pragma approach

[PATCH] D112791: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

foad added inline comments. Comment at: llvm/include/llvm/IR/Constants.h:1317 /// would make it harder to remove ConstantExprs altogether. - Instruction *getAsInstruction() const; + Instruction *getAsInstruction(Instruction *InsertBefore = nullptr) const;

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

asavonic added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9573 - checkTypeSupport(NewFD->getType(), D.getBeginLoc(), NewFD); + if (D.getFunctionDefinitionKind() != FunctionDefinitionKind::Declaration) +checkTypeSupport(NewFD->getType(), D.getBeginLoc(),

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. This has changed the behavior for - // Define __complex128 type corresponding to __float128 (as in GCC headers). typedef _Complex float __attribute__((mode(TC))) __complex128; void check() { // CHECK: alloca { fp128, fp128 } <- Fails because alloca {

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. In D108696#3096822 , @Quuxplusone wrote: > In D108696#3095789 , @ChuanqiXu > wrote: > >> Since there are other `experimental/*` headers moved in to normal include >> paths, I guess

[clang] c001775 - [clang] Inclusive language: change error message to use allowlist

Author: Zarko Todorovski Date: 2021-10-29T13:12:46-04:00 New Revision: c001775a3afb124b9b19ff5a45a68d4baf130077 URL: https://github.com/llvm/llvm-project/commit/c001775a3afb124b9b19ff5a45a68d4baf130077 DIFF:

[PATCH] D112627: [clang] Inclusive language: change error message to use allowlist

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc001775a3afb: [clang] Inclusive language: change error message to use allowlist (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added a comment. Oh, yes, I think this should be preserving the old logic there and just adding a new clause for explicit requests for ibm128, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. In D107049#3096727 , @uabelho wrote: > Hi, > > We're seeing a problem with this patch in our downstream (not public) > buildbots. With an asan-built compiler we see the

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu updated this revision to Diff 383376. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110215/new/ https://reviews.llvm.org/D110215 Files: clang/include/clang/Basic/Module.h clang/include/clang/Sema/Sema.h

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers accepted this revision. nickdesaulniers added a comment. thanks again for all of the work that went into this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 ___ cfe-commits mailing

[PATCH] D112835: [clangd] Record time spent in tidy checks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I think this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111477/new/ https://reviews.llvm.org/D111477

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9573 - checkTypeSupport(NewFD->getType(), D.getBeginLoc(), NewFD); + if (D.getFunctionDefinitionKind() != FunctionDefinitionKind::Declaration) +checkTypeSupport(NewFD->getType(), D.getBeginLoc(),

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

ZarkoCA marked 6 inline comments as done. ZarkoCA added a comment. In D112642#3093559 , @aaron.ballman wrote: > Thank you for this! Mostly just bikeshedding on names (allowlist as a verb > sounds weird to me), feel free to take or leave the

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu marked 7 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:722-723 +void Sema::PopGlobalModuleFragment() { + assert(!ModuleScopes.empty() && getCurrentModule().isGlobalModule() && + "left the wrong module

[clang-tools-extra] f47564e - [clangd] IncludeCleaner: Skip non self-contained headers

Author: Kirill Bobyrev Date: 2021-10-29T17:57:31+02:00 New Revision: f47564ea87a502f5fc6320ba5b57e91186751b12 URL: https://github.com/llvm/llvm-project/commit/f47564ea87a502f5fc6320ba5b57e91186751b12 DIFF:

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf47564ea87a5: [clangd] IncludeCleaner: Skip non self-contained headers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 72c3736 - [OpenMP] Add triple to run lines to avoid message differences

Author: Mike Rice Date: 2021-10-29T09:20:40-07:00 New Revision: 72c373644fc397e9443200865b58514a3d6cf69d URL: https://github.com/llvm/llvm-project/commit/72c373644fc397e9443200865b58514a3d6cf69d DIFF: https://github.com/llvm/llvm-project/commit/72c373644fc397e9443200865b58514a3d6cf69d.diff

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov updated this revision to Diff 383396. ASDenysPetrov added a comment. - Added support of aliased types. - Added tests aliased types. - Added tests with initialization values in parentheses. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111654/new/

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 383406. keith added a comment. Remove broken test for now Turns out this fails on main as well, so I'll punt this to another change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @dexonsmith turns out the test I was adding is broken on main today too. If it's alright with you I will punt that to another diff to not increase the scope of this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. In D112730#3097091 , @tstellar wrote: > @carlosgalvezp Did you write this patch or did you get it from someone else? @tstellar I wrote it myself (following the existing pattern for the other modules in the llvm-project

[PATCH] D112835: [clangd] Record time spent in tidy checks

sammccall added a comment. My only concern with this is the overhead of the timing itself. We look up the hash bucket, turn timers on/off... If I'm understanding right we do this once per AST node per registered matcher. Are you able to see any performance difference with this tracing on vs

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. Hi, We're seeing a problem with this patch in our downstream (not public) buildbots. With an asan-built compiler we see the following: 10:08:55 FAIL: Clang-Unit :: Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests/InterpreterTest.CatchException (25832

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

ZarkoCA updated this revision to Diff 383359. ZarkoCA added a comment. - Fix formatting and change variable names to make better grammatical sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112642/new/ https://reviews.llvm.org/D112642 Files:

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

asavonic added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9573 - checkTypeSupport(NewFD->getType(), D.getBeginLoc(), NewFD); + if (D.getFunctionDefinitionKind() != FunctionDefinitionKind::Declaration) +checkTypeSupport(NewFD->getType(), D.getBeginLoc(),

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383378. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files:

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb updated this revision to Diff 383390. ardb edited the summary of this revision. ardb added a comment. - split off LOAD_STACK_GUARD conversion - deal with guard offsets >= 4096 bytes - reject offsets < 0 or >= 1 MiB - add backend test to check that the MRC/LDR sequence is emitted twice

[PATCH] D112767: [clang][driver] Fix multiarch output name with -Wl arg

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8a9507ef8c: [clang][driver] Fix multiarch output name with -Wl arg (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112767/new/

[PATCH] D112765: [AST] injected-class-name is not a redecl, even in template specializations

sammccall updated this revision to Diff 383351. sammccall added a comment. Add a comment, remove some unneccesary special cases from traversals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112765/new/ https://reviews.llvm.org/D112765 Files:

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:250 if (!MFI.HeaderID) { elog("File {0} not found.", MFI.Written); continue;

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

Quuxplusone added a comment. In D108696#3095789 , @ChuanqiXu wrote: > Since there are other `experimental/*` headers moved in to normal include > paths, I guess there may be similar problems before. I think this problem is > not limited in coroutine.

[PATCH] D112765: [AST] injected-class-name is not a redecl, even in template specializations

sammccall added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1841-1842 + /*DelayTypeCreation=*/IsInjectedClassName); + if (IsInjectedClassName) +SemaRef.Context.getTypeDeclType(Record, cast(Owner));

[PATCH] D112491: Add `LambdaCapture`-related matchers.

sammccall added a comment. This looks really sensible to me too. Some naming bikeshedding, but my main question is migration. Supporting two things is indeed annoying and confusing. I agree it's not worth keeping the old way forever just to avoid writing `refersToVarDecl`. The question is: how

[clang] 1deccd0 - [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

Author: Denys Petrov Date: 2021-10-29T19:44:37+03:00 New Revision: 1deccd05ba8a326e57a513002f482ed0924b1fd8 URL: https://github.com/llvm/llvm-project/commit/1deccd05ba8a326e57a513002f482ed0924b1fd8 DIFF: https://github.com/llvm/llvm-project/commit/1deccd05ba8a326e57a513002f482ed0924b1fd8.diff

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1deccd05ba8a: [analyzer] Retrieve a character from StringLiteral as an initializer for… (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. @carlosgalvezp Did you write this patch or did you get it from someone else? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730

[clang] bd8a950 - [clang][driver] Fix multiarch output name with -Wl arg

Author: Keith Smiley Date: 2021-10-29T10:09:38-07:00 New Revision: bd8a9507ef8c3a493c15828f7f2fbc241a9e5c93 URL: https://github.com/llvm/llvm-project/commit/bd8a9507ef8c3a493c15828f7f2fbc241a9e5c93 DIFF: https://github.com/llvm/llvm-project/commit/bd8a9507ef8c3a493c15828f7f2fbc241a9e5c93.diff

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

rnk added a comment. In D8467#3095610 , @zixuan-wu wrote: > Hi, I am wondering could -fsized-deallocation this be enabled by default > nowadays in 2021? Yes, I think so. This should be a matter of adjusting the default in the driver. We should not bring

[PATCH] D109402: Make 'align-mismatch' warning work without an associated function declaration

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109402/new/ https://reviews.llvm.org/D109402 ___

[PATCH] D112289: Support: Use sys::path::is_style_{posix,windows}() in a few places

dexonsmith updated this revision to Diff 383446. dexonsmith edited the summary of this revision. dexonsmith added a comment. Squashed in the changes from https://reviews.llvm.org/D112786. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112289/new/ https://reviews.llvm.org/D112289 Files:

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 updated this revision to Diff 383458. jcking1034 marked 2 inline comments as done. jcking1034 added a comment. Update matcher names for clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. In D109950#3097161 , @rjmccall wrote: > Oh, yes, I think this should be preserving the old logic there and just > adding a new clause for explicit requests for ibm128, right? I think the old logic should be preserved yes.

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added a comment. In D109950#3097544 , @eandrews wrote: > In D109950#3097161 , @rjmccall > wrote: > >> Oh, yes, I think this should be preserving the old logic there and just >> adding a new clause for

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112642/new/ https://reviews.llvm.org/D112642 ___ cfe-commits mailing list

[PATCH] D112765: [AST] injected-class-name is not a redecl, even in template specializations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the cast request, this LGTM, thank you! Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1841-1842 +

[PATCH] D112765: [AST] injected-class-name is not a redecl, even in template specializations

hokein accepted this revision. hokein added a comment. looks good, thanks. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1685 - // We don't want to visit injected-class-names in this traversal. - if (cast(RD)->isInjectedClassName()) -continue;

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ddpagan updated this revision to Diff 383428. ddpagan added a comment. Thanks for the review, Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112577/new/ https://reviews.llvm.org/D112577 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D112664: [clang-format][docs] fix indentation of rst code block

HazardyKnusperkeks added a comment. Hi, thanks for you contribution. But the `rst` is generated by a script, the error is in `Format.h`. And we already have a review for an even broader fix: D112572 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ddpagan added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:362-364 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + aaron.ballman wrote: > ABataev wrote: > > Also worth to make it private > I

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

dblaikie added a comment. In D99#3096124 , @aaron.ballman wrote: > In D99#3095623 , @yonghong-song > wrote: > >>> Ah, yeah, I see what you mean - that does seem sort of unfortunate. Is it >>> possible

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

nickdesaulniers added a comment. Codegen looks good, probably just need an additional conditional on `ARMSubtarget::isReadTPHard()`. With that and some more tests for cases we don't intend to support (thumb[1], soft tp) this LGTM. Great job @ardb ! Comment at:

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

aaron.ballman added a comment. Thank you for this! I have some concerns that I'd like to talk out to hopefully make myself feel more comfortable with this. My understanding of the utility from -Wformat warnings comes from the fact that the function receiving the format string has no way to

[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

rsmith added a comment. I think this is still not quite right: if the `ObjCObjectPointerType` has a valid star location, we should use that. We should only be falling back on the inner location's end when there is no star. For example: @interface X @end; using ObjectPointer = X*; ...

[clang] 9902362 - Support: Use sys::path::is_style_{posix, windows}() in a few places

Author: Duncan P. N. Exon Smith Date: 2021-10-29T12:09:41-07:00 New Revision: 99023627010bbfefb71e25a2b4d056de1cbd354e URL: https://github.com/llvm/llvm-project/commit/99023627010bbfefb71e25a2b4d056de1cbd354e DIFF:

[PATCH] D112289: Support: Use sys::path::is_style_{posix,windows}() in a few places

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99023627010b: Support: Use sys::path::is_style_{posix,windows}() in a few places (authored by dexonsmith). Repository: rG LLVM Github Monorepo

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4652 +/// matches `[this]() { return cc; }`. +AST_MATCHER(LambdaCapture, refersToThis) { return Node.capturesThis(); } + sammccall wrote: > Again, why `refersToThis`

[clang] 68ffcd5 - Properly determine the end location of an ObjCObjectPointerType.

Author: Richard Smith Date: 2021-10-29T13:15:53-07:00 New Revision: 68ffcd521347e3c8b97ca233239d503beff239f4 URL: https://github.com/llvm/llvm-project/commit/68ffcd521347e3c8b97ca233239d503beff239f4 DIFF: https://github.com/llvm/llvm-project/commit/68ffcd521347e3c8b97ca233239d503beff239f4.diff

[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

rsmith added a comment. In D112101#3097387 , @rsmith wrote: > I think this is still not quite right Fixed in rG68ffcd521347e3c8b97ca233239d503beff239f4 . Repository: rG LLVM

[PATCH] D112572: [docs][clang-format] warn on \code block indentation error

HazardyKnusperkeks added a comment. In D112572#3089373 , @FederAndInk wrote: > In D112572#3089318 , > @HazardyKnusperkeks wrote: > >> Thanks for fixing my mistake. :) > > You're welcome ;) > > Thanks for your

[clang] a43d1aa - [clang] Make 'align-mismatch' warning work without an associated function declaration

Author: Alex Lorenz Date: 2021-10-29T13:39:16-07:00 New Revision: a43d1aa8525649a64b1f0ed5a5c25718c28920c1 URL: https://github.com/llvm/llvm-project/commit/a43d1aa8525649a64b1f0ed5a5c25718c28920c1 DIFF: https://github.com/llvm/llvm-project/commit/a43d1aa8525649a64b1f0ed5a5c25718c28920c1.diff

[PATCH] D109402: Make 'align-mismatch' warning work without an associated function declaration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa43d1aa85256: [clang] Make align-mismatch warning work without an associated function… (authored by arphaman). Herald added a project: clang.

[clang] 8659b24 - [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

Author: Zarko Todorovski Date: 2021-10-29T16:51:36-04:00 New Revision: 8659b241ae945632e2a1c3294073d0fdeacfdbde URL: https://github.com/llvm/llvm-project/commit/8659b241ae945632e2a1c3294073d0fdeacfdbde DIFF:

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rG8659b241ae94: [clang][NFC] Inclusive terms: Replace uses of whitelist in… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112642/new/

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA created this revision. ZarkoCA added reviewers: rzurob, cebowleratibm, sfertile. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Correct the XLC/C++ version in the warning message to use the information from XL's -qversion

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

Quuxplusone added a comment. In D112579#3097360 , @aaron.ballman wrote: > [...] Having the types in the signatures changes something I think might be > pretty fundamental to the way the format string checker works -- it tries to > figure out types

[clang] 9091df5 - Fix a use-after-scope from 99023627010bbfefb71e25a2b4d056de1cbd354e

Author: Duncan P. N. Exon Smith Date: 2021-10-29T16:25:13-07:00 New Revision: 9091df5fad52ab6a281d7f4d6a508696e6f9fbae URL: https://github.com/llvm/llvm-project/commit/9091df5fad52ab6a281d7f4d6a508696e6f9fbae DIFF:

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383536. kstoimenov marked 2 inline comments as done. kstoimenov added a comment. Fixed test failures and crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732

  1   2   >