[clang] 190bde4 - Revert "Making the code compliant to the documentation about Floating Point"

Author: Aaron Ballman Date: 2021-11-08T11:43:49-05:00 New Revision: 190bde404c67527c0a15b1ccbcb5af025aadcdd7 URL: https://github.com/llvm/llvm-project/commit/190bde404c67527c0a15b1ccbcb5af025aadcdd7 DIFF: https://github.com/llvm/llvm-project/commit/190bde404c67527c0a15b1ccbcb5af025aadcdd7.diff

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-stringview-nullptr.cpp:84 + +(void)(std::string_view({nullptr})) /* a3 */; +// CHECK-MESSAGES: :[[@LINE-1]]:29: warning: constructing basic_string_view from null is

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385532. CJ-Johnson added a comment. Rebase on head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D113264: [clang] [DirectoryWatcher] Remove leading \\?\ from GetFinalPathNameByHandleW

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though I'd appreciate if you'd fix the clang-format issues when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8d3b28e - [NFC] Fix lit test failures for clang/CodegenCoroutines

Author: hyeongyu kim Date: 2021-11-09T02:47:16+09:00 New Revision: 8d3b28e7547aac842ed177050ac2a9d25de0f2e9 URL: https://github.com/llvm/llvm-project/commit/8d3b28e7547aac842ed177050ac2a9d25de0f2e9 DIFF: https://github.com/llvm/llvm-project/commit/8d3b28e7547aac842ed177050ac2a9d25de0f2e9.diff

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D113249#3113666 , @carlosgalvezp wrote: >> - The driver needs to enable ptx75 when it constructs cc1 command line in >>

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar added a comment. @carlosgalvezp The LLVM Foundation Board will conduct a legal reivew of this patch. Would you be able to share any information you have about the license or usage restrictions for the AUTOSAR specification? CHANGES SINCE LAST ACTION

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385575. CJ-Johnson added a comment. Add additional tests for sv.empty() cases to ensure parens are removed where appropriate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

thakis added a comment. This fixes tests on macOS, but I don't know if the space is there intentionally to check for presence of any attributes: % git diff diff --git a/clang/test/CodeGen/ffp-contract-option.c b/clang/test/CodeGen/ffp-contract-option.c index 04d23d5f90b7..327722f56f4e

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl added a comment. @tra Any further concerns? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov added a comment. Ping. Does anyone know how to check the status of`-fno-strict-aliasing` flag from CSA side? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110927/new/ https://reviews.llvm.org/D110927 ___ cfe-commits mailing

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385530. CJ-Johnson added a comment. Add AST matcher support and tests for {{}} case where a null pointer is implicitly created Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/

[PATCH] D112890: headers: optionalise some generated resource headers

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ https://reviews.llvm.org/D112890

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

JonChesterfield added a comment. Example of the function as opposed to intrinsics is __kmpc_get_hardware_num_threads_in_block from just above where you've modified. That corresponds to a function in the device runtime, e.g. int __kmpc_get_hardware_num_threads_in_block() { return

[PATCH] D113269: [clang-move] Fix unit tests with forward slash as separator on windows

mstorsjo added inline comments. Comment at: clang-tools-extra/unittests/clang-move/ClangMoveTests.cpp:235 - // std::string IncludeArg = Twine("-I" + WorkingDir; + // std::string IncludeArg = Twine("-I" + Dir; tooling::runToolOnCodeWithArgs( aaron.ballman

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks updated this revision to Diff 385594. HazardyKnusperkeks added a comment. Now the new diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 Files:

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385505. JonChesterfield added a comment. - rebase, static functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1845 + if (auto *Call = dyn_cast(U)) +FAM.invalidate(*Call->getParent()->getParent(), FuncPA); +} nikic wrote: > Do we need to worry about indirect references

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks added a comment. In D113304#3112937 , @nikic wrote: > I don't think I fully understand the interaction this has with eager > invalidation. I would have expected that if we eagerly invalidate, then this > fine-grained invalidation wouldn't make

[PATCH] D112491: Add `LambdaCapture`-related matchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. This continues to LGTM, thank you for it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

tianshilei1992 added a comment. I remember at some point we want to just emit function call to get those information like thread id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421

[clang-tools-extra] 16b07c8 - [clang-tidy] Add check for initialization of `absl::Cleanup`.

Author: CJ Johnson Date: 2021-11-08T15:57:32Z New Revision: 16b07c866ae74e0d02038574fe1c37a6cb55e233 URL: https://github.com/llvm/llvm-project/commit/16b07c866ae74e0d02038574fe1c37a6cb55e233 DIFF: https://github.com/llvm/llvm-project/commit/16b07c866ae74e0d02038574fe1c37a6cb55e233.diff LOG:

[PATCH] D113195: [clang-tidy] Add check for initialization of `absl::Cleanup`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG16b07c866ae7: [clang-tidy] Add check for initialization of `absl::Cleanup`. (authored by CJ-Johnson, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3115814 , @erichkeane wrote: > Either this or D108453 (which were > committed together!) caused this assert according to my git-bisect: > https://godbolt.org/z/4rqYKfW7K > >

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385531. CJ-Johnson added a comment. Add missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks updated this revision to Diff 385539. aeubanks added a comment. address comments [argpromo] only invalidate direct callers that call the function, not if the function is a parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

rjmccall added a comment. Hmm. I wonder if that's related to the problem uncovered by the verifier in https://reviews.llvm.org/D113352. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105169/new/ https://reviews.llvm.org/D105169

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 385551. mbenfield added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.org/D112024 Files: clang/include/clang/Basic/Attr.td

[PATCH] D112504: [OpenMP] Wrap (v)printf in the new RT and use same handling for AMD

jdoerfert closed this revision. jdoerfert added a comment. Committed as part of D112680 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112504/new/ https://reviews.llvm.org/D112504

[clang] 2ca6fc3 - [clang] [DirectoryWatcher] Remove leading \\?\ from GetFinalPathNameByHandleW

Author: Martin Storsjö Date: 2021-11-08T22:21:30+02:00 New Revision: 2ca6fc34fc08eaadb0f287a7f1b33bc1de4d1bd6 URL: https://github.com/llvm/llvm-project/commit/2ca6fc34fc08eaadb0f287a7f1b33bc1de4d1bd6 DIFF:

[clang-tools-extra] 98f0bf7 - [clang-move] Fix unit tests with forward slash as separator on windows

Author: Martin Storsjö Date: 2021-11-08T22:21:31+02:00 New Revision: 98f0bf74ca6d7aa9b3c2b240693824f085aa6675 URL: https://github.com/llvm/llvm-project/commit/98f0bf74ca6d7aa9b3c2b240693824f085aa6675 DIFF:

[PATCH] D113264: [clang] [DirectoryWatcher] Remove leading \\?\ from GetFinalPathNameByHandleW

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ca6fc34fc08: [clang] [DirectoryWatcher] Remove leading \\?\ from GetFinalPathNameByHandleW (authored by mstorsjo). Changed prior to commit:

[PATCH] D113269: [clang-move] Fix unit tests with forward slash as separator on windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98f0bf74ca6d: [clang-move] Fix unit tests with forward slash as separator on windows (authored by mstorsjo). Changed prior to commit:

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone updated this revision to Diff 385508. davidstone added a comment. Take into account Richard's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 Files:

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385512. JonChesterfield added a comment. - helper for nonscalars Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385525. JonChesterfield added a comment. - fold nvptx and openmp printf into one call - Drop ReturnValue argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/

[PATCH] D112890: headers: optionalise some generated resource headers

compnerd added a comment. @craig.topper - ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ https://reviews.llvm.org/D112890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 added a comment. @aaron.ballman Just wanted to confirm with you that the work here and release notes look good and can be wrapped up so that I can have @ymandel submit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 385564. lichray added a comment. Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

MaskRay added a comment. In D112868#3105942 , @aaron.ballman wrote: > One thing that surprises me is that the test changes are in Sema but the code > changes are in CodeGen. I see that this test actually emits LLVM IR. Should > it be moved (as an NFC

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

jdoerfert added a comment. In D113421#3116155 , @tianshilei1992 wrote: > I remember at some point we want to just emit function call to get those > information like thread id. Yes, no intrinsics please. Add `__kmpc_get_warp_size` and similar functions

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeVirtualGPU.cpp:54 + CGOpenMPRuntime::createOffloadEntry(ID, Addr, Size, Flags, Linkage); +} We should be able to get rid of this file (and the cuda/hip) version. Might be the right

[PATCH] D113269: [clang-move] Fix unit tests with forward slash as separator on windows

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from commenting nit. Comment at: clang-tools-extra/unittests/clang-move/ClangMoveTests.cpp:235 - // std::string IncludeArg = Twine("-I" +

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

ibookstein updated this revision to Diff 385541. ibookstein added a comment. clang-format + fastforward rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/ https://reviews.llvm.org/D112868 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, JonChesterfield, tianshilei1992. Herald added subscribers: asavonic, guansong, yaxunl, mgorny, jvesely, jholewinski. atmnpatel requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

carlosgalvezp created this revision. carlosgalvezp added reviewers: aaron.ballman, whisperity. Herald added subscribers: rnkovacs, xazax.hun. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently it's hidden

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Folded EmitOpenMPDevicePrintfCallExpr and EmitNVPTXDevicePrintfCallExpr into asserts plus one line call into a common function. Leaving amdgpu alone in this patch as it's doing something odd with getScalarVal and I don't want to run this through the internal CI

[clang] 2db66f8 - [clang] Fortify warning for scanf calls with field width too big.

Author: Michael Benfield Date: 2021-11-08T17:43:51Z New Revision: 2db66f8d48beeea835cb9a6940e25bc04ab5d941 URL: https://github.com/llvm/llvm-project/commit/2db66f8d48beeea835cb9a6940e25bc04ab5d941 DIFF: https://github.com/llvm/llvm-project/commit/2db66f8d48beeea835cb9a6940e25bc04ab5d941.diff

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2db66f8d48be: [clang] Fortify warning for scanf calls with field width too big. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

tra added a comment. I'll defer to @eugenis. Overall it looks OK to be. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] c0b298f - Add `LambdaCapture`-related matchers.

Author: James King Date: 2021-11-08T18:50:54Z New Revision: c0b298fc213c1b33e97ca72fba58597365375875 URL: https://github.com/llvm/llvm-project/commit/c0b298fc213c1b33e97ca72fba58597365375875 DIFF: https://github.com/llvm/llvm-project/commit/c0b298fc213c1b33e97ca72fba58597365375875.diff LOG:

[PATCH] D112491: Add `LambdaCapture`-related matchers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0b298fc213c: Add `LambdaCapture`-related matchers. (authored by jcking1034, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113319: [clang-format] Improve require handling

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added a comment. In D113319#3115202 , @MyDeveloperDay wrote: > I feel anything you do here would be an improvement. its probably worth > looking at recent issues logged around this

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a subscriber: ronlieb. JonChesterfield added a comment. Updated. Left Builder.CreateCall alone as I've failed to think of a clean way to handle the sometimes present size argument. Tests pass locally and are a credible guess at what will pass the CI bot, but may need to

Re: [clang] 438437c - Making the code compliant to the documentation about Floating Point

FWIW, I reverted this in 190bde404c67527c0a15b1ccbcb5af025aadcdd7 as it didn't fix the bots fully. ~Aaron On Mon, Nov 8, 2021 at 8:35 AM Zahira Ammarguellat via cfe-commits wrote: > > > Author: Zahira Ammarguellat > Date: 2021-11-08T08:35:19-05:00 > New Revision:

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

erichkeane added a comment. Either this or D108453 (which were committed together!) caused this assert according to my git-bisect: https://godbolt.org/z/4rqYKfW7K NOTE that this fails in a lit-test for me, clang CodeGen/ifunc.c (though my downstream seems to

[clang] db81d8f - [OpenMP] Lower printf to __llvm_omp_vprintf

Author: Jon Chesterfield Date: 2021-11-08T18:38:00Z New Revision: db81d8f6c4d6c4f8dfaa036d6959528c9f14e7d7 URL: https://github.com/llvm/llvm-project/commit/db81d8f6c4d6c4f8dfaa036d6959528c9f14e7d7 DIFF: https://github.com/llvm/llvm-project/commit/db81d8f6c4d6c4f8dfaa036d6959528c9f14e7d7.diff

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb81d8f6c4d6: [OpenMP] Lower printf to __llvm_omp_vprintf (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d398e8f - [ASTMatcher] Provide a definition for the lambdaCapture matcher

Author: Benjamin Kramer Date: 2021-11-08T20:26:37+01:00 New Revision: d398e8f170fa9b11a13707b8ccc2a278653d374b URL: https://github.com/llvm/llvm-project/commit/d398e8f170fa9b11a13707b8ccc2a278653d374b DIFF:

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks updated this revision to Diff 385588. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + curdeius

[clang] 0fa45d6 - Revert "[OpenMP] Lower printf to __llvm_omp_vprintf"

Author: Jon Chesterfield Date: 2021-11-08T20:28:57Z New Revision: 0fa45d6d8067d71a8dccac7d942c53b5fd80e499 URL: https://github.com/llvm/llvm-project/commit/0fa45d6d8067d71a8dccac7d942c53b5fd80e499 DIFF: https://github.com/llvm/llvm-project/commit/0fa45d6d8067d71a8dccac7d942c53b5fd80e499.diff

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. This passed the openmp buildbot but failed some others, e.g. clang-armv7-quick/llvm/clang/test/OpenMP/nvptx_target_printf_codegen.c:64:19: error: CHECK-64-NEXT: expected string not found in input // CHECK-64-NEXT: [[TMP6:%.*]] = call i32 @vprintf(i8*

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385611. atmnpatel added a comment. Herald added projects: OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits. Updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/

[clang] bf22593 - [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

Author: Michael Liao Date: 2021-11-08T16:51:57-05:00 New Revision: bf225939bc3acf936c962f24423d3bb5ddd4c93f URL: https://github.com/llvm/llvm-project/commit/bf225939bc3acf936c962f24423d3bb5ddd4c93f DIFF: https://github.com/llvm/llvm-project/commit/bf225939bc3acf936c962f24423d3bb5ddd4c93f.diff

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf225939bc3a: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates. (authored by hliao). Repository: rG LLVM Github Monorepo

[PATCH] D113435: [Clang][Emscripten]: Don't default to -fvisibility=hidden

sbc100 created this revision. Herald added subscribers: wingo, sunfish, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Emscripten wants `-fvisibility=default` by default. See:

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

mtrofin added inline comments. Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:1017 +// invalidate analyses for all functions in this SCC later. +FAM.invalidate(F, PreservedAnalyses::none()); } Should we do this if !Changed? Actually, if this function

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks added inline comments. Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:1017 +// invalidate analyses for all functions in this SCC later. +FAM.invalidate(F, PreservedAnalyses::none()); } mtrofin wrote: > Should we do this if !Changed?

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. > To me the 'not in the weeds' part is, "How do I get CPU-dispatch/CPU-specific > to work without RAUW, since that is offensive to the CFE code owner? > Additionally, I found that some of the examples without the defined resolver > actually DO work in my

[PATCH] D113429: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check

fwolff created this revision. fwolff added reviewers: simon.giesecke, alexfh, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52217.

[PATCH] D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113428 Files: clang/test/Sema/wchar.c Index: clang/test/Sema/wchar.c

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385614. JonChesterfield added a comment. - ./llvm/utils/update_cc_test_checks.py clang/test/OpenMP/nvptx_target_printf_codegen.c --opt=$HOME/llvm-install/bin/opt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111860: [modules] Update visibility for merged ObjCProtocolDecl definitions.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111860/new/ https://reviews.llvm.org/D111860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

JonChesterfield accepted this revision. JonChesterfield added a comment. Thanks! Delighted to see the subclasses gone Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 385636. vaibhav.y added a comment. Format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

asbirlea added a comment. Thank you for the additional clarifications in the comments and descriptions! The invalidations are essentially postponed until after the function simplification pipeline with this patch. Before, everything was invalidated in the SCC pass even if only one function was

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:23 #include "llvm/Frontend/OpenMP/OMPGridValues.h" +#include "llvm/IR/IntrinsicsAMDGPU.h" #include

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385615. atmnpatel added a comment. Remove intrinsic includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab added inline comments. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in { +def fptrauth_intrinsics : Flag<["-"], "fptrauth-intrinsics">, + HelpText<"Enable pointer-authentication intrinsics">; + } +

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nathanchance added a comment. Prior to the latest revert (fd9b099906c61e46574d1ea2d99b973321fe1d21 ), the Linux kernel's binary verifier (`objtool`) points out an issue when building with ThinLTO and

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 385634. vaibhav.y added a comment. Add `Closed` to signal if document is writable Introduce a flag `Closed` to `clang::SarifDocumentWriter` that tracks if the underlying sarif document is accepting results to record. i.e. it is in the middle of an

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385635. CJ-Johnson added a comment. Add missing test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers

ibookstein updated this revision to Diff 385606. ibookstein added a comment. move test from Sema to CodeGen (trying to make arcanist send multiple separate commits..?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

JonChesterfield added a comment. I think __kmpc_get_warp_size needs an entry in Utils.cpp keepAlive(), and corresponding functions added to `deviceRTLs/*/src/target_impl.*` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/

[clang] 7ad693a - [modules] Update visibility for merged ObjCProtocolDecl definitions.

Author: Volodymyr Sapsai Date: 2021-11-08T13:54:00-08:00 New Revision: 7ad693a322c1b6765f5d06559c2bd73cc3938aaf URL: https://github.com/llvm/llvm-project/commit/7ad693a322c1b6765f5d06559c2bd73cc3938aaf DIFF:

[PATCH] D111860: [modules] Update visibility for merged ObjCProtocolDecl definitions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ad693a322c1: [modules] Update visibility for merged ObjCProtocolDecl definitions. (authored by vsapsai). Repository: rG LLVM Github Monorepo

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. Who is the Clang CFE maintainer that we need to involve? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112349/new/ https://reviews.llvm.org/D112349 ___ cfe-commits mailing

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. In D112349#3116726 , @ibookstein wrote: > Who is the Clang CFE maintainer that we need to involve? Richard Smith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112349/new/

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks updated this revision to Diff 385642. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113304/new/ https://reviews.llvm.org/D113304 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

Conanap added a comment. Hello, looks like this commit might be causing some failures on PowerPC buildbots, would you be able to take a quick look? Failing test case is `Clang :: OpenMP/nvptx_target_printf_codegen.c`. Buildbot link:

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. In D112349#3116457 , @ibookstein wrote: >> To me the 'not in the weeds' part is, "How do I get >> CPU-dispatch/CPU-specific to work without RAUW, since that is offensive to >> the CFE code owner? Additionally, I found that

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

Conanap added a comment. thanks for reverting! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 385609. vaibhav.y added a comment. Summary of changes: - [clangBasic] Fix SIGSEGV in Sarif builders - [clangBasic] Fixup documentation typo, add explicit type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385626. atmnpatel added a comment. Yep yep. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp

[PATCH] D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers

ibookstein updated this revision to Diff 385603. ibookstein retitled this revision from "[Sema] Diagnose and reject non-function ifunc resolvers" to "[CodeGen] Diagnose and reject non-function ifunc resolvers". ibookstein added a comment. move attr-ifunc.c test to codegen Repository: rG

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385627. atmnpatel added a comment. small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

ibookstein created this revision. ibookstein published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Itay Bookstein Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113431 Files:

[PATCH] D113433: [NFC][clang] Inclusive language: Rename myMaster in testcase

quinnp created this revision. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch replaces `_myMaster` with `_myLeader` in these testcases. Repository: rG

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

tianshilei1992 accepted this revision. tianshilei1992 added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 ___ cfe-commits mailing list

  1   2   >